Commit Graph

10382 Commits

Author SHA1 Message Date
Phenom
3592d5bf5d Fix GCC warnings: unused parameter ‘names’
/libretroshare/src/pqi/pqiservice.h:80: warning: unused parameter
‘names’ [-Wunused-parameter]
     virtual void getItemNames(std::map<uint8_t,std::string>& names)
const {} // This does nothing by default. Service should derive it in
order to give info for the UI
                                                              ^~~~~
2017-04-25 09:53:06 +02:00
Phenom
593c0cb7e6 Fix CSA warnings: Called C++ object pointer is null
Logic error: Called C++ object pointer is null
 1: Null pointer value stored to field 'mInternalTokenQueue' in /home/
phenom/GIT/RetroShare/trunk/retroshare-gui/src/gui/gxs/
GxsGroupDialog.cpp:70
 2: Calling 'GxsGroupDialog::init' in /home/phenom/GIT/RetroShare/trunk/
retroshare-gui/src/gui/gxs/GxsGroupDialog.cpp:72
 3: Calling 'GxsGroupDialog::initMode' in /home/phenom/GIT/RetroShare/
trunk/retroshare-gui/src/gui/gxs/GxsGroupDialog.cpp:136
 4: Calling 'GxsGroupDialog::requestGroup' in /home/phenom/GIT/
RetroShare/trunk/retroshare-gui/src/gui/gxs/GxsGroupDialog.cpp:190
 5: Called C++ object pointer is null in /home/phenom/GIT/RetroShare/
trunk/retroshare-gui/src/gui/gxs/GxsGroupDialog.cpp:866
2017-04-25 09:52:43 +02:00
Phenom
90aaace69c Fix CSA warnings: Called C++ object pointer is null
Logic error: Called C++ object pointer is null
 1: Value assigned to field 'mMainAction' in /home/phenom/GIT/
RetroShare/trunk/retroshare-gui/src/gui/common/UserNotify.cpp:94
 2: Assuming pointer value is null in /home/phenom/GIT/RetroShare/trunk/
retroshare-gui/src/gui/common/UserNotify.cpp:95
 3: Called C++ object pointer is null in /home/phenom/GIT/RetroShare/
trunk/retroshare-gui/src/gui/common/UserNotify.cpp:103
2017-04-25 09:52:01 +02:00
Phenom
1f16f46aad Fix CSA warnings: Called C++ object pointer is null
Logic error: Called C++ object pointer is null
 1: Assuming pointer value is null in /home/phenom/GIT/RetroShare/trunk/
retroshare-gui/src/gui/common/MimeTextEdit.cpp:65
 2: Called C++ object pointer is null in /home/phenom/GIT/RetroShare/
trunk/retroshare-gui/src/gui/common/MimeTextEdit.cpp:83
2017-04-25 09:51:08 +02:00
Phenom
30632dcfeb Fix CSA warnings: Called C++ object pointer is null
Logic error: Called C++ object pointer is null
 1: Calling 'MainWindow::createNotifyIcons' in /home/phenom/GIT/
RetroShare/trunk/retroshare-gui/src/gui/MainWindow.cpp:291
 2: Loop body executed 0 times in /home/phenom/GIT/RetroShare/trunk/
retroshare-gui/src/gui/MainWindow.cpp:600
 3: Calling 'MainWindow::updateTrayCombine' in /home/phenom/GIT/
RetroShare/trunk/retroshare-gui/src/gui/MainWindow.cpp:605
 4: Value assigned to field 'notifyMenu' in /home/phenom/GIT/RetroShare/
trunk/retroshare-gui/src/gui/MainWindow.cpp:654
 5: Assuming pointer value is null in /home/phenom/GIT/RetroShare/trunk/
retroshare-gui/src/gui/MainWindow.cpp:658
 6: Called C++ object pointer is null in /home/phenom/GIT/RetroShare/
trunk/retroshare-gui/src/gui/MainWindow.cpp:679
2017-04-25 09:50:14 +02:00
Phenom
90cd6233d8 Fix CAS warnings: Potential leak of memory pointed to by 'toaster'
Memory Error: Memory leak: Potential leak of memory pointed to by
'toaster'
 1: Memory is allocated in /home/phenom/GIT/RetroShare/trunk/plugins/
VOIP/gui/VOIPToasterNotify.cpp:182
2017-04-25 09:49:40 +02:00
Phenom
b2b7d004cd Fix CSA warnings: Called C++ object pointer is null
Logic error: Called C++ object pointer is null
 1: 'di' initialized here in /home/phenom/GIT/RetroShare/trunk/plugins/
VOIP/gui/VOIPGUIHandler.cpp:157
 2: Assuming 'di' is null in /home/phenom/GIT/RetroShare/trunk/plugins/
VOIP/gui/VOIPGUIHandler.cpp:158
 3: Called C++ object pointer is null in /home/phenom/GIT/RetroShare/
trunk/plugins/VOIP/gui/VOIPGUIHandler.cpp:161
2017-04-25 09:48:48 +02:00
Phenom
ff1908eda6 Fix Clang Static Analyser: Undefined allocation of 0 bytes
Unix API: Undefined allocation of 0 bytes (CERT MEM04-C; CWE-131): Call
to 'malloc' has an allocation size of 0 bytes
 1: Loop body executed 0 times in /home/phenom/GIT/RetroShare/trunk/
libbitdht/src/util/bdbloom.cc:223
 2: Calling 'bloomFilter::getFilter' in /home/phenom/GIT/RetroShare/
trunk/libbitdht/src/util/bdbloom.cc:240
 3: 'bytes' initialized to 0 in /home/phenom/GIT/RetroShare/trunk/
libbitdht/src/util/bdbloom.cc:141
 4: Call to 'malloc' has an allocation size of 0 bytes in /home/phenom/
GIT/RetroShare/trunk/libbitdht/src/util/bdbloom.cc:148
2017-04-25 09:47:10 +02:00
Phenom
f22dc0f0df Fix Clang warnings: unused variable 'action'
warning: unused variable 'action' [-Wunused-variable]
                                QAction *action = contextMenu-
>addAction(QIcon(":/images/chat_24.png"),tr("Copy identity to
clipboard"),this,SLOT(copyRetroshareLink())) ;
2017-04-25 09:45:57 +02:00
Phenom
490f8d2f54 Fix Clang warnings: 'TYPE_IDENTITY' not handled
warning: enumeration value 'TYPE_IDENTITY' not handled in switch [-
Wswitch]
2017-04-25 09:45:27 +02:00
Phenom
6e42cf4200 Fix Clang warnings: field 'mPassword' will be initialized after field
'mPrevIsBad'

warning: field 'mPassword' will be initialized after field 'mPrevIsBad'
[-Wreorder]
2017-04-25 09:44:59 +02:00
electron128
be9f126898 Merge pull request #781 from Sonetio/libresapi_requests
Added few requests handling in libresapi
2017-04-24 18:43:17 +02:00
Konrad
8da5e15180 Changed: difference time to absolute time. 2017-04-24 16:00:23 +02:00
defnax
6313d89718 Improved look n feel of Profile Generation Window. 2017-04-24 01:23:05 +02:00
csoler
190a638cc1 added zesty to ubuntu releases 2017-04-23 17:53:25 +02:00
csoler
06e90e6549 added control file for zesty 2017-04-23 17:49:07 +02:00
csoler
c738026eb8 updated ubuntu changelog 2017-04-23 17:48:39 +02:00
csoler
5b3b903603 added missing line for ubuntu zesty 2017-04-23 17:36:18 +02:00
csoler
73bfc27f47 Merge pull request #784 from PhenomRetroShare/Fix_RelaySettingsPage
Fix Relay setting page.
2017-04-23 17:33:50 +02:00
Phenom
4c326f5e80 Fix Relay setting page. 2017-04-23 10:27:18 +02:00
defnax
0e087db807 Fixed to use right icons for context menu actions 2017-04-22 17:32:59 +02:00
Konrad
f571b05693 Added: Checking if the vector is empty;
Changed: Grouped values into one member
2017-04-22 11:06:56 +02:00
electron128
8b9c447063 fixed possible crash and return value in rsGetHostByName(), thanks to Kotyara for reporting this 2017-04-22 10:13:23 +02:00
Konrad
8c0b7ce776 Fixed: Responds sends now correct time difference 2017-04-21 23:44:00 +02:00
csoler
4ab60219b2 Merge pull request #782 from PhenomRetroShare/Fix_MacOSX_Compilation
Fix MacOSX compilation.
2017-04-21 19:45:30 +02:00
Phenom
936dcbabb3 Fix UnitTest compilation. 2017-04-21 18:50:36 +02:00
Phenom
969b5ce1f1 Fix MacOSX compilation. 2017-04-21 15:57:57 +02:00
csoler
7400a8d768 Merge pull request #780 from csoler/v0.6-ImprovedGUI
added mechanism to allow services to document the names of their item…
2017-04-20 20:59:12 +02:00
csoler
5f8bf03dfe added mechanism to allow services to document the names of their items, and improved bandwidth graph to show names for GXS services. Other services still need to supply their own names 2017-04-20 20:54:51 +02:00
Konrad
c9f618ddf6 Added: Notification about changed peer status 2017-04-20 19:09:57 +02:00
Konrad
9600359bdb Fixed: Password was not stored after creating a new location 2017-04-20 18:09:19 +02:00
Konrad
4a0b51ce2d Added: to response information whether the identity is a contact 2017-04-19 22:03:24 +02:00
csoler
ccfd12b506 Merge pull request #778 from csoler/v0.6-ImprovedGUI
V0.6 improved gui
2017-04-19 18:53:49 +02:00
csoler
f406b81238 removed all FFT code and cleaned up deleted code in graphwidget.cpp 2017-04-19 18:46:58 +02:00
csoler
1da89dd70d changed FFT code in graph widget into a more efficient one, with free licence 2017-04-19 17:16:30 +02:00
Konrad
b43bedf669 Added: Handling requests to set opinion about identity 2017-04-18 23:00:59 +02:00
Konrad
120ca9d078 Added: Handling requests to set opinion about identity 2017-04-18 22:58:15 +02:00
Konrad
3f54568d7f Added: Handling requests to get details about identity 2017-04-18 22:56:35 +02:00
csoler
e95ddb91af Merge pull request #767 from PhenomRetroShare/Fix_CommentWithLineReturn
Fix comment view when they have line return.
2017-04-18 20:28:36 +02:00
csoler
5f969e7306 Merge pull request #776 from PhenomRetroShare/Fix_ClangWarnings
Fix clang warnings
2017-04-18 20:27:20 +02:00
csoler
3ab39c6b5f Merge pull request #777 from PhenomRetroShare/Fix_EncodeRadixInRSLinks
Encode Radix in RSLinks.
2017-04-18 20:26:14 +02:00
Phenom
3c5e61a297 Encode Radix in RSLinks.
Because it can contains special characters like '+', '/'.
But this is not backward compatible.
2017-04-18 17:36:43 +02:00
Konrad
76dd7fe47f Added: Handling requests to add and remove contact 2017-04-18 14:02:14 +02:00
Konrad
4a99000f16 Added: Handling requests to get and set node options 2017-04-18 14:00:30 +02:00
Phenom
37331372c1 Fix Clang warnings: implicit conversion
warning: implicit conversion from 'int' to 'char' changes value from 255
to -1 [-Wconstant-conversion]
                                asctobin()[i] = 255;    /* used to
detect invalid characters */
2017-04-18 11:25:41 +02:00
Phenom
7d9a80326d Fix Clang warnings: bdnet_inet_ntoa C-linkage
/libbitdht/src/util/bdnet.h:107: warning: 'bdnet_inet_ntoa' has C-
linkage specified, but returns user-defined type 'std::string' (aka
'basic_string<char>') which is incompatible with C [-Wreturn-type-c-
linkage]
std::string bdnet_inet_ntoa(struct in_addr in);
            ^
2017-04-18 11:18:10 +02:00
csoler
4faaaf7093 Merge pull request #775 from csoler/v0.6-PRTest
V0.6 pr test
2017-04-17 22:03:48 +02:00
Phenom
87dd614088 Fix Clang Warnings: private field 'encoding_debug_file' is not used
warning: private field 'encoding_debug_file' is not used [-Wunused-
private-field]
    FILE *encoding_debug_file ;
2017-04-17 22:01:48 +02:00
Phenom
4f939b2b76 Fix Clang warnings: unused function 'set_item_background'
warning: unused function 'set_item_background' [-Wunused-function]
static void set_item_background(QTreeWidgetItem *item, uint32_t type)
2017-04-17 22:01:28 +02:00
Phenom
76f7573659 Fix Clang warnings: comparison of array != a null pointer is always true
warning: comparison of array 'known_zones[i].tzName' not equal to a null
pointer is always true [-Wtautological-pointer-compare]
                        for (int i=0; known_zones[i].tzName != 0; i++) {
2017-04-17 21:58:19 +02:00