Commit Graph

2986 Commits

Author SHA1 Message Date
syeopite
21e29411af
Fix extractor bugs (#2454)
* Add debug/trace logging to extract_items
* Handle invalid timestamps for livestreams extraction
* Make use of author_fallback in playlist extractor
* Don't use extract_text for video length extraction

The extract_text function attempts to extract from both the simpleText and
the runs route. This is typically what we'd want for text extraction as
it could appear in both locations. However, while this still holds true,
the thumbnailOverlayTimeStatusRenderer writes a numerical length (when
present on the video) to the simpleText route and uses runs for a
text overlay like "LIVE" or "PREMIERE".

Therefore, when a video has a text overlay instead of a numerical one,
Invidious still passes it onto decode_length_seconds, which obviously
raises since it cannot be converted into integers.

In the future, if more routes requires one text route over the other, we
should go ahead and add an argument to extract_text itself. Though for
now, this is sufficient.

* Handle unsupported "special" categories
2021-10-07 23:39:21 +02:00
Samantaz Fox
f85930700b
Add myself (SamantazFox) as codeowner of locale files (#2472) 2021-10-07 06:01:25 -07:00
Weblate (bot)
707ef1d0f7
Translations update from Weblate (#2470)
* Update Russian translation

* Update Arabic translation

* Update Spanish translation

* Update Esperanto translation

* Update Chinese (Simplified) translation

* Update Turkish translation

* Update Chinese (Traditional) translation

* Update Lithuanian translation

* Update Portuguese translation

Co-authored-by: Nikita Epifanov <nikgreens@protonmail.com>
Co-authored-by: Rex_sa <rex.sa@pm.me>
Co-authored-by: Jorge Maldonado Ventura <jorgesumle@freakspot.net>
Co-authored-by: Eric <spice2wolf@gmail.com>
Co-authored-by: Oğuz Ersen <oguzersen@protonmail.com>
Co-authored-by: Jeff Huang <s8321414@gmail.com>
Co-authored-by: Gediminas Murauskas <muziejusinfo@gmail.com>
Co-authored-by: SC <lalocas@protonmail.com>
2021-10-07 05:25:54 -07:00
Samantaz Fox
adc12addfa
Add config option to display source code URL in footer (#2450) 2021-10-07 13:53:12 +02:00
Weblate (bot)
bfef9d4b6e
Update Persian translation (#2463)
Co-authored-by: Mostafa Ahangarha <ahangarha@gmail.com>
2021-10-05 16:18:08 +00:00
syeopite
fd29cb9023
Add missing filter ui locales (#1912) 2021-10-05 14:46:19 +00:00
Samantaz Fox
d806310665
Revert "Fix typo (#2456)" (#2457)
This reverts commit 4982bff74d.
2021-10-04 19:51:57 +02:00
Jorge Maldonado Ventura
4982bff74d
Fix typo (#2456) 2021-10-04 17:47:57 +00:00
syeopite
347c189f3f
Merge pull request #1678 from Rjevski/idempotent-database-migrations
Make DB migrations idempotent.
2021-10-03 18:53:35 +00:00
syeopite
81b12b8001
Add support to make invidious API-only via flag (#2363) 2021-10-02 20:04:02 +00:00
syeopite
3e781b7d13
Merge pull request #2443 from iv-org/syeopite-patch-1
Use make_client when querying instance api
2021-10-02 20:00:37 +00:00
syeopite
9c44e41a4c
Merge pull request #2228 from syeopite/extract-items-overhaul
Overhaul extract_item(s) functions and add infrastructure for parsing YouTube categories
2021-10-02 20:00:16 +00:00
syeopite
402bb01151
Update container-release.yml 2021-10-02 16:10:23 +00:00
syeopite
82a1d9dffa
Install Crystal in container-release for linter 2021-10-02 16:10:07 +00:00
syeopite
570541ba49
Run linter in container-release workflow 2021-10-02 16:00:43 +00:00
syeopite
73eabb6ca2
Actually fix lint 2021-10-02 08:53:58 -07:00
Samantaz Fox
5a52b4fe45
Fix lint 2021-10-02 17:41:25 +02:00
Samantaz Fox
caa08a6379
Disable locales with less than 50% of strings translated 2021-10-02 17:38:06 +02:00
Samantaz Fox
cd02078e26
Add Portuguese (pt) to locales
follow up to #2437
2021-10-02 17:19:28 +02:00
Weblate (bot)
0341faeb13
Translations update from Weblate (#2437)
* Add Portuguese translation
* Update German translation
* Update Basque translation
* Update Spanish translation
* Update Portuguese (Brazil) translation
* Update Portuguese (Portugal) translation
* Update Korean translation

Co-authored-by: SC <lalocas@protonmail.com>
Co-authored-by: Pukima <pukima@pukima.site>
Co-authored-by: Sergio Varela <sergitroll9@gmail.com>
Co-authored-by: Kim Tae Kyeong <kim@taekyeong.me>
2021-10-02 17:17:30 +02:00
syeopite
77131cff91
Use make_client when querying instance api 2021-10-02 15:16:07 +00:00
mastihios
7b2aa5f98e
add icon-buttons to playlist items (#2442) 2021-10-02 11:59:33 +00:00
syeopite
26b28cea49
Use break instead of short-circuit return 2021-10-01 05:39:23 -07:00
syeopite
23049e026f
Improve readabltiy of SearchChannel auto-gen detect 2021-09-28 08:55:02 -07:00
syeopite
9ab242ca2e
Optimize routing logic of extract_item(s) funcs 2021-09-28 08:50:23 -07:00
syeopite
aa59925374
Rename get_browse_endpoint to get_browse_id 2021-09-28 08:39:00 -07:00
syeopite
43ea8fa706
Convert nil for AuthorFallback to empty strings 2021-09-28 08:25:03 -07:00
syeopite
6df85718e6
Apply suggestions from code review
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
2021-09-28 15:23:36 +00:00
syeopite
82e6f6e095
Create CODEOWNERS (#2417)
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

Allows automatically assigning PRs to teams/users when it modifies a 
specific section of the repo that they "own".
2021-09-28 06:14:42 +00:00
syeopite
b20f72b963
Use default timeout (5 seconds) for YT pool (#2430) 2021-09-26 23:03:45 +02:00
syeopite
092b8a4e52
Add documentation to extractors.cr 2021-09-24 21:07:07 -07:00
syeopite
e5f07dedbf
Typos and tiny styling changes 2021-09-24 21:07:07 -07:00
syeopite
ca9eb0d539
Bountiful extractor changes
- Add extract_text to simplify extraction of InnerTube texts
- Add helper extractor methods to reduce repetition in parsing InnerTube
- Change [] more than 2 blocks long to use #dig or #dig?
- Remove useless ?.try blocks for items that always exists
- Add (some) documentation to VideoRendererParser
2021-09-24 21:07:07 -07:00
syeopite
142317c2be
Overhaul extractors.cr to use modules 2021-09-24 21:07:07 -07:00
syeopite
3dea670091
Switch to structs in extractors.cr for performance 2021-09-24 21:07:07 -07:00
syeopite
8435e79913
Improve documentation for extract_item(s) funcs 2021-09-24 21:07:07 -07:00
syeopite
30e85b40f9
Fix extract_videos 2021-09-24 21:07:07 -07:00
syeopite
be1a43a337
Manually extract category refactor from 1b569bbc99
Also fixes some errors caused by cherry-picking
2021-09-24 21:07:07 -07:00
syeopite
abca8f7a7c
Rename invidiousitems.cr 2021-09-24 21:07:07 -07:00
syeopite
7b60dac526
Add description_html field to Category
(cherry picked from commit aa8f15f795)
2021-09-24 21:07:07 -07:00
syeopite
ea6434662d
Change typing of Category contents to only Array
(cherry picked from commit d3384e17f1)
2021-09-24 21:07:06 -07:00
syeopite
0b7a108a59
Move continuation_token out of Category struct
(cherry picked from commit 0e96eda28f)
2021-09-24 21:07:06 -07:00
syeopite
57c63f3598
Rename "items_without_cate_items" to reflect usage 2021-09-24 21:07:06 -07:00
syeopite
ae30f32c36
Unpack search items that are embedded in categories
This is a squash of a bunch of commits
cherry-picked commits

Fix category parse error on search

(cherry picked from commit cc02fed4e6)

Fix category items not being extracted in search

(cherry picked from commit 2605b9c609)

Make search not include category items for now

(cherry picked from commit ca4afd59f4)

Change behavior of categories in search results

(cherry picked from commit cc10675610)

Fix missing search results in extraction

(cherry picked from commit abda6840d5)

Fix miscount of search results

(cherry picked from commit 491e33450e)
2021-09-24 21:07:06 -07:00
syeopite
a50f64f6e9
Add parser for categories (shelfRenderer)
This commit adds a new parser for YT's shelfRenderers which are
typically used to denote different categories.The code for featured
channels parsing has also been moved to use the new parser but some
additional refactoring are needed there.

The ContinuationExtractor has also been improved and is now capable of
extraction continuation data that is packaged under
"appendContinuationItemsAction"

In additional this commit adds some useful helper functions to extract
the current selected tab the continuation token. This is to mainly
reduce code size and repetition.
--
This cherry-picked commit also removes the code for parsing featured
channels present on the original.

(cherry picked from commit 8000d538db)
2021-09-24 21:07:06 -07:00
syeopite
1323b94b7a
Rewrite extract_item and extract_items functions
This commit completely rewrites the extract_item and extract_items
function. Before this commit these two function were an unreadable
mess. The extract_item function was a lengthy if-elsif chain
while the extract_items function contained an incomprehensible
mess of .try, else and ||.

With this commit both of these functions have been pulled into a
separate file with the internal logic being moved to a few classes.

This significantly reduces the size of these two methods, enhances
readability and makes adding new extraction/parse rules much simpler.

See diff for details.

--
This cherry-picked commit also removes the code for parsing featured
channels present on the original.

(cherry picked from commit a027fbf7af)
2021-09-24 21:06:46 -07:00
syeopite
6d68fbc31d
Fix livestream regex regression caused by #2271
Closes #2352

Special thanks to @WaywardHeart for finding this issue!
2021-09-25 02:47:52 +00:00
Weblate (bot)
d97e128dc0
Translations update from Weblate (#2424)
* Update Russian translation

* Update Indonesian translation

* Update Croatian translation

Co-authored-by: Nikita Epifanov <nikgreens@protonmail.com>
Co-authored-by: Reza Almanda <rezaalmanda27@gmail.com>
Co-authored-by: Milo Ivir <mail@milotype.de>
2021-09-23 23:49:28 +02:00
syeopite
86ca568d6d
Remove login type button from frontend (#2423) 2021-09-23 08:44:26 +02:00
syeopite
92b04a30f3
Prevent indexing of Invidious instances (#2420)
Closes #2418
2021-09-22 01:29:51 +02:00