14905 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Erik Johnston	d1b5b055be	Merge pull request #5825 from matrix-org/erikj/fix_empty_limited_sync ... Handle TimelineBatch being limited and empty.	2019-08-06 15:39:44 +01:00
Andrew Morgan	edeae53221	Return 404 instead of 403 when retrieving an event without perms (#5798) ... Part of fixing matrix-org/sytest#652 Sytest PR: matrix-org/sytest#667	2019-08-06 13:33:55 +01:00
Erik Johnston	c32d359094	Newsfile	2019-08-06 13:33:42 +01:00
Erik Johnston	bf4db42920	Don't unnecessarily block notifying of new events. ... When persisting events we calculate new stream orderings up front. Before we notify about an event all events with lower stream orderings must have finished being persisted. This PR moves the assignment of stream ordering till *after* calculated the new current state and split the batch of events into separate chunks for persistence. This means that if it takes a long time to calculate new current state then it will not block events in other rooms being notified about. This should help reduce some global pauses in the events stream which can last for tens of seconds (if not longer), caused by some particularly expensive state resolutions.	2019-08-06 13:32:02 +01:00
Erik Johnston	977fa4a717	Newsfile	2019-08-06 13:00:45 +01:00
Erik Johnston	6881f21f3e	Handle TimelineBatch being limited and empty. ... This hopefully addresses #5407 by gracefully handling an empty but limited TimelineBatch. We also add some logging to figure out how this is happening.	2019-08-06 12:59:00 +01:00
Brendan Abolivier	8ed9e63432	Account validity: allow defining HTML templates to serve the us… (#5807) ... Account validity: allow defining HTML templates to serve the user on account renewal attempt	2019-08-01 16:09:25 +02:00
Erik Johnston	d55bc4a8bf	Merge pull request #5810 from matrix-org/erikj/no_server_reachable ... Return 502 not 500 when failing to reach any remote server.	2019-08-01 14:19:39 +01:00
Andrew Morgan	5d018d23f0	Have ClientReaderSlavedStore inherit RegistrationStore (#5806) ... Fixes #5803	2019-08-01 13:54:56 +01:00
Erik Johnston	93fd3cbc7a	Newsfile	2019-08-01 13:48:52 +01:00
Erik Johnston	3c076c79c5	Merge pull request #5808 from matrix-org/erikj/parse_decode_error ... Handle incorrectly encoded query params correctly	2019-08-01 13:48:10 +01:00
Erik Johnston	a8f40a8302	Return 502 not 500 when failing to reach any remote server.	2019-08-01 13:47:31 +01:00
Erik Johnston	55a0c98d16	Merge pull request #5805 from matrix-org/erikj/validate_state ... Validate well known state events are state events.	2019-08-01 13:45:48 +01:00
Erik Johnston	0b36decfb6	Merge pull request #5801 from matrix-org/erikj/recursive_tombstone ... Don't allow clients to send tombstones that reference the same room	2019-08-01 13:45:35 +01:00
Erik Johnston	312cc48e2b	Newsfile	2019-08-01 13:45:09 +01:00
Erik Johnston	d02e41dcb2	Handle pusher being deleted during processing. ... Instead of throwing a StoreError lets break out of processing loop and mark the pusher as stopped.	2019-08-01 13:44:12 +01:00
Erik Johnston	da378af445	Newsfile	2019-08-01 13:24:00 +01:00
Erik Johnston	d2e3d5b9db	Handle incorrectly encoded query params correctly	2019-08-01 13:23:00 +01:00
Erik Johnston	76a58fdcce	Fix spelling. ... Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2019-08-01 13:17:55 +01:00
Erik Johnston	58af30a6c7	Merge pull request #5802 from matrix-org/erikj/deny_redacting_different_room ... Deny redaction of events in a different room.	2019-08-01 13:14:46 +01:00
Erik Johnston	0f632f3a57	Merge pull request #5790 from matrix-org/erikj/groups_request_errors ... Handle RequestSendFailed exception correctly in more places.	2019-08-01 13:14:08 +01:00
Erik Johnston	ad167c3849	Merge pull request #5804 from matrix-org/erikj/match_against_state_key ... Explicitly check that tombstone is a state event before notifying.	2019-08-01 13:13:33 +01:00
Brendan Abolivier	f25f638c35	Lint	2019-08-01 12:19:08 +02:00
Brendan Abolivier	3ff3dfe5a3	Sample config	2019-08-01 12:08:25 +02:00
Brendan Abolivier	f4a30d286f	Changelog	2019-08-01 12:08:06 +02:00
Brendan Abolivier	bc35503528	Add tests	2019-08-01 12:00:08 +02:00
Brendan Abolivier	a4a9ded4d0	Allow defining HTML templates to serve the user on account renewal	2019-08-01 11:59:27 +02:00
Erik Johnston	e5a0224837	Newsfile	2019-07-31 16:39:42 +01:00
Erik Johnston	dc4d74e44a	Validate well-known state events are state events. ... Lets disallow sending things like memberships, topics etc as non-state events.	2019-07-31 16:36:20 +01:00
Erik Johnston	c5288e9984	Newsfile	2019-07-31 16:32:03 +01:00
Erik Johnston	2e697d3013	Explicitly check that tombstone is a state event before notifying.	2019-07-31 16:32:03 +01:00
Erik Johnston	0eefb76fa1	Newsfile	2019-07-31 16:13:57 +01:00
Erik Johnston	cf89266b98	Deny redaction of events in a different room. ... We already correctly filter out such redactions, but we should also deny them over the CS API.	2019-07-31 16:12:27 +01:00
Erik Johnston	02735e140f	Newsfile	2019-07-31 15:53:52 +01:00
Erik Johnston	f31d4cb7a2	Don't allow clients to send tombstones that reference the same room	2019-07-31 15:52:27 +01:00
Andrew Morgan	72167fb394	Change user deactivated errcode to USER_DEACTIVATED and use it (#5686) ... This is intended as an amendment to #5674 as using M_UNKNOWN as the errcode makes it hard for clients to differentiate between an invalid password and a deactivated user (the problem we were trying to solve in the first place). M_UNKNOWN was originally chosen as it was presumed than an MSC would have to be carried out to add a new code, but as Synapse often is the testing bed for new MSC implementations, it makes sense to try it out first in the wild and then add it into the spec if it is successful. Thus this PR return a new M_USER_DEACTIVATED code when a deactivated user attempts to login.	2019-07-31 15:19:06 +01:00
Andrew Morgan	58a755cdc3	Remove duplicate return statement	2019-07-31 13:24:51 +01:00
Erik Johnston	8fde611a8c	Merge pull request #5794 from matrix-org/erikj/share_ssl_options_for_well_known ... Share SSL options for well-known requests	2019-07-31 11:40:02 +01:00
Amber Brown	8f15832950	Remove DelayedCall debugging from test runs (#5787)	2019-07-31 20:39:22 +10:00
Erik Johnston	9fe6ad5fef	Merge pull request #5796 from matrix-org/erikj/disable_codecov_report ... Disable codecov reports to GH comments.	2019-07-31 11:16:15 +01:00
Erik Johnston	fe2f2fc530	Newsfile	2019-07-31 10:59:39 +01:00
Erik Johnston	6be336c0d8	Disable codecov reports to GH comments. ... The double posting is really annoying, and I don't think anyone is actually reading them. The commit statuses should give a good summary and will link to a full report.	2019-07-31 10:56:02 +01:00
Erik Johnston	3b7a35a59a	Newsfile	2019-07-31 10:39:24 +01:00
Erik Johnston	a9bcae9f50	Share SSL options for well-known requests	2019-07-31 10:39:24 +01:00
Brendan Abolivier	d4f91e7e9f	Merge pull request #5793 from matrix-org/erikj/fix_bg_update ... Don't recreate current_state_events.membership column	2019-07-30 21:19:39 +02:00
Erik Johnston	4037d3220a	Newsfile	2019-07-30 16:43:59 +01:00
Erik Johnston	123c04daa7	Don't recreate column	2019-07-30 16:42:48 +01:00
Erik Johnston	62a2d60d72	Merge pull request #5792 from matrix-org/erikj/fix_bg_update ... Fix current_state_events membership background update.	2019-07-30 15:20:09 +01:00
Erik Johnston	958d69f300	Newsfile	2019-07-30 14:53:52 +01:00
Erik Johnston	15056ca208	Fix current_state_events membership background update. ... Turns out not all rooms are in `rooms`, so lets fetch the room list from `current_state_events`. We move the delta file to force it to be run again.	2019-07-30 14:51:41 +01:00