Handle incorrectly encoded query params correctly

This commit is contained in:
Erik Johnston 2019-08-01 13:23:00 +01:00
parent 58af30a6c7
commit d2e3d5b9db

View File

@ -166,7 +166,12 @@ def parse_string_from_args(
value = args[name][0]
if encoding:
value = value.decode(encoding)
try:
value = value.decode(encoding)
except ValueError:
raise SynapseError(
400, "Query parameter %r must be %s" % (name, encoding)
)
if allowed_values is not None and value not in allowed_values:
message = "Query parameter %r must be one of [%s]" % (