synapse-product

mirror of https://git.anonymousland.org/anonymousland/synapse-product.git synced 2024-12-24 05:59:24 -05:00

Author	SHA1	Message	Date
Andrew Morgan	01c3c6c929	Fix power levels being incorrectly set in old and new rooms after a room upgrade (#6633 ) Modify a copy of an upgraded room's PL before sending to the new room	2020-01-06 09:53:07 +00:00
Richard van der Hoff	08815566bc	Automate generation of the sample and debian log configs (#6627 )	2020-01-03 17:14:00 +00:00
Richard van der Hoff	e484101306	Raise an error if someone tries to use the log_file config option (#6626 ) This has caused some confusion for people who didn't notice it going away.	2020-01-03 17:11:29 +00:00
Richard van der Hoff	98247c4a0e	Remove unused, undocumented "content repo" resource (#6628 ) This looks like it got half-killed back in #888. Fixes #6567.	2020-01-03 17:10:52 +00:00
Richard van der Hoff	b6b57ecb4e	Kill off redundant SynapseRequestFactory (#6619 ) We already get the Site via the Channel, so there's no need for a dedicated RequestFactory: we can just use the right constructor.	2020-01-03 14:19:48 +00:00
Richard van der Hoff	6964ea095b	Reduce the reconnect time when replication fails. (#6617 )	2020-01-03 14:19:09 +00:00
Brendan Abolivier	4efe1d4d3f	Fix a typo in the purge jobs configuration example	2020-01-03 12:57:24 +01:00
Richard van der Hoff	dc96943d51	Merge branch 'master' into develop	2019-12-31 11:01:06 +00:00
Richard van der Hoff	77661ce81a	1.7.3	2019-12-31 10:45:12 +00:00
Richard van der Hoff	92eac974b9	Hacks to work around #6605 (#6608 ) When we have an event which refers to non-existent auth_events, ignore said events rather than exploding in a ball of fire. Fixes #6605.	2019-12-31 10:41:44 +00:00
Richard van der Hoff	56ad230efa	Merge branch 'master' into develop	2019-12-20 11:11:34 +00:00
Richard van der Hoff	29794c6bc8	1.7.2	2019-12-20 10:58:07 +00:00
Erik Johnston	75d8f26ac8	Split state groups into a separate data store (#6296 )	2019-12-20 10:48:24 +00:00
Richard van der Hoff	4caab0e95e	Backport fixes to sqlite upgrade from develop (#6578 ) Only run prepare_database on connection for in-memory databases. Fixes #6569.	2019-12-20 10:46:46 +00:00
Erik Johnston	fa780e9721	Change EventContext to use the Storage class (#6564 )	2019-12-20 10:32:02 +00:00
Richard van der Hoff	03d3792f3c	Fix exceptions when attempting to backfill (#6576 ) Fixes #6575	2019-12-20 09:55:45 +00:00
Erik Johnston	0b5dbadd96	Explode on duplicate delta file names. (#6565 )	2019-12-19 15:07:37 +00:00
Erik Johnston	3d46124ad0	Port some admin handlers to async/await (#6559 )	2019-12-19 15:07:28 +00:00
Richard van der Hoff	bca30cefee	Improve diagnostics on database upgrade failure (#6570 ) `Failed to upgrade database` is not helpful, and it's unlikely that UPGRADE.rst has anything useful.	2019-12-19 14:53:15 +00:00
Richard van der Hoff	0b794cbd7b	Fix sdnotify with acme enabled (#6571 ) If acme was enabled, the sdnotify startup hook would never be run because we would try to add it to a hook which had already fired. There's no need to delay it: we can sdnotify as soon as we've started the listeners.	2019-12-19 14:52:52 +00:00
Richard van der Hoff	b95b762560	Add an export_signing_key script (#6546 ) I want to do some key rotation, and it is silly that we don't have a way to do this.	2019-12-19 11:11:14 +00:00
Richard van der Hoff	d6752ce5da	Clean up startup for the pusher (#6558 ) * Remove redundant python2 support code `str.decode()` doesn't exist on python3, so presumably this code was doing nothing * Filter out pushers with corrupt data When we get a row with unparsable json, drop the row, rather than returning a row with null `data`, which will then cause an explosion later on. * Improve logging when we can't start a pusher Log the ID to help us understand the problem * Make email pusher setup more robust We know we'll have a `data` member, since that comes from the database. What we don't know is if that is a dict, and if that has a `brand` member, and if that member is a string.	2019-12-18 14:26:58 +00:00
Andrew Morgan	7963ca83cb	Add delta file to fix missing default table data (#6555 )	2019-12-18 11:13:33 +00:00
Erik Johnston	2284eb3a53	Add database config class (#6513 ) This encapsulates config for a given database and is the way to get new connections.	2019-12-18 10:45:12 +00:00
Richard van der Hoff	91ccfe9f37	Merge branch 'master' into develop	2019-12-18 10:16:39 +00:00
Richard van der Hoff	6e8f8e14f2	Merge release-v1.7.1 into develop	2019-12-18 09:51:51 +00:00
Richard van der Hoff	d656e91fc2	1.7.1	2019-12-18 09:38:08 +00:00
Erik Johnston	5029422530	Fix bug where we added duplicate event IDs as auth_events (#6560 )	2019-12-17 15:06:08 +00:00
Erik Johnston	02553901ce	Remove unused `get_pagination_rows` methods. (#6557 ) Remove unused get_pagination_rows methods	2019-12-17 11:44:32 +00:00
Erik Johnston	5ca2cfadc3	Add auth events as per spec. (#6556 ) Previously we tried to be clever and filter out some unnecessary event IDs to keep the auth chain small, but that had some annoying interactions with state res v2 so we stop doing that for now.	2019-12-16 17:05:01 +00:00
Erik Johnston	3fbe5b7ec3	Add auth events as per spec. (#6556 ) Previously we tried to be clever and filter out some unnecessary event IDs to keep the auth chain small, but that had some annoying interactions with state res v2 so we stop doing that for now.	2019-12-16 16:59:32 +00:00
Brendan Abolivier	6316530366	Merge pull request #6553 from matrix-org/babolivier/fix-context-filter Use the filtered version of an event when responding to /context requests for that event	2019-12-16 16:24:10 +00:00
Will Hunt	bfb95654c9	Add option to allow profile queries without sharing a room (#6523 )	2019-12-16 16:11:55 +00:00
Brendan Abolivier	a820069549	Incorporate review	2019-12-16 16:00:18 +00:00
Richard van der Hoff	bbb75ff6ee	Exclude rejected state events when calculating state at backwards extrems (#6527 ) This fixes a weird bug where, if you were determined enough, you could end up with a rejected event forming part of the state at a backwards-extremity. Authing that backwards extrem would then lead to us trying to pull the rejected event from the db (with allow_rejected=False), which would fail with a 404.	2019-12-16 14:07:29 +00:00
Richard van der Hoff	ff773ff724	Persist auth/state events at backwards extremities when we fetch them (#6526 ) The main point here is to make sure that the state returned by _get_state_in_room has been authed before we try to use it as state in the room.	2019-12-16 14:07:11 +00:00
Richard van der Hoff	83895316d4	sanity-checking for events used in state res (#6531 ) When we perform state resolution, check that all of the events involved are in the right room.	2019-12-16 13:53:53 +00:00
Richard van der Hoff	6577f2d887	Sanity-check room ids in event auth (#6530 ) When we do an event auth operation, check that all of the events involved are in the right room.	2019-12-16 13:47:34 +00:00
Richard van der Hoff	35bbe4ca79	Check the room_id of events when fetching room state/auth (#6524 ) When we request the state/auth_events to populate a backwards extremity (on backfill or in the case of missing events in a transaction push), we should check that the returned events are in the right room rather than blindly using them in the room state or auth chain. Given that _get_events_from_store_or_dest takes a room_id, it seems clear that it should be sanity-checking the room_id of the requested events, so let's do it there.	2019-12-16 13:47:07 +00:00
Richard van der Hoff	20d5ba16e6	Add `include_event_in_state` to _get_state_for_room (#6521 ) Make it return the state after the requested event, rather than the one before it. This is a bit easier and requires fewer calls to get_events_from_store_or_dest.	2019-12-16 13:26:12 +00:00
Richard van der Hoff	be294d6fde	Move get_state methods into FederationHandler (#6503 ) This is a non-functional refactor as a precursor to some other work.	2019-12-16 13:20:21 +00:00
Richard van der Hoff	4c7b1bb6cc	Refactor get_events_from_store_or_dest to return a dict (#6501 ) There was a bunch of unnecessary conversion back and forth between dict and list going on here. We can simplify a bunch of the code.	2019-12-16 13:19:32 +00:00
Richard van der Hoff	6920d88892	Exclude rejected state events when calculating state at backwards extrems (#6527 ) This fixes a weird bug where, if you were determined enough, you could end up with a rejected event forming part of the state at a backwards-extremity. Authing that backwards extrem would then lead to us trying to pull the rejected event from the db (with allow_rejected=False), which would fail with a 404.	2019-12-16 13:14:37 +00:00
Richard van der Hoff	bc7de87650	Persist auth/state events at backwards extremities when we fetch them (#6526 ) The main point here is to make sure that the state returned by _get_state_in_room has been authed before we try to use it as state in the room.	2019-12-16 12:26:28 +00:00
Brendan Abolivier	ac87ddb242	Update the documentation of the filtering function	2019-12-16 12:15:37 +00:00
Brendan Abolivier	487f1bb49d	Use the filtered version of an event when responding to /context requests for that event Sometimes the filtering function can return a pruned version of an event (on top of either the event itself or an empty list), if it thinks the user should be able to see that there's an event there but not the content of that event. Therefore, the previous logic of 'if filtered is empty then we can use the event we retrieved from the database' is flawed, and we should use the event returned by the filtering function.	2019-12-16 12:14:12 +00:00
Werner Sembach	9d173b312c	Automatically delete empty groups/communities (#6453 ) Signed-off-by: Werner Sembach <werner.sembach@fau.de>	2019-12-16 12:12:40 +00:00
Richard van der Hoff	1da15f05f5	sanity-checking for events used in state res (#6531 ) When we perform state resolution, check that all of the events involved are in the right room.	2019-12-13 12:55:32 +00:00
Richard van der Hoff	971a0702b5	Sanity-check room ids in event auth (#6530 ) When we do an event auth operation, check that all of the events involved are in the right room.	2019-12-13 11:44:41 +00:00
Erik Johnston	5cadbd9ebb	Merge pull request #6537 from matrix-org/erikj/bump_mypy_version Bump mypy version	2019-12-13 11:32:53 +00:00
Erik Johnston	f46e05d053	Merge branch 'master' into develop	2019-12-13 10:55:47 +00:00
Erik Johnston	f5aeea9e89	1.7.0	2019-12-13 10:19:53 +00:00
Erik Johnston	caa52836e4	Merge pull request #6496 from matrix-org/erikj/initial_sync_asnyc Port synapse.handlers.initial_sync to async/await	2019-12-13 10:01:51 +00:00
Hubert Chathi	cb2db17994	look up cross-signing keys from the DB in bulk (#6486 )	2019-12-12 12:03:28 -05:00
Andrew Morgan	5bfd8855d6	Fix redacted events being returned in search results ordered by "recent" (#6522 )	2019-12-12 15:53:49 +00:00
Erik Johnston	495005360c	Bump version of mypy	2019-12-12 15:21:12 +00:00
Richard van der Hoff	25f1244329	Check the room_id of events when fetching room state/auth (#6524 ) When we request the state/auth_events to populate a backwards extremity (on backfill or in the case of missing events in a transaction push), we should check that the returned events are in the right room rather than blindly using them in the room state or auth chain. Given that _get_events_from_store_or_dest takes a room_id, it seems clear that it should be sanity-checking the room_id of the requested events, so let's do it there.	2019-12-12 12:57:45 +00:00
Erik Johnston	b8e4b39b69	Merge pull request #6511 from matrix-org/erikj/remove_db_config_from_apps Move database config from apps into HomeServer object	2019-12-12 10:37:56 +00:00
Erik Johnston	cfcfb57e58	Add new config param to docstring and add types	2019-12-11 17:27:46 +00:00
Erik Johnston	6828b47c45	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/initial_sync_asnyc	2019-12-11 17:01:41 +00:00
Richard van der Hoff	2045356517	Add `include_event_in_state` to _get_state_for_room (#6521 ) Make it return the state after the requested event, rather than the one before it. This is a bit easier and requires fewer calls to get_events_from_store_or_dest.	2019-12-11 16:37:51 +00:00
Richard van der Hoff	894d2addac	Merge pull request #6517 from matrix-org/rav/event_auth/13 Port some of FederationHandler to async/await	2019-12-11 16:36:06 +00:00
Erik Johnston	31905a518e	Merge pull request #6504 from matrix-org/erikj/account_validity_async_await Port handlers.account_validity to async/await.	2019-12-11 14:49:26 +00:00
Richard van der Hoff	6637d90d77	convert to async: FederationHandler._process_received_pdu also fix user_joined_room to consistently return deferreds	2019-12-11 14:39:26 +00:00
Richard van der Hoff	4db394a4b3	convert to async: FederationHandler._get_state_for_room ... and _get_events_from_store_or_dest	2019-12-11 14:39:26 +00:00
Richard van der Hoff	e77237b935	convert to async: FederationHandler.on_receive_pdu and associated functions: * on_receive_pdu * handle_queued_pdus * get_missing_events_for_pdu	2019-12-11 14:39:26 +00:00
Richard van der Hoff	7712e751b8	Convert federation backfill to async PaginationHandler.get_messages is only called by RoomMessageListRestServlet, which is async. Chase the code path down from there: - FederationHandler.maybe_backfill (and nested try_backfill) - FederationHandler.backfill	2019-12-11 14:39:25 +00:00
Richard van der Hoff	7c429f92d6	Clean up some logging (#6515 ) This just makes some of the logging easier to follow when things start going wrong.	2019-12-11 14:32:25 +00:00
Erik Johnston	adb3a873fd	Synapse 1.7.0rc2 (2019-12-11) ============================= Bugfixes -------- - Fix incorrect error message for invalid requests when setting user's avatar URL. ([\#6497](https://github.com/matrix-org/synapse/issues/6497)) - Fix support for SQLite 3.7. ([\#6499](https://github.com/matrix-org/synapse/issues/6499)) - Fix regression where sending email push would not work when using a pusher worker. ([\#6507](https://github.com/matrix-org/synapse/issues/6507), [\#6509](https://github.com/matrix-org/synapse/issues/6509)) -----BEGIN PGP SIGNATURE----- iQJEBAABCgAuFiEEumuwyPtYLL2OMhYdOtoG7cdT0R4FAl3w+RwQHGVyaWtAbWF0 cml4Lm9yZwAKCRA62gbtx1PRHijfD/43EQ58jqKvD+qKZwVFOE6JJ3SCS7UJbi3f zq9KWDuCB6EAFjAgmJikbBBqHPO5qq2WtNXaCpexx44s8Mk8SZKHg56dP6Fk651C assAb/Nsh6CAlPUcRkx8I0L/kYXMPDyATlLVBHVOi3pFDJ093mdOQ4q8yP9iUTM+ OPsbT8k/pMhrhCH951bGmB6/SEcju+ubObW+bRFe8o3v1KE9jVYQjUGMhuoXp3pM z/OB8idZcqOvCc6HMo83tg9FuI613Jy80PMIc1ofyJgvnu+aDBepWuldvFEMnmSR D862jMor7+WdnDOTeWZrC+DXjl0qCP8F6ahs5rEllRglt/Ep2wEDPA/8YrRoEI3V RWe9W7XDdFCXdzlvXheOfETqTu9kdsurTwBEeJrWQ0vOLY86hxt9KKKcHVhy5eKq kNfRtvSVLmRhIssp7hVBcywRwnaxN7R2OoRq/TWnTZz+xEOPzYFU6r0l9kk5dbg6 fqYYxIXbgZlhjihLWNIMNwwZH9ll/eoPiinkRTZNz40THP/VDTR9DM4tQ6jrhrr6 sP0qM7LljvrdiimXtV00tUDyUspNgJl6xDJyGDHWM9uoCB7uorEpMQZSzlZhZe8s 6q+fQPHlfW4JYOejfihPkjrV1ViawvEucqWPaIsD+v26C4RP7qCTtYj3NPiA65of zhOjomWWcg== =ABoZ -----END PGP SIGNATURE----- Merge tag 'v1.7.0rc2' into develop Synapse 1.7.0rc2 (2019-12-11) ============================= Bugfixes -------- - Fix incorrect error message for invalid requests when setting user's avatar URL. ([\#6497](https://github.com/matrix-org/synapse/issues/6497)) - Fix support for SQLite 3.7. ([\#6499](https://github.com/matrix-org/synapse/issues/6499)) - Fix regression where sending email push would not work when using a pusher worker. ([\#6507](https://github.com/matrix-org/synapse/issues/6507), [\#6509](https://github.com/matrix-org/synapse/issues/6509))	2019-12-11 14:14:30 +00:00
Erik Johnston	d156912c4c	1.7.0rc2	2019-12-11 13:56:50 +00:00
Andrew Morgan	fc316a4894	Prevent redacted events from appearing in message search (#6377 )	2019-12-11 13:39:47 +00:00
Andrew Morgan	6676ee9c4a	Add dev script to generate full SQL schema files (#6394 )	2019-12-11 13:16:01 +00:00
Andrew Morgan	ea0f0ad414	Prevent message search in upgraded rooms we're not in (#6385 )	2019-12-11 13:07:25 +00:00
Erik Johnston	72acca6a32	Back out change preventing setting null avatar URLs	2019-12-11 11:46:55 +00:00
Brendan Abolivier	54ae52ba96	Merge pull request #6349 from matrix-org/babolivier/msc1802 Implement v2 APIs for send_join and send_leave	2019-12-11 11:41:47 +00:00
Erik Johnston	d21577bdcb	Merge branch 'erikj/fix_sqlite_7' of github.com:matrix-org/synapse into release-v1.7.0	2019-12-11 11:34:50 +00:00
Richard van der Hoff	f8bc2ae883	Move get_state methods into FederationHandler (#6503 ) This is a non-functional refactor as a precursor to some other work.	2019-12-10 17:42:46 +00:00
Andrew Morgan	4947de5a14	Allow SAML username provider plugins (#6411 )	2019-12-10 17:30:16 +00:00
Erik Johnston	b2dcddc413	Merge pull request #6510 from matrix-org/erikj/phone_home_stats_db Phone home stats DB reporting should not assume a single DB.	2019-12-10 16:31:24 +00:00
Richard van der Hoff	40eda84933	Fix race which caused deleted devices to reappear (#6514 ) Stop the `update_client_ips` background job from recreating deleted devices.	2019-12-10 16:22:29 +00:00
Richard van der Hoff	c3dda2874d	Refactor get_events_from_store_or_dest to return a dict (#6501 ) There was a bunch of unnecessary conversion back and forth between dict and list going on here. We can simplify a bunch of the code.	2019-12-10 16:22:00 +00:00
Richard van der Hoff	424fd58237	Remove redundant code from event authorisation implementation. (#6502 )	2019-12-10 15:09:45 +00:00
Erik Johnston	257ef2c727	Port handlers.account_validity to async/await.	2019-12-10 14:40:15 +00:00
Erik Johnston	bc5cb8bfe8	Remove database config parsing from apps.	2019-12-10 14:34:17 +00:00
Erik Johnston	35f3c366ef	Merge pull request #6505 from matrix-org/erikj/make_deferred_yiedable Fix `make_deferred_yieldable` to work with coroutines	2019-12-10 14:20:26 +00:00
Erik Johnston	e726e18737	Merge pull request #6499 from matrix-org/erikj/fix_sqlite_7 Fix support for SQLite 3.7.	2019-12-10 13:43:52 +00:00
Erik Johnston	663238aeb4	Phone home stats DB reporting should not assume a single DB.	2019-12-10 13:21:04 +00:00
Erik Johnston	ffeafade48	Update comment	2019-12-10 13:17:39 +00:00
Brendan Abolivier	3bd049bbb7	Give the server config to the RoomWorkerStore	2019-12-10 13:05:35 +00:00
Erik Johnston	e3f528c544	Merge pull request #6506 from matrix-org/erikj/remove_snapshot_cache Remove SnapshotCache in favour of ResponseCache	2019-12-10 13:04:50 +00:00
Erik Johnston	52346990c8	Drop unused index	2019-12-10 12:46:14 +00:00
Erik Johnston	31da85e467	Convert _censor_redactions to async since it awaits on coroutines	2019-12-10 12:46:00 +00:00
Brendan Abolivier	2ac78438d8	Make the PusherSlaveStore inherit from the slave RoomStore So that it has access to the get_retention_policy_for_room function which is required by filter_events_for_client.	2019-12-10 12:31:03 +00:00
Erik Johnston	cc5f6eb608	Only start censor background job after indices are created	2019-12-10 11:39:31 +00:00
Erik Johnston	9a2223d4c8	Fix make_deferred_yieldable to work with coroutines	2019-12-10 11:22:12 +00:00
Erik Johnston	353396e3a7	Port handlers.account_data to async/await.	2019-12-10 11:12:56 +00:00
Erik Johnston	4cade96616	Fix support for SQLite 3.7. Partial indices support was added in 3.8.0, so we need to use the background updates that handles this correctly.	2019-12-09 15:09:16 +00:00
Neil Johnson	0f3614f0f6	Synapse 1.7.0rc1 (2019-12-09) ============================= Features -------- - Implement per-room message retention policies. ([\#5815](https://github.com/matrix-org/synapse/issues/5815), [\#6436](https://github.com/matrix-org/synapse/issues/6436)) - Add etag and count fields to key backup endpoints to help clients guess if there are new keys. ([\#5858](https://github.com/matrix-org/synapse/issues/5858)) - Add `/admin/v2/users` endpoint with pagination. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#5925](https://github.com/matrix-org/synapse/issues/5925)) - Require User-Interactive Authentication for `/account/3pid/add`, meaning the user's password will be required to add a third-party ID to their account. ([\#6119](https://github.com/matrix-org/synapse/issues/6119)) - Implement the `/_matrix/federation/unstable/net.atleastfornow/state/<context>` API as drafted in MSC2314. ([\#6176](https://github.com/matrix-org/synapse/issues/6176)) - Configure privacy-preserving settings by default for the room directory. ([\#6354](https://github.com/matrix-org/synapse/issues/6354)) - Add ephemeral messages support by partially implementing [MSC2228](https://github.com/matrix-org/matrix-doc/pull/2228). ([\#6409](https://github.com/matrix-org/synapse/issues/6409)) - Add support for [MSC 2367](https://github.com/matrix-org/matrix-doc/pull/2367), which allows specifying a reason on all membership events. ([\#6434](https://github.com/matrix-org/synapse/issues/6434)) Bugfixes -------- - Transfer non-standard power levels on room upgrade. ([\#6237](https://github.com/matrix-org/synapse/issues/6237)) - Fix error from the Pillow library when uploading RGBA images. ([\#6241](https://github.com/matrix-org/synapse/issues/6241)) - Correctly apply the event filter to the `state`, `events_before` and `events_after` fields in the response to `/context` requests. ([\#6329](https://github.com/matrix-org/synapse/issues/6329)) - Fix caching devices for remote users when using workers, so that we don't attempt to refetch (and potentially fail) each time a user requests devices. ([\#6332](https://github.com/matrix-org/synapse/issues/6332)) - Prevent account data syncs getting lost across TCP replication. ([\#6333](https://github.com/matrix-org/synapse/issues/6333)) - Fix bug: TypeError in `register_user()` while using LDAP auth module. ([\#6406](https://github.com/matrix-org/synapse/issues/6406)) - Fix an intermittent exception when handling read-receipts. ([\#6408](https://github.com/matrix-org/synapse/issues/6408)) - Fix broken guest registration when there are existing blocks of numeric user IDs. ([\#6420](https://github.com/matrix-org/synapse/issues/6420)) - Fix startup error when http proxy is defined. ([\#6421](https://github.com/matrix-org/synapse/issues/6421)) - Fix error when using synapse_port_db on a vanilla synapse db. ([\#6449](https://github.com/matrix-org/synapse/issues/6449)) - Fix uploading multiple cross signing signatures for the same user. ([\#6451](https://github.com/matrix-org/synapse/issues/6451)) - Fix bug which lead to exceptions being thrown in a loop when a cross-signed device is deleted. ([\#6462](https://github.com/matrix-org/synapse/issues/6462)) - Fix `synapse_port_db` not exiting with a 0 code if something went wrong during the port process. ([\#6470](https://github.com/matrix-org/synapse/issues/6470)) - Improve sanity-checking when receiving events over federation. ([\#6472](https://github.com/matrix-org/synapse/issues/6472)) - Fix inaccurate per-block Prometheus metrics. ([\#6491](https://github.com/matrix-org/synapse/issues/6491)) - Fix small performance regression for sending invites. ([\#6493](https://github.com/matrix-org/synapse/issues/6493)) - Back out cross-signing code added in Synapse 1.5.0, which caused a performance regression. ([\#6494](https://github.com/matrix-org/synapse/issues/6494)) Improved Documentation ---------------------- - Update documentation and variables in user contributed systemd reference file. ([\#6369](https://github.com/matrix-org/synapse/issues/6369), [\#6490](https://github.com/matrix-org/synapse/issues/6490)) - Fix link in the user directory documentation. ([\#6388](https://github.com/matrix-org/synapse/issues/6388)) - Add build instructions to the docker readme. ([\#6390](https://github.com/matrix-org/synapse/issues/6390)) - Switch Ubuntu package install recommendation to use python3 packages in INSTALL.md. ([\#6443](https://github.com/matrix-org/synapse/issues/6443)) - Write some docs for the quarantine_media api. ([\#6458](https://github.com/matrix-org/synapse/issues/6458)) - Convert CONTRIBUTING.rst to markdown (among other small fixes). ([\#6461](https://github.com/matrix-org/synapse/issues/6461)) Deprecations and Removals ------------------------- - Remove admin/v1/users_paginate endpoint. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#5925](https://github.com/matrix-org/synapse/issues/5925)) - Remove fallback for federation with old servers which lack the /federation/v1/state_ids API. ([\#6488](https://github.com/matrix-org/synapse/issues/6488)) Internal Changes ---------------- - Add benchmarks for structured logging and improve output performance. ([\#6266](https://github.com/matrix-org/synapse/issues/6266)) - Improve the performance of outputting structured logging. ([\#6322](https://github.com/matrix-org/synapse/issues/6322)) - Refactor some code in the event authentication path for clarity. ([\#6343](https://github.com/matrix-org/synapse/issues/6343), [\#6468](https://github.com/matrix-org/synapse/issues/6468), [\#6480](https://github.com/matrix-org/synapse/issues/6480)) - Clean up some unnecessary quotation marks around the codebase. ([\#6362](https://github.com/matrix-org/synapse/issues/6362)) - Complain on startup instead of 500'ing during runtime when `public_baseurl` isn't set when necessary. ([\#6379](https://github.com/matrix-org/synapse/issues/6379)) - Add a test scenario to make sure room history purges don't break `/messages` in the future. ([\#6392](https://github.com/matrix-org/synapse/issues/6392)) - Clarifications for the email configuration settings. ([\#6423](https://github.com/matrix-org/synapse/issues/6423)) - Add more tests to the blacklist when running in worker mode. ([\#6429](https://github.com/matrix-org/synapse/issues/6429)) - Refactor data store layer to support multiple databases in the future. ([\#6454](https://github.com/matrix-org/synapse/issues/6454), [\#6464](https://github.com/matrix-org/synapse/issues/6464), [\#6469](https://github.com/matrix-org/synapse/issues/6469), [\#6487](https://github.com/matrix-org/synapse/issues/6487)) - Port synapse.rest.client.v1 to async/await. ([\#6482](https://github.com/matrix-org/synapse/issues/6482)) - Port synapse.rest.client.v2_alpha to async/await. ([\#6483](https://github.com/matrix-org/synapse/issues/6483)) - Port SyncHandler to async/await. ([\#6484](https://github.com/matrix-org/synapse/issues/6484)) -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEETQ1YthIGLQRddG54CTxDAAxPS/QFAl3uYYkACgkQCTxDAAxP S/QWMQ/8CKgO5cFl6kMxS6EjZJ6C8rA2QxP0iEcveqMj++yT3pQmdtQ5zzO100tS ZZYAdQbHkk/HWW8TIUtlxC+pcb9ZL0sZejY6dXzhD0dBVkFfhXQhJeFAkZnlf5lu CR8/kKTJ9IMgL6WtseOCoZQV/N9ifurWqqb8d0J5H5w1i//CP8opUQTn1a7lUzgm +1KleBv+A+gfltcm+NuC3+Q0GJNqfmtjcneOGwXXiuS3Ux8r2uLpbQsQfuNMMRkP ItmLJLy8hkP2yncrM9NE1Jkh0uOwcBJczbmT1OpXDIJiueFl7FxLKFXQM17QrpOT AqVDnVTlXfTDvWFeFstNz84uceXz98tLKZIl0X0inkN/wo3ZxMmzzxQw2Ob55ZPY pT6oC1gm0bGNQ/smEonyMM3z0ir7OfAce/tFQigfo59qeA08uzeckWkWpiXTbmy5 xu2lomhpQABBNBhEnVpm4+dMXeXWzz1NtkeC6auBn+eX19JqlWZM9WcuNfv4rC+M eg5mwv2qERBA+qLsZQLy0dEMUy9fIrjd0GklMl6GUKYiSAsbDIptYMZl504D9Emc adTY63BT7TTiu64lr+CiQ9BbWQkGJxM1MQ8BoYyaKvgtahmOi+0Y5R0RGmrG6Hju UhgMdjmt5HnN0wiepBFCth9nJq+XDdyls8xAKGtSzGt129krBP4= =queo -----END PGP SIGNATURE----- Merge tag 'v1.7.0rc1' into develop Synapse 1.7.0rc1 (2019-12-09) ============================= Features -------- - Implement per-room message retention policies. ([\#5815](https://github.com/matrix-org/synapse/issues/5815), [\#6436](https://github.com/matrix-org/synapse/issues/6436)) - Add etag and count fields to key backup endpoints to help clients guess if there are new keys. ([\#5858](https://github.com/matrix-org/synapse/issues/5858)) - Add `/admin/v2/users` endpoint with pagination. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#5925](https://github.com/matrix-org/synapse/issues/5925)) - Require User-Interactive Authentication for `/account/3pid/add`, meaning the user's password will be required to add a third-party ID to their account. ([\#6119](https://github.com/matrix-org/synapse/issues/6119)) - Implement the `/_matrix/federation/unstable/net.atleastfornow/state/<context>` API as drafted in MSC2314. ([\#6176](https://github.com/matrix-org/synapse/issues/6176)) - Configure privacy-preserving settings by default for the room directory. ([\#6354](https://github.com/matrix-org/synapse/issues/6354)) - Add ephemeral messages support by partially implementing [MSC2228](https://github.com/matrix-org/matrix-doc/pull/2228). ([\#6409](https://github.com/matrix-org/synapse/issues/6409)) - Add support for [MSC 2367](https://github.com/matrix-org/matrix-doc/pull/2367), which allows specifying a reason on all membership events. ([\#6434](https://github.com/matrix-org/synapse/issues/6434)) Bugfixes -------- - Transfer non-standard power levels on room upgrade. ([\#6237](https://github.com/matrix-org/synapse/issues/6237)) - Fix error from the Pillow library when uploading RGBA images. ([\#6241](https://github.com/matrix-org/synapse/issues/6241)) - Correctly apply the event filter to the `state`, `events_before` and `events_after` fields in the response to `/context` requests. ([\#6329](https://github.com/matrix-org/synapse/issues/6329)) - Fix caching devices for remote users when using workers, so that we don't attempt to refetch (and potentially fail) each time a user requests devices. ([\#6332](https://github.com/matrix-org/synapse/issues/6332)) - Prevent account data syncs getting lost across TCP replication. ([\#6333](https://github.com/matrix-org/synapse/issues/6333)) - Fix bug: TypeError in `register_user()` while using LDAP auth module. ([\#6406](https://github.com/matrix-org/synapse/issues/6406)) - Fix an intermittent exception when handling read-receipts. ([\#6408](https://github.com/matrix-org/synapse/issues/6408)) - Fix broken guest registration when there are existing blocks of numeric user IDs. ([\#6420](https://github.com/matrix-org/synapse/issues/6420)) - Fix startup error when http proxy is defined. ([\#6421](https://github.com/matrix-org/synapse/issues/6421)) - Fix error when using synapse_port_db on a vanilla synapse db. ([\#6449](https://github.com/matrix-org/synapse/issues/6449)) - Fix uploading multiple cross signing signatures for the same user. ([\#6451](https://github.com/matrix-org/synapse/issues/6451)) - Fix bug which lead to exceptions being thrown in a loop when a cross-signed device is deleted. ([\#6462](https://github.com/matrix-org/synapse/issues/6462)) - Fix `synapse_port_db` not exiting with a 0 code if something went wrong during the port process. ([\#6470](https://github.com/matrix-org/synapse/issues/6470)) - Improve sanity-checking when receiving events over federation. ([\#6472](https://github.com/matrix-org/synapse/issues/6472)) - Fix inaccurate per-block Prometheus metrics. ([\#6491](https://github.com/matrix-org/synapse/issues/6491)) - Fix small performance regression for sending invites. ([\#6493](https://github.com/matrix-org/synapse/issues/6493)) - Back out cross-signing code added in Synapse 1.5.0, which caused a performance regression. ([\#6494](https://github.com/matrix-org/synapse/issues/6494)) Improved Documentation ---------------------- - Update documentation and variables in user contributed systemd reference file. ([\#6369](https://github.com/matrix-org/synapse/issues/6369), [\#6490](https://github.com/matrix-org/synapse/issues/6490)) - Fix link in the user directory documentation. ([\#6388](https://github.com/matrix-org/synapse/issues/6388)) - Add build instructions to the docker readme. ([\#6390](https://github.com/matrix-org/synapse/issues/6390)) - Switch Ubuntu package install recommendation to use python3 packages in INSTALL.md. ([\#6443](https://github.com/matrix-org/synapse/issues/6443)) - Write some docs for the quarantine_media api. ([\#6458](https://github.com/matrix-org/synapse/issues/6458)) - Convert CONTRIBUTING.rst to markdown (among other small fixes). ([\#6461](https://github.com/matrix-org/synapse/issues/6461)) Deprecations and Removals ------------------------- - Remove admin/v1/users_paginate endpoint. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#5925](https://github.com/matrix-org/synapse/issues/5925)) - Remove fallback for federation with old servers which lack the /federation/v1/state_ids API. ([\#6488](https://github.com/matrix-org/synapse/issues/6488)) Internal Changes ---------------- - Add benchmarks for structured logging and improve output performance. ([\#6266](https://github.com/matrix-org/synapse/issues/6266)) - Improve the performance of outputting structured logging. ([\#6322](https://github.com/matrix-org/synapse/issues/6322)) - Refactor some code in the event authentication path for clarity. ([\#6343](https://github.com/matrix-org/synapse/issues/6343), [\#6468](https://github.com/matrix-org/synapse/issues/6468), [\#6480](https://github.com/matrix-org/synapse/issues/6480)) - Clean up some unnecessary quotation marks around the codebase. ([\#6362](https://github.com/matrix-org/synapse/issues/6362)) - Complain on startup instead of 500'ing during runtime when `public_baseurl` isn't set when necessary. ([\#6379](https://github.com/matrix-org/synapse/issues/6379)) - Add a test scenario to make sure room history purges don't break `/messages` in the future. ([\#6392](https://github.com/matrix-org/synapse/issues/6392)) - Clarifications for the email configuration settings. ([\#6423](https://github.com/matrix-org/synapse/issues/6423)) - Add more tests to the blacklist when running in worker mode. ([\#6429](https://github.com/matrix-org/synapse/issues/6429)) - Refactor data store layer to support multiple databases in the future. ([\#6454](https://github.com/matrix-org/synapse/issues/6454), [\#6464](https://github.com/matrix-org/synapse/issues/6464), [\#6469](https://github.com/matrix-org/synapse/issues/6469), [\#6487](https://github.com/matrix-org/synapse/issues/6487)) - Port synapse.rest.client.v1 to async/await. ([\#6482](https://github.com/matrix-org/synapse/issues/6482)) - Port synapse.rest.client.v2_alpha to async/await. ([\#6483](https://github.com/matrix-org/synapse/issues/6483)) - Port SyncHandler to async/await. ([\#6484](https://github.com/matrix-org/synapse/issues/6484))	2019-12-09 15:04:08 +00:00
Andrew Morgan	5e8abe9013	Better errors regarding changing avatar_url (#6497 )	2019-12-09 14:54:33 +00:00
Neil Johnson	24da1ffcb6	1.7.0rc1	2019-12-09 14:46:20 +00:00
Neil Johnson	adfdd82b21	Back out perf regression from get_cross_signing_keys_from_cache. (#6494 ) Back out cross-signing code added in Synapse 1.5.0, which caused a performance regression.	2019-12-09 13:59:27 +00:00
Erik Johnston	30e9adf32f	Merge pull request #6487 from matrix-org/erikj/pass_in_db Pass in Database object to data stores.	2019-12-09 13:53:21 +00:00
Erik Johnston	a1f8ea9051	Port synapse.handlers.initial_sync to async/await	2019-12-09 13:46:45 +00:00
Erik Johnston	f166a8d1f5	Remove SnapshotCache in favour of ResponseCache	2019-12-09 13:42:49 +00:00
Erik Johnston	e1544b0af8	Merge pull request #6493 from matrix-org/erikj/invite_state_config Pull out room_invite_state_types config option once.	2019-12-09 12:23:21 +00:00
Erik Johnston	65b37f6729	Fix comment Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2019-12-09 11:56:43 +00:00
Richard van der Hoff	18660a34d8	Fix inaccurate per-block metrics (#6491 ) `Measure` incorrectly assumed that it was the only thing being done by the parent `LoggingContext`. For instance, during a "renew group attestations" operation, hundreds of `outbound_request` calls could take place in parallel, all using the same `LoggingContext`. This would mean that any resources used during any of those calls would be reported against all of them, producing wildly inaccurate results. Instead, we now give each `Measure` block its own `LoggingContext` (using the parent `LoggingContext` mechanism to ensure that the log lines look correct and that the metrics are ultimately propogated to the top level for reporting against requests/backgrond tasks).	2019-12-09 11:55:30 +00:00
Erik Johnston	8ad8bcbed0	Pull out room_invite_state_types config option once. Pulling things out of config is currently surprisingly expensive.	2019-12-09 11:52:19 +00:00
Richard van der Hoff	e519489fc4	Remove fallback for missing /federation/v1/state_ids API (#6488 ) This API was added way back in 0.17.0; the code here is annoying to maintain and entirely redundant.	2019-12-09 11:37:26 +00:00
Erik Johnston	a9b393340f	Merge pull request #6484 from matrix-org/erikj/port_sync_handler Port SyncHandler to async/await	2019-12-09 11:32:44 +00:00
Erik Johnston	71ee22c0ba	Fix port db script	2019-12-06 16:41:48 +00:00
Erik Johnston	75f87450d8	Move start up DB checks to main data store.	2019-12-06 16:02:21 +00:00
Erik Johnston	d537be1ebd	Pass Database into the data store	2019-12-06 15:49:44 +00:00
Erik Johnston	d64bb32a73	Move are_all_users_on_domain checks to main data store.	2019-12-06 13:43:40 +00:00
Erik Johnston	9a4fb457cf	Change DataStores to accept 'database' param.	2019-12-06 13:30:06 +00:00
Erik Johnston	2ace775d88	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/make_database_class	2019-12-06 11:33:34 +00:00
Erik Johnston	e216ec381a	Remove unused var	2019-12-06 11:16:37 +00:00
Erik Johnston	b3a4e35ca8	Fixup functions to consistently return deferreds	2019-12-06 10:40:05 +00:00
Brendan Abolivier	e126d83f74	Merge branch 'develop' into babolivier/msc1802	2019-12-05 21:00:43 +00:00
Manuel Stahl	649b6bc088	Replace /admin/v1/users_paginate endpoint with /admin/v2/users (#5925 )	2019-12-05 18:12:23 +00:00
Erik Johnston	8437e2383e	Port SyncHandler to async/await	2019-12-05 17:58:25 +00:00
Erik Johnston	9c41ba4c5f	Port rest.client.v2	2019-12-05 16:56:23 +00:00
Erik Johnston	1a0997bbd5	Port rest/v1 to async/await	2019-12-05 15:57:28 +00:00
Richard van der Hoff	63d6ad1064	Stronger typing in the federation handler (#6480 ) replace the event_info dict with an attrs thing	2019-12-05 15:02:35 +00:00
Richard van der Hoff	e1f4c83f41	Sanity-check the rooms of auth events before pulling them in. (#6472 )	2019-12-05 14:14:45 +00:00
Erik Johnston	4a33a6dd19	Move background update handling out of store	2019-12-05 11:11:26 +00:00
Erik Johnston	8863624f78	Comments	2019-12-05 10:46:37 +00:00
Erik Johnston	756d4942f5	Move DB pool and helper functions into dedicated Database class	2019-12-05 10:46:37 +00:00
Erik Johnston	ddbbfc9512	Merge pull request #6464 from matrix-org/erikj/make_public_sql_base Clean up SQLBaseStore private function usage	2019-12-05 10:43:49 +00:00
Brendan Abolivier	fe799f353d	Merge pull request #6470 from matrix-org/babolivier/port_db_ci_failure Make synapse_port_db exit with a non-0 code if something failed	2019-12-04 18:20:36 +00:00
Brendan Abolivier	f8421a1404	Fix background updates for synapse_port_db	2019-12-04 17:57:35 +00:00
Richard van der Hoff	e203874caa	get rid of (most of) have_events from _update_auth_events_and_context_for_auth (#6468 ) have_events was a map from event_id to rejection reason (or None) for events which are in our local database. It was used as filter on the list of event_ids being passed into get_events_as_list. However, since get_events_as_list will ignore any event_ids that are unknown or rejected, we can equivalently just leave it to get_events_as_list to do the filtering. That means that we don't have to keep `have_events` up-to-date, and can use `have_seen_events` instead of `get_seen_events_with_rejection` in the one place we do need it.	2019-12-04 17:27:32 +00:00
Erik Johnston	ee86abb2d6	Remove underscore from SQLBaseStore functions	2019-12-04 16:23:43 +00:00
Erik Johnston	c2f525a525	Don't call SQLBaseStore methods from outside stores	2019-12-04 16:23:43 +00:00
Erik Johnston	3eb15c01d9	Merge pull request #6454 from matrix-org/erikj/clean_base_Store Move things out of SQLBaseStore	2019-12-04 16:23:19 +00:00
Erik Johnston	9186c105a0	Revert "Move get_user_count_txn out of base store" This reverts commit `00f0d67566`. Its going to get removed soon, so lets not make merge conflicts.	2019-12-04 15:46:19 +00:00
Erik Johnston	a7f20500ff	_CURRENT_STATE_CACHE_NAME is public	2019-12-04 15:45:42 +00:00
Erik Johnston	b9449012db	Merge pull request #6441 from syamgk/fix-parameter-mismatch Fix issue #6406 parameter mismatch	2019-12-04 15:42:33 +00:00
Brendan Abolivier	c530f9af4d	Merge pull request #6329 from matrix-org/babolivier/context_filters Filter state, events_before and events_after in /context requests	2019-12-04 15:24:16 +00:00
Erik Johnston	00f0d67566	Move get_user_count_txn out of base store	2019-12-04 15:21:14 +00:00
Erik Johnston	1056d6885a	Move cache invalidation to main data store	2019-12-04 15:21:14 +00:00
Erik Johnston	6b2867096b	Move event fetch vars to EventWorkStore	2019-12-04 15:21:14 +00:00
Erik Johnston	ddd48b6851	Move account validity bg updates to registration store	2019-12-04 15:21:14 +00:00
Brendan Abolivier	9dc84b7989	Merge branch 'develop' into babolivier/context_filters	2019-12-04 14:23:44 +00:00
Brendan Abolivier	08a436ecb2	Incorporate review	2019-12-04 14:18:46 +00:00
Erik Johnston	2aa8943809	Merge pull request #6451 from matrix-org/uhoreg/cross_signing_signatures_index make cross signing signature index non-unique	2019-12-04 09:57:09 +00:00
Neil Johnson	cb0aeb147e	privacy by default for room dir (#6355 ) Ensure that the the default settings for the room directory are that the it is hidden from public view by default.	2019-12-04 09:46:16 +00:00
Richard van der Hoff	0120875462	Fix exception when a cross-signed device is deleted (#6462 ) (hopefully) ... and deobfuscate the relevant bit of code.	2019-12-04 07:38:35 +00:00
Syam G Krishnan	ce1c975ebc	Issue #6406 Fix parameter mismatch Signed-off-by: Syam G Krishnan <syamgk01@gmail.com>	2019-12-04 13:03:46 +05:30
Hubert Chathi	418813b205	apply changes from review	2019-12-03 15:27:00 -05:00
Brendan Abolivier	54dd5dc12b	Add ephemeral messages support (MSC2228) (#6409 ) Implement part [MSC2228](https://github.com/matrix-org/matrix-doc/pull/2228). The parts that differ are: * the feature is hidden behind a configuration flag (`enable_ephemeral_messages`) * self-destruction doesn't happen for state events * only implement support for the `m.self_destruct_after` field (not the `m.self_destruct` one) * doesn't send synthetic redactions to clients because for this specific case we consider the clients to be able to destroy an event themselves, instead we just censor it (by pruning its JSON) in the database	2019-12-03 19:19:45 +00:00
Amber Brown	fdec84aa42	Add benchmarks for structured logging performance (#6266 )	2019-12-03 20:21:25 +11:00
Hubert Chathi	2252680a98	make cross signing signature index non-unique	2019-12-02 17:01:59 -05:00
Andrew Morgan	72078e4be5	Transfer power level state events on room upgrade (#6237 )	2019-12-02 15:11:32 +00:00
Filip Štědronský	81731c6e75	Fix: Pillow error when uploading RGBA image (#3325 ) (#6241 ) Signed-Off-By: Filip Štědronský <g@regnarg.cz>	2019-12-02 12:12:55 +00:00
Andrew Morgan	23ea572125	Add User-Interactive Auth to /account/3pid/add (#6119 )	2019-11-29 13:51:14 +00:00
Erik Johnston	1c3a61529f	Merge pull request #6434 from matrix-org/erikj/msc2367_membership_reasons Implement MSC 2367 - Membership Reasons	2019-11-29 13:30:36 +00:00
Brendan Abolivier	6d8576c4ce	Merge pull request #6436 from matrix-org/babolivier/fix-state-retrieval Discard retention policies when retrieving state	2019-11-29 11:25:11 +00:00
Brendan Abolivier	78ec11c085	Lint	2019-11-28 20:35:22 +00:00
Brendan Abolivier	708cef88cf	Discard retention policies when retrieving state Purge jobs don't delete the latest event in a room in order to keep the forward extremity and not break the room. On the other hand, get_state_events, when given an at_token argument calls filter_events_for_client to know if the user can see the event that matches that (sync) token. That function uses the retention policies of the events it's given to filter out those that are too old from a client's view. Some clients, such as Riot, when loading a room, request the list of members for the latest sync token it knows about, and get confused to the point of refusing to send any message if the server tells it that it can't get that information. This can happen very easily with the message retention feature turned on and a room with low activity so that the last event sent becomes too old according to the room's retention policy. An easy and clean fix for that issue is to discard the room's retention policies when retrieving state.	2019-11-28 19:26:26 +00:00
Andrew Morgan	96562131a4	Merge branch 'master' into develop	2019-11-28 12:08:02 +00:00
Erik Johnston	2173785f0d	Propagate reason in remotely rejected invites	2019-11-28 11:31:56 +00:00
Andrew Morgan	e7777f3668	1.6.1	2019-11-28 11:29:50 +00:00
Andrew Morgan	2030193e55	Remove local threepids on account deactivation (#6426 )	2019-11-28 11:07:45 +00:00
Erik Johnston	69d8fb83c6	MSC2367 Allow reason field on all member events	2019-11-28 11:02:04 +00:00
Andrew Morgan	a9c44d4008	Remove local threepids on account deactivation (#6426 )	2019-11-28 10:40:42 +00:00
Richard van der Hoff	c48ea98007	Clarifications for the email configuration settings. (#6423 ) Cf #6422	2019-11-28 09:29:18 +00:00
Amber Brown	0f87b912ab	Implementation of MSC2314 (#6176 )	2019-11-28 08:54:07 +11:00
Hubert Chathi	0d27aba900	add etag and count to key backup endpoints (#5858 )	2019-11-27 16:14:44 -05:00
Brendan Abolivier	d31f69afa0	Merge pull request #6358 from matrix-org/babolivier/message_retention Implement message retention policies (MSC1763)	2019-11-27 15:04:38 +00:00
Richard van der Hoff	9b9ee75666	Fix startup error when http proxy is defined. (#6421 ) Guess I only tested this on python 2 :/ Fixes #6419.	2019-11-27 10:29:10 +00:00
Andrew Morgan	ce578031f4	Remove assertion and provide a clear warning on startup for missing public_baseurl (#6379 )	2019-11-26 18:42:27 +00:00
Richard van der Hoff	651d930f16	Merge pull request #6343 from matrix-org/rav/event_auth/4 Refactor _update_auth_events_and_context_for_auth	2019-11-26 18:15:03 +00:00
Richard van der Hoff	ef1a85e773	Fix startup error when http proxy is defined. (#6421 ) Guess I only tested this on python 2 :/ Fixes #6419.	2019-11-26 18:10:50 +00:00
Brendan Abolivier	9e937c28ee	Merge branch 'develop' into babolivier/message_retention	2019-11-26 17:53:57 +00:00
Erik Johnston	f8f14ba466	Don't construct a set	2019-11-26 16:06:41 +00:00
Erik Johnston	8bb7b15894	Fix find_next_generated_user_id_localpart	2019-11-26 15:54:48 +00:00
Andrew Morgan	9fb350af65	Merge branch 'master' into develop	2019-11-26 14:15:30 +00:00
Andrew Morgan	a8175d0f96	Prevent account_data content from being sent over TCP replication (#6333 )	2019-11-26 13:58:39 +00:00
Andrew Morgan	b98971e8a4	1.6.0	2019-11-26 13:28:40 +00:00
Erik Johnston	65d54c5e8c	Fix phone home stats (#6418 ) Fix phone home stats	2019-11-26 13:28:40 +00:00
Erik Johnston	f9f1c8acbb	Merge pull request #6332 from matrix-org/erikj/query_devices_fix Fix caching devices for remote servers in worker.	2019-11-26 12:56:05 +00:00
Richard van der Hoff	4d394d6415	remove confusing fixme	2019-11-26 12:32:37 +00:00
Erik Johnston	35f9165e96	Fixup docs	2019-11-26 12:04:48 +00:00
Richard van der Hoff	c01d543584	Make sure that we close cursors before returning from a query (#6408 ) There are lots of words in the comment as to why this is a good idea. Fixes #6403.	2019-11-25 21:03:17 +00:00
Richard van der Hoff	07929bd62f	Synapse 1.6.0rc2 (2019-11-25) ============================= Bugfixes -------- - Fix a bug which could cause the background database update hander for event labels to get stuck in a loop raising exceptions. ([\#6407](https://github.com/matrix-org/synapse/issues/6407)) -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEv27Axt/F4vrTL/8QOSor00I9eP8FAl3b1yUACgkQOSor00I9 eP/dWQf+ORS/B853qyH5KPZ66o6d7WudSewPmEkFD3747CBevxBsTPETijkqTBlo WPOmQy9i5OUWpsFYrsrCH+ATpr0JYaIuuoHsIFq/BPFFUx64qrgDwL+X4QEShwAm kjGNtCMP6VNGjM6MqFepRHSTbIEamCCS665CgVJtqgRYRaAJYI3SQDQ64+ALcbx3 clFZowKV2EtfqhYR7HuBUuxuRjRPGcciNVyjMQFkKq91gKsO4rjPttvE4Bok29ia /uqFB6T0qty/81T708teZGgB/3/bYK4RtUA4lZCHBNeUejj26bESTI691RfBAEde to+D7xjA5zaMP3atYNlrvRrqK7Mm3w== =ucJN -----END PGP SIGNATURE----- Merge tag 'v1.6.0rc2' into develop Synapse 1.6.0rc2 (2019-11-25) ============================= Bugfixes -------- - Fix a bug which could cause the background database update hander for event labels to get stuck in a loop raising exceptions. ([\#6407](https://github.com/matrix-org/synapse/issues/6407))	2019-11-25 17:51:39 +00:00
Amber Brown	9eebd46048	Improve the performance of structured logging (#6322 )	2019-11-26 03:45:50 +11:00
Richard van der Hoff	f9c9e1f076	1.6.0rc2	2019-11-25 13:28:12 +00:00
Richard van der Hoff	b7367c339d	Fix exceptions from background database update for event labels. (#6407 ) Add some exception handling here so that events whose json cannot be parsed are ignored rather than getting us stuck in a loop. Fixes #6404.	2019-11-25 13:26:59 +00:00
Andrew Morgan	3916e1b97a	Clean up newline quote marks around the codebase (#6362 )	2019-11-21 12:00:14 +00:00
Andrew Morgan	41e4566682	1.6.0rc1	2019-11-20 14:12:42 +00:00
Manuel Stahl	4f5ca455bf	Move admin endpoints into separate files (#6308 )	2019-11-20 11:49:11 +00:00
Brendan Abolivier	83446a18fb	Merge pull request #6335 from matrix-org/erikj/rc_login_cleanups Only do `rc_login` ratelimiting on succesful login.	2019-11-20 09:52:38 +00:00
Brendan Abolivier	271c322d08	Lint	2019-11-20 09:29:48 +00:00
Brendan Abolivier	cdd3cb870d	Fix worker mode	2019-11-19 14:40:21 +00:00
Brendan Abolivier	a6fc6754f8	Fix 3PID invite exchange	2019-11-19 14:07:39 +00:00
Brendan Abolivier	97b863fe32	Lint again	2019-11-19 13:33:58 +00:00
Brendan Abolivier	bf9a11c54d	Lint again	2019-11-19 13:30:04 +00:00
Brendan Abolivier	7c24d0f443	Lint	2019-11-19 13:22:37 +00:00
Erik Johnston	c7376cdfe3	Apply suggestions from code review Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-Authored-By: Brendan Abolivier <babolivier@matrix.org>	2019-11-18 17:10:16 +00:00
Richard van der Hoff	870c00e278	Merge remote-tracking branch 'origin/develop' into rav/event_auth/4	2019-11-18 12:05:36 +00:00
Andrew Morgan	657d614f6a	Replace UPDATE with UPSERT on device_max_stream_id table (#6363 )	2019-11-15 14:02:34 +00:00
Andrew Morgan	745a48625d	Fix guest -> real account upgrade with account validity enabled (#6359 )	2019-11-14 12:02:05 +00:00
Andrew Morgan	a65a5ea125	Merge branch 'develop' of github.com:matrix-org/synapse into anoa/fix_account_data_sync * 'develop' of github.com:matrix-org/synapse: Blacklist PurgeRoomTestCase (#6361) Set room version default to 5	2019-11-14 10:26:56 +00:00
Andrew Morgan	473acedcdd	Merge branch 'develop' of github.com:matrix-org/synapse into anoa/homeserver_copy * 'develop' of github.com:matrix-org/synapse: Blacklist PurgeRoomTestCase (#6361) Set room version default to 5	2019-11-14 10:26:27 +00:00
Brendan Abolivier	a42567e4a8	Merge pull request #6220 from matrix-org/neilj/set_room_version_default_to_5 Set room version default to 5	2019-11-14 10:21:00 +00:00
Andrew Morgan	73d091be48	A couple more instances	2019-11-12 13:12:25 +00:00
Andrew Morgan	bc29a19731	Replace instance variations of homeserver with correct case/spacing	2019-11-12 13:08:12 +00:00
Brendan Abolivier	94cdd6fffe	Lint	2019-11-11 16:56:55 +00:00
Brendan Abolivier	edc4c7d4c5	Lint	2019-11-11 16:51:54 +00:00
Brendan Abolivier	5e18dc7955	Fix prefix for v2/send_leave	2019-11-11 16:46:09 +00:00
Brendan Abolivier	74897de01f	Add server-side support to the v2 API	2019-11-11 16:40:45 +00:00
Brendan Abolivier	1e202a90f1	Implement v2 API for send_leave	2019-11-11 16:26:53 +00:00
Brendan Abolivier	92527d7b21	Add missing yield	2019-11-11 16:20:53 +00:00
Brendan Abolivier	4c131b2c78	Implement v2 API for send_join	2019-11-11 15:47:47 +00:00
Andrew Morgan	cd96b4586f	lint	2019-11-08 15:45:45 +00:00
Andrew Morgan	c4bdf2d785	Remove content from being sent for account data rdata stream	2019-11-08 15:44:02 +00:00
Richard van der Hoff	f41027f746	Use get_events_as_list rather than lots of calls to get_event It's more efficient and clearer.	2019-11-08 12:21:28 +00:00
Richard van der Hoff	f8407975e7	Update some docstrings and comments	2019-11-08 12:18:20 +00:00
Richard van der Hoff	772d414975	Simplify _update_auth_events_and_context_for_auth move event_key calculation into _update_context_for_auth_events, since it's only used there.	2019-11-08 11:40:11 +00:00
Brendan Abolivier	963ffb60b9	Merge pull request #6340 from matrix-org/babolivier/pagination_query Fix the SQL SELECT query in _paginate_room_events_txn	2019-11-08 11:12:24 +00:00
Brendan Abolivier	b16fa43386	Incorporate review	2019-11-08 10:34:09 +00:00
Erik Johnston	f713c01e2b	Merge pull request #6295 from matrix-org/erikj/split_purge_history Split purge API into events vs state and add PurgeEventsStorage	2019-11-08 10:19:15 +00:00
Erik Johnston	e4ec82ce0f	Move type annotation into docstring	2019-11-08 09:50:48 +00:00
Brendan Abolivier	46e5db9eb2	Merge pull request #6310 from matrix-org/babolivier/msc2326_bg_update MSC2326: Add background update to take previous events into account	2019-11-07 22:54:56 +00:00
Brendan Abolivier	dad8d68c99	Update synapse/storage/data_stores/main/events_bg_updates.py Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2019-11-07 17:01:53 +00:00
Brendan Abolivier	6d360f099f	Update synapse/storage/data_stores/main/events_bg_updates.py Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2019-11-07 17:01:43 +00:00
Brendan Abolivier	c9b27d0044	Copy results	2019-11-07 16:47:45 +00:00
Brendan Abolivier	cd31201267	Revert "Back to using cursor_to_dict" This reverts commit `1186612d6c`.	2019-11-07 16:47:15 +00:00
Brendan Abolivier	1186612d6c	Back to using cursor_to_dict	2019-11-07 16:46:41 +00:00
Brendan Abolivier	ec2cb9f298	Initialise value before looping	2019-11-07 16:18:40 +00:00
Brendan Abolivier	bb78276bdc	Incorporate review	2019-11-07 15:25:27 +00:00
Brendan Abolivier	b9cba07962	Lint	2019-11-07 14:57:15 +00:00
Brendan Abolivier	70804392ae	Only join on event_labels if we're filtering on labels	2019-11-07 14:55:10 +00:00
Brendan Abolivier	15a1a02e70	Handle lack of filter	2019-11-07 12:04:37 +00:00
Brendan Abolivier	3f9b61ff95	Fix the SQL SELECT query in _paginate_room_events_txn Doing a SELECT DISTINCT when paginating is quite expensive, because it requires the engine to do sorting on the entire events table. However, we only need to run it if we're filtering on 2+ labels, so this PR is changing the request so that DISTINCT is only used then.	2019-11-07 11:51:11 +00:00
Andrew Morgan	e914cf12f6	Merge pull request #6235 from matrix-org/anoa/room_upgrade_groups	2019-11-07 11:12:22 +00:00
V02460	affcc2cc36	Fix LruCache callback deduplication (#6213 )	2019-11-07 09:43:51 +00:00
Brendan Abolivier	f03c9d3444	Don't apply retention policy based filtering on state events As per MSC1763, 'Retention is only considered for non-state events.', so don't filter out state events based on the room's retention policy.	2019-11-06 18:40:04 +00:00
Brendan Abolivier	eda14737cf	Also filter state events	2019-11-06 18:14:03 +00:00
Andrew Morgan	a6ebef1bfd	Make numeric user_id checker start at @0, and don't ratelimit on checking (#6338 )	2019-11-06 17:21:20 +00:00
Erik Johnston	5c3363233c	Fix deleting state groups during room purge. And fix the tests to actually test that things got deleted.	2019-11-06 17:02:08 +00:00
Erik Johnston	71f3bd734f	Use correct type annotation	2019-11-06 17:00:18 +00:00
Andrew Morgan	55bc8d531e	raise exception after multiple failures	2019-11-06 16:52:54 +00:00
Andrew Morgan	1fe3cc2c9c	Address review comments	2019-11-06 14:54:24 +00:00
Richard van der Hoff	915903eada	Merge branch 'master' into develop	2019-11-06 13:51:11 +00:00
Andrew Morgan	4059d61e26	Don't forget to ratelimit calls outside of RegistrationHandler	2019-11-06 12:01:54 +00:00
Andrew Morgan	b33c4f7a82	Numeric ID checker now checks @0, don't ratelimit on checking	2019-11-06 11:55:00 +00:00
Erik Johnston	f697b4b4a2	Add failed auth ratelimiting to UIA	2019-11-06 11:08:58 +00:00
Erik Johnston	541f1b92d9	Only do `rc_login` ratelimiting on succesful login. We were doing this in a number of places which meant that some login code paths incremented the counter multiple times. It was also applying ratelimiting to UIA endpoints, which was probably not intentional. In particular, some custom auth modules were calling `check_user_exists`, which incremented the counters, meaning that people would fail to login sometimes.	2019-11-06 11:08:58 +00:00
Brendan Abolivier	24a214bd1b	Fix field name	2019-11-06 11:04:19 +00:00
Brendan Abolivier	70d93cafdb	Update insert	2019-11-06 10:59:03 +00:00
Richard van der Hoff	feafd98aca	1.5.1	2019-11-06 10:02:23 +00:00
Richard van der Hoff	807ec3bd99	Fix bug which caused rejected events to be stored with the wrong room state (#6320 ) Fixes a bug where rejected events were persisted with the wrong state group. Also fixes an occasional internal-server-error when receiving events over federation which are rejected and (possibly because they are backwards-extremities) have no prev_group. Fixes #6289.	2019-11-06 10:01:39 +00:00
Richard van der Hoff	0e3ab8afdc	Add some checks that we aren't using state from rejected events (#6330 ) * Raise an exception if accessing state for rejected events Add some sanity checks on accessing state_group etc for rejected events. * Skip calculating push actions for rejected events It didn't actually cause any bugs, because rejected events get filtered out at various later points, but there's not point in trying to calculate the push actions for a rejected event.	2019-11-05 22:13:37 +00:00
Erik Johnston	01ba7b38a7	Merge pull request #6336 from matrix-org/erikj/fix_phone_home_stats Fix phone home stats	2019-11-05 18:29:57 +00:00
Erik Johnston	052513958d	Fix phone home stats	2019-11-05 17:44:09 +00:00
Richard van der Hoff	5570d1c93f	Merge pull request #6334 from matrix-org/rav/url_preview_limit_title_2 Fix exception when OpenGraph tag values are ints	2019-11-05 17:28:11 +00:00
Richard van der Hoff	81d49cbb07	Fix exception when OpenGraph tag values are ints	2019-11-05 17:22:58 +00:00
Richard van der Hoff	55a7da247a	Merge branch 'develop' into rav/url_preview_limit_title	2019-11-05 17:08:07 +00:00
Richard van der Hoff	e78167c94b	Apply suggestions from code review Co-Authored-By: Brendan Abolivier <babolivier@matrix.org> Co-Authored-By: Erik Johnston <erik@matrix.org>	2019-11-05 16:46:39 +00:00
Richard van der Hoff	e9bfe719ba	Strip overlong OpenGraph data from url preview ... to stop people causing DoSes with malicious web pages	2019-11-05 15:51:18 +00:00
Erik Johnston	c16e192e2f	Fix caching devices for remote servers in worker. When the `/keys/query` API is hit on client_reader worker Synapse may decide that it needs to resync some remote deivces. Usually this happens on master, and then gets cached. However, that fails on workers and so it falls back to fetching devices from remotes directly, which may in turn fail if the remote is down.	2019-11-05 15:49:43 +00:00
Brendan Abolivier	cb2cbe4d26	Only filter if a filter was provided	2019-11-05 15:28:36 +00:00
Brendan Abolivier	f141af4c79	Update copyright	2019-11-05 14:52:38 +00:00
Brendan Abolivier	8822b33111	Update copyrights	2019-11-05 14:46:35 +00:00
Richard van der Hoff	4086002827	Improve documentation for EventContext fields (#6319 )	2019-11-05 13:23:25 +00:00
Brendan Abolivier	1dffa78701	Filter events_before and events_after in /context requests While the current version of the spec doesn't say much about how this endpoint uses filters (see https://github.com/matrix-org/matrix-doc/issues/2338), the current implementation is that some fields of an EventFilter apply (the ones that are used when running the SQL query) and others don't (the ones that are used by the filter itself) because we don't call event_filter.filter(...). This seems counter-intuitive and probably not what we want so this commit fixes it.	2019-11-05 12:21:59 +00:00
Erik Johnston	ffe595381d	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/split_purge_history	2019-11-05 10:27:41 +00:00
Andrew Morgan	506a63de67	Merge branch 'develop' of github.com:matrix-org/synapse into anoa/room_upgrade_groups	2019-11-04 18:22:41 +00:00
Andrew Morgan	c2203bea57	Re-add docstring, with caveats detailed	2019-11-04 18:17:11 +00:00
Brendan Abolivier	e252ffadbc	Merge branch 'develop' into babolivier/msc2326_bg_update	2019-11-04 18:09:50 +00:00
Andrew Morgan	0287d033ee	Transfer upgraded rooms on groups	2019-11-04 18:08:50 +00:00
Amber Brown	4e1c7b79fa	Remove the psutil dependency (#6318 ) * remove psutil and replace with resource	2019-11-05 05:05:48 +11:00
Brendan Abolivier	09957ce0e4	Implement per-room message retention policies	2019-11-04 17:09:22 +00:00
Erik Johnston	7134ca7daa	Change to not require a state_groups.room_id index. This does mean that we won't clean up orphaned state groups (i.e. state groups that were persisted but the associated event wasn't).	2019-11-04 13:36:57 +00:00
Erik Johnston	6a0092d371	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/split_purge_history	2019-11-04 13:29:35 +00:00
Richard van der Hoff	cc6243b4c0	document the REPLICATE command a bit better (#6305 ) since I found myself wonder how it works	2019-11-04 12:40:18 +00:00
Brendan Abolivier	3b29a73f9f	Print out the actual number of affected rows	2019-11-04 09:56:11 +00:00
Brendan Abolivier	824bba2f78	Correctly order results	2019-11-04 09:56:11 +00:00
Brendan Abolivier	49008e674f	TODO	2019-11-04 09:56:11 +00:00
Brendan Abolivier	1586f2c7e7	Fix exit condition	2019-11-04 09:56:11 +00:00
Brendan Abolivier	1c1268245d	Lint	2019-11-04 09:56:11 +00:00
Brendan Abolivier	911b03ca31	Don't try to process events we already have a label for	2019-11-04 09:56:10 +00:00
Brendan Abolivier	07cb38e965	Use a sensible default value for labels	2019-11-04 09:56:10 +00:00
Brendan Abolivier	a46574281d	Use the right format for rows	2019-11-04 09:56:10 +00:00
Brendan Abolivier	c9a1b80a74	MSC2326: Add background update to take previous events into account	2019-11-04 09:56:04 +00:00
Brendan Abolivier	f496d25877	Merge pull request #6301 from matrix-org/babolivier/msc2326 Implement MSC2326 (label based filtering)	2019-11-01 17:04:45 +00:00
Brendan Abolivier	988d8d6507	Incorporate review	2019-11-01 16:22:44 +00:00
Richard van der Hoff	c6516adbe0	Factor out an _AsyncEventContextImpl (#6298 ) The intention here is to make it clearer which fields we can expect to be populated when: notably, that the _event_type etc aren't used for the synchronous impl of EventContext.	2019-11-01 16:19:09 +00:00
Brendan Abolivier	5598445655	Update synapse/storage/data_stores/main/schema/delta/56/event_labels.sql Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2019-11-01 16:18:34 +00:00
Hubert Chathi	fa7e52caf1	Merge pull request #6313 from matrix-org/uhoreg/cross_signing_fix_sqlite_schema fix hidden field in devices table for older sqlite	2019-11-01 10:52:46 -04:00
Richard van der Hoff	1cb84c6486	Support for routing outbound HTTP requests via a proxy (#6239 ) The `http_proxy` and `HTTPS_PROXY` env vars can be set to a `host[:port]` value which should point to a proxy. The address of the proxy should be excluded from IP blacklists such as the `url_preview_ip_range_blacklist`. The proxy will then be used for * push * url previews * phone-home stats * recaptcha validation * CAS auth validation It will not be used for: * Application Services * Identity servers * Outbound federation * In worker configurations, connections from workers to masters Fixes #4198.	2019-11-01 14:07:44 +00:00
Andrew Morgan	fe1f2b4520	Remove last usages of deprecated logging.warn method (#6314 )	2019-11-01 12:03:44 +00:00
Brendan Abolivier	a2c63c619a	Add more data to the event_labels table and fix the indexes	2019-11-01 11:47:28 +00:00
Erik Johnston	669b6cbda3	Fix up comment	2019-11-01 11:32:20 +00:00
Brendan Abolivier	e3689ac6f7	Add unstable feature flag	2019-11-01 10:41:23 +00:00
Brendan Abolivier	57cdb046e4	Lint	2019-11-01 10:39:14 +00:00
Brendan Abolivier	c6dbca2422	Incorporate review	2019-11-01 10:30:51 +00:00
Andrew Morgan	ace947e8da	Depublish a room from the public rooms list when it is upgraded (#6232 )	2019-11-01 10:28:09 +00:00
Hubert Chathi	c61db13183	fix hidden field in devices table for older sqlite	2019-10-31 22:52:55 -04:00
Hubert Chathi	c3fc176c60	Update synapse/storage/data_stores/main/devices.py Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2019-10-31 22:49:48 -04:00
Hubert Chathi	6f4bc6d01d	Merge branch 'develop' into cross-signing_federation	2019-10-31 22:38:21 -04:00
Hubert Chathi	3b4216f961	Merge pull request #6254 from matrix-org/uhoreg/cross_signing_fix_workers_notify make notification of signatures work with workers	2019-10-31 22:35:03 -04:00
Will Hunt	42e707c663	rstrip slashes from url on appservice (#6306 )	2019-10-31 17:32:25 +00:00
Hubert Chathi	9c94b48bf1	Merge branch 'develop' into uhoreg/cross_signing_fix_workers_notify	2019-10-31 12:32:07 -04:00
Hubert Chathi	f7e4a582ef	clean up code a bit	2019-10-31 12:01:00 -04:00
Erik Johnston	fb1a6914cf	Update log line to lie a little less	2019-10-31 15:45:48 +00:00
Amber Brown	020add5099	Update black to 19.10b0 (#6304 ) * update version of black and also fix the mypy config being overridden	2019-11-01 02:43:24 +11:00
Erik Johnston	61be1a2926	Add state_groups.room_id index	2019-10-31 15:39:26 +00:00
Erik Johnston	f91f2a1f92	Docstrings	2019-10-31 15:26:00 +00:00
Erik Johnston	8f5bbdb987	Fix purge room API	2019-10-31 15:22:08 +00:00
Erik Johnston	cd581338cf	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/split_purge_history	2019-10-31 15:19:26 +00:00
Erik Johnston	dfe0cd71b6	Merge pull request #6294 from matrix-org/erikj/add_state_storage Add StateGroupStorage interface	2019-10-31 16:17:53 +01:00
Travis Ralston	3a74c03ffb	Expose some homeserver functionality to spam checkers (#6259 ) * Offer the homeserver instance to the spam checker * Newsfile * Linting * Expose a Spam Checker API instead of passing the homeserver object * Alter changelog * s/hs/api	2019-10-31 09:16:14 -06:00
Erik Johnston	64f2b8c3d8	Apply suggestions from code review Fix docstring Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2019-10-31 15:44:31 +01:00
Erik Johnston	c6bcd38841	Fix /purge_room API. It fails trying to clean the `topic` table which was recently removed.	2019-10-31 11:17:23 +00:00
Andrew Morgan	54fef094b3	Remove usage of deprecated logger.warn method from codebase (#6271 ) Replace every instance of `logger.warn` with `logger.warning` as the former is deprecated.	2019-10-31 10:23:24 +00:00
Hubert Chathi	998f7fe7d4	make user signatures a separate stream	2019-10-30 17:22:52 -04:00
Hubert Chathi	670972c0e1	Merge branch 'develop' into uhoreg/cross_signing_fix_workers_notify	2019-10-30 16:46:31 -04:00
Hubert Chathi	bb6cec27a5	rename get_devices_by_remote to get_device_updates_by_remote	2019-10-30 14:57:34 -04:00
Richard van der Hoff	0467f33584	fix delete_existing for _persist_events (#6300 ) this is part of _retry_on_integrity_error, so should only be on _persist_events_and_state_updates	2019-10-30 18:05:00 +00:00
Brendan Abolivier	dcc069a2e2	Lint	2019-10-30 18:01:56 +00:00
Brendan Abolivier	fe51d6cacf	Add more integration testing	2019-10-30 17:28:41 +00:00
Brendan Abolivier	e7943f660a	Add unit tests	2019-10-30 16:15:04 +00:00
Brendan Abolivier	233b14ebe1	Add index on label	2019-10-30 15:58:05 +00:00
Brendan Abolivier	acd16ad86a	Implement filtering	2019-10-30 15:56:33 +00:00
Erik Johnston	7c8c97e635	Split purge API into events vs state	2019-10-30 15:23:37 +00:00
Erik Johnston	69f0054ce6	Port to use state storage	2019-10-30 14:46:54 +00:00
Erik Johnston	5db03535d5	Add StateGroupStorage interface	2019-10-30 14:46:49 +00:00
Brendan Abolivier	fa0dcbc8fa	Store labels for new events	2019-10-30 14:27:15 +00:00
Hubert Chathi	7d7eac61be	Merge branch 'develop' into cross-signing_federation	2019-10-30 10:17:10 -04:00
Hubert Chathi	bc32f102cd	black	2019-10-30 10:07:36 -04:00
Hubert Chathi	d78b1e339d	apply changes as a result of PR review	2019-10-30 10:01:53 -04:00
Erik Johnston	ec6de1cc7d	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/split_out_persistence_store	2019-10-30 13:37:04 +00:00
Erik Johnston	a8d16f6c00	Review comments	2019-10-30 13:36:12 +00:00
Erik Johnston	e5c3a99091	Merge pull request #6291 from matrix-org/erikj/fix_cache_descriptor Make ObservableDeferred.observe() always return deferred.	2019-10-30 14:06:34 +01:00
Erik Johnston	6e677403b7	Clarify docstring	2019-10-30 11:52:04 +00:00
Erik Johnston	326b3dace7	Make ObservableDeferred.observe() always return deferred. This makes it easier to use in an async/await world. Also fixes a bug where cache descriptors would occaisonally return a raw value rather than a deferred.	2019-10-30 11:35:46 +00:00
Andrew Morgan	a2276d4d3c	Fix log line that was printing undefined value (#6278 )	2019-10-30 11:28:48 +00:00
Andrew Morgan	7955abeaac	Fix small typo in comment (#6269 )	2019-10-30 11:16:19 +00:00
Andrew Morgan	46c12918ad	Fix typo in domain name in account_threepid_delegates config option (#6273 )	2019-10-30 11:07:42 +00:00
Andrew Morgan	b39ca49db1	Handle FileNotFound error in checking git repository version (#6284 )	2019-10-30 11:00:15 +00:00
Erik Johnston	770d1ef673	Merge pull request #6280 from matrix-org/erikj/receipts_async_await Port receipt and read markers to async/wait	2019-10-30 11:44:18 +01:00
Erik Johnston	ba4cc5541c	Merge pull request #6274 from matrix-org/erikj/replication_async Port replication http server endpoints to async/await	2019-10-30 11:44:08 +01:00
Erik Johnston	72bc6294ed	Merge pull request #6275 from matrix-org/erikj/port_rest_events Port room rest handlers to async/await	2019-10-30 11:44:02 +01:00
Brendan Abolivier	47f767269c	Add database table for keeping track of labels on events	2019-10-29 16:56:22 +00:00
Erik Johnston	a287f1e804	Don't return coroutines	2019-10-29 16:36:46 +00:00
Erik Johnston	38474707b9	Merge branch 'erikj/federation_server_async_await' of github.com:matrix-org/synapse into erikj/receipts_async_await	2019-10-29 15:53:17 +00:00
Erik Johnston	74c1e16106	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/federation_server_async_await	2019-10-29 15:52:39 +00:00
Erik Johnston	307e313ef4	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/port_rest_events	2019-10-29 15:51:12 +00:00
Erik Johnston	d6e40e7cbd	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/replication_async	2019-10-29 15:42:58 +00:00
Erik Johnston	2c35ffead2	Port receipt and read markers to async/wait	2019-10-29 15:08:22 +00:00
Erik Johnston	09a135b039	Make concurrently_execute work with async/await	2019-10-29 15:02:23 +00:00
Richard van der Hoff	65cb307e19	Merge branch 'master' into develop	2019-10-29 14:40:57 +00:00
Richard van der Hoff	9ffcf0f7ba	1.5.0	2019-10-29 14:28:54 +00:00
Erik Johnston	3f33879be4	Port federation_server to async/await	2019-10-29 14:13:08 +00:00
Erik Johnston	9be41bc121	Port room rest handlers to async/await	2019-10-29 13:09:29 +00:00
Erik Johnston	e577a4b2ad	Port replication http server endpoints to async/await	2019-10-29 13:00:51 +00:00
Erik Johnston	561133c3c5	Merge pull request #6263 from matrix-org/erikj/caches_return_deferreds Quick fix to ensure cache descriptors always return deferreds	2019-10-29 12:53:21 +01:00
Erik Johnston	e6c7e239ef	Update docstring	2019-10-29 11:48:30 +00:00
Erik Johnston	e419c44ba4	Merge branch 'release-v1.5.0' of github.com:matrix-org/synapse into develop	2019-10-29 11:41:27 +00:00
Erik Johnston	342d871d76	Make room directory search case insensitive	2019-10-29 10:24:02 +00:00
Brendan Abolivier	14504ad573	Add CI for synapse_port_db (#6140 ) This adds: * a test sqlite database * a configuration file for the sqlite database * a configuration file for a postgresql database (using the credentials in `.buildkite/docker-compose.pyXX.pgXX.yaml`) as well as a new script named `.buildkite/scripts/test_synapse_port_db.sh` that: 1. installs Synapse 2. updates the test sqlite database to the latest schema and runs background updates on it 3. creates an empty postgresql database 4. run the `synapse_port_db` script to migrate the test sqlite database to the empty postgresql database (with coverage) Step `2` is done via a new script located at `scripts-dev/update_database`. The test sqlite database is extracted from a SyTest run, so that it can be considered as an actual homeserver's database with actual data in it.	2019-10-28 17:45:32 +00:00
Erik Johnston	d0d8a22c13	Quick fix to ensure cache descriptors always return deferreds	2019-10-28 13:33:04 +00:00
Richard van der Hoff	bcfc647e4d	Synapse 1.5.0rc2 (2019-10-28) ============================= Bugfixes -------- - Update list of boolean columns in `synapse_port_db`. ([\#6247](https://github.com/matrix-org/synapse/issues/6247)) - Fix /keys/query API on workers. ([\#6256](https://github.com/matrix-org/synapse/issues/6256)) - Improve signature checking on some federation APIs. ([\#6262](https://github.com/matrix-org/synapse/issues/6262)) Internal Changes ---------------- - Move schema delta files to the correct data store. ([\#6248](https://github.com/matrix-org/synapse/issues/6248)) - Small performance improvement by removing repeated config lookups in room stats calculation. ([\#6255](https://github.com/matrix-org/synapse/issues/6255)) -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEv27Axt/F4vrTL/8QOSor00I9eP8FAl225VkACgkQOSor00I9 eP/7wwf6AkQE1dGYDPpmS29XYocfD3EbjT8FojaHTz1gbkIt5rEF88QHzwRo4P/x 1S1kQZpEKxKrwmLMDmSbw9STK/76LKGk9k8VycVHfTdy8SICCiL50pVPpSTJ4nXV 905E7nY0zau3wunWJD4gEjqll967W0AtNKwCHO0D6vNP4pcQNhTkSjhnmypXCFGo bvV9r0wq8mtq/FS1GX0Y2CEwbbV1MoPrvlXW37t/gBPk3P1QB/vPjakxO8LgeuZf JzAamP5jOYZJpPCpZxwDm6ZNEQ7T4jORdA623wp1gh1nTG88cObCLXJe2jCnpjnJ QVb1YlJiwcehXkclIoywgIzj13iIsw== =7ctT -----END PGP SIGNATURE----- Merge tag 'v1.5.0rc2' into develop Synapse 1.5.0rc2 (2019-10-28) ============================= Bugfixes -------- - Update list of boolean columns in `synapse_port_db`. ([\#6247](https://github.com/matrix-org/synapse/issues/6247)) - Fix /keys/query API on workers. ([\#6256](https://github.com/matrix-org/synapse/issues/6256)) - Improve signature checking on some federation APIs. ([\#6262](https://github.com/matrix-org/synapse/issues/6262)) Internal Changes ---------------- - Move schema delta files to the correct data store. ([\#6248](https://github.com/matrix-org/synapse/issues/6248)) - Small performance improvement by removing repeated config lookups in room stats calculation. ([\#6255](https://github.com/matrix-org/synapse/issues/6255))	2019-10-28 12:59:13 +00:00
Richard van der Hoff	c482d45822	1.5.0rc2	2019-10-28 12:48:18 +00:00
Richard van der Hoff	172f264ed3	Improve signature checking on some federation APIs (#6262 ) Make sure that we check that events sent over /send_join, /send_leave, and /invite, are correctly signed and come from the expected servers.	2019-10-28 12:43:23 +00:00
Richard van der Hoff	9aee28927b	Convert EventContext to attrs (#6218 ) * make EventContext use an attr	2019-10-28 14:29:55 +02:00
Hubert Chathi	da78f61778	Merge pull request #6253 from matrix-org/uhoreg/e2e_backup_delete_keys delete keys when deleting backup versions	2019-10-25 11:28:11 -04:00
Erik Johnston	64c2cfda8a	Merge branch 'release-v1.5.0' of github.com:matrix-org/synapse into develop	2019-10-25 11:34:49 +01:00
Erik Johnston	87259b3a3a	Merge pull request #6255 from matrix-org/erikj/stats_config Remove repeated calls to config.stats_enabled.	2019-10-25 11:34:38 +01:00
Erik Johnston	a71b8c87ec	Merge branch 'release-v1.5.0' of github.com:matrix-org/synapse into develop	2019-10-25 11:32:24 +01:00
Erik Johnston	a411f2b177	Fix /keys/query API on workers. The necessary getters were added only to the master store and not the worker stores.	2019-10-25 11:08:03 +01:00
Erik Johnston	f666d6f5d7	Remove repeated calls to config.stats_enabled. Turns out that fetching variables from the config object is expensive, so doing it once at startup avoids unnecessary work.	2019-10-25 10:28:36 +01:00
Erik Johnston	44ab048cfe	Merge pull request #6251 from matrix-org/michaelkaye/debug_guard_logging Reduce debug logging overhead	2019-10-25 10:05:44 +01:00
Hubert Chathi	c40d7244f8	Merge branch 'develop' into cross-signing_federation	2019-10-24 22:31:25 -04:00
Hubert Chathi	8ac766c44a	make notification of signatures work with workers	2019-10-24 22:14:58 -04:00
Hubert Chathi	ff05c9b760	don't error if federation query doesn't have cross-signing keys	2019-10-24 21:46:11 -04:00
Hubert Chathi	848cd388d9	delete keys when deleting backups	2019-10-24 21:21:51 -04:00
Michael Kaye	e4d98188da	Address codestyle concerns	2019-10-24 18:43:13 +01:00
Michael Kaye	8f4a808d9d	Delay printf until logging is required. Using % will cause the string to be generated even if debugging is off.	2019-10-24 18:31:53 +01:00
Michael Kaye	9eebc1e73b	use %r to __repr__ objects This avoids calculating __repr__ unless we are going to log.	2019-10-24 18:18:56 +01:00
Michael Kaye	f85b9842f0	Don't encode object as UTF-8 string if not needed. I believe that string formatting ~10-15 sized events will take a proportion of CPU time.	2019-10-24 18:08:45 +01:00
Michael Kaye	39266a9c9f	Make user/room stats log line less verbose.	2019-10-24 17:55:53 +01:00
Erik Johnston	3aa2a90556	Move schema delta files to the correct data store. They were put in the global schema delta directory due to a bad merge.	2019-10-24 16:45:03 +01:00
Andrew Morgan	8831b04a53	1.5.0rc1	2019-10-24 12:47:58 +01:00
Neil Johnson	2794b79052	Option to suppress resource exceeded alerting (#6173 ) The expected use case is to suppress MAU limiting on small instances	2019-10-24 11:48:46 +01:00
Andrew Morgan	92e88a71d3	Cleanup extra quotes from IDEs (#6236 )	2019-10-23 16:49:05 +01:00
Erik Johnston	3ca4c7c516	Use new EventPersistenceStore	2019-10-23 16:15:03 +01:00
Erik Johnston	73cf63784b	Add DataStores and Storage classes.	2019-10-23 16:15:03 +01:00
Hubert Chathi	dc2cd6f79d	move get_e2e_cross_signing_key to EndToEndKeyWorkerStore so it works with workers	2019-10-23 09:13:47 -04:00
Erik Johnston	22a9847670	Move persist_events out from main data store. This is in preparation for splitting out of state_groups_state from the main store into it own one, as persisting events depends on calculating state.	2019-10-23 13:29:44 +01:00
Andrew Morgan	409c62b27b	Add config linting script that checks for bool casing (#6203 ) Add a linting script that enforces all boolean values in the default config be lowercase. This has annoyed me for a while so I decided to fix it.	2019-10-23 13:22:54 +01:00
Hubert Chathi	480eac30eb	black	2019-10-22 22:37:16 -04:00
Hubert Chathi	404e8c8532	vendor-prefix the EDU name until MSC1756 is merged into the spec	2019-10-22 22:33:23 -04:00
Hubert Chathi	1fabf82d50	update to work with newer code, and fix formatting	2019-10-22 21:44:58 -04:00
Hubert Chathi	41ad35b523	add missing param	2019-10-22 19:06:29 -04:00
Hubert Chathi	cfdb84422d	make black happy	2019-10-22 19:06:06 -04:00
Hubert Chathi	a1aaf3eea6	don't crash if the user doesn't have cross-signing keys	2019-10-22 19:04:37 -04:00
Hubert Chathi	8d3542a64e	implement federation parts of cross-signing	2019-10-22 19:04:35 -04:00
Erik Johnston	c17efdc01c	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/refactor_stores	2019-10-22 18:44:29 +01:00
Erik Johnston	23d62eded2	Clean up prepare_database.py a bit and add comments	2019-10-22 18:43:31 +01:00
Erik Johnston	6cc497f99b	Delete background_update table creation in main data_store	2019-10-22 18:02:50 +01:00
Erik Johnston	1bbc5444a8	Move README into synapse/storage/__init__.py	2019-10-22 17:59:31 +01:00
Hubert Chathi	2761731634	Merge pull request #5726 from matrix-org/uhoreg/e2e_cross-signing2-part2 Cross-signing [3/4] -- uploading signatures edition	2019-10-22 17:05:06 +01:00
Erik Johnston	acf47c7698	Add a basic README to synapse.storage	2019-10-22 11:55:46 +01:00
Erik Johnston	bb6264be0b	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/refactor_stores	2019-10-22 10:41:18 +01:00
Erik Johnston	ffd24545bb	Fix schema management to work with multiple data stores.	2019-10-21 16:08:40 +01:00
Erik Johnston	c66a06ac6b	Move storage classes into a main "data store". This is in preparation for having multiple data stores that offer different functionality, e.g. splitting out state or event storage.	2019-10-21 16:05:06 +01:00
Neil Johnson	82c8799ec7	Set room version default to 5	2019-10-19 09:06:15 +01:00
Richard van der Hoff	93eaeec75a	Remove Auth.check method (#6217 ) This method was somewhat redundant, and confusing.	2019-10-18 19:43:36 +02:00
Hubert Chathi	36adfaedab	Merge branch 'develop' into cross-signing_sig_upload	2019-10-18 18:34:42 +01:00
Hubert Chathi	125eb45e19	fix doc strings	2019-10-18 16:56:16 +01:00
Hubert Chathi	0a9d22808c	Merge branch 'uhoreg/e2e_cross-signing_merged' into develop	2019-10-18 15:57:40 +01:00
Richard van der Hoff	2b22faded7	Merge remote-tracking branch 'origin/develop' into rav/event_auth/1	2019-10-18 12:35:13 +01:00
Richard van der Hoff	560c122267	Fix logging config for the docker image (#6197 ) Turns out that loggers that are instantiated before the config is loaded get turned off. Also bring the logging config that is generated by --generate-config into line. Fixes #6194.	2019-10-18 13:34:33 +02:00
Hubert Chathi	cfc28325a6	Merge branch 'develop' into uhoreg/e2e_cross-signing_merged	2019-10-18 11:39:40 +01:00
Brendan Abolivier	1ee97cbd01	Merge branch 'master' into develop	2019-10-18 11:00:43 +01:00
Hubert Chathi	f0f6a2b360	use the right function for when we're already in runInteraction	2019-10-18 10:56:54 +01:00
Erik Johnston	d98029ea89	Merge pull request #6196 from matrix-org/erikj/await Move rest/admin to use async/await.	2019-10-18 11:53:02 +02:00
Brendan Abolivier	41b9faed16	1.4.1	2019-10-18 10:15:12 +01:00
Richard van der Hoff	80003dfcd5	Merge remote-tracking branch 'origin/develop' into rav/event_auth/1	2019-10-18 10:11:40 +01:00
Erik Johnston	5859a5c569	Fix presence timeouts when synchrotron restarts. (#6212 ) * Fix presence timeouts when synchrotron restarts. Handling timeouts would fail if there was an external process that had timed out, e.g. a synchrotron restarting. This was due to a couple of variable name typoes. Fixes #3715.	2019-10-18 06:42:26 +01:00
Richard van der Hoff	1ba359a11f	rip out some unreachable code The only possible rejection reason is AUTH_ERROR, so all of this is unreachable.	2019-10-17 21:45:59 +01:00
Richard van der Hoff	70d9759cdf	Synapse 1.4.1rc1 (2019-10-17) ============================= Bugfixes -------- - Fix bug where redacted events were sometimes incorrectly censored in the database, breaking APIs that attempted to fetch such events. ([\#6185](https://github.com/matrix-org/synapse/issues/6185), [`5b0e9948`](`5b0e9948ea`)) -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEv27Axt/F4vrTL/8QOSor00I9eP8FAl2oj9sACgkQOSor00I9 eP+ZQQf9GQbjQhq92G1Mt1dI3HxXQnIvelGWaLC9rB++eGcafBkP0EJgCbQZTKda WntghJib0oWVHVtPbwYKtwF3z365WbME3awO6RpRoMvrFL5PDqJ8Ma5LUgJ6/GuO yDBfABbZk7PVS5WibftXXqibK8MkSrnId57VN3tc/SUHj3DGe4vk+A7plwjNckBj 2SLUA8DPw5I3Y4Z6peb6VweEA8M59+i3/0cZFAJ+4Ofy2Jad3z8kVXmJ1gTjBOdG 1bjBfnS2SrZLZwD79zJzaUR0zxfIvj62mL/fjrtR66oRmKF2T+9UnM7+9gH9JHWZ ct3Mk4Nnr4VaBBWOWOcD2btvByckug== =9lJk -----END PGP SIGNATURE----- Merge tag 'v1.4.1rc1' into develop Synapse 1.4.1rc1 (2019-10-17) ============================= Bugfixes -------- - Fix bug where redacted events were sometimes incorrectly censored in the database, breaking APIs that attempted to fetch such events. ([\#6185](https://github.com/matrix-org/synapse/issues/6185), [`5b0e9948`](`5b0e9948ea`))	2019-10-17 17:03:02 +01:00
Richard van der Hoff	71cd3fed66	1.4.1rc1	2019-10-17 16:40:56 +01:00
Erik Johnston	5b0e9948ea	Do the update as a background index	2019-10-17 16:31:42 +01:00
Erik Johnston	a2bb50c2eb	Merge pull request #6185 from matrix-org/erikj/fix_censored_evnets Fix inserting bytes as text in `censor_redactions`	2019-10-17 16:29:07 +01:00
Hubert Chathi	06fc66c81e	Merge pull request #6193 from matrix-org/uhoreg/interpret_device_key_in_storage make storage layer in charge of interpreting the device key data	2019-10-11 15:19:06 -04:00
Hubert Chathi	132b251e29	expand on comment	2019-10-11 14:24:52 -04:00
Erik Johnston	2e97a4c197	Port synapse/rest/client/_base.py to async/await	2019-10-11 15:29:26 +01:00
Erik Johnston	3c2d6c708c	Add maybe_awaitable and fix __init__ bugs	2019-10-11 15:26:09 +01:00
Hubert Chathi	691dd67fcd	Merge pull request #6189 from matrix-org/uhoreg/e2e_backup_optional_version make version optional in body of e2e backup version update	2019-10-11 10:11:59 -04:00
Erik Johnston	6f5c6c8f60	Merge pull request #6195 from matrix-org/erikj/opentracing_preview_url Trace non-JSON APIs, /media, /key etc	2019-10-11 13:23:52 +01:00
Valérian Rousset	be9b55e0d2	cas: support setting display name (#6114 ) Now, the CAS server can return an attribute stating what's the desired displayname, instead of using the username directly.	2019-10-11 12:33:12 +01:00
Erik Johnston	dfbb62c28d	Port synaps/rest/client/users.py to async/await	2019-10-11 12:21:40 +01:00
Erik Johnston	f95325e22a	Port synaps/rest/client/server_notice_servlet.py to async/await	2019-10-11 12:21:40 +01:00
Erik Johnston	281f887090	Port synaps/rest/client/media.py to async/await	2019-10-11 12:21:40 +01:00
Erik Johnston	fca3a541e7	Port rest/admin/__init__.py to async/await	2019-10-11 12:17:52 +01:00
Erik Johnston	f3ceaf4323	Trace non-JSON APIs, /media, /key etc	2019-10-11 11:58:52 +01:00
Neil Johnson	a0d0ba7862	Fix MAU reaping where reserved users are specified. (#6168 )	2019-10-11 09:38:26 +01:00
Hubert Chathi	7a0dce9259	make sure we actually return something	2019-10-10 20:31:30 -04:00
Hubert Chathi	4908fb3b30	make storage layer in charge of interpreting the device key data	2019-10-10 19:15:30 -04:00
Erik Johnston	83d86106a8	Merge pull request #6156 from matrix-org/erikj/postgres_any Use Postgres ANY for selecting many values.	2019-10-10 16:41:36 +01:00
Erik Johnston	b54b1e759a	Fix SQLite take 2	2019-10-10 16:19:40 +01:00
Erik Johnston	afb6d9d53b	Fix SQLite	2019-10-10 15:55:41 +01:00
Erik Johnston	3bc687508f	Remove add_in_list_sql_clause	2019-10-10 15:35:46 +01:00
Erik Johnston	ca3e01e50d	Fix store_url_cache using bytes	2019-10-10 14:52:29 +01:00
Erik Johnston	9d06fb9cb1	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/postgres_any	2019-10-10 14:38:21 +01:00
Erik Johnston	8bc529c04d	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/disable_sql_bytes	2019-10-10 14:30:51 +01:00
Erik Johnston	933034e2fe	Merge pull request #6127 from matrix-org/erikj/patch_inner Add more log context checks when patching inlineCallbacks	2019-10-10 13:47:50 +01:00
Erik Johnston	fe1c1e6c28	Fixup comments Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2019-10-10 13:17:19 +01:00
Erik Johnston	b161786c14	Replace IN usage with helper funcs	2019-10-10 13:15:49 +01:00
Erik Johnston	b4fbf71187	Add helper funcs to use postgres ANY This means that we can write queries with `col = ANY(?)`, which helps postgres.	2019-10-10 13:15:24 +01:00
Erik Johnston	91f43dca39	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/disable_sql_bytes	2019-10-10 13:10:57 +01:00
werner291	b5b03b7079	Add domain validation when creating room with list of invitees (#6121 )	2019-10-10 13:05:48 +01:00
Michael Telatynski	9a84d74417	before fulfilling a group invite,check if user is already joined/invited (#3436 ) Fixes vector-im/riot-web#5645	2019-10-10 13:03:44 +01:00
krombel	2efd050c9d	send 404 as http-status when filter-id is unknown to the server (#2380 ) This fixed the weirdness of 400 vs 404 as http status code in the case the filter id is not known by the server. As e.g. matrix-js-sdk expects 404 to catch this situation this leads to unwanted behaviour.	2019-10-10 12:59:55 +01:00
Erik Johnston	59e0ed8306	Fix py3.5	2019-10-10 12:47:07 +01:00
Erik Johnston	c349e3ebaf	Fix py3.5	2019-10-10 12:29:38 +01:00
Erik Johnston	f735aeec65	sort	2019-10-10 12:20:29 +01:00
Erik Johnston	941edad583	Appease mypy	2019-10-10 12:15:17 +01:00
Erik Johnston	791a8c559b	Add coments	2019-10-10 11:53:57 +01:00
Erik Johnston	9970f955ce	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/patch_inner	2019-10-10 11:51:50 +01:00
Richard van der Hoff	a139420a3c	Fix races in room stats (and other) updates. (#6187 ) Hopefully this will fix the occasional failures we were seeing in the room directory. The problem was that events are not necessarily persisted (and `current_state_delta_stream` updated) in the same order as their stream_id. So for instance current_state_delta 9 might be persisted before current_state_delta 8. Then, when the room stats saw stream_id 9, it assumed it had done everything up to 9, and never came back to do stream_id 8. We can solve this easily by only processing up to the stream_id where we know all events have been persisted.	2019-10-10 11:29:01 +01:00
Richard van der Hoff	562b4e51dd	Rewrite the user_filter migration again (#6184 ) you can't plausibly ALTER TABLE in sqlite, so we create the new table with the right schema to start with.	2019-10-10 11:28:23 +01:00
Erik Johnston	128d5948c4	Fix packaging	2019-10-10 11:16:26 +01:00
Erik Johnston	ec0596f2ab	Log correct context	2019-10-10 11:11:38 +01:00
Erik Johnston	3e4272961a	Test for sentinel commit	2019-10-10 10:58:32 +01:00
Erik Johnston	1d6dd1c294	Move patch_inline_callbacks into synapse/	2019-10-10 10:53:06 +01:00
Andrew Morgan	da815c1f69	Move tag/push rules room upgrade checking ealier (#6155 ) It turns out that _local_membership_update doesn't run when you join a new, remote room. It only runs if you're joining a room that your server already knows about. This would explain #4703 and #5295 and why the transfer would work in testing and some rooms, but not others. This would especially hit single-user homeservers. The check has been moved to right after the room has been joined, and works much more reliably. (Though it may still be a bit awkward of a place).	2019-10-10 10:06:45 +01:00
Amber Brown	f743108a94	Refactor HomeserverConfig so it can be typechecked (#6137 )	2019-10-10 09:39:35 +01:00
Hubert Chathi	4535a07f4a	make version optional in body of e2e backup version update to agree with latest version of the MSC	2019-10-09 17:54:03 -04:00
Erik Johnston	5c1f886c75	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/patch_inner	2019-10-09 16:52:21 +01:00
Erik Johnston	7f18b3d526	Do the update as a background index	2019-10-09 16:03:24 +01:00
Erik Johnston	def5413480	Merge pull request #6185 from matrix-org/erikj/fix_censored_evnets Fix inserting bytes as text in `censor_redactions`	2019-10-09 15:39:13 +01:00
Brendan Abolivier	59d6290ed9	Merge pull request #6178 from matrix-org/babolivier/factor_out_bg_updates Factor out backgroung updates	2019-10-09 12:29:01 +01:00
Erik Johnston	1d3858371e	Disable bytes usage with postgres More often than not passing bytes to `txn.execute` is a bug (where we meant to pass a string) that just happens to work if `BYTEA_OUTPUT` is set to `ESCAPE`. However, this is a bit of a footgun so we want to instead error when this happens, and force using `bytearray` if we actually want to use bytes.	2019-10-08 16:28:57 +01:00
Erik Johnston	e7631d84e6	Fix existing hex encoded json values in DB	2019-10-08 16:18:43 +01:00
Erik Johnston	ced4784592	Fix inserting bytes as text	2019-10-08 16:18:43 +01:00
Brendan Abolivier	c69324ffb5	Fix RegistrationStore	2019-10-08 14:48:33 +01:00
Brendan Abolivier	b1c0a4ceb3	Cleanup client_ips	2019-10-08 14:38:14 +01:00
Brendan Abolivier	8f1b385acc	Don't end up with 4 classes in registration	2019-10-08 14:36:33 +01:00
Anshul Angaria	474abf1eb6	add M_TOO_LARGE error code for uploading a too large file (#6151 ) Fixes #6109	2019-10-08 13:55:16 +01:00
Andrew Morgan	ea7d938bca	Remove unused public room list timeout param (#6179 ) * Remove unused public room list timeout param * Add changelog	2019-10-08 13:51:25 +01:00
Richard van der Hoff	b94a401852	Fix /federation/v1/state for recent room versions (#6170 ) * Fix /federation/v1/state for recent room versions Turns out this endpoint was completely broken for v3 rooms. Hopefully this re-signing code is irrelevant nowadays anyway.	2019-10-08 09:35:37 +01:00
Brendan Abolivier	66ebea1723	Lint	2019-10-07 17:44:41 +01:00
Brendan Abolivier	0496eafbf4	Move roommember's bg updates to a dedicated store	2019-10-07 17:35:01 +01:00
Brendan Abolivier	e106a0e4db	Move user_directory's bg updates to a dedicated store	2019-10-07 17:34:45 +01:00
Brendan Abolivier	cfccd2d78a	Move state's bg updates to a dedicated store	2019-10-07 17:34:39 +01:00
Brendan Abolivier	841054ad96	Move search's bg updates to a dedicated store	2019-10-07 17:34:35 +01:00
Brendan Abolivier	81e6ffb536	Move registration's bg updates to a dedicated store	2019-10-07 17:34:29 +01:00
Brendan Abolivier	54f87e0734	Move media_repository's bg updates to a dedicated store	2019-10-07 17:34:26 +01:00
Brendan Abolivier	cef9f6753e	Move devices's bg updates to a dedicated store	2019-10-07 17:34:20 +01:00
Brendan Abolivier	2d3b4f42f0	Move deviceinbox's bg updates to a dedicated store	2019-10-07 17:34:16 +01:00
Brendan Abolivier	88957199e7	Move client_ips's bg updates to a dedicated store	2019-10-07 17:34:12 +01:00
Erik Johnston	2cb7466993	Merge pull request #6161 from matrix-org/erikj/dont_regen_user_id_on_failure Don't regenerate numeric user ID if registration fails.	2019-10-07 16:56:23 +01:00
Michael Kaye	dc795ba709	Log responder we are using. (#6139 ) This prevents us logging "Responding to media request with responder %s".	2019-10-07 15:41:25 +01:00
Richard van der Hoff	276ae5c63e	add some logging to the rooms stats updates, to try to track down a flaky test (#6167 )	2019-10-07 14:41:39 +01:00
Brendan Abolivier	97e2722723	Merge pull request #6175 from matrix-org/babolivier/fix_unique_user_filter_index Fix unique_user_filter_index schema update	2019-10-07 13:48:43 +01:00
Brendan Abolivier	c8e6c308c6	Fix unique_user_filter_index schema update	2019-10-07 13:15:35 +01:00
Erik Johnston	86f4705866	Merge pull request #6159 from matrix-org/erikj/cache_memberships Cache room membership lookups in _get_joined_users_from_context	2019-10-07 13:15:00 +01:00
Erik Johnston	5119a4cac7	Fix bug where we didn't pull out event ID	2019-10-07 12:21:17 +01:00
Brendan Abolivier	ae0b78cb1f	Merge pull request #6147 from matrix-org/babolivier/3pid-invite-revoked Don't 500 when trying to exchange a revoked 3PID invite	2019-10-04 12:09:05 +01:00
Brendan Abolivier	21d51ab598	Typo	2019-10-04 11:21:24 +01:00
Brendan Abolivier	4676732ca0	Lint	2019-10-04 11:18:28 +01:00
Brendan Abolivier	81d51ce48b	Incorporate review	2019-10-04 11:16:19 +01:00
Alexander Maznev	13c4345c84	Update `user_filters` table to have a unique index, and non-null columns (#1172 )	2019-10-04 10:34:16 +01:00
Robert Swain	39b40d6d99	media/thumbnailer: Better quality for 1-bit / 8-bit color palette images (#2142 ) Pillow will use nearest neighbour as the resampling algorithm if the source image is either 1-bit or a color palette using 8 bits. If we convert to RGB before scaling, we'll probably get a better result.	2019-10-04 09:34:52 +01:00
Erik Johnston	6511071837	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/cache_memberships	2019-10-03 17:51:06 +01:00
Richard van der Hoff	66537e10ce	add some metrics on the federation sender (#6160 )	2019-10-03 17:47:20 +01:00
Erik Johnston	ab8a64772b	Remove unused variable	2019-10-03 17:42:32 +01:00
Erik Johnston	693156aaf4	Don't regenerate numeric user ID if registration fails. This causes huge amounts of DB IO if registrations start to fail e.g. because the DB is struggling with IO.	2019-10-03 17:33:54 +01:00
Erik Johnston	91f61fc6d7	Use the right error....	2019-10-03 17:28:31 +01:00
Erik Johnston	84691da6c3	pep8	2019-10-03 17:27:18 +01:00
Erik Johnston	a9610cdf02	Fixup names and comments	2019-10-03 17:26:56 +01:00
Erik Johnston	d89ebf7c25	cachedList descriptor doesn't like typing	2019-10-03 17:23:11 +01:00
Erik Johnston	c8145af8a9	Cache room membership lookups in _get_joined_users_from_context	2019-10-03 17:11:04 +01:00
Andrew Morgan	6018bec919	Merge branch 'master' into develop	2019-10-03 13:48:45 +01:00
Andrew Morgan	ecb69d824a	1.4.0	2019-10-03 13:22:44 +01:00
Andrew Morgan	0f46bf5737	Replace client_secret with <redacted> in server logs (#6158 ) Replace `client_secret` query parameter values with `<redacted>` in the logs. Prevents a scenario where a MITM of server traffic can horde 3pids on their account.	2019-10-03 12:57:26 +01:00
Brendan Abolivier	6527fa18c1	Add test case	2019-10-03 11:24:36 +01:00
Erik Johnston	dca7e32d3d	Merge pull request #6154 from matrix-org/erikj/fix_appservice_pagination Fix appservice room list pagination	2019-10-02 16:50:32 +01:00
Erik Johnston	22a6ffdf91	Merge pull request #6153 from matrix-org/erikj/fix_room_list_non_federatable Fix not showing non-federatable rooms to remote room list queries	2019-10-02 16:09:15 +01:00
Erik Johnston	5d8ffdfe61	Merge pull request #6148 from matrix-org/erikj/find_next_generated Bound find_next_generated_user_id DB query.	2019-10-02 16:09:02 +01:00
Erik Johnston	7a5f080f91	Fix appservice room list pagination	2019-10-02 15:47:22 +01:00
Erik Johnston	4c4f44930d	Fix not showing non-federatable rooms to remote room list queries	2019-10-02 15:20:36 +01:00
Erik Johnston	03cf4385e0	Fix public room list pagination. We incorrectly used `room_id` as to bound the result set, even though we order by `joined_members, room_id`, leading to incorrect results after pagination.	2019-10-02 15:11:17 +01:00
Erik Johnston	a5166e4d5f	Land improved room list based on room stats (#6019 ) Use room_stats and room_state for room directory search	2019-10-02 14:08:35 +01:00
Andrew Morgan	aec1377d0b	1.4.0rc2	2019-10-02 13:55:00 +01:00
Amber Brown	864f144543	Fix up some typechecking (#6150 ) * type checking fixes * changelog	2019-10-02 05:29:01 -07:00
Brendan Abolivier	972c9f65d7	Lint	2019-10-02 12:17:46 +01:00
Andrew Morgan	2a1470cd05	Fix yields and copy instead of move push rules on room upgrade (#6144 ) Copy push rules during a room upgrade from the old room to the new room, instead of deleting them from the old room. For instance, we've defined upgrading of a room multiple times to be possible, and push rules won't be transferred on the second upgrade if they're deleted during the first. Also fix some missing yields that probably broke things quite a bit.	2019-10-02 12:04:22 +01:00
Erik Johnston	d69fd53f74	Bound find_next_generated_user_id DB query. We can easily bound the set of user IDs we pull out of the DB, so lets do that.	2019-10-02 11:45:31 +01:00
Brendan Abolivier	5705ecaec6	Don't 500 code when trying to exchange a revoked 3PID invite While this is not documented in the spec (but should be), Riot (and other clients) revoke 3PID invites by sending a m.room.third_party_invite event with an empty ({}) content to the room's state. When the invited 3PID gets associated with a MXID, the identity server (which doesn't know about revocations) sends down to the MXID's homeserver all of the undelivered invites it has for this 3PID. The homeserver then tries to talk to the inviting homeserver in order to exchange these invite for m.room.member events. When one of the invite is revoked, the inviting homeserver responds with a 500 error because it tries to extract a 'display_name' property from the content, which is empty. This might cause the invited server to consider that the server is down and not try to exchange other, valid invites (or at least delay it). This fix handles the case of revoked invites by avoiding trying to fetch a 'display_name' from the original invite's content, and letting the m.room.member event fail the auth rules (because, since the original invite's content is empty, it doesn't have public keys), which results in sending a 403 with the correct error message to the invited server.	2019-10-02 11:19:43 +01:00
Erik Johnston	ecd254bc49	Merge branch 'release-v1.4.0' of github.com:matrix-org/synapse into develop	2019-10-02 11:08:07 +01:00
Erik Johnston	b4fe7e19c0	Merge pull request #6146 from matrix-org/erikj/fix_destination_retry_timings Fix errors storing large retry intervals.	2019-10-02 11:05:22 +01:00
Erik Johnston	35f392bb29	Merge pull request #6145 from matrix-org/erikj/fix_censored_redactions Fix fetching censored redactions from DB	2019-10-02 10:57:30 +01:00
Erik Johnston	f44f1d2e83	Fix errors storing large retry intervals. We have set the max retry interval to a value larger than a postgres or sqlite int can hold, which caused exceptions when updating the destinations table. To fix postgres we need to change the column to a bigint, and for sqlite we lower the max interval to 2**62 (which is still incredibly long).	2019-10-02 10:36:27 +01:00
Erik Johnston	ce7a3e7e27	Fix fetching censored redactions from DB Fetching a censored redactions caused an exception due to the code expecting redactions to have a `redact` key, which redacted redactions don't have.	2019-10-02 10:14:01 +01:00
Erik Johnston	5e8387af9e	Use `received_ts` to find uncensored redacted events Joining against `events` and ordering by `stream_ordering` is inefficient as it forced scanning the entirety of the redactions table. This isn't the case if we use `redactions.received_ts` column as we can then use an index.	2019-10-01 13:43:48 +01:00
Erik Johnston	898dde981b	Add received_ts column to redactions. This will allow us to efficiently search for uncensored redactions in the DB before a given time.	2019-10-01 13:43:48 +01:00
Erik Johnston	a27fb7d5ca	Don't repeatedly attempt to censor events we don't have. Currently we don't set `have_censored` column if we don't have the target event of a redaction, which means we repeatedly attempt to censor the same non-existant event. When we persist non-redacted events we unset the `have_censored` column for any redactions that target said event.	2019-10-01 11:05:48 +01:00
Erik Johnston	1d349fb159	Merge branch 'erikj/fixup_devices_last_seen_query' of github.com:matrix-org/synapse into develop	2019-10-01 10:17:24 +01:00
Erik Johnston	9267741a5f	Fix `devices_last_seen` background update. Fixes #6134.	2019-09-30 11:58:36 +01:00
Richard van der Hoff	16cb9a71b8	Drop unused tables (#6115 ) These tables are unused since #5893 (as amended by #6047), so we can now drop them. Fixes #6048.	2019-09-30 09:38:41 +01:00
Andrew Morgan	f3451118a6	Edit SimpleHttpClient to reference that header keys can be passed as str or bytes (#6077 )	2019-09-27 17:59:18 +01:00
Brendan Abolivier	3e42d47a5a	Incorporate review	2019-09-27 16:15:01 +01:00
Brendan Abolivier	af92110c46	Update synapse/handlers/deactivate_account.py Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2019-09-27 16:12:15 +01:00
Brendan Abolivier	bbe2a0f339	Update synapse/handlers/deactivate_account.py Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2019-09-27 16:10:36 +01:00
Brendan Abolivier	873fe7883c	Lint	2019-09-27 15:21:03 +01:00
Brendan Abolivier	72a2708ac6	Fixup and add some logging	2019-09-27 15:13:39 +01:00
Erik Johnston	132279a46f	Patch inlinecallbacks for log contexts	2019-09-27 15:11:14 +01:00
Brendan Abolivier	5257a2fb1c	Reject pending invites on deactivation	2019-09-27 14:49:53 +01:00
Andrew Morgan	8c27bc8b60	Move lookup-related functions from RoomMemberHandler to IdentityHandler (#5978 ) Just to have all the methods that make calls to identity services in one place.	2019-09-27 10:36:20 +01:00
Erik Johnston	67ee18daea	Merge pull request #6108 from matrix-org/erikj/remove_get_user_by_req-span Add some helpful opentracing tags and remove get_user_by_req span	2019-09-27 10:02:57 +01:00
Erik Johnston	3423633d50	Fix 'redaction_retention_period' sampel config to match guidelines	2019-09-26 16:43:52 +01:00
Richard van der Hoff	54569c787b	Kill off half-implemented password-reset via sms (#6101 ) Doing a password reset via SMS has never worked, and in any case is a silly idea because msisdn recycling is a thing. See also matrix-org/matrix-doc#2303.	2019-09-26 15:38:25 +01:00
Neil Johnson	8b8f8c7b3c	Explicitly log when a homeserver does not have a trusted key server configured (#6090 )	2019-09-26 12:57:01 +01:00
Richard van der Hoff	2927c6bc4c	bump version	2019-09-26 12:29:59 +01:00
Neil Johnson	034db2ba21	Fix dummy event insertion consent bug (#6053 ) Fixes #5905	2019-09-26 11:47:53 +01:00
Richard van der Hoff	a96318127d	Update comments and docstring	2019-09-25 18:17:39 +01:00
Erik Johnston	4fb3c129aa	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/cleanup_user_ips_2	2019-09-25 17:53:13 +01:00
Erik Johnston	9614d3c9d1	Merge pull request #6089 from matrix-org/erikj/cleanup_user_ips Move last seen info into devices table	2019-09-25 17:42:39 +01:00
Neil Johnson	a4f3ca48b5	Enable cleaning up extremities with dummy events by default to prevent undue build up of forward extremities. (#5884 )	2019-09-25 17:27:35 +01:00
Erik Johnston	39b50ad42a	Review comments	2019-09-25 17:22:33 +01:00
Erik Johnston	d2bd0bc6b1	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/cleanup_user_ips	2019-09-25 17:16:28 +01:00
Erik Johnston	50572db837	Use if `is not None` Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2019-09-25 17:00:23 +01:00
Neil Johnson	77dc7093a7	Threepid validity checks on msisdns should not be dependent on 'threepid_behaviour_email'. (#6104 ) Fixes #6103	2019-09-25 12:29:35 +01:00
Richard van der Hoff	990928abde	Stop advertising unsupported flows for registration (#6107 ) If email or msisdn verification aren't supported, let's stop advertising them for registration. Fixes #6100.	2019-09-25 12:10:26 +01:00
Erik Johnston	dc2c97e1a3	isort	2019-09-25 11:59:05 +01:00
Erik Johnston	dc01cad690	Add device and appservice tags	2019-09-25 11:59:00 +01:00
Erik Johnston	5d99713854	Add tags for event_id and txn_id in event sending This will make it easier to search for sending event requests.	2019-09-25 11:39:15 +01:00
Richard van der Hoff	2cd98812ba	Refactor the user-interactive auth handling (#6105 ) Pull the checkers out to their own classes, rather than having them lost in a massive 1000-line class which does everything. This is also preparation for some more intelligent advertising of flows, as per #6100	2019-09-25 11:33:03 +01:00
Erik Johnston	fde4ce2213	Don't create new span for get_user_by_req We don't actually care about what happens in `get_user_by_req` and having it as a separate span means that the entity tag isn't added to the servlet spans, making it harder to search.	2019-09-25 11:32:41 +01:00
Richard van der Hoff	8004d6ca2f	Refactor code for calculating registration flows (#6106 ) because, frankly, it looked like it was written by an axe-murderer. This should be a non-functional change, except that where `m.login.dummy` was previously advertised before `m.login.terms`, it will now be advertised afterwards. AFAICT that should have no effect, and will be more consistent with the flows that involve passing a 3pid.	2019-09-25 11:32:05 +01:00
Hubert Chathi	c3635c9459	make isort happy	2019-09-24 16:21:03 -04:00
Hubert Chathi	f4b6d43ec3	add some comments	2019-09-24 16:19:54 -04:00
Hubert Chathi	39864f45ec	drop some logger lines to debug	2019-09-24 15:26:45 -04:00
Hubert Chathi	26113fb7de	make changes based on PR feedback	2019-09-24 14:12:20 -04:00
Brendan Abolivier	f99a9c9cb0	Merge pull request #6092 from matrix-org/babolivier/background_update_deactivated_return Fix the return value in the users_set_deactivated_flag background job	2019-09-24 17:11:12 +01:00
Richard van der Hoff	9b7c4f4078	Merge remote-tracking branch 'origin/develop' into rav/saml_mapping_work	2019-09-24 17:03:50 +01:00
Richard van der Hoff	566ac40939	remove unused parameter to get_user_id_by_threepid (#6099 ) Added in #5377, apparently in error	2019-09-24 17:01:09 +01:00
Erik Johnston	242017db8b	Prune rows in user_ips older than configured period Defaults to pruning everything older than 28d.	2019-09-24 15:53:17 +01:00
Erik Johnston	2135c198d1	Add has_completed_background_update This allows checking if a specific background update has completed.	2019-09-24 15:53:17 +01:00
Erik Johnston	367158a609	Add wrap_as_background_process decorator. This does the same thing as `run_as_background_process` but means we don't need to create superfluous functions.	2019-09-24 15:53:17 +01:00
Richard van der Hoff	bb82be9851	Merge pull request #6069 from matrix-org/rav/fix_attribute_mapping Fix a bug with saml attribute maps.	2019-09-24 15:07:26 +01:00
Brendan Abolivier	12fe2a29bc	Incorporate review	2019-09-24 14:43:38 +01:00
J. Ryan Stinnett	40fb00f5b7	Add sid to next_link for email validation (#6097 )	2019-09-24 14:39:50 +01:00
Brendan Abolivier	f02f14e09a	Fix logging	2019-09-24 14:39:07 +01:00
Richard van der Hoff	ed8b92f0d2	Merge remote-tracking branch 'origin/develop' into rav/saml_mapping_work	2019-09-24 12:57:32 +01:00
Richard van der Hoff	a25b66d3f9	docstrings and comments	2019-09-24 11:15:08 +01:00
Andrew Morgan	50776261e1	Add submit_url response parameter to msisdn /requestToken (#6079 ) Second part of solving #6076 Fixes #6076 We return a submit_url parameter on calls to POST */msisdn/requestToken so that clients know where to submit token information to.	2019-09-23 21:21:03 +01:00
Andrew Morgan	2b071a2ff1	Add an unstable feature flag for separate add/bind 3pid APIs (#6044 ) Add a m.separate_add_and_bind flag set to True. See MSC2290's Backward Compatibility section for details.	2019-09-23 20:46:34 +01:00
Richard van der Hoff	78e8ec368e	Merge pull request #6064 from matrix-org/rav/saml_config_cleanup Make the sample saml config closer to our standards	2019-09-23 20:36:51 +01:00
Andrew Morgan	e08ea43463	Use the federation blacklist for requests to untrusted Identity Servers (#6000 ) Uses a SimpleHttpClient instance equipped with the federation_ip_range_blacklist list for requests to identity servers provided by user input. Does not use a blacklist when contacting identity servers specified by account_threepid_delegates. The homeserver trusts the latter and we don't want to prevent homeserver admins from specifying delegates that are on internal IP addresses. Fixes #5935	2019-09-23 20:23:20 +01:00
Andrew Morgan	1ea3ed7620	Add m.id_access_token to /versions unstable_features (MSC2264) (#5974 ) Adds a flag to /versions' unstable_features section indicating that this Synapse understands what an id_access_token is, as per MSC2264. Fixes #5927	2019-09-23 20:19:25 +01:00
Andrew Morgan	b38aa82b83	Add m.require_identity_server to /versions unstable_flags (#5972 ) As MSC2263 states, m.require_identity_server must be set to false when it does not require an identity server to be provided by the client for the purposes of email registration or password reset. Adds an m.require_identity_server flag to /versionss unstable_flags section. This will advertise that Synapse no longer needs id_server as a parameter.	2019-09-23 18:52:43 +01:00
Andrew Morgan	2c99c63453	Add POST submit_token endpoint for MSISDN (#6078 ) First part of solving #6076	2019-09-23 17:49:00 +01:00
Brendan Abolivier	323d685bf7	Typo	2019-09-23 17:23:49 +01:00
Brendan Abolivier	2858d10671	Fix the return value in the users_set_deactivated_flag background job	2019-09-23 17:22:01 +01:00
Erik Johnston	51d28272e2	Query devices table for last seen info. This is a) simpler than querying user_ips directly and b) means we can purge older entries from user_ips without losing the required info. The storage functions now no longer return the access_token, since it was unused.	2019-09-23 16:59:45 +01:00
Erik Johnston	ed80231ade	Add BG update to populate devices last seen info	2019-09-23 16:59:45 +01:00
Erik Johnston	2ade05dca3	Add last seen info to devices table. This allows us to purge old user_ips entries without having to preserve the latest last seen info for active devices.	2019-09-23 16:59:35 +01:00
Andrew Morgan	30af161af2	Implement MSC2290 (#6043 ) Implements MSC2290. This PR adds two new endpoints, /unstable/account/3pid/add and /unstable/account/3pid/bind. Depending on the progress of that MSC the unstable prefix may go away. This PR also removes the blacklist on some 3PID tests which occurs in #6042, as the corresponding Sytest PR changes them to use the new endpoints. Finally, it also modifies the account deactivation code such that it doesn't just try to deactivate 3PIDs that were bound to the user's account, but any 3PIDs that were bound through the homeserver on that user's account.	2019-09-23 16:50:27 +01:00
Andrew Morgan	1b519e0272	Disable /register/available if registration is disabled (#6082 ) Fixes #6066 This register endpoint should be disabled if registration is disabled, otherwise we're giving anyone the ability to check if a username exists on a server when we don't need to be. Error code is 403 (Forbidden) as that's the same returned by /register when registration is disabled.	2019-09-23 15:38:38 +01:00
Andrew Morgan	1c9feadf4b	Generalize email sending logging (#6075 ) In ancient times Synapse would only send emails when it was notifying a user about a message they received... Now it can do all sorts of neat things! Change the logging so it's not just about notifications.	2019-09-23 14:38:19 +01:00
Andrew Morgan	885a4726b7	Return timeout error to user for identity server calls (#6073 )	2019-09-23 14:37:23 +01:00
Richard van der Hoff	0660f8e367	Merge pull request #6072 from matrix-org/rav/fix_retry_reset Fix exception when resetting retry timings	2019-09-23 14:31:47 +01:00
Matthew Hodgson	7ef319aefe	fix broken copyrights	2019-09-23 12:28:01 +01:00
Andrew Morgan	df3401a71d	Allow HS to send emails when adding an email to the HS (#6042 )	2019-09-20 15:21:30 +01:00
Andrew Morgan	7763dd3e95	Remove trailing slash ability from password reset's submit_token endpoint (#6074 ) Remove trailing slash ability from the password reset submit_token endpoint. Since we provide the link in an email, and have never sent it with a trailing slash, there's no point for us to accept them on the endpoint.	2019-09-20 14:58:37 +01:00
Richard van der Hoff	9d94313209	Fix exception when resetting retry timings Fixes: > TypeError: set_destination_retry_timings() missing 1 required positional argument: 'retry_interval' Introduced in #6016.	2019-09-20 12:09:39 +01:00
Richard van der Hoff	366dc7d2d4	Merge commit '33757bad1' into rav/saml_mapping_work	2019-09-20 11:21:40 +01:00
Richard van der Hoff	33757bad19	More better logging	2019-09-20 11:20:02 +01:00
Andrew Morgan	aeb40f355c	Ensure email validation link parameters are URL-encoded (#6063 ) The validation links sent via email had their query parameters inserted without any URL-encoding. Surprisingly this didn't seem to cause any issues, but if a user were to put a `/` in their client_secret it could lead to problems.	2019-09-20 10:46:59 +01:00
Andrew Morgan	3ac614eb6c	Drop support for bind param on POST /account/3pid (MSC2290) (#6067 ) As per [MSC2290](https://github.com/matrix-org/matrix-doc/pull/2290/files#diff-05cde9463e9209b701312b3baf2fb2ebR151), we're dropping the bind parameter from `/account/3pid`. This endpoint can now only be used for adding threepid's to the user's account on the homeserver.	2019-09-20 10:46:34 +01:00
J. Ryan Stinnett	36015d68ef	Use unstable prefix for 3PID unbind API (#6062 )	2019-09-19 22:28:29 +01:00
Richard van der Hoff	284e1cb027	Merge branch 'develop' into rav/fix_attribute_mapping	2019-09-19 20:32:25 +01:00
Richard van der Hoff	b74606ea22	Fix a bug with saml attribute maps. Fixes a bug where the default attribute maps were prioritised over user-specified ones, resulting in incorrect mappings. The problem is that if you call SPConfig.load() multiple times, it adds new attribute mappers to a list. So by calling it with the default config first, and then the user-specified config, we would always get the default mappers before the user-specified mappers. To solve this, let's merge the config dicts first, and then pass them to SPConfig.	2019-09-19 20:32:14 +01:00
Richard van der Hoff	b65327ff66	Merge branch 'develop' into rav/saml_mapping_work	2019-09-19 18:13:31 +01:00
Richard van der Hoff	7423fade92	better logging	2019-09-19 17:16:50 +01:00
Richard van der Hoff	bcd9132869	Undo the deletion of some tables (#6047 ) This is a partial revert of #5893. The problem is that if we drop these tables in the same release as removing the code that writes to them, it prevents users users from being able to roll back to a previous release. So let's leave the tables in place for now, and remember to drop them in a subsequent release. (Note that these tables haven't been read for years, so any missing rows resulting from a temporary upgrade to vNext won't cause a problem.)	2019-09-19 15:06:27 +01:00
Richard van der Hoff	b789c7eb03	Merge branch 'develop' into rav/saml_config_cleanup	2019-09-19 15:05:31 +01:00
Andrew Morgan	62e3ff92fd	Remove POST method from password reset submit_token endpoint (#6056 ) Removes the POST method from `/password_reset/<medium>/submit_token/` as it's only used by phone number verification which Synapse does not support yet.	2019-09-19 10:53:14 +01:00
Jorik Schellekens	38fd1f8e3f	Fix typo in account_threepid_delegates config (#6028 )	2019-09-18 22:30:44 +01:00
J. Ryan Stinnett	a86a290850	Fix logcontext spam on non-Linux platforms (#6059 ) This checks whether the current platform supports thread resource usage tracking before logging a warning to avoid log spam. Fixes https://github.com/matrix-org/synapse/issues/6055	2019-09-18 21:55:37 +01:00
Andrew Morgan	6670bd4072	v2 3PID Invites (part of MSC2140) (#5979 ) 3PID invites require making a request to an identity server to check that the invited 3PID has an Matrix ID linked, and if so, what it is. These requests are being made on behalf of a user. The user will supply an identity server and an access token for that identity server. The homeserver will then forward this request with the access token (using an `Authorization` header) and, if the given identity server doesn't support v2 endpoints, will fall back to v1 (which doesn't require any access tokens). Requires: ~~#5976~~	2019-09-17 18:05:13 +01:00
dstipp	379d2a8c39	(#5849 ) Convert rst to markdown (#6040 ) Converting some of the rst documentation to markdown. Attempted to preserve whitespace and line breaks to minimize cosmetic change.	2019-09-17 12:55:29 +01:00
Erik Johnston	70c52821ce	Fix race condition in room stats. (#6029 ) Broke in #5971 Basically the bug is that if get_current_state_deltas returns no new updates and we then take the max pos, its possible that we miss an update that happens in between the two calls. (e.g. get_current_state_deltas looks up to stream pos 5, then an event persists and so getting the max stream pos returns 6, meaning that next time we check for things with a stream pos bigger than 6)	2019-09-17 12:41:23 +01:00
Richard van der Hoff	1e19ce00bf	Add 'failure_ts' column to 'destinations' table (#6016 ) Track the time that a server started failing at, for general analysis purposes.	2019-09-17 11:41:54 +01:00
Amber Brown	850dcfd2d3	Fix well-known lookups with the federation certificate whitelist (#5997 )	2019-09-14 04:58:38 +10:00
Richard van der Hoff	a8ac40445c	Record mappings from saml users in an external table We want to assign unique mxids to saml users based on an incrementing suffix. For that to work, we need to record the allocated mxid in a separate table.	2019-09-13 16:01:46 +01:00
Richard van der Hoff	785cbd3999	Make the sample saml config closer to our standards It' still not great, thanks to the nested dictionaries, but it's better.	2019-09-13 12:07:03 +01:00
Amber Brown	b617864cd9	Fix for structured logging tests stomping on logs (#6023 )	2019-09-13 02:29:55 +10:00
Richard van der Hoff	3d882a7ba5	Remove the cap on federation retry interval. (#6026 ) Essentially the intention here is to end up blacklisting servers which never respond to federation requests. Fixes https://github.com/matrix-org/synapse/issues/5113.	2019-09-12 13:00:13 +01:00
Richard van der Hoff	0388beafe4	Fix bug in calculating the federation retry backoff period (#6025 ) This was intended to introduce an element of jitter; instead it gave you a 30/60 chance of resetting to zero.	2019-09-12 12:59:43 +01:00
David Baker	642fad8bd4	Fix SSO fallback login Well, it worked, but forgot to remove the thing saying login was unavailable.	2019-09-12 11:42:47 +01:00
Sorunome	dd2e5b0038	add report_stats_endpoint config option (#6012 ) This PR adds the optional `report_stats_endpoint` to configure where stats are reported to, if enabled.	2019-09-12 11:24:57 +01:00
Jorik Schellekens	a8251da10f	Blow up config if opentracing is missing (#5985 ) * Blow up config if opentracing is missing	2019-09-12 10:57:37 +01:00
Jason Robinson	6d847d8ce6	Ensure support users can be registered even if MAU limit is reached This allows support users to be created even on MAU limits via the admin API. Support users are excluded from MAU after creation, so it makes sense to exclude them in creation - except if the whole host is in disabled state. Signed-off-by: Jason Robinson <jasonr@matrix.org>	2019-09-11 20:48:31 +03:00
Andrew Morgan	9fc71dc5ee	Use the v2 Identity Service API for lookups (MSC2134 + MSC2140) (#5976 ) This is a redo of https://github.com/matrix-org/synapse/pull/5897 but with `id_access_token` accepted. Implements [MSC2134](https://github.com/matrix-org/matrix-doc/pull/2134) plus Identity Service v2 authentication ala [MSC2140](https://github.com/matrix-org/matrix-doc/pull/2140). Identity lookup-related functions were also moved from `RoomMemberHandler` to `IdentityHandler`.	2019-09-11 16:02:42 +01:00
Erik Johnston	cbcbfe64a2	Merge pull request #6015 from matrix-org/erikj/ratelimit_admin_redaction Allow use of different ratelimits for admin redactions.	2019-09-11 15:39:38 +01:00
Richard van der Hoff	7902bf1e1d	Clean up some code in the retry logic (#6017 ) * remove some unused code * make things which were constants into constants for efficiency and clarity	2019-09-11 15:14:56 +01:00
Andrew Morgan	9c555f37e3	Add note about extra arg to send_membership_event, remove arg in remote_reject_invite (#6009 ) Some small fixes to `room_member.py` found while doing other PRs. 1. Add requester to the base `_remote_reject_invite` method. 2. `send_membership_event`'s docstring was out of date and took in a `remote_room_hosts` arg that was not used and no calling function provided.	2019-09-11 14:23:24 +01:00
Jorik Schellekens	6604b64fae	Check dependencies on setup in the nicer way. (#5989 )	2019-09-11 14:00:37 +01:00
Erik Johnston	57dd41a45b	Fix comments Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2019-09-11 13:54:50 +01:00
Andrew Morgan	3505ffcda7	Fix existing v2 identity server calls (MSC2140) (#6013 ) Two things I missed while implementing [MSC2140](https://github.com/matrix-org/matrix-doc/pull/2140/files#diff-c03a26de5ac40fb532de19cb7fc2aaf7R80). 1. Access tokens should be provided to the identity server as `access_token`, not `id_access_token`, even though the homeserver may accept the tokens as `id_access_token`. 2. Access tokens must be sent to the identity server in a query parameter, the JSON body is not allowed. We now send the access token as part of an `Authorization: ...` header, which fixes both things. The breaking code was added in https://github.com/matrix-org/synapse/pull/5892 Sytest PR: https://github.com/matrix-org/sytest/pull/697	2019-09-11 11:59:45 +01:00
Erik Johnston	c64c3bb4c5	Fix how we check for self redaction	2019-09-11 11:18:04 +01:00
Erik Johnston	54ce81c86d	Allow use of different ratelimits for admin redactions. This is useful to allow room admins to quickly deal with a large number of abusive messages.	2019-09-11 10:46:38 +01:00
Andrew Morgan	cd17a2085e	Remove origin parameter from add_display_name_to_third_party_invite and add params to docstring (#6010 ) Another small fixup noticed during work on a larger PR. The `origin` field of `add_display_name_to_third_party_invite` is not used and likely was just carried over from the `on_PUT` method of `FederationThirdPartyInviteExchangeServlet` which, like all other servlets, provides an `origin` argument. Since it's not used anywhere in the handler function though, we should remove it from the function arguments.	2019-09-11 10:37:17 +01:00
Erik Johnston	5e9b05d7da	Merge pull request #6011 from matrix-org/anoa/fix_3pid_validation Use account_threepid_delegate for 3pid validation	2019-09-10 18:15:07 +01:00
Andrew Morgan	b5833a2abf	Add changelog	2019-09-10 17:56:10 +01:00
Andrew Morgan	60d3c57bd0	Use account_threepid_delegate for 3pid validation	2019-09-10 17:56:10 +01:00
Jason Robinson	63f9317b8e	Merge pull request #6004 from matrix-org/jaywink/autojoin-create-real-users Only count real users when checking for auto-creation of auto-join room	2019-09-09 17:37:52 +03:00
Erik Johnston	470dc621ae	Merge pull request #5934 from matrix-org/erikj/censor_redactions Censor redactions in DB after a month	2019-09-09 15:29:39 +01:00
Amber Brown	aeb9b2179e	Add a build info metric to Prometheus (#6005 )	2019-09-10 00:14:58 +10:00
Jason Robinson	aaed6b39e1	Fix code style, again Signed-off-by: Jason Robinson <jasonr@matrix.org>	2019-09-09 17:10:02 +03:00
Erik Johnston	580f3df9b2	Fix comments	2019-09-09 15:08:24 +01:00
Jason Robinson	e89fea4f04	Simplify count_real_users SQL to only count user_type is null rows Signed-off-by: Jason Robinson <jasonr@matrix.org>	2019-09-09 16:43:32 +03:00
Jason Robinson	8c03cd0e5f	Simplify is_real_user_txn check to trust user_type is null if real user Signed-off-by: Jason Robinson <jasonr@matrix.org>	2019-09-09 16:40:40 +03:00
Erik Johnston	8b9ade8c78	Default to censoring redactions after seven days	2019-09-09 13:55:28 +01:00
Erik Johnston	e7184a4370	Use better names in SQL	2019-09-09 13:33:38 +01:00
Erik Johnston	916c697228	Fixup comment	2019-09-09 13:31:00 +01:00
Erik Johnston	fffe17b77d	Don't start looping call unless enabled	2019-09-09 13:24:24 +01:00
Erik Johnston	80e14a8546	Handle setting retention period to 0	2019-09-09 13:23:41 +01:00
Jason Robinson	62fac9d969	Auto-fix a few code style issues Signed-off-by: Jason Robinson <jasonr@matrix.org>	2019-09-09 14:59:35 +03:00
Jason Robinson	be618e0551	Only count real users when checking for auto-creation of auto-join room Previously if the first registered user was a "support" or "bot" user, when the first real user registers, the auto-join rooms were not created. Fix to exclude non-real (ie users with a special user type) users when counting how many users there are to determine whether we should auto-create a room. Signed-off-by: Jason Robinson <jasonr@matrix.org>	2019-09-09 14:48:08 +03:00
Erik Johnston	05bae6b4fc	Add opentracing span for HTTP push	2019-09-09 10:24:14 +01:00
Hubert Chathi	d3f2fbcfe5	add function docs	2019-09-07 14:13:18 -04:00
Hubert Chathi	8e86f5b65c	Merge branch 'develop' into uhoreg/e2e_cross-signing_merged	2019-09-07 13:20:34 -04:00
Hubert Chathi	0d61d1d735	Merge branch 'develop' into cross-signing_sig_upload	2019-09-07 13:14:45 -04:00
Hubert Chathi	415d0a00e0	run black	2019-09-06 16:46:45 -04:00
Hubert Chathi	561cbba057	split out signature processing into separate functions	2019-09-06 16:44:24 -04:00
Amber Brown	55d5b3af88	Servers-known-about statistic (#5981 )	2019-09-07 01:45:51 +10:00
Andrew Morgan	78801e7f9e	Ensure a sid parameter is passed to bind_threepid (#5995 ) `sid` is required to be part of `three_pid_creds`. We were 500'ing if it wasn't provided instead of returning `M_MISSING_PARAM`.	2019-09-06 15:36:50 +01:00
Erik Johnston	a2a695b7ec	Merge pull request #5998 from matrix-org/erikj/fixup_federate_flag Correctly handle non-bool m.federate flag	2019-09-06 15:32:43 +01:00
Erik Johnston	142c9325c2	Correctly handle non-bool m.federate flag	2019-09-06 14:21:06 +01:00
Erik Johnston	30b67e0f63	Merge pull request #5993 from matrix-org/anoa/worker_store_reg Move get_threepid_validation_session and delete_threepid_session into RegistrationWorkerStore	2019-09-06 14:10:02 +01:00
Andrew Morgan	cf5a420c8a	Apply suggestions from code review Co-Authored-By: Erik Johnston <erik@matrix.org>	2019-09-06 13:34:42 +01:00
Andrew Morgan	ca74b140f2	Fix destructuring assumption bug	2019-09-06 13:25:06 +01:00
Andrew Morgan	6ddda8152e	Move delete_threepid_session into RegistrationWorkerStore	2019-09-06 13:23:10 +01:00
Andrew Morgan	e059c5e648	Move get_threepid_validation_session into RegistrationWorkerStore	2019-09-06 13:10:11 +01:00
Erik Johnston	146af7b47f	Merge pull request #5991 from matrix-org/erikj/fix_tracing_funcs Don't assume there is a 'self' arg in @trace decorator	2019-09-06 11:42:45 +01:00
Andrew Morgan	0c0b82b6d1	Allow Synapse to send registration emails + choose Synapse or an external server to handle 3pid validation (#5987 ) This is a combination of a few different PRs, finally all being merged into `develop`: * #5875 * #5876 * #5868 (This one added the `/versions` flag but the flag itself was actually [backed out](`891afb57cb (diff-e591d42d30690ffb79f63bb726200891)`) in #5969. What's left is just giving /versions access to the config file, which could be useful in the future) * #5835 * #5969 * #5940 Clients should not actually use the new registration functionality until https://github.com/matrix-org/synapse/pull/5972 is merged. UPGRADE.rst, changelog entries and config file changes should all be reviewed closely before this PR is merged.	2019-09-06 11:35:28 +01:00
Erik Johnston	d8517da85b	Don't assume there is a 'self' arg in @trace decorator	2019-09-06 10:07:12 +01:00
Hubert Chathi	369462da74	avoid modifying input parameter	2019-09-05 17:03:31 -04:00
Jorik Schellekens	f7c873a643	Trace how long it takes for the send trasaction to complete, including retrys (#5986 )	2019-09-05 17:44:55 +01:00
Jorik Schellekens	bc604e7f94	Gracefully handle log context slips and missing opentracing import errors. (#5988 )	2019-09-05 17:33:29 +01:00
Erik Johnston	591d82f06b	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/censor_redactions	2019-09-05 17:27:46 +01:00
Erik Johnston	3ff0422d2d	Make redaction retention period configurable	2019-09-05 17:16:45 +01:00
Erik Johnston	1a6ae33309	Merge pull request #5984 from matrix-org/joriks/opentracing_link_send_to_edu_contexts Link the send loop with the edus contexts	2019-09-05 15:22:24 +01:00
Jorik Schellekens	ef20aa52eb	use access methods (duh..) Co-Authored-By: Erik Johnston <erik@matrix.org>	2019-09-05 15:07:17 +01:00
Jorik Schellekens	5ade977d08	Opentracing context cannot be none	2019-09-05 15:06:13 +01:00
Jorik Schellekens	909827b422	Add opentracing to all client servlets (#5983 )	2019-09-05 14:46:04 +01:00
Jorik Schellekens	1d65292e94	Link the send loop with the edus contexts The contexts were being filtered too early so the send loop wasn't being linked to them unless the destination was whitelisted.	2019-09-05 14:42:37 +01:00
Andrew Morgan	a0d294c306	Switch to using v2 Identity Service APIs other than lookup (MSC 2140) (#5892 )	2019-09-05 14:31:22 +01:00
Jorik Schellekens	b9cfd3c375	Fix opentracing contexts missing from outbound replication requests (#5982 )	2019-09-05 14:22:15 +01:00
Andrew Morgan	90d17a3d28	Add POST /_matrix/client/r0/account/3pid/unbind (MSC2140) (#5980 ) Implements `POST /_matrix/client/r0/account/3pid/unbind` from [MSC2140](https://github.com/matrix-org/matrix-doc/blob/dbkr/tos_2/proposals/2140-terms-of-service-2.md#post-_matrixclientr0account3pidunbind).	2019-09-05 14:00:30 +01:00

... 12 13 14 15 16 ...

11894 Commits