synapse-product

mirror of https://git.anonymousland.org/anonymousland/synapse-product.git synced 2024-12-22 07:54:58 -05:00

Author	SHA1	Message	Date
Richard van der Hoff	7966a1cde9	Rewrite prune_old_outbound_device_pokes for efficiency (#7159 ) make sure we clear out all but one update for the user	2020-03-30 19:06:52 +01:00
Andrew Morgan	7042840b32	Transfer alias mappings when joining an upgraded room (#6946 )	2020-03-30 17:53:25 +01:00
Andrew Morgan	d9f29f8dae	Fix a small typo in the `metrics_flags` config option. (#7171 )	2020-03-30 17:38:21 +01:00
Erik Johnston	4f21c33be3	Remove usage of "conn_id" for presence. (#7128 ) * Remove `conn_id` usage for UserSyncCommand. Each tcp replication connection is assigned a "conn_id", which is used to give an ID to a remotely connected worker. In a redis world, there will no longer be a one to one mapping between connection and instance, so instead we need to replace such usages with an ID generated by the remote instances and included in the replicaiton commands. This really only effects UserSyncCommand. * Add CLEAR_USER_SYNCS command that is sent on shutdown. This should help with the case where a synchrotron gets restarted gracefully, rather than rely on 5 minute timeout.	2020-03-30 16:37:24 +01:00
David Baker	07569f25d1	Merge pull request #7160 from matrix-org/dbkr/always_send_own_device_list_updates Always send the user updates to their own device list	2020-03-30 14:34:28 +01:00
Andrew Morgan	104844c1e1	Add explanatory comment	2020-03-30 14:00:11 +01:00
David Baker	7406477525	black	2020-03-30 10:18:33 +01:00
David Baker	9fc588e6dc	Just add own user ID to the list we track device changes for	2020-03-30 10:11:26 +01:00
Richard van der Hoff	b7da598a61	Always whitelist the login fallback for SSO (#7153 ) That fallback sets the redirect URL to itself (so it can process the login token then return gracefully to the client). This would make it pointless to ask the user for confirmation, since the URL the confirmation page would be showing wouldn't be the client's.	2020-03-27 20:24:52 +00:00
Brendan Abolivier	84f7eaed16	Improve the UX of the login fallback when using SSO (#7152 ) * Don't show the login forms if we're currently logging in with a password or a token. * Submit directly the SSO login form, showing only a spinner to the user, in order to eliminate from the clunkiness of SSO through this fallback.	2020-03-27 20:19:54 +00:00
Dirk Klimpel	fb69690761	Admin API to join users to a room. (#7051 )	2020-03-27 19:16:43 +00:00
Dirk Klimpel	8327eb9280	Add options to prevent users from changing their profile. (#7096 )	2020-03-27 19:15:23 +00:00
Brendan Abolivier	90246344e3	Improve the UX of the login fallback when using SSO (#7152 ) * Don't show the login forms if we're currently logging in with a password or a token. * Submit directly the SSO login form, showing only a spinner to the user, in order to eliminate from the clunkiness of SSO through this fallback.	2020-03-27 15:44:13 +01:00
Brendan Abolivier	63aea691a7	Update the wording of the config comment	2020-03-27 15:09:12 +01:00
Andrew Morgan	12aa5a7fa7	Ensure is_verified on /_matrix/client/r0/room_keys/keys is a boolean (#7150 )	2020-03-27 13:30:22 +00:00
David Vo	fbf0782c63	Only import sqlite3 when type checking (#7155 ) Fixes: #7127 Signed-off-by: David Vo <david@vovo.id.au>	2020-03-27 13:20:00 +00:00
David Baker	16ee97988a	Fix undefined variable & remove debug logging	2020-03-27 12:39:54 +00:00
David Baker	a07e03ce90	black	2020-03-27 12:35:32 +00:00
David Baker	09cc058a4c	Always send the user updates to their own device list This will allow clients to notify users about new devices even if the user isn't in any rooms (yet).	2020-03-27 12:26:47 +00:00
Jason Robinson	7496d3d2f6	Merge pull request #7151 from matrix-org/jaywink/saml-redirect-fix Allow RedirectResponse in SAML response handler	2020-03-26 22:10:31 +02:00
Patrick Cloke	fa4f12102d	Refactor the CAS code (move the logic out of the REST layer to a handler) (#7136 )	2020-03-26 15:05:26 -04:00
Brendan Abolivier	c2ab0b3066	Whitelist the login fallback by default for SSO	2020-03-26 18:58:58 +01:00
Nektarios Katakis	825fb5d0a5	Don't default to an invalid sqlite config if no database configuration is provided (#6573 )	2020-03-26 17:13:14 +00:00
Jason Robinson	060e7dce09	Allow RedirectResponse in SAML response handler Allow custom SAML handlers to redirect after processing an auth response. Fixes #7149 Signed-off-by: Jason Robinson <jasonr@matrix.org>	2020-03-26 19:02:35 +02:00
Dirk Klimpel	e8e2ddb60a	Allow server admins to define and enforce a password policy (MSC2000). (#7118 )	2020-03-26 16:51:13 +00:00
Patrick Cloke	1c1242acba	Validate that the session is not modified during UI-Auth (#7068 )	2020-03-26 07:39:34 -04:00
Aaron Raimist	6ca5e56fd1	Remove unused captcha_bypass_secret option (#7137 ) Signed-off-by: Aaron Raimist <aaron@raim.ist>	2020-03-25 17:49:34 +00:00
Erik Johnston	4cff617df1	Move catchup of replication streams to worker. (#7024 ) This changes the replication protocol so that the server does not send down `RDATA` for rows that happened before the client connected. Instead, the server will send a `POSITION` and clients then query the database (or master out of band) to get up to date.	2020-03-25 14:54:01 +00:00
Erik Johnston	b1cfaf08af	Merge pull request #7133 from matrix-org/erikj/fix_worker_startup Fix starting workers when federation sending not split out.	2020-03-25 09:42:39 +00:00
Richard van der Hoff	39230d2171	Clean up some LoggingContext stuff (#7120 ) * Pull Sentinel out of LoggingContext ... and drop a few unnecessary references to it * Factor out LoggingContext.current_context move `current_context` and `set_context` out to top-level functions. Mostly this means that I can more easily trace what's actually referring to LoggingContext, but I think it's generally neater. * move copy-to-parent into `stop` this really just makes `start` and `stop` more symetric. It also means that it behaves correctly if you manually `set_log_context` rather than using the context manager. * Replace `LoggingContext.alive` with `finished` Turn `alive` into `finished` and make it a bit better defined.	2020-03-24 14:45:33 +00:00
Naugrimm	1fcf9c6f95	Fix CAS redirect url (#6634 ) Build the same service URL when requesting the CAS ticket and when calling the proxyValidate URL.	2020-03-24 11:59:04 +00:00
Erik Johnston	c816072d47	Fix starting workers when federation sending not split out.	2020-03-24 10:35:00 +00:00
Patrick Cloke	190ab593b7	Use the proper error code when a canonical alias that does not exist is used. (#7109 )	2020-03-23 15:21:54 -04:00
Richard van der Hoff	a564b92d37	Convert `*StreamRow` classes to inner classes (#7116 ) This just helps keep the rows closer to their streams, so that it's easier to see what the format of each stream is.	2020-03-23 13:59:11 +00:00
Richard van der Hoff	5126cb1253	Merge branch 'master' into develop	2020-03-23 13:54:29 +00:00
Richard van der Hoff	2fa55c0cc6	1.12.0	2020-03-23 12:13:09 +00:00
Richard van der Hoff	b3cee0ce67	Fix processing of `groups` stream, and use symbolic names for streams (#7117 ) `groups` != `receipts` Introduced in #6964	2020-03-23 11:39:36 +00:00
Dionysis Grigoropoulos	96071eea8f	Set Referrer-Policy to no-referrer for media (#7009 )	2020-03-23 09:48:28 +00:00
Patrick Cloke	477c4f5b1c	Clean-up some auth/login REST code (#7115 )	2020-03-20 16:22:47 -04:00
Richard van der Hoff	c165c1233b	Improve database configuration docs (#6988 ) Attempts to clarify the sample config for databases, and add some stuff about tcp keepalives to `postgres.md`.	2020-03-20 15:24:22 +00:00
Erik Johnston	fdb1344716	Remove concept of a non-limited stream. (#7011 )	2020-03-20 14:40:47 +00:00
Patrick Cloke	caec7d4fa0	Convert some of the media REST code to async/await (#7110 )	2020-03-20 07:20:02 -04:00
Patrick Cloke	c2db6599c8	Fix a bug in the federation API which could cause occasional "Failed to get PDU" errors (#7089 ).	2020-03-19 08:22:56 -04:00
Erik Johnston	a319cb1dd1	Change device list streams to have one row per ID (#7010 ) * Add 'device_lists_outbound_pokes' as extra table. This makes sure we check all the relevant tables to get the current max stream ID. Currently not doing so isn't problematic as the max stream ID in `device_lists_outbound_pokes` is the same as in `device_lists_stream`, however that will change. * Change device lists stream to have one row per id. This will make it possible to process the streams more incrementally, avoiding having to process large chunks at once. * Change device list replication to match new semantics. Instead of sending down batches of user ID/host tuples, send down a row per entity (user ID or host). * Newsfile * Remove handling of multiple rows per ID * Fix worker handling * Comments from review	2020-03-19 11:36:53 +00:00
Richard van der Hoff	e43e78b985	1.12.0rc1	2020-03-19 11:07:16 +00:00
Richard van der Hoff	e913823a22	Fix concurrent modification errors in pusher metrics (#7106 ) add a lock to try to make this metric actually work	2020-03-19 10:28:49 +00:00
Richard van der Hoff	8c75667ad7	Add prometheus metrics for the number of active pushers (#7103 )	2020-03-19 10:00:24 +00:00
Richard van der Hoff	443162e577	Move pusherpool startup into _base.setup (#7104 ) This should be safe to do on all workers/masters because it is guarded by a config option which will ensure it is only actually done on the worker assigned as a pusher.	2020-03-19 09:48:45 +00:00
Erik Johnston	4a17a647a9	Improve get auth chain difference algorithm. (#7095 ) It was originally implemented by pulling the full auth chain of all state sets out of the database and doing set comparison. However, that can take a lot work if the state and auth chains are large. Instead, lets try and fetch the auth chains at the same time and calculate the difference on the fly, allowing us to bail early if all the auth chains converge. Assuming that the auth chains do converge more often than not, this should improve performance. Hopefully.	2020-03-18 16:46:41 +00:00
Patrick Cloke	88b41986db	Add an option to the set password API to choose whether to logout other devices. (#7085 )	2020-03-18 07:50:00 -04:00
Erik Johnston	6e6476ef07	Comments from review	2020-03-18 10:13:55 +00:00
Richard van der Hoff	c37db0211e	Share SSL contexts for non-federation requests (#7094 ) Extends #5794 etc to the SimpleHttpClient so that it also applies to non-federation requests. Fixes #7092.	2020-03-17 21:32:25 +00:00
The Stranjer	5e477c1deb	Set charset to utf-8 when adding headers for certain text content types (#7044 ) Fixes #7043	2020-03-17 13:29:09 +00:00
Patrick Cloke	7581d30e9f	Remove unused federation endpoint (`query_auth`) (#7026 )	2020-03-17 08:04:49 -04:00
Patrick Cloke	60724c46b7	Remove special casing of `m.room.aliases` events (#7034 )	2020-03-17 07:37:04 -04:00
Richard van der Hoff	6a35046363	Revert "Add options to disable setting profile info for prevent changes. (#7053 )" This reverts commit `54dd28621b`, reversing changes made to `6640460d05`.	2020-03-17 11:25:01 +00:00
Brendan Abolivier	7df04ca0e6	Populate the room version from state events (#7070 ) Fixes #7065 This is basically the same as https://github.com/matrix-org/synapse/pull/6847 except it tries to populate events from `state_events` rather than `current_state_events`, since the latter might have been cleared from the state of some rooms too early, leaving them with a `NULL` room version.	2020-03-16 22:31:47 +00:00
Brendan Abolivier	beb19cf61a	Fix buggy condition in account validity handler (#7074 )	2020-03-16 12:16:30 +00:00
Brendan Abolivier	d8d91983bc	Merge pull request #7067 from matrix-org/babolivier/saml_error_moar Move the default SAML2 error HTML to a dedicated file	2020-03-13 19:53:19 +00:00
Brendan Abolivier	ebfcbbff9c	Use innerText instead of innerHTML	2020-03-13 19:09:22 +00:00
Patrick Cloke	77d0a4507b	Add type annotations and comments to auth handler (#7063 )	2020-03-12 11:36:27 -04:00
Brendan Abolivier	0de9f9486a	Lint	2020-03-11 20:39:18 +00:00
Brendan Abolivier	f9e98176bf	Put the file in the templates directory	2020-03-11 20:31:42 +00:00
Brendan Abolivier	900bca9707	Update wording and config	2020-03-11 19:40:30 +00:00
Brendan Abolivier	b8cfe79ffc	Move the default SAML2 error HTML to a dedicated file Also add some JS to it to process any error we might have in the URI (see #6893).	2020-03-11 19:33:16 +00:00
Brendan Abolivier	8120a238a4	Refactor a bit	2020-03-11 18:49:41 +00:00
Brendan Abolivier	37a9873f63	Also don't fail on aliases events in this case	2020-03-11 18:43:41 +00:00
Brendan Abolivier	e38c44b418	Lint	2020-03-11 18:06:07 +00:00
Brendan Abolivier	2dce68c651	Also don't filter out events sent by ignored users when checking state visibility	2020-03-11 17:53:22 +00:00
Brendan Abolivier	9c0775e86a	Fix condition	2020-03-11 17:53:18 +00:00
Brendan Abolivier	69ce55c510	Don't filter out dummy events when we're checking the visibility of state	2020-03-11 17:52:54 +00:00
Brendan Abolivier	54dd28621b	Add options to disable setting profile info for prevent changes. (#7053 )	2020-03-10 22:23:01 +00:00
Dirk Klimpel	42ac4ca477	Update synapse/config/registration.py Co-Authored-By: Brendan Abolivier <github@brendanabolivier.com>	2020-03-10 21:26:55 +01:00
Brendan Abolivier	8f826f98ac	Rephrase default message	2020-03-10 17:22:45 +00:00
Brendan Abolivier	dc6fb56c5f	Hopefully mypy is happy now	2020-03-10 14:40:28 +00:00
Brendan Abolivier	fe593ef990	Attempt at appeasing the gods of mypy	2020-03-10 14:19:06 +00:00
Brendan Abolivier	5ec2077bf9	Lint	2020-03-10 14:04:20 +00:00
Brendan Abolivier	6b0efe73e2	SAML2: render a comprehensible error page if something goes wrong If an error happened while processing a SAML AuthN response, or a client ends up doing a `GET` request to `/authn_response`, then render a customisable error page rather than a confusing error.	2020-03-10 13:59:22 +00:00
dklimpel	39f6595b4a	lint, fix tests	2020-03-09 22:13:20 +01:00
dklimpel	885134529f	updates after review	2020-03-09 22:09:29 +01:00
Brendan Abolivier	14b2ebe767	Merge pull request #7055 from matrix-org/babolivier/get_time_of_last_push_action_before Move get_time_of_last_push_action_before to the EventPushActionsWorkerStore	2020-03-09 14:53:50 +00:00
Brendan Abolivier	aee2bae952	Fix undefined `room_id` in `make_summary_text` This would break notifications about un-named rooms when processing notifications in a batch.	2020-03-09 14:10:19 +00:00
Brendan Abolivier	87c65576e0	Move `get_time_of_last_push_action_before` to the `EventPushActionsWorkerStore` Fixes #7054 I also had a look at the rest of the functions in `EventPushActionsStore` and in the push notifications send code and it looks to me like there shouldn't be any other method with this issue in this part of the codebase.	2020-03-09 13:58:38 +00:00
Patrick Cloke	06eb5cae08	Remove special auth and redaction rules for aliases events in experimental room ver. (#7037 )	2020-03-09 08:58:25 -04:00
Brendan Abolivier	bbf725e7da	Merge pull request #7045 from matrix-org/babolivier/room_keys_check Make sure that is_verified is a boolean when processing room keys	2020-03-09 09:54:48 +00:00
dklimpel	99bbe177b6	add disable_3pid_changes	2020-03-08 21:58:12 +01:00
dklimpel	20545a2199	lint2	2020-03-08 15:28:00 +01:00
dklimpel	ce460dc31c	lint	2020-03-08 15:22:43 +01:00
dklimpel	fb078f921b	changelog	2020-03-08 15:19:07 +01:00
dklimpel	1f5f3ae8b1	Add options to disable setting profile info for prevent changes.	2020-03-08 14:49:33 +01:00
Neil Pilgrim	2bff4457d9	Add type hints to logging/context.py (#6309 ) * Add type hints to logging/context.py Signed-off-by: neiljp (Neil Pilgrim) <github@kepier.clara.net>	2020-03-07 17:57:26 +00:00
Neil Johnson	1d66dce83e	Break down monthly active users by appservice_id (#7030 ) * Break down monthly active users by appservice_id and emit via prometheus. Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2020-03-06 18:14:19 +00:00
Brendan Abolivier	54b78a0e3b	Lint	2020-03-06 15:11:13 +00:00
Brendan Abolivier	297aaf4816	Mention the session ID in the error message	2020-03-06 15:07:41 +00:00
Brendan Abolivier	45df9d35a9	Lint	2020-03-06 11:10:52 +00:00
Brendan Abolivier	80e580ae92	Make sure that is_verified is a boolean when processing room keys	2020-03-06 11:05:00 +00:00
Patrick Cloke	87972f07e5	Convert remote key resource REST layer to async/await. (#7020 )	2020-03-05 11:29:56 -05:00
Richard van der Hoff	78a15b1f9d	Store room_versions in EventBase objects (#6875 ) This is a bit fiddly because it all has to be done on one fell swoop: * Wherever we create a new event, pass in the room version (and check it matches the format version) * When we prune an event, use the room version of the unpruned event to create the pruned version. * When we pass an event over the replication protocol, pass the room version over alongside it, and use it when deserialising the event again.	2020-03-05 15:46:44 +00:00
Brendan Abolivier	31a2116331	Hide extremities dummy events from clients	2020-03-04 17:28:13 +00:00
Patrick Cloke	13892776ef	Allow deleting an alias if the user has sufficient power level (#6986 )	2020-03-04 11:30:46 -05:00
Richard van der Hoff	8ef8fb2c1c	Read the room version from database when fetching events (#6874 ) This is a precursor to giving EventBase objects the knowledge of which room version they belong to.	2020-03-04 13:11:04 +00:00
Brendan Abolivier	43f874055d	Merge branch 'master' into develop	2020-03-03 15:20:49 +00:00
Brendan Abolivier	fd983fad96	v1.11.1	2020-03-03 14:58:37 +00:00
Patrick Cloke	7dcbc33a1b	Validate the alt_aliases property of canonical alias events (#6971 )	2020-03-03 07:12:45 -05:00
Brendan Abolivier	a0178df104	Fix wrong handler being used in SAML handler	2020-03-03 11:29:07 +00:00
Brendan Abolivier	65c73cdfec	Factor out complete_sso_login and expose it to the Module API	2020-03-03 10:54:44 +00:00
Richard van der Hoff	b68041df3d	Add a whitelist for the SSO confirmation step.	2020-03-02 17:05:09 +00:00
Erik Johnston	65a941d1f8	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/fixup_devices_stream	2020-03-02 16:55:55 +00:00
Erik Johnston	b29474e0aa	Always return a deferred from `get_current_state_deltas`. (#7019 ) This currently causes presence notify code to log exceptions when there is no state changes to process. This doesn't actually cause any problems as we'd simply do nothing anyway.	2020-03-02 16:52:15 +00:00
Richard van der Hoff	27d099edd6	Merge remote-tracking branch 'origin/release-v1.11.1' into release-v1.11.1	2020-03-02 16:43:33 +00:00
Brendan Abolivier	b2bd54a2e3	Add a confirmation step to the SSO login flow	2020-03-02 16:36:32 +00:00
Dirk Klimpel	bbeee33d63	Fixed set a user as an admin with the new API (#6928 ) Fix #6910	2020-03-02 13:28:50 +00:00
Erik Johnston	e53744c737	Fix worker handling	2020-03-02 12:52:28 +00:00
Patrick Cloke	12d4259000	Add some type annotations to the federation base & client classes (#6995 )	2020-02-28 07:31:07 -05:00
Erik Johnston	f70f44abc7	Remove handling of multiple rows per ID	2020-02-28 11:45:35 +00:00
Erik Johnston	9ce4e344a8	Change device list replication to match new semantics. Instead of sending down batches of user ID/host tuples, send down a row per entity (user ID or host).	2020-02-28 11:25:34 +00:00
Erik Johnston	f5caa1864e	Change device lists stream to have one row per id. This will make it possible to process the streams more incrementally, avoiding having to process large chunks at once.	2020-02-28 11:21:25 +00:00
Erik Johnston	c3c6c0e622	Add 'device_lists_outbound_pokes' as extra table. This makes sure we check all the relevant tables to get the current max stream ID. Currently not doing so isn't problematic as the max stream ID in `device_lists_outbound_pokes` is the same as in `device_lists_stream`, however that will change.	2020-02-28 11:15:11 +00:00
Dirk Klimpel	9b06d8f8a6	Fixed set a user as an admin with the new API (#6928 ) Fix #6910	2020-02-28 09:58:05 +00:00
Patrick Cloke	ab0073a6c0	Merge remote-tracking branch 'origin/release-v1.11.1' into develop	2020-02-27 13:47:44 -05:00
Erik Johnston	2201bc9795	Don't refuse to start worker if media listener configured. (#7002 ) Instead lets just warn if the worker has a media listener configured but has the media repository disabled. Previously non media repository workers would just ignore the media listener.	2020-02-27 16:33:21 +00:00
Richard van der Hoff	132b673dbe	Add some type annotations in `synapse.storage` (#6987 ) I cracked, and added some type definitions in synapse.storage.	2020-02-27 11:53:40 +00:00
Richard van der Hoff	3e99528f2b	Store room version on invite (#6983 ) When we get an invite over federation, store the room version in the rooms table. The general idea here is that, when we pull the invite out again, we'll want to know what room_version it belongs to (so that we can later redact it if need be). So we need to store it somewhere...	2020-02-26 16:58:33 +00:00
Patrick Cloke	380122866f	Cast a coroutine into a Deferred in the federation base (#6996 ) Properly convert a coroutine into a Deferred in federation_base to fix an error when joining a room.	2020-02-26 11:32:13 -05:00
Erik Johnston	1f773eec91	Port PresenceHandler to async/await (#6991 )	2020-02-26 15:33:26 +00:00
Uday Bansal	7728d87fd7	Updated warning for incorrect database collation/ctype (#6985 ) Signed-off-by: Uday Bansal <43824981+udaybansal19@users.noreply.github.com>	2020-02-26 15:17:03 +00:00
Andrew Morgan	8c75b621bf	Ensure 'deactivated' parameter is a boolean on user admin API, Fix error handling of call to deactivate user (#6990 )	2020-02-26 12:22:55 +00:00
Richard van der Hoff	e66f099ca9	Sanity-check database before running upgrades (#6982 ) Some of the database deltas rely on `config.server_name` being set correctly, so we should check that it is before running the deltas. Fixes #6870.	2020-02-25 17:46:00 +00:00
Erik Johnston	bbf8886a05	Merge worker apps into one. (#6964 )	2020-02-25 16:56:55 +00:00
Richard van der Hoff	691659568f	Remove redundant store_room call (#6979 ) `_process_received_pdu` is only called by `on_receive_pdu`, which ignores any events for unknown rooms, so this is redundant.	2020-02-24 17:20:44 +00:00
Richard van der Hoff	a301934f46	Upsert room version when we join over federation (#6968 ) This is intended as a precursor to storing room versions when we receive an invite over federation, but has the happy side-effect of fixing #3374 at last. In short: change the store_room with try/except to a proper upsert which updates the right columns.	2020-02-24 15:46:41 +00:00
Richard van der Hoff	4c2ed3f20e	Fix minor issues with email config (#6962 ) * Give `notif_template_html`, `notif_template_text` default values (fixes #6960) * Don't complain if `smtp_host` and `smtp_port` are unset, since they have sensible defaults (fixes #6961) * Set the example for `enable_notifs` to `True`, for consistency and because it's more useful * Raise errors as ConfigError rather than RuntimeError for nicer formatting	2020-02-24 15:18:38 +00:00
Patrick Cloke	af6c389501	No longer use room alias events to calculate room names for push notifications. (#6966 )	2020-02-21 12:50:48 -05:00
Dirk Klimpel	7b0e2d961c	Change displayname of user as admin in rooms (#6876 )	2020-02-21 17:44:03 +00:00
Patrick Cloke	fcf4599488	Stop returning aliases as part of the room list. (#6970 )	2020-02-21 12:40:23 -05:00
Patrick Cloke	7936d2a96e	Publishing/removing from the directory requires a power level greater than canonical aliases.	2020-02-21 07:18:33 -05:00
Patrick Cloke	509e381afa	Clarify list/set/dict/tuple comprehensions and enforce via flake8 (#6957 ) Ensure good comprehension hygiene using flake8-comprehensions.	2020-02-21 07:15:07 -05:00
Richard van der Hoff	272eee1ae1	Merge pull request #6967 from matrix-org/rav/increase_max_events_behind Increase MAX_EVENTS_BEHIND for replication clients	2020-02-21 10:17:28 +00:00
Richard van der Hoff	4f7e4fc2fb	Merge branch 'master' into develop	2020-02-21 09:37:03 +00:00
Erik Johnston	0bd8cf435e	Increase MAX_EVENTS_BEHIND for replication clients	2020-02-21 09:04:33 +00:00
Richard van der Hoff	9c1b83b007	1.11.0	2020-02-21 08:56:04 +00:00
Andrew Morgan	8f6d9c4cf0	Small grammar fixes to the ACME v1 deprecation notice (#6944 ) Some small fixes to the copy in #6907.	2020-02-21 08:53:01 +00:00
Patrick Cloke	99eed85a77	Do not send alias events when creating / upgrading a room (#6941 ) Stop emitting room alias update events during room creation/upgrade.	2020-02-20 16:24:04 -05:00
Hubert Chathi	a90d0dc5c2	don't insert into the device table for remote cross-signing keys (#6956 )	2020-02-20 09:59:00 -05:00
Ruben Barkow-Kuder	4fb5f4d0ce	Add some clarifications to README.md in the database schema directory. (#6615 ) Signed-off-by: Ruben Barkow-Kuder <github@r.z11.de>	2020-02-20 10:37:57 +00:00
Erik Johnston	7b7c3cedf2	Minor perf fixes to `get_auth_chain_ids`.	2020-02-19 15:47:11 +00:00
Erik Johnston	fc87d2ffb3	Freeze allocated objects on startup. (#6953 ) This may make gc go a bit faster as the gc will know things like caches/data stores etc. are frozen without having to check.	2020-02-19 15:09:00 +00:00
Erik Johnston	2b37eabca1	Reduce auth chains fetched during v2 state res. (#6952 ) The state res v2 algorithm only cares about the difference between auth chains, so we can pass in the known common state to the `get_auth_chain` storage function so that it can ignore those events.	2020-02-19 15:04:47 +00:00
Richard van der Hoff	197b08de35	1.11.0rc1	2020-02-19 13:48:32 +00:00
Erik Johnston	099c96b89b	Revert `get_auth_chain_ids` changes (#6951 )	2020-02-19 11:37:35 +00:00
Richard van der Hoff	2fb7794e60	Merge pull request #6949 from matrix-org/rav/list_room_aliases_peekable Make room alias lists peekable	2020-02-19 11:19:11 +00:00
Richard van der Hoff	880aaac1d8	Move MSC2432 stuff onto unstable prefix (#6948 ) it's not in the spec yet, so needs to be unstable. Also add a feature flag for it. Also add a test for admin users.	2020-02-19 10:40:27 +00:00
Richard van der Hoff	abf1e5c526	Tiny optimisation for _get_handler_for_request (#6950 ) we have hundreds of path_regexes (see #5118), so let's not convert the same bytes to str for each of them.	2020-02-19 10:38:20 +00:00
Erik Johnston	0d0bc35792	Increase DB/CPU perf of `_is_server_still_joined` check. (#6936 ) * Increase DB/CPU perf of `_is_server_still_joined` check. For rooms with large amount of state a single user leaving could cause us to go and load a lot of membership events and then pull out membership state in a large number of batches. * Newsfile * Update synapse/storage/persist_events.py Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Fix adding if too soon * Update docstring * Review comments * Woops typo Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2020-02-19 10:15:49 +00:00
Brendan Abolivier	5e4a438556	Merge pull request #6945 from matrix-org/babolivier/fix-retention-debug-log Fix log in message retention purge jobs	2020-02-19 10:12:55 +00:00
Erik Johnston	5a5abd55e8	Limit size of get_auth_chain_ids query (#6947 )	2020-02-19 09:39:26 +00:00
Richard van der Hoff	709e81f518	Make room alias lists peekable As per https://github.com/matrix-org/matrix-doc/pull/2432#pullrequestreview-360566830, make room alias lists accessible to users outside world_readable rooms.	2020-02-19 08:53:32 +00:00
Richard van der Hoff	a0a1fd0bec	Add `allow_departed_users` param to `check_in_room_or_world_readable` ... and set it everywhere it's called. while we're here, rename it for consistency with `check_user_in_room` (and to help check that I haven't missed any instances)	2020-02-19 08:52:51 +00:00
Richard van der Hoff	b58d17e44f	Refactor the membership check methods in Auth these were getting a bit unwieldy, so let's combine `check_joined_room` and `check_user_was_in_room` into a single `check_user_in_room`.	2020-02-18 23:21:44 +00:00
Brendan Abolivier	f31a94a6dd	Fix log in message retention purge jobs	2020-02-18 17:29:57 +00:00
Richard van der Hoff	adfaea8c69	Implement GET /_matrix/client/r0/rooms/{roomId}/aliases (#6939 ) per matrix-org/matrix-doc#2432	2020-02-18 16:23:25 +00:00
Richard van der Hoff	3f1cd14791	Merge pull request #6872 from matrix-org/rav/dictproperty Rewrite _EventInternalMetadata to back it with a dict	2020-02-18 16:21:02 +00:00
Brendan Abolivier	d484126bf7	Merge pull request #6907 from matrix-org/babolivier/acme-config Add mention and warning about ACME v1 deprecation to the TLS config	2020-02-18 16:11:31 +00:00
Erik Johnston	8a380d0fe2	Increase perf of `get_auth_chain_ids` used in state res v2. (#6937 ) We do this by moving the recursive query to be fully in the DB.	2020-02-18 15:39:09 +00:00
Brendan Abolivier	9801a042f3	Make the log more noticeable	2020-02-18 15:15:43 +00:00
Brendan Abolivier	bfbe2f5b08	Print the error as an error log and raise the same exception we got	2020-02-18 15:10:41 +00:00
Patrick Cloke	fe3941f6e3	Stop sending events when creating or deleting aliases (#6904 ) Stop sending events when creating or deleting associations (room aliases). Send an updated canonical alias event if one of the alt_aliases is deleted.	2020-02-18 07:29:44 -05:00
Richard van der Hoff	0a714c3abf	Merge branch 'master' into develop	2020-02-17 16:33:21 +00:00
Richard van der Hoff	fd6d83ed96	1.10.1	2020-02-17 16:27:33 +00:00
Richard van der Hoff	d2455ec3aa	wait for current_state_events_membership before delete_old_current_state_events (#6924 )	2020-02-17 16:19:32 +00:00
Andrew Morgan	3404ad289b	Raise the default power levels for invites, tombstones and server acls (#6834 )	2020-02-17 13:23:37 +00:00
Richard van der Hoff	46fa66bbfd	wait for current_state_events_membership before delete_old_current_state_events (#6924 )	2020-02-17 11:30:50 +00:00
Patrick Cloke	10027c80b0	Add type hints to the spam check module (#6915 ) Add typing information to the spam checker modules.	2020-02-14 12:49:40 -05:00
Richard van der Hoff	9551911f88	Rewrite _EventInternalMetadata to back it with a _dict Mostly, this gives mypy an easier time.	2020-02-14 16:42:40 +00:00
Richard van der Hoff	43b2be9764	Replace _event_dict_property with DictProperty this amounts to the same thing, but replaces `_event_dict` with `_dict`, and removes some of the function layers generated by `property`.	2020-02-14 16:42:37 +00:00
Richard van der Hoff	97a42bbc3a	Add a warning about indentation to generated config (#6920 ) Fixes #6916.	2020-02-14 16:22:30 +00:00
Patrick Cloke	49f877d32e	Filter the results of user directory searching via the spam checker (#6888 ) Add a method to the spam checker to filter the user directory results.	2020-02-14 07:17:54 -05:00
Brendan Abolivier	36af094017	Linters are hard but in they end they just want what's best for us	2020-02-13 17:03:41 +00:00
Brendan Abolivier	65bdc35a1f	Lint	2020-02-13 16:14:15 +00:00
Brendan Abolivier	0cb83cde70	Lint	2020-02-13 16:06:31 +00:00
Brendan Abolivier	ef9c275d96	Add a separator for the config warning	2020-02-13 15:44:14 +00:00
Brendan Abolivier	12bbcc255a	Add a comprehensive error when failing to register for an ACME account	2020-02-13 14:58:34 +00:00
Brendan Abolivier	5820ed905f	Add mention and warning about ACME v1 deprecation to the Synapse config	2020-02-13 14:20:08 +00:00
Aaron Raimist	dc3f998706	Remove m.lazy_load_members from unstable features since it is in CS r0.5.0 (#6877 ) Fixes #5528	2020-02-13 12:02:32 +00:00
Andrew Morgan	d8994942f2	Return a 404 for admin api user lookup if user not found (#6901 )	2020-02-12 18:14:10 +00:00
Brendan Abolivier	47acbc519f	Merge branch 'master' into develop	2020-02-12 13:24:09 +00:00
Brendan Abolivier	fdb816713a	1.10.0	2020-02-12 12:19:19 +00:00
Richard van der Hoff	88d41e94f5	Merge branch 'release-v1.10.0' into develop	2020-02-11 11:12:31 +00:00
Richard van der Hoff	856b2a9555	1.10.0rc5	2020-02-11 11:06:28 +00:00
Richard van der Hoff	605cd089f7	Merge branch 'release-v1.10.0' into develop	2020-02-11 10:43:47 +00:00
Richard van der Hoff	3edc65dd24	1.10.0rc4	2020-02-11 10:43:16 +00:00
Patrick Cloke	a92e703ab9	Reject device display names that are too long (#6882 ) * Reject device display names that are too long. Too long is currently defined as 100 characters in length. * Add a regression test for rejecting a too long device display name.	2020-02-10 16:35:26 -05:00
Matthew Hodgson	01209382fb	filter out m.room.aliases from /sync state blocks (#6884 ) We forgot to filter out aliases from /sync state blocks as well as the timeline.	2020-02-10 18:07:35 +00:00
Richard van der Hoff	db0fee738d	Synapse 1.10.0rc3 (2020-02-10) ============================== Features -------- - Filter out m.room.aliases from the CS API to mitigate abuse while a better solution is specced. ([\#6878](https://github.com/matrix-org/synapse/issues/6878)) Internal Changes ---------------- - Fix continuous integration failures with old versions of `pip`, which were introduced by a release of the `zipp` library. ([\#6880](https://github.com/matrix-org/synapse/issues/6880)) -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEv27Axt/F4vrTL/8QOSor00I9eP8FAl5BLBwACgkQOSor00I9 eP/9Ogf9HZ+XD5tt1uYkGqDSvUBS4sHdNcvxpNf1UMo6VaY4K5b9kF28MjY07ur2 nGq/nnLyLZZzwVXtV3q8upIdIK1hcMp2HCU0qDhEljepOkGmyQTqZooxrdrLTjPS 232bbifB6VFdK8P4gPIGopCRQI9a+TII4jODBobiJR43e0gEPfSREJKAnJs7DYaD Quf3Svzu+jB+X8ymWLVbCFXuk4A4UqPzrRPb8TQBDN3w35G4JBDAgIpdxhQdJpdR RIS1HgSm95P03doS23RLUjXuIpBfYveyStuGfPx4P9Lf30M2o6bxDeTPo2+IGbST yhl1jB0l8Ve5/6veuTieA6vuXWU55g== =2rgX -----END PGP SIGNATURE----- Merge tag 'v1.10.0rc3' into develop Synapse 1.10.0rc3 (2020-02-10) ============================== Features -------- - Filter out m.room.aliases from the CS API to mitigate abuse while a better solution is specced. ([\#6878](https://github.com/matrix-org/synapse/issues/6878)) Internal Changes ---------------- - Fix continuous integration failures with old versions of `pip`, which were introduced by a release of the `zipp` library. ([\#6880](https://github.com/matrix-org/synapse/issues/6880))	2020-02-10 10:15:32 +00:00
Richard van der Hoff	3de57e7062	1.10.0rc3	2020-02-10 09:56:42 +00:00
Matthew Hodgson	8e64c5a24c	filter out m.room.aliases from the CS API until a better solution is specced (#6878 ) We're in the middle of properly mitigating spam caused by malicious aliases being added to a room. However, until this work fully lands, we temporarily filter out all m.room.aliases events from /sync and /messages on the CS API, to remove abusive aliases. This is considered acceptable as m.room.aliases events were never a reliable record of the given alias->id mapping and were purely informational, and in their current state do more harm than good.	2020-02-10 09:36:23 +00:00
Erik Johnston	21db35f77e	Add support for putting fed user query API on workers (#6873 )	2020-02-07 15:45:39 +00:00
Richard van der Hoff	e1d858984d	Remove unused `get_room_stats_state` method. (#6869 )	2020-02-07 15:30:26 +00:00
Richard van der Hoff	799001f2c0	Add a `make_event_from_dict` method (#6858 ) ... and use it in places where it's trivial to do so. This will make it easier to pass room versions into the FrozenEvent constructors.	2020-02-07 15:30:04 +00:00
Erik Johnston	b08b0a22d5	Add typing to synapse.federation.sender (#6871 )	2020-02-07 13:56:38 +00:00
Erik Johnston	de2d267375	Allow moving group read APIs to workers (#6866 )	2020-02-07 11:14:19 +00:00
Dirk Klimpel	56ca93ef59	Admin api to add an email address (#6789 )	2020-02-07 10:29:36 +00:00
Richard van der Hoff	f4884444c3	remove unused room_version_to_event_format (#6857 )	2020-02-07 09:26:57 +00:00
Richard van der Hoff	e1b240329e	Merge pull request #6856 from matrix-org/rav/redact_changes/6 Pass room_version into `event_from_pdu_json`	2020-02-07 09:22:15 +00:00
Patrick Cloke	7765bf3989	Limit the number of events that can be requested when backfilling events (#6864 ) Limit the maximum number of events requested when backfilling events.	2020-02-06 13:25:24 -05:00
Richard van der Hoff	928edef979	Pass room_version into `event_from_pdu_json` It's called from all over the shop, so this one's a bit messy.	2020-02-06 16:08:27 +00:00
Richard van der Hoff	b0c8bdd49d	pass room version into FederationClient.send_join (#6854 ) ... which allows us to sanity-check the create event.	2020-02-06 15:50:39 +00:00
timfi	bce557175b	Allow empty federation_certificate_verification_whitelist (#6849 )	2020-02-06 14:45:01 +00:00
PeerD	99fcc96289	Third party event rules Update (#6781 )	2020-02-06 14:15:29 +00:00
Erik Johnston	ed630ea17c	Reduce amount of logging at INFO level. (#6862 ) A lot of the things we log at INFO are now a bit superfluous, so lets make them DEBUG logs to reduce the amount we log by default. Co-Authored-By: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Brendan Abolivier <github@brendanabolivier.com>	2020-02-06 13:31:05 +00:00
Richard van der Hoff	9bcd37146e	Merge pull request #6823 from matrix-org/rav/redact_changes/5 pass room versions around	2020-02-06 11:32:33 +00:00
Erik Johnston	2201ef8556	Synapse 1.10.0rc2 (2020-02-06) ============================== Bugfixes -------- - Fix an issue with cross-signing where device signatures were not sent to remote servers. ([\#6844](https://github.com/matrix-org/synapse/issues/6844)) - Fix to the unknown remote device detection which was introduced in 1.10.rc1. ([\#6848](https://github.com/matrix-org/synapse/issues/6848)) Internal Changes ---------------- - Detect unexpected sender keys on remote encrypted events and resync device lists. ([\#6850](https://github.com/matrix-org/synapse/issues/6850)) -----BEGIN PGP SIGNATURE----- iQJEBAABCgAuFiEEumuwyPtYLL2OMhYdOtoG7cdT0R4FAl478l8QHGVyaWtAbWF0 cml4Lm9yZwAKCRA62gbtx1PRHmKfD/0ZpBV95gMk0iecfvO6IY8+0KigzDUypgXf zp1k+k5DBUmH5/83h7+cXWHIJyofv1At1YdIq9J/nNeyqr3V3dcQwPabOKYbI96d kVD0EZX+2NjuYejAuF9eJNdiwRq5yMLluCfnOXr5jCS0NNdpO1xVb4bWYm50RmcD WJvBvmfwXwCC3AFyNb4IAipaVUXuVXXx1YhjFs6DsbtpPUG88e4uIhpfvrS4v0t8 GFJZNuVJStOvyKHHTfNRIMkhy4xidj3HRUMSmjNpx07WnPBnbv4LnUOD1boYxgaP EoODYnoAPshdiKB0AywNNjue3TmFD/Z7vVEzlFP/lNZ4GDU4kN9C/EwFYw0C2Jqq f9O/E2ZuP9Qqume5O9UwMQQAmhV5lMBaIsYRbixU+9bSB893zRHRffA11HypzD00 ZXj8QDOXpiXp2jpAwN1Rk9e/aZEX3qd+zUAgRmk+kYb0KTC2/gcY956rodNSSO/U RFYg4DFvoCgCrRSxZ4LQMlFu3YY2E7qWH+p/OHk3WG79jW64VpEFaytvv8fR+GKq g3EbtWy6mUzlKYqbjZ+ZTUDe5AWdv6ZX8xJqRD/S6cpiwyh6Gp89HHNvBThXoCmK fxkgw8if7eIITuTlNuDrqunxyWqwd3oVlzd2mi2bg0yRfcqJ9C6OuBV1VTLFZeky 3sjCiU0IRw== =kcSy -----END PGP SIGNATURE----- Merge tag 'v1.10.0rc2' into develop Synapse 1.10.0rc2 (2020-02-06) ============================== Bugfixes -------- - Fix an issue with cross-signing where device signatures were not sent to remote servers. ([\#6844](https://github.com/matrix-org/synapse/issues/6844)) - Fix to the unknown remote device detection which was introduced in 1.10.rc1. ([\#6848](https://github.com/matrix-org/synapse/issues/6848)) Internal Changes ---------------- - Detect unexpected sender keys on remote encrypted events and resync device lists. ([\#6850](https://github.com/matrix-org/synapse/issues/6850))	2020-02-06 11:04:03 +00:00
Erik Johnston	6a7e90ad78	1.10.0rc2	2020-02-06 10:40:08 +00:00
Richard van der Hoff	ee0525b2b2	Simplify `room_version` handling in `FederationClient.send_invite`	2020-02-05 17:43:57 +00:00
Richard van der Hoff	f84700fba8	Pass room version object into `FederationClient.get_pdu`	2020-02-05 17:25:46 +00:00
Richard van der Hoff	577f460369	Merge pull request #6840 from matrix-org/rav/federation_client_async Port much of `synapse.federation.federation_client` to async/await	2020-02-05 16:56:39 +00:00
Richard van der Hoff	6bbd890f05	make FederationClient._do_send_invite async	2020-02-05 15:50:31 +00:00
Richard van der Hoff	146fec0820	Apply suggestions from code review Co-Authored-By: Erik Johnston <erik@matrix.org>	2020-02-05 15:47:00 +00:00
Erik Johnston	a58860e480	Check sender_key matches on inbound encrypted events. (#6850 ) If they don't then the device lists are probably out of sync.	2020-02-05 14:02:39 +00:00
Hubert Chathi	60d0672426	Merge pull request #6844 from matrix-org/uhoreg/cross_signing_fix_device_fed add device signatures to device key query results	2020-02-05 10:54:49 +00:00
Michael Kaye	a831d2e4e3	Reduce performance logging to DEBUG (#6833 ) * Reduce tnx performance logging to DEBUG * Changelog.d	2020-02-05 08:57:37 +00:00
Richard van der Hoff	d88e0ec080	Database updates to populate rooms.room_version (#6847 ) We're going to need this so that we can figure out how to handle redactions when fetching events from the database.	2020-02-04 21:31:08 +00:00
Erik Johnston	6475382d80	Fix detecting unknown devices from remote encrypted events. (#6848 ) We were looking at the wrong event type (`m.room.encryption` vs `m.room.encrypted`). Also fixup the duplicate `EvenTypes` entries. Introduced in #6776.	2020-02-04 17:25:54 +00:00
Hubert Chathi	74bf3fdbb9	Merge pull request #6844 from matrix-org/uhoreg/cross_signing_fix_device_fed add device signatures to device key query results	2020-02-04 12:03:54 -05:00
Richard van der Hoff	5ef91b96f1	Merge remote-tracking branch 'origin/develop' into rav/federation_client_async	2020-02-04 12:07:05 +00:00
Richard van der Hoff	c7d6d5c69e	Merge pull request #6837 from matrix-org/rav/federation_async Port much of `synapse.handlers.federation` to async/await.	2020-02-04 12:06:18 +00:00
Hubert Chathi	23d8a55c7a	add device signatures to device key query results	2020-02-04 00:13:12 -05:00
Richard van der Hoff	ea23210b2d	make FederationClient.send_invite async	2020-02-03 22:29:49 +00:00
Richard van der Hoff	6deeefb68c	make FederationClient.get_missing_events async	2020-02-03 22:28:45 +00:00
Richard van der Hoff	abadf44eb2	make FederationClient._do_send_leave async	2020-02-03 22:28:45 +00:00
Richard van der Hoff	e88b90aaeb	make FederationClient.send_leave.send_request async	2020-02-03 22:28:45 +00:00
Richard van der Hoff	638001116d	make FederationClient._do_send_join async	2020-02-03 22:28:45 +00:00
Richard van der Hoff	3960527c2e	make FederationClient.send_join.send_request async	2020-02-03 22:28:45 +00:00
Richard van der Hoff	ad09ee9262	make FederationClient.make_membership_event.send_request async	2020-02-03 22:28:45 +00:00
Richard van der Hoff	1330c311b7	make FederationClient._try_destination_list async	2020-02-03 22:28:45 +00:00
Richard van der Hoff	a46fabf17b	make FederationClient.send_leave async	2020-02-03 22:28:45 +00:00
Richard van der Hoff	8af9f11bea	make FederationClient.send_join async	2020-02-03 22:28:45 +00:00
Richard van der Hoff	3f11cbb404	make FederationClient.make_membership_event async	2020-02-03 22:28:45 +00:00
Richard van der Hoff	24d814ca23	make FederationClient.get_event_auth async	2020-02-03 22:28:45 +00:00
Richard van der Hoff	d73683c363	make FederationClient.get_room_state_ids async	2020-02-03 22:28:45 +00:00
Richard van der Hoff	0cb0c7bcd5	make FederationClient.get_pdu async	2020-02-03 22:28:45 +00:00
Richard van der Hoff	0536d0c9be	make FederationClient.backfill async	2020-02-03 22:28:45 +00:00
Richard van der Hoff	5d17c31596	make FederationHandler.send_invite async	2020-02-03 22:28:11 +00:00
Richard van der Hoff	e81c093974	make FederationHandler.on_get_missing_events async	2020-02-03 19:15:08 +00:00
Erik Johnston	b9391c9575	Add typing to SyncHandler (#6821 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2020-02-03 18:05:44 +00:00
Erik Johnston	ae5b3104f0	Fix stacktraces when using ObservableDeferred and async/await (#6836 )	2020-02-03 17:10:54 +00:00
Richard van der Hoff	f64c96662e	make FederationHandler.user_joined_room async	2020-02-03 16:29:30 +00:00
Richard van der Hoff	52642860da	make FederationHandler._clean_room_for_join async	2020-02-03 16:29:30 +00:00
Richard van der Hoff	814cc00cb9	make FederationHandler._notify_persisted_event async	2020-02-03 16:29:30 +00:00
Richard van der Hoff	05299599b6	make FederationHandler.persist_events_and_notify async	2020-02-03 16:29:30 +00:00
Richard van der Hoff	3b7e0e002b	make FederationHandler._make_and_verify_event async	2020-02-03 16:22:30 +00:00
Richard van der Hoff	4286e429a7	make FederationHandler.do_remotely_reject_invite async	2020-02-03 16:19:18 +00:00
Richard van der Hoff	c3f296af32	make FederationHandler._check_for_soft_fail async	2020-02-03 16:16:31 +00:00
Richard van der Hoff	dbdf843012	make FederationHandler._persist_auth_tree async	2020-02-03 16:14:58 +00:00
Richard van der Hoff	ebd6a15af3	make FederationHandler.do_invite_join async	2020-02-03 16:13:13 +00:00
Richard van der Hoff	94f7b4cd54	make FederationHandler.on_event_auth async	2020-02-03 16:06:46 +00:00
Richard van der Hoff	863087d186	make FederationHandler.on_exchange_third_party_invite_request async	2020-02-03 16:02:50 +00:00
Richard van der Hoff	957129f4a7	make FederationHandler.construct_auth_difference async	2020-02-03 16:00:46 +00:00
Richard van der Hoff	0d5f2f4bb0	make FederationHandler._update_context_for_auth_events async	2020-02-03 15:55:35 +00:00
Richard van der Hoff	a25ddf26a3	make FederationHandler._update_auth_events_and_context_for_auth async	2020-02-03 15:53:54 +00:00
Richard van der Hoff	bc9b75c6f0	make FederationHandler.do_auth async	2020-02-03 15:51:24 +00:00
Richard van der Hoff	8033b257a7	make FederationHandler._prep_event async	2020-02-03 15:49:32 +00:00
Richard van der Hoff	1cdc253e0a	make FederationHandler._handle_new_event async	2020-02-03 15:48:33 +00:00
Richard van der Hoff	c556ed9e15	make FederationHandler._handle_new_events async	2020-02-03 15:43:51 +00:00
Richard van der Hoff	6e89ec5e32	make FederationHandler.on_make_leave_request async	2020-02-03 15:40:41 +00:00
Richard van der Hoff	d184cbc031	make FederationHandler.on_send_leave_request async	2020-02-03 15:39:24 +00:00
Richard van der Hoff	98681f90cb	make FederationHandler.on_make_join_request async	2020-02-03 15:38:02 +00:00
Richard van der Hoff	af8ba6b525	make FederationHandler.on_invite_request async	2020-02-03 15:33:42 +00:00
Richard van der Hoff	7571bf86f0	make FederationHandler.on_send_join_request async	2020-02-03 15:32:48 +00:00
Richard van der Hoff	b3e44f0bdf	make FederationHandler.on_query_auth async	2020-02-03 15:30:23 +00:00
Andrew Morgan	370080531e	Allow URL-encoded user IDs on user admin api paths (#6825 )	2020-02-03 13:18:42 +00:00
Richard van der Hoff	b0d112e78b	Fix `room_version` in `on_invite_request` flow (#6827 ) I messed this up a bit in #6805, but fortunately we weren't actually doing anything with the room_version so it didn't matter that it was a str not a RoomVersion.	2020-02-03 13:15:23 +00:00
Erik Johnston	ac0d45b78b	1.10.0rc1	2020-01-31 15:35:37 +00:00
Erik Johnston	83b0ea047b	Fix deleting of stale marker for device lists (#6819 ) We were in fact only deleting stale marker when we got an incremental update, rather than when we did a full resync.	2020-01-31 14:04:15 +00:00
Richard van der Hoff	7f93eb1903	pass room_version into compute_event_signature (#6807 )	2020-01-31 13:47:43 +00:00
Richard van der Hoff	a5afdd15e5	Merge pull request #6806 from matrix-org/rav/redact_changes/3 Pass room_version into add_hashes_and_signatures	2020-01-31 10:57:03 +00:00
Richard van der Hoff	160522e32c	Merge pull request #6820 from matrix-org/rav/get_room_version_id Make `get_room_version` return a RoomVersion object	2020-01-31 10:56:42 +00:00
Richard van der Hoff	08f41a6f05	Add `get_room_version` method So that we can start factoring out some of this boilerplatey boilerplate.	2020-01-31 10:28:15 +00:00
Richard van der Hoff	d7bf793cc1	s/get_room_version/get_room_version_id/ ... to make way for a forthcoming get_room_version which returns a RoomVersion object.	2020-01-31 10:06:21 +00:00
Erik Johnston	7d846e8704	Fix bug with getting missing auth event during join 500'ed (#6810 )	2020-01-31 09:49:13 +00:00
Richard van der Hoff	2a81393a4b	Pass room_version into add_hashes_and_signatures	2020-01-30 22:15:50 +00:00
Richard van der Hoff	54f3f369bd	Pass room_version into create_local_event_from_event_dict	2020-01-30 22:15:50 +00:00
Richard van der Hoff	ef6bdafb29	Store the room version in EventBuilder	2020-01-30 22:15:50 +00:00
Richard van der Hoff	46a446828d	pass room version into FederationHandler.on_invite_request (#6805 )	2020-01-30 22:13:02 +00:00
Erik Johnston	e0992fcc5b	Log when we delete room in bg update (#6816 )	2020-01-30 17:55:34 +00:00
Richard van der Hoff	184303b865	MSC2260: Block direct sends of m.room.aliases events (#6794 ) as per MSC2260	2020-01-30 17:20:55 +00:00
Erik Johnston	57ad702af0	Backgroud update to clean out rooms from current state (#6802 )	2020-01-30 17:17:44 +00:00
Erik Johnston	b660327056	Resync remote device list when detected as stale. (#6786 )	2020-01-30 17:06:38 +00:00
Erik Johnston	c3d4ad8afd	Fix sending server up commands from workers (#6811 ) Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2020-01-30 16:42:11 +00:00
Erik Johnston	a5bab2d058	When server leaves room check for stale device lists. (#6801 ) When a server leaves a room it may stop sharing a room with remote users, and thus not get any updates to their device lists. So we need to check for this case and delete those device lists from the cache. We don't need to do this if we stop sharing a room because the remote user leaves the room, because we track that case via looking at membership changes.	2020-01-30 16:10:30 +00:00
Erik Johnston	c80a9fe13d	When a client asks for remote keys check if should resync. (#6797 ) If we detect that the remote users' keys may have changed then we should attempt to resync against the remote server rather than using the (potentially) stale local cache.	2020-01-30 15:06:58 +00:00
Richard van der Hoff	5a246611e3	Type defintions for use in refactoring for redaction changes (#6803 ) * Bump signedjson to 1.1 ... so that we can use the type definitions * Fix breakage caused by upgrade to signedjson 1.1 Thanks, @illicitonion...	2020-01-30 11:25:59 +00:00
Erik Johnston	a855b7c3a8	Remove unused DeviceRow class (#6800 )	2020-01-29 12:06:31 +00:00
Richard van der Hoff	dcd85b976d	Make /directory/room/<alias> handle restrictive power levels Fixes a bug where the alias would be added, but `PUT /directory/room/<alias>` would return a 403.	2020-01-29 11:52:52 +00:00
Richard van der Hoff	b36095ae5c	Set the PL for aliases events to 0.	2020-01-29 11:52:52 +00:00
Richard van der Hoff	ee42a5513e	Factor out a `copy_power_levels_contents` method I'm going to need another copy (hah!) of this.	2020-01-29 11:52:52 +00:00
Erik Johnston	6b9e1014cf	Fix race in federation sender that delayed device updates. (#6799 ) We were sending device updates down both the federation stream and device streams. This mean there was a race if the federation sender worker processed the federation stream first, as when the sender checked if there were new device updates the slaved ID generator hadn't been updated with the new stream IDs and so returned nothing. This situation is correctly handled by events/receipts/etc by not sending updates down the federation stream and instead having the federation sender worker listen on the other streams and poke the transaction queues as appropriate.	2020-01-29 11:23:01 +00:00
Erik Johnston	611215a49c	Delete current state when server leaves a room (#6792 ) Otherwise its just stale data, which may get deleted later anyway so can't be relied on. It's also a bit of a shotgun if we're trying to get the current state of a room we're not in.	2020-01-29 11:01:32 +00:00
Erik Johnston	2cad8baa70	Fix bug when querying remote user keys that require a resync. (#6796 ) We ended up only returning a single device, rather than all of them.	2020-01-29 09:56:41 +00:00
Erik Johnston	fcfb591b31	Fix outbound federation request metrics (#6795 )	2020-01-28 18:59:48 +00:00
Richard van der Hoff	cc109b79dd	Merge pull request #6787 from matrix-org/rav/msc2260 Implement updated auth rules from MSC2260	2020-01-28 15:11:22 +00:00
Richard van der Hoff	a1f307f7d1	fix bad variable ref	2020-01-28 14:55:22 +00:00
Erik Johnston	e17a110661	Detect unknown remote devices and mark cache as stale (#6776 ) We just mark the fact that the cache may be stale in the database for now.	2020-01-28 14:43:21 +00:00
Richard van der Hoff	49d3bca37b	Implement updated auth rules from MSC2260	2020-01-28 14:20:10 +00:00
Richard van der Hoff	a8ce7aeb43	Pass room version object into event_auth.check and check_redaction (#6788 ) These are easier to work with than the strings and we normally have one around. This fixes `FederationHander._persist_auth_tree` which was passing a RoomVersion object into event_auth.check instead of a string.	2020-01-28 14:18:29 +00:00
Erik Johnston	02b44db922	Warn if postgres database has non-C locale. (#6734 ) As using non-C locale can cause issues on upgrading OS.	2020-01-28 13:44:21 +00:00
Erik Johnston	33f904835a	Merge branch 'master' into develop	2020-01-28 13:39:39 +00:00
Erik Johnston	77d9357226	1.9.1	2020-01-28 13:09:36 +00:00
Erik Johnston	bdbeeb94ec	Fix setting `mau_limit_reserved_threepids` config (#6793 ) Calling the invalidation function during initialisation of the data stores introduces a circular dependency, causing Synapse to fail to start.	2020-01-28 13:05:24 +00:00
Erik Johnston	8df862e45d	Add `rooms.room_version` column (#6729 ) This is so that we don't have to rely on pulling it out from `current_state_events` table.	2020-01-27 14:30:57 +00:00
Erik Johnston	d5275fc55f	Propagate cache invalidates from workers to other workers. (#6748 ) Currently if a worker invalidates a cache it will be streamed to master, which then didn't forward those to other workers.	2020-01-27 13:47:50 +00:00
Andrew Morgan	9f7aaf90b5	Validate client_secret parameter (#6767 )	2020-01-24 14:28:40 +00:00
Erik Johnston	fa4d609e20	Make 'event.redacts' never raise. (#6771 ) There are quite a few places that we assume that a redaction event has a corresponding `redacts` key, which is not always the case. So lets cheekily make it so that event.redacts just returns None instead.	2020-01-23 15:19:03 +00:00
Brendan Abolivier	51fc3f693e	Merge branch 'master' into develop	2020-01-23 13:45:23 +00:00
Brendan Abolivier	f3eac2b3e9	1.9.0	2020-01-23 12:57:55 +00:00
Richard van der Hoff	6b7462a13f	a bit of debugging for media storage providers (#6757 ) * a bit of debugging for media storage providers * changelog	2020-01-23 12:11:44 +00:00
Richard van der Hoff	5bd3cb7260	Minor fixes to user admin api (#6761 ) * don't insist on a password (this is valid if you have an SSO login) * fix reference to undefined `requester`	2020-01-23 12:03:58 +00:00
Andrew Morgan	ce84dd9e20	Remove unnecessary abstractions in admin handler (#6751 )	2020-01-22 15:09:57 +00:00
Brendan Abolivier	0d0f32bc53	1.9.0rc1	2020-01-22 14:03:46 +00:00
Andrew Morgan	90a28fb475	Admin API to list, filter and sort rooms (#6720 )	2020-01-22 13:36:43 +00:00
Brendan Abolivier	ed83c3a018	Fix typo in _select_thumbnail	2020-01-22 12:27:42 +00:00
Andrew Morgan	aa9b00fb2f	Fix and add test to deprecated quarantine media admin api (#6756 )	2020-01-22 11:05:50 +00:00
Neil Johnson	5e52d8563b	Allow monthly active user limiting support for worker mode, fixes #4639 . (#6742 )	2020-01-22 11:05:14 +00:00
Erik Johnston	5d7a6ad223	Allow streaming cache invalidate all to workers. (#6749 )	2020-01-22 10:37:00 +00:00
Erik Johnston	0e68760078	Add a DeltaState to track changes to be made to current state (#6716 )	2020-01-20 18:07:20 +00:00
Erik Johnston	b0a66ab83c	Fixup synapse.rest to pass mypy (#6732 )	2020-01-20 17:38:21 +00:00
Erik Johnston	74b74462f1	Fix `/events/:event_id` deprecated API. (#6731 )	2020-01-20 17:38:09 +00:00
Erik Johnston	0f6e525be3	Fixup synapse.api to pass mypy (#6733 )	2020-01-20 17:34:13 +00:00
Erik Johnston	ceecedc68b	Fix changing password via user admin API. (#6730 )	2020-01-20 17:23:59 +00:00
Andrew Morgan	198d52da3a	Fix empty account_validity config block	2020-01-20 14:05:29 +00:00
Brendan Abolivier	a17f64361c	Add more logging around message retention policies support (#6717 ) So we can debug issues like #6683 more easily	2020-01-17 20:51:44 +00:00
Richard van der Hoff	0b885d62ef	bump version to v1.9.0.dev2	2020-01-17 14:58:58 +00:00
Satsuki Yanagi	722b4f302d	Fix syntax error in run_upgrade for schema 57 (#6728 ) Fix #6727 Related #6655 Co-authored-by: Erik Johnston <erikj@jki.re>	2020-01-17 14:30:35 +00:00
Brendan Abolivier	3b72bb780a	Merge pull request #6714 from matrix-org/babolivier/retention_select_event Fix instantiation of message retention purge jobs	2020-01-17 14:23:51 +00:00
Richard van der Hoff	1dee1e900b	bump version to v1.9.0.dev1	2020-01-17 10:44:12 +00:00
Richard van der Hoff	59dc87c618	Merge pull request #6724 from matrix-org/rav/log_saml_attributes Log saml assertions rather than the whole response	2020-01-17 10:33:24 +00:00
Richard van der Hoff	2b6a77fcde	Delegate remote_user_id mapping to the saml mapping provider (#6723 ) Turns out that figuring out a remote user id for the SAML user isn't quite as obvious as it seems. Factor it out to the SamlMappingProvider so that it's easy to control.	2020-01-17 10:32:47 +00:00
Erik Johnston	a8a50f5b57	Wake up transaction queue when remote server comes back online (#6706 ) This will be used to retry outbound transactions to a remote server if we think it might have come back up.	2020-01-17 10:27:19 +00:00
Richard van der Hoff	5ce0b17e38	Clarify the `account_validity` and `email` sections of the sample configuration. (#6685 ) Generally try to make this more comprehensible, and make it match the conventions. I've removed the documentation for all the settings which allow you to change the names of the template files, because I can't really see why they are useful.	2020-01-17 10:04:15 +00:00
Richard van der Hoff	acc7820574	Log saml assertions rather than the whole response ... since the whole response is huge. We even need to break up the assertions, since kibana otherwise truncates them.	2020-01-16 22:26:34 +00:00
Richard van der Hoff	14d8f342d5	move batch_iter to a separate module	2020-01-16 22:25:32 +00:00
Brendan Abolivier	dac148341b	Fixup diff	2020-01-16 20:25:09 +00:00
Brendan Abolivier	842c2cfbf1	Remove get_room_event_after_stream_ordering entirely	2020-01-16 20:24:17 +00:00
Erik Johnston	d386f2f339	Add StateMap type alias (#6715 )	2020-01-16 13:31:22 +00:00
Brendan Abolivier	e601f35d3b	Lint	2020-01-16 09:55:11 +00:00
Neil Johnson	38e0e59f42	Add org.matrix.e2e_cross_signing to unstable_features in /versions as per MSC1756 (#6712 )	2020-01-16 09:46:14 +00:00
Erik Johnston	48c3a96886	Port synapse.replication.tcp to async/await (#6666 ) * Port synapse.replication.tcp to async/await * Newsfile * Correctly document type of on_<FOO> functions as async * Don't be overenthusiastic with the asyncing....	2020-01-16 09:16:12 +00:00
Brendan Abolivier	066b9f52b8	Correctly order when selecting before stream ordering	2020-01-15 19:32:47 +00:00
Brendan Abolivier	8363588237	Fix typo	2020-01-15 19:13:22 +00:00
Brendan Abolivier	855af069a4	Fix instantiation of message retention purge jobs When figuring out which topological token to start a purge job at, we need to do the following: 1. Figure out a timestamp before which events will be purged 2. Select the first stream ordering after that timestamp 3. Select info about the first event after that stream ordering 4. Build a topological token from that info In some situations (e.g. quiet rooms with a short max_lifetime), there might not be an event after the stream ordering at step 3, therefore we abort the purge with the error `No event found`. To mitigate that, this patch fetches the first event _before_ the stream ordering, instead of after.	2020-01-15 18:56:18 +00:00
Erik Johnston	19a1aac48c	Fix purge_room admin API (#6711 )	2020-01-15 18:13:47 +00:00
Andrew Morgan	edc244eec4	Remove duplicate session check in web fallback servlet (#6702 )	2020-01-15 18:05:18 +00:00
Richard van der Hoff	107f256cd8	Merge branch 'develop' into rav/module_api_extensions	2020-01-15 16:00:24 +00:00
Richard van der Hoff	8f5d7302ac	Implement RedirectException (#6687 ) Allow REST endpoint implemnentations to raise a RedirectException, which will redirect the user's browser to a given location.	2020-01-15 15:58:55 +00:00
Erik Johnston	28c98e51ff	Add `local_current_membership` table (#6655 ) Currently we rely on `current_state_events` to figure out what rooms a user was in and their last membership event in there. However, if the server leaves the room then the table may be cleaned up and that information is lost. So lets add a table that separately holds that information.	2020-01-15 14:59:33 +00:00
Erik Johnston	b5ce7f5874	Process EDUs in parallel with PDUs. (#6697 ) This means that things like to device messages don't get blocked behind processing PDUs, which can potentially take ages.	2020-01-14 14:08:35 +00:00
Erik Johnston	e8b68a4e4b	Fixup synapse.replication to pass mypy checks (#6667 )	2020-01-14 14:08:06 +00:00
Andrew Morgan	1177d3f3a3	Quarantine media by ID or user ID (#6681 )	2020-01-13 18:10:43 +00:00
Richard van der Hoff	326c893d24	Kill off RegistrationError (#6691 ) This is pretty pointless. Let's just use SynapseError.	2020-01-13 12:48:22 +00:00
Richard van der Hoff	2d07c73777	Don't assign numeric IDs for empty usernames (#6690 ) Fix a bug where we would assign a numeric userid if somebody tried registering with an empty username	2020-01-13 12:47:30 +00:00
Richard van der Hoff	3cfac9593c	Merge pull request #6689 from matrix-org/rav/saml_mapping_provider_updates Updates to the SAML mapping provider API	2020-01-13 12:44:55 +00:00
Richard van der Hoff	8039685051	Allow additional_resources to implement Resource directly (#6686 ) AdditionalResource really doesn't add any value, and it gets in the way for resources which want to support child resources or the like. So, if the resource object already implements the IResource interface, don't bother wrapping it.	2020-01-13 12:42:44 +00:00
Richard van der Hoff	feee819973	Fix exceptions on requests for non-ascii urls (#6682 ) Fixes #6402	2020-01-13 12:41:51 +00:00
Richard van der Hoff	da4e52544e	comment for run_in_background	2020-01-12 21:53:47 +00:00
Richard van der Hoff	dc69a1cf43	Pass client redirect URL into SAML mapping providers	2020-01-12 21:40:49 +00:00
Richard van der Hoff	47e63cc67a	Pass the module_api into the SamlMappingProvider ... for consistency with other modules, and because we'll need it sooner or later and it will be a pain to introduce later.	2020-01-12 21:40:49 +00:00
Richard van der Hoff	01243b98e1	Handle `config` not being set for synapse plugin modules Some modules don't need any config, so having to define a `config` property just to keep the loader happy is a bit annoying.	2020-01-12 21:34:36 +00:00
Richard van der Hoff	473d3801b6	Cleanups and additions to the module API Add some useful things, such as error types and logcontext handling, to the API. Make `hs` a private member to dissuade people from using it (hopefully they aren't already). Add a couple of new methods (`record_user_external_id` and `generate_short_term_login_token`).	2020-01-12 21:31:44 +00:00
Richard van der Hoff	bf46821180	Refuse to start if sqlite is older than 3.11.0	2020-01-09 18:11:04 +00:00
Richard van der Hoff	e48ba84e0b	Check postgres version in check_database this saves doing it on each connection, and will allow us to pass extra options in.	2020-01-09 18:05:59 +00:00
Richard van der Hoff	e97d1cf001	Modify check_database to take a connection rather than a cursor We might not need the cursor at all.	2020-01-09 18:05:50 +00:00
Manuel Stahl	d2906fe666	Allow admin users to create or modify users without a shared secret (#6495 ) Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>	2020-01-09 13:31:00 +00:00
Erik Johnston	d773290cb1	Merge branch 'master' into develop	2020-01-09 13:25:48 +00:00
Erik Johnston	24b2c940fb	1.8.0	2020-01-09 11:39:29 +00:00
Erik Johnston	7c232bd98b	Merge pull request #6664 from matrix-org/erikj/media_admin_apis Fix media repo admin APIs when using a media worker.	2020-01-08 15:50:06 +00:00
Erik Johnston	d74054afda	Shuffle the code	2020-01-08 14:57:45 +00:00
Erik Johnston	bca3455b38	Comments	2020-01-08 14:27:35 +00:00
Erik Johnston	187dc6ad02	Do not rely on streaming events, as media repo doesn't	2020-01-08 14:24:28 +00:00
Richard van der Hoff	b064a41291	Merge remote-tracking branch 'origin/release-v1.8.0' into develop	2020-01-08 13:27:17 +00:00
Manuel Stahl	7caaa29daa	Fix GET request on /_synapse/admin/v2/users endpoint (#6563 ) Fixes #6552	2020-01-08 13:26:40 +00:00
Erik Johnston	1adf27c82a	Import RoomStore in media worker to fix admin APIs	2020-01-08 13:26:20 +00:00
Erik Johnston	3cf7d6d5b6	Move media admin store functions to worker store	2020-01-08 13:26:20 +00:00
Richard van der Hoff	573fee759c	Back out ill-advised notary server hackery (#6657 ) This was ill-advised. We can't modify verify_keys here, because the response object has already been signed by the requested key. Furthermore, it's somewhat unnecessary because existing versions of Synapse (which get upset that the notary key isn't present in verify_keys) will fall back to a direct fetch via `/key/v2/server`. Also: more tests for fetching keys via perspectives: it would be nice if we actually tested when our fetcher can't talk to our notary impl.	2020-01-08 13:24:10 +00:00
Erik Johnston	be29ed7ad8	Correctly proxy remote group HTTP errors. (#6654 ) e.g. if remote returns a 404 then that shouldn't be treated as an error but should be proxied through.	2020-01-07 15:36:41 +00:00
Brendan Abolivier	2b6b7f482a	Merge pull request #6621 from matrix-org/babolivier/purge_job_config_typo Fix a typo in the purge jobs configuration example	2020-01-07 16:17:40 +01:00
Brendan Abolivier	391fb47791	Reword	2020-01-07 14:54:32 +00:00
Brendan Abolivier	3a86477162	Change the example from 5min to 12h Have a purge job running every 5min is probably not something we want to advise admins to do as a sort-of default.	2020-01-07 14:53:07 +00:00
Erik Johnston	7f0e706ebf	1.8.0rc1	2020-01-07 14:31:13 +00:00
Brendan Abolivier	0ab5853ec9	Merge pull request #6652 from matrix-org/babolivier/depth_missing_events Fix conditions failing if min_depth = 0	2020-01-07 15:22:07 +01:00
Richard van der Hoff	85db7f73be	Add a background update to clear tombstoned rooms from the directory (#6648 ) * Add a background update to clear tombstoned rooms from the directory * use the ABC metaclass	2020-01-07 14:18:43 +00:00
Richard van der Hoff	9824a39d80	Async/await for background updates (#6647 ) so that bg update routines can be async	2020-01-07 14:12:42 +00:00
Richard van der Hoff	1ff5491117	Merge pull request #6645 from matrix-org/rav/fix_synchrotron_error Fix exceptions in the synchrotron worker log when events are rejected.	2020-01-07 14:02:14 +00:00
Brendan Abolivier	cd428a93e2	Fix conditions failing if min_depth = 0 This could result in Synapse not fetching prev_events for new events in the room if it has missed some events.	2020-01-07 12:08:58 +00:00
Richard van der Hoff	1807db5e73	Merge pull request #6629 from matrix-org/rav/kill_event_reference_hashes Remove a bunch of unused code from event creation	2020-01-06 17:46:31 +00:00
Richard van der Hoff	26c5d3d398	Fix exceptions in log when rejected event is replicated	2020-01-06 17:16:28 +00:00
Richard van der Hoff	c74de81bfc	async/await for SyncReplicationHandler.process_and_notify	2020-01-06 17:14:28 +00:00
Richard van der Hoff	bc42da4ab8	Clarify documentation on get_event* methods Make it clearer how they behave in the face of rejected and/or missing events.	2020-01-06 17:12:06 +00:00
Richard van der Hoff	ba897a7590	Fix some test failures when frozen_dicts are enabled (#6642 ) Fixes #4026	2020-01-06 15:22:46 +00:00
Erik Johnston	9f6c1befbb	Add experimental 'databases' config (#6580 )	2020-01-06 14:44:01 +00:00
Richard van der Hoff	ab4b4ee6a7	Fix an error which was thrown by the PresenceHandler _on_shutdown handler. (#6640 )	2020-01-06 14:34:02 +00:00
Richard van der Hoff	a7d2e5b37f	Remove unused get_latest_event_ids_and_hashes_in_room	2020-01-06 13:45:33 +00:00
Richard van der Hoff	dc41fbf0dd	Remove unused get_prev_events_and_hashes_for_room	2020-01-06 13:45:33 +00:00
Richard van der Hoff	38e0829a4c	Remove unused hashes and depths from _update_membership params	2020-01-06 13:45:33 +00:00
Richard van der Hoff	3bef62488e	Remove unused hashes and depths from create_event params	2020-01-06 13:45:33 +00:00
Richard van der Hoff	66ca914dc0	Remove unused hashes and depths from create_new_client_event params	2020-01-06 13:45:33 +00:00
Richard van der Hoff	15720092ac	replace get_prev_events_and_hashes_for_room with get_prev_events_for_room in create_new_client_event	2020-01-06 13:45:33 +00:00
Richard van der Hoff	5a04781643	rename get_prev_events_for_room to get_prev_events_and_hashes_for_room ... to make way for a new method which just returns the event ids	2020-01-06 13:45:33 +00:00
Richard van der Hoff	4b36b482e0	Fix exception when fetching notary server's old keys (#6625 ) Lift the restriction that all the keys used for signing v2 key responses be present in verify_keys. Fixes #6596.	2020-01-06 12:33:56 +00:00
Richard van der Hoff	18674eebb1	Workaround for error when fetching notary's own key (#6620 ) * Kill off redundant SynapseRequestFactory We already get the Site via the Channel, so there's no need for a dedicated RequestFactory: we can just use the right constructor. * Workaround for error when fetching notary's own key As a notary server, when we return our own keys, include all of our signing keys in verify_keys. This is a workaround for #6596.	2020-01-06 12:28:58 +00:00
Andrew Morgan	01c3c6c929	Fix power levels being incorrectly set in old and new rooms after a room upgrade (#6633 ) Modify a copy of an upgraded room's PL before sending to the new room	2020-01-06 09:53:07 +00:00
Richard van der Hoff	08815566bc	Automate generation of the sample and debian log configs (#6627 )	2020-01-03 17:14:00 +00:00
Richard van der Hoff	e484101306	Raise an error if someone tries to use the log_file config option (#6626 ) This has caused some confusion for people who didn't notice it going away.	2020-01-03 17:11:29 +00:00
Richard van der Hoff	98247c4a0e	Remove unused, undocumented "content repo" resource (#6628 ) This looks like it got half-killed back in #888. Fixes #6567.	2020-01-03 17:10:52 +00:00
Richard van der Hoff	b6b57ecb4e	Kill off redundant SynapseRequestFactory (#6619 ) We already get the Site via the Channel, so there's no need for a dedicated RequestFactory: we can just use the right constructor.	2020-01-03 14:19:48 +00:00
Richard van der Hoff	6964ea095b	Reduce the reconnect time when replication fails. (#6617 )	2020-01-03 14:19:09 +00:00
Brendan Abolivier	4efe1d4d3f	Fix a typo in the purge jobs configuration example	2020-01-03 12:57:24 +01:00
Richard van der Hoff	dc96943d51	Merge branch 'master' into develop	2019-12-31 11:01:06 +00:00
Richard van der Hoff	77661ce81a	1.7.3	2019-12-31 10:45:12 +00:00
Richard van der Hoff	92eac974b9	Hacks to work around #6605 (#6608 ) When we have an event which refers to non-existent auth_events, ignore said events rather than exploding in a ball of fire. Fixes #6605.	2019-12-31 10:41:44 +00:00
Richard van der Hoff	56ad230efa	Merge branch 'master' into develop	2019-12-20 11:11:34 +00:00
Richard van der Hoff	29794c6bc8	1.7.2	2019-12-20 10:58:07 +00:00
Erik Johnston	75d8f26ac8	Split state groups into a separate data store (#6296 )	2019-12-20 10:48:24 +00:00
Richard van der Hoff	4caab0e95e	Backport fixes to sqlite upgrade from develop (#6578 ) Only run prepare_database on connection for in-memory databases. Fixes #6569.	2019-12-20 10:46:46 +00:00
Erik Johnston	fa780e9721	Change EventContext to use the Storage class (#6564 )	2019-12-20 10:32:02 +00:00
Richard van der Hoff	03d3792f3c	Fix exceptions when attempting to backfill (#6576 ) Fixes #6575	2019-12-20 09:55:45 +00:00
Erik Johnston	0b5dbadd96	Explode on duplicate delta file names. (#6565 )	2019-12-19 15:07:37 +00:00
Erik Johnston	3d46124ad0	Port some admin handlers to async/await (#6559 )	2019-12-19 15:07:28 +00:00
Richard van der Hoff	bca30cefee	Improve diagnostics on database upgrade failure (#6570 ) `Failed to upgrade database` is not helpful, and it's unlikely that UPGRADE.rst has anything useful.	2019-12-19 14:53:15 +00:00
Richard van der Hoff	0b794cbd7b	Fix sdnotify with acme enabled (#6571 ) If acme was enabled, the sdnotify startup hook would never be run because we would try to add it to a hook which had already fired. There's no need to delay it: we can sdnotify as soon as we've started the listeners.	2019-12-19 14:52:52 +00:00
Richard van der Hoff	b95b762560	Add an export_signing_key script (#6546 ) I want to do some key rotation, and it is silly that we don't have a way to do this.	2019-12-19 11:11:14 +00:00
Richard van der Hoff	d6752ce5da	Clean up startup for the pusher (#6558 ) * Remove redundant python2 support code `str.decode()` doesn't exist on python3, so presumably this code was doing nothing * Filter out pushers with corrupt data When we get a row with unparsable json, drop the row, rather than returning a row with null `data`, which will then cause an explosion later on. * Improve logging when we can't start a pusher Log the ID to help us understand the problem * Make email pusher setup more robust We know we'll have a `data` member, since that comes from the database. What we don't know is if that is a dict, and if that has a `brand` member, and if that member is a string.	2019-12-18 14:26:58 +00:00
Andrew Morgan	7963ca83cb	Add delta file to fix missing default table data (#6555 )	2019-12-18 11:13:33 +00:00
Erik Johnston	2284eb3a53	Add database config class (#6513 ) This encapsulates config for a given database and is the way to get new connections.	2019-12-18 10:45:12 +00:00
Richard van der Hoff	91ccfe9f37	Merge branch 'master' into develop	2019-12-18 10:16:39 +00:00
Richard van der Hoff	6e8f8e14f2	Merge release-v1.7.1 into develop	2019-12-18 09:51:51 +00:00
Richard van der Hoff	d656e91fc2	1.7.1	2019-12-18 09:38:08 +00:00
Erik Johnston	5029422530	Fix bug where we added duplicate event IDs as auth_events (#6560 )	2019-12-17 15:06:08 +00:00
Erik Johnston	02553901ce	Remove unused `get_pagination_rows` methods. (#6557 ) Remove unused get_pagination_rows methods	2019-12-17 11:44:32 +00:00
Erik Johnston	5ca2cfadc3	Add auth events as per spec. (#6556 ) Previously we tried to be clever and filter out some unnecessary event IDs to keep the auth chain small, but that had some annoying interactions with state res v2 so we stop doing that for now.	2019-12-16 17:05:01 +00:00
Erik Johnston	3fbe5b7ec3	Add auth events as per spec. (#6556 ) Previously we tried to be clever and filter out some unnecessary event IDs to keep the auth chain small, but that had some annoying interactions with state res v2 so we stop doing that for now.	2019-12-16 16:59:32 +00:00
Brendan Abolivier	6316530366	Merge pull request #6553 from matrix-org/babolivier/fix-context-filter Use the filtered version of an event when responding to /context requests for that event	2019-12-16 16:24:10 +00:00
Will Hunt	bfb95654c9	Add option to allow profile queries without sharing a room (#6523 )	2019-12-16 16:11:55 +00:00
Brendan Abolivier	a820069549	Incorporate review	2019-12-16 16:00:18 +00:00
Richard van der Hoff	bbb75ff6ee	Exclude rejected state events when calculating state at backwards extrems (#6527 ) This fixes a weird bug where, if you were determined enough, you could end up with a rejected event forming part of the state at a backwards-extremity. Authing that backwards extrem would then lead to us trying to pull the rejected event from the db (with allow_rejected=False), which would fail with a 404.	2019-12-16 14:07:29 +00:00
Richard van der Hoff	ff773ff724	Persist auth/state events at backwards extremities when we fetch them (#6526 ) The main point here is to make sure that the state returned by _get_state_in_room has been authed before we try to use it as state in the room.	2019-12-16 14:07:11 +00:00
Richard van der Hoff	83895316d4	sanity-checking for events used in state res (#6531 ) When we perform state resolution, check that all of the events involved are in the right room.	2019-12-16 13:53:53 +00:00
Richard van der Hoff	6577f2d887	Sanity-check room ids in event auth (#6530 ) When we do an event auth operation, check that all of the events involved are in the right room.	2019-12-16 13:47:34 +00:00
Richard van der Hoff	35bbe4ca79	Check the room_id of events when fetching room state/auth (#6524 ) When we request the state/auth_events to populate a backwards extremity (on backfill or in the case of missing events in a transaction push), we should check that the returned events are in the right room rather than blindly using them in the room state or auth chain. Given that _get_events_from_store_or_dest takes a room_id, it seems clear that it should be sanity-checking the room_id of the requested events, so let's do it there.	2019-12-16 13:47:07 +00:00
Richard van der Hoff	20d5ba16e6	Add `include_event_in_state` to _get_state_for_room (#6521 ) Make it return the state after the requested event, rather than the one before it. This is a bit easier and requires fewer calls to get_events_from_store_or_dest.	2019-12-16 13:26:12 +00:00
Richard van der Hoff	be294d6fde	Move get_state methods into FederationHandler (#6503 ) This is a non-functional refactor as a precursor to some other work.	2019-12-16 13:20:21 +00:00
Richard van der Hoff	4c7b1bb6cc	Refactor get_events_from_store_or_dest to return a dict (#6501 ) There was a bunch of unnecessary conversion back and forth between dict and list going on here. We can simplify a bunch of the code.	2019-12-16 13:19:32 +00:00
Richard van der Hoff	6920d88892	Exclude rejected state events when calculating state at backwards extrems (#6527 ) This fixes a weird bug where, if you were determined enough, you could end up with a rejected event forming part of the state at a backwards-extremity. Authing that backwards extrem would then lead to us trying to pull the rejected event from the db (with allow_rejected=False), which would fail with a 404.	2019-12-16 13:14:37 +00:00
Richard van der Hoff	bc7de87650	Persist auth/state events at backwards extremities when we fetch them (#6526 ) The main point here is to make sure that the state returned by _get_state_in_room has been authed before we try to use it as state in the room.	2019-12-16 12:26:28 +00:00
Brendan Abolivier	ac87ddb242	Update the documentation of the filtering function	2019-12-16 12:15:37 +00:00
Brendan Abolivier	487f1bb49d	Use the filtered version of an event when responding to /context requests for that event Sometimes the filtering function can return a pruned version of an event (on top of either the event itself or an empty list), if it thinks the user should be able to see that there's an event there but not the content of that event. Therefore, the previous logic of 'if filtered is empty then we can use the event we retrieved from the database' is flawed, and we should use the event returned by the filtering function.	2019-12-16 12:14:12 +00:00
Werner Sembach	9d173b312c	Automatically delete empty groups/communities (#6453 ) Signed-off-by: Werner Sembach <werner.sembach@fau.de>	2019-12-16 12:12:40 +00:00
Richard van der Hoff	1da15f05f5	sanity-checking for events used in state res (#6531 ) When we perform state resolution, check that all of the events involved are in the right room.	2019-12-13 12:55:32 +00:00
Richard van der Hoff	971a0702b5	Sanity-check room ids in event auth (#6530 ) When we do an event auth operation, check that all of the events involved are in the right room.	2019-12-13 11:44:41 +00:00
Erik Johnston	5cadbd9ebb	Merge pull request #6537 from matrix-org/erikj/bump_mypy_version Bump mypy version	2019-12-13 11:32:53 +00:00
Erik Johnston	f46e05d053	Merge branch 'master' into develop	2019-12-13 10:55:47 +00:00
Erik Johnston	f5aeea9e89	1.7.0	2019-12-13 10:19:53 +00:00
Erik Johnston	caa52836e4	Merge pull request #6496 from matrix-org/erikj/initial_sync_asnyc Port synapse.handlers.initial_sync to async/await	2019-12-13 10:01:51 +00:00
Hubert Chathi	cb2db17994	look up cross-signing keys from the DB in bulk (#6486 )	2019-12-12 12:03:28 -05:00
Andrew Morgan	5bfd8855d6	Fix redacted events being returned in search results ordered by "recent" (#6522 )	2019-12-12 15:53:49 +00:00
Erik Johnston	495005360c	Bump version of mypy	2019-12-12 15:21:12 +00:00
Richard van der Hoff	25f1244329	Check the room_id of events when fetching room state/auth (#6524 ) When we request the state/auth_events to populate a backwards extremity (on backfill or in the case of missing events in a transaction push), we should check that the returned events are in the right room rather than blindly using them in the room state or auth chain. Given that _get_events_from_store_or_dest takes a room_id, it seems clear that it should be sanity-checking the room_id of the requested events, so let's do it there.	2019-12-12 12:57:45 +00:00
Erik Johnston	b8e4b39b69	Merge pull request #6511 from matrix-org/erikj/remove_db_config_from_apps Move database config from apps into HomeServer object	2019-12-12 10:37:56 +00:00
Erik Johnston	cfcfb57e58	Add new config param to docstring and add types	2019-12-11 17:27:46 +00:00
Erik Johnston	6828b47c45	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/initial_sync_asnyc	2019-12-11 17:01:41 +00:00
Richard van der Hoff	2045356517	Add `include_event_in_state` to _get_state_for_room (#6521 ) Make it return the state after the requested event, rather than the one before it. This is a bit easier and requires fewer calls to get_events_from_store_or_dest.	2019-12-11 16:37:51 +00:00
Richard van der Hoff	894d2addac	Merge pull request #6517 from matrix-org/rav/event_auth/13 Port some of FederationHandler to async/await	2019-12-11 16:36:06 +00:00
Erik Johnston	31905a518e	Merge pull request #6504 from matrix-org/erikj/account_validity_async_await Port handlers.account_validity to async/await.	2019-12-11 14:49:26 +00:00
Richard van der Hoff	6637d90d77	convert to async: FederationHandler._process_received_pdu also fix user_joined_room to consistently return deferreds	2019-12-11 14:39:26 +00:00
Richard van der Hoff	4db394a4b3	convert to async: FederationHandler._get_state_for_room ... and _get_events_from_store_or_dest	2019-12-11 14:39:26 +00:00
Richard van der Hoff	e77237b935	convert to async: FederationHandler.on_receive_pdu and associated functions: * on_receive_pdu * handle_queued_pdus * get_missing_events_for_pdu	2019-12-11 14:39:26 +00:00
Richard van der Hoff	7712e751b8	Convert federation backfill to async PaginationHandler.get_messages is only called by RoomMessageListRestServlet, which is async. Chase the code path down from there: - FederationHandler.maybe_backfill (and nested try_backfill) - FederationHandler.backfill	2019-12-11 14:39:25 +00:00
Richard van der Hoff	7c429f92d6	Clean up some logging (#6515 ) This just makes some of the logging easier to follow when things start going wrong.	2019-12-11 14:32:25 +00:00
Erik Johnston	adb3a873fd	Synapse 1.7.0rc2 (2019-12-11) ============================= Bugfixes -------- - Fix incorrect error message for invalid requests when setting user's avatar URL. ([\#6497](https://github.com/matrix-org/synapse/issues/6497)) - Fix support for SQLite 3.7. ([\#6499](https://github.com/matrix-org/synapse/issues/6499)) - Fix regression where sending email push would not work when using a pusher worker. ([\#6507](https://github.com/matrix-org/synapse/issues/6507), [\#6509](https://github.com/matrix-org/synapse/issues/6509)) -----BEGIN PGP SIGNATURE----- iQJEBAABCgAuFiEEumuwyPtYLL2OMhYdOtoG7cdT0R4FAl3w+RwQHGVyaWtAbWF0 cml4Lm9yZwAKCRA62gbtx1PRHijfD/43EQ58jqKvD+qKZwVFOE6JJ3SCS7UJbi3f zq9KWDuCB6EAFjAgmJikbBBqHPO5qq2WtNXaCpexx44s8Mk8SZKHg56dP6Fk651C assAb/Nsh6CAlPUcRkx8I0L/kYXMPDyATlLVBHVOi3pFDJ093mdOQ4q8yP9iUTM+ OPsbT8k/pMhrhCH951bGmB6/SEcju+ubObW+bRFe8o3v1KE9jVYQjUGMhuoXp3pM z/OB8idZcqOvCc6HMo83tg9FuI613Jy80PMIc1ofyJgvnu+aDBepWuldvFEMnmSR D862jMor7+WdnDOTeWZrC+DXjl0qCP8F6ahs5rEllRglt/Ep2wEDPA/8YrRoEI3V RWe9W7XDdFCXdzlvXheOfETqTu9kdsurTwBEeJrWQ0vOLY86hxt9KKKcHVhy5eKq kNfRtvSVLmRhIssp7hVBcywRwnaxN7R2OoRq/TWnTZz+xEOPzYFU6r0l9kk5dbg6 fqYYxIXbgZlhjihLWNIMNwwZH9ll/eoPiinkRTZNz40THP/VDTR9DM4tQ6jrhrr6 sP0qM7LljvrdiimXtV00tUDyUspNgJl6xDJyGDHWM9uoCB7uorEpMQZSzlZhZe8s 6q+fQPHlfW4JYOejfihPkjrV1ViawvEucqWPaIsD+v26C4RP7qCTtYj3NPiA65of zhOjomWWcg== =ABoZ -----END PGP SIGNATURE----- Merge tag 'v1.7.0rc2' into develop Synapse 1.7.0rc2 (2019-12-11) ============================= Bugfixes -------- - Fix incorrect error message for invalid requests when setting user's avatar URL. ([\#6497](https://github.com/matrix-org/synapse/issues/6497)) - Fix support for SQLite 3.7. ([\#6499](https://github.com/matrix-org/synapse/issues/6499)) - Fix regression where sending email push would not work when using a pusher worker. ([\#6507](https://github.com/matrix-org/synapse/issues/6507), [\#6509](https://github.com/matrix-org/synapse/issues/6509))	2019-12-11 14:14:30 +00:00
Erik Johnston	d156912c4c	1.7.0rc2	2019-12-11 13:56:50 +00:00
Andrew Morgan	fc316a4894	Prevent redacted events from appearing in message search (#6377 )	2019-12-11 13:39:47 +00:00
Andrew Morgan	6676ee9c4a	Add dev script to generate full SQL schema files (#6394 )	2019-12-11 13:16:01 +00:00
Andrew Morgan	ea0f0ad414	Prevent message search in upgraded rooms we're not in (#6385 )	2019-12-11 13:07:25 +00:00
Erik Johnston	72acca6a32	Back out change preventing setting null avatar URLs	2019-12-11 11:46:55 +00:00
Brendan Abolivier	54ae52ba96	Merge pull request #6349 from matrix-org/babolivier/msc1802 Implement v2 APIs for send_join and send_leave	2019-12-11 11:41:47 +00:00
Erik Johnston	d21577bdcb	Merge branch 'erikj/fix_sqlite_7' of github.com:matrix-org/synapse into release-v1.7.0	2019-12-11 11:34:50 +00:00
Richard van der Hoff	f8bc2ae883	Move get_state methods into FederationHandler (#6503 ) This is a non-functional refactor as a precursor to some other work.	2019-12-10 17:42:46 +00:00
Andrew Morgan	4947de5a14	Allow SAML username provider plugins (#6411 )	2019-12-10 17:30:16 +00:00
Erik Johnston	b2dcddc413	Merge pull request #6510 from matrix-org/erikj/phone_home_stats_db Phone home stats DB reporting should not assume a single DB.	2019-12-10 16:31:24 +00:00
Richard van der Hoff	40eda84933	Fix race which caused deleted devices to reappear (#6514 ) Stop the `update_client_ips` background job from recreating deleted devices.	2019-12-10 16:22:29 +00:00
Richard van der Hoff	c3dda2874d	Refactor get_events_from_store_or_dest to return a dict (#6501 ) There was a bunch of unnecessary conversion back and forth between dict and list going on here. We can simplify a bunch of the code.	2019-12-10 16:22:00 +00:00
Richard van der Hoff	424fd58237	Remove redundant code from event authorisation implementation. (#6502 )	2019-12-10 15:09:45 +00:00
Erik Johnston	257ef2c727	Port handlers.account_validity to async/await.	2019-12-10 14:40:15 +00:00
Erik Johnston	bc5cb8bfe8	Remove database config parsing from apps.	2019-12-10 14:34:17 +00:00
Erik Johnston	35f3c366ef	Merge pull request #6505 from matrix-org/erikj/make_deferred_yiedable Fix `make_deferred_yieldable` to work with coroutines	2019-12-10 14:20:26 +00:00
Erik Johnston	e726e18737	Merge pull request #6499 from matrix-org/erikj/fix_sqlite_7 Fix support for SQLite 3.7.	2019-12-10 13:43:52 +00:00
Erik Johnston	663238aeb4	Phone home stats DB reporting should not assume a single DB.	2019-12-10 13:21:04 +00:00
Erik Johnston	ffeafade48	Update comment	2019-12-10 13:17:39 +00:00
Brendan Abolivier	3bd049bbb7	Give the server config to the RoomWorkerStore	2019-12-10 13:05:35 +00:00
Erik Johnston	e3f528c544	Merge pull request #6506 from matrix-org/erikj/remove_snapshot_cache Remove SnapshotCache in favour of ResponseCache	2019-12-10 13:04:50 +00:00
Erik Johnston	52346990c8	Drop unused index	2019-12-10 12:46:14 +00:00

... 8 9 10 11 12 ...

12104 Commits