Dan Brown
f6a6b11ec5
Added and addressed multi-role/own-role-perm/inheretance scenario
...
Found during manual testing.
Have checked against relation queries manually too.
2023-01-26 12:53:25 +00:00
Dan Brown
48df8725d8
Added better drawing load failure handling
...
Failure of loading drawings will now close the drawing view and show an
error message, hinting at file or permission issues, instead of leaving
the user facing a continuosly loading interface.
Adds test to cover.
This also updates errors from our HTTP service to be wrapped in a custom
error type for better identification and so the error is an actual
javascript error. Should be object compatible.
Related to #3955 .
2023-01-26 12:18:33 +00:00
Dan Brown
25bdd71477
Add scheme and sql-variant code language options
...
For #3954 and #3942
2023-01-26 11:26:20 +00:00
Dan Brown
deda331745
Fixed global search preview click on safari
...
Safari needs an element to be focusable to be able to use :focus-within.
For #3926
2023-01-25 21:46:26 +00:00
Dan Brown
f6d3944b20
Merge pull request #3994 from BookStackApp/app_icon_setting
...
Added ability to control app icon (favicon) via settings
2023-01-25 16:50:48 +00:00
Dan Brown
a50b0ea1e5
Covered app icon setting with testing
2023-01-25 16:41:41 +00:00
Dan Brown
3c658e39ab
Extracted app icon text, fixed issues
...
Tweaked sizes and meta tags based unpon ipad testing.
Fixed reduced sizes not being cleaned up.
2023-01-25 16:11:34 +00:00
Dan Brown
d8354255e7
Added practicali to sponsor list
2023-01-25 12:06:11 +00:00
Dan Brown
55b6a7842e
Added ability to control app icon (favicon) via settings
2023-01-25 11:03:19 +00:00
Dan Brown
0f113ec41f
Merge pull request #3986 from BookStackApp/permission_testing
...
Permission Testing & Alignment
2023-01-24 21:37:28 +00:00
Dan Brown
1fa5a31960
Fixed role entity permissions ignoring inheritance
...
Added additional scnenario tests to cover
2023-01-24 21:26:41 +00:00
Dan Brown
8be36455ab
Addressed fallback override cases found during testing
...
Had misalignment between query and usercan, The nuance between fallback
and entity-role permissions was not taken into account by the query
system. Now added with new test cases to cover.
2023-01-24 20:42:20 +00:00
Dan Brown
d1bd6d0e39
Fixed incorrect field in down migration
2023-01-24 19:21:23 +00:00
Dan Brown
1660e72cc5
Migrated remaining relation permission usages
...
Now all tests are passing.
Some level of manual checks to do.
2023-01-24 19:04:32 +00:00
Dan Brown
2d1f1abce4
Implemented alternate approach to current joint_permissions
...
Is a tweak upon the existing approach, mainly to store and query role
permission access in a way that allows muli-level states that may
override eachother. These states are represented in the new PermissionStatus
class.
This also simplifies how own permissions are stored and queried, to be
part of a single column.
2023-01-24 14:55:34 +00:00
Dan Brown
7d74575eb8
Found a sql having-style approach to permissions
...
As a way to check aggregate queries for required changes to need to
analyse across combined permission values.
2023-01-24 13:44:38 +00:00
Dan Brown
91e613fe60
Shared entity permission logic across both query methods
...
The runtime userCan() and the JointPermissionBuilder now share much of
the same logic for handling entity permission resolution.
2023-01-23 15:09:03 +00:00
Dan Brown
f3f2a0c1d5
Updated userCan logic to meet expectations in tests
...
Updated with similar logic to that used in the user_permissions branch,
but all extracted to a seperate class for doing all fetch and collapse
work.
2023-01-23 12:40:11 +00:00
Dan Brown
1c2ae7bff6
Added gmp extension to test workflow
...
If was not already enabled by default, should enable faster testing
handling as it helps the phpseclib usage for OIDC tokens in test rocket
through.
2023-01-21 21:34:39 +00:00
Dan Brown
78ebcb6f38
Addressed a range of deprecation warnings
...
Closes #3969
2023-01-21 20:50:04 +00:00
Dan Brown
28dda39260
Updated PHP and JS depenencies
2023-01-21 19:09:19 +00:00
Dan Brown
e2a72d16aa
Made adjustments to fit copied work into dev branch
...
Ported non-compatible elements, Now all tests passing apart from some
specific permission scenario tests which are probably correctly failing.
Updates some tests to better avoid messing environment state.
2023-01-21 13:03:47 +00:00
Dan Brown
c724bfe4d3
Copied over work from user_permissions branch
...
Only that relevant to the additional testing work.
2023-01-21 11:08:34 +00:00
Dan Brown
6070d804f8
Fixed incorrect pluralisation for de_informal
...
Updated language system to only use initial part of locale for
translation pluralisation to better match the hard-coded logic of the
built-in MessageSelector. Extends and overrides Laravel's default for
this system.
Added test to cover.
Related to #3976 .
2023-01-16 16:56:41 +00:00
Dan Brown
5393465ea7
Updated translator attribution before release v22.11.1
2022-12-16 23:48:04 +00:00
Dan Brown
f5df811b15
Removed old unused style definition
2022-12-16 23:21:24 +00:00
Dan Brown
a521f41838
Fixed lack of scroll in editor toolbox contents
...
For #2887
2022-12-16 23:16:51 +00:00
Dan Brown
0123d83fb2
Fixed not being able to remove all user roles
...
User roles would only be actioned if they existed in the form request,
hence removal of all roles would have no data to action upon.
This adds a placeholder 0-id role to ensure there is always role data to
send, even when no roles are selected. This field value is latter
filtered out.
Added test to cover.
Likely related to #3922 .
2022-12-16 17:44:13 +00:00
Dan Brown
559e392f1b
Merge branch 'development' of https://github.com/jhit/BookStack into jhit-development
2022-12-16 17:12:57 +00:00
Dan Brown
8468b632a1
Updated crowdin config with PR title and labels
...
Aligns to the title and labelling I already do manually.
2022-12-16 17:11:01 +00:00
Dan Brown
7053a8669f
New Crowdin updates ( #3881 )
2022-12-16 17:06:52 +00:00
Dan Brown
2c0a7346b1
Prevent search focus change on left/right arrow press
...
For #3920
2022-12-16 17:03:48 +00:00
Dan Brown
69d702c783
Updated locale list to align with lang folders
2022-11-30 12:13:50 +00:00
Dan Brown
dd92cf9e96
Updated translator attribution before v22.11 release
2022-11-30 12:02:10 +00:00
Dan Brown
0cd0b44cdb
New Crowdin updates ( #3828 )
2022-11-30 12:01:19 +00:00
Jürgen Hörmann
d505642336
Add popular PHP templating languages to code editor
...
Smarty and Twig are two very popular PHP templating engines and might be
useful to some Bookstack users too.
2022-11-29 14:53:41 +01:00
Dan Brown
31c28be57a
Converted md settings to localstorage, added preview resize
2022-11-28 14:08:20 +00:00
Dan Brown
38db3a28ea
Merge pull request #3878 from BookStackApp/dark_style_cleanup
...
Cleaned up dark mode styles inc. setting browser color scheme
2022-11-28 12:42:16 +00:00
Dan Brown
09fa2d2c9c
Cleaned up dark mode styles inc. setting browser color scheme
...
Forces browser colorscheme based on BookStack color scheme, via
'color-scheme' css property.
Sets proper dark mode colors for some previously missed areas like
templates and attachment control buttons.
Also fixed search bar icon position for some search inputs.
2022-11-28 12:38:30 +00:00
Dan Brown
b786ed07be
Merge pull request #3875 from BookStackApp/md_editor_updates
...
Markdown Editor Updates
2022-11-28 12:21:33 +00:00
Dan Brown
0527c4a1ea
Added test to preference boolean endpoint
2022-11-28 12:17:22 +00:00
Dan Brown
ec3713bc74
Connected md editor settings to logic for functionality
2022-11-28 12:12:36 +00:00
Dan Brown
9fd5190c70
Added md editor ui dropdown options & their back-end storage
...
Still need to perform actual in-editor functionality for those controls.
2022-11-27 20:30:14 +00:00
Dan Brown
3995b01399
Tightened existing markdown editor styles
2022-11-27 19:52:10 +00:00
Dan Brown
3fdb88c7aa
Added callout cycling in markdown editor via shortcut
2022-11-26 23:18:51 +00:00
Dan Brown
8e4bb32b77
Fixed md editor refactoring issues after manual test
...
Testing was a full manual feature test of each piece of supported logic
defined in the code.
2022-11-26 21:33:39 +00:00
Dan Brown
63d6272282
Refactored markdown editor logic
...
Split out the markdown editor logic into seperate components to provide
a more orgranised heirachy with feature-specific files.
2022-11-26 16:43:28 +00:00
Dan Brown
40a1377c0b
Fixed tests to align with recent changes, Updated php deps
2022-11-23 12:08:55 +00:00
Dan Brown
e20c944350
Fixed OIDC handling when no JWKS 'use' prop exists
...
Now assume, based on OIDC discovery spec, that keys without 'use' are
'sig' keys. Should not affect existing use-cases since existance of such
keys would have throw exceptions in prev. versions of bookstack.
For #3869
2022-11-23 11:50:59 +00:00
Dan Brown
85b7b10c01
Merge branch 'development' of github.com:BookStackApp/BookStack into development
2022-11-23 00:13:02 +00:00
