Deletion of image file on book deletion.

This commit is contained in:
Nilesh Deepak 2017-07-06 10:03:40 +05:30
parent f51db4b9f6
commit 16a09e8ff6

View File

@ -8,6 +8,7 @@ use BookStack\Services\ExportService;
use Illuminate\Http\Request; use Illuminate\Http\Request;
use Illuminate\Http\Response; use Illuminate\Http\Response;
use Views; use Views;
use File;
class BookController extends Controller class BookController extends Controller
{ {
@ -135,11 +136,18 @@ class BookController extends Controller
*/ */
private function getBookCoverURL($image) private function getBookCoverURL($image)
{ {
$input = time().'-'.$image->getClientOriginalName(); if(is_null($image))
$destinationPath = public_path('uploads/book/'); {
$image->move($destinationPath, $input); return;
$path = baseUrl('/uploads/book/').'/'.$input; }
return $path; else
{
$input = time().'-'.$image->getClientOriginalName();
$destinationPath = public_path('uploads/book/');
$image->move($destinationPath, $input);
$path = baseUrl('/uploads/book/').'/'.$input;
return $path;
}
} }
/** /**
@ -250,6 +258,8 @@ class BookController extends Controller
$book = $this->entityRepo->getBySlug('book', $bookSlug); $book = $this->entityRepo->getBySlug('book', $bookSlug);
$this->checkOwnablePermission('book-delete', $book); $this->checkOwnablePermission('book-delete', $book);
Activity::addMessage('book_delete', 0, $book->name); Activity::addMessage('book_delete', 0, $book->name);
$file = basename($book->image);
File::delete('uploads/book/'.$file);
$this->entityRepo->destroyBook($book); $this->entityRepo->destroyBook($book);
return redirect('/books'); return redirect('/books');
} }