diff --git a/app/Http/Controllers/BookController.php b/app/Http/Controllers/BookController.php index aca993bba..b64841220 100644 --- a/app/Http/Controllers/BookController.php +++ b/app/Http/Controllers/BookController.php @@ -8,6 +8,7 @@ use BookStack\Services\ExportService; use Illuminate\Http\Request; use Illuminate\Http\Response; use Views; +use File; class BookController extends Controller { @@ -135,11 +136,18 @@ class BookController extends Controller */ private function getBookCoverURL($image) { - $input = time().'-'.$image->getClientOriginalName(); - $destinationPath = public_path('uploads/book/'); - $image->move($destinationPath, $input); - $path = baseUrl('/uploads/book/').'/'.$input; - return $path; + if(is_null($image)) + { + return; + } + else + { + $input = time().'-'.$image->getClientOriginalName(); + $destinationPath = public_path('uploads/book/'); + $image->move($destinationPath, $input); + $path = baseUrl('/uploads/book/').'/'.$input; + return $path; + } } /** @@ -250,6 +258,8 @@ class BookController extends Controller $book = $this->entityRepo->getBySlug('book', $bookSlug); $this->checkOwnablePermission('book-delete', $book); Activity::addMessage('book_delete', 0, $book->name); + $file = basename($book->image); + File::delete('uploads/book/'.$file); $this->entityRepo->destroyBook($book); return redirect('/books'); }