2021-06-26 11:23:15 -04:00
|
|
|
<?php
|
2016-10-23 10:25:04 -04:00
|
|
|
|
2021-06-26 11:23:15 -04:00
|
|
|
namespace Tests\Uploads;
|
|
|
|
|
|
|
|
use BookStack\Entities\Models\Page;
|
2020-11-06 07:54:39 -05:00
|
|
|
use BookStack\Entities\Repos\PageRepo;
|
2021-06-26 11:23:15 -04:00
|
|
|
use BookStack\Entities\Tools\TrashCan;
|
2018-09-25 07:30:50 -04:00
|
|
|
use BookStack\Uploads\Attachment;
|
2020-10-31 11:01:52 -04:00
|
|
|
use BookStack\Uploads\AttachmentService;
|
|
|
|
use Illuminate\Http\UploadedFile;
|
2020-04-03 20:16:05 -04:00
|
|
|
use Tests\TestCase;
|
2018-02-11 07:37:02 -05:00
|
|
|
|
|
|
|
class AttachmentTest extends TestCase
|
2016-10-23 10:25:04 -04:00
|
|
|
{
|
|
|
|
/**
|
2021-06-26 11:23:15 -04:00
|
|
|
* Get a test file that can be uploaded.
|
2016-10-23 10:25:04 -04:00
|
|
|
*/
|
2020-10-31 11:01:52 -04:00
|
|
|
protected function getTestFile(string $fileName): UploadedFile
|
2016-10-23 10:25:04 -04:00
|
|
|
{
|
2021-10-26 17:04:18 -04:00
|
|
|
return new UploadedFile(base_path('tests/test-data/test-file.txt'), $fileName, 'text/plain', null, true);
|
2016-10-23 10:25:04 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Uploads a file with the given name.
|
|
|
|
*/
|
2021-10-26 17:04:18 -04:00
|
|
|
protected function uploadFile(string $name, int $uploadedTo = 0): \Illuminate\Testing\TestResponse
|
2016-10-23 10:25:04 -04:00
|
|
|
{
|
|
|
|
$file = $this->getTestFile($name);
|
2021-06-26 11:23:15 -04:00
|
|
|
|
2016-11-12 09:12:26 -05:00
|
|
|
return $this->call('POST', '/attachments/upload', ['uploaded_to' => $uploadedTo], [], ['file' => $file], []);
|
2016-10-23 10:25:04 -04:00
|
|
|
}
|
|
|
|
|
2020-10-31 11:01:52 -04:00
|
|
|
/**
|
2021-06-26 11:23:15 -04:00
|
|
|
* Create a new attachment.
|
2020-10-31 11:01:52 -04:00
|
|
|
*/
|
|
|
|
protected function createAttachment(Page $page): Attachment
|
|
|
|
{
|
|
|
|
$this->post('attachments/link', [
|
2021-06-26 11:23:15 -04:00
|
|
|
'attachment_link_url' => 'https://example.com',
|
|
|
|
'attachment_link_name' => 'Example Attachment Link',
|
2020-10-31 11:01:52 -04:00
|
|
|
'attachment_link_uploaded_to' => $page->id,
|
|
|
|
]);
|
|
|
|
|
|
|
|
return Attachment::query()->latest()->first();
|
|
|
|
}
|
|
|
|
|
2021-10-31 13:58:56 -04:00
|
|
|
/**
|
|
|
|
* Create a new upload attachment from the given data.
|
|
|
|
*/
|
|
|
|
protected function createUploadAttachment(Page $page, string $filename, string $content, string $mimeType): Attachment
|
|
|
|
{
|
|
|
|
$file = tmpfile();
|
|
|
|
$filePath = stream_get_meta_data($file)['uri'];
|
|
|
|
file_put_contents($filePath, $content);
|
|
|
|
$upload = new UploadedFile($filePath, $filename, $mimeType, null, true);
|
|
|
|
|
|
|
|
$this->call('POST', '/attachments/upload', ['uploaded_to' => $page->id], [], ['file' => $upload], []);
|
2021-11-01 09:26:02 -04:00
|
|
|
|
2021-10-31 13:58:56 -04:00
|
|
|
return $page->attachments()->latest()->firstOrFail();
|
|
|
|
}
|
|
|
|
|
2016-10-23 10:25:04 -04:00
|
|
|
/**
|
|
|
|
* Delete all uploaded files.
|
|
|
|
* To assist with cleanup.
|
|
|
|
*/
|
|
|
|
protected function deleteUploads()
|
|
|
|
{
|
2020-10-31 11:01:52 -04:00
|
|
|
$fileService = $this->app->make(AttachmentService::class);
|
2020-07-04 12:04:26 -04:00
|
|
|
foreach (Attachment::all() as $file) {
|
2016-10-23 10:25:04 -04:00
|
|
|
$fileService->deleteFile($file);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
public function test_file_upload()
|
|
|
|
{
|
2022-09-29 12:31:38 -04:00
|
|
|
$page = $this->entities->page();
|
2016-10-23 10:25:04 -04:00
|
|
|
$this->asAdmin();
|
|
|
|
$admin = $this->getAdmin();
|
|
|
|
$fileName = 'upload_test_file.txt';
|
|
|
|
|
|
|
|
$expectedResp = [
|
2021-06-26 11:23:15 -04:00
|
|
|
'name' => $fileName,
|
2022-09-17 20:25:20 -04:00
|
|
|
'uploaded_to' => $page->id,
|
2021-06-26 11:23:15 -04:00
|
|
|
'extension' => 'txt',
|
|
|
|
'order' => 1,
|
2016-10-23 10:25:04 -04:00
|
|
|
'created_by' => $admin->id,
|
|
|
|
'updated_by' => $admin->id,
|
|
|
|
];
|
|
|
|
|
2018-02-11 07:37:02 -05:00
|
|
|
$upload = $this->uploadFile($fileName, $page->id);
|
|
|
|
$upload->assertStatus(200);
|
2019-03-24 15:07:18 -04:00
|
|
|
|
|
|
|
$attachment = Attachment::query()->orderBy('id', 'desc')->first();
|
2018-02-11 07:37:02 -05:00
|
|
|
$upload->assertJson($expectedResp);
|
2021-10-19 19:58:56 -04:00
|
|
|
|
|
|
|
$expectedResp['path'] = $attachment->path;
|
2018-02-11 07:37:02 -05:00
|
|
|
$this->assertDatabaseHas('attachments', $expectedResp);
|
2016-10-23 10:25:04 -04:00
|
|
|
|
|
|
|
$this->deleteUploads();
|
|
|
|
}
|
|
|
|
|
2019-03-24 15:07:18 -04:00
|
|
|
public function test_file_upload_does_not_use_filename()
|
|
|
|
{
|
2022-09-29 12:31:38 -04:00
|
|
|
$page = $this->entities->page();
|
2019-03-24 15:07:18 -04:00
|
|
|
$fileName = 'upload_test_file.txt';
|
|
|
|
|
|
|
|
$upload = $this->asAdmin()->uploadFile($fileName, $page->id);
|
|
|
|
$upload->assertStatus(200);
|
|
|
|
|
|
|
|
$attachment = Attachment::query()->orderBy('id', 'desc')->first();
|
2019-09-14 09:12:39 -04:00
|
|
|
$this->assertStringNotContainsString($fileName, $attachment->path);
|
2021-11-01 07:32:00 -04:00
|
|
|
$this->assertStringEndsWith('-txt', $attachment->path);
|
|
|
|
$this->deleteUploads();
|
2019-03-24 15:07:18 -04:00
|
|
|
}
|
|
|
|
|
2016-10-23 10:25:04 -04:00
|
|
|
public function test_file_display_and_access()
|
|
|
|
{
|
2022-09-29 12:31:38 -04:00
|
|
|
$page = $this->entities->page();
|
2016-10-23 10:25:04 -04:00
|
|
|
$this->asAdmin();
|
|
|
|
$fileName = 'upload_test_file.txt';
|
|
|
|
|
2018-02-11 07:37:02 -05:00
|
|
|
$upload = $this->uploadFile($fileName, $page->id);
|
|
|
|
$upload->assertStatus(200);
|
|
|
|
$attachment = Attachment::orderBy('id', 'desc')->take(1)->first();
|
|
|
|
|
|
|
|
$pageGet = $this->get($page->getUrl());
|
|
|
|
$pageGet->assertSeeText($fileName);
|
|
|
|
$pageGet->assertSee($attachment->getUrl());
|
|
|
|
|
|
|
|
$attachmentGet = $this->get($attachment->getUrl());
|
2022-04-03 11:22:31 -04:00
|
|
|
$content = $attachmentGet->streamedContent();
|
|
|
|
$this->assertStringContainsString('Hi, This is a test file for testing the upload process.', $content);
|
2016-10-23 10:25:04 -04:00
|
|
|
|
|
|
|
$this->deleteUploads();
|
|
|
|
}
|
|
|
|
|
|
|
|
public function test_attaching_link_to_page()
|
|
|
|
{
|
2022-09-29 12:31:38 -04:00
|
|
|
$page = $this->entities->page();
|
2016-10-23 10:25:04 -04:00
|
|
|
$admin = $this->getAdmin();
|
|
|
|
$this->asAdmin();
|
|
|
|
|
2018-02-11 07:37:02 -05:00
|
|
|
$linkReq = $this->call('POST', 'attachments/link', [
|
2021-06-26 11:23:15 -04:00
|
|
|
'attachment_link_url' => 'https://example.com',
|
|
|
|
'attachment_link_name' => 'Example Attachment Link',
|
2020-07-04 12:04:26 -04:00
|
|
|
'attachment_link_uploaded_to' => $page->id,
|
2016-10-23 10:25:04 -04:00
|
|
|
]);
|
|
|
|
|
2020-07-04 12:04:26 -04:00
|
|
|
$expectedData = [
|
2021-06-26 11:23:15 -04:00
|
|
|
'path' => 'https://example.com',
|
|
|
|
'name' => 'Example Attachment Link',
|
2016-10-23 10:25:04 -04:00
|
|
|
'uploaded_to' => $page->id,
|
2021-06-26 11:23:15 -04:00
|
|
|
'created_by' => $admin->id,
|
|
|
|
'updated_by' => $admin->id,
|
|
|
|
'external' => true,
|
|
|
|
'order' => 1,
|
|
|
|
'extension' => '',
|
2016-10-23 10:25:04 -04:00
|
|
|
];
|
|
|
|
|
2018-02-11 07:37:02 -05:00
|
|
|
$linkReq->assertStatus(200);
|
2020-07-04 12:04:26 -04:00
|
|
|
$this->assertDatabaseHas('attachments', $expectedData);
|
2018-02-11 07:37:02 -05:00
|
|
|
$attachment = Attachment::orderBy('id', 'desc')->take(1)->first();
|
2016-10-23 10:25:04 -04:00
|
|
|
|
2018-02-11 07:37:02 -05:00
|
|
|
$pageGet = $this->get($page->getUrl());
|
|
|
|
$pageGet->assertSeeText('Example Attachment Link');
|
|
|
|
$pageGet->assertSee($attachment->getUrl());
|
|
|
|
|
|
|
|
$attachmentGet = $this->get($attachment->getUrl());
|
|
|
|
$attachmentGet->assertRedirect('https://example.com');
|
2016-10-23 10:25:04 -04:00
|
|
|
|
|
|
|
$this->deleteUploads();
|
|
|
|
}
|
|
|
|
|
|
|
|
public function test_attachment_updating()
|
|
|
|
{
|
2022-09-29 12:31:38 -04:00
|
|
|
$page = $this->entities->page();
|
2016-10-23 10:25:04 -04:00
|
|
|
$this->asAdmin();
|
|
|
|
|
2020-10-31 11:01:52 -04:00
|
|
|
$attachment = $this->createAttachment($page);
|
|
|
|
$update = $this->call('PUT', 'attachments/' . $attachment->id, [
|
2020-07-04 12:04:26 -04:00
|
|
|
'attachment_edit_name' => 'My new attachment name',
|
2021-06-26 11:23:15 -04:00
|
|
|
'attachment_edit_url' => 'https://test.example.com',
|
2016-10-23 10:25:04 -04:00
|
|
|
]);
|
|
|
|
|
2020-07-04 12:04:26 -04:00
|
|
|
$expectedData = [
|
2021-06-26 11:23:15 -04:00
|
|
|
'id' => $attachment->id,
|
|
|
|
'path' => 'https://test.example.com',
|
|
|
|
'name' => 'My new attachment name',
|
|
|
|
'uploaded_to' => $page->id,
|
2016-10-23 10:25:04 -04:00
|
|
|
];
|
|
|
|
|
2018-02-11 07:37:02 -05:00
|
|
|
$update->assertStatus(200);
|
2020-07-04 12:04:26 -04:00
|
|
|
$this->assertDatabaseHas('attachments', $expectedData);
|
2016-10-23 10:25:04 -04:00
|
|
|
|
|
|
|
$this->deleteUploads();
|
|
|
|
}
|
|
|
|
|
|
|
|
public function test_file_deletion()
|
|
|
|
{
|
2022-09-29 12:31:38 -04:00
|
|
|
$page = $this->entities->page();
|
2016-10-23 10:25:04 -04:00
|
|
|
$this->asAdmin();
|
|
|
|
$fileName = 'deletion_test.txt';
|
|
|
|
$this->uploadFile($fileName, $page->id);
|
|
|
|
|
2019-03-24 15:07:18 -04:00
|
|
|
$attachment = Attachment::query()->orderBy('id', 'desc')->first();
|
|
|
|
$filePath = storage_path($attachment->path);
|
2016-10-23 10:25:04 -04:00
|
|
|
$this->assertTrue(file_exists($filePath), 'File at path ' . $filePath . ' does not exist');
|
|
|
|
|
2020-07-04 12:04:26 -04:00
|
|
|
$attachment = Attachment::first();
|
2018-02-11 07:37:02 -05:00
|
|
|
$this->delete($attachment->getUrl());
|
2016-10-23 10:25:04 -04:00
|
|
|
|
2018-02-11 07:37:02 -05:00
|
|
|
$this->assertDatabaseMissing('attachments', [
|
2021-06-26 11:23:15 -04:00
|
|
|
'name' => $fileName,
|
2016-10-23 10:25:04 -04:00
|
|
|
]);
|
|
|
|
$this->assertFalse(file_exists($filePath), 'File at path ' . $filePath . ' was not deleted as expected');
|
|
|
|
|
|
|
|
$this->deleteUploads();
|
|
|
|
}
|
|
|
|
|
|
|
|
public function test_attachment_deletion_on_page_deletion()
|
|
|
|
{
|
2022-09-29 12:31:38 -04:00
|
|
|
$page = $this->entities->page();
|
2016-10-23 10:25:04 -04:00
|
|
|
$this->asAdmin();
|
|
|
|
$fileName = 'deletion_test.txt';
|
|
|
|
$this->uploadFile($fileName, $page->id);
|
|
|
|
|
2019-03-24 15:07:18 -04:00
|
|
|
$attachment = Attachment::query()->orderBy('id', 'desc')->first();
|
|
|
|
$filePath = storage_path($attachment->path);
|
2016-10-23 10:25:04 -04:00
|
|
|
|
|
|
|
$this->assertTrue(file_exists($filePath), 'File at path ' . $filePath . ' does not exist');
|
2018-02-11 07:37:02 -05:00
|
|
|
$this->assertDatabaseHas('attachments', [
|
2021-06-26 11:23:15 -04:00
|
|
|
'name' => $fileName,
|
2016-10-23 10:25:04 -04:00
|
|
|
]);
|
|
|
|
|
2020-11-06 07:54:39 -05:00
|
|
|
app(PageRepo::class)->destroy($page);
|
|
|
|
app(TrashCan::class)->empty();
|
2016-10-23 10:25:04 -04:00
|
|
|
|
2018-02-11 07:37:02 -05:00
|
|
|
$this->assertDatabaseMissing('attachments', [
|
2021-06-26 11:23:15 -04:00
|
|
|
'name' => $fileName,
|
2016-10-23 10:25:04 -04:00
|
|
|
]);
|
|
|
|
$this->assertFalse(file_exists($filePath), 'File at path ' . $filePath . ' was not deleted as expected');
|
|
|
|
|
|
|
|
$this->deleteUploads();
|
|
|
|
}
|
2018-02-11 07:37:02 -05:00
|
|
|
|
|
|
|
public function test_attachment_access_without_permission_shows_404()
|
|
|
|
{
|
|
|
|
$admin = $this->getAdmin();
|
|
|
|
$viewer = $this->getViewer();
|
2022-09-29 12:31:38 -04:00
|
|
|
$page = $this->entities->page(); /** @var Page $page */
|
2018-02-11 07:37:02 -05:00
|
|
|
$this->actingAs($admin);
|
|
|
|
$fileName = 'permission_test.txt';
|
|
|
|
$this->uploadFile($fileName, $page->id);
|
|
|
|
$attachment = Attachment::orderBy('id', 'desc')->take(1)->first();
|
|
|
|
|
2022-10-10 11:58:26 -04:00
|
|
|
$this->entities->setPermissions($page, [], []);
|
2018-02-11 07:37:02 -05:00
|
|
|
|
|
|
|
$this->actingAs($viewer);
|
|
|
|
$attachmentGet = $this->get($attachment->getUrl());
|
|
|
|
$attachmentGet->assertStatus(404);
|
2021-06-26 11:23:15 -04:00
|
|
|
$attachmentGet->assertSee('Attachment not found');
|
2018-02-11 07:37:02 -05:00
|
|
|
|
|
|
|
$this->deleteUploads();
|
|
|
|
}
|
2020-10-31 11:01:52 -04:00
|
|
|
|
|
|
|
public function test_data_and_js_links_cannot_be_attached_to_a_page()
|
|
|
|
{
|
2022-09-29 12:31:38 -04:00
|
|
|
$page = $this->entities->page();
|
2020-10-31 11:01:52 -04:00
|
|
|
$this->asAdmin();
|
|
|
|
|
|
|
|
$badLinks = [
|
|
|
|
'javascript:alert("bunny")',
|
|
|
|
' javascript:alert("bunny")',
|
|
|
|
'JavaScript:alert("bunny")',
|
|
|
|
"\t\n\t\nJavaScript:alert(\"bunny\")",
|
2021-06-26 11:23:15 -04:00
|
|
|
'data:text/html;<a></a>',
|
|
|
|
'Data:text/html;<a></a>',
|
|
|
|
'Data:text/html;<a></a>',
|
2020-10-31 11:01:52 -04:00
|
|
|
];
|
|
|
|
|
|
|
|
foreach ($badLinks as $badLink) {
|
|
|
|
$linkReq = $this->post('attachments/link', [
|
2021-06-26 11:23:15 -04:00
|
|
|
'attachment_link_url' => $badLink,
|
|
|
|
'attachment_link_name' => 'Example Attachment Link',
|
2020-10-31 11:01:52 -04:00
|
|
|
'attachment_link_uploaded_to' => $page->id,
|
|
|
|
]);
|
|
|
|
$linkReq->assertStatus(422);
|
|
|
|
$this->assertDatabaseMissing('attachments', [
|
|
|
|
'path' => $badLink,
|
|
|
|
]);
|
|
|
|
}
|
|
|
|
|
|
|
|
$attachment = $this->createAttachment($page);
|
|
|
|
|
|
|
|
foreach ($badLinks as $badLink) {
|
|
|
|
$linkReq = $this->put('attachments/' . $attachment->id, [
|
2021-06-26 11:23:15 -04:00
|
|
|
'attachment_edit_url' => $badLink,
|
2020-10-31 11:01:52 -04:00
|
|
|
'attachment_edit_name' => 'Example Attachment Link',
|
|
|
|
]);
|
|
|
|
$linkReq->assertStatus(422);
|
|
|
|
$this->assertDatabaseMissing('attachments', [
|
|
|
|
'path' => $badLink,
|
|
|
|
]);
|
|
|
|
}
|
|
|
|
}
|
2021-06-06 08:55:56 -04:00
|
|
|
|
|
|
|
public function test_file_access_with_open_query_param_provides_inline_response_with_correct_content_type()
|
|
|
|
{
|
2022-09-29 12:31:38 -04:00
|
|
|
$page = $this->entities->page();
|
2021-06-06 08:55:56 -04:00
|
|
|
$this->asAdmin();
|
|
|
|
$fileName = 'upload_test_file.txt';
|
|
|
|
|
|
|
|
$upload = $this->uploadFile($fileName, $page->id);
|
|
|
|
$upload->assertStatus(200);
|
|
|
|
$attachment = Attachment::query()->orderBy('id', 'desc')->take(1)->first();
|
|
|
|
|
|
|
|
$attachmentGet = $this->get($attachment->getUrl(true));
|
|
|
|
// http-foundation/Response does some 'fixing' of responses to add charsets to text responses.
|
|
|
|
$attachmentGet->assertHeader('Content-Type', 'text/plain; charset=UTF-8');
|
2021-06-26 11:23:15 -04:00
|
|
|
$attachmentGet->assertHeader('Content-Disposition', 'inline; filename="upload_test_file.txt"');
|
2021-10-31 13:58:56 -04:00
|
|
|
$attachmentGet->assertHeader('X-Content-Type-Options', 'nosniff');
|
2021-06-06 08:55:56 -04:00
|
|
|
|
|
|
|
$this->deleteUploads();
|
|
|
|
}
|
2021-10-31 13:58:56 -04:00
|
|
|
|
|
|
|
public function test_html_file_access_with_open_forces_plain_content_type()
|
|
|
|
{
|
2022-09-29 12:31:38 -04:00
|
|
|
$page = $this->entities->page();
|
2021-10-31 13:58:56 -04:00
|
|
|
$this->asAdmin();
|
|
|
|
|
|
|
|
$attachment = $this->createUploadAttachment($page, 'test_file.html', '<html></html><p>testing</p>', 'text/html');
|
|
|
|
|
|
|
|
$attachmentGet = $this->get($attachment->getUrl(true));
|
|
|
|
// http-foundation/Response does some 'fixing' of responses to add charsets to text responses.
|
|
|
|
$attachmentGet->assertHeader('Content-Type', 'text/plain; charset=UTF-8');
|
|
|
|
$attachmentGet->assertHeader('Content-Disposition', 'inline; filename="test_file.html"');
|
|
|
|
|
|
|
|
$this->deleteUploads();
|
|
|
|
}
|
2022-09-02 09:40:17 -04:00
|
|
|
|
|
|
|
public function test_file_upload_works_when_local_secure_restricted_is_in_use()
|
|
|
|
{
|
|
|
|
config()->set('filesystems.attachments', 'local_secure_restricted');
|
|
|
|
|
2022-09-29 12:31:38 -04:00
|
|
|
$page = $this->entities->page();
|
2022-09-02 09:40:17 -04:00
|
|
|
$fileName = 'upload_test_file.txt';
|
|
|
|
|
|
|
|
$upload = $this->asAdmin()->uploadFile($fileName, $page->id);
|
|
|
|
$upload->assertStatus(200);
|
|
|
|
|
|
|
|
$attachment = Attachment::query()->orderBy('id', 'desc')->where('uploaded_to', '=', $page->id)->first();
|
|
|
|
$this->assertFileExists(storage_path($attachment->path));
|
|
|
|
$this->deleteUploads();
|
|
|
|
}
|
2016-10-23 10:25:04 -04:00
|
|
|
}
|