mirror of https://github.com/comit-network/xmr-btc-swap.git synced 2024-10-01 01:45:40 -04:00

Philipp Hoenisch 99db8c9108

Co-authored-by: Daniel Karzel <daniel.karzel@coblox.tech>

2021-04-28 16:04:25 +10:00

Changelog

All notable changes to this project will be documented in this file.

The format is based on Keep a Changelog, and this project adheres to Semantic Versioning.

Unreleased

The quote protocol returns JSON encoded data instead of CBOR. This is a breaking change in the protocol handling, old CLI versions will not be able to process quote requests of ASBs running this version.

An issue where concurrent swaps with the same peer would cause the ASB to handle network communication incorrectly. To fix this, all messages are now tagged with a unique identifier that is agreed upon at the start of the swap. This is a breaking change in the network layer and hence old versions are not compatible with this version. We advise to also not resume any swaps that have been created with an older version. It is recommended to reset / delete the database after upgrading.
An issue where the CLI would not reconnect to the ASB in case the network connection dropped. We now attempt to re-establish the connection using an exponential backoff but will give up eventually after 5 minutes.

Websocket support for the ASB. The ASB is now capable to listen on both TCP and Websocket connections. Default websocket listening port is 9940.
Tor support as an optional feature. If ASB detects that Tor's control port is open, a hidden service is created for the network it is listening on (currently 2). The Tor control port as well as Tor socks5 proxy port is configurable.

The resume command of the swap CLI no longer require the --seller-peer-id parameter. This information is now saved in the database.

A changelog file.
Automatic resume of unfinished swaps for the asb upon startup. Unfinished swaps from earlier versions will be skipped.
A configurable spread for the ASB that is applied to the asking price received from the Kraken price ticker. The default value is 2% and can be configured using the --ask-spread parameter. See ./asb --help for details.

Require the buyer to specify the connection details of the peer they wish to swap with. Throughout the public demo phase of this project, the CLI traded with us by default if the peer id and multiaddress of the seller were not specified. Having the defaults made it easy for us to give something to the community that can easily be tested, however it is not aligned with our long-term vision of a decentralised network of sellers. We have removed these defaults forcing the user to specify the seller they wish to trade with.

An issue where the swap CLI would fail on systems that were set to a locale different than English. A bad readiness check when waiting for monero-wallet-rpc to be ready caused the CLI to hang forever, preventing users from perform a swap.

Fixed an issue where Alice would not verify if Bob's Bitcoin lock transaction is semantically correct, i.e. pays the agreed upon amount to an output owned by both of them. Fixing this required a breaking change on the network layer and hence old versions are not compatible with this version.