Commit Graph

645 Commits

Author SHA1 Message Date
Haley Weslin
58524657fe setting not settings: struct.RoutingContext.html
"by settings ‘force_refresh’" needs to use the "setting" word.

After changing it, build_docs.sh fixes rustdoc for
veilid_core/struct.RoutingContext.html
2023-09-05 16:05:18 +00:00
TC Johnson
65826b219b
Version update: v0.2.0 → v0.2.1 2023-09-03 19:45:12 -05:00
John Smith
71f91998b2 more fork 2023-09-03 10:23:41 -04:00
John Smith
896df0bb97 more forking 2023-09-03 10:08:04 -04:00
John Smith
fd6e9e22c2 crate fixes 2023-09-03 09:53:00 -04:00
Christien Rioux
7d71b50170
Merge branch 'rustdocTypo2023-09-02' into 'main'
Remove stray by: veilid_core/struct.VeilidAPI.html

See merge request veilid/veilid!166
2023-09-03 00:18:16 +00:00
Christien Rioux
b3354194e0 repo fix 2023-09-02 18:50:12 -04:00
Christien Rioux
a77f80a8a9 repo fixes 2023-09-02 15:47:19 -04:00
Christien Rioux
20f55745b0 add descriptions 2023-09-02 12:28:31 -04:00
TC Johnson
2c46a159a3
Version update: v0.1.10 → v0.2.0 2023-09-02 09:45:56 -05:00
Christien Rioux
90772728c2 bumpversion fixes 2023-09-02 10:41:59 -04:00
Haley Weslin
3cfaff9cbb Remove stray by: veilid_core/struct.VeilidAPI.html
"specified by at startup time" has an extra "by" (wrong grammar)

After changing it, build_docs.sh fixes rustdoc here:
target/doc/veilid_core/struct.VeilidAPI.html
2023-09-02 05:22:51 +00:00
Christien Rioux
709ec4543b change visibility of dhcache 2023-09-01 21:18:45 -04:00
Christien Rioux
246056913e doc work 2023-09-01 21:13:05 -04:00
Christien Rioux
c377a59278 fix tests 2023-09-01 18:59:43 -04:00
Christien Rioux
ffcf16711b android fixes 2023-09-01 17:44:42 -04:00
Christien Rioux
d68a543800 fix ios 2023-08-29 17:50:25 -05:00
Christien Rioux
e302b764d0 docs and tests work 2023-08-29 15:15:47 -05:00
Christien Rioux
3125c19f02 doc work 2023-08-27 16:39:50 -05:00
Christien Rioux
8c366387eb Merge branch 'fix-set-record-data-size-call' into 'main'
call set_record_data_size with accumulated size

See merge request veilid/veilid!155
2023-08-27 16:07:38 +00:00
Christien Rioux
59dda0febe Merge branch 'api_startup_json_skip_all' into 'main'
api_startup_json: use 'skip_all'

See merge request veilid/veilid!154
2023-08-27 15:58:00 +00:00
Rivka Segan
5dd0a3793b call set_record_data_size with accumulated size
set_subkey corrupts record_data_size in a Record struct by calling
set_record_data_size with a value that depends only on the length of
the new subkey value. This leads to various undesirable outcomes, such
as: applications can write more than MAX_RECORD_DATA_SIZE without
encountering the intended "veilid.error.VeilidAPIErrorGeneric:
label='Generic' message='dht record too large'" error message, and
"panicked at 'attempt to subtract with overflow'" (i.e., an attempt to
set a negative value of a size) if a subkey's new length is less than
a subkey's old length. Typically, record_data_size in a Record struct
will be incorrect if a value was set for more than one subkey. Some
users might want to start over with a table_store that doesn't have
any incorrect record_data_size values.

The issue begins here:
6f71c6a00a/veilid-core/src/storage_manager/record_store.rs (L583-L586)

and is triggered here:
6f71c6a00a/veilid-core/src/storage_manager/record_store.rs (L613-L615)

It should be clear that new_record_data_size is only related to the
subkey that is currently being set. The amount of data in the record,
before set_subkey is called, is ignored. It appears that
new_total_size, not new_record_data_size, was intended to be used for
set_record_data_size, and this change succeeds for me in limited
testing but I don't have a comprehensive test suite.

One way to reproduce is by running the code from
https://gitlab.com/vatueil/veilid-file on a greater than 1 MB file
while watching variable values within
veilid-core/src/storage_manager/record_store.rs. For example: "poetry
run file put /usr/bin/tcpdump" (1.3 MB on Ubuntu 23.04). With the
original Veilid code, each of the dozens of subkey writes is checking
whether a roughly 32K value is greater than 1048576, it never is, and
thus there is never a "dht record too large" error. With the patch in
this MR, each of the dozens of subkey writes is checking whether an
ever-increasing value is greater than 1048576, it eventually is, and
the "dht record too large" error is printed. With the patch, one can
work with smaller files, e.g., do "poetry run file put /usr/bin/ssh"
(0.8 MB) followed by "poetry run file get VLD0:<_insert_key_here_>
ssh-copy" and the retrieved file ssh-copy is identical to
/usr/bin/ssh.

The more detailed behavior is that the modified code has
record.total_size of 350 on the first iteration, then 33596, 66842,
100088, etc. The original code also has record.total_size of 350 on
the first iteration, but then stays at 33246 forever (33246 is the
user-supplied subkey size of 32768, plus 128, plus the minimum record
size of 350),
2023-08-26 07:08:47 +00:00
Bruno Bigras
ff6f04be8c api_startup_json: use 'skip_all' 2023-08-26 02:01:57 +00:00
Christien Rioux
248b21a951 proper relay switch, fix wasm 2023-08-24 18:59:33 -04:00
John Smith
6bb35dd6a6 skip publishing relay for fullconenat 2023-08-24 18:35:37 -04:00
John Smith
945215aba1 speed up public address detection 2023-08-24 18:35:37 -04:00
John Smith
4eca53fd9b direct port forward detection 2023-08-24 18:35:37 -04:00
Christien Rioux
654b5dfebc simplify code 2023-08-24 18:35:37 -04:00
Christien Rioux
34c686c227 xfer 2023-08-24 18:35:37 -04:00
Christien Rioux
030a0073da fix public address check 2023-08-24 18:35:37 -04:00
Pedro Nunes
aa824c176f Merge branch veilid:main into fix-lockapi-dependency 2023-08-23 15:52:56 +00:00
solace-10
59f4899bca Added exact lock_api dependency. 2023-08-23 16:46:14 +01:00
Christien Rioux
1315766fa9 eliminate network keying from bootstrap name 2023-08-22 15:11:45 -04:00
Christien Rioux
e504da2564 xfer 2023-08-22 15:11:45 -04:00
Christien Rioux
0249b7c7ae dial info failure reprioritization 2023-08-22 15:11:45 -04:00
Christien Rioux
10ec693fb4 Merge branch 'fix/value-data-api-crash' into 'main'
fix: large value_data length in api crashes server

See merge request veilid/veilid!139
2023-08-22 19:00:50 +00:00
Cheradenine Zakalwe
0ce19d85fa fix: large value_data length in api crashes server 2023-08-22 19:00:49 +00:00
Christien Rioux
eb4f29900d Merge branch 'mr-test' into 'main'
Fix a couple of minor speedup issues

See merge request veilid/veilid!142
2023-08-22 18:58:30 +00:00
a1ecbr0wn
3f9f31a0a2
Fix a couple of minor speedup issues 2023-08-22 13:00:53 +01:00
pbarry25
0b018edfe5
Fix minor typos 2023-08-21 20:12:20 -05:00
TC Johnson
513116e672
Version update: v0.1.9 → v0.1.10 2023-08-20 11:37:18 -05:00
John Smith
f43462da8c add more changelog and clean up test output 2023-08-20 12:10:54 -04:00
John Smith
2d454c2654 fix comment 2023-08-20 11:52:54 -04:00
John Smith
c1cbcbe7c1 switch back to Sha512 for ed25519 compliance. add domain separation for signing and crypt 2023-08-20 11:47:29 -04:00
John Smith
d0fabbe3d9 Merge branch 'main' of gitlab.com:veilid/veilid into windows-fix 2023-08-20 11:25:39 -04:00
John Smith
1a3c87f9f1 fix nul termination 2023-08-20 11:23:17 -04:00
John Smith
964741463e vld0 work 2023-08-20 10:54:26 -04:00
John Smith
a7860d829e dh fix 2023-08-20 01:37:49 -04:00
John Smith
909a2f5362 windows fixess 2023-08-19 21:21:58 -04:00
Imuli
8f18569e30
use strict verification for ed25519
This enables all the signature malleability checks (including one that
is not RFC8032 compliant but are still likely important for Veilid.)

For details on the additional check, see
https://docs.rs/ed25519-dalek/2.0.0/ed25519_dalek/struct.VerifyingKey.html#method.verify_strict
2023-08-19 23:35:34 +00:00