Git-Mirrors/tornado-core
1
0
Fork 0
mirror of https://github.com/tornadocash/tornado-core.git synced 2024-10-01 01:06:17 -04:00
Code Issues Packages Projects Releases Wiki Activity
aa301c035c
tornado-core/README.md
Alexey aa301c035c readme fix
2019-07-24 17:09:37 +03:00

2.8 KiB
Raw Blame History

Tornado mixer Build Status

mixer image

Specs

  • Deposit gas cost: deposit 888054
  • Withdraw gas cost: 692133
  • Circuit constraints: 22617
  • Circuit proving time: 6116ms
  • Serverless

Security risks

  • Cryptographic tools used by mixer (zkSNARKS, Pedersen commitment, MiMC hash) are not yet extensively audited by cryptographic experts and may be vulnerable
    • Note: we use MiMC hash only for merkle tree, so even if a preimage attack on MiMC is discovered, it will not allow to deanonymize users or drain mixer funds
  • Relayer is frontrunnable. When relayer submits a transaction someone can see it in tx pool and frontrun it with higher gas price to get the fee and drain relayer funds.
    • Workaround: we can set high gas price so that (almost) all fee is used on gas. The relayer will not receive profit this way, but this approach is acceptable until we develop more sophisticated system that prevents frontrunning
  • Bugs in contract. Even though we have an extensive experience in smart contract security audits, we can still make mistakes. An external audit is needed to reduce probablility of bugs
  • Nullifier griefing. when you submit a withdraw transaction you reveal the nullifier for your note. If someone manages to make a deposit with the same nullifier and withdraw it while your transaction is still in tx pool, your note will be considered spent since it has the same nullifier and it will prevent you from withdrawing your funds
    • This attack doesnt't provide any profit for the attacker
    • This can be solved by storing block number for merkle root history, and only allowing to withdraw using merkle roots that are older than N ~10-20 blocks. It will slightly reduce anonymity set (by not counting users that deposited in last N blocks), but provide a safe period for mining your withdrawal transactions.

Requirements

  1. node v11.15.0
  2. npm install -g npx

Usage

  1. npm i
  2. cp .env.example .env
  3. npm run build:circuit - may take 10 minutes or more
  4. npm run build:contract
  5. npm run browserify
  6. npx ganache-cli
  7. npm run test - optionally run tests. It may fail for the first time, just run one more time.
  8. npm run migrate:dev
  9. ./cli.js deposit
  10. ./cli.js withdraw <note from previous step> <destination eth address>
  11. ./cli.js balance <destination eth address>
  12. vi .env - add your Kovan private key to deploy contracts
  13. npm run migrate
  14. npx http-server - serve current dir, you can use any other http server
  15. Open localhost:8080

Credits

Special thanks to @barryWhiteHat and @kobigurk for valuable input, and to @jbaylina for awesome Circom & Websnark framework