Git-Mirrors/qubes-doc
1
0
Fork 0
mirror of https://github.com/QubesOS/qubes-doc.git synced 2025-07-24 07:21:15 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix variable; emphasize "comment" and "tag"

Browse source 
QubeOS/qubes-issues#2876
This commit is contained in:
Andrew David Wong 2017-06-30 20:26:32 -05:00
parent 4b3b9a47ec
commit 3c79779ec5
No known key found for this signature in database
GPG key ID: 8CE137352A019A17
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
basics_dev/package-contributions.md
View file

@ -67,8 +67,8 @@ The review procedure is as follows:
1. Someone, S, wishes to make a change to a package, P.
2. S submits a fast-forwardable pull request against the fork of P's repo owned by [QubesOS-contrib].
3. The PM reviews the pull request.
If the the pull request passes the PM's review, the PM adds a [signed][sig] comment on the pull request stating that it has passed review.
(In cases in which P = PM, the PM can simply add a [signed][sig] tag to the HEAD commit prior to submitting the pull request.)
If the the pull request passes the PM's review, the PM adds a [signed][sig] *comment* on the pull request stating that it has passed review.
(In cases in which S = PM, the PM can simply add a [signed][sig] *tag* to the HEAD commit prior to submitting the pull request.)
If the pull request does not pass the PM's review, the PM leaves a comment on the pull request explaining why not.
4. The QCR reviews the pull request.
If the pull request passes the QCR's review, the QCR pushes a [signed][sig] tag to the HEAD commit stating that it has passed review and fast-forward merges the pull request.