From 3c79779ec5c1a92a5ddeda66e8fa3a9a1d8e6b14 Mon Sep 17 00:00:00 2001 From: Andrew David Wong Date: Fri, 30 Jun 2017 20:26:32 -0500 Subject: [PATCH] Fix variable; emphasize "comment" and "tag" QubeOS/qubes-issues#2876 --- basics_dev/package-contributions.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/basics_dev/package-contributions.md b/basics_dev/package-contributions.md index 8dbe5a49..56731da6 100644 --- a/basics_dev/package-contributions.md +++ b/basics_dev/package-contributions.md @@ -67,8 +67,8 @@ The review procedure is as follows: 1. Someone, S, wishes to make a change to a package, P. 2. S submits a fast-forwardable pull request against the fork of P's repo owned by [QubesOS-contrib]. 3. The PM reviews the pull request. - If the the pull request passes the PM's review, the PM adds a [signed][sig] comment on the pull request stating that it has passed review. - (In cases in which P = PM, the PM can simply add a [signed][sig] tag to the HEAD commit prior to submitting the pull request.) + If the the pull request passes the PM's review, the PM adds a [signed][sig] *comment* on the pull request stating that it has passed review. + (In cases in which S = PM, the PM can simply add a [signed][sig] *tag* to the HEAD commit prior to submitting the pull request.) If the pull request does not pass the PM's review, the PM leaves a comment on the pull request explaining why not. 4. The QCR reviews the pull request. If the pull request passes the QCR's review, the QCR pushes a [signed][sig] tag to the HEAD commit stating that it has passed review and fast-forward merges the pull request.