Git-Mirrors/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-12-26 17:59:23 -05:00
Code Issues Packages Projects Releases Wiki Activity
11,227 Commits 9 Branches 69 Tags 295 MiB
e6b86af931
Commit Graph

11227 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
j-berman
e6b86af931 wallet2: fix rescanning tx via scan_tx 
- Detach & re-process txs >= lowest scan height
- ensures that if a user calls scan_tx(tx1) after scanning tx2,
the wallet correctly processes tx1 and tx2
- if a user provides a tx with a height higher than the wallet's
last scanned height, the wallet will scan starting from that tx's
height
- scan_tx requires trusted daemon iff need to re-process existing
txs: in addition to querying a daemon for txids, if a user
provides a txid of a tx with height *lower* than any *already*
scanned txs in the wallet, then the wallet will also query the
daemon for all the *higher* txs as well. This is likely
unexpected behavior to a caller, and so to protect a caller from
revealing txid's to an untrusted daemon in an unexpected way,
require the daemon be trusted.
 2023-06-15 02:21:29 -07:00
luigi1111
94e67bf96b
Merge pull request #8842 
c32befe fix missing <cstdint> includes (tobtoht)
 2023-05-12 14:30:49 -05:00
tobtoht
c32befe4f8
fix missing <cstdint> includes 2023-05-06 18:13:18 +02:00
luigi1111
a2e8d1d427
Merge pull request #8760 
1698cb1 remove defunct light wallet code (tobtoht)
 2023-04-26 14:02:25 -04:00
luigi1111
28e43b17c2
Merge pull request #8735 
4080796 serialization: remove unused function dump_json (Jeffrey Ryan)
 2023-04-26 14:01:45 -04:00
tobtoht
1698cb1f84
remove defunct light wallet code 2023-04-25 21:22:10 +02:00
Jeffrey Ryan
408079661d serialization: remove unused function dump_json 2023-04-25 11:39:55 -05:00
luigi1111
1c9686cb45
Merge pull request #8724 
d2a591d wallet, simplewallet: Drop support for mine-to-use RPC system (Jeffrey Ryan)
 2023-04-25 12:36:11 -04:00
luigi1111
0d9e790311
Merge pull request #8802 
eb0e405 gamma picker: relax constructor requirements and test for selecting outputs from first spendable block (jeffro256)
 2023-04-25 11:26:20 -04:00
luigi1111
d44350fb7f
Merge pull request #8798 
f383fd3 wallet2: make m_process_pool_txs local to refresh method (jeffro256)
 2023-04-25 11:25:29 -04:00
luigi1111
a5cf8b5c4c
Merge pull request #8797 
833dd6b add libunbound to package list for OpenBSD (Nihal Jere)
 2023-04-25 11:25:00 -04:00
luigi1111
df2eb0da0a
Merge pull request #8796 
7a4a03d wallet2: do not commit transactions more than once (moneromooo-monero)
 2023-04-25 11:24:15 -04:00
luigi1111
63e9b47bbe
Merge pull request #8791 
3a34c63 depends: cleanup Makefile (tobtoht)
 2023-04-25 11:23:19 -04:00
luigi1111
b2d603e61f
Merge pull request #8789 
df9aa6b epee: remove dead code in net_helper (Jeffro256)
 2023-04-25 11:22:50 -04:00
luigi1111
0db1b4503e
Merge pull request #8788 
c61d33e wallet2: fix outdated wallet check (Crypto City)
 2023-04-25 11:22:11 -04:00
luigi1111
b442d5d4c1
Merge pull request #8780 
4e16559 rpc: give reason when sending non-hex raw tx (jeffro256)
 2023-04-25 11:21:48 -04:00
luigi1111
5387018ade
Merge pull request #8771 
2eaa523 cryptonote::transaction_prefix: fix IDE parsing error (koe)
 2023-04-25 11:21:22 -04:00
luigi1111
8172e4d8ad
Merge pull request #8765 
630906c cryptonote_basic: remove unused struct (tobtoht)
 2023-04-25 11:20:12 -04:00
luigi1111
83100b6cbe
Merge pull request #8764 
b13ddb9 Handle case where a command line flag is not allowed in the config file (almalh)
 2023-04-25 11:19:38 -04:00
luigi1111
37feb225a6
Merge pull request #8750 
5a7a5f1 build: BUILD_DEBUG_UTILITIES fix (Jeffro256)
 2023-04-25 11:18:40 -04:00
Jeffrey Ryan
d2a591d7c6 wallet, simplewallet: Drop support for mine-to-use RPC system 
Using post-PR wallet with pre-PR node will generate error message specific to this PR and not generic "command failed" mesages.
 2023-04-25 10:18:20 -05:00
luigi1111
8b617064d4
Merge pull request #8748 
11a8360 simplewallet: print fully qualified filename for new wallets (moneromooo-monero)
 2023-04-25 11:17:56 -04:00
luigi1111
4931462d1d
Merge pull request #8730 
9e09093 wallet_rpc_server: allow creating more than 64 addresses at once (moneromooo-monero)
 2023-04-25 11:17:22 -04:00
luigi1111
5e19f232d0
Merge pull request #8719 
1082720 README: fix void ssl package (tobtoht)
 2023-04-25 11:14:14 -04:00
luigi1111
aa5382c470
Merge pull request #8716 
9c7d28b wallet2: add on_reorg callback (Crypto City)
 2023-04-25 11:13:44 -04:00
luigi1111
9bf06ea75d
Merge pull request #8698 
5b4fea7 Copyright: Update to 2023 (mj-xmr)
 2023-04-25 11:12:56 -04:00
luigi1111
af88341272
Merge pull request #8694 
d89e7a2 util: make GMT timestamps explicit for clarity (moneromooo-monero)
 2023-04-25 11:11:08 -04:00
luigi1111
ecf0d01aa2
Merge pull request #8679 
b986421 adjust multiexp pippenger_cached_data for better reusability (koe)
 2023-04-25 11:10:27 -04:00
jeffro256
eb0e4052b7 gamma picker: relax constructor requirements and test for selecting outputs from first spendable block 2023-04-02 20:06:09 -05:00
luigi1111
44ac52f929
Merge pull request #8810 
d594981 Fixed deadlock and crash when syncing with full dataset on Windows (SChernykh)
 2023-04-02 20:45:13 -04:00
luigi1111
5f2bbf78a0
Merge pull request #8808 
caa7561 cryptonote core/protocol: don't drop peers for soft offenses (jeffro256)
 2023-04-02 20:44:18 -04:00
luigi1111
441373b9ef
Merge pull request #8794 
85a4558 wallet2: fix infinite loop in fake out selection (Crypto City)
 2023-04-02 20:43:32 -04:00
Crypto City
85a45587f2
wallet2: fix infinite loop in fake out selection 
The gamma picker and the caller code did not quite agree on the
number of rct outputs available for use - by one block - which
caused an infinite loop if the picker could never pick outputs
from that block but already had picked all other outputs from
previous blocks.

Also change the range to select from using code from UkoeHB.
 2023-03-30 14:44:36 +00:00
jeffro256
caa7561705 cryptonote core/protocol: don't drop peers for soft offenses 
Also: txs with tx_extra which is too large will not get published to ZMQ

Co-authored-by: SChernykh <sergey.v.chernykh@gmail.com>
 2023-03-29 02:05:43 -05:00
SChernykh
d59498101c Fixed deadlock and crash when syncing with full dataset on Windows 
It's not allowed to use WaitForSingleObject with _beginthread, because the thread closes its own handle before exiting.

So the wait function will either wait on an invalid handle, or on a different handle used by something else.

Or, if it starts waiting before the thread exits, the behavior is undefined according to MS: "If this handle is closed while the wait is still pending, the function's behavior is undefined."

In my test sync I observed threads getting stuck infinitely on WaitForSingleObject, and then rx_set_main_seedhash spamming new threads when RandomX seed changes again. Eventually the system ran out of resources, and monerod aborted with "Couldn't start RandomX seed thread" message.

This PR fixes it by using `_beginthreadex` instead and explicitly closing the handle when it's safe.
 2023-03-29 08:43:47 +02:00
luigi1111
abe74fda35
Merge pull request #8770 
d7a81cc p2p: do not log to global when re-blocking a subnet (moneromooo-monero)
d84a0d7 p2p: avoid spam blocking ipv4 addresses in a blocked subnet (moneromooo-monero)
 2023-03-24 22:54:32 -04:00
jeffro256
f383fd3cd0 wallet2: make m_process_pool_txs local to refresh method 2023-03-21 19:18:48 -05:00
moneromooo-monero
7a4a03d9d3
wallet2: do not commit transactions more than once 
Fixes #8793
 2023-03-21 21:05:53 +00:00
Nihal Jere
833dd6bb92 add libunbound to package list for OpenBSD 2023-03-21 14:20:49 -05:00
tobtoht
3a34c63ba9
depends: cleanup Makefile 2023-03-20 14:39:32 +01:00
Jeffro256
df9aa6bb04 epee: remove dead code in net_helper 2023-03-19 12:51:27 -05:00
Crypto City
c61d33e24c
wallet2: fix outdated wallet check 
it was mistaking the number of forks in the fork table for
the last fork, and assuming the table was including every
single fork
 2023-03-19 17:43:37 +00:00
luigi1111
f307621678
Merge pull request #8775 
1b27fcd device: Add ledger Stax device id to device detection (Francois Beutin)
 2023-03-18 18:21:02 -04:00
luigi1111
b7dbf4fd7c
Merge pull request #8745 
eaf5902 workflows: update dependencies to fix warnings (selsta)
 2023-03-18 18:19:25 -04:00
luigi1111
6bebc2d08c
Merge pull request #8743 
7a44eb7 depends: remove unused packages (tobtoht)
 2023-03-18 18:19:01 -04:00
luigi1111
76dd14dfb1
Merge pull request #8733 
3771641 Add a size limit for tx_extra in tx pool (tevador)
 2023-03-18 18:18:13 -04:00
luigi1111
55fddad446
Merge pull request #8707 
7159f92 verRctNonSemanticsSimpleCached: fix fragility (Jeffrey Ryan)
 2023-03-18 18:17:05 -04:00
luigi1111
a511202222
Merge pull request #8076 
c4af33e Enforce restricted # pool txs served via RPC + optimize chunked reqs (j-berman)
9752116 wallet2, RPC: Optimize RPC calls for periodic refresh from 3 down to 1 call (rbrunner7)
 2023-03-18 17:58:27 -04:00
Jeffrey Ryan
7159f92a57 verRctNonSemanticsSimpleCached: fix fragility 2023-03-17 18:45:35 -05:00
jeffro256
4e16559053 rpc: give reason when sending non-hex raw tx 2023-03-17 18:18:06 -05:00