Git-Mirrors/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-12-16 07:34:20 -05:00
Code Issues Packages Projects Releases Wiki Activity
7,441 Commits 9 Branches 69 Tags 295 MiB
53760ee044
Commit Graph

5228 Commits

Author SHA1 Message Date
Riccardo Spagni
617deb3329
Merge pull request #4689 
ba0faae7 crypto: fixed groestl on big-endian platforms (xiphon)
ed36335c crypto: fixed incremental keccak API on big-endian platforms (xiphon)
 2018-11-04 20:45:40 +02:00
Riccardo Spagni
adf4eb8d50
Merge pull request #4688 
5a2e54a1 Fix prune using receive time as tx_weight (doy-lee)
 2018-11-04 20:45:06 +02:00
Riccardo Spagni
0c7086bf7f
Merge pull request #4687 
6097472a Update ZMQ fee estimate and add ZMQ output distribution (Lee Clagett)
 2018-11-04 20:44:49 +02:00
Riccardo Spagni
d394c50f7b
Merge pull request #4686 
cf646e3a wallet2/create_transactions_2: removed extraneous shuffle before sort of unused_*_indices_per_subaddr (Paul Shapiro)
 2018-11-04 20:44:27 +02:00
Riccardo Spagni
9cf0e67978
Merge pull request #4685 
76681b9b wallet2/create_transactions_2: fixed typo in try_tx=true's estimate_fee args (Paul Shapiro)
 2018-11-04 20:44:00 +02:00
Riccardo Spagni
5251496662
Merge pull request #4684 
4a003bb5 mnemonics/electrum-words/create_checksum_index(): updated to work with non fixed word list length mnemonic (Paul Shapiro)
 2018-11-04 20:43:28 +02:00
Riccardo Spagni
5918ef93f8
Merge pull request #4683 
3a85af40 core: fix handle_incoming_tx* comment about return value (moneromooo-monero)
 2018-11-04 20:43:08 +02:00
Riccardo Spagni
69b646494b
Merge pull request #4241 
29ffb6bb device/trezor: trezor support added (Dusan Klinec)
 2018-11-04 20:42:46 +02:00
Riccardo Spagni
dc7de3312f
Merge pull request #4779 
233f00c6 cryptonote_core: fix build error gcc 5.4.0 'sign-compare' (xiphon)
 2018-11-04 20:41:19 +02:00
Hasan Pekdemir
e198b06e7a Fix: out_of_hashchain_bounds_error in refresh 
15:43 < hahsun> Im on stagenet and I suddenly get this exception: 2018-11-04 14:42:52.416 [RPC0] ERROR wallet.wallet2 src/wallet/wallet2.cpp:2070 !m_blockchain.is_in_bounds(current_index). THROW EXCEPTION: error::out_of_hashchain_bounds_error
16:01 <+moneromooo> OK, possibly because the blckchain is always seeded with the genesis block hash...
16:02 <+moneromooo> So that case should be allowed, assuming it doesn't break the code around it.
16:05 <+moneromooo> OK if stop_height == size || (size==1 && stop_heigt ==0)
16:05 <+moneromooo> Throw if not that.
16:06 < hahsun> k
 2018-11-04 17:07:30 +01:00
moneromooo-monero
5d7c231604
rct: add a zeroCommit cache for common pre-rct case 
This is called for every pre-rct output at blockchain sync time,
and a lot of them wil hit the cache, saving a scalarmult each.
 2018-11-04 15:44:56 +00:00
moneromooo-monero
5808530f54
blockchain: remove unused output_scan_worker parameter 2018-11-04 13:23:05 +00:00
moneromooo-monero
1426209a10
blockchain: don't run threads if we have just one function to run 2018-11-04 13:23:02 +00:00
moneromooo-monero
6f7a5fd4f7
db_lmdb: slight speedup getting array data from the blockchain 2018-11-04 13:23:00 +00:00
stoffu
5d4f3df887
simplewallet: reorganize SCOPED_WALLET_UNLOCK a bit more 
Followup on #4555
 2018-11-04 10:51:14 +09:00
stoffu
5878fe95ce
simplewallet: don't skip asking for password when watch-only 2018-11-04 10:50:03 +09:00
moneromooo-monero
177a9d76f9
wallet: warn if lockable memory limit is too low 2018-11-03 20:09:28 +00:00
moneromooo-monero
f26ce08c8a
wallet: add a non destructive blockchain rescan 2018-11-03 15:04:37 +00:00
moneromooo-monero
8f3963d200
wallet2: demote a few uninteresting recurring logs to TRACE 2018-11-03 11:51:03 +00:00
moneromooo-monero
0afdb00b9d
wallet2: fix print_ring printing double entries for transactions 
When a tx gets from unconfirmed to conirmed, the rings for that
transaction were being added twice
 2018-11-03 11:50:38 +00:00
cryptochangements34
e61062b6f2 use current height - 1 for top block height in err msgs 2018-11-02 19:31:31 -04:00
Dusan Klinec
29ffb6bba8
device/trezor: trezor support added 2018-11-02 21:36:39 +01:00
stoffu
c22e85fe1a
simplewallet: remove redundant messages on daemon connection failure 
try_connect_to_daemon with silent=false already prints failure message
 2018-11-02 23:25:27 +09:00
stoffu
1c04c21d6e
wallet_rpc_server: include additional tx keys in sign_transfer response 
Followup on #4552
 2018-11-02 21:42:02 +09:00
moneromooo-monero
97cad7e979
db_lmdb: log which output was not found in get_output_key 2018-11-02 11:49:39 +00:00
xiphon
233f00c601 cryptonote_core: fix build error gcc 5.4.0 'sign-compare' 2018-11-01 22:57:08 +00:00
moneromooo-monero
71eb32a976
dns_utils: do not exit if DNS records are corrupt 2018-11-01 22:53:48 +00:00
moneromooo-monero
c17a1d431b
daemon: use msg_writer, not cout, to display information 2018-11-01 22:53:10 +00:00
moneromooo-monero
03fc731bf2
p2p: less frequent incoming connections check 2018-11-01 22:00:35 +00:00
Riccardo Spagni
9a4b15c631
Merge pull request #4664 
61304151 db_lmdb: use MDB_MULTIPLE_NEXT where possible for some speedup (moneromooo-monero)
 2018-11-01 22:34:20 +02:00
Riccardo Spagni
7d05e6eab3
Merge pull request #4663 
d6937e37 ringct: use dummy bulletproofs when in fake mode, for speed (moneromooo-monero)
 2018-11-01 22:34:02 +02:00
Riccardo Spagni
a0cd602e56
Merge pull request #4658 
ca9b996d perf_timer: separate log categories based on caller categories (moneromooo-monero)
 2018-11-01 22:33:38 +02:00
Riccardo Spagni
3ceeac50da
Merge pull request #4653 
ade369f9 Add RPC error code for non-deterministic wallet (Michał Sałaban)
 2018-11-01 22:33:20 +02:00
Riccardo Spagni
fde24c80c2
Merge pull request #4648 
a7bffead daemon: fix base fee stating /kB even when it is per byte (moneromooo-monero)
 2018-11-01 22:33:02 +02:00
Riccardo Spagni
e7a475e4e6
Merge pull request #4645 
6f88c03d Simplewallet: update help text for show_transfers. (Ted Moravec)
 2018-11-01 22:32:41 +02:00
Riccardo Spagni
4f7cdd90fd
Merge pull request #4639 
ec301390 Update db_lmdb.cpp (Cactii1)
 2018-11-01 22:24:11 +02:00
moneromooo-monero
99fbe1008b
db_lmdb: save some string copies for readonly db keys/values 2018-11-01 17:26:09 +00:00
moneromooo-monero
14a5c2068f
p2p: tone down "no incoming connections" warning to info if in peers is 0 
Also add an info if not offline, since it weakens the network
 2018-11-01 16:43:06 +00:00
moneromooo-monero
bf31447e9b
tx_pool: speed up take_tx for transactions from blocks 
This happens for every historical tx when syncing, and the
unnecessary parsing is actually showing up on profile.
Since these are kept cached for just one block, this does
not increase memory usage after syncing.
 2018-11-01 15:51:28 +00:00
moneromooo-monero
4f005a77c2
tx_pool: remove unnecessary get_transaction_hash 2018-11-01 15:51:24 +00:00
moneromooo-monero
593ef5981d
perf_timer: call reserve on new timer array 
to avoid reallocations in the vast majority of the time
 2018-11-01 15:51:22 +00:00
moneromooo-monero
6ecc99ad1f
core: avoid unnecessary tx/blob conversions 2018-11-01 15:51:19 +00:00
RaskaRuby
2bd46065ae Expose limit-rate defaults from command line help 2018-10-31 14:47:20 -07:00
moneromooo-monero
cf552c752d
tx_pool: allow take_tx to work without m_txs_by_fee_and_receive_time 
This should make it possible to have two daemons running on the
same database again.
 2018-10-31 14:45:02 +00:00
moneromooo-monero
09dbd9cbbc
tx_pool: fix comment about transaction_prefix 
It was leftover from a change that was undone before commit,
but the comment change was let through
 2018-10-31 12:15:38 +00:00
stoffu
1598f01caf
wallet2: use padded bulletproofs for multisig signing 
Analogous to #4540
 2018-10-31 20:01:25 +09:00
xiphon
42d8d5085e crypto: fix AES encryption on big endian 2018-10-31 03:13:55 +00:00
moneromooo-monero
db24a2e509
hash: fix hash_permutation on big endian 2018-10-29 22:26:44 +00:00
Hasan Pekdemir
f3019efe1b wallet-rpc: add on_restore_deterministic RPC call. 2018-10-29 18:19:42 +01:00
moneromooo-monero
157054b840
hardfork: initialize current_fork_index in ctor 
Also order init list to match actual runtime init order

Coverity 136605
 2018-10-29 16:23:58 +00:00
moneromooo-monero
d9400f69eb
serializtion: add missing mainnet and stagenet fields for 0mq 
Coverity 184940
 2018-10-29 16:23:14 +00:00
moneromooo-monero
cbe0122bf1
wallet2: initialize amount to 0 in tx_scan_info_t ctor 
It seems the more prudent thing to do here. It will not catch
attempts to use that value before it is initialized when using
ASAN or valgrind, but in a case where it does, it will have
smaller repercussions.

So it seems appropriate in this particular case.

Coverity 182498
 2018-10-29 16:22:55 +00:00
Nathan Dorfman
e86af52e2f wallet2: rewrite keys file in a safer manner 2018-10-28 09:58:54 -06:00
cryptochangements34
dad5bbfdf9
return message in stop_mining if mining never started 2018-10-28 09:50:33 -04:00
moneromooo-monero
b3e8677c70
cryptonote: use logging functions for errors, not std::cout 2018-10-27 18:07:55 +00:00
moneromooo-monero
9335d5a297
wallet2: save ring in the ringdb once a tx is created 
Even if it is never relayed, it ensures a daemon supplying
fake outs on demand will never be asked for a set with the
real input being the only intersecting member (only a problem
with people who trust their privacy to some stranger's node,
but it seems to be a massively common thing, even in Monero)
 2018-10-27 17:59:56 +00:00
moneromooo-monero
0a95cdaa80
blockchain_utilities: fix logs and cout output colliding 2018-10-27 17:40:01 +00:00
moneromooo-monero
107f33985d
wallet2: fix ring reuse breaking when using histogram 2018-10-27 14:35:00 +00:00
moneromooo-monero
73e504c139
rpc: adjust ring size error message now that too high is also possible 2018-10-27 11:16:28 +00:00
moneromooo-monero
a5ca7f4fb5
core: fix unmixable special case allowing ring size below 11 2018-10-27 11:16:25 +00:00
Riccardo Spagni
00a7d441d6
Merge pull request #4719 
0aff4987 rpc: fix build with older compilers (moneromooo-monero)
 2018-10-26 22:41:43 +02:00
Riccardo Spagni
20d3605a54
Merge pull request #4700 
3bb4b0d4 miner: fix build with boost 1.69 (moneromooo-monero)
 2018-10-26 22:41:21 +02:00
Riccardo Spagni
33d9d2b4c1
Merge pull request #4672 
62f94e1b device_io_hid.cpp: fix copyright header (moneromooo-monero)
 2018-10-26 22:40:47 +02:00
Riccardo Spagni
fc06c5daf8
Merge pull request #4617 
3ffbec15 rpc: init m_rpc_version in Message ctor (moneromooo-monero)
bfa2dce1 rpc: remove unused ctors (moneromooo-monero)
7cc39845 account: init creation timestamp to 0 (moneromooo-monero)
32123789 wallet2: initialize some scalar fields in ctor where appropriate (moneromooo-monero)
4eca42b2 blockchain_db: initialize m_hardfork in ctor just in case (moneromooo-monero)
 2018-10-26 22:39:00 +02:00
Riccardo Spagni
148d14164e
Merge pull request #4615 
a7960542 WalletAPI: rescanBlockchain, rescanBlockchainAsync (mmitkevich)
 2018-10-26 22:38:41 +02:00
Riccardo Spagni
ecc690a613
Merge pull request #4612 
2d48861d p2p: only deinitialize what's been initialized in offline mode (moneromooo-monero)
 2018-10-26 22:38:03 +02:00
Riccardo Spagni
665ab1afbc
Merge pull request #4609 
e54e5668 daemon: Show mining address (Ricardo de Vries)
 2018-10-26 22:36:54 +02:00
Riccardo Spagni
481d7ed147
Merge pull request #4604 
0fbbb065 p2p: a negative result from UPNP_GetValidIGD is an error (moneromooo-monero)
 2018-10-26 22:35:50 +02:00
Riccardo Spagni
6fc7869eb5
Merge pull request #4586 
e51c9787 rpc: fix wrongly formatted JSON for pruned tx (stoffu)
 2018-10-26 22:35:03 +02:00
Riccardo Spagni
c761bee764
Merge pull request #4561 
04ddf02e Return appropriate RPC error code when key image signature check fails (Michał Sałaban)
 2018-10-26 22:33:35 +02:00
Riccardo Spagni
d6fb329653
Merge pull request #4555 
68e9744d simplewallet: perform trivial error checks before password prompt (xiphon)
 2018-10-26 22:33:09 +02:00
Riccardo Spagni
169e6e9074
Merge pull request #4552 
67e76aa0 wallet_rpc_server: optionally return tx keys in sign_transfer (moneromooo-monero)
 2018-10-26 22:32:34 +02:00
Riccardo Spagni
b8a4e5b7a6
Merge pull request #4547 
f2c2c47a simplewallet: fixed deadlock if a user hits CTRL+C twice (xiphon)
 2018-10-26 22:31:37 +02:00
Riccardo Spagni
d7ff24c1e0
Merge pull request #4545 
93a88d73 Utils: add support for newer Windows versions detection (Gregory Lemercier)
 2018-10-26 22:30:40 +02:00
Riccardo Spagni
659cf52a61
Merge pull request #4539 
977fc1bc wallet_rpc_server: add describe_transfer RPC (moneromooo-monero)
 2018-10-26 22:20:57 +02:00
Riccardo Spagni
056a58d13f
Merge pull request #4536 
fd62b6e7 blocks: use auto-generated .c files instead of 'LD -r -b binary' (xiphon)
 2018-10-26 22:20:39 +02:00
Riccardo Spagni
557c17e206
Merge pull request #4408 
341b3931 cryptonote_core: warn when the block rate deviates from expectations (moneromooo-monero)
 2018-10-26 22:18:41 +02:00
Riccardo Spagni
1c91963dcd
Merge pull request #4308 
9907ea06 cryptonote: sort tx_extra fields (moneromooo-monero)
 2018-10-26 22:18:28 +02:00
moneromooo-monero
1f35de2300
simplewallet: display locked/unlocked state in show_transfers 
it doesn't display the details, which are already displayed
in show_transfer
 2018-10-25 23:02:42 +00:00
moneromooo-monero
91eaea9c72
mnemonics: fix words_to_bytes on big endian 2018-10-25 20:23:17 +00:00
xiphon
ba0faae789 crypto: fixed groestl on big-endian platforms 2018-10-25 02:06:23 +00:00
moneromooo-monero
0aff49873c
rpc: fix build with older compilers 2018-10-24 20:36:58 +00:00
Pol Mauri
c4fbfd786a Small function declaration cleanup in slow-hash.c 
- These functions are declared twice in slow-hash.c. Remove one of the copies.
- The declarations have the wrong return type, should be void, not int.

Function definitions here: 1e74586ee9/src/crypto/aesb.c (L151-L180)
Test plan: make release-test
 2018-10-23 23:19:52 -07:00
Lee Clagett
6097472a19 Update ZMQ fee estimate and add ZMQ output distribution 2018-10-23 23:46:31 -04:00
moneromooo-monero
d6937e373b
ringct: use dummy bulletproofs when in fake mode, for speed 2018-10-23 21:03:18 +00:00
Howard Chu
a43daebf57
Add stats utility 
Report statistics from a blockchain DB
 2018-10-23 19:43:31 +01:00
moneromooo-monero
61f83316b3
wallet2: extend fake out picks away from the gamma pick 
in order to unbias selection from blocks with few txes
 2018-10-23 09:06:47 +00:00
Paul Shapiro
70877b1d91 wallet2/create_transactions_2: removed obsolete '/ 1024' on min_fee calc 2018-10-22 18:51:45 -05:00
doy-lee
5a2e54a1cb Fix prune using receive time as tx_weight 2018-10-23 10:03:45 +11:00
moneromooo-monero
3bb4b0d41f
miner: fix build with boost 1.69 2018-10-22 22:17:15 +00:00
moneromooo-monero
74fb3d882c
multiexp: some minor speedups 2018-10-22 16:08:26 +00:00
moneromooo-monero
a6d2e246f3
bulletproofs: only enable profiling on request 2018-10-22 16:07:44 +00:00
moneromooo-monero
a110e6aa18
multiexp: tune which variants to use for which number of points 2018-10-22 16:07:44 +00:00
moneromooo-monero
8b4767221c
bulletproofs: speedup prover 2018-10-22 16:07:44 +00:00
moneromooo-monero
6f9ae5b6eb
multiexp: handle pippenger multiexps with part precalc 2018-10-22 16:07:44 +00:00
moneromooo-monero
10e5a92769
bulletproofs: maintain -z4, -z5, and -y0 to avoid subtractions 2018-10-22 16:07:44 +00:00
moneromooo-monero
8629a42cf6
bulletproofs: rework flow to use sarang's fast batch inversion code 2018-10-22 16:07:44 +00:00
moneromooo-monero
fc9f7d9c81
bulletproofs: merge multiexps as per sarang's new python code 2018-10-22 16:07:44 +00:00
moneromooo-monero
4061960a16
multiexp: pack the digits table when STRAUS_C is 4 
Spotted by stoffu
 2018-10-22 16:07:44 +00:00
moneromooo-monero
bf8e4b9870
bulletproofs: some more minor speedup 2018-10-22 16:07:44 +00:00
moneromooo-monero
a281b950bf
bulletproofs: remove single value prover 
It is now expressed in terms of the array prover
 2018-10-22 16:07:44 +00:00
moneromooo-monero
484155d043
bulletproofs: some more speedup 2018-10-22 16:07:44 +00:00
moneromooo-monero
a621d6c8b4
bulletproofs: random minor speedups 2018-10-22 16:07:44 +00:00
moneromooo-monero
a49a17618f
bulletproofs: shave off a lot of scalar muls from the g/h construction 2018-10-22 16:07:44 +00:00
moneromooo-monero
4564a5d17b
bulletproofs: speedup PROVE 2018-10-22 16:07:44 +00:00
moneromooo-monero
cb4aafd27e
blockchain_utilities: simplify getting block blob from height 2018-10-22 16:04:28 +00:00
xiphon
ed36335c96 crypto: fixed incremental keccak API on big-endian platforms 2018-10-22 18:34:19 +03:00
moneromooo-monero
7f0dd094e7
wallet2: sanity check rct output distribution from the daemon 2018-10-22 14:01:46 +00:00
stoffu
e51c978770
rpc: fix wrongly formatted JSON for pruned tx 
Fix for #4399.
Also unifies code for serializing pruned tx to binary/json into one.
 2018-10-22 10:52:40 +09:00
xiphon
fd62b6e79f blocks: use auto-generated .c files instead of 'LD -r -b binary' 2018-10-22 01:12:00 +03:00
Paul Shapiro
4a003bb5a2 mnemonics/electrum-words/create_checksum_index(): updated to work with non fixed word list length mnemonic 2018-10-21 12:46:13 -05:00
Paul Shapiro
76681b9bda wallet2/create_transactions_2: fixed typo in try_tx=true's estimate_fee args 2018-10-21 12:44:22 -05:00
Paul Shapiro
cf646e3afe wallet2/create_transactions_2: removed extraneous shuffle before sort of unused_*_indices_per_subaddr 2018-10-21 12:43:31 -05:00
moneromooo-monero
3a85af403d
core: fix handle_incoming_tx* comment about return value 2018-10-21 17:09:21 +00:00
Riccardo Spagni
2287fb9fb4
Merge pull request #4524 
f5f7c2ac rpc: blanket initialize 0MQ request and response structures (moneromooo-monero)
 2018-10-20 20:40:56 +02:00
Riccardo Spagni
a145ae52b6
Merge pull request #4523 
6ca00b6d miner: really reset flags/precision on std::cout (moneromooo-monero)
 2018-10-20 20:40:36 +02:00
Riccardo Spagni
5c418c0522
Merge pull request #4522 
a39c0358 blockchain: add check test options are given for fakechain mode (moneromooo-monero)
 2018-10-20 20:40:16 +02:00
Riccardo Spagni
ed4b953bb7
Merge pull request #4518 
92a0827e wallet2: make fake out selection messages less spammy (moneromooo-monero)
 2018-10-20 20:39:36 +02:00
Riccardo Spagni
a38299801f
Merge pull request #4666 
cf75ee72 blockchain: move two new verification errors to the verify category (moneromooo-monero)
 2018-10-20 20:38:37 +02:00
Riccardo Spagni
9f34a3a29a
Merge pull request #4659 
b916ca63 rpc: fix output distribution caching ignoring chain changes (moneromooo-monero)
 2018-10-20 20:37:54 +02:00
Riccardo Spagni
4cd8850fce
Merge pull request #4642 
25d327e7 device: extended logging, refactored device selection code (xiphon)
825d836f device: fixed Ledger Nano S device selection (xiphon)
 2018-10-20 20:37:28 +02:00
Riccardo Spagni
bdd32bc2b2
Merge pull request #4650 
99cd6f96 Rename "blackball" for clarity (moneromooo-monero)
 2018-10-20 20:36:58 +02:00
Riccardo Spagni
93f2c13a39
Merge pull request #4637 
c39e0a17 core: don't verify range proofs multiple times (moneromooo-monero)
 2018-10-20 20:36:33 +02:00
Riccardo Spagni
313f16e83c
Merge pull request #4635 
776aefda tx_pool: revert #4592 and move bin2hex conversion to on_get_transaction_pool (stoffu)
 2018-10-20 20:35:22 +02:00
Riccardo Spagni
fe0e426be4
Merge pull request #4629 
c7743929 spawn: close all file descriptors before execve (moneromooo-monero)
 2018-10-20 20:34:15 +02:00
moneromooo-monero
62f94e1b9d
device_io_hid.cpp: fix copyright header 2018-10-20 10:31:27 +00:00
moneromooo-monero
cf75ee722a
blockchain: move two new verification errors to the verify category 
Lest we get people get scared again
 2018-10-19 21:11:12 +00:00
moneromooo-monero
61304151b4
db_lmdb: use MDB_MULTIPLE_NEXT where possible for some speedup 2018-10-19 16:47:29 +00:00
moneromooo-monero
b916ca63a8
rpc: fix output distribution caching ignoring chain changes 
0 is placeholder for whole chain, so we should compare chain
height changes rather than chain-height-or-zero. Even this isn't
totally foolproof if a blocks are popped and the same number
added again, but it is much better as it prevents the data from
slowly going out of sync.
 2018-10-19 09:22:35 +00:00
moneromooo-monero
ca9b996dcb
perf_timer: separate log categories based on caller categories 
Also default to microseconds, for homogeneity

Makes it easier to enable what we need
 2018-10-19 08:59:56 +00:00
moneromooo-monero
a7bffead9e
daemon: fix base fee stating /kB even when it is per byte 2018-10-19 08:39:33 +00:00
Michał Sałaban
ade369f96f Add RPC error code for non-deterministic wallet 2018-10-18 23:14:06 +02:00
moneromooo-monero
99cd6f961a
Rename "blackball" for clarity 
Apparently some people seem to think it's a censorship list...
 2018-10-18 18:45:45 +00:00
xiphon
25d327e796 device: extended logging, refactored device selection code 2018-10-18 17:53:06 +03:00
Ted Moravec
6f88c03dfc
Simplewallet: update help text for show_transfers. 
Describe the output format.
 2018-10-18 09:14:15 +00:00
Ricardo de Vries
e54e5668a8 daemon: Show mining address 2018-10-18 10:45:42 +02:00
xiphon
825d836f9f device: fixed Ledger Nano S device selection 2018-10-18 07:42:29 +03:00
stoffu
776aefdac1
tx_pool: revert #4592 and move bin2hex conversion to on_get_transaction_pool 2018-10-18 08:01:56 +09:00
Cactii1
ec3013903b
Update db_lmdb.cpp 2018-10-17 21:36:10 +02:00
moneromooo-monero
c39e0a1706
core: don't verify range proofs multiple times 2018-10-17 16:23:10 +00:00
moneromooo-monero
c774392985
spawn: close all file descriptors before execve 
No need to give whatever we're calling access to what we use
 2018-10-17 09:31:34 +00:00
moneromooo-monero
a69fc05a0c
util: close keys file lock on exec 2018-10-16 17:20:44 +00:00
Riccardo Spagni
5c85da5a73
Merge pull request #4610 
9b6dd934 Providing user supplied default constructor for expect<void> (Lee Clagett)
 2018-10-16 18:25:14 +02:00
Riccardo Spagni
d4e4fac209
Merge pull request #4602 
6f28667a daemon: fix reading past stack on exit (moneromooo-monero)
 2018-10-16 18:23:44 +02:00
Riccardo Spagni
c5be5ca6b4
Merge pull request #4623 
99d45a95 wallet_rpc_server: fix change_wallet_password RPC (moneromooo-monero)
 2018-10-16 18:23:30 +02:00
moneromooo-monero
99d45a9578
wallet_rpc_server: fix change_wallet_password RPC 2018-10-16 15:19:05 +00:00
Riccardo Spagni
e0a1d45d76
Merge pull request #4621 
0cdd4b07 wallet2_api: fix generating new wallet in the GUI (moneromooo-monero)
 2018-10-16 17:13:39 +02:00
moneromooo-monero
0cdd4b074e
wallet2_api: fix generating new wallet in the GUI 
It was creating a new wallet without a password first (this should
be fixed), then not changing the password correctly
 2018-10-16 14:46:17 +00:00
moneromooo-monero
3ffbec1556
rpc: init m_rpc_version in Message ctor 
Coverity 182501
 2018-10-16 11:58:54 +00:00
moneromooo-monero
bfa2dce171
rpc: remove unused ctors 
Also prevents coverity from moaning about them not initializing fields
 2018-10-16 11:58:52 +00:00
moneromooo-monero
7cc39845be
account: init creation timestamp to 0 
Never actually used uninitialized

Coverity 136615
 2018-10-16 11:58:50 +00:00
moneromooo-monero
3212378912
wallet2: initialize some scalar fields in ctor where appropriate 
Coverity 188336
 2018-10-16 11:58:48 +00:00
moneromooo-monero
4eca42b241
blockchain_db: initialize m_hardfork in ctor just in case 
Coverity 136568
 2018-10-16 11:58:46 +00:00
mmitkevich
a7960542a9 WalletAPI: rescanBlockchain, rescanBlockchainAsync 2018-10-16 14:58:22 +03:00
moneromooo-monero
2d48861db7
p2p: only deinitialize what's been initialized in offline mode 2018-10-16 09:20:05 +00:00
Lee Clagett
9b6dd9348c Providing user supplied default constructor for expect<void> 2018-10-15 23:42:29 -04:00
iDunk5400
e7f24850d5
Fix Windows build after epee dependency change 2018-10-15 23:08:17 +00:00
moneromooo-monero
0fbbb065d4
p2p: a negative result from UPNP_GetValidIGD is an error 
as per the source documentation
 2018-10-15 22:41:00 +00:00
moneromooo-monero
6f28667aa3
daemon: fix reading past stack on exit 2018-10-15 22:13:05 +00:00
Riccardo Spagni
1afc1d0d26
Merge pull request #4502 
9a856697 rpc: fixed typo in JSON command error response message (AnythingTechPro)
 2018-10-15 13:38:47 +02:00
Riccardo Spagni
5ccd3d32b4
Merge pull request #4489 
00901e9c epee: initialize a few data members where it seems to be appropriate (moneromooo-monero)
144a6c32 abstract_tcp_server2: move m_period to subclass (moneromooo-monero)
758d7684 connection_basic: remove unused floating time start time (moneromooo-monero)
e5108a29 Catch more exceptions in dtors (moneromooo-monero)
 2018-10-15 13:37:18 +02:00
Riccardo Spagni
c531df734f
Merge pull request #4389 
6844ae1b tx_pool: avoid parsing a whole tx if only the prefix is needed (moneromooo-monero)
 2018-10-15 13:36:15 +02:00
Riccardo Spagni
ad8e6ee8c7
Merge pull request #4592 
a677492f tx_pool: store hex string instead of raw binary to tx_blob of get_transaction_pool RPC (stoffu)
 2018-10-15 13:33:40 +02:00
Riccardo Spagni
544413de8f
Merge pull request #4577 
d886b97f SOFTWARE is the default wallet device (m2049r)
 2018-10-15 13:31:29 +02:00
Riccardo Spagni
f6cfca9a40
Merge pull request #4551 
c0822fdd simplewallet: mark default-ring-size setting as obsolete (moneromooo-monero)
 2018-10-15 13:30:01 +02:00
Riccardo Spagni
fa7278d6b5
Merge pull request #4578 
76d6d832 Revert "p2p: connect via the bound ip, if any" (moneromooo-monero)
 2018-10-15 13:29:21 +02:00
Riccardo Spagni
f916ef81f1
Merge pull request #4571 
c3b8328c daemon: do not run complex code in a signal handler (moneromooo-monero)
e736964a Remove epee header dependency on cryptonote_core (moneromooo-monero)
 2018-10-15 13:28:42 +02:00
Riccardo Spagni
175bfe4747
Merge pull request #4567 
14ed029b simplewallet: fix view key parsing in --generate-from-view-key (moneromooo-monero)
 2018-10-15 13:26:29 +02:00
Riccardo Spagni
40980b33b7
Merge pull request #4550 
0e33cf89 password: fix secure input with echo on windows (moneromooo-monero)
 2018-10-15 13:25:50 +02:00
Riccardo Spagni
ae5ca0bea1
Merge pull request #4549 
dc8f6924 password: fix backspace outputting ^? on linux on echoing secure input (moneromooo-monero)
 2018-10-15 13:24:55 +02:00
stoffu
a677492f1b
tx_pool: store hex string instead of raw binary to tx_blob of get_transaction_pool RPC 
Inspired by https://github.com/masari-project/masari/issues/93
 2018-10-15 11:57:02 +09:00
moneromooo-monero
76d6d832d2
Revert "p2p: connect via the bound ip, if any" 
This reverts commit 909398efc7.

It looks like it's causing trouble with tor on some setups
 2018-10-13 10:20:04 +00:00
m2049r
d886b97fe2
SOFTWARE is the default wallet device 2018-10-13 09:25:49 +02:00
moneromooo-monero
c3b8328cd3
daemon: do not run complex code in a signal handler 
instead, delegate the work to a one off thread
and notify it from the signal handler
 2018-10-12 17:44:04 +00:00
moneromooo-monero
e736964a0c
Remove epee header dependency on cryptonote_core 2018-10-12 17:16:44 +00:00
moneromooo-monero
14ed029b24
simplewallet: fix view key parsing in --generate-from-view-key 2018-10-12 12:54:42 +00:00
moneromooo-monero
f5f7c2ac24
rpc: blanket initialize 0MQ request and response structures 2018-10-12 09:57:41 +00:00
Michał Sałaban
04ddf02e3a Return appropriate RPC error code when key image signature check fails 2018-10-11 18:12:17 +02:00
xiphon
68e9744d44 simplewallet: perform trivial error checks before password prompt 2018-10-10 20:01:04 +00:00
xiphon
f2c2c47a4b simplewallet: fixed deadlock if a user hits CTRL+C twice 
Co-authored-by: moneromooo-monero <moneromooo-monero@users.noreply.github.com>
 2018-10-10 19:39:51 +00:00
moneromooo-monero
67e76aa06c
wallet_rpc_server: optionally return tx keys in sign_transfer 2018-10-10 15:55:35 +00:00
moneromooo-monero
c0822fdd30
simplewallet: mark default-ring-size setting as obsolete 2018-10-10 15:04:11 +00:00
moneromooo-monero
0e33cf89d2
password: fix secure input with echo on windows 
Thanks to iDunk for the testing back and forth
 2018-10-10 12:37:47 +00:00
moneromooo-monero
dc8f6924b2
password: fix backspace outputting ^? on linux on echoing secure input 2018-10-10 08:58:40 +00:00
moneromooo-monero
92a0827eea
wallet2: make fake out selection messages less spammy 2018-10-09 21:46:33 +00:00
Riccardo Spagni
bf60e98abc
fix version changes on master 2018-10-09 22:36:44 +02:00
Gregory Lemercier
93a88d7323 Utils: add support for newer Windows versions detection 2018-10-09 19:19:12 +02:00
Riccardo Spagni
c23b6f8f56
Merge pull request #4540 
8833aec0 wallet2: fix cold signing using non padded bulletproofs (moneromooo-monero)
 2018-10-09 16:43:01 +02:00
Riccardo Spagni
0c135c9420
Merge pull request #4535 
c716a331 device: increase ledger timeout to 2 minutes (selsta)
 2018-10-09 16:42:30 +02:00
Riccardo Spagni
18318e0dbc
Merge pull request #4538 
bd7b800f device_io_hid: fix DEFAULT_* type (too short) and init time (moneromooo-monero)
 2018-10-09 16:42:16 +02:00
moneromooo-monero
8833aec083
wallet2: fix cold signing using non padded bulletproofs 
This code was deciding which bulletproof configuration to use
based on ptx which weren't created yet.
 2018-10-09 14:32:38 +00:00
moneromooo-monero
977fc1bceb
wallet_rpc_server: add describe_transfer RPC 
for unsigned tx sets using a view only wallet
 2018-10-09 10:47:32 +00:00
moneromooo-monero
bd7b800f0a
device_io_hid: fix DEFAULT_* type (too short) and init time 2018-10-09 08:18:50 +00:00
selsta
c716a331f3
device: increase ledger timeout to 2 minutes 2018-10-09 02:17:40 +02:00
Riccardo Spagni
31155115d2
Merge pull request #4532 
8f22e808 device: destroy device objects on exit (moneromooo-monero)
 2018-10-08 22:30:50 +02:00
Riccardo Spagni
d6dbb6601b
Merge pull request #4530 
77471e23 blockchain_blackball: fix stray ! (moneromooo-monero)
 2018-10-08 22:05:29 +02:00
Riccardo Spagni
91c6725b88
Merge pull request #4527 
c5a97315 Remove last traces of libpcsc-lite (moneromooo-monero)
 2018-10-08 22:04:45 +02:00
Riccardo Spagni
ac5674524a
Revert "Merge pull request #4472" 
This reverts commit 79d46c4d55, reversing
changes made to c9fc61dbb5.
 2018-10-08 21:39:54 +02:00
moneromooo-monero
8f22e80865
device: destroy device objects on exit 2018-10-08 19:22:31 +00:00
moneromooo-monero
77471e23bd
blockchain_blackball: fix stray ! 2018-10-08 17:37:31 +00:00
moneromooo-monero
c5a97315ee
Remove last traces of libpcsc-lite 2018-10-08 14:22:10 +00:00
moneromooo-monero
6ca00b6d75
miner: really reset flags/precision on std::cout 2018-10-08 12:12:36 +00:00
moneromooo-monero
a39c035846
blockchain: add check test options are given for fakechain mode 
Coverity 188616
 2018-10-08 11:37:58 +00:00
Riccardo Spagni
3f2bfe87f7
Merge pull request #4514 
85e58cb2 blockchain_blackball: fix stats double counting (moneromooo-monero)
 2018-10-08 13:02:33 +02:00
moneromooo-monero
6844ae1b8d
tx_pool: avoid parsing a whole tx if only the prefix is needed 2018-10-08 10:18:01 +00:00
moneromooo-monero
85e58cb24a
blockchain_blackball: fix stats double counting 2018-10-08 08:55:56 +00:00
Riccardo Spagni
e19652df51
Merge pull request #4036 
9acf42d3 Multisig M/N functionality core tests added (naughtyfox)
9f3963e8 Arbitrary M/N multisig schemes: * support in wallet2 * support in monero-wallet-cli * support in monero-wallet-rpc * support in wallet api * support in monero-gen-trusted-multisig * unit tests for multisig wallets creation (naughtyfox)
 2018-10-07 19:57:26 +02:00
moneromooo-monero
9907ea0694
cryptonote: sort tx_extra fields 
This removes some small amount of fingerprinting entropy.
There is no consensus rule to require this since this field
is technically free form, and a transaction is free to have
custom data in it.
 2018-10-07 11:13:22 +00:00
Guillaume LE VAILLANT
977df6315f Fix some calls to the translation function 
Some strings were not detected by lupdate because "tr() cannot be called without
context".
 2018-10-06 10:26:06 +02:00
Riccardo Spagni
79d46c4d55
Merge pull request #4472 
02d3ef7b blocks: use auto-generated .c files instead of 'LD -r -b binary' (xiphon)
 2018-10-05 23:13:32 +02:00
Riccardo Spagni
c9fc61dbb5
Merge pull request #4495 
34a85e0c wallet2: disable height based segregation (moneromooo-monero)
 2018-10-05 23:13:15 +02:00
Riccardo Spagni
21960a5b5a
Merge pull request #4499 
c5928bde wallet2_api: fix build with C++14 (moneromooo-monero)
 2018-10-05 23:12:57 +02:00
Riccardo Spagni
445d9c86f2
Merge pull request #4390 
a0613532 secure_pwd_reader: Add proper Unicode handling [Ryo contribution] (fireice-uk)
579383c2 simplewallet: Add Unicode input_line [Ryo backport] (fireice-uk)
 2018-10-05 23:12:42 +02:00
Riccardo Spagni
6762897f70
Merge pull request #4487 
7c790f11 Fix rtxn usage in BlockchainLMDB::get_estimated_batch_size (Howard Chu)
 2018-10-05 23:12:11 +02:00
AnythingTechPro
9a85669724
rpc: fixed typo in JSON command error response message 2018-10-04 22:12:53 -04:00
fireice-uk
a061353254 secure_pwd_reader: Add proper Unicode handling [Ryo contribution] 2018-10-04 19:31:59 +01:00
moneromooo-monero
c5928bdec6
wallet2_api: fix build with C++14 2018-10-04 13:42:01 +00:00
xiphon
02d3ef7bda blocks: use auto-generated .c files instead of 'LD -r -b binary' 2018-10-04 00:01:09 +00:00
moneromooo-monero
34a85e0cc3
wallet2: disable height based segregation 
It can still be enable via DNS if a key reusing fork pops up
 2018-10-03 20:44:48 +00:00
Riccardo Spagni
215651cbb3
Merge pull request #4485 
5ec929fb daemon: do not display uptime when not known (moneromooo-monero)
 2018-10-02 22:43:00 +02:00
Riccardo Spagni
932a17018a
Merge pull request #4490 
bccd88dd wallet2: clear found out for every tx key (doy-lee)
 2018-10-02 22:41:24 +02:00
Riccardo Spagni
6cb9c815d4
Merge pull request #4484 
2c74b1a1 wallet_rpc_server: include all transfer records for a txid (moneromooo-monero)
 2018-10-02 22:40:51 +02:00
Riccardo Spagni
66094dee00
Merge pull request #4482 
25e5890d wallet: fix --generate-from-json using wrong password (moneromooo-monero)
 2018-10-02 22:39:57 +02:00
Riccardo Spagni
be6063ea59
Merge pull request #4479 
d5541e44 common: Windows 'spawn' support for tx and block notifications (xiphon)
 2018-10-02 22:39:34 +02:00
Riccardo Spagni
d1d64327b6
Merge pull request #4476 
fa9e54b6 build: fix gcc false positive 'stringop-overflow' warning (xiphon)
 2018-10-02 22:38:32 +02:00
Riccardo Spagni
64412acd31
Merge pull request #4475 
6da36ea0 wallet2_api: blackball/unblackball now take two parameters (moneromooo-monero)
 2018-10-02 22:38:09 +02:00
Riccardo Spagni
3a4fbdd9ec
Merge pull request #4470 
2fbf38ee Fix 32bit depends builds (TheCharlatan)
17142ec9 malloc scratchpad for all supported android archs (m2049r)
6a781408 Make depends use self built clang for darwin (TheCharlatan)
69da14e1 fixes make debug compilation on OSX (Dusan Klinec)
fe125647 Fixup RENAME_DB() macro (Howard Chu)
b2972927 osx compilation fix: missing boost libs added (Dusan Klinec)
174f31bf simplewallet: don't complain about payment id on pool mined blocks (moneromooo-monero)
89288863 README: mention ASAN usage alongside valgrind (moneromooo-monero)
83debef9 wallet_rpc_server: remove verbose field in incoming_transfers query (moneromooo-monero)
a69271fa Fixed a typo (Piotr Kąkol)
92d1da28 unit_tests: fix build with GCC 5.4.0 on ubuntu (moneromooo-monero)
a21da905 Wallet: use unique_ptr for WalletImpl members (oneiric)
7a056f44 WalletAPI: multisigSignData bug fixed (naughtyfox)
43a06350 ringdb: use cursors to be a bit faster (moneromooo-monero)
7964d4f8 wallet2: handle corner case in picking fake outputs (moneromooo-monero)
6f5360b3 bump version to 0.13.0.1 (Riccardo Spagni)
cf470bf3 switch from master to rc (Riccardo Spagni)
 2018-10-02 22:37:18 +02:00
Riccardo Spagni
e2da7c7817
Merge pull request #4467 
fa942ef6 daemon: silence daemon update warnings on testnet (iDunk5400)
 2018-10-02 22:36:57 +02:00
Riccardo Spagni
8d03350244
Merge pull request #4463 
8110bea3 dns_utils: refresh list of usable DNSSEC servers (moneromooo-monero)
 2018-10-02 22:36:18 +02:00
moneromooo-monero
e5108a294a
Catch more exceptions in dtors 
Misc coverity reports
 2018-10-02 17:28:44 +00:00
Howard Chu
7c790f11f2
Fix rtxn usage in BlockchainLMDB::get_estimated_batch_size 
Should only stop the rtxn if we actually started it
Fixes Coverity 184960
 2018-10-02 16:14:20 +01:00
doy-lee
bccd88ddf5
wallet2: clear found out for every tx key 
Avoids triggering the sanity check
 2018-10-02 08:53:28 +00:00
moneromooo-monero
5ec929fb3a
daemon: do not display uptime when not known 2018-10-02 08:40:38 +00:00
xiphon
d5541e44fe common: Windows 'spawn' support for tx and block notifications 2018-10-02 01:53:27 +03:00
naughtyfox
9f3963e823 Arbitrary M/N multisig schemes: 
* support in wallet2
* support in monero-wallet-cli
* support in monero-wallet-rpc
* support in wallet api
* support in monero-gen-trusted-multisig
* unit tests for multisig wallets creation
 2018-10-01 19:16:56 +03:00
moneromooo-monero
2c74b1a1c4
wallet_rpc_server: include all transfer records for a txid 
Since subaddresses were added, a tx can now create more than
one payment
 2018-10-01 14:47:26 +00:00
moneromooo-monero
25e5890d37
wallet: fix --generate-from-json using wrong password 2018-10-01 12:32:26 +00:00
xiphon
fa9e54b6ee build: fix gcc false positive 'stringop-overflow' warning 2018-09-30 10:58:00 +00:00
moneromooo-monero
6da36ea057
wallet2_api: blackball/unblackball now take two parameters 
amount and offset (instead of pubkey)
 2018-09-30 08:10:30 +00:00
Riccardo Spagni
83d8f03c23
Merge pull request #4333 
73403004 add --block-notify to monerod and --tx-notify to monero-wallet-{cli,rpc} (moneromooo-monero)
 2018-09-29 22:20:44 +02:00
Riccardo Spagni
4a2664f743
Merge pull request #4461 
7dd11711 wallet2: fix transfers between subaddresses hitting the sanity check (moneromooo-monero)
 2018-09-29 22:20:41 +02:00
Riccardo Spagni
effcbf2060
Merge pull request #4459 
bcf3f6af fuzz_tests: catch unhandled exceptions (moneromooo-monero)
3ebd05d4 miner: restore stream flags after changing them (moneromooo-monero)
a093092e levin_protocol_handler_async: do not propagate exception through dtor (moneromooo-monero)
1eebb82b net_helper: do not propagate exceptions through dtor (moneromooo-monero)
fb6a3630 miner: do not propagate exceptions through dtor (moneromooo-monero)
2e2139ff epee: do not propagate exception through dtor (moneromooo-monero)
0749a8bd db_lmdb: do not propagate exceptions in dtor (moneromooo-monero)
1b0afeeb wallet_rpc_server: exit cleanly on unhandled exceptions (moneromooo-monero)
418a9936 unit_tests: catch unhandled exceptions (moneromooo-monero)
ea7f9543 threadpool: do not propagate exceptions through the dtor (moneromooo-monero)
6e855422 gen_multisig: nice exit on unhandled exception (moneromooo-monero)
53df2deb db_lmdb: catch error in mdb_stat calls during migration (moneromooo-monero)
e67016dd blockchain_blackball: catch failure to commit db transaction (moneromooo-monero)
661439f4 mlog: don't remove old logs if we failed to rename the current file (moneromooo-monero)
5fdcda50 easylogging++: test for NULL before dereference (moneromooo-monero)
7ece1550 performance_test: fix bad last argument calling add_arg (moneromooo-monero)
a085da32 unit_tests: add check for page size > 0 before dividing (moneromooo-monero)
d8b1ec8b unit_tests: use std::shared_ptr to shut coverity up about leaks (moneromooo-monero)
02563bf4 simplewallet: top level exception catcher to print nicer messages (moneromooo-monero)
c57a65b2 blockchain_blackball: fix shift range for 32 bit archs (moneromooo-monero)
 2018-09-29 22:20:38 +02:00
Riccardo Spagni
9a54d0033e
Merge pull request #4458 
921b0fb1 use default create_address_file argument (m2049r)
 2018-09-29 22:20:35 +02:00
Riccardo Spagni
e951258543
Merge pull request #4456 
06d05c21 device: set device name correctly if key_on_device is set (Dusan Klinec)
 2018-09-29 22:20:27 +02:00
Riccardo Spagni
2ec0d780c4
Merge pull request #4449 
17142ec9 malloc scratchpad for all supported android archs (m2049r)
 2018-09-29 22:20:24 +02:00
Riccardo Spagni
09fb2bb5f8
Merge pull request #4445 
fe125647 Fixup RENAME_DB() macro (Howard Chu)
 2018-09-29 22:20:12 +02:00
Riccardo Spagni
b710d78026
Merge pull request #4439 
174f31bf simplewallet: don't complain about payment id on pool mined blocks (moneromooo-monero)
 2018-09-29 22:20:05 +02:00
Riccardo Spagni
54d883d826
Merge pull request #4427 
83debef9 wallet_rpc_server: remove verbose field in incoming_transfers query (moneromooo-monero)
 2018-09-29 22:19:58 +02:00
Riccardo Spagni
cd5638f894
Merge pull request #4417 
a21da905 Wallet: use unique_ptr for WalletImpl members (oneiric)
 2018-09-29 22:19:40 +02:00
Riccardo Spagni
e4130e6ae6
Merge pull request #4409 
7a056f44 WalletAPI: multisigSignData bug fixed (naughtyfox)
 2018-09-29 22:19:36 +02:00