Git-Mirrors/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2024-12-17 00:24:22 -05:00
Code Issues Packages Projects Releases Wiki Activity
9,856 Commits 9 Branches 69 Tags 295 MiB
4603ec9765
Commit Graph

6799 Commits

Author SHA1 Message Date
wowario
cd720c7e0b
add cumulative difficulty to diff command 2019-05-30 11:57:21 +03:00
Jesus Ramirez
270a3ae58b Unused private member m_miner_address 2019-05-29 10:12:47 -04:00
moneromooo-monero
f950517a08
core: update pruning if using --prune-blockchain on a pruned blockchain 
Avoids a massive amount of spurious warnings if the last update before
the daemon exited was a while ago and the daemon was syncing
 2019-05-28 09:12:11 +00:00
xiphon
577324a954 wallet_manager: omit redundant disconnect, drop unused variable 2019-05-27 14:40:29 +00:00
moneromooo-monero
35da33bea9
blockchain: do not try to pop blocks down to the genesis block 2019-05-26 17:11:32 +00:00
moneromooo-monero
4b51f9a34f
core: do not commit half constructed batch db txn 2019-05-25 16:24:56 +00:00
moneromooo-monero
162c3e18ec
blockchain_export: allow exporting blocks.dat format from pruned 
We don't need any of the pruned data for this
 2019-05-24 14:12:45 +00:00
moneromooo-monero
c07bbd5c04
daemon: fix "never seen before" time span display for peers 2019-05-24 10:47:36 +00:00
Lee Clagett
9bfa4c20ca Fix allow any cert mode in wallet rpc when configured over rpc 2019-05-22 00:15:14 -04:00
Lee Clagett
3544596f9f Add ssl_options support to monerod's rpc mode. 2019-05-22 00:09:11 -04:00
Lee Clagett
c9aaccf346 Fix configuration bug; wallet2 --daemon-ssl-allow-any-cert now works. 2019-05-21 15:43:27 -04:00
Howard Chu
b6830db2d4
Fix #5553 
Make sure the tip hash still matches the cached block
 2019-05-19 03:02:33 +01:00
moneromooo-monero
915f59e3c0
wallet: add unlock_time details to show_transfers 
also add a note when receiving the tx, because the user
might not notice the "XXX blocks to unlock" in the balance.
 2019-05-16 21:37:05 +00:00
Riccardo Spagni
e8487fa46b
Merge pull request #5539 
3f612cda Changed odd bullet point to low level header (Rohaq)
af9bc4ec Used subeaders to avoid slightly wonky looking formatting (Rohaq)
1873af35 Made code block usage consistent across all .md files (Rohaq)
68103075 Updated Copyright notice (Rohaq)
39bd157f Added Table of Contents to main README.md (Rohaq)
 2019-05-15 16:10:41 +02:00
Riccardo Spagni
5e80b3c3ef
Merge pull request #5535 
e1016bce password: do not use line input on windows (moneromooo-monero)
 2019-05-15 16:06:58 +02:00
luigi1111
1607419e38
Merge pull request #5538 
615f287 wallet: fix certificate fingerprint length check (moneromooo-monero)
 2019-05-14 16:02:59 -05:00
luigi1111
eedf5106f5
Merge pull request #5532 
46244dd wallet_rpc_server: use original addresses in destinations in get_transfers (moneromooo-monero)
 2019-05-14 15:59:34 -05:00
luigi1111
5a67ff2b32
Merge pull request #5526 
1e8f3f6 rpc: fail update RPC when running offline (moneromooo-monero)
 2019-05-14 15:54:10 -05:00
luigi1111
266f68be32
Merge pull request #5512 
d47292e error: fix compile error on windows with depends (moneromooo-monero)
 2019-05-14 15:51:14 -05:00
Rohaq
1873af35bf Made code block usage consistent across all .md files 2019-05-12 05:16:26 +01:00
moneromooo-monero
615f287aec
wallet: fix certificate fingerprint length check 
Fixed by crCr62U0
 2019-05-11 13:05:06 +00:00
moneromooo-monero
e1016bce14
password: do not use line input on windows 
This keeps its builtin command editing away

Thanks iDunk for testing on Windows
 2019-05-10 18:56:50 +00:00
dsc
4c666141e3 expose set/get walletcache attribute functionality in wallet api 2019-05-10 19:24:45 +02:00
moneromooo-monero
46244dd08c
wallet_rpc_server: use original addresses in destinations in get_transfers 
And add them for pending transfers, where they were missing
 2019-05-10 14:44:13 +00:00
moneromooo-monero
6abaaaa994
remove obsolete save_graph skeleton code 2019-05-10 14:17:18 +00:00
moneromooo-monero
1e8f3f66bf
rpc: fail update RPC when running offline 2019-05-09 19:14:49 +00:00
moneromooo-monero
4228ee0b9e
daemon: add optional arguments to alt_chain_info 
>N limits display to alt chains with more than N blocks
-N limits display to alt chains younger than N blocks
 2019-05-09 09:13:11 +00:00
moneromooo-monero
0605406714
daemon: sort alt chains by height 2019-05-09 09:12:49 +00:00
moneromooo-monero
06b8f29992
blockchain: keep alternative blocks in LMDB 
Alternative blocks are cleared on startup unless --keep-alt-blocks
is passed on the command line
 2019-05-08 17:36:52 +00:00
Riccardo Spagni
f64f59627d
Merge pull request #5510 
e9809382 fix wide difficulty conversion with some versions of boost (moneromooo-monero)
 2019-05-07 17:36:27 +02:00
Riccardo Spagni
97cb1c9436
Merge pull request #5508 
1c44e658 wallet2: reject standalone short payment IDs in monero: URI API (moneromooo-monero)
 2019-05-07 17:35:28 +02:00
Riccardo Spagni
a22a8b0f2b
Merge pull request #5505 
7e5158aa mnemonics: fix 4 byte UTF-8 rewriting (moneromooo-monero)
 2019-05-07 17:34:53 +02:00
Riccardo Spagni
c20221f290
Merge pull request #5503 
ccc1e311 wallet_rpc_server: reject standalone short payment id in address book (moneromooo-monero)
 2019-05-07 17:34:16 +02:00
Riccardo Spagni
ebb1c03e8c
Merge pull request #5501 
b4ca72dd wallet2: fix infinite loop picking outputs in corner case (moneromooo-monero)
 2019-05-07 17:32:33 +02:00
Riccardo Spagni
2d04b0e500
Merge pull request #5499 
a4c4a2d8 blockchain: keep a rolling long term block weight median (moneromooo-monero)
 2019-05-07 17:31:45 +02:00
Riccardo Spagni
9d91301faa
Merge pull request #5496 
0eb0d6b8 rpc: improve get_output_distribution (moneromooo-monero)
 2019-05-07 17:30:27 +02:00
Riccardo Spagni
cf8319602d
Merge pull request #5481 
28a7d315 p2p: do not send last_seen timestamp to peers (moneromooo-monero)
 2019-05-07 17:29:42 +02:00
moneromooo-monero
e4d100b062
wallet2: don't wait a day before using new version fees 
30 blocks should be more than enough to drain the txpool of
transactions made with the old fee scheme
 2019-05-02 18:00:25 +00:00
moneromooo-monero
bc94ba4d14
wallet: distinguish between empty and absent attributes 2019-05-02 13:00:08 +00:00
moneromooo-monero
d47292eb3d
error: fix compile error on windows with depends 
state_not_recoverable is not defined there
 2019-05-02 10:14:09 +00:00
moneromooo-monero
a4c4a2d8aa
blockchain: keep a rolling long term block weight median 2019-05-02 09:47:01 +00:00
Riccardo Spagni
77f9bfa4d5
Merge pull request #5493 
5e0da6fb change SSL certificate fingerprint whitelisting from SHA1 to SHA-256 (moneromooo-monero)
 2019-05-02 11:30:28 +02:00
Riccardo Spagni
52eb454d7b
Merge pull request #5491 
98fb98f9 wallet_rpc_server: adding missing return on error in set_daemon (moneromooo-monero)
9074c0d8 wallet_rpc_server: return false on error in set_log_categories (moneromooo-monero)
968848a7 wallet_rpc_server: fix crash in validate_address if no wallet is loaded (moneromooo-monero)
 2019-05-02 11:30:11 +02:00
Riccardo Spagni
efd2412e77
Merge pull request #5489 
64983fce wallet2: default to trying to keep 5 outputs of 2+ monero (moneromooo-monero)
 2019-05-02 11:29:25 +02:00
Riccardo Spagni
08ab0cbdda
Merge pull request #5476 
0aaf5e2a device/trezor: device sorting and filtering improved (Dusan Klinec)
 2019-05-02 11:28:51 +02:00
moneromooo-monero
e980938210
fix wide difficulty conversion with some versions of boost 2019-05-01 19:58:09 +00:00
moneromooo-monero
1c44e65863
wallet2: reject standalone short payment IDs in monero: URI API 2019-05-01 18:41:39 +00:00
moneromooo-monero
7e5158aa97
mnemonics: fix 4 byte UTF-8 rewriting 2019-04-30 21:10:54 +00:00
moneromooo-monero
ccc1e311dc
wallet_rpc_server: reject standalone short payment id in address book 2019-04-30 21:07:37 +00:00
moneromooo-monero
1a66a86f94
remove unused code 2019-04-29 20:52:40 +00:00
moneromooo-monero
25a7cfdb4a
add a few checks where it seems appropriate 2019-04-29 20:52:40 +00:00
moneromooo-monero
b4ca72dde9
wallet2: fix infinite loop picking outputs in corner case 
If we have fewer outputs available on the chain than what we
require, but the output we're spending already has a ring,
it would loop picking outputs randomly, but never find enough.
Also tune logs for better debugging this kind of thing.
 2019-04-29 10:02:20 +00:00
moneromooo-monero
5e0da6fb68
change SSL certificate fingerprint whitelisting from SHA1 to SHA-256 
SHA1 is too close to bruteforceable
 2019-04-26 11:37:15 +00:00
moneromooo-monero
98fb98f93f
wallet_rpc_server: adding missing return on error in set_daemon 2019-04-25 23:35:37 +00:00
moneromooo-monero
9074c0d8cf
wallet_rpc_server: return false on error in set_log_categories 
Reported by SmajeNz0
 2019-04-25 23:35:37 +00:00
moneromooo-monero
968848a77b
wallet_rpc_server: fix crash in validate_address if no wallet is loaded 
Reported by SmajeNz0
 2019-04-25 23:35:37 +00:00
moneromooo-monero
0eb0d6b802
rpc: improve get_output_distribution 
It can now handle small reorgs without having to rescan the
whole blockchain.

Also add a test for it.
 2019-04-25 16:49:29 +00:00
Dusan Klinec
0aaf5e2ac8
device/trezor: device sorting and filtering improved 
- Trezor type detection refactored, T1 disabled (was enabled before which was a bug)
- Sort connected devices by env TREZOR_PATH
  - Compatibility with Trezor ecosystem using TREZOR_PATH env var
  - Enables to pick particular Trezor to use in GUI as we don't have the multi-device selection yet
- Dump all detected devices to log for better debugging / troubleshooting
 2019-04-25 00:31:10 +02:00
Riccardo Spagni
581994b61c
Merge pull request #5486 
4be18df3 tx_sanity_check: relax uniqueness check a bit (moneromooo-monero)
b386ae57 wallet2: add missing "sanity check failed" reason message (moneromooo-monero)
 2019-04-24 22:41:40 +02:00
Riccardo Spagni
2e2ee3d823
Merge pull request #5485 
c519d1df wallet2: fix wrong change being recorded in sweep_all (moneromooo-monero)
 2019-04-24 22:41:18 +02:00
Riccardo Spagni
2aa7fbd1d6
Merge pull request #5480 
7af49ef0 daemonizer: add --non-interactive for windows (moneromooo-monero)
 2019-04-24 22:39:50 +02:00
Riccardo Spagni
edcb0cfff2
Merge pull request #5477 
97e1c927 wallet: fix key image computation signaling to the device (Dusan Klinec)
 2019-04-24 22:38:36 +02:00
Riccardo Spagni
fd7ed93526
Merge pull request #5470 
31a9aa83 wallet_rpc_server: add block_height and frozen to incoming_transfers (moneromooo-monero)
 2019-04-24 22:37:43 +02:00
moneromooo-monero
28a7d31565
p2p: do not send last_seen timestamp to peers 
This can be used for fingerprinting and working out the
network topology.

Instead of sending the first N (which are sorted by last
seen time), we sent a random subset of the first N+N/5,
which ensures reasonably recent peers are used, while
preventing repeated calls from deducing new entries are
peers the target node just connected to.

The list is also randomly shuffled so the original set of
timestamps cannot be approximated.
 2019-04-24 17:56:12 +00:00
moneromooo-monero
64983fcee4
wallet2: default to trying to keep 5 outputs of 2+ monero 
In the case where previously a second unneeded output would be
added to a transaction. This should help *some* of the cases
where outputs are slowly being consolidated, leading to the
whole balance being locked when sending monero.
 2019-04-24 12:25:43 +00:00
moneromooo-monero
df83ed74e4
consensus: from v12, enforce >= 2 outputs 2019-04-23 22:09:35 +00:00
moneromooo-monero
4be18df32a
tx_sanity_check: relax uniqueness check a bit 
It triggers easily on testnet
 2019-04-23 21:59:57 +00:00
moneromooo-monero
b386ae5725
wallet2: add missing "sanity check failed" reason message 2019-04-23 21:59:57 +00:00
moneromooo-monero
c519d1df34
wallet2: fix wrong change being recorded in sweep_all 
leading to the sanity check triggering
 2019-04-23 21:58:55 +00:00
moneromooo-monero
6aa3c2f303
dns_checks: new helper program to check on DNSSEC lookups 2019-04-23 15:20:45 +00:00
moneromooo-monero
7af49ef0c2
daemonizer: add --non-interactive for windows 
The RPC functional tests need it

Thanks to iDunk for debugging/testing
 2019-04-23 00:26:51 +00:00
Dusan Klinec
97e1c9278c
wallet: fix key image computation signaling to the device 2019-04-22 16:14:50 +02:00
moneromooo-monero
31a9aa83af
wallet_rpc_server: add block_height and frozen to incoming_transfers 2019-04-20 08:44:09 +00:00
moneromooo-monero
375fde9454
hardfork: fix off by one updating fork index after popping 2019-04-20 00:05:35 +00:00
Riccardo Spagni
71c6b24893
Merge pull request #5464 
0f52fe4c Windows: work around a boost 1.70 and cmake SNAFU (iDunk5400)
b414b69f Windows: fix a build error in MSYS2 with boost 1.70.0 (iDunk5400)
 2019-04-18 22:04:11 +02:00
Riccardo Spagni
2267f110b2
Merge pull request #5463 
fbbe75d7 device/trezor: button request callback fix (Dusan Klinec)
 2019-04-18 22:03:30 +02:00
Riccardo Spagni
950f79dc03
Merge pull request #5389 
588e6700 simplewallet: fix output representation offset (moneromooo-monero)
35e0a968 wallet2: "output lineup" fake out selection (moneromooo-monero)
 2019-04-18 22:01:51 +02:00
Riccardo Spagni
2e342d8df6
Merge pull request #5458 
84047cb7 wallet_rpc_server: add unlocked field to incoming_transfers output (moneromooo-monero)
 2019-04-18 22:01:22 +02:00
Riccardo Spagni
b8f1709684
Merge pull request #5456 
58eade68 simplewallet: add the change amount to the prompt when locking (moneromooo-monero)
 2019-04-18 22:01:03 +02:00
Riccardo Spagni
55807141f2
Merge pull request #5453 
71102267 wallet_rpc_server: set suggested_confirmations_threshold for pool txes (moneromooo-monero)
 2019-04-18 21:59:01 +02:00
Dusan Klinec
fbbe75d75f
device/trezor: button request callback fix 2019-04-18 18:04:54 +02:00
moneromooo-monero
588e670089
simplewallet: fix output representation offset 2019-04-18 15:14:41 +00:00
moneromooo-monero
35e0a968bd
wallet2: "output lineup" fake out selection 
Based on python code by sarang:
https://github.com/SarangNoether/skunkworks/blob/outputs/outputs/simulate.py
 2019-04-18 15:14:38 +00:00
iDunk5400
b414b69f5c
Windows: fix a build error in MSYS2 with boost 1.70.0 2019-04-18 17:00:13 +02:00
moneromooo-monero
a23dbe69f6
simplewallet: prompt when spending more than one old out in one tx 2019-04-18 12:46:03 +00:00
moneromooo-monero
84047cb729
wallet_rpc_server: add unlocked field to incoming_transfers output 2019-04-17 15:30:49 +00:00
moneromooo-monero
3b9ce453a9
wallet_rpc_server: remove unused variable 2019-04-17 11:25:33 +00:00
moneromooo-monero
58eade689c
simplewallet: add the change amount to the prompt when locking 2019-04-17 11:05:18 +00:00
Riccardo Spagni
e9464eb5e3
Merge pull request #5413 
5fafb90e testdb: add override keyword where missing (stoffu)
 2019-04-17 08:27:36 +02:00
stoffu
5fafb90e91
testdb: add override keyword where missing 
and delete obsolete BlockchainBDB::get_tx_output_indices along the way
 2019-04-17 10:26:25 +09:00
moneromooo-monero
b0a346689b
daemon: fix absolute/relative log file test for windows 2019-04-16 22:15:36 +00:00
moneromooo-monero
7110226794
wallet_rpc_server: set suggested_confirmations_threshold for pool txes 2019-04-16 20:59:57 +00:00
moneromooo-monero
294e858d57
wallet_rpc_server: add set_log_level/set_log_categories 2019-04-16 20:50:15 +00:00
Riccardo Spagni
1b092f3a44
Merge pull request #5452 
c30d93fc rpc: add a pruned bool to the prune_blockchain call (moneromooo-monero)
 2019-04-16 22:48:50 +02:00
Riccardo Spagni
810dd0a5f6
Merge pull request #5450 
926e0472 simplewallet: add another warning about long payment ids (moneromooo-monero)
 2019-04-16 22:48:18 +02:00
Riccardo Spagni
68d131615e
Merge pull request #5448 
d009f6dd rpc: fix get_block_hashes.bin from wallet on pruned blockchain (moneromooo-monero)
bb0ef5b1 blockchain: lock the blockchain while pruning (moneromooo-monero)
 2019-04-16 22:47:36 +02:00
Riccardo Spagni
c8ce4217cf
Merge pull request #5445 
b18f0b10 wallet: new --offline option (moneromooo-monero)
 2019-04-16 22:46:53 +02:00
Riccardo Spagni
f376cd5605
Merge pull request #5446 
7d79222f daemon: remove debug info (moneromooo-monero)
8fec0f98 functional_tests: add sweep_single test (moneromooo-monero)
9880d61b wallet_rpc_server: remove unused code (moneromooo-monero)
8a61b33d rpc: omit irrelevant fields for pool txes in gettransactions (moneromooo-monero)
56508524 rpc: add relayed in get_transaction output (moneromooo-monero)
82e510f1 rpc: set default log category in core_rpc_server.h (moneromooo-monero)
 2019-04-16 22:46:29 +02:00
Riccardo Spagni
e98cbfbdfe
Merge pull request #5444 
6643b047 Increment m_threads_active when mining thread starts (Doyle)
 2019-04-16 22:45:42 +02:00
Riccardo Spagni
c5f64bf170
Merge pull request #5443 
07dd5536 hardfork: remove "no hf version db" recreation check (moneromooo-monero)
 2019-04-16 22:45:23 +02:00
Riccardo Spagni
8af1a89e4c
Merge pull request #5441 
b3648232 daemon: fix ratio not being floating point (moneromooo-monero)
e1b097b9 core_rpc_server: remove dummy assigning int to bool (moneromooo-monero)
 2019-04-16 22:44:41 +02:00
Riccardo Spagni
1fc20ba48a
Merge pull request #5439 
f26e0b5d cryptonote_protocol: warn when the last connection goes (moneromooo-monero)
 2019-04-16 22:44:19 +02:00
Riccardo Spagni
ac8e2a7819
Merge pull request #5437 
acb68dba bulletproofs: cut down on keyV allocations (moneromooo-monero)
 2019-04-16 22:44:00 +02:00
Riccardo Spagni
b0472c43a1
Merge pull request #5435 
5140c15e daemon: if a log file has a /, interpret it from the cwd (moneromooo-monero)
 2019-04-16 22:42:26 +02:00
Riccardo Spagni
1f01070a0c
Merge pull request #5434 
ccb996af rpc: new sanity check on relayed transactions (moneromooo-monero)
 2019-04-16 22:41:40 +02:00
Riccardo Spagni
8deee24cbb
Merge pull request #5431 
34f8c237 simplewallet: fix warning about long payment id using the old option (moneromooo-monero)
 2019-04-16 22:40:34 +02:00
Riccardo Spagni
35b3d754e8
Merge pull request #5429 
bcb86ae6 wallet_rpc_server: fix inconsistent wallet caches on reload (moneromooo-monero)
 2019-04-16 22:39:37 +02:00
Riccardo Spagni
45e1f7c292
Merge pull request #5428 
f3425f8d rpc.getblocktemplate: set reserved_offset to zero when reserve_size==0 (stoffu)
 2019-04-16 22:39:18 +02:00
Riccardo Spagni
8d16e92dcb
Merge pull request #5425 
58585986 p2p: fix integer overflow in host bans (moneromooo-monero)
 2019-04-16 22:38:56 +02:00
Riccardo Spagni
a1ea611e24
Merge pull request #5424 
93bb2f48 ringct: prevent use of full ringct signatures for more than one input (moneromooo-monero)
 2019-04-16 22:38:32 +02:00
Riccardo Spagni
8966ac314c
Merge pull request #5422 
2c221d1b wallet2: update estimate_rct_tx_size for smaller rct proofs (moneromooo-monero)
 2019-04-16 22:38:11 +02:00
Riccardo Spagni
96696d1e75
Merge pull request #5418 
374f388d wallet_rpc_server: add a all flag to export_outputs (moneromooo-monero)
 2019-04-16 22:37:52 +02:00
Riccardo Spagni
0d2aaac15b
Merge pull request #5414 
e9fac29a unit_tests/long_term_block_weight: some tweaks that seem to make more sense (stoffu)
467f4c7e tests/block_weight: use integer division when computing median (stoffu)
815d08dc tests/block_weight: remove unused MULTIPLIER_SMALL (stoffu)
661f1fb8 blockchain: remove unused calc of short_term_constraint (stoffu)
 2019-04-16 22:37:02 +02:00
Riccardo Spagni
313a56a2da
Merge pull request #5406 
bea1918a blockchain_import: error out if preparing to handle blocks fails (moneromooo-monero)
 2019-04-16 22:32:27 +02:00
Riccardo Spagni
ce2f46f76b
Merge pull request #5405 
ffdbcfb6 core: don't check block rate nor fork time in regtest mode (moneromooo-monero)
 2019-04-16 22:32:06 +02:00
Riccardo Spagni
46c477ab30
Merge pull request #5400 
5e673c03 blockchain_db: fix db txn ending too early (moneromooo-monero)
 2019-04-16 22:30:40 +02:00
moneromooo-monero
c30d93fcd9
rpc: add a pruned bool to the prune_blockchain call 2019-04-16 15:15:14 +00:00
moneromooo-monero
926e047288
simplewallet: add another warning about long payment ids 2019-04-16 10:11:02 +00:00
moneromooo-monero
7d79222f5c
daemon: remove debug info 2019-04-15 22:32:09 +00:00
moneromooo-monero
d009f6dd61
rpc: fix get_block_hashes.bin from wallet on pruned blockchain 
We want to get all blocks here, even pruned ones
 2019-04-15 22:27:15 +00:00
moneromooo-monero
bb0ef5b1f2
blockchain: lock the blockchain while pruning 2019-04-15 22:27:12 +00:00
moneromooo-monero
b18f0b1051
wallet: new --offline option 
It will avoid connecting to a daemon (so useful for cold signing
using a RPC wallet), and not perform DNS queries.
 2019-04-15 09:14:12 +00:00
moneromooo-monero
9880d61b98
wallet_rpc_server: remove unused code 2019-04-15 09:13:12 +00:00
moneromooo-monero
8a61b33d8e
rpc: omit irrelevant fields for pool txes in gettransactions 2019-04-15 09:11:54 +00:00
moneromooo-monero
565085245a
rpc: add relayed in get_transaction output 2019-04-15 09:11:50 +00:00
moneromooo-monero
82e510f15e
rpc: set default log category in core_rpc_server.h 2019-04-15 09:10:29 +00:00
Riccardo Spagni
e89aa2ec56
Merge pull request #5421 
e78cea74 rpc: fix off by one in get_height (moneromooo-monero)
 2019-04-15 09:22:50 +02:00
Riccardo Spagni
64a4aa4f60
Merge pull request #5408 
c4f8a8a6 build fix: combinator.h stdexcept missing include (Dusan Klinec)
 2019-04-15 09:21:00 +02:00
Riccardo Spagni
9bd0983d5e
Merge pull request #5402 
cbf32241 rpc: make wide_difficulty hexadecimal (moneromooo-monero)
 2019-04-15 09:18:10 +02:00
Riccardo Spagni
e31559d319
Merge pull request #5398 
41901b8d device/trezor: env-configurable ports (Dusan Klinec)
c97a1f79 tests: trezor tests fixes and improvements (Dusan Klinec)
 2019-04-15 09:17:47 +02:00
Riccardo Spagni
8bf0a3f123
Merge pull request #5396 
b40392fb wallet2: add --no-dns flag (moneromooo-monero)
 2019-04-15 09:17:26 +02:00
Riccardo Spagni
98f4c8af98
Merge pull request #5395 
15f27c80 wallet2: support multi out txes without change in sanity check (moneromooo-monero)
 2019-04-15 09:17:07 +02:00
Riccardo Spagni
89b8ecfc7c
Merge pull request #5392 
a2195b9b crypto: replace rand<T>()%N idiom with unbiased rand_idx(N) (stoffu)
 2019-04-15 09:14:28 +02:00
Riccardo Spagni
3f46c5b4e1
Merge pull request #5365 
383c38fd fix init warning on whatever compiler version (italocoin)
 2019-04-15 09:12:50 +02:00
Riccardo Spagni
37aea526a9
Merge pull request #5355 
c68fe787 device/trezor: add button pressed request (Dusan Klinec)
827f52ad wallet: API changes to enable passphrase entry (Dusan Klinec)
 2019-04-15 09:12:20 +02:00
Doyle
6643b04737 Increment m_threads_active when mining thread starts 2019-04-15 13:08:33 +10:00
moneromooo-monero
07dd55363c
hardfork: remove "no hf version db" recreation check 
This is now obsolete, and this removes the warning on startup
on a new db that confuses some people
 2019-04-14 10:34:29 +00:00
moneromooo-monero
f26e0b5d11
cryptonote_protocol: warn when the last connection goes 2019-04-14 10:30:01 +00:00
moneromooo-monero
b364823286
daemon: fix ratio not being floating point 
Coverity 197648
 2019-04-14 09:26:12 +00:00
moneromooo-monero
e1b097b99b
core_rpc_server: remove dummy assigning int to bool 
Coverity 197653
 2019-04-14 09:26:12 +00:00
moneromooo-monero
5e673c03fe
blockchain_db: fix db txn ending too early 
The db txn in add_block ending caused the entire overarching
batch txn to stop.
Also add a new guard class so a db txn can be stopped in the
face of exceptions.

Also use a read only db txn in init when the db itself is
read only, and do not save the max tx size in that case.
 2019-04-14 08:35:38 +00:00
moneromooo-monero
acb68dbaa9
bulletproofs: cut down on keyV allocations 2019-04-13 22:37:08 +00:00
moneromooo-monero
5140c15e56
daemon: if a log file has a /, interpret it from the cwd 
rather than from data dir where it normally is.

It makes things like --log-file ./foo.log behave as you'd expect.
 2019-04-13 11:21:08 +00:00
moneromooo-monero
ccb996afc6
rpc: new sanity check on relayed transactions 
This will weed out some transactions with silly rings
 2019-04-12 20:22:09 +00:00
moneromooo-monero
34f8c237c2
simplewallet: fix warning about long payment id using the old option 2019-04-12 14:09:26 +00:00
moneromooo-monero
bcb86ae651
wallet_rpc_server: fix inconsistent wallet caches on reload 
Loading the same wallet as the currently loaded one would autosave
the current state after loading it, leading to some kind of rollback
effect. We now save before loading to avoid this. If loading fails,
it means the current wallet will be saved (or maybe not, depending
on where the failure occurs: most of the sanity checks occur before
saving). There is a new autosave_current flag to open/restore calls
so the (enabled by default) autosave can be skipped.
 2019-04-12 13:40:42 +00:00
stoffu
f3425f8d32
rpc.getblocktemplate: set reserved_offset to zero when reserve_size==0 2019-04-12 18:55:38 +09:00
moneromooo-monero
5858598604
p2p: fix integer overflow in host bans 2019-04-11 21:59:27 +00:00
moneromooo-monero
93bb2f48f7
ringct: prevent use of full ringct signatures for more than one input 2019-04-11 19:44:06 +00:00
moneromooo-monero
8f1fe45fe1
simplewallet: fix merge error with new welcome command 2019-04-11 18:46:23 +00:00
moneromooo-monero
2c221d1b6c
wallet2: update estimate_rct_tx_size for smaller rct proofs 2019-04-11 17:31:18 +00:00
moneromooo-monero
e78cea74bd
rpc: fix off by one in get_height 2019-04-11 17:24:02 +00:00
Riccardo Spagni
9c77dbf376
Merge pull request #5386 
d843f200 simplewallet: add a welcome/disclaimer message command (moneromooo-monero)
 2019-04-11 13:16:28 +02:00
Riccardo Spagni
083271375a
Merge pull request #5383 
0575794f console: simple shell over console.py (moneromooo-monero)
047af5c3 console.py: can now connect to several daemons/wallets (moneromooo-monero)
9f9571aa cmake: always detect python, it's neeed for some tests (moneromooo-monero)
8646bd00 functional_tests: exit with 1 if any test fails (moneromooo-monero)
6fd8834d console.py: add tab completion (moneromooo-monero)
04a20cb2 functional_tests: cold signing key images/outputs import/export (moneromooo-monero)
798e3cad functional_tests: add double spend detection tests (moneromooo-monero)
7c657bb2 functional_tests: add alt chains tests (moneromooo-monero)
f8be31d2 functional_tests: add wallet creation language tests (moneromooo-monero)
2d68b31f functional_tests: add more wallet tests (moneromooo-monero)
23f86dad python-rpc: add set_log_level and set_log_categories (moneromooo-monero)
b3a32d55 functional_tests: add describe_transfer tests (moneromooo-monero)
108f4375 console.py: support connecting to any host, not just 127.0.0.1 (moneromooo-monero)
064ab123 functional_tests: add more blockchain related tests (moneromooo-monero)
21b1ac1d functional_tests: add bans tests (moneromooo-monero)
 2019-04-11 13:14:44 +02:00
moneromooo-monero
d843f20044
simplewallet: add a welcome/disclaimer message command 
I saw one when landing on www.tribler.org, and it seemed
like a good idea to have something similar, alongside some
more general "what is monero" text.
 2019-04-11 11:11:45 +00:00
moneromooo-monero
064ab12340
functional_tests: add more blockchain related tests 
Related to emission, reorgs, getting tx data back, output
distribution and histogram
 2019-04-11 11:07:58 +00:00
Riccardo Spagni
5db72d12b4
Merge pull request #5388 
0be5b2ee simplewallet: new unset_ring command (moneromooo-monero)
 2019-04-11 13:05:43 +02:00
Riccardo Spagni
5c02316598
Merge pull request #5382 
c12b43cb wallet: add number of blocks required for the balance to fully unlock (moneromooo-monero)
3f1e9e84 wallet2: set confirmations to 0 for pool txes in proofs (moneromooo-monero)
36c037ec wallet_rpc_server: error out on getting the spend key from a hot wallet (moneromooo-monero)
cd1eaff2 wallet_rpc_server: always fill out subaddr_indices in get_transfers (moneromooo-monero)
 2019-04-11 13:03:55 +02:00
Riccardo Spagni
38717dafc0
Merge pull request #5381 
def40161 miner: fix race when stopping mining with start mining enabled (moneromooo-monero)
 2019-04-11 13:03:32 +02:00
Riccardo Spagni
915d9e5a1f
Merge pull request #5380 
113e4877 blockchain_stats: fix sign in formatting function (moneromooo-monero)
adaea3ea various: remove unused variables (moneromooo-monero)
631ef00e blockchain: some debug info when adding txes-from-block fails (moneromooo-monero)
 2019-04-11 13:02:59 +02:00
Riccardo Spagni
fa789109f6
Merge pull request #5379 
83fc45a4 Add NanoX support (cslashm)
 2019-04-11 13:02:47 +02:00
Riccardo Spagni
bd429033df
Merge pull request #5378 
eda2661a Allow pruning before v10 (moneromooo-monero)
 2019-04-11 13:02:35 +02:00
Riccardo Spagni
4a2cc76c84
Merge pull request #5376 
c746f45d Add hash of top block to /getheight RPC (Howard Chu)
 2019-04-11 13:01:54 +02:00
Riccardo Spagni
3a4008f0fc
Merge pull request #5374 
a2561653 wallet: new option to start background mining (moneromooo-monero)
 2019-04-11 13:01:30 +02:00
Riccardo Spagni
036daa3af9
Merge pull request #5373 
aff80e70 blockchain: fix returned height in create_block_template (moneromooo-monero)
 2019-04-11 13:00:55 +02:00
moneromooo-monero
9f8dc4ce51
simplewallet: new net_stats command 
displays total sent and received bytes
 2019-04-11 10:46:41 +00:00
Riccardo Spagni
19e37c05d6
Merge pull request #5367 
07b716bf util: name replace_file arguments better (moneromooo-monero)
 2019-04-11 12:41:55 +02:00
Riccardo Spagni
793651e731
Merge pull request #5366 
c2f271d1 device/trezor: increase live-refresh timeout (Dusan Klinec)
 2019-04-11 12:41:34 +02:00
Riccardo Spagni
76fbcfe2dd
Merge pull request #5123 
089c7637 cryptonote: rework block blob size sanity check (moneromooo-monero)
 2019-04-11 12:41:07 +02:00
Dusan Klinec
41901b8deb
device/trezor: env-configurable ports 2019-04-10 18:29:24 +02:00
moneromooo-monero
374f388de2
wallet_rpc_server: add a all flag to export_outputs 
if we don't want to export new outputs only
 2019-04-10 10:37:34 +00:00
stoffu
661f1fb8b2
blockchain: remove unused calc of short_term_constraint 2019-04-09 19:39:24 +09:00
Lee Clagett
2e578b8214 Enabling daemon-rpc SSL now requires non-system CA verification 
If `--daemon-ssl enabled` is set in the wallet, then a user certificate,
fingerprint, or onion/i2p address must be provided.
 2019-04-07 13:02:43 -04:00
Dusan Klinec
c4f8a8a6a9
build fix: combinator.h stdexcept missing include 2019-04-07 17:41:13 +02:00
moneromooo-monero
bea1918a05
blockchain_import: error out if preparing to handle blocks fails 
Coverity 197562
 2019-04-07 13:48:19 +00:00
moneromooo-monero
ffdbcfb6b3
core: don't check block rate nor fork time in regtest mode 2019-04-07 13:30:02 +00:00
Dusan Klinec
c68fe7873b
device/trezor: add button pressed request 2019-04-07 13:35:49 +02:00
Lee Clagett
d58f368289 Require manual override for user chain certificates. 
An override for the wallet to daemon connection is provided, but not for
other SSL contexts. The intent is to prevent users from supplying a
system CA as the "user" whitelisted certificate, which is less secure
since the key is controlled by a third party.
 2019-04-07 00:44:37 -04:00
Lee Clagett
21eb1b0725 Pass SSL arguments via one class and use shared_ptr instead of reference 2019-04-07 00:44:37 -04:00
Lee Clagett
1f5ed328aa Change default SSL to "enabled" if user specifies fingerprint/certificate 
Currently if a user specifies a ca file or fingerprint to verify peer,
the default behavior is SSL autodetect which allows for mitm downgrade
attacks. It should be investigated whether a manual override should be
allowed - the configuration is likely always invalid.
 2019-04-06 23:47:07 -04:00
Lee Clagett
a3b0284837 Change SSL certificate file list to OpenSSL builtin load_verify_location 
Specifying SSL certificates for peer verification does an exact match,
making it a not-so-obvious alias for the fingerprints option. This
changes the checks to OpenSSL which loads concatenated certificate(s)
from a single file and does a certificate-authority (chain of trust)
check instead. There is no drop in security - a compromised exact match
fingerprint has the same worse case failure. There is increased security
in allowing separate long-term CA key and short-term SSL server keys.

This also removes loading of the system-default CA files if a custom
CA file or certificate fingerprint is specified.
 2019-04-06 23:47:06 -04:00
moneromooo-monero
e8cf7dcc2b
rpc: merge the two get_info implementations 2019-04-06 14:04:24 +00:00
Riccardo Spagni
3759e2359f
Merge pull request #5360 
b0c552f5 cryptonote_protocol_handler: add block/tx hashes in notify logs (moneromooo-monero)
 2019-04-06 16:03:13 +02:00
Riccardo Spagni
18ceac9ca5
Merge pull request #5351 
a299dc96 rpc.gettransactions: fill as_json with partial tx in pruned mode (stoffu)
 2019-04-06 16:01:44 +02:00
Riccardo Spagni
c7e536db23
Merge pull request #5350 
050bb337 wallet2: factor the watchonly/multisig/etc fields on creation (moneromooo-monero)
 2019-04-06 16:00:40 +02:00
Riccardo Spagni
cd8fe937ad
Merge pull request #5347 
d45b85e1 wallet2: skip derivation precalc for blocks we know we'll skip (moneromooo-monero)
 2019-04-06 15:59:56 +02:00
Riccardo Spagni
4ac78e1612
Merge pull request #5346 
c84ea299 cryptonote_basic: some more minor speedups (moneromooo-monero)
e40eb2ad cryptonote_basic: speedup calculate_block_hash (moneromooo-monero)
547a9708 cryptonote: block parsing + hash calculation speedup (moneromooo-monero)
11604b6d blockchain: avoid unneeded block copy (moneromooo-monero)
8461df04 save some database calls when getting top block hash and height (moneromooo-monero)
3bbc3661 Avoid repeated (de)serialization when syncing (moneromooo-monero)
 2019-04-06 15:59:43 +02:00
Riccardo Spagni
7e5651c346
Merge pull request #5345 
678262ab wallet_rpc_server: allow english/local language names in create_wallet (moneromooo-monero)
 2019-04-06 15:59:10 +02:00
Riccardo Spagni
c61b3f0ead
Merge pull request #5344 
5e1a3e48 lmdb: fix size_t size issues on 32 bit (moneromooo-monero)
 2019-04-06 15:58:50 +02:00
Riccardo Spagni
9e72f785d6
Merge pull request #5343 
cafa15b9 wallet2: set confirmations to 0 for pool txes in proofs (moneromooo-monero)
 2019-04-06 15:58:25 +02:00
Riccardo Spagni
6f8e0a28b2
Merge pull request #5342 
849a768f perf_timer: move some debug levels to info for consistency (moneromooo-monero)
 2019-04-06 15:57:50 +02:00
Riccardo Spagni
e1f0e6da5c
Merge pull request #5340 
16eda54b wallet: use original user address if we have a short payment id (moneromooo-monero)
 2019-04-06 15:56:52 +02:00
Dusan Klinec
827f52add0
wallet: API changes to enable passphrase entry 2019-04-05 22:17:50 +02:00
moneromooo-monero
cbf3224180
rpc: make wide_difficulty hexadecimal 
This should be friendlier for clients which don't have bignum support
 2019-04-05 16:30:16 +00:00
moneromooo-monero
089c7637a6
cryptonote: rework block blob size sanity check 
Use the actual block weight limit, assuming that weight is always
greater or equal to size
 2019-04-05 09:35:19 +00:00
moneromooo-monero
a2561653cb
wallet: new option to start background mining 
The setup-background-mining option can be used to select
background mining when a wallet loads. The user will be asked
the first time the wallet is created.
 2019-04-04 18:10:45 +00:00
moneromooo-monero
b40392fb02
wallet2: add --no-dns flag 2019-04-04 14:32:40 +00:00
stoffu
a2195b9b7f
crypto: replace rand<T>()%N idiom with unbiased rand_idx(N) 2019-04-04 22:38:19 +09:00
stoffu
a299dc96f7
rpc.gettransactions: fill as_json with partial tx in pruned mode 2019-04-04 18:08:01 +09:00
moneromooo-monero
15f27c80b9
wallet2: support multi out txes without change in sanity check 2019-04-03 20:58:21 +00:00
selsta
8bb253b0db
libwallet_merged: add missing net target 2019-04-02 21:22:51 +02:00
moneromooo-monero
0be5b2ee78
simplewallet: new unset_ring command 
Useful when debugging, though not much for users
 2019-04-02 14:18:07 +00:00
stoffu
d3018d0f0b
api/wallet: fix some wrong namespace 2019-04-02 10:11:49 +09:00
moneromooo-monero
c12b43cb5a
wallet: add number of blocks required for the balance to fully unlock 2019-04-01 19:31:19 +00:00
moneromooo-monero
3f1e9e84c0
wallet2: set confirmations to 0 for pool txes in proofs 
It makes more sense than (uint64_t)-1, which is going to look
like very much confirmed when not checking in_pool
 2019-04-01 19:31:10 +00:00
moneromooo-monero
36c037ec47
wallet_rpc_server: error out on getting the spend key from a hot wallet 2019-04-01 19:31:01 +00:00
moneromooo-monero
cd1eaff29e
wallet_rpc_server: always fill out subaddr_indices in get_transfers 
It was not filled out for in and pool types
 2019-04-01 19:30:27 +00:00
moneromooo-monero
def4016171 miner: fix race when stopping mining with start mining enabled 2019-04-01 19:28:50 +00:00
moneromooo-monero
113e487739
blockchain_stats: fix sign in formatting function 2019-04-01 19:24:47 +00:00
moneromooo-monero
adaea3ea3c
various: remove unused variables 2019-04-01 19:24:41 +00:00
moneromooo-monero
631ef00e76
blockchain: some debug info when adding txes-from-block fails 2019-04-01 19:24:35 +00:00
Riccardo Spagni
b6726aaa6c
Merge pull request #5319 
f825055d wallet_rpc_server: error out on getting the spend key from a hot wallet (moneromooo-monero)
67aa4adc wallet_rpc_server: add a set_daemon RPC (moneromooo-monero)
705acbac wallet2: init some variables to default values if loading old wallets (moneromooo-monero)
f82bc29e wallet_rpc_server: always fill out subaddr_indices in get_transfers (moneromooo-monero)
01efdc6a wallet_rpc_server: set confirmations to 0 for pending/pool txes (moneromooo-monero)
 2019-04-01 20:56:52 +02:00
moneromooo-monero
f825055d22
wallet_rpc_server: error out on getting the spend key from a hot wallet 2019-04-01 16:03:29 +00:00
moneromooo-monero
67aa4adcfc
wallet_rpc_server: add a set_daemon RPC 2019-04-01 16:03:25 +00:00
moneromooo-monero
705acbac4d
wallet2: init some variables to default values if loading old wallets 2019-04-01 16:03:23 +00:00
moneromooo-monero
f82bc29ec2
wallet_rpc_server: always fill out subaddr_indices in get_transfers 
It was not filled out for in and pool types
 2019-04-01 16:03:20 +00:00
moneromooo-monero
01efdc6a7e
wallet_rpc_server: set confirmations to 0 for pending/pool txes 2019-04-01 16:03:17 +00:00
cslashm
83fc45a413 Add NanoX support 2019-04-01 17:40:24 +02:00
Riccardo Spagni
0eb2c7b272
Merge pull request #5339 
9f49722c Fix build on FreeBSD (Nathan Dorfman)
 2019-04-01 17:37:14 +02:00
Riccardo Spagni
6e0242f861
Merge pull request #5334 
19f8089f p2p: don't lookup seed nodes when offline (moneromooo-monero)
 2019-04-01 17:37:01 +02:00
Riccardo Spagni
286dec012d
Merge pull request #5333 
18faa6da wallet: add freeze/thaw/frozen commands (moneromooo-monero)
 2019-04-01 17:36:16 +02:00
Riccardo Spagni
b8ab510f23
Merge pull request #5332 
7c440915 Add get_tx_proof support, needed for new sanity check (cslashm)
98fdcb2a Add support for V11 protocol with BulletProofV2 and short amount. New scheme key destination contrfol Fix dummy decryption in debug mode (cslashm)
3a981a33 Add application version compatibility check. (cslashm)
 2019-04-01 17:35:12 +02:00
Riccardo Spagni
3b52940471
Merge pull request #5349 
f1a3796a wallet2: fix tx sanity check change test for the sweep_all case (moneromooo-monero)
 2019-04-01 17:34:43 +02:00
Riccardo Spagni
29e4e70f30
Merge pull request #5352 
ae6885f6 blockchain: incremental long term block weight cache (moneromooo-monero)
9b687c78 blockchain: simple cache for the long term block weights (moneromooo-monero)
 2019-04-01 17:34:02 +02:00
Riccardo Spagni
3b1fa543ca
Merge pull request #5329 
023f2c77 wallet_rpc_server: remove mixin from transfer RPCs (moneromooo-monero)
 2019-04-01 17:32:20 +02:00
Riccardo Spagni
1ed6441925
Merge pull request #5327 
c23ea796 New interactive daemon command 'print_net_stats': Global traffic stats (rbrunner7)
 2019-04-01 17:32:01 +02:00
Riccardo Spagni
a69b71dc41
Merge pull request #5326 
dc20d774 rpc: add miner tx hash to block header response (moneromooo-monero)
 2019-04-01 17:31:36 +02:00
Riccardo Spagni
4f3f15edba
Merge pull request #5325 
760d3a2a daemon: init public_port in all ctors (moneromooo-monero)
 2019-04-01 17:31:17 +02:00
Riccardo Spagni
13f414cb9f
Merge pull request #5322 
85f2f8c9 Fix daemon startup parameter '--limit-rate' processing after parameter defaults (rbrunner7)
 2019-04-01 17:31:01 +02:00
Riccardo Spagni
55d7eb06a8
Merge pull request #5317 
1730a44f core: improve block rate monitor trigger probabilities (moneromooo-monero)
 2019-04-01 17:28:55 +02:00
Riccardo Spagni
97831e5f8b
Merge pull request #5308 
a7211793 rpc: quantize db size up to 5 GB in restricted mode (moneromooo-monero)
 2019-04-01 17:27:56 +02:00
Riccardo Spagni
5a71fb74f0
Merge pull request #5307 
e99b2b12 simplewallet: make the long payment ids warnigns more warney (moneromooo-monero)
 2019-04-01 17:27:25 +02:00
Riccardo Spagni
c994dc7ec0
Merge pull request #5306 
8a97563a Use threadpool instead of new threads for DNS queries (Howard Chu)
 2019-04-01 17:27:09 +02:00
Riccardo Spagni
8b57e33789
Merge pull request #5305 
4500236f wallet2: make use_fork_rules handle chain heights lower than leeway (moneromooo-monero)
 2019-04-01 17:26:23 +02:00
Riccardo Spagni
30a3a73609
Merge pull request #5303 
0a6cb30d wallet: flush output cache upon reorg (moneromooo-monero)
 2019-04-01 17:26:10 +02:00
Riccardo Spagni
94880540e7
Merge pull request #5302 
23fb056a wallet_rpc_server: new auto_refresh RPC (moneromooo-monero)
 2019-04-01 17:25:53 +02:00
Riccardo Spagni
b09f1bdb8f
Merge pull request #5299 
4ee15655 wallet_rpc_server: fix buffer read overflow in string assignment (moneromooo-monero)
 2019-04-01 17:24:33 +02:00
Riccardo Spagni
4a06b3ee62
Merge pull request #5298 
8fd7452b wallet: move light wallet RPC out of core RPC (moneromooo-monero)
 2019-04-01 17:24:13 +02:00
Riccardo Spagni
f13d38350a
Merge pull request #5297 
a8b98a0b wallet: fix memory only wallets (moneromooo-monero)
 2019-04-01 17:23:37 +02:00
Riccardo Spagni
89fb0e3cd6
Merge pull request #5295 
2b10f22a mnemonics: fix half length seed to bytes conversion (moneromooo-monero)
 2019-04-01 17:23:25 +02:00
Riccardo Spagni
cabd848efa
Merge pull request #5294 
77e9815d blockchain: do not try to pop the genesis block (moneromooo-monero)
 2019-04-01 17:22:51 +02:00
Riccardo Spagni
6cb0a26d9d
Merge pull request #5292 
328d291f wallet2: set seed language when creating from json (moneromooo-monero)
 2019-04-01 17:22:22 +02:00
Riccardo Spagni
a6b798e72f
Merge pull request #5291 
a52366c1 wallet2: fix generation from json when restore height is not set (moneromooo-monero)
 2019-04-01 17:21:14 +02:00
Riccardo Spagni
574c399386
Merge pull request #5288 
39f000b3 miner: fix possible exit crash due to race in stop (moneromooo-monero)
 2019-04-01 17:20:25 +02:00
Riccardo Spagni
7ec799c542
Merge pull request #5287 
1d14b3f0 ringct: fix capitalization for scaler mult (fuwa)
 2019-04-01 17:19:32 +02:00
Riccardo Spagni
e55b3f9dda
Merge pull request #5239 
91f4c7f4 Make difficulty 128 bit instead of 64 bit (moneromooo-monero)
 2019-04-01 17:19:10 +02:00
moneromooo-monero
eda2661aa2
Allow pruning before v10 
This check is now not needed anymore, and would prevent people
from using --prune-blockchain when starting a new sync
 2019-04-01 14:06:49 +00:00
Howard Chu
c746f45d3e
Add hash of top block to /getheight RPC 2019-04-01 01:02:58 +01:00
moneromooo-monero
5e1a3e48ba
lmdb: fix size_t size issues on 32 bit 2019-03-31 11:12:21 +00:00
moneromooo-monero
aff80e7043
blockchain: fix returned height in create_block_template 
It's now needed for CNv4, and was not retained when cached
 2019-03-30 20:27:25 +00:00
moneromooo-monero
07b716bfea
util: name replace_file arguments better 
It was confusing unless you read code and the rename(2) man page.
 2019-03-29 16:32:00 +00:00
Dusan Klinec
c2f271d13a
device/trezor: increase live-refresh timeout 2019-03-29 17:23:14 +01:00
italocoin
383c38fdb1 fix init warning on whatever compiler version 2019-03-29 11:25:36 -04:00
moneromooo-monero
ae6885f6b4
blockchain: incremental long term block weight cache 2019-03-28 18:07:57 +00:00
moneromooo-monero
9b687c7873
blockchain: simple cache for the long term block weights 2019-03-28 18:07:57 +00:00
cslashm
7c44091541 Add get_tx_proof support, needed for new sanity check 
Enhance debug info
 2019-03-28 18:26:15 +01:00
cslashm
98fdcb2aa5 Add support for V11 protocol with BulletProofV2 and short amount. 
New scheme key destination contrfol
Fix dummy decryption in debug mode
 2019-03-28 18:26:15 +01:00
cslashm
3a981a3313 Add application version compatibility check. 2019-03-28 18:26:15 +01:00
moneromooo-monero
b0c552f50f
cryptonote_protocol_handler: add block/tx hashes in notify logs 2019-03-28 00:43:55 +00:00
moneromooo-monero
ef92620c1d
socks: fix build with boost 1.70 2019-03-27 13:22:41 +00:00
moneromooo-monero
050bb337d7
wallet2: factor the watchonly/multisig/etc fields on creation 
There's half a dozen calls, and it's easy to miss some when
adding a new field.
 2019-03-27 08:51:16 +00:00
moneromooo-monero
f1a3796a43
wallet2: fix tx sanity check change test for the sweep_all case 2019-03-25 22:41:22 +00:00
moneromooo-monero
d45b85e170
wallet2: skip derivation precalc for blocks we know we'll skip 2019-03-25 14:28:05 +00:00
moneromooo-monero
c84ea2993f
cryptonote_basic: some more minor speedups 2019-03-25 13:43:38 +00:00
moneromooo-monero
e40eb2ad9d
cryptonote_basic: speedup calculate_block_hash 
The block 202612 fix can be left tested at the end, if we
already know we're not in the general case
 2019-03-25 13:43:29 +00:00
moneromooo-monero
547a9708de
cryptonote: block parsing + hash calculation speedup 
This saves a duplicate serialization step
 2019-03-25 13:43:17 +00:00
moneromooo-monero
11604b6da6
blockchain: avoid unneeded block copy 2019-03-25 13:42:32 +00:00
moneromooo-monero
8461df0405
save some database calls when getting top block hash and height 2019-03-25 13:42:25 +00:00
moneromooo-monero
3bbc366147
Avoid repeated (de)serialization when syncing 2019-03-25 13:42:18 +00:00
moneromooo-monero
678262ab65
wallet_rpc_server: allow english/local language names in create_wallet 
and return both in get_languages
 2019-03-25 12:52:43 +00:00
moneromooo-monero
a8b98a0bd7
wallet: fix memory only wallets 
at least when using restore_deterministic_wallet
 2019-03-25 12:49:25 +00:00
fuwa
1d14b3f072 ringct: fix capitalization for scaler mult 2019-03-25 13:00:14 +08:00
Lee Clagett
7acfa9f3cc Added socks proxy (tor/i2pd/kovri) support to wallet 2019-03-25 01:35:13 +00:00
moneromooo-monero
1730a44f90
core: improve block rate monitor trigger probabilities 
The original intent of one false positive a week on average
was not met, since what we really want is not the probability
of having N blocks in T seconds, but either N blocks of fewer
in T seconds, or N blocks or more in T seconds.

Some of this could be cached since it calculates the same fairly
complex floating point values, but it seems pretty fast already.
 2019-03-25 00:55:09 +00:00
moneromooo-monero
cafa15b904
wallet2: set confirmations to 0 for pool txes in proofs 
It makes more sense than (uint64_t)-1, which is going to look
like very much confirmed when not checking in_pool
 2019-03-24 21:59:06 +00:00
moneromooo-monero
91f4c7f45f
Make difficulty 128 bit instead of 64 bit 
Based on Boolberry work by:
  jahrsg <jahr@jahr.me>
  cr.zoidberg <crypto.zoidberg@gmail.com>
 2019-03-24 21:03:19 +00:00
moneromooo-monero
849a768f36
perf_timer: move some debug levels to info for consistency 2019-03-24 20:15:33 +00:00
Riccardo Spagni
e4b049da05
Merge pull request #5286 
cce948a5 simplewallet: add some missing spacing before uses data (moneromooo-monero)
 2019-03-24 19:38:50 +02:00
Riccardo Spagni
4176a399de
Merge pull request #5282 
f962449d wallet_rpc_server: include out subaddress indices in get_transfers (moneromooo-monero)
 2019-03-24 19:37:07 +02:00
Riccardo Spagni
8cb4293e82
Merge pull request #5277 
adf6d773 wallet: fix offline signing calling a daemon RPC (moneromooo-monero)
 2019-03-24 19:35:39 +02:00
Riccardo Spagni
0920ac7642
Merge pull request #5207 
be6f426a rpc: Allow submitting tx as hex blob over ZMQ (Nathan Dorfman)
 2019-03-24 19:33:36 +02:00
Riccardo Spagni
de4ca3f14e
Merge pull request #5324 
223c6b07 dns_utils: really add default DNSSEC servers on failure (moneromooo-monero)
 2019-03-24 19:05:28 +02:00
Riccardo Spagni
0965b101f2
Merge pull request #5321 
e9519e98 cryptonote: fix calculating coinbase tx hash (moneromooo-monero)
 2019-03-24 19:04:27 +02:00
rbrunner7
c23ea7962d New interactive daemon command 'print_net_stats': Global traffic stats 2019-03-24 16:58:57 +01:00
moneromooo-monero
16eda54b38
wallet: use original user address if we have a short payment id 2019-03-24 08:58:59 +00:00
Nathan Dorfman
9f49722c4d Fix build on FreeBSD 2019-03-24 01:12:06 -06:00
moneromooo-monero
19f8089fca
p2p: don't lookup seed nodes when offline 
This will cause DNS requests, which will block and timeout
if there is really no network connectivity
 2019-03-22 15:47:48 +00:00
moneromooo-monero
18faa6da0c
wallet: add freeze/thaw/frozen commands 
These commands let one freeze outputs by key image, so they
do not appear in balance, nor are considered when creating
a transaction, etc

This is helpful when receiving an output from a suspected spy,
who might try to track your other outputs by seeing with what
other outputs it gets spent.

The frozen command may be used without parameters to list all
currently frozen outputs.
 2019-03-22 09:19:24 +00:00
moneromooo-monero
e9519e9876
cryptonote: fix calculating coinbase tx hash 
Also set error flag on exception when handling new txes
to keep tests working
 2019-03-21 17:13:01 +00:00
moneromooo-monero
023f2c7747
wallet_rpc_server: remove mixin from transfer RPCs 
it's been a while, only use ring_size now
 2019-03-21 14:47:39 +00:00
moneromooo-monero
adf6d7730f
wallet: fix offline signing calling a daemon RPC 2019-03-21 14:46:29 +00:00
moneromooo-monero
b05f10f82e
wallet2: sanity check new tx before sending 
We generate and check tx proofs and verify the amounts in those
match what the original amounts were.
 2019-03-21 13:03:45 +00:00
Riccardo Spagni
cac4c3103a
Merge pull request #5271 
2790d4d3 hardfork: update last_versions on popped block (moneromooo-monero)
 2019-03-21 14:52:02 +02:00
Riccardo Spagni
e0a05837ba
Merge pull request #5270 
5ade7281 Wallet API: multisig_tx_set passing bug fixed (naughtyfox)
 2019-03-21 14:51:41 +02:00
Riccardo Spagni
dcfd5a8892
Merge pull request #5266 
576116d4 wallet: fix load failure if the mms isn't usable (moneromooo-monero)
 2019-03-21 14:51:30 +02:00
Riccardo Spagni
5ac46c5310
Merge pull request #5256 
4b21d38d blockchain: speed up getting N blocks weights/long term weights (moneromooo-monero)
 2019-03-21 14:48:40 +02:00
Riccardo Spagni
6c0c7d796d
Merge pull request #5252 
7ac33342 slow-hash: cache TLS references locally once at function start (moneromooo-monero)
 2019-03-21 14:48:24 +02:00
Riccardo Spagni
39107e18d5
Merge pull request #5251 
7632dede crypto: fix PaX issue on NetBSD with CNv4 JIT (moneromooo-monero)
89b1630e gtest: build fix for NetBSD (moneromooo-monero)
fa43b547 tests: handle any cmake detected python interpreter (moneromooo-monero)
 2019-03-21 14:47:43 +02:00
Riccardo Spagni
56feda84d3
Merge pull request #5250 
a48e49aa aesb: avoid stomping on an existing define on NetBSD (moneromooo-monero)
 2019-03-21 14:47:11 +02:00
Riccardo Spagni
30e823e7cd
Merge pull request #5248 
3f6f90bb wallet2: do not use invalid keys as fake outs in rings (moneromooo-monero)
 2019-03-21 14:46:58 +02:00
Riccardo Spagni
df50181ab2
Merge pull request #5237 
3907588b rpc: make fill_pow restricted (moneromooo-monero)
 2019-03-21 14:46:20 +02:00
Riccardo Spagni
5e03bd06c1
Merge pull request #5235 
c6a70af8 wallet2: key image import fixes (moneromooo-monero)
 2019-03-21 14:45:58 +02:00
Riccardo Spagni
f9b1c4f962
Merge pull request #5213 
efb2bdd3 slow-hash: default to JIT on x86_64 (moneromooo-monero)
 2019-03-21 14:44:26 +02:00
Riccardo Spagni
48e3a341f8
Merge pull request #5211 
c9b13fbb tests/trezor: HF9 and HF10 tests (Dusan Klinec)
a1fd1d49 device/trezor: HF10 support added, wallet::API (Dusan Klinec)
d74d26f2 crypto: hmac_keccak added (Dusan Klinec)
 2019-03-21 14:44:04 +02:00
moneromooo-monero
efb2bdd309
slow-hash: default to JIT on x86_64 2019-03-21 11:29:08 +00:00
moneromooo-monero
dc20d77459
rpc: add miner tx hash to block header response 2019-03-21 00:24:12 +00:00
moneromooo-monero
223c6b0796
dns_utils: really add default DNSSEC servers on failure 
Coverity 196597
 2019-03-20 23:46:22 +00:00
moneromooo-monero
760d3a2a0c
daemon: init public_port in all ctors 
Coverity 196596
 2019-03-20 23:45:00 +00:00
Dusan Klinec
a1fd1d499c
device/trezor: HF10 support added, wallet::API 
- import only key images generated by cold signing process
- wallet_api: trezor methods added
- wallet: button request code added
- const added to methods
- wallet2::get_tx_key_device() tries to decrypt stored tx private keys using the device.
- simplewallet supports get_tx_key and get_tx_proof on hw device using the get_tx_key feature
- live refresh enables refresh with trezor i.e. computing key images on the fly. More convenient and efficient for users.
- device: has_ki_live_refresh added
- a thread is watching whether live refresh is being computed, if not for 30 seconds, it terminates the live refresh process - switches Trezor state
 2019-03-20 21:11:02 +01:00
Dusan Klinec
d74d26f2c9
crypto: hmac_keccak added 2019-03-20 21:11:01 +01:00
rbrunner7
85f2f8c933 Fix daemon startup parameter '--limit-rate' processing after parameter defaults 2019-03-20 16:40:59 +01:00
Lee Clagett
0c7e7bce18 Adding classes, functions, and utilities for common LMDB operations. 2019-03-19 17:52:26 +00:00
Riccardo Spagni
f2f725d8db
Merge pull request #5201 
4921c794 cn_deserialize: remove some unused code (moneromooo-monero)
 2019-03-19 10:59:55 +02:00
Riccardo Spagni
695d51a481
Merge pull request #5203 
8b514645 add multisig tx sets to describe_transfer rpc endpoint (spoke0)
 2019-03-19 10:59:42 +02:00
Riccardo Spagni
acc7211b5b
Merge pull request #5199 
eef164f7 cryptonote_protocol_handler: search for syncing peers in "cruise mode" (moneromooo-monero)
 2019-03-19 10:58:38 +02:00
Riccardo Spagni
2900f6a3ca
Merge pull request #5198 
9c4d403a dns_utils: use fallback if the default resolver does not support DNSSEC (moneromooo-monero)
 2019-03-19 10:58:25 +02:00
Riccardo Spagni
bf0f85221b
Merge pull request #5195 
a54e81e5 daemon: add '--no-sync' arg to optionally disable blockchain sync (xiphon)
 2019-03-19 10:57:28 +02:00
Riccardo Spagni
38dcd975f2
Merge pull request #4889 
f42263eb wallet: adds rescan_bc option with preserving key images (Dusan Klinec)
 2019-03-19 10:55:45 +02:00
moneromooo-monero
a7211793ba
rpc: quantize db size up to 5 GB in restricted mode 2019-03-17 21:27:52 +00:00
moneromooo-monero
e99b2b12fd
simplewallet: make the long payment ids warnigns more warney 
We want people to really realize it's bad for *their* privacy.
 2019-03-17 18:42:52 +00:00
Riccardo Spagni
c3de019f56
Merge pull request #5192 
d0e07b3d performance_tests: fix NetBSD build (moneromooo-monero)
7d88d8f2 discontinue use of alloca (moneromooo-monero)
 2019-03-17 17:56:52 +02:00
Riccardo Spagni
848591c4d8
Merge pull request #5190 
551104fb daemon: add --public-node mode, RPC port propagation over P2P (xiphon)
 2019-03-17 17:56:04 +02:00
Riccardo Spagni
429930534d
Merge pull request #5185 
59478c80 daemon: new mining_status command (moneromooo-monero)
 2019-03-17 17:55:32 +02:00
Riccardo Spagni
e1be617ea2
Merge pull request #5182 
b674728d Better error when sending a tx with a too large extra field (moneromooo-monero)
 2019-03-17 17:55:13 +02:00
Riccardo Spagni
6031a1f5b4
Merge pull request #5179 
7c09882a dns_utils: remove MoneroPulse/checkpoints mention in TXT record code (moneromooo-monero)
 2019-03-17 17:53:53 +02:00
Riccardo Spagni
fd231226b9
Merge pull request #5177 
bb2aed8e rpc: quantize db size up to 5 GB in restricted mode (moneromooo-monero)
 2019-03-17 17:52:56 +02:00
Riccardo Spagni
761ef99e77
Merge pull request #5168 
8630a028 wallet: fix payment ID decryption for construction data (Dusan Klinec)
 2019-03-17 17:52:41 +02:00
Riccardo Spagni
47c278c90f
Merge pull request #5166 
75e5aafd device/trezor: dummy payment ID fix (Dusan Klinec)
 2019-03-17 17:51:52 +02:00
Riccardo Spagni
6d5849d9bb
Merge pull request #5165 
36451697 Simplify RPC endpoint, emoving second RPC endpoint generate_from_view_key (Joel)
c17c8188 Remove code duplication (Joel)
acb14c10 Add generate_from_view_key RPC method (Joel)
7dd7a3b7 Add generate_from_keys RPC method (Joel)
 2019-03-17 17:51:24 +02:00
Riccardo Spagni
50d48d6118
Merge pull request #5135 
de32dcea Human readable message if maximum outputs reached (italocoin)
 2019-03-17 17:50:41 +02:00
Riccardo Spagni
4c91eb23a0
Merge pull request #5061 
1f2930ce Update 2019 copyright (binaryFate)
 2019-03-17 17:49:30 +02:00
Howard Chu
8a97563a93
Use threadpool instead of new threads for DNS queries 2019-03-17 15:39:15 +00:00
moneromooo-monero
4500236f25
wallet2: make use_fork_rules handle chain heights lower than leeway 2019-03-17 14:22:50 +00:00
moneromooo-monero
0a6cb30d62
wallet: flush output cache upon reorg 
Fixes output usage tracking
 2019-03-17 10:34:07 +00:00
moneromooo-monero
23fb056a72
wallet_rpc_server: new auto_refresh RPC 
It can enable/disable auto refresh, and set auto refresh period
 2019-03-17 10:33:51 +00:00
Riccardo Spagni
e063615a0e
Merge pull request #5249 
3ac40938 timings: fix errno.h mispelt as error.h (moneromooo-monero)
 2019-03-16 14:06:07 +02:00
Riccardo Spagni
03d1dbc2ad
Merge pull request #5280 
aac4e2f5 wallet_rpc_server: add missing --rpc-ssl-allowed-fingerprints (moneromooo-monero)
 2019-03-16 14:05:30 +02:00
moneromooo-monero
4ee156556d
wallet_rpc_server: fix buffer read overflow in string assignment 2019-03-15 19:36:13 +00:00
moneromooo-monero
8fd7452b6e
wallet: move light wallet RPC out of core RPC 
It's not nothing to do with it
 2019-03-15 13:34:08 +00:00
Dusan Klinec
f42263ebb6
wallet: adds rescan_bc option with preserving key images 
- enables to perform rescan_spent / ki sync with untrusted daemon. Spent check status involves RPC calls which require trusted daemon status as it leaks information. The new call performs soft reset while preserving key images thus a sequence: refresh, ki sync / import, rescan_bc keep_ki will correctly perform spent checking without need for trusted daemon.

- useful to detect spent outputs with untrusted daemon on watch_only / multisig / hw-cold wallets after expensive key image sync.

- cli: rescan_bc keep_ki
 2019-03-15 12:55:29 +01:00
moneromooo-monero
2b10f22ae6
mnemonics: fix half length seed to bytes conversion 2019-03-15 11:05:42 +00:00
moneromooo-monero
77e9815db7
blockchain: do not try to pop the genesis block 2019-03-15 10:51:48 +00:00
moneromooo-monero
328d291fe4
wallet2: set seed language when creating from json 2019-03-15 00:16:50 +00:00
moneromooo-monero
a52366c1bf
wallet2: fix generation from json when restore height is not set 
It was not recovering then, but creating a new random address
 2019-03-14 23:41:41 +00:00
moneromooo-monero
39f000b394
miner: fix possible exit crash due to race in stop 
If a thread asks to stop the miner, m_stop will be set, and
that thread will wait to join. If the main thread is exiting
at that time, it will ask the miner to stop, but the miner
will claim it's not mining and early out since m_stop is
set. This will cause the database and other things to get
shutdown. If the miner happens to find a block at that time,
it will try to call core, and crash.

Instead, lock and check whether any threads are currently
in m_threads, since they'll only be cleared once the threads
are joined. Moreover, since we lock, the second thread will
have to wait for the first one to have finished. Calling
join twice on a thread seems fine as per pthread_join(3).
 2019-03-14 16:59:08 +00:00
moneromooo-monero
cce948a5ae
simplewallet: add some missing spacing before uses data 2019-03-14 10:07:49 +00:00
Riccardo Spagni
c88e992104
Merge pull request #4977 
5ea17909 device/trezor: debugging features, trezor tests (Dusan Klinec)
 2019-03-14 09:43:02 +02:00
moneromooo-monero
f962449d46
wallet_rpc_server: include out subaddress indices in get_transfers 2019-03-13 14:14:15 +00:00
moneromooo-monero
aac4e2f585
wallet_rpc_server: add missing --rpc-ssl-allowed-fingerprints 2019-03-13 12:59:44 +00:00
moneromooo-monero
bc61b5ca95
wallet2: don't store 0 amount outputs, they'll fail to be spent 
It's better to just ignore them, the user does not really need
to know they're here. If the mask is wrong, they'll fail to be
used, and sweeping will fail as it tries to use it.

Reported by Josh Davis.
 2019-03-12 18:42:30 +00:00
moneromooo-monero
2790d4d30a
hardfork: update last_versions on popped block 2019-03-12 13:43:12 +00:00
naughtyfox
5ade72818b Wallet API: multisig_tx_set passing bug fixed 2019-03-12 14:02:01 +03:00
moneromooo-monero
576116d415
wallet: fix load failure if the mms isn't usable 2019-03-11 16:11:48 +00:00
moneromooo-monero
4ef3c895a4
blockchain: fix ahead of time PoW batch calc 2019-03-10 10:16:13 +00:00
moneromooo-monero
59478c80dd
daemon: new mining_status command 2019-03-09 20:51:53 +00:00
moneromooo-monero
4b21d38dfd
blockchain: speed up getting N blocks weights/long term weights 2019-03-08 12:04:14 +00:00
moneromooo-monero
7ac3334217
slow-hash: cache TLS references locally once at function start 2019-03-07 18:11:19 +00:00
moneromooo-monero
7632dede7b
crypto: fix PaX issue on NetBSD with CNv4 JIT 2019-03-07 16:46:02 +00:00
moneromooo-monero
a48e49aa36
aesb: avoid stomping on an existing define on NetBSD 2019-03-07 16:08:00 +00:00
moneromooo-monero
3ac40938c3
timings: fix errno.h mispelt as error.h 2019-03-07 16:03:55 +00:00
moneromooo-monero
3f6f90bb31
wallet2: do not use invalid keys as fake outs in rings 2019-03-07 15:49:13 +00:00
Riccardo Spagni
49afbd0c53
Merge pull request #5232 
082149c5 fix merge errors, update recommended version to 0.14.0.2 (Riccardo Spagni)
f3b368c6 update checkpoints hash (Riccardo Spagni)
e518f2b1 update checkpoints, update README for 0.14.1 release (Riccardo Spagni)
8780d6b4 update readme via cherry-pick (Riccardo Spagni)
 2019-03-07 15:17:31 +02:00
moneromooo-monero
3907588bf6
rpc: make fill_pow restricted 
It's slow work, so let's not expose it
 2019-03-06 00:05:41 +00:00
moneromooo-monero
c6a70af86a
wallet2: key image import fixes 
- return the right output data when offset is not zero
- do not consider import failed if result height is zero
  (it can be 0 if unknown)
- select the right tx pubkey when using subaddresses (it's faster,
  and we might select the wrong one if we got an output using one
  of the additional tx keys)
- account for skipped outputs for spent/unspent balance info

"spent" is arguably wrong, since it will count spent change
multiple times as it goes through receive/spend cycles.
 2019-03-05 22:41:44 +00:00
binaryFate
1f2930ce0b Update 2019 copyright 2019-03-05 22:05:34 +01:00
Riccardo Spagni
5bbbe3902b
Merge pull request #4852 
057c279c epee: add SSL support (Martijn Otto)
 2019-03-05 16:21:30 +02:00
spoke0
8b51464516 add multisig tx sets to describe_transfer rpc endpoint 2019-03-05 14:42:43 +01:00
Martijn Otto
057c279cb4
epee: add SSL support 
RPC connections now have optional tranparent SSL.

An optional private key and certificate file can be passed,
using the --{rpc,daemon}-ssl-private-key and
--{rpc,daemon}-ssl-certificate options. Those have as
argument a path to a PEM format private private key and
certificate, respectively.
If not given, a temporary self signed certificate will be used.

SSL can be enabled or disabled using --{rpc}-ssl, which
accepts autodetect (default), disabled or enabled.

Access can be restricted to particular certificates using the
--rpc-ssl-allowed-certificates, which takes a list of
paths to PEM encoded certificates. This can allow a wallet to
connect to only the daemon they think they're connected to,
by forcing SSL and listing the paths to the known good
certificates.

To generate long term certificates:

openssl genrsa -out /tmp/KEY 4096
openssl req -new -key /tmp/KEY -out /tmp/REQ
openssl x509 -req -days 999999 -sha256 -in /tmp/REQ -signkey /tmp/KEY -out /tmp/CERT

/tmp/KEY is the private key, and /tmp/CERT is the certificate,
both in PEM format. /tmp/REQ can be removed. Adjust the last
command to set expiration date, etc, as needed. It doesn't
make a whole lot of sense for monero anyway, since most servers
will run with one time temporary self signed certificates anyway.

SSL support is transparent, so all communication is done on the
existing ports, with SSL autodetection. This means you can start
using an SSL daemon now, but you should not enforce SSL yet or
nothing will talk to you.
 2019-03-05 14:16:08 +01:00
Dusan Klinec
5ea17909ca
device/trezor: debugging features, trezor tests 2019-03-05 14:02:45 +01:00
Riccardo Spagni
e65221d690
Merge pull request #5119 
f024a10b db_lmdb: make mdb_block_info format conversion more future proof (moneromooo-monero)
 2019-03-05 14:12:24 +02:00
Riccardo Spagni
5b9c3df5c1
Merge pull request #5103 
ceb72be3 p2p: avoid busy loop when we have nothing to connect to (moneromooo-monero)
 2019-03-05 14:09:42 +02:00
Riccardo Spagni
ed6aa76cca
Merge pull request #5100 
c4851024 wallet_rpc_server: avoid repeated string allocations when parsing (moneromooo-monero)
88c85c18 cryptonote: avoid double parsing blocks when syncing (moneromooo-monero)
9feda0ee cryptonote: speed up calculating coinbase tx prunable hash (moneromooo-monero)
238401d4 core: avoid double parsing blocks after hoh (moneromooo-monero)
dc5a7609 blockchain: avoid unneeded block copy (moneromooo-monero)
79b4e9f3 save some database calls when getting top block hash and height (moneromooo-monero)
98278808 blockchain: avoid pointless transaction copy and temporary (moneromooo-monero)
07d655e4 blockchain: avoid duplicate block hash computation (moneromooo-monero)
f75d51ab core: avoid calculating tx prefix hash when we don't need it (moneromooo-monero)
b044d03a Avoid repeated (de)serialization when syncing (moneromooo-monero)
b747e836 wallet2: don't calculate prefix hash when we don't need it (moneromooo-monero)
e69477bf db: speedup block addition (moneromooo-monero)
 2019-03-05 14:09:19 +02:00
moneromooo-monero
f024a10b68
db_lmdb: make mdb_block_info format conversion more future proof 
If mdb_block_info changes again, the v2 to v3 conversion would
convert to an incorrect format.
 2019-03-05 12:06:23 +00:00
moneromooo-monero
ceb72be329
p2p: avoid busy loop when we have nothing to connect to 2019-03-05 12:00:45 +00:00
moneromooo-monero
c4851024ce
wallet_rpc_server: avoid repeated string allocations when parsing 2019-03-05 11:58:22 +00:00
moneromooo-monero
88c85c18e0
cryptonote: avoid double parsing blocks when syncing 2019-03-05 11:58:18 +00:00
moneromooo-monero
9feda0eeba
cryptonote: speed up calculating coinbase tx prunable hash 
It's a hash of an empty buffer, so we can avoid keccak
 2019-03-05 11:58:16 +00:00
moneromooo-monero
238401d4e9
core: avoid double parsing blocks after hoh 2019-03-05 11:58:13 +00:00
moneromooo-monero
dc5a76095c
blockchain: avoid unneeded block copy 2019-03-05 11:58:10 +00:00
moneromooo-monero
79b4e9f377
save some database calls when getting top block hash and height 2019-03-05 11:58:05 +00:00
moneromooo-monero
9827880877
blockchain: avoid pointless transaction copy and temporary 2019-03-05 11:58:02 +00:00
moneromooo-monero
07d655e438
blockchain: avoid duplicate block hash computation 2019-03-05 11:58:00 +00:00
moneromooo-monero
f75d51abda
core: avoid calculating tx prefix hash when we don't need it 2019-03-05 11:57:57 +00:00
moneromooo-monero
b044d03a51
Avoid repeated (de)serialization when syncing 2019-03-05 11:57:55 +00:00
Riccardo Spagni
082149c580
fix merge errors, update recommended version to 0.14.0.2 2019-03-05 13:46:35 +02:00
Riccardo Spagni
f3b368c659
update checkpoints hash 2019-03-05 13:06:36 +02:00
Riccardo Spagni
e518f2b1c0
update checkpoints, update README for 0.14.1 release 2019-03-05 13:05:41 +02:00
moneromooo-monero
b747e836c8
wallet2: don't calculate prefix hash when we don't need it 2019-03-05 10:28:55 +00:00
moneromooo-monero
e69477bf25
db: speedup block addition 
by avoiding repeated (de)serialization
 2019-03-05 10:28:52 +00:00
moneromooo-monero
108c625b3f
CryptonightR: define out i386/x86_64 specific code on other archs 2019-03-05 10:24:24 +00:00
moneromooo-monero
1b8757dddc
slow-hash: fix build on arm 2019-03-05 10:24:24 +00:00
moneromooo-monero
23abe60705
check load_t_from_json return values 2019-03-04 22:38:06 +00:00
moneromooo-monero
e396146aee
default initialize rpc structures 2019-03-04 22:38:03 +00:00
moneromooo-monero
ef93b0995c
various: remove unused variables 2019-03-04 22:24:49 +00:00
Riccardo Spagni
2f7108f9d7
Merge pull request #5156 
3d2772a0 wallet-rpc: get balance for all accounts and subaddresses (stoffu)
 2019-03-04 21:33:07 +02:00
Riccardo Spagni
6984a4d69c
Merge pull request #5154 
8a1ff079 wallet-rpc: get transfers for all accounts and subaddresses (Jethro Grassie)
 2019-03-04 21:32:42 +02:00
Riccardo Spagni
5260111631
Merge pull request #5146 
4a9257b4 Support docker for gitian builds (TheCharlatan)
 2019-03-04 21:32:30 +02:00
Riccardo Spagni
8e3bd389ea
Merge pull request #5143 
1f5680c8 simplewallet: add help for ask-password options (moneromooo-monero)
c7c74caf simplewallet: mark confirm-missing-payment-id as obsolete (moneromooo-monero)
 2019-03-04 21:31:33 +02:00
Riccardo Spagni
27db0e3bb9
Merge pull request #5141 
5c81a9f1 wallet_rpc_server: add a validate_address RPC (moneromooo-monero)
 2019-03-04 21:30:45 +02:00
Riccardo Spagni
5ab6d68a40
Merge pull request #5140 
a3973fc9 debug compilation fix: net lib missing common deps (Dusan Klinec)
 2019-03-04 21:30:14 +02:00
Riccardo Spagni
66014706bb
Merge pull request #5131 
d2c95ab9 Don't decrypt keys in view only wallets in wallet_keys_unlocker (Doyle)
 2019-03-04 21:28:09 +02:00
Riccardo Spagni
42adc50766
Merge pull request #5125 
8298f42e miner: it can now autodetect the optimal number of threads (moneromooo-monero)
 2019-03-04 21:27:16 +02:00
Riccardo Spagni
372c0da086
Merge pull request #5111 
6a3608d3 cryptonote_protocol_handler: pad tx messages when using tor/i2p (moneromooo-monero)
 2019-03-04 21:24:32 +02:00
Riccardo Spagni
196022530b
Merge pull request #5108 
1c9d5285 blockchain_prune: don't prune before v10 (moneromooo-monero)
 2019-03-04 21:24:09 +02:00
Riccardo Spagni
a28237c9ca
Merge pull request #5102 
1eef0565 performance_tests: better stats, and keep track of timing history (moneromooo-monero)
 2019-03-04 21:22:51 +02:00
Riccardo Spagni
e1a177f0da
Merge pull request #5092 
eec79276 blockchain: fix default genesis block timestamp (moneromooo-monero)
 2019-03-04 21:21:08 +02:00
Riccardo Spagni
4466f4504e
Merge pull request #5091 
123fc2a2 i2p: initial support (Jethro Grassie)
 2019-03-04 21:20:34 +02:00
Riccardo Spagni
b0d326bf2a
Merge pull request #5084 
9d58749b wallet2: fix hashchain going out of sync on refresh error (moneromooo-monero)
 2019-03-04 21:19:12 +02:00
Riccardo Spagni
9d415495bf
Merge pull request #5082 
1bc5f9fa bulletproofs: speed up vector_power_sum (moneromooo-monero)
 2019-03-04 21:18:53 +02:00
Riccardo Spagni
11daa98c0a
Merge pull request #5081 
d78addcb db_lmdb: don't unnecessarily cast to double on the way to uint64_t (moneromooo-monero)
 2019-03-04 21:18:24 +02:00
Riccardo Spagni
46fd181cca
Merge pull request #4054 
24569454 epee: add SSL support (moneromooo-monero)
 2019-03-04 21:17:21 +02:00
Riccardo Spagni
9547e3f451
Merge pull request #5224 
807903bb hardfork: fix fork determination for historical heights (moneromooo)
 2019-03-04 17:17:34 +02:00
Riccardo Spagni
de6d6c0e29
Merge pull request #5217 
fa2fbc39 wallet2: fix mishandling rct outputs in coinbase tx (moneromooo-monero)
 2019-03-04 17:15:06 +02:00
moneromooo-monero
5f67e7f547
blockchain: forbid older BP rct versions from v11 2019-03-04 15:08:12 +00:00
Riccardo Spagni
09020235bf
Merge pull request #5175 
85088d9f db_lmdb: fix missing mdb_dbi_close in migration (moneromooo-monero)
 2019-03-04 17:06:58 +02:00
Riccardo Spagni
815c8a48ab
Merge pull request #5174 
0de14396 tests: add a CNv4 JIT test (moneromooo-monero)
24d281c3 crypto: plug CNv4 JIT into cn_slow_hash (moneromooo-monero)
78ab59ea crypto: clear cache after generating random program (moneromooo-monero)
b9a61884 performance_tests: add tests for new Cryptonight variants (moneromooo-monero)
fff23bf7 CNv4 JIT compiler for x86-64 and tests (SChernykh)
3dde67d8 blockchain: add v10 fork heights (moneromooo-monero)
 2019-03-04 17:06:37 +02:00
Riccardo Spagni
8c53ac2dd1
Merge pull request #5132 
2dbc487e Add support for V10 protocol with BulletProofV2 and short amount. (cslashm)
63cc02c0 Fix dummy decryption in debug mode (cslashm)
f0e55ceb fix log namespace (cslashm)
460da140 New scheme key destination contrfol (cslashm)
 2019-03-04 14:58:45 +02:00
moneromooo-monero
0de14396b9
tests: add a CNv4 JIT test 2019-03-04 11:56:55 +00:00
moneromooo-monero
24d281c324
crypto: plug CNv4 JIT into cn_slow_hash 
Enabled by setting the MONERO_USE_CNV4_JIT env var to 1
 2019-03-04 11:56:55 +00:00
moneromooo-monero
78ab59ea44
crypto: clear cache after generating random program 2019-03-04 11:56:46 +00:00
SChernykh
fff23bf7c6
CNv4 JIT compiler for x86-64 and tests 
Minimalistic JIT code generator for random math sequence in CryptonightR.

Usage:
- Allocate writable and executable memory
- Call v4_generate_JIT_code with "buf" pointed to memory allocated on the previous step
- Call the generated code instead of "v4_random_math(code, r)", omit the "code" parameter
 2019-03-04 11:56:29 +00:00
moneromooo-monero
3dde67d82d
blockchain: add v10 fork heights 2019-03-04 11:56:22 +00:00
moneromooo-monero
a17da7202b
Print the reason why a notification spec failed to parse 2019-03-04 11:48:46 +00:00
moneromooo-monero
356d813799
blockchain: include number of discarded blocks in --reorg-notify 2019-03-04 11:48:44 +00:00
moneromooo-monero
4d598e3d4d
core: add a few more block rate window sizes 
The 10 minute one will never trigger for 0 blocks, as it's still
fairly likely to happen even without the actual hash rate changing
much, so we add a 20 minute window, where it will (for 0 blocks)
and a one hour window.
 2019-03-04 11:48:42 +00:00
moneromooo-monero
d4fb9641e0
core: add --block-rate-notify 
This runs a command whenever the block rate deviates too much
from the expectation
 2019-03-04 11:48:39 +00:00
moneromooo-monero
28b6dbf263
notify: fix tokenizing being too strict 2019-03-04 11:48:36 +00:00
moneromooo
807903bbbf
hardfork: fix fork determination for historical heights 2019-03-04 11:19:59 +00:00
Riccardo Spagni
1b4fa00d7c
Merge pull request #5126 
f1fb06b1 Fixed path to int-util.h (SChernykh)
9da0892b Adding cnv4-2 tweaks (SChernykh)
f51397b3 Cryptonight variant 4 aka CryptonightR (SChernykh)
 2019-03-04 12:10:16 +02:00
Riccardo Spagni
55305559c1
Merge pull request #5124 
b8787f43 ArticMine's new block weight algorithm (moneromooo-monero)
 2019-03-04 12:09:13 +02:00
Riccardo Spagni
35e0bf2e06
Merge pull request #5122 
52964501 ringct: fix v1 ecdhInfo serialization (moneromooo-monero)
 2019-03-04 12:08:26 +02:00
Riccardo Spagni
4f06639d63
Merge pull request #5120 
45b7df70 wallet_rpc_server: remove detached short payment ids support (moneromooo-monero)
 2019-03-04 12:07:40 +02:00
Riccardo Spagni
e62ae67d16
Merge pull request #5118 
49b2a48a simplewallet: tell the user to complain to the recipient (moneromooo-monero)
 2019-03-04 12:07:02 +02:00
moneromooo-monero
b8787f4302
ArticMine's new block weight algorithm 
This curbs runaway growth while still allowing substantial
spikes in block weight

Original specification from ArticMine:

here is the scaling proposal
Define: LongTermBlockWeight
Before fork:
LongTermBlockWeight = BlockWeight
At or after fork:
LongTermBlockWeight = min(BlockWeight, 1.4*LongTermEffectiveMedianBlockWeight)
Note: To avoid possible consensus issues over rounding the LongTermBlockWeight for a given block should be calculated to the nearest byte, and stored as a integer in the block itself. The stored LongTermBlockWeight is then used for future calculations of the LongTermEffectiveMedianBlockWeight and not recalculated each time.
Define:   LongTermEffectiveMedianBlockWeight
LongTermEffectiveMedianBlockWeight = max(300000, MedianOverPrevious100000Blocks(LongTermBlockWeight))
Change Definition of EffectiveMedianBlockWeight
From (current definition)
EffectiveMedianBlockWeight  = max(300000, MedianOverPrevious100Blocks(BlockWeight))
To (proposed definition)
EffectiveMedianBlockWeight  = min(max(300000, MedianOverPrevious100Blocks(BlockWeight)), 50*LongTermEffectiveMedianBlockWeight)
Notes:
1) There are no other changes to the existing penalty formula, median calculation, fees etc.
2) There is the requirement to store the LongTermBlockWeight of a block unencrypted in the block itself. This  is to avoid possible consensus issues over rounding and also to prevent the calculations from becoming unwieldy as we move away from the fork.
3) When the  EffectiveMedianBlockWeight cap is reached it is still possible to mine blocks up to 2x the EffectiveMedianBlockWeight by paying the corresponding penalty.

Note: the long term block weight is stored in the database, but not in the actual block itself,
since it requires recalculating anyway for verification.
 2019-03-04 09:33:58 +00:00
moneromooo-monero
fa2fbc3917
wallet2: fix mishandling rct outputs in coinbase tx 
Reported by cutcoin
 2019-03-03 18:55:12 +00:00
Joel
364516975a Simplify RPC endpoint, emoving second RPC endpoint generate_from_view_key 2019-03-02 23:14:35 +01:00
Nathan Dorfman
be6f426a3f rpc: Allow submitting tx as hex blob over ZMQ 2019-02-27 16:55:04 -07:00
moneromooo-monero
9c4d403ae0
dns_utils: use fallback if the default resolver does not support DNSSEC 2019-02-27 11:08:56 +00:00
moneromooo-monero
4921c79494
cn_deserialize: remove some unused code 2019-02-26 17:57:03 +00:00
moneromooo-monero
eef164f7cc
cryptonote_protocol_handler: search for syncing peers in "cruise mode" 
When all our outgoing peer slots are filled, we cycle one peer at
a time looking for syncing peers until we have at least two such
peers. This brings two advantages:

- Peers without incoming connections will find more syncing peers
that before, thereby strengthening network decentralization

- Peers will have more resistance to isolation attacks, as they
are more likely to find a "good" peer than they were before
 2019-02-26 12:45:28 +00:00
moneromooo-monero
7d88d8f27c
discontinue use of alloca 
NetBSD emits:
warning: Warning: reference to the libc supplied alloca(3); this most likely will not work. Please use the compiler provided version of alloca(3), by supplying the appropriate compiler flags (e.g. not -std=c89).

and man 3 alloca says:

       Normally,  gcc(1)  translates  calls  to  alloca()  with  inlined code.  This is not done when either the -ansi, -std=c89, -std=c99, or the
       -std=c11 option is given and the header <alloca.h> is not included.  Otherwise, (without an -ansi or -std=c* option) the glibc  version  of
       <stdlib.h> includes <alloca.h> and that contains the lines:

           #ifdef  __GNUC__
           #define alloca(size)   __builtin_alloca (size)
           #endif

It looks like alloca is a bad idea in modern C/C++, so we use
VLAs for C and std::vector for C++.
 2019-02-25 11:11:07 +00:00
xiphon
a54e81e572 daemon: add '--no-sync' arg to optionally disable blockchain sync 2019-02-25 03:22:14 +00:00
xiphon
551104fbf1 daemon: add --public-node mode, RPC port propagation over P2P 2019-02-25 02:40:23 +03:00
moneromooo-monero
8298f42e9d
miner: it can now autodetect the optimal number of threads 2019-02-23 12:22:32 +00:00
moneromooo-monero
b674728dfa
Better error when sending a tx with a too large extra field 2019-02-22 11:45:32 +00:00
moneromooo-monero
bb2aed8e4d
rpc: quantize db size up to 5 GB in restricted mode 2019-02-21 23:49:53 +00:00
moneromooo-monero
7c09882a27
dns_utils: remove MoneroPulse/checkpoints mention in TXT record code 
This code is used for more than just these
 2019-02-21 17:38:43 +00:00
Joel
c17c81881b Remove code duplication 2019-02-21 15:49:32 +01:00
moneromooo-monero
85088d9f85
db_lmdb: fix missing mdb_dbi_close in migration 
Fixed by hyc
 2019-02-21 09:52:30 +00:00
stoffu
3d2772a0d6
wallet-rpc: get balance for all accounts and subaddresses 2019-02-20 14:23:36 +09:00
Dusan Klinec
8630a028f2
wallet: fix payment ID decryption for construction data 2019-02-20 03:55:35 +01:00
Dusan Klinec
75e5aafdcb
device/trezor: dummy payment ID fix 2019-02-20 02:00:14 +01:00
Joel
acb14c1079 Add generate_from_view_key RPC method 2019-02-19 14:30:35 +01:00
Joel
7dd7a3b791 Add generate_from_keys RPC method 2019-02-19 14:13:01 +01:00
Jethro Grassie
8a1ff079ea
wallet-rpc: get transfers for all accounts and subaddresses 2019-02-17 22:21:45 -05:00
TheCharlatan
4a9257b464
Support docker for gitian builds 
Building with docker is arguably easier and more familiar to most people
than either kvm, or lxc.

This commit also relaxes the back compat requirement a bit. 32 bit linux
now uses glibc version 2.0. Also, the docker shell could not handle gcc arguments
containing spaces, so the explicit '-DFELT_TYPE' declaration was dropped.

Lastly, this removes some packages from the osx descriptor.
 2019-02-14 23:14:34 +01:00
moneromooo-monero
5c81a9f1a1
wallet_rpc_server: add a validate_address RPC 2019-02-14 21:01:11 +00:00
SChernykh
f1fb06b137 Fixed path to int-util.h 2019-02-14 20:46:56 +01:00
SChernykh
9da0892b10 Adding cnv4-2 tweaks 
Co-Authored-By: Lee Clagett <vtnerd@users.noreply.github.com>
 2019-02-14 20:42:50 +01:00
SChernykh
f51397b306 Cryptonight variant 4 aka CryptonightR 
It introduces random integer math into the main loop.
 2019-02-14 11:29:54 +01:00
moneromooo-monero
1f5680c8db
simplewallet: add help for ask-password options 2019-02-14 09:21:22 +00:00
moneromooo-monero
c7c74cafec
simplewallet: mark confirm-missing-payment-id as obsolete 2019-02-14 09:21:22 +00:00
Dusan Klinec
a3973fc95f debug compilation fix: net lib missing common deps 
```
Undefined symbols for architecture x86_64:
  "common_category()", referenced from:
      make_error_code(common_error) in parse.cpp.o
      make_error_code(common_error) in tor_address.cpp.o
  "boost::system::detail::system_category_ncx()", referenced from:
      boost::system::system_category() in parse.cpp.o
      boost::system::system_category() in socks.cpp.o
      boost::system::system_category() in libepee.a(net_utils_base.cpp.o)
  "boost::system::detail::generic_category_ncx()", referenced from:
      boost::system::generic_category() in parse.cpp.o
      boost::system::generic_category() in socks.cpp.o
      boost::system::generic_category() in tor_address.cpp.o
      boost::system::generic_category() in libepee.a(string_tools.cpp.o)
      boost::system::generic_category() in libepee.a(net_utils_base.cpp.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[3]: *** [src/net/libnet.dylib] Error 1
make[2]: *** [src/net/CMakeFiles/net.dir/all] Error 2
```
 2019-02-13 23:37:46 +01:00
Doyle
d2c95ab941 Don't decrypt keys in view only wallets in wallet_keys_unlocker 2019-02-13 15:36:49 +11:00
italocoin
de32dcea1d Human readable message if maximum outputs reached 2019-02-10 09:51:20 -05:00
cslashm
2dbc487ec0 Add support for V10 protocol with BulletProofV2 and short amount. 2019-02-08 17:02:55 +01:00
cslashm
63cc02c08d Fix dummy decryption in debug mode 2019-02-08 17:02:55 +01:00
cslashm
f0e55cebf7 fix log namespace 2019-02-08 17:02:55 +01:00
cslashm
460da140ec New scheme key destination contrfol 
Implies protocol version management.
 2019-02-08 17:02:44 +01:00
moneromooo-monero
49b2a48a46
simplewallet: tell the user to complain to the recipient 
for long payment ids
 2019-02-03 10:34:07 +00:00
moneromooo-monero
529645014c
ringct: fix v1 ecdhInfo serialization 
The change made for v2 broke v1, and we have no way to know which
version we're serializing here. However, since we don't actually
care about space savings in this case, we continue serialiazing
both mask and amount.
 2019-02-03 10:33:10 +00:00
moneromooo-monero
2456945408
epee: add SSL support 
RPC connections now have optional tranparent SSL.

An optional private key and certificate file can be passed,
using the --{rpc,daemon}-ssl-private-key and
--{rpc,daemon}-ssl-certificate options. Those have as
argument a path to a PEM format private private key and
certificate, respectively.
If not given, a temporary self signed certificate will be used.

SSL can be enabled or disabled using --{rpc}-ssl, which
accepts autodetect (default), disabled or enabled.

Access can be restricted to particular certificates using the
--rpc-ssl-allowed-certificates, which takes a list of
paths to PEM encoded certificates. This can allow a wallet to
connect to only the daemon they think they're connected to,
by forcing SSL and listing the paths to the known good
certificates.

To generate long term certificates:

openssl genrsa -out /tmp/KEY 4096
openssl req -new -key /tmp/KEY -out /tmp/REQ
openssl x509 -req -days 999999 -sha256 -in /tmp/REQ -signkey /tmp/KEY -out /tmp/CERT

/tmp/KEY is the private key, and /tmp/CERT is the certificate,
both in PEM format. /tmp/REQ can be removed. Adjust the last
command to set expiration date, etc, as needed. It doesn't
make a whole lot of sense for monero anyway, since most servers
will run with one time temporary self signed certificates anyway.

SSL support is transparent, so all communication is done on the
existing ports, with SSL autodetection. This means you can start
using an SSL daemon now, but you should not enforce SSL yet or
nothing will talk to you.
 2019-02-02 20:05:33 +00:00
moneromooo-monero
45b7df703b
wallet_rpc_server: remove detached short payment ids support 2019-02-02 18:53:14 +00:00
Tom Smeding
fec359a641 cryptonote: Fix enum check in expand_transaction_2 
This was noticed because GCC warned about using an enum value in a
boolean context.
 2019-02-01 16:44:58 +01:00
Tom Smeding
9bf0e53751 cryptonote: Add const-qualifier on comparison functor 
The original code did not compile with GCC 8.2.1 in C++17 mode, since
comparison functions for std::set's must be invocable as const.
 2019-02-01 16:44:56 +01:00
Tom Smeding
5d2fdc2e8c serialization: Use pos_type instead of streampos 
According to [1], the ios_base::streampos member type is deprecated, and
removed in C++17. This type was an alias for pos_type, which this commit
uses instead.

[1]: https://en.cppreference.com/w/cpp/io/ios_base
 2019-02-01 16:44:55 +01:00
moneromooo-monero
6a3608d3d2
cryptonote_protocol_handler: pad tx messages when using tor/i2p 2019-01-30 23:17:45 +00:00
Jethro Grassie
123fc2a25a
i2p: initial support 2019-01-30 13:37:45 -05:00
moneromooo-monero
1c9d5285d1
blockchain_prune: don't prune before v10 
This uses system time since it doesn't see the p2p network,
so is not 100% accurate
 2019-01-30 16:32:14 +00:00
Riccardo Spagni
31bdf7bd11
Merge pull request #4988 
973403bc Adding initial support for broadcasting transactions over Tor (Lee Clagett)
 2019-01-29 16:47:17 +02:00
Riccardo Spagni
227bf1407e
Merge pull request #5104 
dc0b86ab block_queue: fix late sanity check off by one (moneromooo-monero)
 2019-01-29 16:45:47 +02:00
Lee Clagett
973403bc9f Adding initial support for broadcasting transactions over Tor 
- Support for ".onion" in --add-exclusive-node and --add-peer
  - Add --anonymizing-proxy for outbound Tor connections
  - Add --anonymous-inbounds for inbound Tor connections
  - Support for sharing ".onion" addresses over Tor connections
  - Support for broadcasting transactions received over RPC exclusively
    over Tor (else broadcast over public IP when Tor not enabled).
 2019-01-28 23:56:33 +00:00
moneromooo-monero
dc0b86ab4b
block_queue: fix late sanity check off by one 2019-01-28 22:17:43 +00:00
Riccardo Spagni
1e5cd3b35a
Merge pull request #5062 
acfff8d0 rpc: fix internal daemon calls in restricted rpc getting partial data (moneromooo-monero)
 2019-01-28 21:40:11 +02:00
Riccardo Spagni
40bb66cc1e
Merge pull request #5053 
23813c71 blockchain: add --reorg-notify (moneromooo-monero)
f6db59b0 notify: handle arbitrary tags (moneromooo-monero)
ff959216 notify: warn if the spec contains one of '"\ (moneromooo-monero)
13852678 common: set MONERO_DEFAULT_LOG_CATEGORY for notify and spawn (moneromooo-monero)
 2019-01-28 21:35:46 +02:00
moneromooo-monero
acfff8d0ce
rpc: fix internal daemon calls in restricted rpc getting partial data 2019-01-28 19:35:20 +00:00
Riccardo Spagni
23c7663167
Merge pull request #5080 
d294a577 daemon: extend 'print_pl' command, optional filter by type and limit (xiphon)
 2019-01-28 21:34:17 +02:00
Riccardo Spagni
c07c907114
Merge pull request #5074 
b8c5f550 wallet api: don't truncate address in subaddress_account (selsta)
 2019-01-28 21:33:33 +02:00
moneromooo-monero
23813c7160
blockchain: add --reorg-notify 
This will trigger if a reorg is seen. This may be used to do things
like stop automated withdrawals on large reorgs.

%s is replaced by the height at the split point
%h is replaced by the height of the new chain
%n is replaced by the number of new blocks after the reorg
 2019-01-28 19:32:31 +00:00
moneromooo-monero
f6db59b011
notify: handle arbitrary tags 2019-01-28 19:32:28 +00:00
moneromooo-monero
ff95921668
notify: warn if the spec contains one of '"\ 
These aren't processed as a shell does, so this may surprise users
 2019-01-28 19:32:25 +00:00
moneromooo-monero
13852678e1
common: set MONERO_DEFAULT_LOG_CATEGORY for notify and spawn 2019-01-28 19:32:22 +00:00
Riccardo Spagni
4f104a0dc3
Merge pull request #5069 
2112060d wallet2: fix duplicate tx notifications for pool txes (moneromooo-monero)
 2019-01-28 21:32:14 +02:00
Riccardo Spagni
b7719022fd
Merge pull request #5068 
96e35506 wallet2: fix incorrect patch for determining fork rules (moneromooo-monero)
 2019-01-28 21:31:47 +02:00
Riccardo Spagni
f2ca4e3205
Merge pull request #5063 
11227e0b mnemonics: compare canonical words (lowercase) (moneromooo-monero)
 2019-01-28 21:30:26 +02:00
Riccardo Spagni
756ed760f7
Merge pull request #5056 
8258a9e7 wallet: do not check txpool in background mode (moneromooo-monero)
 2019-01-28 21:27:34 +02:00
Riccardo Spagni
77e96d0948
Merge pull request #5055 
6c060e6a device: proper handling of user input (selsta)
 2019-01-28 21:27:10 +02:00
Riccardo Spagni
0c970fde1c
Merge pull request #5054 
93c21644 device_ledger: remove full_name variable (selsta)
 2019-01-28 21:26:44 +02:00
Riccardo Spagni
0daa00e035
Merge pull request #5052 
b6534c40 ringct: remove unused senderPk from ecdhTuple (moneromooo-monero)
7d375981 ringct: the commitment mask is now deterministic (moneromooo-monero)
99d946e6 ringct: encode 8 byte amount, saving 24 bytes per output (moneromooo-monero)
cdc3ccec ringct: save 3 bytes on bulletproof size (moneromooo-monero)
f931e16c add a bulletproof version, new bulletproof type, and rct config (moneromooo-monero)
 2019-01-28 21:24:55 +02:00
moneromooo-monero
1eef056588
performance_tests: better stats, and keep track of timing history 2019-01-28 15:45:37 +00:00
moneromooo-monero
eec792764d
blockchain: fix default genesis block timestamp 2019-01-26 21:39:00 +00:00
moneromooo-monero
b6534c40e6
ringct: remove unused senderPk from ecdhTuple 
This was an early ringct field, which was never used in production
 2019-01-22 23:17:42 +00:00
moneromooo-monero
7d37598158
ringct: the commitment mask is now deterministic 
saves space in the tx and is safe

Found by knaccc
 2019-01-22 23:17:39 +00:00
moneromooo-monero
99d946e619
ringct: encode 8 byte amount, saving 24 bytes per output 
Found by knaccc
 2019-01-22 23:17:31 +00:00
moneromooo-monero
cdc3ccec5f
ringct: save 3 bytes on bulletproof size 
Found by luigi1111
 2019-01-22 23:17:27 +00:00
moneromooo-monero
f931e16c6e
add a bulletproof version, new bulletproof type, and rct config 
This makes it easier to modify the bulletproof format
 2019-01-22 23:17:24 +00:00
moneromooo-monero
b750fb27b0
Pruning 
The blockchain prunes seven eighths of prunable tx data.
This saves about two thirds of the blockchain size, while
keeping the node useful as a sync source for an eighth
of the blockchain.

No other data is currently pruned.

There are three ways to prune a blockchain:

- run monerod with --prune-blockchain
- run "prune_blockchain" in the monerod console
- run the monero-blockchain-prune utility

The first two will prune in place. Due to how LMDB works, this
will not reduce the blockchain size on disk. Instead, it will
mark parts of the file as free, so that future data will use
that free space, causing the file to not grow until free space
grows scarce.

The third way will create a second database, a pruned copy of
the original one. Since this is a new file, this one will be
smaller than the original one.

Once the database is pruned, it will stay pruned as it syncs.
That is, there is no need to use --prune-blockchain again, etc.
 2019-01-22 20:30:51 +00:00
moneromooo-monero
9d58749b85
wallet2: fix hashchain going out of sync on refresh error 2019-01-19 16:47:13 +00:00
moneromooo-monero
1bc5f9fa4b
bulletproofs: speed up vector_power_sum 
found by sarang
 2019-01-19 00:18:34 +00:00
moneromooo-monero
d78addcbc0
db_lmdb: don't unnecessarily cast to double on the way to uint64_t 2019-01-19 00:03:04 +00:00
Riccardo Spagni
4e72384318
Merge pull request #5008 
c6d38718 core: include a dummy encrypted payment id when no payment is used (moneromooo-monero)
b7441c4a core, wallet: remember original text version of destination address (moneromooo-monero)
a9b1c04a crptonote_core: do not error out sending unparsable extra field (moneromooo-monero)
 2019-01-18 19:12:58 +02:00
Riccardo Spagni
5753d71922
Merge pull request #5050 
07cb574c ringct: remove duplicate rv.mixRing = mixRing; in genRctSimple (stoffu)
 2019-01-18 19:02:01 +02:00
Riccardo Spagni
8ba36cf6d4
Merge pull request #5049 
0a29660f message_store: init me field (moneromooo-monero)
 2019-01-18 19:01:23 +02:00
Riccardo Spagni
416b6719bd
Merge pull request #5047 
584126d1 i18n: filter LANG/LC_LANG for valid characters, and handle @ (moneromooo-monero)
 2019-01-18 19:01:02 +02:00
Riccardo Spagni
54eb3318e2
Merge pull request #5048 
a67b77a9 blockchain: don't propagate exception past dtor (moneromooo-monero)
 2019-01-18 19:00:47 +02:00
moneromooo-monero
c6d387184e
core: include a dummy encrypted payment id when no payment is used 
For better transaction uniformity, even though this wastes space.
 2019-01-18 16:58:50 +00:00
moneromooo-monero
b7441c4a32
core, wallet: remember original text version of destination address 2019-01-18 16:58:47 +00:00
moneromooo-monero
a9b1c04acf
crptonote_core: do not error out sending unparsable extra field 
extra is arbitrary, and the user may well want to send custom data
 2019-01-18 16:58:45 +00:00
Riccardo Spagni
13b12973d1
Merge pull request #5037 
51b0625e simplewallet: improve punctuation in user visible string (selsta)
 2019-01-18 09:25:59 +02:00
Riccardo Spagni
aa5b0c7f71
Merge pull request #5028 
464097e5 blockchain_ancestry: allow getting ancestry of a single output (moneromooo-monero)
a6216d1a blockchain_db: allow getting output keys without commitment (moneromooo-monero)
 2019-01-18 09:25:34 +02:00
Riccardo Spagni
f3368acef5
Merge pull request #5020 
1ef79b43 simplewallet: disable long payment ids by default (moneromooo-monero)
 2019-01-18 09:25:18 +02:00
Riccardo Spagni
3c80562861
Merge pull request #5014 
0debe7d7 wallet2: remember which output keys map to which key images (moneromooo-monero)
 2019-01-18 09:24:19 +02:00
Riccardo Spagni
4fb9cfa017
Merge pull request #4971 
15904610 simplewallet: remove extra colon in a few calls to input_secure_line (stoffu)
247dab73 simplewallet: avoid conversion to string in input_secure_line (stoffu)
bf9ef7ad simplewallet: factor yesno hint into input_line (stoffu)
 2019-01-18 09:23:03 +02:00
xiphon
d294a577fa daemon: extend 'print_pl' command, optional filter by type and limit 2019-01-18 01:32:18 +00:00
stoffu
1717e63551
simplewallet: fix help text of rescan_bc to mention the "hard" option 2019-01-18 09:51:44 +09:00
stoffu
1590461005
simplewallet: remove extra colon in a few calls to input_secure_line 2019-01-18 09:48:54 +09:00
stoffu
247dab7304
simplewallet: avoid conversion to string in input_secure_line 2019-01-18 09:48:52 +09:00
stoffu
bf9ef7adb6
simplewallet: factor yesno hint into input_line 2019-01-18 09:48:48 +09:00
moneromooo-monero
464097e592
blockchain_ancestry: allow getting ancestry of a single output 
This involved a reorg of the code, to factor and speedup some bits,
as well as using the cache for all modes, and making both modes
usable in the same run.
 2019-01-16 20:13:12 +00:00
moneromooo-monero
a6216d1ac2
blockchain_db: allow getting output keys without commitment 
Since the commitment has to be calculated for non rct outputs,
it slows down a lot unnecessarily if we don't need it
 2019-01-16 20:13:08 +00:00
moneromooo-monero
1ef79b430f
simplewallet: disable long payment ids by default 
unless --long-payment-id-support is used
 2019-01-16 20:06:04 +00:00
moneromooo-monero
0debe7d7d3
wallet2: remember which output keys map to which key images 
This allows filling in transfer_details when a cold signed tx
gets seen in a block next
 2019-01-16 19:58:13 +00:00
selsta
51b0625e00 simplewallet: improve punctuation in user visible string 2019-01-16 20:45:39 +01:00
Riccardo Spagni
6285c43ffc
Merge pull request #5042 
c1081091 simplewallet: Show new address after going multisig (rbrunner7)
 2019-01-16 21:42:17 +02:00
Riccardo Spagni
8e4c0de46a
Merge pull request #5035 
53fcd159 simplewallet: don't subtract 1 to estimate blockchain height (moneromooo-monero)
 2019-01-16 21:40:56 +02:00
Riccardo Spagni
c84d559fb1
Merge pull request #5034 
13785ec9 wallet api/device: set estimated restore height if none is provided (selsta)
 2019-01-16 21:40:20 +02:00
Riccardo Spagni
dc726f4b3b
Merge pull request #5032 
5ee6f037 blockchain: fix wrong hf version when popping multiple blocks (moneromooo-monero)
634d359a blockchain: use the version passed as parameter, not a new one (moneromooo-monero)
94a375d5 hardfork: remove batch transactions setup (moneromooo-monero)
 2019-01-16 21:40:06 +02:00
Riccardo Spagni
e59813c3d7
Merge pull request #5029 
d1b3990d p2p: don't stop the idle thread when no gray peers are found (moneromooo-monero)
 2019-01-16 21:39:19 +02:00
Riccardo Spagni
3eb96fa512
Merge pull request #5027 
9092fc4b wallet: do not display daemon controlled text if untrusted (moneromooo-monero)
 2019-01-16 21:38:15 +02:00
Riccardo Spagni
17878369f9
Merge pull request #5019 
65ce387c daemon: add a +hex option to print_block (moneromooo-monero)
 2019-01-16 21:36:08 +02:00
Riccardo Spagni
46fcae717a
Merge pull request #5018 
8bd71677 simplewallet: remove ability to transfer with detached short payment ids (moneromooo-monero)
 2019-01-16 21:35:48 +02:00
Riccardo Spagni
a80978e699
Merge pull request #5015 
6f2081f8 cryptonote_core: revert extra_tx_map (moneromooo-monero)
 2019-01-16 21:32:14 +02:00
Riccardo Spagni
00090aae7f
Merge pull request #5012 
d7354c78 wallet_rpc_server: add all field to export_key_images (moneromooo-monero)
 2019-01-16 21:31:40 +02:00
Riccardo Spagni
f8a10bcc07
Merge pull request #5009 
5e10dee3 simplewallet: fix show_transfers colouring, and add red for failed (moneromooo-monero)
 2019-01-16 21:30:52 +02:00
Riccardo Spagni
0673ed54cf
Merge pull request #5006 
7c58421c blockchain_blackball: make log file name consistent with executable (stoffu)
 2019-01-16 19:29:29 +02:00
Riccardo Spagni
e0c107ee51
Merge pull request #5004 
de9dcdd1 wallet2: finalize_multisig now rejects non N-1/N multisig wallets (moneromooo-monero)
 2019-01-16 19:28:51 +02:00
Riccardo Spagni
3e9bb9626a
Merge pull request #5001 
a5ffc2d5 Remove boost::lexical_cast for uuid and unused uuid function (Lee Clagett)
 2019-01-16 19:27:13 +02:00
Riccardo Spagni
8e04070d9d
Merge pull request #4995 
99765b21 Remove unused hash in export_key_images (doy-lee)
 2019-01-16 19:08:48 +02:00
Riccardo Spagni
47213e2519
Merge pull request #4994 
c5e0539c device/trezor: store tx_prefix_hash in tx key aux (Dusan Klinec)
 2019-01-16 19:08:13 +02:00
Riccardo Spagni
1f71bfc8d0
Merge pull request #4993 
b8342dd5 blockchain: fix block rate check for empty blockchains (moneromooo-monero)
 2019-01-16 19:07:55 +02:00
Riccardo Spagni
538043bdcd
Merge pull request #4987 
841a6acd wallet2: fix accessing unwound stack on exception (moneromooo-monero)
 2019-01-16 19:07:13 +02:00
Riccardo Spagni
8bfce660a5
Merge pull request #4986 
d24c325c daemon: print human friendly timestamp too (moneromooo-monero)
 2019-01-16 19:06:53 +02:00
Riccardo Spagni
63b5c933ef
Merge pull request #4985 
808a1f1e wallet2: cut down on the number of useless derivation threads (moneromooo-monero)
 2019-01-16 19:06:31 +02:00
Riccardo Spagni
9d57ee9ff6
Merge pull request #4984 
008647d7 blockchain_db: speedup tx output gathering (moneromooo-monero)
 2019-01-16 19:06:07 +02:00
Riccardo Spagni
cb996d15c5
Merge pull request #4981 
60b35c91 Add --restore-date param (Howard Chu)
 2019-01-16 19:05:31 +02:00
Riccardo Spagni
a193f1e236
Merge pull request #4980 
219548f2 Sync hashchain bug fixed (naughtyfox)
 2019-01-16 19:05:09 +02:00
Riccardo Spagni
b565115c84
Merge pull request #4979 
611db08a Wallet: Initialize members without default ctor. (Tadeas Moravec)
 2019-01-16 19:04:45 +02:00
Riccardo Spagni
846362842c
Merge pull request #4976 
85665003 epee: better network buffer data structure (moneromooo-monero)
 2019-01-16 19:04:22 +02:00
Riccardo Spagni
c07969d0d1
Merge pull request #4973 
aaafa8a9 ringct: avoid repeated point conversion (moneromooo-monero)
 2019-01-16 19:03:45 +02:00
selsta
b8c5f550c1
wallet api: don't truncate address in subaddress_account 
Same behaviour as subaddress.cpp now.
 2019-01-15 22:19:50 +01:00
moneromooo-monero
96e35506e9
wallet2: fix incorrect patch for determining fork rules 
Half of the patch was correct, but half was introducing another bug,
where a wallet asking for a fork that the daemon does not know about
yet would decide to use those rules.
 2019-01-13 14:48:16 +00:00
moneromooo-monero
2112060d03
wallet2: fix duplicate tx notifications for pool txes 2019-01-13 14:47:42 +00:00
moneromooo-monero
11227e0ba2
mnemonics: compare canonical words (lowercase) 2019-01-11 16:45:48 +00:00
selsta
6c060e6aaa
device: proper handling of user input 
(1) If the user denies something on the Ledger,
    a proper error message is now shown.
(2) Ledger doesn't time out anymore while waiting
    on user input.
(3) Lower the timeout to 2 seconds, this is enough for
    normal Ledger <-> System communication.
 2019-01-09 15:45:06 +01:00
moneromooo-monero
8258a9e7a9
wallet: do not check txpool in background mode 
This avoids the constant message about needed to run refresh
to enter a password.
Also mention the txpool when asking for the password if the
reason is a pool tx.
 2019-01-09 11:21:39 +00:00
selsta
93c2164434
device_ledger: remove full_name variable 
This variable was never set, resulting in the
device name always showing as "disconnected".
 2019-01-09 05:33:49 +01:00
moneromooo-monero
584126d15b
i18n: filter LANG/LC_LANG for valid characters, and handle @ 
If there are more valid characters, add them in, I did not find
an actual list.
 2019-01-08 16:03:30 +00:00
stoffu
07cb574ca4
ringct: remove duplicate rv.mixRing = mixRing; in genRctSimple 2019-01-08 11:51:35 +09:00
Riccardo Spagni
094b0c4d00
Merge pull request #5045 
050ee521 wallet_api: fix usage of LOG_ERROR (moneromooo-monero)
 2019-01-07 21:27:34 +02:00
Riccardo Spagni
4902b2ad3d
Merge pull request #5016 
434a147b blocks: fix checkpoint code generation on OpenBSD (moneromooo-monero)
 2019-01-07 21:27:14 +02:00
Riccardo Spagni
53fba1455c
Merge pull request #5007 
68f095f0 message_store: fix error message adding const char * with offset (moneromooo-monero)
 2019-01-07 21:26:52 +02:00
moneromooo-monero
0a29660f5c
message_store: init me field 
Coverity 190651
 2019-01-07 16:41:34 +00:00
moneromooo-monero
a67b77a9eb
blockchain: don't propagate exception past dtor 
Coverity 190660
 2019-01-07 16:32:50 +00:00
moneromooo-monero
050ee52162
wallet_api: fix usage of LOG_ERROR 2019-01-07 11:57:10 +00:00
moneroexamples
ec68cf822f Make get_output_key method const 
get_output_key method is commonly used when working with txs and their key images. Because the method is not const, passing blockchain object though const& or pointers to const is not possible in this context. This is especially problematic in external projects (e.g., projects in moneroexamples) that use monero C++ api to operate on the blockchain and txs.

Thus, having get_output_key method will simplify moving blockchain object around through const references and pointers to const objects.
 2019-01-07 05:53:14 +08:00
Riccardo Spagni
b67eb481a7
Merge pull request #4956 
2d7b0236 wallet2: clear all payments on soft rescan_bc (moneromooo-monero)
 2019-01-06 20:40:06 +02:00
Riccardo Spagni
be625a95af
Merge pull request #4954 
93c59b29 perf_timer: check allowed categories before logging (moneromooo-monero)
6a507dab perf_timer: add a way to get and reset the current time (moneromooo-monero)
c1581a5b perf_timer: only log to file (moneromooo-monero)
 2019-01-06 20:39:29 +02:00
Riccardo Spagni
577a8f5c84
Merge pull request #4952 
570dd369 p2p: use vector instead of list for peer lists (moneromooo-monero)
 2019-01-06 20:39:07 +02:00
Riccardo Spagni
13b006137c
Merge pull request #4949 
5464725a protocol: change standby mode to not wait sleeping (moneromooo-monero)
85807dfb add a once_a_time_milliseconds class (moneromooo-monero)
 2019-01-06 20:37:51 +02:00
Riccardo Spagni
ad1eb3338c
Merge pull request #4938 
a13eb0a1 epee: speed up string matching a bit (moneromooo-monero)
3a3858dc epee: avoid string allocation when parsing a pod from string (moneromooo-monero)
 2019-01-06 20:36:46 +02:00
rbrunner7
c108109102 simplewallet: Show new address after going multisig 2019-01-04 16:33:02 +01:00
selsta
13785ec96b
wallet api/device: set estimated restore height if none is provided 2019-01-02 11:25:49 +01:00
moneromooo-monero
53fcd15953
simplewallet: don't subtract 1 to estimate blockchain height 
in case it returns 0, and other uses don't, plus it's a estimation anyway.
 2019-01-02 00:55:19 +00:00
moneromooo-monero
5ee6f03742
blockchain: fix wrong hf version when popping multiple blocks 
Since we keep track of the hf version in the db, we pick it up
from there instead of doing the full reorg call, which is quite
expensive
 2019-01-01 18:28:01 +00:00
moneromooo-monero
634d359a84
blockchain: use the version passed as parameter, not a new one 2019-01-01 18:28:01 +00:00
moneromooo-monero
94a375d559
hardfork: remove batch transactions setup 
This is now default, so it spares us the warnings
 2019-01-01 18:28:01 +00:00
moneromooo-monero
5dc590cbdb
wallet2: speedup output tracking 
It can get heavy for large wallets
 2018-12-31 23:57:54 +00:00
moneromooo-monero
db3f2a91fa
wallet: optionally keep track of owned outputs uses 2018-12-31 23:57:51 +00:00
luigi1111
e344d93ce7
Merge pull request #4960 
b56b5b5 ignore child process when exec (jtgrassie)
 2018-12-31 16:32:12 -06:00
luigi1111
53760ee044
Merge pull request #4957 
0e2f5cb perf_timer: make all logs Info level (moneromooo-monero)
 2018-12-31 16:30:47 -06:00
luigi1111
1aaa82cb1a
Merge pull request #4955 
25e5a85 singleton: fix missing *this return value in operator= (monermooo-monero)
 2018-12-31 16:28:49 -06:00
luigi1111
61c0083105
Merge pull request #4953 
dbbb3ce cryptonote: don't serialize for blob size if already known (moneromooo-monero)
 2018-12-31 16:26:22 -06:00
luigi1111
a872a2a41a
Merge pull request #4948 
1d892ec simplewallet: donate command validate amount (selsta)
 2018-12-31 16:10:30 -06:00
luigi1111
69e8567c0e
Merge pull request #4946 
6644b9b blockchain_db: remove a couple unused functions (moneromooo-monero)
ce594f5 blockchain_db: allocate known size vector only once (moneromooo-monero)
8332698 db_lmdb: inline check_open, it's trivial and called everywhere (moneromooo-monero)
5511563 db_lmdb: avoid pointless division (moneromooo-monero)
d1efe3d cryptonote: set tx hash on newly parsed txes when known (moneromooo-monero)
9cc68a2 tx_pool: add a few std::move where it can make a difference (moneromooo-monero)
 2018-12-31 16:06:50 -06:00
luigi1111
9c2d671397
Merge pull request #4945 
e37154a build: protobuf dependency fixes, libusb build (ph4r05)
 2018-12-31 15:53:59 -06:00
luigi1111
6e4e228461
Merge pull request #4944 
1505dd3 util: set MONERO_DEFAULT_LOG_CATEGORY (moneromooo-monero)
db57374 util: use fcntl instead of flock, for compatibility (moneromooo-monero)
 2018-12-31 15:52:17 -06:00
luigi1111
c7af379d29
Merge pull request #4940 
9e64a71 blockchain: call deinit in dtor (moneromooo-monero)
 2018-12-31 15:44:49 -06:00
luigi1111
3adac4ee2b
Merge pull request #4929 
5a76933 Add glibc back compat code (TheCharlatan)
 2018-12-31 15:31:01 -06:00
luigi1111
6d3caaff70
Merge pull request #4928 
affff94 blockchain: fix race between two external mining threads (moneromooo-monero)
 2018-12-31 15:28:25 -06:00
luigi1111
a7ff63ec77
Merge pull request #4898 
e6f026e Simplewallet: Unify usage messages. (tmoravec)
 2018-12-31 15:15:46 -06:00
luigi1111
c93c638199
Merge pull request #4864 
707c2f8 Remove -Werror (moneromooo-monero)
 2018-12-31 15:13:59 -06:00
moneromooo-monero
d1b3990d40
p2p: don't stop the idle thread when no gray peers are found 2018-12-30 19:32:38 +00:00
moneromooo-monero
9092fc4bfd
wallet: do not display daemon controlled text if untrusted 2018-12-30 01:32:57 +00:00
moneromooo-monero
8bd716777e
simplewallet: remove ability to transfer with detached short payment ids 
It seemed like a good idea at the time
 2018-12-27 00:45:04 +00:00
moneromooo-monero
65ce387c93
daemon: add a +hex option to print_block 2018-12-26 17:55:28 +00:00
moneromooo-monero
d24c325c7d
daemon: print human friendly timestamp too 2018-12-26 14:01:18 +00:00
moneromooo-monero
434a147b57
blocks: fix checkpoint code generation on OpenBSD 
Its od outputs small decimals with leading 0, which means octal in C
 2018-12-25 19:11:39 +00:00
moneromooo-monero
6f2081f867
cryptonote_core: revert extra_tx_map 
While the lookups are faster, the zeroCommit calls have to be
done again when storing the new outputs in the db, which ends
up making the whole thing slower after all, and the ways this
can be cached aren't very nice code wise, so let's forget it
since the gains aren't very large anyway.
 2018-12-25 15:19:41 +00:00
moneromooo-monero
d7354c7864
wallet_rpc_server: add all field to export_key_images 
To use if you want all key images, not just the ones for
recently imported outputs
 2018-12-24 13:00:29 +00:00
Tadeas Moravec
e6f026e530
Simplewallet: Unify usage messages. 
Help messages describe the commands usage. When users run the command
with wrong arguments, it usually helpfully offers the usage, too.
Unfortunately, these two usage messages were duplicated in the code and
started to get out of sync.

Fixing with constant strings.
 2018-12-23 20:12:50 +00:00
moneromooo-monero
85665003a7
epee: better network buffer data structure 
avoids pointless allocs and memcpy
 2018-12-23 16:46:07 +00:00
moneromooo-monero
5e10dee3ea
simplewallet: fix show_transfers colouring, and add red for failed 
Also add the type back, as it was somehow weirdly split into
two different fields, one being a union...
 2018-12-23 15:15:55 +00:00
Lee Clagett
a5ffc2d5ad Remove boost::lexical_cast for uuid and unused uuid function 2018-12-23 11:11:30 +00:00
moneromooo-monero
68f095f059
message_store: fix error message adding const char * with offset 2018-12-22 15:52:10 +00:00
stoffu
7c58421c79
blockchain_blackball: make log file name consistent with executable 2018-12-22 14:46:35 +09:00
moneromooo-monero
de9dcdd179
wallet2: finalize_multisig now rejects non N-1/N multisig wallets 2018-12-21 23:41:16 +00:00
doy-lee
99765b218e Remove unused hash in export_key_images 2018-12-19 14:45:13 +11:00
Dusan Klinec
c5e0539cb5
device/trezor: store tx_prefix_hash in tx key aux 
- tx_prefix_hash is required in the key derivation for decryption of the tx keys
 2018-12-18 22:20:18 +01:00
moneromooo-monero
b8342dd52c
blockchain: fix block rate check for empty blockchains 2018-12-18 18:47:54 +00:00
Dusan Klinec
e37154a879
build: protobuf dependency fixes, libusb build 
- docker protobuf dependencies, cross-compilation
- device/trezor protobuf build fixes, try_compile
- libusb built under all platforms, used by trezor for direct connect
 2018-12-18 16:50:19 +01:00
moneromooo-monero
008647d7eb
blockchain_db: speedup tx output gathering 
We know all the data we'll want for getblocks.bin is contiguous
 2018-12-18 11:55:21 +00:00
moneromooo-monero
808a1f1e8a
wallet2: cut down on the number of useless derivation threads 2018-12-16 18:31:10 +00:00
moneromooo-monero
841a6acda2
wallet2: fix accessing unwound stack on exception 2018-12-16 18:30:02 +00:00
Howard Chu
60b35c91b9
Add --restore-date param 
Estimate restore height from given date
Check date format early, error out early if invalid
 2018-12-14 19:11:35 +00:00
naughtyfox
219548f299 Sync hashchain bug fixed 2018-12-14 17:42:11 +03:00
Tadeas Moravec
611db08a00
Wallet: Initialize members without default ctor. 
Found by Coverity (188336 in Anonimal's Coverity account).
 2018-12-14 13:45:41 +00:00
rbrunner7
1ebcd7b9b0 MMS (Multisig Messaging System): Initial version 2018-12-12 21:49:20 +01:00
moneromooo-monero
aaafa8a946
ringct: avoid repeated point conversion 2018-12-12 12:48:10 +00:00
Riccardo Spagni
6bc0c7e685
Merge pull request #4927 
6456cb41 Bulletproof: Initialize members in default construtor. (Tadeas Moravec)
 2018-12-12 12:01:31 +02:00
Riccardo Spagni
5e9225e637
Merge pull request #4925 
ab783b17 easylogging++: ensure logger is initialized before main (moneromooo-monero)
9b69a0ae daemon: print monero version at startup when calling a detached daemon (moneromooo-monero)
4d71d463 mlocker: remove early page size log (moneromooo-monero)
 2018-12-12 12:01:18 +02:00
Riccardo Spagni
51874e5a40
Merge pull request #4924 
0c5dd316 cryptonote: add a set_null for transaction_prefix (moneromooo-monero)
 2018-12-12 12:00:50 +02:00
Riccardo Spagni
fe3c8c9682
Merge pull request #4923 
aba9a9c2 daemon: stop miner before we bring the whole thing down (moneromooo-monero)
 2018-12-12 12:00:37 +02:00
Riccardo Spagni
e9aa886d9e
Merge pull request #4921 
ac665418 ringct: fix dummy bulletproofs on ledger in fake mode (moneromooo-monero)
 2018-12-12 11:59:56 +02:00
Riccardo Spagni
e19a205ff4
Merge pull request #4920 
e98ae34e core: fix adding new pre-hoh block when a tx is already in the pool (moneromooo-monero)
 2018-12-12 11:59:43 +02:00
Riccardo Spagni
83684ea515
Merge pull request #4909 
756684bb blockchain: avoid unnecessary DB lookups when syncing (moneromooo-monero)
 2018-12-12 11:59:25 +02:00
Riccardo Spagni
4556f0e2b8
Merge pull request #4908 
5ca4994c rpc: speed up the common get_output_distribution case while syncing (moneromooo-monero)
 2018-12-12 11:59:04 +02:00
Riccardo Spagni
0fccc78e39
Merge pull request #4903 
dc1c1252 add command pop_blocks (Jason Wong)
 2018-12-12 11:58:37 +02:00
Riccardo Spagni
d855f9bb92
Merge pull request #4901 
a48f2dab blockchain_prune_known_spent_data: blackball file is now optional (moneromooo-monero)
17b45725 Outputs where all amounts are known spent can now be pruned (moneromooo-monero)
 2018-12-12 11:57:31 +02:00
Riccardo Spagni
85262ca8cd
Merge pull request #4899 
2be31b4c blockchain_blackball: spot when all outputs of an amount are spent (moneromooo-monero)
 2018-12-12 11:56:21 +02:00
Riccardo Spagni
c73ac91af8
Merge pull request #4897 
9b5efad2 simplewallet: enable donation on testnet/stagenet for easier testing (stoffu)
 2018-12-12 11:55:13 +02:00
Riccardo Spagni
0b31baf6e4
Merge pull request #4839 
d71f89e2 device/trezor: device/trezor: correct device initialization, status check (Dusan Klinec)
65b9bca7 device/trezor: python2 compatibility - bundle dependencies (Dusan Klinec)
9cf636af device/trezor: ask for KI sync on first refresh (Dusan Klinec)
d21dad70 device: enable to use multiple independent device wallets (Dusan Klinec)
318cc784 device/trezor: passphrase entry on host (Dusan Klinec)
 2018-12-12 11:53:42 +02:00
Riccardo Spagni
dde1e69723
Merge pull request #4787 
3dba7f25 protocol: option to pad transaction relay to the next kB (moneromooo-monero)
 2018-12-12 11:53:10 +02:00
Jethro Grassie
b56b5b52eb
ignore child process when exec 2018-12-08 20:52:54 -05:00
moneromooo-monero
0e2f5cb5fc
perf_timer: make all logs Info level 
and make them not default at log level 1
 2018-12-08 10:53:09 +00:00
moneromooo-monero
2d7b0236eb
wallet2: clear all payments on soft rescan_bc 
They'll get duplicated otherwise
 2018-12-08 10:39:54 +00:00
moneromooo-monero
3a3858dc90
epee: avoid string allocation when parsing a pod from string 2018-12-08 02:00:34 +00:00
moneromooo-monero
25e5a8539c
singleton: fix missing *this return value in operator= 
while there, disable both operator= and copy ctor, since they
are not supposed to be around for a singleton
 2018-12-07 16:56:59 +00:00
moneromooo-monero
93c59b29a8
perf_timer: check allowed categories before logging 2018-12-07 14:23:47 +00:00
moneromooo-monero
6a507dab6f
perf_timer: add a way to get and reset the current time 2018-12-07 14:23:47 +00:00
moneromooo-monero
c1581a5bb8
perf_timer: only log to file 2018-12-07 14:23:47 +00:00
moneromooo-monero
dbbb3ce9d8
cryptonote: don't serialize for blob size if already known 2018-12-07 14:07:26 +00:00
moneromooo-monero
570dd3690e
p2p: use vector instead of list for peer lists 2018-12-07 13:20:34 +00:00
moneromooo-monero
5464725a29
protocol: change standby mode to not wait sleeping 2018-12-07 12:53:11 +00:00
selsta
1d892ec881
simplewallet: donate command validate amount 2018-12-07 13:43:21 +01:00
moneromooo-monero
db5737413e
util: use fcntl instead of flock, for compatibility 
in particular with NFS
 2018-12-06 12:59:29 +00:00
moneromooo-monero
9cc68a2f74
tx_pool: add a few std::move where it can make a difference 2018-12-05 21:13:37 +00:00
moneromooo-monero
d1efe3d91c
cryptonote: set tx hash on newly parsed txes when known 2018-12-05 21:13:29 +00:00
moneromooo-monero
5511563e92
db_lmdb: avoid pointless division 2018-12-05 21:13:24 +00:00
moneromooo-monero
833269834d
db_lmdb: inline check_open, it's trivial and called everywhere 2018-12-05 21:13:21 +00:00
moneromooo-monero
ce594f5af7
blockchain_db: allocate known size vector only once 2018-12-05 21:13:18 +00:00
moneromooo-monero
6644b9b7b7
blockchain_db: remove a couple unused functions 2018-12-05 21:13:13 +00:00
moneromooo-monero
1505dd38c9
util: set MONERO_DEFAULT_LOG_CATEGORY 
Otherwise it'd end up with whatever was included last
 2018-12-05 14:53:30 +00:00
moneromooo-monero
9e64a71e7d
blockchain: call deinit in dtor 
This ensures the io service that runs in another thread cannot
access data after it's deleted
 2018-12-05 00:13:28 +00:00
Dusan Klinec
d71f89e2a2
device/trezor: device/trezor: correct device initialization, status check 
- checks if the device is in the correct usable state
- implements check for the v2.0.9 firmware which does not support payment IDs
- simple transacttion check, payment id fmt consistency
- minor fixes, refactoring, webusb session counting fix
 2018-12-04 20:12:03 +01:00
Dusan Klinec
65b9bca70e
device/trezor: python2 compatibility - bundle dependencies 2018-12-04 18:38:18 +01:00
Dusan Klinec
9cf636af69
device/trezor: ask for KI sync on first refresh 
When doing a first refresh on HW-token based wallet KI sync is required if money were received. Received money may indicate wallet was already used before the restore I.e., some transaction could have been already sent from the wallet. The spent UTXO would not be detected as spent which could lead to double spending errors on submitting a new transaction.

Thus if the wallet is HW-token based with the cold signing protocol and the first refresh detected received money the user is asked to perform the key image sync.
 2018-12-04 18:38:17 +01:00
Dusan Klinec
d21dad70dd
device: enable to use multiple independent device wallets 
- adds a new option `--hw-device-deriv-path` to the simple wallet. Enables to specify wallet derivation path / wallet code (path avoided so it can be misinterpreted as a file path).
- devices can use different derivation mechanisms. Trezor uses standard SLIP-10 mechanism with fixed SLIP-44 prefix for Monero
- Trezor: when empty, the default derivation mechanism is used with 44'/128'/0'. When entered the derivation path is 44'/128'/PATH.
- Trezor: the path is always taken as elements are hardened (1<<31 bit turned on)
 2018-12-04 18:38:16 +01:00
Riccardo Spagni
7e957c162a
Merge pull request #4879 
243f010e rpc: mask values that are nobody else's business in restricted RPC (moneromooo-monero)
 2018-12-04 17:34:57 +02:00
Riccardo Spagni
5ed45acaec
Merge pull request #4906 
506472e0 protocol: fix use after free when dropping a connection (moneromooo-monero)
 2018-12-04 17:33:53 +02:00
Riccardo Spagni
81418cb281
Merge pull request #4894 
aee7a4e3 wallet_rpc_server: do not use RPC data if the call failed (moneromooo-monero)
1a0733e5 windows_service: fix memory leak (moneromooo-monero)
0dac3c64 unit_tests: do not rethrow a copy of an exception (moneromooo-monero)
5d9915ab cryptonote: fix get_unit for non default settings (moneromooo-monero)
d4f50cb1 remove some unused code (moneromooo-monero)
61163971 a few minor (but easy) performance tweaks (moneromooo-monero)
30023074 tests: slow_memmem now returns size_t (moneromooo-monero)
 2018-12-04 17:33:19 +02:00
Riccardo Spagni
6d1c2a9304
Merge pull request #4892 
c28e3d2d rctOps: add braces to suppress warnings (stoffu)
 2018-12-04 17:32:42 +02:00
moneromooo-monero
243f010edc
rpc: mask values that are nobody else's business in restricted RPC 2018-12-04 15:32:21 +00:00
Riccardo Spagni
0e0777e4d1
Merge pull request #4888 
b0d9d605 cn_deserialize: allow parsing partially valid tx extra (moneromooo-monero)
 2018-12-04 17:31:43 +02:00
Riccardo Spagni
6e74aa9a6c
Merge pull request #4885 
b5573fc2 wallet2: resume processing when tx extra is partially broken (stoffu)
 2018-12-04 17:31:27 +02:00
Riccardo Spagni
1bebe99496
Merge pull request #4884 
56e616e8 wallet2: add n_vouts to capture list (moneromooo-monero)
 2018-12-04 17:31:15 +02:00
Riccardo Spagni
302fd80826
Merge pull request #4882 
6bfcc573 scoped_message_writer: protect all std::cout usage from readline (moneromooo-monero)
 2018-12-04 17:30:30 +02:00
Riccardo Spagni
e799fc87ae
Merge pull request #4866 
9c923bad epee: fix network packet header field endianness (moneromooo-monero)
ec1a62b5 move int-util.h to epee (moneromooo-monero)
 2018-12-04 17:30:11 +02:00
Riccardo Spagni
d4a0fb2b89
Merge pull request #4880 
96e6b439 blockchain_stats: don't use gmtime_r on Windows (moneromooo-monero)
 2018-12-04 17:29:46 +02:00
Riccardo Spagni
e282e9fa40
Merge pull request #4878 
517f25ef rpc: add version to get_info (Jethro Grassie)
 2018-12-04 17:28:24 +02:00
Riccardo Spagni
868630c1db
Merge pull request #4877 
c25260f5 protocol: fix incorrect tx hash in log (moneromooo-monero)
 2018-12-04 17:16:52 +02:00
moneromooo-monero
ec1a62b50d
move int-util.h to epee 2018-12-04 15:14:29 +00:00
Riccardo Spagni
a605c0da08
Merge pull request #4872 
fc99f177 lmdb: fix gcc 7.3.0 'implicit-fallthrough' warning (xiphon)
 2018-12-04 17:13:21 +02:00
Riccardo Spagni
e7d30780de
Merge pull request #4869 
60f36386 Avoid unnecessary temp block and copy ctor (moneromooo-monero)
 2018-12-04 17:12:47 +02:00
Riccardo Spagni
eba668c6ad
Merge pull request #4862 
3998a937 Enhance help text for print_ring. (Tadeas Moravec)
3900fb77 Enhance help text for incoming_transfers. (Tadeas Moravec)
 2018-12-04 17:09:40 +02:00
Riccardo Spagni
11d86f6008
Merge pull request #4859 
6f2497bc Don't cache nettype in core_rpc_server use m_core (doy-lee)
 2018-12-04 17:09:21 +02:00
Riccardo Spagni
c00ac446fd
Merge pull request #4854 
bd98e99c Removed a lot of unnecessary includes (Martijn Otto)
 2018-12-04 17:08:42 +02:00
Riccardo Spagni
398f7076bb
Merge pull request #4853 
2b3595d0 various: do not propagate exception through dtor (moneromooo-monero)
 2018-12-04 17:07:51 +02:00
Riccardo Spagni
94288d7d1d
Merge pull request #4845 
6732fc7f Fix issue 4793 - M/N multisig transaction signature (naughtyfox)
 2018-12-04 17:06:04 +02:00
TheCharlatan
5a76933903 Add glibc back compat code 
To ensure that the binaries compiled by gitian run across many linux
distributions, enforce 2.17 as the minimum libc version supported.
 2018-12-04 02:21:06 +01:00
moneromooo-monero
affff949f9
blockchain: fix race between two external mining threads 2018-12-02 13:08:41 +00:00
Tadeas Moravec
6456cb415a
Bulletproof: Initialize members in default construtor. 
Fixing a build warning on g++ 7.3.0
 2018-12-01 13:03:32 +00:00
moneromooo-monero
9b69a0ae01
daemon: print monero version at startup when calling a detached daemon 
So people who want a timstamp get a timestamp
 2018-11-30 17:55:16 +00:00
moneromooo-monero
0c5dd3161b
cryptonote: add a set_null for transaction_prefix 
Since it's all inline, I suspect the compiler will merge the
duplicate stores anyway.
 2018-11-30 15:11:43 +00:00
moneromooo-monero
aba9a9c277
daemon: stop miner before we bring the whole thing down 
This avoids the miner erroring out trying to submit blocks
to a core that's already shut down (and avoids pegging
the CPU while we're busy shutting down).
 2018-11-30 15:10:25 +00:00
moneromooo-monero
ac665418f0
ringct: fix dummy bulletproofs on ledger in fake mode 
Ledger does some basic checks on them
 2018-11-30 13:33:29 +00:00
Dusan Klinec
318cc78457
device/trezor: passphrase entry on host 
- simple device callback object added. Device can request passphrase/PIN entry via the callback or notify user some action is required
- callback is routed to wallet2, which routes the callback to i_wallet_callback so CLI or GUI wallets can support passphrase entry for HW tokens
- wallet: device open needs wallet callback first - passphrase protected device needs wallet callback so user can enter passphrase
 2018-11-29 04:33:41 +01:00
Jason Wong
dc1c12528d add command pop_blocks 
add new public method to Blockchain and update according to code review

update after review: better lock/unlock, try catch and coding style
 2018-11-28 12:20:28 +01:00
moneromooo-monero
a48f2dab00
blockchain_prune_known_spent_data: blackball file is now optional 
If not present, the tool will scan the blockchain, since scanning
for this is fairly fast.
 2018-11-27 15:45:47 +00:00
moneromooo-monero
17b45725af
Outputs where all amounts are known spent can now be pruned 
Only for pre rct for obvious reasons.

Note: DO NOT use a known spent list which includes outputs
which are not known spent. If the list includes any output
that's just strongly thought to be spent, but not provably
so, you risk finding yourself unable to sync past the point
where that output is spent.

I estimate only 200 MB saved on current mainnet though,
unless the new blackballing rule unearths a good amount of
large-amount-set extra spent outs.
 2018-11-27 15:45:42 +00:00
moneromooo-monero
756684bb28
blockchain: avoid unnecessary DB lookups when syncing 
Some of the inputs for block in a span will be from other earlier
blocks in that span. Keep track of those outputs so we don't have
to look them up again after those early blocks are added to the
blockchain.
 2018-11-27 14:03:06 +00:00
moneromooo-monero
5ca4994c9c
rpc: speed up the common get_output_distribution case while syncing 2018-11-27 14:01:40 +00:00
moneromooo-monero
e98ae34e4b
core: fix adding new pre-hoh block when a tx is already in the pool 2018-11-26 23:45:01 +00:00
stoffu
0e2a5d75de
simplewallet: use is_transfer_unlocked instead of is_tx_spendtime_unlocked for show_transfers 
Followup on #4728
 2018-11-27 07:50:16 +09:00
Riccardo Spagni
58ce16d4d9
Merge pull request #4821 
fc98f7a0 rpc: speedup get_outs.bin (moneromooo-monero)
 2018-11-26 21:51:27 +02:00
moneromooo-monero
fc98f7a0a1
rpc: speedup get_outs.bin 2018-11-26 18:56:23 +00:00
Riccardo Spagni
3e2abc9eaa
Merge pull request #4834 
2c7195d8 bulletproofs: avoid std::vector allocations for slice (moneromooo-monero)
 2018-11-26 20:30:15 +02:00
Riccardo Spagni
4a64303d71
Merge pull request #4831 
c5ee14ae json_archive: initialize inner_array_size in ctor (moneromooo-monero)
 2018-11-26 20:29:06 +02:00
Riccardo Spagni
c4fd8ce97e
Merge pull request #4830 
dffec258 db_lmdb: error out if the db needs migration in read only mode (moneromooo-monero)
 2018-11-26 20:28:49 +02:00
Riccardo Spagni
eccb9b08c4
Merge pull request #4825 
b9b307d1 rpc: speedup get_output_distribution (moneromooo-monero)
 2018-11-26 20:28:02 +02:00
Riccardo Spagni
b37ce24cdd
Merge pull request #4824 
2ffe53d9 device/trezor: webusb transport added, cmake fixes (Dusan Klinec)
 2018-11-26 20:27:29 +02:00
Riccardo Spagni
cc1ea0b651
Merge pull request #4816 
1a4d1603 wallet2: remove redundant chacha key generation in store_keys (stoffu)
 2018-11-26 20:25:39 +02:00
moneromooo-monero
506472e0c6
protocol: fix use after free when dropping a connection 2018-11-26 17:19:25 +00:00
Dusan Klinec
2ffe53d9e6
device/trezor: webusb transport added, cmake fixes 
- webusb transport based on libusb added. Provides direct access to Trezor via USB, no need for Trezor bridge.
- trezor protocol message handler improved, no recursion used. Ready for upcoming integration tests.
- libusb (for docker) bumped from v1.0.9 to v1.0.22, newer version required for webusb transport, for device enumeration.
- cmake improvements and fixes. Cmake Trezor checks are moved to a dedicated CheckTrezor.cmake file. In case of a problem Trezor is excluded from build.
- ifdefs made consistent to Ledger.
- UDP Transport enumeration disabled by default in release mode
 2018-11-25 11:57:19 +01:00
moneromooo-monero
2be31b4c9c
blockchain_blackball: spot when all outputs of an amount are spent 2018-11-24 11:07:15 +00:00
stoffu
9b5efad294
simplewallet: enable donation on testnet/stagenet for easier testing 2018-11-24 08:25:38 +09:00
moneromooo-monero
aee7a4e364
wallet_rpc_server: do not use RPC data if the call failed 
Found by codacy.com
 2018-11-23 15:38:00 +00:00
moneromooo-monero
1a0733e534
windows_service: fix memory leak 
Found by codacy.com
 2018-11-23 15:38:00 +00:00
moneromooo-monero
5d9915ab9e
cryptonote: fix get_unit for non default settings 
Found by codacy.com
 2018-11-23 15:37:39 +00:00
moneromooo-monero
d4f50cb109
remove some unused code 
Found by codacy.com
 2018-11-23 15:37:36 +00:00
moneromooo-monero
611639710d
a few minor (but easy) performance tweaks 
Found by codacy.com
 2018-11-23 15:36:48 +00:00
moneromooo-monero
3002307418
tests: slow_memmem now returns size_t 
Makes more sense than uint64_t for an offset, and agrees with
the %zu used to print results.

Found by codacy.com
 2018-11-23 15:36:48 +00:00
stoffu
c28e3d2dae
rctOps: add braces to suppress warnings 2018-11-23 12:28:04 +09:00
moneromooo-monero
b0d9d6051f
cn_deserialize: allow parsing partially valid tx extra 2018-11-22 11:15:57 +00:00
stoffu
b5573fc231
wallet2: resume processing when tx extra is partially broken 
Motivated by https://monero.stackexchange.com/questions/10483

Some exchanges appear to have customized the wallet software
in an inappropriate way, making the tx extra field partially
unreadable. PR #3716 changed the wallet behavior disallowing
such partially valid tx extra.

An example tx reported by the user is
e87c675a85f34ecac58a8846613d25062f1813e1023c552b705afad32b972c38
where the normal tx pubkey appears again with the aditional
tx pubkeys tag `04` which is inappropriate.
 2018-11-22 14:51:35 +09:00
moneromooo-monero
56e616e855
wallet2: add n_vouts to capture list 2018-11-22 01:45:45 +00:00
Jethro Grassie
517f25efd1
rpc: add version to get_info 2018-11-21 12:56:34 -05:00
moneromooo-monero
6bfcc57395
scoped_message_writer: protect all std::cout usage from readline 2018-11-21 12:48:43 +00:00
moneromooo-monero
96e6b43970
blockchain_stats: don't use gmtime_r on Windows 
In some cases, it doesn't like it (I don't know the details).

Factor into a new epee function
 2018-11-21 00:50:53 +00:00
moneromooo-monero
c25260f51c
protocol: fix incorrect tx hash in log 2018-11-20 18:35:58 +00:00
naughtyfox
6732fc7fde Fix issue 4793 - M/N multisig transaction signature 2018-11-20 16:50:41 +03:00
moneromooo-monero
b9b307d11a
rpc: speedup get_output_distribution 
and decrease the amount of data carried around
 2018-11-20 10:11:25 +00:00
Riccardo Spagni
84dd674cd0
Merge pull request #4781 
2a48c2a2 slow-hash: some more big endian fixes (xiphon)
b39fdf8e slow-hash: fix for big endian (moneromooo-monero)
 2018-11-20 12:34:41 +09:00
xiphon
fc99f177f3 lmdb: fix gcc 7.3.0 'implicit-fallthrough' warning 2018-11-19 22:36:10 +00:00
moneromooo-monero
60f36386e4
Avoid unnecessary temp block and copy ctor 
block already has a default ctor, and the extra object
churn due to its innards (vectors, etc) is pointless.
 2018-11-19 17:57:17 +00:00
moneromooo-monero
707c2f836b
Remove -Werror 
It is an annoying piece of garbage
 2018-11-17 13:15:03 +00:00
moneromooo-monero
31d80027b5
tests: add unit tests for get_output_distribution 2018-11-16 19:21:45 +00:00
Tadeas Moravec
3998a937e5
Enhance help text for print_ring. 2018-11-16 15:15:35 +00:00
Tadeas Moravec
3900fb779f
Enhance help text for incoming_transfers. 2018-11-16 14:53:31 +00:00
moneromooo-monero
0936dae8a4
blockchain: remove "0 is height" shortcut from get_output_distribution 
This prevents asking for just 0, and the RPC layer already does this
 2018-11-16 10:03:02 +00:00
moneromooo-monero
872c7eb26a
Revert "blockchain: simplify output distribution code" 
This reverts commit b2bb9312a7.
 2018-11-16 10:02:59 +00:00
xiphon
2a48c2a286
slow-hash: some more big endian fixes 2018-11-16 09:58:41 +00:00
moneromooo-monero
b39fdf8ebe
slow-hash: fix for big endian 2018-11-16 09:58:38 +00:00
Riccardo Spagni
c37c70f459
Merge pull request #4806 
ac23b10f blockchain: fix innocuous difficulty cache inconsistency (moneromooo-monero)
3b14d972 blockchain: use uint64_t for block height, not size_t (moneromooo-monero)
 2018-11-16 11:16:49 +02:00
Riccardo Spagni
0295055bcb
Merge pull request #4805 
6a1062f5 bulletproofs: reserve vector memory when known in advance (moneromooo-monero)
 2018-11-16 11:16:12 +02:00
Riccardo Spagni
cec336ecbc
Merge pull request #4804 
00907c39 rct: speedup commit a little (moneromooo-monero)
 2018-11-16 11:15:56 +02:00
Riccardo Spagni
056abf980e
Merge pull request #4801 
7ae36e91 wallet_rpc_server: account for watch-only/non-deterministic/multisig when querying seed (stoffu)
 2018-11-16 11:13:09 +02:00
Riccardo Spagni
3a40d94998
Merge pull request #4800 
79b4dae6 simplewallet: slightly adjust wording when printing multisig seed (stoffu)
 2018-11-16 11:12:43 +02:00
Riccardo Spagni
45f597c564
Merge pull request #4799 
f4988454 perf_timer: remove stray debug addition (moneromooo-monero)
 2018-11-16 11:12:09 +02:00
Riccardo Spagni
46f989bc49
Merge pull request #4795 
5d7c2316 rct: add a zeroCommit cache for common pre-rct case (moneromooo-monero)
 2018-11-16 11:11:10 +02:00
Riccardo Spagni
f9c60736b8
Merge pull request #4794 
e198b06e Fix: out_of_hashchain_bounds_error in refresh (Hasan Pekdemir)
 2018-11-16 11:10:20 +02:00
Riccardo Spagni
40bb7a304a
Merge pull request #4792 
5d4f3df8 simplewallet: reorganize SCOPED_WALLET_UNLOCK a bit more (stoffu)
 2018-11-16 11:09:41 +02:00
Riccardo Spagni
86395e5bd6
Merge pull request #4791 
5878fe95 simplewallet: don't skip asking for password when watch-only (stoffu)
 2018-11-16 11:08:34 +02:00
Riccardo Spagni
9aff9a5372
Merge pull request #4790 
177a9d76 wallet: warn if lockable memory limit is too low (moneromooo-monero)
 2018-11-16 11:08:07 +02:00
Riccardo Spagni
20bf9b93dd
Merge pull request #4789 
0afdb00b wallet2: fix print_ring printing double entries for transactions (moneromooo-monero)
 2018-11-16 11:07:40 +02:00
Riccardo Spagni
c8cc65f30a
Merge pull request #4788 
8f3963d2 wallet2: demote a few uninteresting recurring logs to TRACE (moneromooo-monero)
 2018-11-16 11:07:21 +02:00
Riccardo Spagni
279a0a4d8a
Merge pull request #4786 
c22e85fe simplewallet: remove redundant messages on daemon connection failure (stoffu)
 2018-11-16 11:06:32 +02:00
Riccardo Spagni
4561119846
Merge pull request #4784 
1c04c21d wallet_rpc_server: include additional tx keys in sign_transfer response (stoffu)
 2018-11-16 11:05:31 +02:00
Riccardo Spagni
140defd89f
Merge pull request #4778 
71eb32a9 dns_utils: do not exit if DNS records are corrupt (moneromooo-monero)
 2018-11-16 11:02:28 +02:00
Riccardo Spagni
b1ba96e159
Merge pull request #4777 
c17a1d43 daemon: use msg_writer, not cout, to display information (moneromooo-monero)
 2018-11-16 11:01:33 +02:00
Riccardo Spagni
46d0dc2808
Merge pull request #4776 
03fc731b p2p: less frequent incoming connections check (moneromooo-monero)
14a5c206 p2p: tone down "no incoming connections" warning to info if in peers is 0 (moneromooo-monero)
 2018-11-16 11:01:19 +02:00
Riccardo Spagni
d7bac99f6f
Merge pull request #4770 
2bd46065 Expose limit-rate defaults from command line help (RaskaRuby)
 2018-11-16 10:59:38 +02:00
Riccardo Spagni
9827958f5e
Merge pull request #4768 
cf552c75 tx_pool: allow take_tx to work without m_txs_by_fee_and_receive_time (moneromooo-monero)
 2018-11-16 10:59:25 +02:00
Riccardo Spagni
e90ee7548c
Merge pull request #4765 
09dbd9cb tx_pool: fix comment about transaction_prefix (moneromooo-monero)
 2018-11-16 10:58:42 +02:00
Riccardo Spagni
95d96d139d
Merge pull request #4764 
1598f01c wallet2: use padded bulletproofs for multisig signing (stoffu)
 2018-11-16 10:58:29 +02:00
Riccardo Spagni
1910aab5f4
Merge pull request #4236 
a9357141 Add new command "export_transfers" to save transfers to csv (sachaaaaa)
 2018-11-16 10:57:43 +02:00
doy-lee
6f2497bc7a Don't cache nettype in core_rpc_server use m_core 
This can go out of sync with m_core's nettype if you run in fakechain
mode since entering fakechain mode is done through code not the command
line and core_rpc_server only looks at the command line to figure out
the nettype.
 2018-11-16 15:32:05 +11:00
moneromooo-monero
c5ee14ae6e
json_archive: initialize inner_array_size in ctor 
Coverity 136581
 2018-11-15 16:33:51 +00:00
Martijn Otto
bd98e99c80
Removed a lot of unnecessary includes 2018-11-15 17:29:34 +01:00
moneromooo-monero
2b3595d0fe
various: do not propagate exception through dtor 
Coverity 189689, 189690, 189692, 189695
 2018-11-15 15:53:21 +00:00
stoffu
79b4dae66f
simplewallet: slightly adjust wording when printing multisig seed 2018-11-15 23:51:19 +09:00
Riccardo Spagni
0cc3fc3756
Merge pull request #4769 
5808530f blockchain: remove unused output_scan_worker parameter (moneromooo-monero)
1426209a blockchain: don't run threads if we have just one function to run (moneromooo-monero)
6f7a5fd4 db_lmdb: slight speedup getting array data from the blockchain (moneromooo-monero)
99fbe100 db_lmdb: save some string copies for readonly db keys/values (moneromooo-monero)
bf31447e tx_pool: speed up take_tx for transactions from blocks (moneromooo-monero)
4f005a77 tx_pool: remove unnecessary get_transaction_hash (moneromooo-monero)
593ef598 perf_timer: call reserve on new timer array (moneromooo-monero)
6ecc99ad core: avoid unnecessary tx/blob conversions (moneromooo-monero)
00cc1a16 unit_tests: notify test special case for the usual weirdo (moneromooo-monero)
 2018-11-14 21:35:03 +02:00
Riccardo Spagni
33ad6fb4c1
Merge pull request #4761 
6e1282b6 wallet2: fix off by one in output picking (moneromooo-monero)
 2018-11-14 21:34:51 +02:00
Riccardo Spagni
92c5a892b5
Merge pull request #4757 
db24a2e5 hash: fix hash_permutation on big endian (moneromooo-monero)
 2018-11-14 21:34:09 +02:00
Riccardo Spagni
8ba3f89b44
Merge pull request #4755 
42d8d508 crypto: fix AES encryption on big endian (xiphon)
 2018-11-14 21:33:38 +02:00
Riccardo Spagni
59e8a4c306
Merge pull request #4753 
157054b8 hardfork: initialize current_fork_index in ctor (moneromooo-monero)
2362baf7 network_throttle: initialize m_last_sample_time in ctor (moneromooo-monero)
d9400f69 serializtion: add missing mainnet and stagenet fields for 0mq (moneromooo-monero)
cbe0122b wallet2: initialize amount to 0 in tx_scan_info_t ctor (moneromooo-monero)
 2018-11-14 21:33:02 +02:00
Riccardo Spagni
23fc891555
Merge pull request #4750 
e61062b6 use current height - 1 for top block height in err msgs (cryptochangements34)
 2018-11-14 21:32:21 +02:00
Riccardo Spagni
ff347c98a1
Merge pull request #4747 
dad5bbfd return message in stop_mining if mining never started (cryptochangements34)
 2018-11-14 21:32:10 +02:00
Riccardo Spagni
dd42b642ee
Merge pull request #4746 
f3019efe wallet-rpc: add on_restore_deterministic RPC call. (Hasan Pekdemir)
 2018-11-14 21:31:08 +02:00
Riccardo Spagni
2312aacf18
Merge pull request #4847 
6d3311ac libwallet_api_tests: add missing dependency on Boost Locale and ICU (stoffu)
f0459abb cmake: move Boost_LOCALE_LIBRARY out of ICU_LIBRARIES (stoffu)
 2018-11-14 21:30:19 +02:00
stoffu
f0459abbb9
cmake: move Boost_LOCALE_LIBRARY out of ICU_LIBRARIES 2018-11-15 00:18:31 +09:00
xiphon
d01bdaca12 common: fix base58 gcc -Werror=implicit-fallthrough 2018-11-13 12:15:18 +00:00
sachaaaaa
a93571410e Add new command "export_transfers" to save transfers to csv 2018-11-12 12:03:11 +11:00
moneromooo-monero
2c7195d80c
bulletproofs: avoid std::vector allocations for slice 2018-11-09 19:58:11 +00:00
moneromooo-monero
dffec2587f
db_lmdb: error out if the db needs migration in read only mode 2018-11-09 09:39:22 +00:00
Riccardo Spagni
8534f71eed
Merge pull request #4814 
840bf155 build: fix Ubuntu 16.04 (GCC 5.4.0) compilation (xiphon)
 2018-11-07 15:02:56 +02:00
stoffu
ba2055a220
api/wallet: fix compile errors made in #4720 2018-11-07 15:12:24 +09:00
stoffu
1a4d160311
wallet2: remove redundant chacha key generation in store_keys 2018-11-07 10:47:10 +09:00
xiphon
840bf155a0 build: fix Ubuntu 16.04 (GCC 5.4.0) compilation 2018-11-06 21:45:00 +00:00
Riccardo Spagni
a9e03ebc6a
Merge pull request #4809 
1fd017cf Fix build of monero-gui by adding device_trezor to wallet_merged (buricl)
 2018-11-06 21:35:08 +02:00
Riccardo Spagni
148ac1a898
Merge pull request #4744 
b3e8677c cryptonote: use logging functions for errors, not std::cout (moneromooo-monero)
 2018-11-06 21:33:52 +02:00
Riccardo Spagni
a369a13928
Merge pull request #4743 
9335d5a2 wallet2: save ring in the ringdb once a tx is created (moneromooo-monero)
 2018-11-06 21:33:22 +02:00
Riccardo Spagni
da26bc92e9
Merge pull request #4742 
0a95cdaa blockchain_utilities: fix logs and cout output colliding (moneromooo-monero)
 2018-11-06 21:32:54 +02:00
Riccardo Spagni
d210d6fb45
Merge pull request #4738 
107f3398 wallet2: fix ring reuse breaking when using histogram (moneromooo-monero)
 2018-11-06 21:31:32 +02:00
Riccardo Spagni
299d75b209
Merge pull request #4735 
73e504c1 rpc: adjust ring size error message now that too high is also possible (moneromooo-monero)
a5ca7f4f core: fix unmixable special case allowing ring size below 11 (moneromooo-monero)
 2018-11-06 21:31:14 +02:00
Riccardo Spagni
0991aa8964
Merge pull request #4733 
b3067962 cryptonote_core: avoid gratuitous recalculations in check_block_rate() (xiphon)
 2018-11-06 21:30:52 +02:00
Riccardo Spagni
164ba3ef1c
Merge pull request #4731 
f26ce08c wallet: add a non destructive blockchain rescan (moneromooo-monero)
 2018-11-06 21:30:12 +02:00
moneromooo-monero
3dba7f252e
protocol: option to pad transaction relay to the next kB 
To help protect one's privacy from traffic volume analysis
for people using Tor or I2P. This will really fly once we
relay txes on a timer rather than on demand, though.

Off by default for now since it's wasteful and doesn't bring
anything until I2P's in.
 2018-11-06 15:47:05 +00:00
Riccardo Spagni
b789f7e10d
Merge pull request #4729 
e86af52e wallet2: rewrite keys file in a safer manner (Nathan Dorfman)
 2018-11-06 15:09:45 +02:00
Riccardo Spagni
1667d41064
Merge pull request #4728 
1f35de23 simplewallet: display locked/unlocked state in show_transfers (moneromooo-monero)
 2018-11-06 14:54:17 +02:00
Riccardo Spagni
b60078d1b3
Merge pull request #4726 
91eaea9c mnemonics: fix words_to_bytes on big endian (moneromooo-monero)
 2018-11-06 14:53:40 +02:00
Riccardo Spagni
236c0dd48c
Merge pull request #4720 
5f614ba9 simplewallet: print the number of show/all transfers (moneromooo-monero)
8d71b2b1 wallet2: only export necessary outputs and key images (moneromooo-monero)
769ae42a wallet2: faster output and key image import/export (moneromooo-monero)
 2018-11-06 14:52:24 +02:00
Riccardo Spagni
267b5d8807
Merge pull request #4711 
c4fbfd78 Small function declaration cleanup in slow-hash.c (Pol Mauri)
 2018-11-06 14:51:23 +02:00
Riccardo Spagni
cb4d5c2d4b
Merge pull request #4707 
97cad7e9 db_lmdb: log which output was not found in get_output_key (moneromooo-monero)
 2018-11-06 14:50:08 +02:00
buricl
1fd017cf77 Fix build of monero-gui by adding device_trezor to wallet_merged 2018-11-06 00:17:22 +01:00
moneromooo-monero
6e1282b600
wallet2: fix off by one in output picking 
and take into account wallet level minimum spend age
 2018-11-05 20:13:00 +00:00
moneromooo-monero
ac23b10f15
blockchain: fix innocuous difficulty cache inconsistency 
This inconsistent state would not actually be used in practice
 2018-11-05 14:47:52 +00:00
moneromooo-monero
3b14d9727b
blockchain: use uint64_t for block height, not size_t 
for consistency
 2018-11-05 14:47:48 +00:00
moneromooo-monero
6a1062f560
bulletproofs: reserve vector memory when known in advance 2018-11-05 14:32:32 +00:00
moneromooo-monero
00907c3987
rct: speedup commit a little 
saves a conversion, and uses a double scalarmult instead of
two scalarmults
 2018-11-05 14:25:11 +00:00
stoffu
7ae36e91f6
wallet_rpc_server: account for watch-only/non-deterministic/multisig when querying seed 
Followup on #4653
 2018-11-05 12:13:15 +09:00
moneromooo-monero
f49884543c
perf_timer: remove stray debug addition 2018-11-05 00:34:16 +00:00
xiphon
b3067962fa cryptonote_core: avoid gratuitous recalculations in check_block_rate() 2018-11-05 00:13:51 +00:00
Dusan Klinec
e178bf234a
rpc: fix linking error of 6097472a, get_output_distribution 
Undefined symbols for architecture x86_64:
  "cryptonote::core::get_output_distribution(unsigned long long, unsigned long long, unsigned long long, unsigned long long&, std::__1::vector<unsigned long long, std::__1::allocator<unsigned long long> >&, unsigned long long&) const", referenced from:
      cryptonote::rpc::RpcHandler::get_output_distribution(cryptonote::core&, unsigned long long, unsigned long long, unsigned long long, bool) in rpc_handler.cpp.o
 2018-11-04 23:38:52 +01:00
moneromooo-monero
5f614ba968
simplewallet: print the number of show/all transfers 2018-11-04 22:27:05 +00:00
moneromooo-monero
8d71b2b1b3
wallet2: only export necessary outputs and key images 
and disable annoying test that requires ridiculous amounts
of skullduggery every time some format changes
 2018-11-04 22:27:01 +00:00
moneromooo-monero
769ae42a7b
wallet2: faster output and key image import/export 2018-11-04 22:26:59 +00:00
Riccardo Spagni
7e2483e1d5
Merge pull request #4702 
70877b1d wallet2/create_transactions_2: removed obsolete '/ 1024' on min_fee calc (Paul Shapiro)
 2018-11-04 20:47:25 +02:00
Riccardo Spagni
68e2efa8f2
Merge pull request #4694 
a43daebf Add stats utility (Howard Chu)
 2018-11-04 20:47:06 +02:00
Riccardo Spagni
6d3d8635be
Merge pull request #4693 
74fb3d88 multiexp: some minor speedups (moneromooo-monero)
a6d2e246 bulletproofs: only enable profiling on request (moneromooo-monero)
a110e6aa multiexp: tune which variants to use for which number of points (moneromooo-monero)
8b476722 bulletproofs: speedup prover (moneromooo-monero)
6f9ae5b6 multiexp: handle pippenger multiexps with part precalc (moneromooo-monero)
10e5a927 bulletproofs: maintain -z4, -z5, and -y0 to avoid subtractions (moneromooo-monero)
8629a42c bulletproofs: rework flow to use sarang's fast batch inversion code (moneromooo-monero)
fc9f7d9c bulletproofs: merge multiexps as per sarang's new python code (moneromooo-monero)
4061960a multiexp: pack the digits table when STRAUS_C is 4 (moneromooo-monero)
bf8e4b98 bulletproofs: some more minor speedup (moneromooo-monero)
c415df97 performance_tests: sc_check and ge_dsm_precomp (moneromooo-monero)
a281b950 bulletproofs: remove single value prover (moneromooo-monero)
484155d0 bulletproofs: some more speedup (moneromooo-monero)
a621d6c8 bulletproofs: random minor speedups (moneromooo-monero)
a49a1761 bulletproofs: shave off a lot of scalar muls from the g/h construction (moneromooo-monero)
4564a5d1 bulletproofs: speedup PROVE (moneromooo-monero)
 2018-11-04 20:46:42 +02:00
Riccardo Spagni
5141f6e8e8
Merge pull request #4692 
cb4aafd2 blockchain_utilities: simplify getting block blob from height (moneromooo-monero)
 2018-11-04 20:46:21 +02:00
Riccardo Spagni
ae919a1e15
Merge pull request #4691 
7f0dd094 wallet2: sanity check rct output distribution from the daemon (moneromooo-monero)
 2018-11-04 20:45:59 +02:00
Riccardo Spagni
617deb3329
Merge pull request #4689 
ba0faae7 crypto: fixed groestl on big-endian platforms (xiphon)
ed36335c crypto: fixed incremental keccak API on big-endian platforms (xiphon)
 2018-11-04 20:45:40 +02:00
Riccardo Spagni
adf4eb8d50
Merge pull request #4688 
5a2e54a1 Fix prune using receive time as tx_weight (doy-lee)
 2018-11-04 20:45:06 +02:00
Riccardo Spagni
0c7086bf7f
Merge pull request #4687 
6097472a Update ZMQ fee estimate and add ZMQ output distribution (Lee Clagett)
 2018-11-04 20:44:49 +02:00
Riccardo Spagni
d394c50f7b
Merge pull request #4686 
cf646e3a wallet2/create_transactions_2: removed extraneous shuffle before sort of unused_*_indices_per_subaddr (Paul Shapiro)
 2018-11-04 20:44:27 +02:00
Riccardo Spagni
9cf0e67978
Merge pull request #4685 
76681b9b wallet2/create_transactions_2: fixed typo in try_tx=true's estimate_fee args (Paul Shapiro)
 2018-11-04 20:44:00 +02:00
Riccardo Spagni
5251496662
Merge pull request #4684 
4a003bb5 mnemonics/electrum-words/create_checksum_index(): updated to work with non fixed word list length mnemonic (Paul Shapiro)
 2018-11-04 20:43:28 +02:00
Riccardo Spagni
5918ef93f8
Merge pull request #4683 
3a85af40 core: fix handle_incoming_tx* comment about return value (moneromooo-monero)
 2018-11-04 20:43:08 +02:00
Riccardo Spagni
69b646494b
Merge pull request #4241 
29ffb6bb device/trezor: trezor support added (Dusan Klinec)
 2018-11-04 20:42:46 +02:00
Riccardo Spagni
dc7de3312f
Merge pull request #4779 
233f00c6 cryptonote_core: fix build error gcc 5.4.0 'sign-compare' (xiphon)
 2018-11-04 20:41:19 +02:00
Hasan Pekdemir
e198b06e7a Fix: out_of_hashchain_bounds_error in refresh 
15:43 < hahsun> Im on stagenet and I suddenly get this exception: 2018-11-04 14:42:52.416 [RPC0] ERROR wallet.wallet2 src/wallet/wallet2.cpp:2070 !m_blockchain.is_in_bounds(current_index). THROW EXCEPTION: error::out_of_hashchain_bounds_error
16:01 <+moneromooo> OK, possibly because the blckchain is always seeded with the genesis block hash...
16:02 <+moneromooo> So that case should be allowed, assuming it doesn't break the code around it.
16:05 <+moneromooo> OK if stop_height == size || (size==1 && stop_heigt ==0)
16:05 <+moneromooo> Throw if not that.
16:06 < hahsun> k
 2018-11-04 17:07:30 +01:00
moneromooo-monero
5d7c231604
rct: add a zeroCommit cache for common pre-rct case 
This is called for every pre-rct output at blockchain sync time,
and a lot of them wil hit the cache, saving a scalarmult each.
 2018-11-04 15:44:56 +00:00
moneromooo-monero
5808530f54
blockchain: remove unused output_scan_worker parameter 2018-11-04 13:23:05 +00:00
moneromooo-monero
1426209a10
blockchain: don't run threads if we have just one function to run 2018-11-04 13:23:02 +00:00
moneromooo-monero
6f7a5fd4f7
db_lmdb: slight speedup getting array data from the blockchain 2018-11-04 13:23:00 +00:00
stoffu
5d4f3df887
simplewallet: reorganize SCOPED_WALLET_UNLOCK a bit more 
Followup on #4555
 2018-11-04 10:51:14 +09:00
stoffu
5878fe95ce
simplewallet: don't skip asking for password when watch-only 2018-11-04 10:50:03 +09:00
moneromooo-monero
177a9d76f9
wallet: warn if lockable memory limit is too low 2018-11-03 20:09:28 +00:00
moneromooo-monero
f26ce08c8a
wallet: add a non destructive blockchain rescan 2018-11-03 15:04:37 +00:00
moneromooo-monero
8f3963d200
wallet2: demote a few uninteresting recurring logs to TRACE 2018-11-03 11:51:03 +00:00
moneromooo-monero
0afdb00b9d
wallet2: fix print_ring printing double entries for transactions 
When a tx gets from unconfirmed to conirmed, the rings for that
transaction were being added twice
 2018-11-03 11:50:38 +00:00
cryptochangements34
e61062b6f2 use current height - 1 for top block height in err msgs 2018-11-02 19:31:31 -04:00
Dusan Klinec
29ffb6bba8
device/trezor: trezor support added 2018-11-02 21:36:39 +01:00
stoffu
c22e85fe1a
simplewallet: remove redundant messages on daemon connection failure 
try_connect_to_daemon with silent=false already prints failure message
 2018-11-02 23:25:27 +09:00
stoffu
1c04c21d6e
wallet_rpc_server: include additional tx keys in sign_transfer response 
Followup on #4552
 2018-11-02 21:42:02 +09:00
moneromooo-monero
97cad7e979
db_lmdb: log which output was not found in get_output_key 2018-11-02 11:49:39 +00:00
xiphon
233f00c601 cryptonote_core: fix build error gcc 5.4.0 'sign-compare' 2018-11-01 22:57:08 +00:00
moneromooo-monero
71eb32a976
dns_utils: do not exit if DNS records are corrupt 2018-11-01 22:53:48 +00:00
moneromooo-monero
c17a1d431b
daemon: use msg_writer, not cout, to display information 2018-11-01 22:53:10 +00:00
moneromooo-monero
03fc731bf2
p2p: less frequent incoming connections check 2018-11-01 22:00:35 +00:00
Riccardo Spagni
9a4b15c631
Merge pull request #4664 
61304151 db_lmdb: use MDB_MULTIPLE_NEXT where possible for some speedup (moneromooo-monero)
 2018-11-01 22:34:20 +02:00
Riccardo Spagni
7d05e6eab3
Merge pull request #4663 
d6937e37 ringct: use dummy bulletproofs when in fake mode, for speed (moneromooo-monero)
 2018-11-01 22:34:02 +02:00
Riccardo Spagni
a0cd602e56
Merge pull request #4658 
ca9b996d perf_timer: separate log categories based on caller categories (moneromooo-monero)
 2018-11-01 22:33:38 +02:00
Riccardo Spagni
3ceeac50da
Merge pull request #4653 
ade369f9 Add RPC error code for non-deterministic wallet (Michał Sałaban)
 2018-11-01 22:33:20 +02:00
Riccardo Spagni
fde24c80c2
Merge pull request #4648 
a7bffead daemon: fix base fee stating /kB even when it is per byte (moneromooo-monero)
 2018-11-01 22:33:02 +02:00
Riccardo Spagni
e7a475e4e6
Merge pull request #4645 
6f88c03d Simplewallet: update help text for show_transfers. (Ted Moravec)
 2018-11-01 22:32:41 +02:00
Riccardo Spagni
4f7cdd90fd
Merge pull request #4639 
ec301390 Update db_lmdb.cpp (Cactii1)
 2018-11-01 22:24:11 +02:00
moneromooo-monero
99fbe1008b
db_lmdb: save some string copies for readonly db keys/values 2018-11-01 17:26:09 +00:00
moneromooo-monero
14a5c2068f
p2p: tone down "no incoming connections" warning to info if in peers is 0 
Also add an info if not offline, since it weakens the network
 2018-11-01 16:43:06 +00:00
moneromooo-monero
bf31447e9b
tx_pool: speed up take_tx for transactions from blocks 
This happens for every historical tx when syncing, and the
unnecessary parsing is actually showing up on profile.
Since these are kept cached for just one block, this does
not increase memory usage after syncing.
 2018-11-01 15:51:28 +00:00
moneromooo-monero
4f005a77c2
tx_pool: remove unnecessary get_transaction_hash 2018-11-01 15:51:24 +00:00
moneromooo-monero
593ef5981d
perf_timer: call reserve on new timer array 
to avoid reallocations in the vast majority of the time
 2018-11-01 15:51:22 +00:00
moneromooo-monero
6ecc99ad1f
core: avoid unnecessary tx/blob conversions 2018-11-01 15:51:19 +00:00
RaskaRuby
2bd46065ae Expose limit-rate defaults from command line help 2018-10-31 14:47:20 -07:00
moneromooo-monero
cf552c752d
tx_pool: allow take_tx to work without m_txs_by_fee_and_receive_time 
This should make it possible to have two daemons running on the
same database again.
 2018-10-31 14:45:02 +00:00
moneromooo-monero
09dbd9cbbc
tx_pool: fix comment about transaction_prefix 
It was leftover from a change that was undone before commit,
but the comment change was let through
 2018-10-31 12:15:38 +00:00
stoffu
1598f01caf
wallet2: use padded bulletproofs for multisig signing 
Analogous to #4540
 2018-10-31 20:01:25 +09:00
xiphon
42d8d5085e crypto: fix AES encryption on big endian 2018-10-31 03:13:55 +00:00
moneromooo-monero
db24a2e509
hash: fix hash_permutation on big endian 2018-10-29 22:26:44 +00:00
Hasan Pekdemir
f3019efe1b wallet-rpc: add on_restore_deterministic RPC call. 2018-10-29 18:19:42 +01:00
moneromooo-monero
157054b840
hardfork: initialize current_fork_index in ctor 
Also order init list to match actual runtime init order

Coverity 136605
 2018-10-29 16:23:58 +00:00
moneromooo-monero
d9400f69eb
serializtion: add missing mainnet and stagenet fields for 0mq 
Coverity 184940
 2018-10-29 16:23:14 +00:00
moneromooo-monero
cbe0122bf1
wallet2: initialize amount to 0 in tx_scan_info_t ctor 
It seems the more prudent thing to do here. It will not catch
attempts to use that value before it is initialized when using
ASAN or valgrind, but in a case where it does, it will have
smaller repercussions.

So it seems appropriate in this particular case.

Coverity 182498
 2018-10-29 16:22:55 +00:00
Nathan Dorfman
e86af52e2f wallet2: rewrite keys file in a safer manner 2018-10-28 09:58:54 -06:00
cryptochangements34
dad5bbfdf9
return message in stop_mining if mining never started 2018-10-28 09:50:33 -04:00
moneromooo-monero
b3e8677c70
cryptonote: use logging functions for errors, not std::cout 2018-10-27 18:07:55 +00:00
moneromooo-monero
9335d5a297
wallet2: save ring in the ringdb once a tx is created 
Even if it is never relayed, it ensures a daemon supplying
fake outs on demand will never be asked for a set with the
real input being the only intersecting member (only a problem
with people who trust their privacy to some stranger's node,
but it seems to be a massively common thing, even in Monero)
 2018-10-27 17:59:56 +00:00
moneromooo-monero
0a95cdaa80
blockchain_utilities: fix logs and cout output colliding 2018-10-27 17:40:01 +00:00
moneromooo-monero
107f33985d
wallet2: fix ring reuse breaking when using histogram 2018-10-27 14:35:00 +00:00
moneromooo-monero
73e504c139
rpc: adjust ring size error message now that too high is also possible 2018-10-27 11:16:28 +00:00
moneromooo-monero
a5ca7f4fb5
core: fix unmixable special case allowing ring size below 11 2018-10-27 11:16:25 +00:00
Riccardo Spagni
00a7d441d6
Merge pull request #4719 
0aff4987 rpc: fix build with older compilers (moneromooo-monero)
 2018-10-26 22:41:43 +02:00
Riccardo Spagni
20d3605a54
Merge pull request #4700 
3bb4b0d4 miner: fix build with boost 1.69 (moneromooo-monero)
 2018-10-26 22:41:21 +02:00
Riccardo Spagni
33d9d2b4c1
Merge pull request #4672 
62f94e1b device_io_hid.cpp: fix copyright header (moneromooo-monero)
 2018-10-26 22:40:47 +02:00
Riccardo Spagni
fc06c5daf8
Merge pull request #4617 
3ffbec15 rpc: init m_rpc_version in Message ctor (moneromooo-monero)
bfa2dce1 rpc: remove unused ctors (moneromooo-monero)
7cc39845 account: init creation timestamp to 0 (moneromooo-monero)
32123789 wallet2: initialize some scalar fields in ctor where appropriate (moneromooo-monero)
4eca42b2 blockchain_db: initialize m_hardfork in ctor just in case (moneromooo-monero)
 2018-10-26 22:39:00 +02:00
Riccardo Spagni
148d14164e
Merge pull request #4615 
a7960542 WalletAPI: rescanBlockchain, rescanBlockchainAsync (mmitkevich)
 2018-10-26 22:38:41 +02:00
Riccardo Spagni
ecc690a613
Merge pull request #4612 
2d48861d p2p: only deinitialize what's been initialized in offline mode (moneromooo-monero)
 2018-10-26 22:38:03 +02:00
Riccardo Spagni
665ab1afbc
Merge pull request #4609 
e54e5668 daemon: Show mining address (Ricardo de Vries)
 2018-10-26 22:36:54 +02:00
Riccardo Spagni
481d7ed147
Merge pull request #4604 
0fbbb065 p2p: a negative result from UPNP_GetValidIGD is an error (moneromooo-monero)
 2018-10-26 22:35:50 +02:00
Riccardo Spagni
6fc7869eb5
Merge pull request #4586 
e51c9787 rpc: fix wrongly formatted JSON for pruned tx (stoffu)
 2018-10-26 22:35:03 +02:00
Riccardo Spagni
c761bee764
Merge pull request #4561 
04ddf02e Return appropriate RPC error code when key image signature check fails (Michał Sałaban)
 2018-10-26 22:33:35 +02:00
Riccardo Spagni
d6fb329653
Merge pull request #4555 
68e9744d simplewallet: perform trivial error checks before password prompt (xiphon)
 2018-10-26 22:33:09 +02:00
Riccardo Spagni
169e6e9074
Merge pull request #4552 
67e76aa0 wallet_rpc_server: optionally return tx keys in sign_transfer (moneromooo-monero)
 2018-10-26 22:32:34 +02:00
Riccardo Spagni
b8a4e5b7a6
Merge pull request #4547 
f2c2c47a simplewallet: fixed deadlock if a user hits CTRL+C twice (xiphon)
 2018-10-26 22:31:37 +02:00
Riccardo Spagni
d7ff24c1e0
Merge pull request #4545 
93a88d73 Utils: add support for newer Windows versions detection (Gregory Lemercier)
 2018-10-26 22:30:40 +02:00
Riccardo Spagni
659cf52a61
Merge pull request #4539 
977fc1bc wallet_rpc_server: add describe_transfer RPC (moneromooo-monero)
 2018-10-26 22:20:57 +02:00
Riccardo Spagni
056a58d13f
Merge pull request #4536 
fd62b6e7 blocks: use auto-generated .c files instead of 'LD -r -b binary' (xiphon)
 2018-10-26 22:20:39 +02:00
Riccardo Spagni
557c17e206
Merge pull request #4408 
341b3931 cryptonote_core: warn when the block rate deviates from expectations (moneromooo-monero)
 2018-10-26 22:18:41 +02:00
Riccardo Spagni
1c91963dcd
Merge pull request #4308 
9907ea06 cryptonote: sort tx_extra fields (moneromooo-monero)
 2018-10-26 22:18:28 +02:00
moneromooo-monero
1f35de2300
simplewallet: display locked/unlocked state in show_transfers 
it doesn't display the details, which are already displayed
in show_transfer
 2018-10-25 23:02:42 +00:00
moneromooo-monero
91eaea9c72
mnemonics: fix words_to_bytes on big endian 2018-10-25 20:23:17 +00:00
xiphon
ba0faae789 crypto: fixed groestl on big-endian platforms 2018-10-25 02:06:23 +00:00
moneromooo-monero
0aff49873c
rpc: fix build with older compilers 2018-10-24 20:36:58 +00:00
Pol Mauri
c4fbfd786a Small function declaration cleanup in slow-hash.c 
- These functions are declared twice in slow-hash.c. Remove one of the copies.
- The declarations have the wrong return type, should be void, not int.

Function definitions here: 1e74586ee9/src/crypto/aesb.c (L151-L180)
Test plan: make release-test
 2018-10-23 23:19:52 -07:00
Lee Clagett
6097472a19 Update ZMQ fee estimate and add ZMQ output distribution 2018-10-23 23:46:31 -04:00
moneromooo-monero
d6937e373b
ringct: use dummy bulletproofs when in fake mode, for speed 2018-10-23 21:03:18 +00:00
Howard Chu
a43daebf57
Add stats utility 
Report statistics from a blockchain DB
 2018-10-23 19:43:31 +01:00
moneromooo-monero
61f83316b3
wallet2: extend fake out picks away from the gamma pick 
in order to unbias selection from blocks with few txes
 2018-10-23 09:06:47 +00:00
Paul Shapiro
70877b1d91 wallet2/create_transactions_2: removed obsolete '/ 1024' on min_fee calc 2018-10-22 18:51:45 -05:00
doy-lee
5a2e54a1cb Fix prune using receive time as tx_weight 2018-10-23 10:03:45 +11:00
moneromooo-monero
3bb4b0d41f
miner: fix build with boost 1.69 2018-10-22 22:17:15 +00:00
moneromooo-monero
74fb3d882c
multiexp: some minor speedups 2018-10-22 16:08:26 +00:00
moneromooo-monero
a6d2e246f3
bulletproofs: only enable profiling on request 2018-10-22 16:07:44 +00:00
moneromooo-monero
a110e6aa18
multiexp: tune which variants to use for which number of points 2018-10-22 16:07:44 +00:00
moneromooo-monero
8b4767221c
bulletproofs: speedup prover 2018-10-22 16:07:44 +00:00
moneromooo-monero
6f9ae5b6eb
multiexp: handle pippenger multiexps with part precalc 2018-10-22 16:07:44 +00:00
moneromooo-monero
10e5a92769
bulletproofs: maintain -z4, -z5, and -y0 to avoid subtractions 2018-10-22 16:07:44 +00:00
moneromooo-monero
8629a42cf6
bulletproofs: rework flow to use sarang's fast batch inversion code 2018-10-22 16:07:44 +00:00
moneromooo-monero
fc9f7d9c81
bulletproofs: merge multiexps as per sarang's new python code 2018-10-22 16:07:44 +00:00
moneromooo-monero
4061960a16
multiexp: pack the digits table when STRAUS_C is 4 
Spotted by stoffu
 2018-10-22 16:07:44 +00:00
moneromooo-monero
bf8e4b9870
bulletproofs: some more minor speedup 2018-10-22 16:07:44 +00:00
moneromooo-monero
a281b950bf
bulletproofs: remove single value prover 
It is now expressed in terms of the array prover
 2018-10-22 16:07:44 +00:00
moneromooo-monero
484155d043
bulletproofs: some more speedup 2018-10-22 16:07:44 +00:00
moneromooo-monero
a621d6c8b4
bulletproofs: random minor speedups 2018-10-22 16:07:44 +00:00
moneromooo-monero
a49a17618f
bulletproofs: shave off a lot of scalar muls from the g/h construction 2018-10-22 16:07:44 +00:00
moneromooo-monero
4564a5d17b
bulletproofs: speedup PROVE 2018-10-22 16:07:44 +00:00
moneromooo-monero
cb4aafd27e
blockchain_utilities: simplify getting block blob from height 2018-10-22 16:04:28 +00:00
xiphon
ed36335c96 crypto: fixed incremental keccak API on big-endian platforms 2018-10-22 18:34:19 +03:00
moneromooo-monero
7f0dd094e7
wallet2: sanity check rct output distribution from the daemon 2018-10-22 14:01:46 +00:00
stoffu
e51c978770
rpc: fix wrongly formatted JSON for pruned tx 
Fix for #4399.
Also unifies code for serializing pruned tx to binary/json into one.
 2018-10-22 10:52:40 +09:00
xiphon
fd62b6e79f blocks: use auto-generated .c files instead of 'LD -r -b binary' 2018-10-22 01:12:00 +03:00
Paul Shapiro
4a003bb5a2 mnemonics/electrum-words/create_checksum_index(): updated to work with non fixed word list length mnemonic 2018-10-21 12:46:13 -05:00
Paul Shapiro
76681b9bda wallet2/create_transactions_2: fixed typo in try_tx=true's estimate_fee args 2018-10-21 12:44:22 -05:00
Paul Shapiro
cf646e3afe wallet2/create_transactions_2: removed extraneous shuffle before sort of unused_*_indices_per_subaddr 2018-10-21 12:43:31 -05:00
moneromooo-monero
3a85af403d
core: fix handle_incoming_tx* comment about return value 2018-10-21 17:09:21 +00:00
Riccardo Spagni
2287fb9fb4
Merge pull request #4524 
f5f7c2ac rpc: blanket initialize 0MQ request and response structures (moneromooo-monero)
 2018-10-20 20:40:56 +02:00
Riccardo Spagni
a145ae52b6
Merge pull request #4523 
6ca00b6d miner: really reset flags/precision on std::cout (moneromooo-monero)
 2018-10-20 20:40:36 +02:00
Riccardo Spagni
5c418c0522
Merge pull request #4522 
a39c0358 blockchain: add check test options are given for fakechain mode (moneromooo-monero)
 2018-10-20 20:40:16 +02:00
Riccardo Spagni
ed4b953bb7
Merge pull request #4518 
92a0827e wallet2: make fake out selection messages less spammy (moneromooo-monero)
 2018-10-20 20:39:36 +02:00
Riccardo Spagni
a38299801f
Merge pull request #4666 
cf75ee72 blockchain: move two new verification errors to the verify category (moneromooo-monero)
 2018-10-20 20:38:37 +02:00
Riccardo Spagni
9f34a3a29a
Merge pull request #4659 
b916ca63 rpc: fix output distribution caching ignoring chain changes (moneromooo-monero)
 2018-10-20 20:37:54 +02:00
Riccardo Spagni
4cd8850fce
Merge pull request #4642 
25d327e7 device: extended logging, refactored device selection code (xiphon)
825d836f device: fixed Ledger Nano S device selection (xiphon)
 2018-10-20 20:37:28 +02:00
Riccardo Spagni
bdd32bc2b2
Merge pull request #4650 
99cd6f96 Rename "blackball" for clarity (moneromooo-monero)
 2018-10-20 20:36:58 +02:00
Riccardo Spagni
93f2c13a39
Merge pull request #4637 
c39e0a17 core: don't verify range proofs multiple times (moneromooo-monero)
 2018-10-20 20:36:33 +02:00
Riccardo Spagni
313f16e83c
Merge pull request #4635 
776aefda tx_pool: revert #4592 and move bin2hex conversion to on_get_transaction_pool (stoffu)
 2018-10-20 20:35:22 +02:00
Riccardo Spagni
fe0e426be4
Merge pull request #4629 
c7743929 spawn: close all file descriptors before execve (moneromooo-monero)
 2018-10-20 20:34:15 +02:00
moneromooo-monero
62f94e1b9d
device_io_hid.cpp: fix copyright header 2018-10-20 10:31:27 +00:00
moneromooo-monero
cf75ee722a
blockchain: move two new verification errors to the verify category 
Lest we get people get scared again
 2018-10-19 21:11:12 +00:00
moneromooo-monero
61304151b4
db_lmdb: use MDB_MULTIPLE_NEXT where possible for some speedup 2018-10-19 16:47:29 +00:00
moneromooo-monero
b916ca63a8
rpc: fix output distribution caching ignoring chain changes 
0 is placeholder for whole chain, so we should compare chain
height changes rather than chain-height-or-zero. Even this isn't
totally foolproof if a blocks are popped and the same number
added again, but it is much better as it prevents the data from
slowly going out of sync.
 2018-10-19 09:22:35 +00:00
moneromooo-monero
ca9b996dcb
perf_timer: separate log categories based on caller categories 
Also default to microseconds, for homogeneity

Makes it easier to enable what we need
 2018-10-19 08:59:56 +00:00
moneromooo-monero
a7bffead9e
daemon: fix base fee stating /kB even when it is per byte 2018-10-19 08:39:33 +00:00
Michał Sałaban
ade369f96f Add RPC error code for non-deterministic wallet 2018-10-18 23:14:06 +02:00
moneromooo-monero
99cd6f961a
Rename "blackball" for clarity 
Apparently some people seem to think it's a censorship list...
 2018-10-18 18:45:45 +00:00
xiphon
25d327e796 device: extended logging, refactored device selection code 2018-10-18 17:53:06 +03:00
Ted Moravec
6f88c03dfc
Simplewallet: update help text for show_transfers. 
Describe the output format.
 2018-10-18 09:14:15 +00:00
Ricardo de Vries
e54e5668a8 daemon: Show mining address 2018-10-18 10:45:42 +02:00
xiphon
825d836f9f device: fixed Ledger Nano S device selection 2018-10-18 07:42:29 +03:00
stoffu
776aefdac1
tx_pool: revert #4592 and move bin2hex conversion to on_get_transaction_pool 2018-10-18 08:01:56 +09:00
Cactii1
ec3013903b
Update db_lmdb.cpp 2018-10-17 21:36:10 +02:00
moneromooo-monero
c39e0a1706
core: don't verify range proofs multiple times 2018-10-17 16:23:10 +00:00
moneromooo-monero
c774392985
spawn: close all file descriptors before execve 
No need to give whatever we're calling access to what we use
 2018-10-17 09:31:34 +00:00
moneromooo-monero
a69fc05a0c
util: close keys file lock on exec 2018-10-16 17:20:44 +00:00
Riccardo Spagni
5c85da5a73
Merge pull request #4610 
9b6dd934 Providing user supplied default constructor for expect<void> (Lee Clagett)
 2018-10-16 18:25:14 +02:00
Riccardo Spagni
d4e4fac209
Merge pull request #4602 
6f28667a daemon: fix reading past stack on exit (moneromooo-monero)
 2018-10-16 18:23:44 +02:00
Riccardo Spagni
c5be5ca6b4
Merge pull request #4623 
99d45a95 wallet_rpc_server: fix change_wallet_password RPC (moneromooo-monero)
 2018-10-16 18:23:30 +02:00
moneromooo-monero
99d45a9578
wallet_rpc_server: fix change_wallet_password RPC 2018-10-16 15:19:05 +00:00
Riccardo Spagni
e0a1d45d76
Merge pull request #4621 
0cdd4b07 wallet2_api: fix generating new wallet in the GUI (moneromooo-monero)
 2018-10-16 17:13:39 +02:00
moneromooo-monero
0cdd4b074e
wallet2_api: fix generating new wallet in the GUI 
It was creating a new wallet without a password first (this should
be fixed), then not changing the password correctly
 2018-10-16 14:46:17 +00:00
moneromooo-monero
3ffbec1556
rpc: init m_rpc_version in Message ctor 
Coverity 182501
 2018-10-16 11:58:54 +00:00
moneromooo-monero
bfa2dce171
rpc: remove unused ctors 
Also prevents coverity from moaning about them not initializing fields
 2018-10-16 11:58:52 +00:00
moneromooo-monero
7cc39845be
account: init creation timestamp to 0 
Never actually used uninitialized

Coverity 136615
 2018-10-16 11:58:50 +00:00
moneromooo-monero
3212378912
wallet2: initialize some scalar fields in ctor where appropriate 
Coverity 188336
 2018-10-16 11:58:48 +00:00
moneromooo-monero
4eca42b241
blockchain_db: initialize m_hardfork in ctor just in case 
Coverity 136568
 2018-10-16 11:58:46 +00:00
mmitkevich
a7960542a9 WalletAPI: rescanBlockchain, rescanBlockchainAsync 2018-10-16 14:58:22 +03:00
moneromooo-monero
2d48861db7
p2p: only deinitialize what's been initialized in offline mode 2018-10-16 09:20:05 +00:00
Lee Clagett
9b6dd9348c Providing user supplied default constructor for expect<void> 2018-10-15 23:42:29 -04:00
iDunk5400
e7f24850d5
Fix Windows build after epee dependency change 2018-10-15 23:08:17 +00:00
moneromooo-monero
0fbbb065d4
p2p: a negative result from UPNP_GetValidIGD is an error 
as per the source documentation
 2018-10-15 22:41:00 +00:00
moneromooo-monero
6f28667aa3
daemon: fix reading past stack on exit 2018-10-15 22:13:05 +00:00
Riccardo Spagni
1afc1d0d26
Merge pull request #4502 
9a856697 rpc: fixed typo in JSON command error response message (AnythingTechPro)
 2018-10-15 13:38:47 +02:00
Riccardo Spagni
5ccd3d32b4
Merge pull request #4489 
00901e9c epee: initialize a few data members where it seems to be appropriate (moneromooo-monero)
144a6c32 abstract_tcp_server2: move m_period to subclass (moneromooo-monero)
758d7684 connection_basic: remove unused floating time start time (moneromooo-monero)
e5108a29 Catch more exceptions in dtors (moneromooo-monero)
 2018-10-15 13:37:18 +02:00
Riccardo Spagni
c531df734f
Merge pull request #4389 
6844ae1b tx_pool: avoid parsing a whole tx if only the prefix is needed (moneromooo-monero)
 2018-10-15 13:36:15 +02:00
Riccardo Spagni
ad8e6ee8c7
Merge pull request #4592 
a677492f tx_pool: store hex string instead of raw binary to tx_blob of get_transaction_pool RPC (stoffu)
 2018-10-15 13:33:40 +02:00
Riccardo Spagni
544413de8f
Merge pull request #4577 
d886b97f SOFTWARE is the default wallet device (m2049r)
 2018-10-15 13:31:29 +02:00
Riccardo Spagni
f6cfca9a40
Merge pull request #4551 
c0822fdd simplewallet: mark default-ring-size setting as obsolete (moneromooo-monero)
 2018-10-15 13:30:01 +02:00
Riccardo Spagni
fa7278d6b5
Merge pull request #4578 
76d6d832 Revert "p2p: connect via the bound ip, if any" (moneromooo-monero)
 2018-10-15 13:29:21 +02:00
Riccardo Spagni
f916ef81f1
Merge pull request #4571 
c3b8328c daemon: do not run complex code in a signal handler (moneromooo-monero)
e736964a Remove epee header dependency on cryptonote_core (moneromooo-monero)
 2018-10-15 13:28:42 +02:00
Riccardo Spagni
175bfe4747
Merge pull request #4567 
14ed029b simplewallet: fix view key parsing in --generate-from-view-key (moneromooo-monero)
 2018-10-15 13:26:29 +02:00
Riccardo Spagni
40980b33b7
Merge pull request #4550 
0e33cf89 password: fix secure input with echo on windows (moneromooo-monero)
 2018-10-15 13:25:50 +02:00
Riccardo Spagni
ae5ca0bea1
Merge pull request #4549 
dc8f6924 password: fix backspace outputting ^? on linux on echoing secure input (moneromooo-monero)
 2018-10-15 13:24:55 +02:00
stoffu
a677492f1b
tx_pool: store hex string instead of raw binary to tx_blob of get_transaction_pool RPC 
Inspired by https://github.com/masari-project/masari/issues/93
 2018-10-15 11:57:02 +09:00
moneromooo-monero
76d6d832d2
Revert "p2p: connect via the bound ip, if any" 
This reverts commit 909398efc7.

It looks like it's causing trouble with tor on some setups
 2018-10-13 10:20:04 +00:00
m2049r
d886b97fe2
SOFTWARE is the default wallet device 2018-10-13 09:25:49 +02:00
moneromooo-monero
c3b8328cd3
daemon: do not run complex code in a signal handler 
instead, delegate the work to a one off thread
and notify it from the signal handler
 2018-10-12 17:44:04 +00:00
moneromooo-monero
e736964a0c
Remove epee header dependency on cryptonote_core 2018-10-12 17:16:44 +00:00
moneromooo-monero
14ed029b24
simplewallet: fix view key parsing in --generate-from-view-key 2018-10-12 12:54:42 +00:00
moneromooo-monero
f5f7c2ac24
rpc: blanket initialize 0MQ request and response structures 2018-10-12 09:57:41 +00:00
Michał Sałaban
04ddf02e3a Return appropriate RPC error code when key image signature check fails 2018-10-11 18:12:17 +02:00
xiphon
68e9744d44 simplewallet: perform trivial error checks before password prompt 2018-10-10 20:01:04 +00:00