Git-Mirrors/constellation
1
0
Fork 0
mirror of https://github.com/edgelesssys/constellation.git synced 2025-01-25 14:56:18 -05:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Otto Bittner <cobittner@posteo.net>
This commit is contained in:
Adrian Stobbe 2023-07-26 07:25:58 +02:00
parent aca3bf3ca9
commit d3735a4520
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dev-docs/workflows/release.md
View File

@ -6,7 +6,7 @@ This checklist will prepare `v1.3.0` from `v1.2.0` (minor release) or `v1.3.1` f
1. Search the code for TODOs and FIXMEs that should be resolved before releasing.
2. [Update titles and labels for all PRs relevant for this release](/dev-docs/conventions.md#pr-conventions) to aid in the [changelog generation](/.github/release.yml).
3. Check PRs with `breaking change` for the label `iam upgrade`. If there is any, the `upgradeRequiresIAMMigration` constant in `iamupgradeapply.go` needs to be set to `true`, otherwise set to `false`. This ensures to issue a warning to the user on `upgrade apply` to ensure prior `iam upgrade apply`
3. Check PRs for the label `iam upgrade`. If there is any, the `upgradeRequiresIAMMigration` constant in `iamupgradeapply.go` needs to be set to `true`, otherwise set to `false`. This ensures the CLI issues a warning on `upgrade apply` to run `iam upgrade apply` before upgrading the cluster.

2
docs/docs/reference/migration.md
View File

@ -16,7 +16,7 @@ Use [`constellation config migrate`](./cli.md#constellation-config-migrate) to a
## Migrating from CLI versions before 2.10
- AWS cluster upgrades require additional iam permissions for the newly introduced `aws-load-balancer-controller`. Please perform an upgrade through `iam upgrade apply` which will show the needed changes and ask to confirm them before applying.
- AWS cluster upgrades require additional IAM permissions for the newly introduced `aws-load-balancer-controller`. Please upgrade your IAM roles using `iam upgrade apply`. This will show necessary changes and apply them, if desired.
## Migrating from CLI versions before 2.9