From d3735a4520967c1c904036bfe415296694787600 Mon Sep 17 00:00:00 2001 From: Adrian Stobbe Date: Wed, 26 Jul 2023 07:25:58 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Otto Bittner --- dev-docs/workflows/release.md | 2 +- docs/docs/reference/migration.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dev-docs/workflows/release.md b/dev-docs/workflows/release.md index e5b79734d..605bb45b9 100644 --- a/dev-docs/workflows/release.md +++ b/dev-docs/workflows/release.md @@ -6,7 +6,7 @@ This checklist will prepare `v1.3.0` from `v1.2.0` (minor release) or `v1.3.1` f 1. Search the code for TODOs and FIXMEs that should be resolved before releasing. 2. [Update titles and labels for all PRs relevant for this release](/dev-docs/conventions.md#pr-conventions) to aid in the [changelog generation](/.github/release.yml). -3. Check PRs with `breaking change` for the label `iam upgrade`. If there is any, the `upgradeRequiresIAMMigration` constant in `iamupgradeapply.go` needs to be set to `true`, otherwise set to `false`. This ensures to issue a warning to the user on `upgrade apply` to ensure prior `iam upgrade apply` +3. Check PRs for the label `iam upgrade`. If there is any, the `upgradeRequiresIAMMigration` constant in `iamupgradeapply.go` needs to be set to `true`, otherwise set to `false`. This ensures the CLI issues a warning on `upgrade apply` to run `iam upgrade apply` before upgrading the cluster. diff --git a/docs/docs/reference/migration.md b/docs/docs/reference/migration.md index d8cfbb35f..06c1342b2 100644 --- a/docs/docs/reference/migration.md +++ b/docs/docs/reference/migration.md @@ -16,7 +16,7 @@ Use [`constellation config migrate`](./cli.md#constellation-config-migrate) to a ## Migrating from CLI versions before 2.10 -- AWS cluster upgrades require additional iam permissions for the newly introduced `aws-load-balancer-controller`. Please perform an upgrade through `iam upgrade apply` which will show the needed changes and ask to confirm them before applying. +- AWS cluster upgrades require additional IAM permissions for the newly introduced `aws-load-balancer-controller`. Please upgrade your IAM roles using `iam upgrade apply`. This will show necessary changes and apply them, if desired. ## Migrating from CLI versions before 2.9