Commit Graph

5976 Commits

Author SHA1 Message Date
b1rdG
dafd975b51 Verify before lock the mutex 2020-05-17 14:06:07 -05:00
b1rdG
089ea76a6e Add lobby_identity check 2020-05-17 09:18:12 -05:00
csoler
dc03f8ff49
imprved readability of the logic in rstlvidset serialization 2020-05-16 13:13:48 +02:00
csoler
6008599f02
fixed wrong call to std::set::erase(iterator,iterator) where the iterator comes from another set, causing inconsistencies 2020-05-16 13:12:37 +02:00
jolavillette
51ba879bb7 bandwidth control improvement 2020-05-14 23:28:20 +02:00
jolavillette
1f547aaefe bandwidth control improvement 2020-05-14 23:13:36 +02:00
Phenom
f6260a95ae Add Votes when calling getPostData. 2020-05-13 00:36:14 +02:00
csoler
e6edae27be
Merge pull request #1922 from PhenomRetroShare/Fix_SomeWarnings
Fix some warnings
2020-05-12 23:05:34 +02:00
csoler
cb1fe154f3
removed debug info 2020-05-10 18:40:31 +02:00
csoler
766da8117a
added missing update of membership status flags when an id is removed from the invitee list 2020-05-10 18:37:03 +02:00
csoler
3ae173f104
removed debug info in circles 2020-05-10 13:47:53 +02:00
csoler
6f6e0de5f1
merged with upstreamm/master 2020-05-09 22:33:27 +02:00
csoler
e09bf7c261
added a check to prevent SEGV when sending a notification about a group we updated 2020-05-09 21:30:51 +02:00
csoler
df2899bae9
added warning about keys tht are out of range when checking a msg signature 2020-05-09 21:30:07 +02:00
jolavillette
7c2efbc630 reduce cpu load by increasing sleep before ticking pqi and core 2020-05-09 20:35:20 +02:00
csoler
0c3b8641af
fixing some bugs in circles backend 2020-05-09 18:07:56 +02:00
Phenom
b40ca53f13 Fix warning: ‘n’ may be used uninitialized in this function
../../../trunk/libretroshare/src/rsitems/rsmsgitems.cc: In member
function ‘virtual void
RsMsgTags::serial_process(RsGenericSerializer::SerializeJob,
RsGenericSerializer::SerializeContext&)’:
../../../trunk/libretroshare/src/rsitems/rsmsgitems.cc:93:22: warning:
‘n’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   93 |             uint32_t n ;
      |                      ^
2020-05-09 14:32:48 +02:00
defnax
38af9244a6 added spam box 2020-05-08 23:21:38 +02:00
csoler
bc69e8c1ac
forgot to update file in previous commit 2020-05-08 16:06:23 +02:00
csoler
8e52f07621
changed NO_DATA enum to NO_DATA_YET. Seems that this is an existing define on windows 2020-05-08 14:49:25 +02:00
csoler
59df44535a
put enum outside class in RsGxsCircleCache 2020-05-08 11:24:49 +02:00
csoler
5f5c2be64b
fixed a few bugs in the new circle cache system 2020-05-07 20:35:02 +02:00
csoler
11a4b6540f
cleaned-up circles cache. Needs testing. 2020-05-07 17:31:58 +02:00
jolavillette
4ead639e8c remove unneeded pqithreadstreamer and pqissl mutex locks 2020-05-06 21:29:46 +02:00
jolavillette
2c1238db2c remove unneeded lock of p3ServiceServer mutex 2020-05-06 12:11:54 +02:00
jolavillette
7634d121de Merge remote-tracking branch 'upstream/master' into mutexDivorce
Update mutexDivorce
2020-05-06 11:33:43 +02:00
jolavillette
7113d1935f finish removing pqistreamer locks, clean rates methods 2020-05-04 22:42:18 +02:00
csoler
65fa29e789
fixed notifications on circle not working due to cache reload failure. That circle cache code needs a real cleanup 2020-05-04 20:54:08 +02:00
sehraf
757e922c4f
Fix unix_fcntl_nonblock() to not overwrite any existing flags. 2020-05-04 15:13:39 +02:00
jolavillette
28458bf10a tick_send: remove unneeded lock around mBio->cansend 2020-05-04 08:11:57 +02:00
csoler
ce6abe5d66
made GxsNotify for messages with more granularity. Removed RsGxsCircleMsg class that was not used. 2020-05-03 23:20:13 +02:00
sehraf
638648cf64
fix json api markup 2020-05-03 20:57:48 +02:00
jolavillette
d847086911 finish emoving unneeded pqistreamer locks in recv part 2020-05-03 20:32:17 +02:00
sehraf
53b76732a9
pqisslistener: document accept() process 2020-05-03 14:58:19 +02:00
csoler
48960d548d
Merge pull request #1880 from jolavillette/threadTick
clean rewrite of RsServer::threadTick
2020-05-03 13:28:43 +02:00
jolavillette
7db8cbca97 remove debug flag 2020-05-02 21:21:42 +02:00
csoler
efb26ce9c0
added warnign when notified CircleMsg cannot be retrieved from DB 2020-05-02 15:48:38 +02:00
csoler
32baccae97
finished cleaning GxsCircle Notifications 2020-05-02 15:09:32 +02:00
jolavillette
d35dd76ca5 try to isolate pqistreamer mutex from pqissl mutex, step 1: pqistreamer::tick_recv() 2020-05-02 09:47:24 +02:00
csoler
26dd716967
added documentation on circle membership at UI and circles API level. Internals need to be implemented accordingly 2020-05-01 22:59:39 +02:00
csoler
d32daaa111
made group notifications separate so that they can be treated more easily and added group item to new_group notifications, to allow more GUI notifications 2020-05-01 00:00:13 +02:00
Phenom
e8b8119174 Fix Channel Post Comments Number 2020-04-29 00:52:19 +02:00
csoler
767440afc5
added circle invite notifications 2020-04-28 21:39:38 +02:00
sehraf
04dc163d30
pqissl: document statemachine and function hierarchy 2020-04-28 19:17:35 +02:00
Olivier Marty
b0613ef653 Correct design flaw in slow process control, improve indentation, set up debug #ifdef 2020-04-28 09:48:12 +02:00
csoler
59b7f042e1
Merge pull request #1879 from G10h4ck/item_uninitialized_ptr
RawMemoryWrapper::serial_process report error
2020-04-27 23:24:09 +02:00
csoler
f5af7dfeb3
fixed up top bar tooltips to display what the numbers actually mean 2020-04-27 21:56:43 +02:00
csoler
0f1a3879d0
quick fix for debug flag that was left in the code 2020-04-27 20:28:34 +02:00
Gioacchino Mazzurco
6fc89c2d37
RawMemoryWrapper DESERIALIZE warn if got non null ptr 2020-04-27 20:22:50 +02:00
csoler
28a6b43357
added missing file 2020-04-27 17:11:06 +02:00
Olivier Marty
9a9eb56a3a clean rewrite of RsServer::threadTick 2020-04-27 16:08:20 +02:00
csoler
f7199f1f1c
moved GxsNotify classes to rsgxsnotify.h internal to gxs (not visible in API) since it is unused in GUI. Added event item in forum to handle moderator list changes 2020-04-26 23:35:37 +02:00
csoler
4b568f3068
fixed the same error in turtle generic search result 2020-04-26 15:34:28 +02:00
csoler
76e9387467
fixed deserialiser for rawWrapper causing crashes when wrapper memory is not initialized properly by the client 2020-04-26 14:19:44 +02:00
csoler
86897b60de
fixed uninitialized memory causing a crash in turtle items 2020-04-26 14:19:02 +02:00
csoler
ae54e53bc1
updated RsGenExchange::performUpdateValidation to simplify the logic and save (oldGrp,newGrp) in a specific RsGxsGroupUpdate subclass of GxsNotify so as to be able to handle group data notifications in services 2020-04-26 00:18:01 +02:00
csoler
9b0abe16dd
small fix to indent in authssl.cc 2020-04-25 18:07:04 +02:00
csoler
b2e36fbd9c
fixed version incompatibility in merge PR 1869 2020-04-24 23:06:29 +02:00
csoler
ad4939e64c
Merge pull request #1872 from b1rdG/patch-2
Improve documentation
2020-04-24 21:56:41 +02:00
csoler
e323bc8573
Merge pull request #1869 from PhenomRetroShare/Fix_OpenSSL1_CreatCertFail
Fix OpenSSL fail to create Cert.
2020-04-24 21:55:01 +02:00
b1rdG
36bab55d8c Use tabs instead of spaces 2020-04-23 15:15:03 -05:00
b1rdG
7290caa1a5
Improve documentation 2020-04-23 20:07:18 +00:00
b1rdG
b55d37efa4 Add RsGxsId checks 2020-04-23 14:56:53 -05:00
csoler
f9b731c92e
fixed free()/delete[] mismatch reported by valgrind 2020-04-22 20:32:16 +02:00
Phenom
866b564f90 Fix OpenSSL fail to create Cert. 2020-04-22 17:28:41 +02:00
csoler
5120f693be
Merge pull request #1859 from csoler/v0.6-ImprovedGUI_4
Making channels faster to load
2020-04-21 19:30:49 +02:00
Gioacchino Mazzurco
2f0b0f48bf
Better atomicity (not perfect) for RsDdg() and companions 2020-04-21 18:10:58 +02:00
csoler
1cfbfdaf63
Merge pull request #1866 from PhenomRetroShare/Fix_SIGSEGV_OnRsThreadStart
Fix SIGSEGV on RsThread::start
2020-04-21 13:11:35 +02:00
G10h4ck
2b44492cb6
Merge pull request #1829 from G10h4ck/rsfiles_links
RsFiles links support in libretroshare + a bunch of fixes
2020-04-20 17:12:04 +02:00
Gioacchino Mazzurco
3f38d04680
Clarify pointer ownership decorators documentation
Use old char* in PGP functionas asked by Cyril
2020-04-20 15:52:29 +02:00
Gioacchino Mazzurco
e406a1fb8b
Fix JSON API compilation after rebasing on master 2020-04-20 15:52:20 +02:00
csoler
38e89d4055
fixed merge with upstream/master 2020-04-19 21:53:02 +02:00
csoler
5b761c72ba
removed debug info 2020-04-19 21:07:53 +02:00
csoler
096cdd6dd2
Merge pull request #1863 from sehraf/pr_handle_deprecated_packets
Fix log spam by handling deprecated packet gracefully
2020-04-19 18:57:11 +02:00
Phenom
c0ce5c7088 Fix SIGSEGV on RsThread::start
mTid could be null while pError is null too.

This happens to me always with "gxs integrity".
2020-04-19 11:24:57 +02:00
sehraf
f19d933ff1
Partially revert bea6769a4e.
Currently the log is flooded with messages about "unkown" packets which are actually just deprecated ones. Add back the code to gracefully handle them (= delete them).
2020-04-18 11:45:35 +02:00
b1rdG
d100e53470
Improve parameter description 2020-04-17 22:09:40 +00:00
b1rdG
d265e61b06
Expose JSON API closeDistantChatConnexion and initiateDistantChatConnexion 2020-04-17 21:56:58 +00:00
csoler
fa8968797c
added some tests to insertGroupData() to avoid inconsistent calls 2020-04-16 21:35:57 +02:00
csoler
915e197223
Merge pull request #1857 from csoler/v0.6-GxsDbFix
Quick fix to allow plugin loading
2020-04-15 11:09:05 +02:00
csoler
59508d4c7e
fixed plugin loading 2020-04-14 21:38:52 +02:00
Gioacchino Mazzurco
f54fb046e4
Use a a loop instead of std::trasform as suggested by Cyril 2020-04-14 12:26:21 +02:00
Gioacchino Mazzurco
7d388c3090
Solve non compatible 32/64bit file handle API 2020-04-14 12:26:21 +02:00
Gioacchino Mazzurco
2a369cb785
Fix noisy compiler warning 2020-04-14 12:26:21 +02:00
Gioacchino Mazzurco
a4950aca66
Safer checks in type serializer 2020-04-14 12:24:58 +02:00
Gioacchino Mazzurco
0c3fd6f27c
Explicit type as requested by Cyril 2020-04-14 12:24:58 +02:00
Gioacchino Mazzurco
b701ca8da3
Keep 10 extra unassigned slots for event types
Proper error reporting + cruft removal
2020-04-14 12:24:58 +02:00
Gioacchino Mazzurco
76d492b4aa
Add forgot authorship in rsbase64* 2020-04-14 12:24:58 +02:00
Gioacchino Mazzurco
05f65e9211
Fix missing paramether direction in Doxygen doc 2020-04-14 12:24:58 +02:00
Gioacchino Mazzurco
13e0179812
Readd struct disappeared in rebase + fix warning 2020-04-14 12:24:58 +02:00
Gioacchino Mazzurco
612d47908d
Fix JSON API breakage introduced in cf7a77e512 2020-04-14 12:24:57 +02:00
Gioacchino Mazzurco
8cb46e5937
Fix compilation on Android arm64 2020-04-14 12:24:57 +02:00
Gioacchino Mazzurco
7d1efa7ed9
Fix compiler warnings 2020-04-14 12:24:57 +02:00
Gioacchino Mazzurco
4c0baa1ec3
Fix JSON API event handler registering behavior
As a bonus the behaviour is now homogeneous between C++ API and JSON API
Fix a bunch of compiler warning
RsEvents implementation is now safer
mHandlerMaps size is known at compile time, so use an std::array instead
  of vector
2020-04-14 12:24:57 +02:00
Gioacchino Mazzurco
ce5f5faa97
Fix Android compilation after rebase on master 2020-04-14 12:24:57 +02:00
Gioacchino Mazzurco
b42c0410f1
Expose pgpIdFromFingerprint to JSON API
+ missing explicit in one paramether costructor
2020-04-14 12:17:04 +02:00
Gioacchino Mazzurco
9d325e3d17
Fix mail in rsjsonapi.h copyright header 2020-04-14 12:17:03 +02:00
Gioacchino Mazzurco
0d1524aa12
Fix crash due to RsChatAvatarItem uninitialized pointer
Caught signal 11 (SIGSEGV)
stack trace:
retroshare( 0xbbd2da)[0x558ccf46a2da]
retroshare(CrashStackTrace::abortHandler(int) 0xeb)[0x558ccf471c5c]
/lib64/libc.so.6( 0x38f80)[0x7f6ef6facf80]
/lib64/libc.so.6(realloc 0x54)[0x7f6ef6fffef4]
retroshare(RsTypeSerializer::RawMemoryWrapper::serial_process(RsGenericSerializer::SerializeJob, RsGenericSerializer::SerializeContext&) 0x5d4)[0x558ccfcddad0]
retroshare(std::enable_if<std::is_base_of<RsSerializable, RsTypeSerializer::RawMemoryWrapper>::value, void>::type RsTypeSerializer::serial_process<RsTypeSerializer::RawMemoryWrapper>(RsGenericSerializer::SerializeJob, RsGenericSerializer::SerializeContext&, RsTypeSerializer::RawMemoryWrapper&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) 0x9d)[0x558ccfb3da66]
retroshare(RsChatAvatarItem::serial_process(RsGenericSerializer::SerializeJob, RsGenericSerializer::SerializeContext&) 0x84)[0x558ccff90ba6]
retroshare(RsServiceSerializer::deserialise(void*, unsigned int*) 0x403)[0x558ccfcd96e9]
retroshare(RsSerialiser::deserialise(void*, unsigned int*) 0x38e)[0x558ccfb5a1a8]
retroshare(pqiSSLstore::readPkt(RsItem**) 0x3f9)[0x558ccfad329f]
retroshare(pqiSSLstore::GetItem() 0xbb)[0x558ccfad2d9f]
retroshare(pqiSSLstore::getEncryptedItems(std::__cxx11::list<RsItem*, std::allocator<RsItem*> >&) 0x3e)[0x558ccfad2c26]
retroshare(p3Config::loadAttempt(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::list<RsItem*, std::allocator<RsItem*> >&) 0xf8)[0x558ccfab20d0]
retroshare(p3Config::loadConfig() 0xeb)[0x558ccfab1d69]
retroshare(p3Config::loadConfiguration(t_RsGenericIdType<20u, false, (RsGenericIdType)2>&) 0x1c)[0x558ccfab1c7c]
retroshare(p3ConfigMgr::loadConfig() 0x97)[0x558ccfab17f3]
retroshare(p3ConfigMgr::loadConfiguration() 0x18)[0x558ccfab1758]
retroshare(RsServer::StartupRetroShare() 0x4407)[0x558ccfb02fab]
retroshare(main 0x17e2)[0x558ccf46d291]
/lib64/libc.so.6(__libc_start_main 0xeb)[0x7f6ef6f97e9b]
retroshare(_start 0x2a)[0x558ccf438c9a]
D 1585687209 void RetroDb::closeDb() sqlite3_close return: 0
D 1585687209 void RetroDb::closeDb() sqlite3_close return: 0
Memory still in use at end of program: 24776 bytes.
2020-04-14 12:17:03 +02:00
Gioacchino Mazzurco
0187bf2f2f
Suppress eccessive VLQ debugging 2020-04-14 12:17:03 +02:00
Gioacchino Mazzurco
d7f23ce21c
Deprecate unreliable Channels features
Fix licensing years
2020-04-14 12:17:03 +02:00