Commit Graph

3728 Commits

Author SHA1 Message Date
csoler
7aea6e5bf8 removed some debug info 2016-04-21 22:07:10 -04:00
csoler
eca83fdd62 removed some debug info 2016-04-21 19:54:50 -04:00
csoler
fba3d37126 fixed memory leak after receiving RsNxsItem deserialised from decrypted memory 2016-04-21 19:47:34 -04:00
csoler
0d3ff0e3aa fixed possible uninitialised memory read in memory decryption return 2016-04-21 19:46:47 -04:00
csoler
0c711a4c61 added missing calls to EVP_CIPHER_CTX_cleanup() to release memory after decryption, causing memory leaks 2016-04-21 19:41:21 -04:00
csoler
e82c217cd2 half-implemented packet slicing (QoS part done) 2016-04-20 22:42:09 -04:00
csoler
057249225e severely reduced packet grouping, which limited the effectiveness of QoS 2016-04-20 21:20:47 -04:00
csoler
aba3d2fb35 removed memory leak due to zeroing (on purpose!) a data chunk in GRouter before deleting it 2016-04-20 18:24:02 -04:00
csoler
d017771650 fixed missing sendTime in distant chat, causing inconsistent display in GUI 2016-04-20 18:10:53 -04:00
csoler
fc725b03a8 added some debug info to pqistreamer 2016-04-19 22:04:30 -04:00
csoler
39553a601c removed debug info 2016-04-19 21:58:30 -04:00
csoler
26af7c900e changed heart beat limit to a larger value. Apparently too tight a value causes disconnections due to packets being stuck sometimes (old bug) 2016-04-17 22:58:48 -04:00
csoler
34bd998c8e cleaned the mess in Circles, due to mixing up GxsIds and PgpIds, which is now irrelevant because items for external circles are not sent based on PGP signatures anymore 2016-04-17 17:13:42 -04:00
csoler
c14c240f07 fixed update of circles GUI using a timer. This is not optimal, and should be replaced by a proper notify call 2016-04-17 00:52:01 -04:00
csoler
3000f94999 separated subscribe status from wether we are part of a circle or not. Still needs update of GUI 2016-04-17 00:52:00 -04:00
csoler
fa8a585e20 removed some debug info 2016-04-15 18:25:53 -04:00
csoler
d642934cb5 increased frequency of update for banned PGP nodes 2016-04-15 18:25:41 -04:00
csoler
048192ee9c added mOriginator to CircleCache entry and auto-ask for unknown GXS ids to the friend who supplied the circle group 2016-04-14 23:47:42 -04:00
csoler
ba1a1b2a61 fixed auto-subscribed of circles when some IDs are unknown 2016-04-14 23:09:59 -04:00
Cyril Soler
a52bd98d4b fixed potential div by 0 in speed estimations. To be tested. 2016-04-11 10:10:10 -04:00
csoler
b148239e4f always pass data accept test in distant chat when we are on the client side of the tunnel 2016-04-10 21:09:47 -04:00
csoler
c97f197b7e removed depth obfucation of search results and replaced by 0 always, effectively removing any information about search depth (idea by AC) 2016-04-10 20:39:08 -04:00
csoler
0d5b9ae0d1 fixed last commit 2016-04-10 18:55:05 -04:00
csoler
b8075d65bd skip circle vetting when sending message posts with no author 2016-04-10 18:53:49 -04:00
csoler
a5044bd71c improved calculation of speed in pqistreamer (was called before only when sending bytes), and prevented situation where no HB is received by the connection is not reset because last HB is 0, causing ghost connected peers in GUI 2016-04-09 14:48:05 -04:00
csoler
993d7d4c8f removed debug info in rsgxsnetservice 2016-04-09 14:46:12 -04:00
csoler
0853773079 merged and removed debug output in rsgxsnetservice.cc 2016-04-09 12:51:15 -04:00
Cyril Soler
10a32d3c4e Merge pull request #343 from csoler/v0.6-Circles
V0.6 circles
2016-04-09 11:38:07 -04:00
csoler
ca0f76954e removed warning that would show up too often when a GxsTunnel is down and message cannot be sent 2016-04-08 21:08:22 -04:00
csoler
b90808dca8 changed update of server update TS in subscribeStatusChange from 0 to time(NULL) 2016-04-07 18:26:18 -04:00
Cyril Soler
c8cae4c33c Merge pull request #297 from PhenomRetroShare/Add_AllowOnlyOneIntanceAndPassArg
Allow only one instance. If exists, pass to it arguments.
2016-04-07 00:09:00 -04:00
csoler
4bf9262382 merged with upstream/master 2016-04-06 22:26:34 -04:00
csoler
60ffcd21b7 fixed double item deletion in RsGxsNetService::handleRecvItem() 2016-04-06 22:23:10 -04:00
csoler
c79c9bae5e added encryption of message sync requests for external circles-restricted groups, and verification that properly encrypted requests are sent before sending encrypted msg ID lists 2016-04-06 21:12:54 -04:00
Phenom
10bb542e83 Allow only one instance for useLocalServer option activated. If exists,
pass to it arguments.

For now, only allow to pass RsCollection file and retroshare://
protocol.
2016-04-06 22:04:53 +02:00
csoler
f26348b710 fixed bug in grouter which caused sending of messages to some offline peers, hence wasting some routes, and causing " p3ServiceServer::sendItem() Fails Filtering for packet id=2001810" messages. 2016-04-05 18:09:02 -04:00
csoler
18dd7ee7bd moved "too many routing clues" message to debug output, since it can be caused by normal lobby operation 2016-04-03 11:42:45 -04:00
csoler
3554e48c7e output packet error with some details (inspired by Phenom-PR289) 2016-04-03 11:38:53 -04:00
csoler
a3890ad1c3 added gathering of routing clues from lobbies 2016-04-03 11:00:03 -04:00
csoler
f8639e5486 fixed bug considering null PGP ids in ban list 2016-04-02 16:44:41 -04:00
csoler
5bbaa1e8e5 added people settings page, removed debug output 2016-04-02 16:14:18 -04:00
csoler
9d9b790a3e exposed un-verified PGP signatures on GXS ids in GUI. Added auto-ban of GXS ids signed by a PGP ids that has already signed a large enough set of GXS ids. Still needs some GUI to change the threshold. 2016-04-02 16:14:18 -04:00
Phenom
c6f1cc4e63 Clear WebAPI when clear chat history in GUI.
Move notifyChatCleared call to p3ChatService
To maintain notify direction.
2016-03-31 22:52:53 +02:00
zeners
aca88308ea compatible to g++11 / QT5
method suggested by cyril
2016-03-29 21:22:14 +02:00
electron128
5783c59463 Merge pull request #318 from realityfabric/remove_empty_file
Delete empty BUGS file
2016-03-29 20:16:44 +02:00
zeners
d96a8efb66 Merge branch 'master' 2016-03-26 23:38:18 +01:00
csoler
0c138d70ad moved discarding of banned identities from lobbies before signature checking, so as to avoid to time stamp their GXSId keys 2016-03-26 18:36:52 -04:00
zeners
922644f03e Merge branch 'master' 2016-03-26 23:24:29 +01:00
csoler
ebf54d1340 fixed unit tests 2016-03-26 17:25:15 -04:00
csoler
6c8737c84a merged with upstream/master 2016-03-25 21:09:37 -04:00
csoler
d1b09b93b9 removed some debug info 2016-03-25 18:54:13 -04:00
csoler
44cadc22b2 cleaned debug info and disabled local circles before merge 2016-03-24 19:46:08 -04:00
csoler
40d23509a1 removed deadlock 2016-03-23 21:50:41 -04:00
csoler
981f81deae added anon ids to offline vetting 2016-03-23 20:54:45 -04:00
csoler
57f4463864 fixed potential crash due to using deleted data (found by dimqua) 2016-03-23 18:23:10 -04:00
csoler
1fb1f3ebaf update of groups up to the latest attached circle server update TS. Should re-send groups that depend on a circle when the circle change 2016-03-21 23:21:26 -04:00
zeners
1c94ff743b Merge branch 'master' 2016-03-21 16:41:21 +01:00
Jessie
2fc533b8c3 Delete empty BUGS file 2016-03-21 07:59:00 -07:00
Phenom
b13292bb80 Fix error reported by CppChecker:
/libretroshare/src/gxs/rsgenexchange.cc:2850: erreur : Cppcheck:
Dereferencing 'grp' after it is deallocated / released
/libretroshare/src/gxstunnel/p3gxstunnel.cc:1004: erreur : Cppcheck:
Invalid usage of output stream: '<< std::cerr'.
/libretroshare/src/util/contentvalue.cc:185: erreur : Cppcheck: Memory
leak: dest
/openpgpsdk/src/openpgpsdk/reader_armoured.c:575: erreur : Cppcheck:
Common realloc mistake: 'buf' nulled but not freed upon failure
/retroshare-gui/src/gui/FileTransfer/DLListDelegate.cpp:103: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/FileTransfer/DLListDelegate.cpp:122: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/FileTransfer/DLListDelegate.cpp:141: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/FileTransfer/ULListDelegate.cpp:92: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/FileTransfer/ULListDelegate.cpp:111: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/People/PeopleDialog.cpp:774: erreur : Cppcheck:
Uninitialized variable: layout
/retroshare-gui/src/gui/People/PeopleDialog.cpp:864: erreur : Cppcheck:
Uninitialized variable: layout
/retroshare-gui/src/gui/common/AvatarWidget.cpp:225: erreur : Cppcheck:
Uninitialized variable: status
/retroshare-nogui/src/rpc/proto/rpcprotostream.cc:805: erreur :
Cppcheck: Memory leak: buffer
/supportlibs/pegmarkdown/GLibFacade.c:150: erreur : Cppcheck: va_list
'args' was opened but not closed by va_end().
/openpgpsdk/src/openpgpsdk/reader_armoured.c:575: erreur : Cppcheck:
Common realloc mistake: 'buf' nulled but not freed upon failure
/tests/unittests/libretroshare/serialiser/rsturtleitem_test.cc:213:
erreur : Cppcheck: Return value of allocation function 'init_item' is
not stored.
2016-03-20 13:12:30 +01:00
csoler
2e9d22c580 used RsTemporaryMemory to avoid memory leak in case of error in GxsTunnels 2016-03-19 18:47:59 -04:00
Cyril Soler
d1bb939344 Merge pull request #312 from PhenomRetroShare/AddPluginsPathForApple
Add Plugins Path for Apple
2016-03-19 17:14:00 -04:00
Phenom
5061046c96 Add Plugins Path for Apple
From Jenster
2016-03-19 18:58:00 +01:00
zeners
ecf8e7f127 Merge remote branch 'origin/master' 2016-03-19 17:39:34 +01:00
csoler
24ba909f41 fixed mixup between in/out bandwidth traffic info 2016-03-19 11:39:58 -04:00
csoler
31356bab96 added reload of grp meta on update 2016-03-16 21:27:46 -04:00
csoler
384131a231 added force reload of cache for circles that are modified 2016-03-15 22:41:59 -04:00
csoler
6466209553 added test to only subscribe/unsubscribe circles when needed, hence avoiding an unnecessary TS update 2016-03-15 22:11:36 -04:00
hunbernd
78f7ca81a9 Make it possible to open databases using SQLCipher v2 that were created with v3 2016-03-15 22:04:56 +01:00
hunbernd
ff5189996c Fixed display of SQLCipher version
RS used to show SQLite's version
2016-03-15 19:02:34 +01:00
csoler
80aaf30a01 fixed potential crash due to bad usage of updates 2016-03-15 00:00:39 -04:00
csoler
bdb326a989 attempt at fixing circle cache loop. Renamed a few variables and fixed logic. Not yet fully working 2016-03-14 23:19:37 -04:00
csoler
9c649aa58c improved debugDump(), showing the subscription status of each grp 2016-03-13 12:08:03 -04:00
csoler
051806227f fixed circle auto-subscribe 2016-03-13 11:29:21 -04:00
csoler
61c7da7e2d unselect all IDs when no circle is selected 2016-03-12 11:02:32 -05:00
zeners
b1da4ed67e Merge branch 'master' 2016-03-12 16:46:33 +01:00
csoler
5d2833fa42 improved one line of debug output in turtle 2016-03-12 09:25:28 -05:00
csoler
9e8a4cdac4 fixed auto-subscribe of circles when unsigned identities are locally owned 2016-03-11 22:36:47 -05:00
csoler
692b549f08 fixing compilation problem 2016-03-11 17:27:40 -05:00
csoler
232dba28ea allow non signature checking for GR message recepts at intermediate peers when key is missing. Should fix return receipt being lost in the way keeping messages in outbox 2016-03-11 17:21:27 -05:00
csoler
4eebe24ee2 disabled auto-sync for messages in GXS circles, while keeping Grp auto-sync 2016-03-09 20:23:33 -05:00
csoler
53f32f2dc8 added missing collection of some peers in p3gxscircles::recipients() 2016-03-04 13:45:35 -05:00
csoler
3c2c1df245 added test against empty circles 2016-03-03 21:37:36 -05:00
csoler
bb260696ce attempt at fixing negative bw rates in GUI that may pop up when an error is present in the SSL stream (e.g. when a peer disconnects/reconnects) 2016-03-02 19:00:51 -05:00
electron128
20fcf635e4 Merge pull request #285 from PhenomRetroShare/Fix_SSGxsChannelGroupLoadNullError
Fix error "(EE) SSGxsChannelGroup::load() asked to load a null string.
2016-02-26 18:13:20 +01:00
csoler
9ddef9e45b merged with upstream/master 2016-02-25 17:48:59 -05:00
Phenom
1a110e4ada Define empty service string as a valid case. 2016-02-25 13:58:45 +01:00
Phenom
3c3d23bf8a Fix error "(EE) SSGxsChannelGroup::load() asked to load a null string.
Weird." by creating a default serviceString if empty.
2016-02-25 13:58:45 +01:00
csoler
0bcf52c442 added missing update of mRecvTS in database when updating a group metadata 2016-02-24 16:51:56 -05:00
csoler
f5eb791230 added notification for modified metadata in group. Does not yet work on friends though. 2016-02-23 23:04:22 -05:00
csoler
b8c42a9eb7 added copy of previous subscription flags when group update is received. Avoids unsubscribing friends when publishing an update to grp metadata 2016-02-23 23:04:22 -05:00
csoler
fafe75dca6 added update of mServerUpdateTS up to last mRecvTS of each group, which holds the last time the grp meta data was received/modified 2016-02-23 23:04:22 -05:00
sehraf
dbdfdcd008 removed unused map lookups 2016-02-22 21:09:10 +01:00
sehraf
77166cbf13 impoved cleanup of unused locations 2016-02-22 16:41:31 +01:00
csoler
dcf86e6384 removed compilation warning and added warning about missing vetting for external circles 2016-02-21 12:00:09 -05:00
csoler
3446e20506 removed debug output from p3grouter.cc 2016-02-21 11:47:44 -05:00
csoler
0266b3cfa2 improved debug output in gxsnetservice.cc 2016-02-21 11:34:49 -05:00
csoler
edef6dc339 moved subscription flags when received group changes/create group to the case where the group is actually created (fixing bug causing group meta data change to unsubscribe friends) 2016-02-21 10:29:35 -05:00
electron128
dcbd99f0ab Merge pull request #202 from electron128/fixtests
make tests compile
2016-02-21 11:20:14 +01:00
csoler
09a6efad52 removed dead code in GxsSecurity 2016-02-20 21:25:21 -05:00
csoler
41a03eb331 fixed small bug causing update of TS to fail in encrypted NxsItems 2016-02-20 21:21:15 -05:00
csoler
6a4add8806 implemented per-item encryption and Vetting method compatibility layer 2016-02-20 17:53:03 -05:00
csoler
b2a6bfbbd0 fixed one bug in debug output of encrypted key offset 2016-02-19 20:55:27 -05:00
csoler
405ecefbf8 added proper decryption calls for partial decryption and possible re-try after loading keys. 2016-02-19 20:47:50 -05:00
zeners
5979d2f827 Merge branch 'master' into webui 2016-02-19 18:18:15 +01:00
Cyril Soler
5a48070171 Merge pull request #281 from sehraf/pr-disc-increase-auto-clean-time
discovery: don't remove new added locations too soon
2016-02-19 10:45:18 -05:00
sehraf
4140969fcb added seperated limit for discovery (30 days) 2016-02-19 16:35:11 +01:00
csoler
0293e246a2 fixed encryption method on the basis that encrypted keys always have the same length 2016-02-18 23:38:07 -05:00
csoler
6995212a8b added code for single item encryption/decryption 2016-02-18 21:30:52 -05:00
csoler
697ef4061c added test against arbitrary large items in turtle search requests. 2016-02-17 09:39:08 -05:00
csoler
51d90a4ef4 added test against arbitrary large items in turtle search requests. 2016-02-17 09:39:08 -05:00
csoler
08e4c90cc2 added single-block multiple encryption 2016-02-16 22:36:22 -05:00
Cyril Soler
d878334551 Merge pull request #206 from realityfabric/master
Added top level license file for GPL 2.0
2016-02-16 17:45:49 -05:00
sehraf
841299d077 discovery: don't remove new added locations too soon
was: removed after 10 min. or less - when no connection is established
now: removed after 1 day - when no connection is established
2016-02-16 20:33:38 +01:00
csoler
763108f5fa debugged transport of encrypted items. Still needs work. 2016-02-15 23:24:18 -05:00
csoler
0513e71c68 fixed sending part in encrypted msg items 2016-02-14 19:42:21 -05:00
Cyril Soler
efadc7d2c6 Merge pull request #270 from PhenomRetroShare/Fix_GxsChannelFilterWhenLoading
Fix Channel filter when loading big post.
2016-02-14 13:38:08 -05:00
Cyril Soler
3ab7c89660 Merge pull request #279 from cavebeat/single_dh_op
added openSSL option SSL_OP_SINGLE_DH_USE regarding CVE-2016-0701
2016-02-14 13:33:27 -05:00
cave beat
9843c8381b added openSSL option SSL_OP_SINGLE_DH_USE regarding CVE-2016-0701
tl;dr The OpenSSL 1.0.2 releases suffer from a Key Recovery Attack on DH small subgroups. This issue got assigned CVE-2016-0701 with a severity of High and OpenSSL 1.0.2 users should upgrade to 1.0.2f. If an application is using DH configured with parameters based on primes that are not "safe" or not Lim-Lee (as the one in RFC 5114) and either Static DH ciphersuites are used or DHE ciphersuites with the default OpenSSL configuration (in particular SSL_OP_SINGLE_DH_USE is not set) then is vulnerable to this attack.
2016-02-14 18:49:37 +01:00
electron128
fc5f8c3b8c removed unused function declaration ChatId::toGxsId() 2016-02-14 14:55:57 +01:00
electron128
821c14426c remove dead code from RsNotify (old forum and channel read status changed notify) 2016-02-14 12:48:52 +01:00
electron128
63a8260cb9 change RsNotify to use RsGxsId for chat lobby events 2016-02-14 11:53:27 +01:00
electron128
aa93505860 added missing lock in RsSharedPtr destructor 2016-02-13 11:55:27 +01:00
electron128
9f9221273a - make tests compile
- added tests to travis.yml
- excluded grouteritems and photoitems from test, because they changed too much
- disabled failing tests
- all tests pass in valgrind, without valgrind result is undefined
- to compile tests add CONFIG+=tests to qmake args. Then run tests/unittests/unittests
2016-02-13 11:55:25 +01:00
csoler
71071595c8 called re-loading of circles after creation. Added debug info in msg vetting 2016-02-11 21:59:45 -05:00
csoler
5ba8965523 fixed compilation 2016-02-10 22:18:55 -05:00
csoler
3db3ccf636 merged with upstream 2016-02-10 00:00:21 -05:00
Phenom
5f0afb3d6e Fix Channel filter when loading big post.
And fix "Not a GxsChannelPostItem, deleting!" error message

Don't search empty text in very long string.
2016-02-08 19:42:56 +01:00
thunder2
7ded128b3a Update rsversion.in 2016-02-06 19:18:22 +01:00
csoler
d9e512da8b fixed update of GroupNetworkStats and proper reset when loadList is called (thx Jo) 2016-02-03 18:58:28 -05:00
Cyril Soler
06b7417eed added comment in rsinit.cc for the initialisation of NetService for GxsIds 2016-02-02 12:34:26 -05:00
Cyril Soler
3664626704 added missing check for mNetService 2016-02-02 12:14:39 -05:00
Cyril Soler
dc9fadd7c9 added missing subscription change notify in rsgenexchange when creating a new group 2016-02-02 09:46:16 -05:00
Cyril Soler
a41d9df4da fixed small bug in probability computation in grouter 2016-02-01 09:59:13 -05:00
csoler
6d1a3937d6 fixed but in re-sending of failed grouter items 2016-02-01 00:33:11 -05:00
csoler
aa194caea3 fixed bug preventing save of routage info in distant messaging 2016-01-31 20:27:53 -05:00
csoler
a85b5d2fab re-enabled GRouter tunnels (disabled for testing). Removed debug output. 2016-01-30 20:35:08 -05:00
csoler
f0a49a427e changed global router routing strategy. Should be more effective now. 2016-01-30 20:27:56 -05:00
csoler
59d4c2c829 removed some compilation warnings 2016-01-30 20:27:27 -05:00
Cyril Soler
85cdfcc721 fixed bug causing multi-tunneling not to be used (found by jo) 2016-01-28 10:44:37 -05:00
csoler
3bc444b087 removed some debug info 2016-01-26 23:00:10 -05:00
csoler
2072ca4ade fixed bug in getPeerDetails causing callstacks to be displayed for non initialised IPs 2016-01-26 22:08:17 -05:00
csoler
b70057a540 removed sending probability in GXS since it is not justified anymore. This should fix peers not being updated because they have very low bandwidth. Removed and fixed a few minor warnings. 2016-01-26 18:50:33 -05:00
csoler
39b3df964a fixed bug causing net reset when closing config 2016-01-25 22:39:20 -05:00
csoler
9b64b96811 fixed potential crash in pqisslstore 2016-01-23 13:04:02 -05:00
csoler
55d0a213dd added cache of latest GXS tunnel data items for the last 10 minutes in order to avoid replays of messages caused by the conservative message transmition system. Removed the global item counter for a purely random uint64_t 2016-01-21 21:19:40 -05:00
csoler
7488ba19ff removed feedback from messages to mGrpServerUpdateTS, which is now only updated when the subscribe status is changed and/or new groups are received/created 2016-01-20 23:56:22 -05:00
csoler
c473200625 moved getCurrentTS() inside RTT packet sending loop (suggestion from Jo) 2016-01-20 23:34:25 -05:00
csoler
49c1d56945 increased GXS post size limit to just below 200K 2016-01-19 21:45:55 -05:00
csoler
43ee506adc added automatic GXS message rejection when item size exceeds 200K. Should fix the forums that got stuck because of a large message not being sent 2016-01-19 10:13:24 -05:00
csoler
dedd6d4cf4 disabled debug info 2016-01-18 23:54:03 -05:00