Commit Graph

3675 Commits

Author SHA1 Message Date
csoler
981f81deae added anon ids to offline vetting 2016-03-23 20:54:45 -04:00
csoler
57f4463864 fixed potential crash due to using deleted data (found by dimqua) 2016-03-23 18:23:10 -04:00
csoler
1fb1f3ebaf update of groups up to the latest attached circle server update TS. Should re-send groups that depend on a circle when the circle change 2016-03-21 23:21:26 -04:00
zeners
1c94ff743b Merge branch 'master' 2016-03-21 16:41:21 +01:00
Jessie
2fc533b8c3 Delete empty BUGS file 2016-03-21 07:59:00 -07:00
Phenom
b13292bb80 Fix error reported by CppChecker:
/libretroshare/src/gxs/rsgenexchange.cc:2850: erreur : Cppcheck:
Dereferencing 'grp' after it is deallocated / released
/libretroshare/src/gxstunnel/p3gxstunnel.cc:1004: erreur : Cppcheck:
Invalid usage of output stream: '<< std::cerr'.
/libretroshare/src/util/contentvalue.cc:185: erreur : Cppcheck: Memory
leak: dest
/openpgpsdk/src/openpgpsdk/reader_armoured.c:575: erreur : Cppcheck:
Common realloc mistake: 'buf' nulled but not freed upon failure
/retroshare-gui/src/gui/FileTransfer/DLListDelegate.cpp:103: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/FileTransfer/DLListDelegate.cpp:122: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/FileTransfer/DLListDelegate.cpp:141: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/FileTransfer/ULListDelegate.cpp:92: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/FileTransfer/ULListDelegate.cpp:111: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/People/PeopleDialog.cpp:774: erreur : Cppcheck:
Uninitialized variable: layout
/retroshare-gui/src/gui/People/PeopleDialog.cpp:864: erreur : Cppcheck:
Uninitialized variable: layout
/retroshare-gui/src/gui/common/AvatarWidget.cpp:225: erreur : Cppcheck:
Uninitialized variable: status
/retroshare-nogui/src/rpc/proto/rpcprotostream.cc:805: erreur :
Cppcheck: Memory leak: buffer
/supportlibs/pegmarkdown/GLibFacade.c:150: erreur : Cppcheck: va_list
'args' was opened but not closed by va_end().
/openpgpsdk/src/openpgpsdk/reader_armoured.c:575: erreur : Cppcheck:
Common realloc mistake: 'buf' nulled but not freed upon failure
/tests/unittests/libretroshare/serialiser/rsturtleitem_test.cc:213:
erreur : Cppcheck: Return value of allocation function 'init_item' is
not stored.
2016-03-20 13:12:30 +01:00
csoler
2e9d22c580 used RsTemporaryMemory to avoid memory leak in case of error in GxsTunnels 2016-03-19 18:47:59 -04:00
Cyril Soler
d1bb939344 Merge pull request #312 from PhenomRetroShare/AddPluginsPathForApple
Add Plugins Path for Apple
2016-03-19 17:14:00 -04:00
Phenom
5061046c96 Add Plugins Path for Apple
From Jenster
2016-03-19 18:58:00 +01:00
zeners
ecf8e7f127 Merge remote branch 'origin/master' 2016-03-19 17:39:34 +01:00
csoler
24ba909f41 fixed mixup between in/out bandwidth traffic info 2016-03-19 11:39:58 -04:00
csoler
31356bab96 added reload of grp meta on update 2016-03-16 21:27:46 -04:00
csoler
384131a231 added force reload of cache for circles that are modified 2016-03-15 22:41:59 -04:00
csoler
6466209553 added test to only subscribe/unsubscribe circles when needed, hence avoiding an unnecessary TS update 2016-03-15 22:11:36 -04:00
hunbernd
78f7ca81a9 Make it possible to open databases using SQLCipher v2 that were created with v3 2016-03-15 22:04:56 +01:00
hunbernd
ff5189996c Fixed display of SQLCipher version
RS used to show SQLite's version
2016-03-15 19:02:34 +01:00
csoler
80aaf30a01 fixed potential crash due to bad usage of updates 2016-03-15 00:00:39 -04:00
csoler
bdb326a989 attempt at fixing circle cache loop. Renamed a few variables and fixed logic. Not yet fully working 2016-03-14 23:19:37 -04:00
csoler
9c649aa58c improved debugDump(), showing the subscription status of each grp 2016-03-13 12:08:03 -04:00
csoler
051806227f fixed circle auto-subscribe 2016-03-13 11:29:21 -04:00
csoler
61c7da7e2d unselect all IDs when no circle is selected 2016-03-12 11:02:32 -05:00
zeners
b1da4ed67e Merge branch 'master' 2016-03-12 16:46:33 +01:00
csoler
5d2833fa42 improved one line of debug output in turtle 2016-03-12 09:25:28 -05:00
csoler
9e8a4cdac4 fixed auto-subscribe of circles when unsigned identities are locally owned 2016-03-11 22:36:47 -05:00
csoler
692b549f08 fixing compilation problem 2016-03-11 17:27:40 -05:00
csoler
232dba28ea allow non signature checking for GR message recepts at intermediate peers when key is missing. Should fix return receipt being lost in the way keeping messages in outbox 2016-03-11 17:21:27 -05:00
csoler
4eebe24ee2 disabled auto-sync for messages in GXS circles, while keeping Grp auto-sync 2016-03-09 20:23:33 -05:00
csoler
53f32f2dc8 added missing collection of some peers in p3gxscircles::recipients() 2016-03-04 13:45:35 -05:00
csoler
3c2c1df245 added test against empty circles 2016-03-03 21:37:36 -05:00
csoler
bb260696ce attempt at fixing negative bw rates in GUI that may pop up when an error is present in the SSL stream (e.g. when a peer disconnects/reconnects) 2016-03-02 19:00:51 -05:00
electron128
20fcf635e4 Merge pull request #285 from PhenomRetroShare/Fix_SSGxsChannelGroupLoadNullError
Fix error "(EE) SSGxsChannelGroup::load() asked to load a null string.
2016-02-26 18:13:20 +01:00
csoler
9ddef9e45b merged with upstream/master 2016-02-25 17:48:59 -05:00
Phenom
1a110e4ada Define empty service string as a valid case. 2016-02-25 13:58:45 +01:00
Phenom
3c3d23bf8a Fix error "(EE) SSGxsChannelGroup::load() asked to load a null string.
Weird." by creating a default serviceString if empty.
2016-02-25 13:58:45 +01:00
csoler
0bcf52c442 added missing update of mRecvTS in database when updating a group metadata 2016-02-24 16:51:56 -05:00
csoler
f5eb791230 added notification for modified metadata in group. Does not yet work on friends though. 2016-02-23 23:04:22 -05:00
csoler
b8c42a9eb7 added copy of previous subscription flags when group update is received. Avoids unsubscribing friends when publishing an update to grp metadata 2016-02-23 23:04:22 -05:00
csoler
fafe75dca6 added update of mServerUpdateTS up to last mRecvTS of each group, which holds the last time the grp meta data was received/modified 2016-02-23 23:04:22 -05:00
sehraf
dbdfdcd008 removed unused map lookups 2016-02-22 21:09:10 +01:00
sehraf
77166cbf13 impoved cleanup of unused locations 2016-02-22 16:41:31 +01:00
csoler
dcf86e6384 removed compilation warning and added warning about missing vetting for external circles 2016-02-21 12:00:09 -05:00
csoler
3446e20506 removed debug output from p3grouter.cc 2016-02-21 11:47:44 -05:00
csoler
0266b3cfa2 improved debug output in gxsnetservice.cc 2016-02-21 11:34:49 -05:00
csoler
edef6dc339 moved subscription flags when received group changes/create group to the case where the group is actually created (fixing bug causing group meta data change to unsubscribe friends) 2016-02-21 10:29:35 -05:00
electron128
dcbd99f0ab Merge pull request #202 from electron128/fixtests
make tests compile
2016-02-21 11:20:14 +01:00
csoler
09a6efad52 removed dead code in GxsSecurity 2016-02-20 21:25:21 -05:00
csoler
41a03eb331 fixed small bug causing update of TS to fail in encrypted NxsItems 2016-02-20 21:21:15 -05:00
csoler
6a4add8806 implemented per-item encryption and Vetting method compatibility layer 2016-02-20 17:53:03 -05:00
csoler
b2a6bfbbd0 fixed one bug in debug output of encrypted key offset 2016-02-19 20:55:27 -05:00
csoler
405ecefbf8 added proper decryption calls for partial decryption and possible re-try after loading keys. 2016-02-19 20:47:50 -05:00
zeners
5979d2f827 Merge branch 'master' into webui 2016-02-19 18:18:15 +01:00
Cyril Soler
5a48070171 Merge pull request #281 from sehraf/pr-disc-increase-auto-clean-time
discovery: don't remove new added locations too soon
2016-02-19 10:45:18 -05:00
sehraf
4140969fcb added seperated limit for discovery (30 days) 2016-02-19 16:35:11 +01:00
csoler
0293e246a2 fixed encryption method on the basis that encrypted keys always have the same length 2016-02-18 23:38:07 -05:00
csoler
6995212a8b added code for single item encryption/decryption 2016-02-18 21:30:52 -05:00
csoler
697ef4061c added test against arbitrary large items in turtle search requests. 2016-02-17 09:39:08 -05:00
csoler
51d90a4ef4 added test against arbitrary large items in turtle search requests. 2016-02-17 09:39:08 -05:00
csoler
08e4c90cc2 added single-block multiple encryption 2016-02-16 22:36:22 -05:00
Cyril Soler
d878334551 Merge pull request #206 from realityfabric/master
Added top level license file for GPL 2.0
2016-02-16 17:45:49 -05:00
sehraf
841299d077 discovery: don't remove new added locations too soon
was: removed after 10 min. or less - when no connection is established
now: removed after 1 day - when no connection is established
2016-02-16 20:33:38 +01:00
csoler
763108f5fa debugged transport of encrypted items. Still needs work. 2016-02-15 23:24:18 -05:00
csoler
0513e71c68 fixed sending part in encrypted msg items 2016-02-14 19:42:21 -05:00
Cyril Soler
efadc7d2c6 Merge pull request #270 from PhenomRetroShare/Fix_GxsChannelFilterWhenLoading
Fix Channel filter when loading big post.
2016-02-14 13:38:08 -05:00
Cyril Soler
3ab7c89660 Merge pull request #279 from cavebeat/single_dh_op
added openSSL option SSL_OP_SINGLE_DH_USE regarding CVE-2016-0701
2016-02-14 13:33:27 -05:00
cave beat
9843c8381b added openSSL option SSL_OP_SINGLE_DH_USE regarding CVE-2016-0701
tl;dr The OpenSSL 1.0.2 releases suffer from a Key Recovery Attack on DH small subgroups. This issue got assigned CVE-2016-0701 with a severity of High and OpenSSL 1.0.2 users should upgrade to 1.0.2f. If an application is using DH configured with parameters based on primes that are not "safe" or not Lim-Lee (as the one in RFC 5114) and either Static DH ciphersuites are used or DHE ciphersuites with the default OpenSSL configuration (in particular SSL_OP_SINGLE_DH_USE is not set) then is vulnerable to this attack.
2016-02-14 18:49:37 +01:00
electron128
fc5f8c3b8c removed unused function declaration ChatId::toGxsId() 2016-02-14 14:55:57 +01:00
electron128
821c14426c remove dead code from RsNotify (old forum and channel read status changed notify) 2016-02-14 12:48:52 +01:00
electron128
63a8260cb9 change RsNotify to use RsGxsId for chat lobby events 2016-02-14 11:53:27 +01:00
electron128
aa93505860 added missing lock in RsSharedPtr destructor 2016-02-13 11:55:27 +01:00
electron128
9f9221273a - make tests compile
- added tests to travis.yml
- excluded grouteritems and photoitems from test, because they changed too much
- disabled failing tests
- all tests pass in valgrind, without valgrind result is undefined
- to compile tests add CONFIG+=tests to qmake args. Then run tests/unittests/unittests
2016-02-13 11:55:25 +01:00
csoler
71071595c8 called re-loading of circles after creation. Added debug info in msg vetting 2016-02-11 21:59:45 -05:00
csoler
5ba8965523 fixed compilation 2016-02-10 22:18:55 -05:00
csoler
3db3ccf636 merged with upstream 2016-02-10 00:00:21 -05:00
Phenom
5f0afb3d6e Fix Channel filter when loading big post.
And fix "Not a GxsChannelPostItem, deleting!" error message

Don't search empty text in very long string.
2016-02-08 19:42:56 +01:00
thunder2
7ded128b3a Update rsversion.in 2016-02-06 19:18:22 +01:00
csoler
d9e512da8b fixed update of GroupNetworkStats and proper reset when loadList is called (thx Jo) 2016-02-03 18:58:28 -05:00
Cyril Soler
06b7417eed added comment in rsinit.cc for the initialisation of NetService for GxsIds 2016-02-02 12:34:26 -05:00
Cyril Soler
3664626704 added missing check for mNetService 2016-02-02 12:14:39 -05:00
Cyril Soler
dc9fadd7c9 added missing subscription change notify in rsgenexchange when creating a new group 2016-02-02 09:46:16 -05:00
Cyril Soler
a41d9df4da fixed small bug in probability computation in grouter 2016-02-01 09:59:13 -05:00
csoler
6d1a3937d6 fixed but in re-sending of failed grouter items 2016-02-01 00:33:11 -05:00
csoler
aa194caea3 fixed bug preventing save of routage info in distant messaging 2016-01-31 20:27:53 -05:00
csoler
a85b5d2fab re-enabled GRouter tunnels (disabled for testing). Removed debug output. 2016-01-30 20:35:08 -05:00
csoler
f0a49a427e changed global router routing strategy. Should be more effective now. 2016-01-30 20:27:56 -05:00
csoler
59d4c2c829 removed some compilation warnings 2016-01-30 20:27:27 -05:00
Cyril Soler
85cdfcc721 fixed bug causing multi-tunneling not to be used (found by jo) 2016-01-28 10:44:37 -05:00
csoler
3bc444b087 removed some debug info 2016-01-26 23:00:10 -05:00
csoler
2072ca4ade fixed bug in getPeerDetails causing callstacks to be displayed for non initialised IPs 2016-01-26 22:08:17 -05:00
csoler
b70057a540 removed sending probability in GXS since it is not justified anymore. This should fix peers not being updated because they have very low bandwidth. Removed and fixed a few minor warnings. 2016-01-26 18:50:33 -05:00
csoler
39b3df964a fixed bug causing net reset when closing config 2016-01-25 22:39:20 -05:00
csoler
9b64b96811 fixed potential crash in pqisslstore 2016-01-23 13:04:02 -05:00
csoler
55d0a213dd added cache of latest GXS tunnel data items for the last 10 minutes in order to avoid replays of messages caused by the conservative message transmition system. Removed the global item counter for a purely random uint64_t 2016-01-21 21:19:40 -05:00
csoler
7488ba19ff removed feedback from messages to mGrpServerUpdateTS, which is now only updated when the subscribe status is changed and/or new groups are received/created 2016-01-20 23:56:22 -05:00
csoler
c473200625 moved getCurrentTS() inside RTT packet sending loop (suggestion from Jo) 2016-01-20 23:34:25 -05:00
csoler
49c1d56945 increased GXS post size limit to just below 200K 2016-01-19 21:45:55 -05:00
csoler
43ee506adc added automatic GXS message rejection when item size exceeds 200K. Should fix the forums that got stuck because of a large message not being sent 2016-01-19 10:13:24 -05:00
csoler
dedd6d4cf4 disabled debug info 2016-01-18 23:54:03 -05:00
csoler
68a039540e fixed a few bugs in existing msg fragmentation code. Signature checking still not working, not NXS_FRAG stays disabled 2016-01-18 23:54:02 -05:00
csoler
39e6a9b61a fixed up People context menu so as to handle actions for multiple persons at once 2016-01-16 20:44:52 -05:00
csoler
1edfcf9731 do not time stamp banned GXS ids 2016-01-16 13:41:24 -05:00
thunder2
748147f73b Fixed Windows compile. 2016-01-15 21:41:23 +01:00
Cyril Soler
b5f6059485 deprecated updateClientSyncTS() which is not needed anymore 2016-01-15 10:07:21 -05:00
csoler
c24447fd21 fixed update of mGrpClientUpdateMap when no new group is available, avoiding unnecessary GXS grp list traffic (patch from jolavillette) 2016-01-14 20:11:26 -05:00
csoler
ed12b7a243 fixed merge 2016-01-13 20:57:03 -05:00
csoler
d2f56a5c53 merged with upstream/master 2016-01-13 20:52:55 -05:00
csoler
fd04f0b3bb updated to upstream/master 2016-01-13 20:27:08 -05:00
csoler
3b18c43d8e removed [dos] LF from rsgxsnetservice (causes merging rampage) 2016-01-13 20:25:18 -05:00
Cyril Soler
086b076477 fixed a few serialisation issues 2016-01-13 12:22:55 -05:00
Cyril Soler
96f3446aa7 added size limit to packet grouping 2016-01-13 11:13:23 -05:00
Cyril Soler
b56881e6d9 fixed windows compilation 2016-01-13 10:23:21 -05:00
csoler
60408b3799 fixed a bug in GRouterGenericDataItem::duplicate() 2016-01-13 00:13:16 -05:00
csoler
d55993d1e4 removed two instances of malloc(0) captured by new rs_malloc funtion 2016-01-12 21:43:04 -05:00
csoler
d13526facd added a new method rs_malloc that checks its arguments and prints a stacktrace on error/weird call. Changed the code everywhere to use this instead of malloc. Removed some mallocs and replaced with RsTemporaryMemory 2016-01-12 21:10:11 -05:00
csoler
9c6e7dfc13 added checks after mallocs in several files 2016-01-11 23:49:00 -05:00
csoler
46520b0e22 fixed potential integer overflow / Out of bounds read in gxstunnelitems.cc 2016-01-11 20:49:26 -05:00
csoler
8e666fcec3 fixed potential integer overflow / Out of bounds read in rsturtleitems.cc 2016-01-11 20:40:57 -05:00
csoler
98f0c101b9 fixed potential integer overflow / Out of bounds read in GRouterItems.cc 2016-01-11 19:26:54 -05:00
csoler
3094b52e8f fixed potential integer overflow / Out of bounds read in rsbaseserial.cc. Also added a few more error output. 2016-01-11 19:08:52 -05:00
electron128
8e6998b8d9 removed redundant map _lobby_ids from DistributedChatService.
The same information and more is stored in the _chat_lobbys map.
_lobby_ids is unused since commit 67e1495d9a
2016-01-10 14:34:08 +01:00
electron128
09ed1ea22c removed getVirtualPeerId method from rsmsgs lobby interface.
It is not neccesary anymore to have the virtual peer id exposed to the GUI layer.
2016-01-10 14:22:06 +01:00
electron128
67e1495d9a use ChatId instead of virtual peer id for chat lobby popup. Removed a now unused method from rsmsgs interface and DistributedChatService. 2016-01-10 13:29:40 +01:00
csoler
ee84ab732d fixed serialisation error (missing call) for received Distant msg hash map 2016-01-09 10:58:49 -05:00
csoler
fe02167ad7 disabled part of msg re-sending code in order to improve it later 2016-01-08 23:18:45 -05:00
csoler
3f6964bb8b added back messages to sent box 2016-01-08 22:50:03 -05:00
csoler
75edb46c99 added auto-resend of unsent messages. Fixed display of From field in outbox 2016-01-08 20:48:47 -05:00
csoler
0c591f08ae added auto re-send of distant messages after global router notified the message cannot be sent. Added a map n p3msgService to avoid receiving multiple times the same message. 2016-01-07 22:22:05 -05:00
csoler
9651f430d5 fixed wrong usage of local client ids in global router causing distant messages to stay in outbox forever. 2016-01-07 21:01:50 -05:00
csoler
4484b08b50 cleaned up the problem of outgoing messages being shown with the from from field. 2016-01-07 00:04:52 -05:00
csoler
3d6fa0cf8d fixed bug causing turtle to keep asking for a tunnel after a distant chat is closed if not connected 2016-01-06 18:38:27 -05:00
Cyril Soler
7da2ad14ec re-enabled previously disabled code in rsgxsnetservice, that proved useful 2016-01-06 10:31:59 -05:00
csoler
6398b7b9d6 added comment in rsgxsnetservice.cc 2016-01-05 23:00:26 -05:00
csoler
3fa8d863b5 removed time-stamp-ing of messages on client side in locked_genReqMsgTransaction() as it is already handled when receiving messages, and the need to stamp non subscribed groups is not justified anymore 2016-01-05 22:53:56 -05:00
csoler
678afe7a0f fixed stupid mistake in previous commit (GXS transaction timestamp) 2016-01-05 22:27:00 -05:00
csoler
7b3fd53bb9 added correct timestamp in msg list response items for GXS. To be tested. 2016-01-05 19:24:40 -05:00
Cyril Soler
9fd0fc54cc fixed bandwidth measurement in pqistreamer 2016-01-05 11:44:05 -05:00
csoler
9f7af84347 added debug output for encryption/decryption of transactions 2016-01-03 17:33:14 -05:00
Phenom
c5e6f62382 Make Plugin working in Mac OSX. 2016-01-02 14:19:53 +01:00
csoler
b6b5f9cd17 fixed some of the issues reported by coverity scan (mainly uninitialised class members) 2016-01-01 22:36:07 -05:00
csoler
8ec0e10019 updated v0.6-Circles with latest trunk 2016-01-01 22:18:43 -05:00
csoler
9da8a8abc3 fixed compilation of RsNxsTransaction encryption code 2016-01-01 21:37:27 -05:00
csoler
6ecd2991e7 merged with latest trunk 2016-01-01 15:15:19 -05:00
csoler
ab3939cd9a added missing update of mClientMsgUpdateMap, causing both a memory leak and an inconsistency in TS 2016-01-01 11:12:06 -05:00
electron128
58672e83a6 fix the logic to prevent using invalid iterators.
First make a valid iterator, then dereference it. Not the other way round.
This bug can randomly prevent gxs group stats from being collected from peers.
2016-01-01 13:51:35 +01:00
electron128
9cb81f57ea don't create wiki dataservice if wiki is not enabled for compile 2016-01-01 12:01:49 +01:00
electron128
55ea8a54f8 init pointer in RsServer 2016-01-01 11:49:03 +01:00
electron128
7efb763191 restore stream state of std::cerr after printing hex number 2016-01-01 11:38:29 +01:00
electron128
640d71b8af removed delete of RsTemporaryMemory 2016-01-01 11:09:49 +01:00
Gio
78959326b6 print_stacktrace is OS specific 2016-01-01 00:45:01 +01:00
Gio
c5feafa1d2 Add missing stacktrace.h 2015-12-31 19:56:50 +01:00
Gio
1303d855e6 more cleanups + sanitize p3Peers::getPeerDetails avoid to look for port on null sockaddr_storage 2015-12-31 19:32:46 +01:00