Commit Graph

563 Commits

Author SHA1 Message Date
csoler
951f29f155 removed debug info in rsDataService 2016-07-10 23:00:47 -04:00
Cyril Soler
1c277ab81b Merge pull request #433 from csoler/v0.6-SqlCache
V0.6 sql cache
2016-07-05 23:47:55 -04:00
csoler
218ca45ac8 removed some debug info in rsdataservice 2016-07-03 23:12:56 -04:00
csoler
e611b2bb05 moved isIdentitybanned from p3GxsReputations to p3IdService, so as to avoid calling back p3IdService from p3GxsReputations, which simplifies the code 2016-07-03 18:06:01 -04:00
csoler
86d8f01033 added a local cache in rsdataservice to avoid calling sqlcipher on GrpMetaData 2016-07-01 23:38:10 -04:00
csoler
ba500284c7 added GXS distribution flag to defavor posts signed by key form unknown RS nodes, and updated UI in forums to use it 2016-06-30 14:16:45 -04:00
csoler
9f7ef8b46b fixed possible cross deadlocks between RsGxsGenExchange and RsGxsNetService 2016-06-28 20:59:56 -04:00
csoler
f57f620111 reduced database testing/cleaning frequency to 31/59 mins. 2016-06-17 22:27:00 -04:00
csoler
eb05922cd1 added a tooltip and read color for unsecure GXS identities. These are still supported for a few weeks at most. So get rid of them 2016-06-17 22:21:06 -04:00
csoler
4df4bb638f fixed removal of messages in unsubscribed groups 2016-06-17 20:46:58 -04:00
csoler
886d896151 fixed warning about old fingerprint for own keys. 2016-06-17 20:46:24 -04:00
csoler
c25b65074a removed check key debug info 2016-06-16 23:10:13 -04:00
csoler
25c0c9d4ce added systematic consistency checking of public/private RSA keys at deserialisation time 2016-06-16 23:06:07 -04:00
csoler
8d54603b02 fixed bug in private key extraction 2016-06-16 21:27:28 -04:00
csoler
dbd78d2401 merged with upstream/master 2016-06-16 20:19:03 -04:00
csoler
e63f9361f2 improved strategy for removal of unused GXS ids with proper constants for unknown/signed/known ids. Forbid the stamping of banned keys. 2016-06-15 21:33:27 -04:00
csoler
e03c5dfe56 improved GUI layout in circle creation box. Added tooltips 2016-06-13 22:38:51 -04:00
csoler
600607d879 added warning for old peers in circles 2016-06-13 22:14:09 -04:00
csoler
fa29dd7332 changed the way RsGxsSyncMsgReqItem are sent for circle-restricted groups, using a hash of the group ID instead of encrypting the whole item, hense saving a lot of bandwidth on msg sync. 2016-06-12 21:41:09 -04:00
csoler
eb9025d9a4 removed annoying warning when a circle is empty 2016-06-11 17:20:22 -04:00
csoler
c2ae4fc904 merged upstream/master 2016-06-05 10:06:11 -04:00
csoler
a2ca0385db fixed compilation and several problems following separation of public/private keys 2016-06-04 21:39:40 -04:00
csoler
814db7ed55 fixed possible uninitialised memory read 2016-06-03 19:15:16 +02:00
csoler
590be092e5 separated RsTlvSecurityKey into two incompatible classes to enforce the correct usage of private vs. public keys 2016-06-02 23:47:57 -04:00
csoler
e2b5785eec merged PR403 with trunk 2016-06-02 21:15:51 -04:00
csoler
10e0254317 fixed a few things to correct PR403 2016-06-02 20:38:33 -04:00
sehraf
4f60c8cc9b libretroshare: fix comparison between signed and unsigned integer 2016-06-02 14:54:23 +02:00
sehraf
8b788b2aa8 libretroshare: fix member initialisation order 2016-06-02 14:54:16 +02:00
sehraf
f16ee97093 add static thread names 2016-06-01 16:21:55 +02:00
csoler
722609a3e6 finished implementing the backend part for the subscription system 2016-05-18 21:13:54 -04:00
csoler
89472d6502 put some notes and comments in the code for what is to be done 2016-05-17 00:00:15 -04:00
csoler
70648398e2 merged with upstream/master 2016-05-01 15:22:13 -04:00
csoler
7914aeb60a use RsTemporaryMemory in signature verification 2016-04-30 17:33:47 -04:00
csoler
be7e87cb1e use RsTemporaryMemory in signature verification 2016-04-30 17:25:24 -04:00
csoler
55e80871eb added missing free for public keys used in envelop encryption 2016-04-22 17:30:55 -04:00
csoler
7aea6e5bf8 removed some debug info 2016-04-21 22:07:10 -04:00
csoler
eca83fdd62 removed some debug info 2016-04-21 19:54:50 -04:00
csoler
fba3d37126 fixed memory leak after receiving RsNxsItem deserialised from decrypted memory 2016-04-21 19:47:34 -04:00
csoler
0d3ff0e3aa fixed possible uninitialised memory read in memory decryption return 2016-04-21 19:46:47 -04:00
csoler
0c711a4c61 added missing calls to EVP_CIPHER_CTX_cleanup() to release memory after decryption, causing memory leaks 2016-04-21 19:41:21 -04:00
csoler
39553a601c removed debug info 2016-04-19 21:58:30 -04:00
csoler
34bd998c8e cleaned the mess in Circles, due to mixing up GxsIds and PgpIds, which is now irrelevant because items for external circles are not sent based on PGP signatures anymore 2016-04-17 17:13:42 -04:00
csoler
3000f94999 separated subscribe status from wether we are part of a circle or not. Still needs update of GUI 2016-04-17 00:52:00 -04:00
csoler
fa8a585e20 removed some debug info 2016-04-15 18:25:53 -04:00
csoler
048192ee9c added mOriginator to CircleCache entry and auto-ask for unknown GXS ids to the friend who supplied the circle group 2016-04-14 23:47:42 -04:00
csoler
123041a684 skip circle vetting when sending message posts with no author 2016-04-10 18:59:36 -04:00
csoler
993d7d4c8f removed debug info in rsgxsnetservice 2016-04-09 14:46:12 -04:00
csoler
b90808dca8 changed update of server update TS in subscribeStatusChange from 0 to time(NULL) 2016-04-07 18:26:18 -04:00
csoler
60ffcd21b7 fixed double item deletion in RsGxsNetService::handleRecvItem() 2016-04-06 22:23:10 -04:00
csoler
c79c9bae5e added encryption of message sync requests for external circles-restricted groups, and verification that properly encrypted requests are sent before sending encrypted msg ID lists 2016-04-06 21:12:54 -04:00
csoler
6c8737c84a merged with upstream/master 2016-03-25 21:09:37 -04:00
csoler
d1b09b93b9 removed some debug info 2016-03-25 18:54:13 -04:00
csoler
44cadc22b2 cleaned debug info and disabled local circles before merge 2016-03-24 19:46:08 -04:00
csoler
981f81deae added anon ids to offline vetting 2016-03-23 20:54:45 -04:00
csoler
57f4463864 fixed potential crash due to using deleted data (found by dimqua) 2016-03-23 18:23:10 -04:00
csoler
1fb1f3ebaf update of groups up to the latest attached circle server update TS. Should re-send groups that depend on a circle when the circle change 2016-03-21 23:21:26 -04:00
Phenom
b13292bb80 Fix error reported by CppChecker:
/libretroshare/src/gxs/rsgenexchange.cc:2850: erreur : Cppcheck:
Dereferencing 'grp' after it is deallocated / released
/libretroshare/src/gxstunnel/p3gxstunnel.cc:1004: erreur : Cppcheck:
Invalid usage of output stream: '<< std::cerr'.
/libretroshare/src/util/contentvalue.cc:185: erreur : Cppcheck: Memory
leak: dest
/openpgpsdk/src/openpgpsdk/reader_armoured.c:575: erreur : Cppcheck:
Common realloc mistake: 'buf' nulled but not freed upon failure
/retroshare-gui/src/gui/FileTransfer/DLListDelegate.cpp:103: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/FileTransfer/DLListDelegate.cpp:122: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/FileTransfer/DLListDelegate.cpp:141: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/FileTransfer/ULListDelegate.cpp:92: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/FileTransfer/ULListDelegate.cpp:111: erreur :
Cppcheck: Array 'byteUnits[4]' accessed at index 4, which is out of
bounds.
/retroshare-gui/src/gui/People/PeopleDialog.cpp:774: erreur : Cppcheck:
Uninitialized variable: layout
/retroshare-gui/src/gui/People/PeopleDialog.cpp:864: erreur : Cppcheck:
Uninitialized variable: layout
/retroshare-gui/src/gui/common/AvatarWidget.cpp:225: erreur : Cppcheck:
Uninitialized variable: status
/retroshare-nogui/src/rpc/proto/rpcprotostream.cc:805: erreur :
Cppcheck: Memory leak: buffer
/supportlibs/pegmarkdown/GLibFacade.c:150: erreur : Cppcheck: va_list
'args' was opened but not closed by va_end().
/openpgpsdk/src/openpgpsdk/reader_armoured.c:575: erreur : Cppcheck:
Common realloc mistake: 'buf' nulled but not freed upon failure
/tests/unittests/libretroshare/serialiser/rsturtleitem_test.cc:213:
erreur : Cppcheck: Return value of allocation function 'init_item' is
not stored.
2016-03-20 13:12:30 +01:00
csoler
31356bab96 added reload of grp meta on update 2016-03-16 21:27:46 -04:00
csoler
80aaf30a01 fixed potential crash due to bad usage of updates 2016-03-15 00:00:39 -04:00
csoler
bdb326a989 attempt at fixing circle cache loop. Renamed a few variables and fixed logic. Not yet fully working 2016-03-14 23:19:37 -04:00
csoler
9c649aa58c improved debugDump(), showing the subscription status of each grp 2016-03-13 12:08:03 -04:00
csoler
051806227f fixed circle auto-subscribe 2016-03-13 11:29:21 -04:00
csoler
61c7da7e2d unselect all IDs when no circle is selected 2016-03-12 11:02:32 -05:00
csoler
3c2c1df245 added test against empty circles 2016-03-03 21:37:36 -05:00
csoler
9ddef9e45b merged with upstream/master 2016-02-25 17:48:59 -05:00
csoler
0bcf52c442 added missing update of mRecvTS in database when updating a group metadata 2016-02-24 16:51:56 -05:00
csoler
f5eb791230 added notification for modified metadata in group. Does not yet work on friends though. 2016-02-23 23:04:22 -05:00
csoler
b8c42a9eb7 added copy of previous subscription flags when group update is received. Avoids unsubscribing friends when publishing an update to grp metadata 2016-02-23 23:04:22 -05:00
csoler
fafe75dca6 added update of mServerUpdateTS up to last mRecvTS of each group, which holds the last time the grp meta data was received/modified 2016-02-23 23:04:22 -05:00
csoler
dcf86e6384 removed compilation warning and added warning about missing vetting for external circles 2016-02-21 12:00:09 -05:00
csoler
0266b3cfa2 improved debug output in gxsnetservice.cc 2016-02-21 11:34:49 -05:00
csoler
edef6dc339 moved subscription flags when received group changes/create group to the case where the group is actually created (fixing bug causing group meta data change to unsubscribe friends) 2016-02-21 10:29:35 -05:00
csoler
09a6efad52 removed dead code in GxsSecurity 2016-02-20 21:25:21 -05:00
csoler
41a03eb331 fixed small bug causing update of TS to fail in encrypted NxsItems 2016-02-20 21:21:15 -05:00
csoler
6a4add8806 implemented per-item encryption and Vetting method compatibility layer 2016-02-20 17:53:03 -05:00
csoler
b2a6bfbbd0 fixed one bug in debug output of encrypted key offset 2016-02-19 20:55:27 -05:00
csoler
405ecefbf8 added proper decryption calls for partial decryption and possible re-try after loading keys. 2016-02-19 20:47:50 -05:00
csoler
0293e246a2 fixed encryption method on the basis that encrypted keys always have the same length 2016-02-18 23:38:07 -05:00
csoler
6995212a8b added code for single item encryption/decryption 2016-02-18 21:30:52 -05:00
csoler
08e4c90cc2 added single-block multiple encryption 2016-02-16 22:36:22 -05:00
csoler
763108f5fa debugged transport of encrypted items. Still needs work. 2016-02-15 23:24:18 -05:00
csoler
0513e71c68 fixed sending part in encrypted msg items 2016-02-14 19:42:21 -05:00
electron128
9f9221273a - make tests compile
- added tests to travis.yml
- excluded grouteritems and photoitems from test, because they changed too much
- disabled failing tests
- all tests pass in valgrind, without valgrind result is undefined
- to compile tests add CONFIG+=tests to qmake args. Then run tests/unittests/unittests
2016-02-13 11:55:25 +01:00
csoler
71071595c8 called re-loading of circles after creation. Added debug info in msg vetting 2016-02-11 21:59:45 -05:00
csoler
5ba8965523 fixed compilation 2016-02-10 22:18:55 -05:00
csoler
3db3ccf636 merged with upstream 2016-02-10 00:00:21 -05:00
csoler
d9e512da8b fixed update of GroupNetworkStats and proper reset when loadList is called (thx Jo) 2016-02-03 18:58:28 -05:00
Cyril Soler
3664626704 added missing check for mNetService 2016-02-02 12:14:39 -05:00
Cyril Soler
dc9fadd7c9 added missing subscription change notify in rsgenexchange when creating a new group 2016-02-02 09:46:16 -05:00
csoler
b70057a540 removed sending probability in GXS since it is not justified anymore. This should fix peers not being updated because they have very low bandwidth. Removed and fixed a few minor warnings. 2016-01-26 18:50:33 -05:00
csoler
7488ba19ff removed feedback from messages to mGrpServerUpdateTS, which is now only updated when the subscribe status is changed and/or new groups are received/created 2016-01-20 23:56:22 -05:00
csoler
49c1d56945 increased GXS post size limit to just below 200K 2016-01-19 21:45:55 -05:00
csoler
43ee506adc added automatic GXS message rejection when item size exceeds 200K. Should fix the forums that got stuck because of a large message not being sent 2016-01-19 10:13:24 -05:00
csoler
dedd6d4cf4 disabled debug info 2016-01-18 23:54:03 -05:00
csoler
68a039540e fixed a few bugs in existing msg fragmentation code. Signature checking still not working, not NXS_FRAG stays disabled 2016-01-18 23:54:02 -05:00
csoler
39e6a9b61a fixed up People context menu so as to handle actions for multiple persons at once 2016-01-16 20:44:52 -05:00
csoler
1edfcf9731 do not time stamp banned GXS ids 2016-01-16 13:41:24 -05:00
Cyril Soler
b5f6059485 deprecated updateClientSyncTS() which is not needed anymore 2016-01-15 10:07:21 -05:00
csoler
c24447fd21 fixed update of mGrpClientUpdateMap when no new group is available, avoiding unnecessary GXS grp list traffic (patch from jolavillette) 2016-01-14 20:11:26 -05:00
csoler
ed12b7a243 fixed merge 2016-01-13 20:57:03 -05:00
csoler
d2f56a5c53 merged with upstream/master 2016-01-13 20:52:55 -05:00
csoler
fd04f0b3bb updated to upstream/master 2016-01-13 20:27:08 -05:00
csoler
3b18c43d8e removed [dos] LF from rsgxsnetservice (causes merging rampage) 2016-01-13 20:25:18 -05:00
csoler
d55993d1e4 removed two instances of malloc(0) captured by new rs_malloc funtion 2016-01-12 21:43:04 -05:00
csoler
d13526facd added a new method rs_malloc that checks its arguments and prints a stacktrace on error/weird call. Changed the code everywhere to use this instead of malloc. Removed some mallocs and replaced with RsTemporaryMemory 2016-01-12 21:10:11 -05:00
csoler
9c6e7dfc13 added checks after mallocs in several files 2016-01-11 23:49:00 -05:00
Cyril Soler
7da2ad14ec re-enabled previously disabled code in rsgxsnetservice, that proved useful 2016-01-06 10:31:59 -05:00
csoler
6398b7b9d6 added comment in rsgxsnetservice.cc 2016-01-05 23:00:26 -05:00
csoler
3fa8d863b5 removed time-stamp-ing of messages on client side in locked_genReqMsgTransaction() as it is already handled when receiving messages, and the need to stamp non subscribed groups is not justified anymore 2016-01-05 22:53:56 -05:00
csoler
678afe7a0f fixed stupid mistake in previous commit (GXS transaction timestamp) 2016-01-05 22:27:00 -05:00
csoler
7b3fd53bb9 added correct timestamp in msg list response items for GXS. To be tested. 2016-01-05 19:24:40 -05:00
csoler
9f7af84347 added debug output for encryption/decryption of transactions 2016-01-03 17:33:14 -05:00
csoler
b6b5f9cd17 fixed some of the issues reported by coverity scan (mainly uninitialised class members) 2016-01-01 22:36:07 -05:00
csoler
8ec0e10019 updated v0.6-Circles with latest trunk 2016-01-01 22:18:43 -05:00
csoler
9da8a8abc3 fixed compilation of RsNxsTransaction encryption code 2016-01-01 21:37:27 -05:00
csoler
6ecd2991e7 merged with latest trunk 2016-01-01 15:15:19 -05:00
csoler
ab3939cd9a added missing update of mClientMsgUpdateMap, causing both a memory leak and an inconsistency in TS 2016-01-01 11:12:06 -05:00
electron128
58672e83a6 fix the logic to prevent using invalid iterators.
First make a valid iterator, then dereference it. Not the other way round.
This bug can randomly prevent gxs group stats from being collected from peers.
2016-01-01 13:51:35 +01:00
csoler
8a41554754 fixed some leaking memory issues in loadList() methods, and also increased consistency by not returning non empty list with deleted items inside 2015-12-30 18:20:09 -05:00
csoler
0299691a54 removed overkill test that would cause sending updates to peers when no messages are available (thx jo) 2015-12-30 11:14:10 -05:00
csoler
9e0dc01110 changed the reset of client map into a reset f server map when subscribing a group 2015-12-29 17:31:35 -05:00
Cyril Soler
f30f71db8e Merge pull request #218 from csoler/v0.6-ContactList
V0.6 contact list
2015-12-23 18:07:10 -05:00
csoler
98b27d6a2b moved notify calls to RsGenExchange out of RsGxsNetService lock zone, to avoid deadlocks 2015-12-23 11:18:26 -05:00
Phenom
1346259411 Miss recomment NXS_NET_DEBUG_0... 2015-12-23 13:45:39 +01:00
Phenom
4aea100e4f From jolavillette-morkitu: in rsgxsnetservice.cc when #define
NXS_NET_DEBUG_0 is set to 1 the compilation fails with:
gxs/rsgxsnetservice.cc: In member function ‘void
RsGxsNetService::updateClientSyncTS()’:
gxs/rsgxsnetservice.cc:1686:117: error: ‘now’ was not declared in this
scope
2015-12-23 13:40:01 +01:00
csoler
5d9272055f merged with upstream/master 2015-12-22 18:33:01 -05:00
csoler
d4926cbc61 fixed a number of memory leaks in gxsnetservice. Used a class that auto-deletes retrieved items. 2015-12-20 20:35:48 -05:00
csoler
462f969da7 merged with upstream/master 2015-12-19 19:15:48 -05:00
csoler
ccc5f0f8fc improved debug info in rsgxsnetservice 2015-12-19 19:04:49 -05:00
csoler
5fcaa36736 fixed some serialising bugs, and added proper notification of observer 2015-12-19 19:00:06 -05:00
csoler
6910ad3695 added stats exchange system to gather number of posts in unsubscribed groups without the need to actually DL the messages (reduced bw a lot) 2015-12-19 17:38:52 -05:00
csoler
b1b75a35a1 fixed stupid bug causing cleanRejectedMessages() to be called continuously 2015-12-18 08:07:00 -05:00
csoler
e8b881b2f1 added rejection list to gxsnetservice that is fed by calls from GenExchange system, to avoid infinitely re-downloading rejected messages due to bad reputation, bad signatures, missing ids, etc 2015-12-17 23:08:02 -05:00
csoler
55e66d090c fixed mismatch between API versions causing signed groups created with old API to fail author signature checking 2015-12-17 00:08:08 -05:00
csoler
dc034fe523 removed debug info from GxsNetService 2015-12-15 23:17:35 -05:00
csoler
0c4fd8e274 added missing time-stamping of keys 2015-12-15 18:13:40 -05:00
csoler
3617f9ced0 added NXS_NET_DEBUG_5 to print summary of incoming items 2015-12-15 18:09:49 -05:00
csoler
92780b7688 added auto-request of missing GXS ids for group posts authors and group authors 2015-12-15 18:01:03 -05:00
csoler
8d886b8ecc added regular timestamp-ing of GXS ids of group authors and group post authors for all subscribed groups 2015-12-15 12:31:03 -05:00
csoler
3f132f2c33 added missing timestamp at message creation time and group creation time 2015-12-14 21:13:44 -05:00
csoler
f702c942ed added a few methods to improve consistency between client and server sides, and force update of groups in some cases (such as database erased) 2015-12-13 18:22:04 -05:00
csoler
ed7a261001 added check for NULL client update map in rsgxsnetservice::debugDump() 2015-12-12 21:07:48 -05:00
csoler
ad1aafebf7 added missing mutex 2015-12-12 14:05:45 -05:00
csoler
534be72360 improved debug info in rsgxsnetservice.cc 2015-12-11 22:54:45 -05:00
csoler
7be7233b29 fixed a number of timing issues in rsgxsnetservice. To be tested. 2015-12-11 22:38:17 -05:00
csoler
66d6f053f5 added debugDump() method to display update timestamps of GXS groups on both sides 2015-12-11 19:01:20 -05:00
csoler
16d815f891 added protocol documentation in rsgxsnetservice.cc 2015-12-11 18:03:44 -05:00
csoler
039db26cd2 improved debug info in rsgxsnetservice.cc 2015-12-10 22:25:09 -05:00
csoler
c9af8e3240 improved debug info in rsgxsnetservice.cc 2015-12-10 22:08:28 -05:00
csoler
3cb3662d2d improved debug info in rsgxsnetservice.cc 2015-12-10 21:54:48 -05:00