Commit Graph

12658 Commits

Author SHA1 Message Date
Gioacchino Mazzurco
c0ca1a5aad
Print stack trace on crash 2018-11-05 00:19:45 +01:00
csoler
d711e09b68
fixed bug causing IdChooser to reset the current id 2018-11-03 20:25:32 +01:00
csoler
1f8ecc024d
Merge pull request #1378 from csoler/v0.6-ImprovedGUI
V0.6 improved gui
2018-11-02 20:30:30 +01:00
csoler
af86b29f2b
moved initialization to initializer list in HomePage 2018-11-02 20:26:49 +01:00
csoler
4aedfddb9f
fixed bug in GRouter failing to set proper service ID in return receipts 2018-11-01 22:10:17 +01:00
csoler
33b39a8be6
removed uninitialized memory read in determination of own IP 2018-11-01 22:05:22 +01:00
csoler
cb5d247565
removed unnecessry debug output from pqissl 2018-11-01 21:45:59 +01:00
csoler
eb078d462e
added more info to deserialization warning in rsrecogn 2018-11-01 21:42:07 +01:00
csoler
9a2bbe339a
fixed uninitialized memory read due to not checking the result of beMsgGetNodeId() in bitdht 2018-11-01 21:40:56 +01:00
csoler
84aedb8ac7
removed uninitialized memory read in updateOwnCert() 2018-11-01 20:28:09 +01:00
csoler
3c6dd1af1c
removed unnecessary saving of config in p3turtle 2018-10-28 17:45:21 +01:00
csoler
20391371c7
fixed bug causing some GXS sync tunnels to remain unused and prevent new tunnels to be created 2018-10-28 17:29:48 +01:00
G10h4ck
b603b9b4c7
Merge pull request #1381 from G10h4ck/conservative_ext_port
Avoid external port being reset without necessity
2018-10-27 19:46:43 +02:00
Gioacchino Mazzurco
e5805e9047
Avoid external port being reset without necessity
Fix RetroSahre behaviour when manually configured external port is
  different to local port
2018-10-24 05:39:31 +02:00
G10h4ck
966cd27cd7
Merge pull request #1372 from PhenomRetroShare/Fix_Warnings
Fix warnings
2018-10-24 01:53:52 +02:00
Phenom
89082f3420 Fix warnings in RetroShareLink
/retroshare-gui/src/gui/RetroShareLink.cpp:1556: warning: this statement
may fall through [-Wimplicit-fallthrough=]
/retroshare-gui/src/gui/RetroShareLink.cpp:400: warning: implicit
conversion loses integer precision: 'qulonglong' (aka 'unsigned long
long') to 'uint32_t' (aka 'unsigned int')
/retroshare-gui/src/gui/RetroShareLink.cpp:736: warning: use of old-
style cast
/retroshare-gui/src/gui/RetroShareLink.cpp:733: warning: unannotated
fall-through between switch labels
/retroshare-gui/src/gui/RetroShareLink.cpp:1175: warning: implicit
conversion changes signedness: 'char' to 'unsigned char'
/retroshare-gui/src/gui/RetroShareLink.cpp:1193: warning: implicit
conversion changes signedness: 'char' to 'unsigned char'
/retroshare-gui/src/gui/RetroShareLink.cpp:1208: warning: implicit
conversion changes signedness: 'char' to 'unsigned char'
/retroshare-gui/src/gui/RetroShareLink.cpp:1228: warning: implicit
conversion changes signedness: 'char' to 'unsigned char'
/retroshare-gui/src/gui/RetroShareLink.cpp:1261: warning: implicit
conversion changes signedness: 'int' to 'unsigned int'
/retroshare-gui/src/gui/RetroShareLink.cpp:1507: warning: zero as null
pointer constant
/retroshare-gui/src/gui/RetroShareLink.cpp:1621: warning: zero as null
pointer constant
/retroshare-gui/src/gui/RetroShareLink.cpp:1696: warning: zero as null
pointer constant
/retroshare-gui/src/gui/RetroShareLink.cpp:1698: warning: zero as null
pointer constant
/retroshare-gui/src/gui/RetroShareLink.cpp:1742: warning: zero as null
pointer constant
/retroshare-gui/src/gui/RetroShareLink.cpp:1775: warning: implicit
conversion changes signedness: 'int' to 'unsigned int'
/retroshare-gui/src/gui/RetroShareLink.cpp:1779: warning: implicit
conversion changes signedness: 'int' to 'unsigned int'
/retroshare-gui/src/gui/RetroShareLink.cpp:1559: warning: unannotated
fall-through between switch labels
2018-10-23 17:43:01 +02:00
Phenom
358f27be06 Fix warnings in MessagePage.cpp
/retroshare-gui/src/gui/settings/MessagePage.cpp:62:19: warning:
deleting object of polymorphic class type 'Rs::Msgs::MsgTagType' which
has non-virtual destructor might cause undefined behavior [-Wdelete-non-
virtual-dtor]
/retroshare-gui/src/gui/settings/MessagePage.cpp:62: warning: delete
called on non-final 'Rs::Msgs::MsgTagType' that has virtual functions
but non-virtual destructor
/retroshare-gui/src/gui/settings/MessagePage.cpp:86: warning: use of
old-style cast
/retroshare-gui/src/gui/settings/MessagePage.cpp:172: warning: zero as
null pointer constant
/retroshare-gui/src/gui/settings/MessagePage.cpp:176: warning: implicit
conversion changes signedness: 'int' to 'uint32_t' (aka 'unsigned int')
/retroshare-gui/src/gui/settings/MessagePage.cpp:203: warning: zero as
null pointer constant
/retroshare-gui/src/gui/settings/MessagePage.cpp:207: warning: implicit
conversion changes signedness: 'int' to 'uint32_t' (aka 'unsigned int')
/retroshare-gui/src/gui/settings/MessagePage.cpp:261: warning: implicit
conversion changes signedness: 'int' to 'uint32_t' (aka 'unsigned int')

/libretroshare/src/retroshare/rsmsgs.h:168: warning:
'Rs::Msgs::MessageInfo' has virtual functions but non-virtual destructor
/libretroshare/src/retroshare/rsmsgs.h:168: warning: 'MessageInfo' has
no out-of-line virtual method definitions; its vtable will be emitted in
every translation unit
/libretroshare/src/retroshare/rsmsgs.h:234: warning:
'Rs::Msgs::MsgInfoSummary' has virtual functions but non-virtual
destructor
/libretroshare/src/retroshare/rsmsgs.h:234: warning: 'MsgInfoSummary'
has no out-of-line virtual method definitions; its vtable will be
emitted in every translation unit
/libretroshare/src/retroshare/rsmsgs.h:261: warning:
'Rs::Msgs::MsgTagInfo' has virtual functions but non-virtual destructor
/libretroshare/src/retroshare/rsmsgs.h:328: warning: 'ChatId' has
virtual functions but non-virtual destructor
/libretroshare/src/retroshare/rsmsgs.h:400: warning: 'ChatLobbyInvite'
has virtual functions but non-virtual destructor
/libretroshare/src/retroshare/rsmsgs.h:420: warning:
'VisibleChatLobbyRecord' has virtual functions but non-virtual
destructor
/libretroshare/src/retroshare/rsmsgs.h:420: warning:
'VisibleChatLobbyRecord' has no out-of-line virtual method definitions;
its vtable will be emitted in every translation unit
/libretroshare/src/retroshare/rsmsgs.h:449: warning: 'ChatLobbyInfo' has
virtual functions but non-virtual destructor
/libretroshare/src/retroshare/rsmsgs.h:486: warning: 'RsMsgs' has no
out-of-line virtual method definitions; its vtable will be emitted in
every translation unit

About vtable:
https://stackoverflow.com/questions/23746941/what-is-the-meaning-of-
clangs-wweak-vtables
https://stackoverflow.com/questions/50463374/avoid-weak-vtable-warnings-
for-classes-only-defined-in-a-source-file
2018-10-23 17:43:01 +02:00
Phenom
a30e2c3400 Fix Warnings in MouseEventFilter.cpp
/retroshare-gui/src/util/MouseEventFilter.cpp:56: warning: catching
polymorphic type 'class std::bad_cast' by value [-Wcatch-value=]
/retroshare-gui/src/util/MouseEventFilter.cpp:77: warning: catching
polymorphic type 'class std::bad_cast' by value [-Wcatch-value=]
2018-10-23 17:37:19 +02:00
Phenom
da6778934d Fix Warnings in rsloginhandler.cc
/libretroshare/src/rsserver/rsloginhandler.cc:122:2: warning: missing
initializer for member 'SecretSchema::reserved' [-Wmissing-field-
initializers]
/libretroshare/src/rsserver/rsloginhandler.cc:122:2: warning: missing
initializer for member 'SecretSchema::reserved1' [-Wmissing-field-
initializers]
/libretroshare/src/rsserver/rsloginhandler.cc:122:2: warning: missing
initializer for member 'SecretSchema::reserved2' [-Wmissing-field-
initializers]
/libretroshare/src/rsserver/rsloginhandler.cc:122:2: warning: missing
initializer for member 'SecretSchema::reserved3' [-Wmissing-field-
initializers]
/libretroshare/src/rsserver/rsloginhandler.cc:122:2: warning: missing
initializer for member 'SecretSchema::reserved4' [-Wmissing-field-
initializers]
/libretroshare/src/rsserver/rsloginhandler.cc:122:2: warning: missing
initializer for member 'SecretSchema::reserved5' [-Wmissing-field-
initializers]
/libretroshare/src/rsserver/rsloginhandler.cc:122:2: warning: missing
initializer for member 'SecretSchema::reserved6' [-Wmissing-field-
initializers]
/libretroshare/src/rsserver/rsloginhandler.cc:122:2: warning: missing
initializer for member 'SecretSchema::reserved7' [-Wmissing-field-
initializers]
/libretroshare/src/rsserver/rsloginhandler.cc:34: warning: zero as null
pointer constant
/libretroshare/src/rsserver/rsloginhandler.cc:55: warning: zero as null
pointer constant
/libretroshare/src/rsserver/rsloginhandler.cc:120: warning: use of old-
style cast
/libretroshare/src/rsserver/rsloginhandler.cc:122: warning: missing
field 'reserved' initializer
/libretroshare/src/rsserver/rsloginhandler.cc:243: warning: zero as null
pointer constant
/libretroshare/src/rsserver/rsloginhandler.cc:244: warning: zero as null
pointer constant
/libretroshare/src/rsserver/rsloginhandler.cc:248: warning: zero as null
pointer constant
/libretroshare/src/rsserver/rsloginhandler.cc:254: warning: zero as null
pointer constant
/libretroshare/src/rsserver/rsloginhandler.cc:443: warning: 'return'
will never be executed
/libretroshare/src/rsserver/rsloginhandler.cc:270: warning: 'return'
will never be executed
/libretroshare/src/rsserver/rsloginhandler.cc:468: warning: zero as null
pointer constant
/libretroshare/src/rsserver/rsloginhandler.cc:470: warning: use of old-
style cast
/libretroshare/src/rsserver/rsloginhandler.cc:470: warning: cast from
'const char *' to 'char *' drops const qualifier
/libretroshare/src/rsserver/rsloginhandler.cc:471: warning: use of old-
style cast
/libretroshare/src/rsserver/rsloginhandler.cc:471: warning: cast from
'const char *' to 'char *' drops const qualifier
/libretroshare/src/rsserver/rsloginhandler.cc:472: warning: zero as null
pointer constant
/libretroshare/src/rsserver/rsloginhandler.cc:476: warning: zero as null
pointer constant
/libretroshare/src/rsserver/rsloginhandler.cc:630: warning: 'return'
will never be executed
/libretroshare/src/rsserver/rsloginhandler.cc:650: warning: zero as null
pointer constant
/libretroshare/src/rsserver/rsloginhandler.cc:651: warning: zero as null
pointer constant
/libretroshare/src/rsserver/rsloginhandler.cc:655: warning: zero as null
pointer constant
2018-10-23 17:37:19 +02:00
G10h4ck
be1f2f7a30
Merge pull request #1379 from G10h4ck/jsonapi
More JSON API
2018-10-22 00:29:55 +02:00
Gioacchino Mazzurco
e746b5b4a0
JSON API unauthenticated access to /rsAccounts/getCurrentAccountId 2018-10-22 00:24:02 +02:00
Gioacchino Mazzurco
6543d713e4
JSON API import/export PGP key to file 2018-10-21 17:12:13 +02:00
Gioacchino Mazzurco
7a1375ff6f
rsPeers add few JSON API calls 2018-10-20 21:13:10 +02:00
csoler
7d21e74b29
added explicit options to including IP history and removed iP history from RS Links as it leaks information without users consent 2018-10-20 17:48:36 +02:00
csoler
259264897e
changed lobby for "chat rooms" in settings 2018-10-20 17:34:57 +02:00
csoler
d97551aa3b
added option to not include external IPs in preferences->node->certificate 2018-10-20 17:31:52 +02:00
csoler
395cf57ece
merged upstream/master 2018-10-20 14:48:11 +02:00
csoler
cfe95a57a0
Merge pull request #1377 from G10h4ck/jsonapi
GXS deep search notify results also of already known groups
2018-10-20 14:47:37 +02:00
csoler
9e632ce995
Merge pull request #1375 from csoler/v0.6-GxsFix2
created a connexion between token and meta data of created posts and …
2018-10-20 14:42:58 +02:00
csoler
ff92b36aa6
Merge pull request #7 from G10h4ck/csoler-v0.6-GxsFix2
Fix compilation with deep search and remove dead code
2018-10-20 14:14:44 +02:00
Gioacchino Mazzurco
2d497d7303
Fix compilation with deep search and rm dead code 2018-10-20 14:07:39 +02:00
Gioacchino Mazzurco
aca29e3ea7
Merge branch 'v0.6-GxsFix2' of https://github.com/csoler/RetroShare into csoler-v0.6-GxsFix2 2018-10-20 13:51:11 +02:00
csoler
b5dbdcb601
fixed compilation of web UI files on linux 2018-10-20 13:51:01 +02:00
Gioacchino Mazzurco
5699d81ae7
GXS deep search notify results also of known groups 2018-10-20 13:48:16 +02:00
csoler
abcd687416
Merge pull request #1374 from csoler/v0.6-ImprovedGUI
patch from sss to fix deadlocks on forum fill thread. To be tested
2018-10-19 22:05:29 +02:00
G10h4ck
450ed27b17
Merge pull request #1376 from G10h4ck/jsonapi
JSON API authorize token in createLocation
2018-10-19 16:36:11 +02:00
Gioacchino Mazzurco
9e2c4ce49e
JSON API authorize token in createLocation
Solve uncoherent 401 behaviour at first use without login
2018-10-19 15:10:15 +02:00
Gioacchino Mazzurco
945775e9f5
Fix deep search compiling on 32bit time_t targets 2018-10-18 04:27:30 +02:00
csoler
9b4c48c540
created a connexion between token and meta data of created posts and grps 2018-10-16 22:40:27 +02:00
csoler
21a92d69b4
merged upstream/master 2018-10-16 20:51:10 +02:00
Gioacchino Mazzurco
2bb24075c4
Print warning also when serializing negative rstime_t 2018-10-16 16:19:23 +02:00
G10h4ck
03cdd6c7b6
Merge pull request #1363 from G10h4ck/jsonapi
New cross-platform target retroshare-service
2018-10-16 16:06:09 +02:00
csoler
37c515bcb5
patch from sss to fix deadlocks on forum fill thread. To be tested 2018-10-15 20:57:21 +02:00
thunder2
617ed25a19 Modified Windows Build Environment
- Removed commandline switch "version"
- Added MinGit for determining version information during compile process
- Added sigcheck to determine version of the executable
2018-10-14 17:47:31 +02:00
thunder2
c7563f1efd Fixed Windows compile with MSYS2 2018-10-14 15:28:41 +02:00
thunder2
6e1de5b5ed Fixed Windows compile with MinGW 2018-10-14 15:28:20 +02:00
csoler
fae02741d4
Merge pull request #1370 from sehraf/pr_remove-debug-output
remove debug output
2018-10-14 15:00:09 +02:00
csoler
bbf855fefb
Merge pull request #1371 from csoler/v0.6-BugFixing
fixed bug in recent commit that broke turtle generic search
2018-10-13 23:00:29 +02:00
csoler
74022a5e10
fixed bug in recent commit that broke turtle generic search 2018-10-13 22:59:26 +02:00
Gioacchino Mazzurco
15b729b35c
Fix crash in p3Peers::loadCertificateFromString
This function is part of the public API so it must be safe to call with
any input, before this commit if would crash if feeded with a broken or
empty certificate radix string.
2018-10-12 22:28:44 +02:00