Commit Graph

5287 Commits

Author SHA1 Message Date
csoler
e17c4d0e40
added a dialog to edit banned files 2018-08-16 22:22:47 +02:00
csoler
50e03a539c
basic infrastructure for banning unwanted file content 2018-08-16 18:49:36 +02:00
Gioacchino Mazzurco
b7f5d4286f
RsGxsNetService::receiveTurtleSearchResults fix deadlock
Avoid notifing observer while the mutex is locked by storing results in
a temporary set
2018-08-16 14:26:41 +02:00
csoler
5b1c150acb
added background for post pinning and logic to edit others posts 2018-08-12 15:30:07 +02:00
csoler
ded9c21617
added selection boxes to add forum moderators 2018-08-09 21:18:37 +02:00
csoler
cc51298de6
fixed warning about badly overloaded function in rsexpr.h 2018-08-02 14:13:14 +02:00
csoler
985be3504e
fixed compilation with RS_AUTO_LOGIN 2018-08-01 23:05:36 +02:00
sehraf
97194fd092
Add wrapper function to convert uint16_t service IDs to internal unsigned int.
Use it when looking up service names.
2018-08-01 20:47:02 +02:00
csoler
c948517c3d
Merge pull request #1306 from csoler/v0.6-TorOnly
V0.6 tor only
2018-07-31 14:18:24 +02:00
csoler
ecd45215c7
disallow empty file when loading shared file list in order to avoid malloc of size 0 2018-07-31 14:13:01 +02:00
csoler
1297d2e106
fixed double calls to pthread_exit() (one being implicit after return from main thread method) -- patch from sss 2018-07-30 10:50:32 +02:00
csoler
d7c7e35d71
fixed compilation on MacOS 2018-07-27 15:15:04 +02:00
csoler
cc1a05ddc9
fixed certificate creation in TorAuto mode 2018-07-27 12:33:06 +02:00
csoler
62b9a74324
fixed running with TorControl in new mode 2018-07-25 15:31:18 +02:00
csoler
d1a375cbd0
removed RETROTOR #ifdef and started using RsAccounts::isTorAuto() instead. Unfinished yet. 2018-07-25 11:37:40 +02:00
Gioacchino Mazzurco
d2a62b03ee
Fix deep search returning 0 results 2018-07-25 00:29:36 +02:00
Gioacchino Mazzurco
b4dd89dd87
Fix deep search returning 0 results 2018-07-25 00:27:39 +02:00
csoler
0f758902cd
started cleaning the mess with rsAccounts: only exposed useful functionality of rsAccount beyond a static class and removed all references to rsAccounts in the code 2018-07-24 23:47:32 +02:00
sehraf
7af5075891
fix jsonapi.h 2018-07-24 20:59:20 +02:00
sehraf
e6acb52d17
add simple chat support 2018-07-24 20:09:45 +02:00
thunder2
7128a04525 Added Xapian to Windows build environment 2018-07-24 16:03:32 +02:00
Gioacchino Mazzurco
1bc518041c
Experiment of notification via NotifyClient + JSON API 2018-07-23 14:52:17 +02:00
Gioacchino Mazzurco
130007b578
Merge branch 'master' into jsonapi 2018-07-23 13:44:01 +02:00
G10h4ck
fbc4e4205d
Merge pull request #1292 from G10h4ck/deep_search
Content search for channels trough xapian
2018-07-23 11:48:55 +02:00
Gioacchino Mazzurco
e8c9ba52b2
Improve code quality after Cyril review 2018-07-23 11:18:32 +02:00
Gioacchino Mazzurco
6f8c2f6f41
Fix compilation if deep_search is disabled 2018-07-22 23:39:06 +02:00
Gioacchino Mazzurco
51c25219bb
Fix compiling with old GCC 2018-07-22 22:47:30 +02:00
Gioacchino Mazzurco
d9aa37219c
Revert "DROP before merge. Reduce INTEGRITY_CHECK_PERIOD"
This reverts commit ce61174d79.
2018-07-22 21:45:43 +02:00
Gioacchino Mazzurco
f97dc8a125
Properly plug deep search in GXS search
Some modifications breaks retrocompatibility of GXS search:
  remove horrible templated RsTypeSerializer::serial_process for
    RsGxsGroupSummary with hardcoded member names
  RsGxsGroupSummary doesn't use old TLV serialization format anymore
  RsGxsGroupSummary remove unused description member
  RsGxsGroupSummary derive from RsSerializable and use serialization
    helper macro
Add autor id and signature flags to the index so there is no need to
  retrive them from GXS, thus improving performances
RsGroupNetworkStats initialize members properly
RsGxsGroupSummary rename members to follow usual mMemberName convention
2018-07-22 21:33:40 +02:00
csoler
82c9084ca4
Merge pull request #1303 from csoler/v0.6-GXS-DistSync3-TurtleSearch
fixed deadlock due to turtle calling addVirtualPeer for client servic…
2018-07-22 00:22:51 +02:00
csoler
2ab12a2ef5
fixed deadlock due to turtle calling addVirtualPeer for client services inside a mutex protected zone (breaks mutex order service > turtle) 2018-07-22 00:21:45 +02:00
Gioacchino Mazzurco
6982ae6cd5
Improve retrocompatibility with older xapian 2018-07-21 13:35:05 +02:00
Gioacchino Mazzurco
ff166b2295
Merge branch 'master' into deep_search 2018-07-21 12:57:05 +02:00
csoler
e72ef242c9
Merge pull request #1298 from csoler/v0.6-DebianPackaging
V0.6 debian packaging
2018-07-20 19:16:58 +02:00
Gioacchino Mazzurco
3fc9ff3fef
WIP Plug deep search into GXS search 2018-07-20 15:29:37 +02:00
Gioacchino Mazzurco
a31b06ab60
Merge branch 'master' into deep_search
Needed to make deep search and GXS search cooperate
2018-07-20 13:15:11 +02:00
csoler
d4fce07e4c
changed lrand48 to RSRandom for cross-plateform compatibility, in rsgxsnettunnel.cc 2018-07-19 23:46:31 +02:00
csoler
2bab688dec
fixed merge with upstream/master 2018-07-19 23:22:24 +02:00
csoler
b8062f2e21
Merge pull request #1294 from csoler/v0.6-GXS-DistSync3-TurtleSearch
V0.6 gxs dist sync3 turtle search
2018-07-19 22:59:43 +02:00
csoler
dac885e24d
made randomBias initilized with true random bytes at start 2018-07-18 21:22:38 +02:00
csoler
9b0a4b966e
removed extra call to loadConfiguration() 2018-07-18 21:20:51 +02:00
sehraf
55e99ef0d1
add auto detection of installed rapidjson 2018-07-16 23:22:04 +02:00
csoler
1de31493a9
fixed up display of GXS net tunnel info 2018-07-15 19:09:12 +02:00
csoler
fd45d44826
added interface to get statistics about GxsNetTunnel 2018-07-15 11:14:58 +02:00
csoler
b20bd0a454
added admin list to forum group data 2018-07-15 10:13:04 +02:00
csoler
6848a586f3
merged upstream/master 2018-07-08 21:17:48 +02:00
chelovechishko
b3dddeafdf add missing namespaces 2018-07-06 23:55:12 +09:00
csoler
0c45217fc0
merged upstream/master 2018-07-05 17:41:30 +02:00
csoler
98f8e4da0a
added per-item type limit for turtle search results 2018-07-05 17:40:06 +02:00
csoler
4a64ea5f1f
added optional use of dist sync in GroupFrameDialog 2018-07-05 14:00:04 +02:00
csoler
0cc87c9880
fixed bug causing search data result to not be forwarded correctly (missing request id) 2018-07-05 12:20:22 +02:00
csoler
0e37de3e11
made retrieval of group data manual instead of automatic 2018-07-05 11:43:55 +02:00
csoler
59c51a250b
removed debug switch to allow display of existing distant group search results 2018-07-05 10:16:48 +02:00
csoler
47e760a2c5
added a few missing mutexes in prevent searches to be shown when already known 2018-07-05 10:11:12 +02:00
csoler
2067b106e4
fixed missing code in passing turtle group data result to client service 2018-07-04 23:54:26 +02:00
csoler
8ad454723a
added group data request when search items are selected 2018-07-04 21:42:09 +02:00
Gioacchino Mazzurco
d3e5b760a2
DeepSearch index channels posts too
Improve indexing using RsUrl, store some relevant fields in stored url
2018-07-04 12:08:50 +02:00
Gioacchino Mazzurco
32014eaac1
Use proper path for DeepSearch xapian DB 2018-07-02 17:31:47 +02:00
Gioacchino Mazzurco
5a41b3cb37
Index only public channels 2018-07-02 17:31:47 +02:00
Gioacchino Mazzurco
0f63283f96
Add search capability to DeepSearch 2018-07-02 17:31:47 +02:00
Gioacchino Mazzurco
c15ae864b5
deep_search: use service serializer not serial_process
Avoid tricky pointers arithmetic, thanks Cyril for suggestion
2018-07-02 17:31:47 +02:00
Gioacchino Mazzurco
c0e92ddc6b
WIP Index GXS channels with xapian
Use temporary DB ATM
2018-07-02 17:29:54 +02:00
Gioacchino Mazzurco
ce61174d79
DROP before merge. Reduce INTEGRITY_CHECK_PERIOD
So it run each two 2 minutes and it's easy to debug deep search
2018-07-02 17:29:52 +02:00
Gioacchino Mazzurco
418c42bd11
Extra locators in cert invite made optional 2018-07-02 13:50:02 +02:00
Gioacchino Mazzurco
1dd707710b
Merge branch 'master' into extra_locators_merge 2018-07-02 12:22:23 +02:00
csoler
80a43fe3d5
added secure retrieval of distant groups 2018-06-30 21:52:25 +02:00
Gioacchino Mazzurco
1c63cec735
Expose some RsFiles method trought JSON API 2018-06-29 16:02:07 +02:00
Gioacchino Mazzurco
102558afdf
Merge fixes to serialization from master branch 2018-06-29 00:13:07 +02:00
sehraf
f7625e3526
fix json uint64 2018-06-28 20:25:10 +02:00
Gioacchino Mazzurco
d511b6648e
Extend JSON API to shutdown retroshare gracefully 2018-06-28 15:04:06 +02:00
Gioacchino Mazzurco
0ff80baed3
Extend JSON API with reasonable way to create location 2018-06-28 12:06:43 +02:00
csoler
db06c32e80
turned turtle encryption routine into a generic authenticated encryption method in librs::crypto 2018-06-28 10:01:57 +02:00
Gioacchino Mazzurco
4637fbaff5
Add login JSON API
Implement a "normal" way to login RsLoginHelper::attemptLogin
Implement a way to get locations list RsLoginHelper::getLocations
Enable JSON API into retroshare-android-service
2018-06-27 08:52:03 +02:00
csoler
00dfa0f3c2
added fallback for GXS GroupMessage UI to look into cached distant group data 2018-06-26 22:20:02 +02:00
Gioacchino Mazzurco
d14a455cf1
jsonapi-generator fix support for void methods
Thanks sehraf for reporting
retroshare://forum?name=fucking%20genius&id=8fd22bd8f99754461e7ba1ca8a727995&msgid=503d75bf7ed7fa7568eeae4db5c8d31a7e124c98
2018-06-26 22:01:17 +02:00
Gioacchino Mazzurco
cb11ad92ea
Merge branch 'master' into jsonapi 2018-06-26 15:19:25 +02:00
Gioacchino Mazzurco
502459a25a
Cleanup rapidjson inclusion
Fix compilation error of android service
2018-06-26 15:12:16 +02:00
Gioacchino Mazzurco
15f39129f1
Complete GxsChannels JSON API with blocking methods
RsGxsIfaceHelper::requestStatus expose it to JSON API
Implemented RsGxsIfaceHelper::waitToken to wait for GXS operations
RsItem::serial_process fix doxygen warning as it's a comment not documentation
RsTypeSerializer add JSON conversion methods for double [de]serialization not
	implemented yet
RsTypeSerializer_PRIVATE_{FROM,TO}_JSON_ARRAY fix doxygen warning as it's a
	comment not documentation
make GxsChannels::ExtraFileHash a bit more reasonable
jsonapi-generator fix unused variable warning if there is no input or output
	paramethers
jsonapi-generator fix generation for inerithed jsonapi methods
Convert to RsSerializable some Gxs structs for the JSON API
2018-06-26 13:20:24 +02:00
Gioacchino Mazzurco
d731b665db
Expose tokenservice methods trough GxsIfaceHelper 2018-06-25 10:44:39 +02:00
Gioacchino Mazzurco
2f4b9b3e20
Convert to RsTokenService::GxsRequestStatus
Indicate GxsRequest status with an enum instead of uint_* that make the
  code less readable and more prone to errors
2018-06-24 23:24:52 +02:00
Gioacchino Mazzurco
b4d2ce82c1
RsTokenService use enum for request status 2018-06-24 18:56:48 +02:00
Gioacchino Mazzurco
ec95b6d054
Remove unused misleading GXS request status
Something must be really strange to be finished and incomplete at same
  time..
2018-06-24 18:03:26 +02:00
csoler
e351d7257e
added retrieval of search results in UI 2018-06-24 16:55:38 +02:00
Gioacchino Mazzurco
7ad337c8d2
Implement automatic JSON API generation
qmake file add jsonapi-generator target to compile JSON API generator
qmake files add rs_jsonapi CONFIG option to enable/disable JSON API at compile
  time
RsTypeSerializer pass down same serialization flags when creating new context
  for nested objects serial job
RsGxsChannels expose a few methods through JSON API as example
Derive a few GXS types (RsGxsChannelGroup, RsGxsChannelPost, RsGxsFile,
  RsMsgMetaData) from RsSerializables so they can be used for the JSON API
Create RsGenericSerializer::SERIALIZATION_FLAG_YIELDING so JSON objects that
  miss some fields can be still deserialized, this improve API usability
SerializeContext offer friendly constructor with default paramethers
Add restbed 4.6 library as git submodule as most systems doesn't have it yet
Add a bit of documentation about JSON API into jsonapi-generator/README.adoc
Add JsonApiServer class to expose the JSON API via HTTP protocol
2018-06-24 16:28:33 +02:00
csoler
6ccc7654d6
added code to notify GxsBroadcast system with new distant search results 2018-06-23 22:25:36 +02:00
csoler
5b9666855d
fixed merge with upstream 2018-06-22 23:38:31 +02:00
csoler
2f159efb10
Merge pull request #1288 from csoler/v0.6-GxsFix
changed std::vector into std::set in notification system, hence remov…
2018-06-22 22:06:59 +02:00
csoler
84699db744
changed std::vector into std::set in notification system, hence removing lots of std::find(std::vector::begin(),std::vector::end(),T), causing quadratic costs in multiple places. 2018-06-21 15:46:59 +02:00
csoler
3981bc8e3b
extended notification system to add distant search result notification 2018-06-21 13:48:57 +02:00
csoler
5cb48c27de
renamed a few constants of GXS notify system into more consistent values 2018-06-21 09:26:03 +02:00
G10h4ck
9090205747
Merge pull request #1284 from G10h4ck/improve_build
Improve build and Windows Continuos Integration
2018-06-19 11:53:07 +02:00
csoler
79e676edbe
fixed re-load of GXS groups (forums/channels) when the read flag is changed 2018-06-18 22:27:05 +02:00
csoler
c67084b7de
fixed mutex problem in turtle-GXS search 2018-06-17 21:23:16 +02:00
csoler
84194b6234
sereral fixes to GXS distant search 2018-06-16 22:39:35 +02:00
csoler
7a135c5c43
added quick and dirty turtle search for channels in Files search tab 2018-06-13 22:46:27 +02:00
csoler
be1e127a93
added test search functions in rsgxsnetservice 2018-06-11 22:00:03 +02:00
Gioacchino Mazzurco
1f76108a9e
Remove some cruft from build files 2018-06-11 14:21:28 +02:00
csoler
6fb459ce64
added logic for GXS search in RsGxsNetTunnel and Gxs client net service 2018-06-10 22:34:17 +02:00
Gioacchino Mazzurco
6010104127
Merge commit '9886840b79d617a32764ad52ef4747f5fd999250' 2018-06-09 18:10:22 +02:00
Gioacchino Mazzurco
9886840b79
Provide proper constructor for SerializeContext
Deprecate constructor that depends on deprecated declarations.
2018-06-09 17:59:11 +02:00
Gioacchino Mazzurco
1825b263f0
ChunkMap::reAskPendingChunk fix unused parameter warning 2018-06-09 17:21:59 +02:00
cyril soler
8edb1f7535 fixed problem causing infinite loop of net reset in p3NetMgr 2018-06-08 14:32:56 +02:00
G10h4ck
f3b0f7af1f
Merge pull request #1280 from G10h4ck/channels_apiv2_improvements
Channels apiv2 improvements
2018-06-07 17:53:42 +02:00
G10h4ck
e5c72481ad
Merge pull request #1281 from G10h4ck/filesharing_apiv2_improvements
Extend a bit filesharing JSON API v2
2018-06-07 17:53:26 +02:00
Gioacchino Mazzurco
3eff851cdb
Improve deprecation of RS_TOKREQ_ANSTYPE_* 2018-06-07 14:57:31 +02:00
csoler
7caf06b57d
added structures for generic turtle search and access functions in Gxs objects 2018-06-06 23:15:29 +02:00
csoler
b5c1b8210b
added classes for both group data and group summary results in turtle search 2018-06-02 18:12:27 +02:00
csoler
90d7f55c40
finished implementing GXS search items 2018-05-31 15:41:54 +02:00
csoler
b0f391d66f
fixed compilation and re-licensed zeroconf/ 2018-05-30 21:45:18 +02:00
csoler
bc63726c4c
fixed compilation 2018-05-30 21:35:29 +02:00
csoler
8641da189c
relicensed util/ and moved rsaes to crypto/ 2018-05-30 21:34:38 +02:00
csoler
858dcfc14c
removed unused tempering in random number generator, added comments and license text 2018-05-30 21:19:53 +02:00
csoler
6cf2090149
relicensed tcponudp, turtle, unused, upnp, and part of util/ 2018-05-30 21:19:13 +02:00
csoler
b3853156ce
re-licensed services/ 2018-05-29 21:54:27 +02:00
csoler
70f09b654c
re-licensed serialiser/ 2018-05-29 21:27:12 +02:00
csoler
05e2f684a9
re-licensed rsitems and rsserver 2018-05-29 21:08:17 +02:00
csoler
ff8c37f169
fixed license in retroshare/ 2018-05-28 22:28:51 +02:00
csoler
b3277824eb
license fix in pqi 2018-05-28 22:03:39 +02:00
csoler
1fee544db7
re-licensed gxstrans, gxstunnel, pgp, plugins and half pqi 2018-05-26 14:45:43 +02:00
csoler
33fe823127
Merge pull request #1271 from sehraf/pr_compile-fix-unused-services
make wiki and photo services compile again
2018-05-26 11:22:47 +02:00
csoler
8a07f2c8c4
fixed wrong commit with copy-pasted code 2018-05-24 19:50:07 +02:00
csoler
d5627d4b22
fixed license in ft, grouter, and gxs 2018-05-22 22:03:11 +02:00
Gioacchino Mazzurco
1ad1fdc7be
p3NetMgrIMPL::checkNetAddress() notify if port change
Plus cleanups and proper sockaddr_storage copy
2018-05-22 19:17:37 +02:00
Gioacchino Mazzurco
0bf02e2bc3
pqissludp::Initiate_Connection() check remote_addr to be IPv4 before use 2018-05-22 19:14:25 +02:00
csoler
544b4af4c2
fixed license in chat, crypto, dht, file_sharing 2018-05-21 20:50:38 +02:00
csoler
50b360bf9d
added missing license to some libresapi files 2018-05-21 20:17:54 +02:00
sehraf
0c19a5640e
compile fix gxsphoto 2018-05-21 14:55:10 +02:00
sehraf
92b21d7332
compile fix wikipoos 2018-05-21 14:26:46 +02:00
Gioacchino Mazzurco
5a301734a9
Extend a bit filesharing JSON API v2 2018-05-17 16:46:34 +02:00
csoler
28981b6c86
Merge pull request #1251 from PhenomRetroShare/Fix_Cppcheck(duplInheritedMember)InRsItem
Fix CppCheck duplInheritedMember warning in RsItem
2018-05-16 13:37:02 +02:00
csoler
2145911ac4
Merge pull request #1262 from PhenomRetroShare/Fix_PartialDirCheck
Fix Partial Dir Check
2018-05-16 13:30:56 +02:00
csoler
3f88e3e901
added check to avoid hashing files that are currently being modified 2018-05-16 13:24:52 +02:00
csoler
8451550561
added missing licence to file_tree.h 2018-05-16 11:40:39 +02:00
csoler
291c86e2d0
Merge pull request #1265 from csoler/v0.6-GxsFix
fixed bug causing new forums and identities to not show up immediately
2018-05-16 11:17:22 +02:00
csoler
4661329bee
fixed bug causing new forums and identities to not show up immediately 2018-05-16 11:15:18 +02:00
G10h4ck
9f37b63e4d
Merge pull request #1264 from G10h4ck/channel_json_api_v2
Channel json api v2
2018-05-16 10:49:28 +02:00
Phenom
f12cd5774d Fix Partial Dir Check
Add WrongValue StyleSheet property, when bad directory selected.
Update QLineEdit with current setting so it's possible to see if
something is modified. No need to restart.
2018-05-12 14:31:28 +02:00
csoler
4d287d68bc
fixed weird mistake in grouter which causes an issue only in gcc > 8 2018-05-09 13:27:16 +02:00
Phenom
f39fd069b5 Fix CppCheck duplInheritedMember warning in RsItem
/libretroshare/src/rsitems/rsitem.h:92: warning:
Cppcheck(duplInheritedMember): The class 'RsPeerNetItem' defines member
variable with name 'peerId' also defined in its parent struct 'RsItem'.
/libretroshare/src/rsitems/rsitem.h:92: warning:
Cppcheck(duplInheritedMember): The class 'RsHistoryMsgItem' defines
member variable with name 'peerId' also defined in its parent struct
'RsItem'.
/libretroshare/src/rsitems/rsitem.h:91: warning:
Cppcheck(duplInheritedMember): The class 'RsBanListConfigItem' defines
member variable with name 'type' also defined in its parent struct
'RsItem'.
/libretroshare/src/rsitems/rsitem.h:92: warning:
Cppcheck(duplInheritedMember): The class 'RsBanListConfigItem' defines
member variable with name 'peerId' also defined in its parent struct
'RsItem'.
2018-05-07 17:29:11 +02:00
csoler
a6821f4ded
Merge pull request #1249 from sehraf/pr_libsecret
Add support for libsecret (including KDE keyring) and fix retroshare-nogui autologin
2018-05-06 23:02:18 +02:00
Phenom
dca33daae8 Fix CppCheck in ftcontroller.cc
/libretroshare/src/ft/ftcontroller.cc:91: warning:
Cppcheck(passedByValue): Function parameter 'fname' should be passed by
reference.
/libretroshare/src/ft/ftcontroller.cc:92: warning:
Cppcheck(passedByValue): Function parameter 'tmppath' should be passed
by reference.
/libretroshare/src/ft/ftcontroller.cc:92: warning:
Cppcheck(passedByValue): Function parameter 'dest' should be passed by
reference.
/libretroshare/src/ft/ftcontroller.cc:1482: warning:
Cppcheck(stlIfStrFind): Inefficient usage of string::find() in
condition; string::compare() would be faster.
/libretroshare/src/ft/ftcontroller.cc:1491: warning:
Cppcheck(stlIfStrFind): Inefficient usage of string::find() in
condition; string::compare() would be faster.
2018-05-06 18:54:25 +02:00
csoler
e7182013bf
added items for generic search result items for GXS 2018-05-05 18:41:41 +02:00
csoler
0ada4d4895
improved GxsNetTunnel comment section 2018-05-05 18:08:27 +02:00
sehraf
1129bcb0c0
Add support for libsecret 2018-05-04 20:47:41 +02:00
csoler
8d5c013a17
added proper synchronization of GxsIds through tunnels of another service 2018-05-03 23:21:59 +02:00
csoler
8e111c2ee2
added rapidjson-1.1.0 code hard-coded in the source directory to allow everyone to compile without the need to tweak too much. When v1.1.0 is mainstream (espcially on ubuntu) we can revert back to an external dependency 2018-05-02 22:46:27 +02:00
csoler
4d6fed643a
reverted to single GxsTunnelService shared for all services 2018-05-01 20:10:56 +02:00
csoler
ba0819f8d0
added additional debug info to test proper distant request of GXS ids 2018-05-01 15:17:41 +02:00
csoler
c5ba0e975f
fixed TS in tunnel management 2018-04-29 19:20:14 +02:00
csoler
9973978350
improved management of tunnels and virtual peers 2018-04-29 16:19:45 +02:00
Gioacchino Mazzurco
be75e89ad2
Fix compialtion after merge 2018-04-27 20:55:38 +02:00
Gioacchino Mazzurco
f3ae61b462
Merge branch 'json_experiments' 2018-04-27 18:17:09 +02:00
csoler
5be57046f1
added load/save of random bias in GxsNetTunnel service 2018-04-27 00:00:29 +02:00
Gioacchino Mazzurco
f4e110ed0e
p3Banlist fail gracefully if IPv6 address get into
Translate IPv4 mapped to plain IPv4 before processing
Fail gracefully if the address is IPv6
2018-04-26 11:04:05 +02:00
csoler
57bb31ece6
added new checks in canSend and canRecv Msg/Grp to work with distant peers 2018-04-25 18:52:07 +02:00
csoler
da4b382ede
removed dependency on service in RsGxsNetTunnel 2018-04-25 18:29:49 +02:00
csoler
1a9a7622a2
made GxsNetTunnelService a parent class of GxsNetService and renamed public methods appropriately. 2018-04-25 17:58:37 +02:00
csoler
38b39caf13
added compilation flag for GXS dist sync 2018-04-25 14:58:53 +02:00
G10h4ck
82eb42ad8a
Merge pull request #1235 from G10h4ck/build_improvements
Build improvements
2018-04-23 12:04:35 +02:00
csoler
63359e0801
using additional const ref in rsexpr.h 2018-04-22 17:14:08 +02:00
csoler
c599b5a627
removed debug output in pqissl and pqissllistenner 2018-04-22 17:13:25 +02:00
Gioacchino Mazzurco
4876a0ea3b
Multiple improvements to build process
Restructure and document retroshare.pri variables and helper functions
Link sqlite statically like other libraries on Android
qmake has multiple win32-* specs match them correctly
Move a buch of generic thing to retroshare.pri instead of having them replocated
  accross project specific .pro
Fix retroshare-gui too many symbols exported on windows liking error by adding
  QMAKE_LFLAGS+=-Wl,--exclude-libs,ALL
Rename retroshare-gui/src/util/win32.h because the name is too prone to
  confusion and build conflicts
libreasapi avoid usage of cretar_prl link_prl that seems unreliable on some
  platforms
libreasapi rename LIBRESAPI_QT to more understendable LIBRESAPI_SETTINGS
Use use_*.pri instead of copy pasting error prone qmake snippets around
Expose bitdht option to retroshare.pri
Add RS_THREAD_LIB qmake variable for better crossplatform support
Move debug and profiling generic options to retroshare.pri (avoid copy/pasting)
Remove Qt script module in qmake as it is not available anymore
2018-04-18 07:56:43 +02:00
Gioacchino Mazzurco
f20705b36d
Workaround for systems that miss IPV6_V6ONLY
This should improve compatibility with old systems that miss
IPV6_V6ONLY and in particular for Windows XP
2018-04-15 12:32:39 +02:00
csoler
3c9af3d2e7
fixed bug in tunnel monitoring code 2018-04-14 11:48:55 +02:00
csoler
66df281f25
added asymmetry in GXS tunnel management to reduce the number of tunnels 2018-04-11 23:14:10 +02:00
Pooh
732e87a8bb
Merge branch 'master' into logshutup1 2018-04-09 11:15:43 +03:00
Gioacchino Mazzurco
c19919962d
pqissl silence extra debug message 2018-04-08 12:37:41 +02:00
csoler
27824943ff
removed debug info 2018-04-07 14:29:23 +02:00
csoler
e2b0e27205
fixed costly polling in RsGenExchange 2018-04-07 14:12:44 +02:00
Gioacchino Mazzurco
cc091cc2c8
Fixed hidden nodes listening failure
In case of hidden node the listen address was not properly converted to
  ipv4 mapped format causing bind to fail
Use sockaddr_storage_copy instead of = as sockaddr_storage is not
  guaranted to be copyable
2018-04-07 12:48:01 +02:00
csoler
393ff75c90
fixed polling strategy in RsGxsNetService causing some delay in distant post syncing 2018-04-07 00:56:44 +02:00
csoler
c0570ffef6
fixed costly polling in RsGenExchange 2018-04-07 00:56:07 +02:00
csoler
2b9139bf85
improved GXS dist sync item handling 2018-04-06 15:26:54 +02:00
csoler
7d561bcceb
added distant data access in GxsNetService 2018-04-04 21:41:21 +02:00
csoler
8fe3eb711d
fixed a few bugs in GXS dist sync tunneling 2018-04-02 17:07:32 +02:00
csoler
aa59694d88
added automatic detection for need to dist-sync groups 2018-04-01 22:04:16 +02:00
Pooh
c0834cf232
Merge branch 'master' into logshutup1 2018-04-01 17:40:44 +03:00
RetroPooh
0a943ea9ee log shut up 2018-04-01 17:30:36 +03:00
csoler
f0f69b8dd9
shared virtual peers across services 2018-03-29 16:26:36 +02:00
csoler
73b04f3109
finished implementation of GxsNetTunnel service 2018-03-29 10:54:58 +02:00
Gioacchino Mazzurco
8d1f1da242
Extend libresapi with minimal support for channels
The code is not elegant as this version of the API will be soon obsolete
  but it offer a bunch of channels functionalities, comments and votes
  are not implemented yet

/channels/list_channels get all visibile channels
/channels/get_channel get content of a subscribed channel
/channels/toggle_subscribe subscribe/unsubscribe to a channel
/channels/toggle_auto_download set/unset auto-download for files attached
  to posts in a channel
/channels/toggle_read mark a post as read
/channels/create_channel create a new channel
/channels/create_post create a new post in given channel, group_id
  paramenter renamed to channel_id for consistence

mChannels use reference instead of pointer as it must be valid
  for the whole lifetime of the object
RsGxsCommentService and derivatives use proper types for parameter, avoid
  reference when unneeded
2018-03-28 16:41:05 +02:00
csoler
73c6deebf4
Merge pull request #1191 from G10h4ck/IPv6-v3
IPv6 support
2018-03-27 20:54:31 +02:00
csoler
b488760d7d
fixed data incoming/outgoing in GxsNetTunnel 2018-03-26 23:19:29 +02:00
csoler
5566d90f32
finished tunnel handling and data send/recv in GxsNetTunnel 2018-03-24 16:42:16 +01:00
csoler
2255bda007
improved documentation of TurtleClientService class with doxygen type 2018-03-24 16:41:51 +01:00
csoler
58aa2413b3
finished moving tunnel encryption into turtle 2018-03-23 22:46:04 +01:00
csoler
00a6bd5b73
started to move FT encryption into p3turtle 2018-03-22 14:41:50 +01:00
csoler
3407604a54
added code to add/remove virtual peers in RsGxsNetTunnel 2018-03-21 22:09:40 +01:00
csoler
076309133b
basic structure of GxsNetTunnelService 2018-03-15 17:46:21 +01:00
csoler
e1ad21c357
fixed wrong file count in RsCollectionDialog when downloading files 2018-03-15 13:11:19 +01:00
csoler
b3653d1283
enabled aggressive re-request of pending slices at end of transfer, thus fixing the long delay to finish files with mixed fast/slow sources 2018-03-15 11:32:55 +01:00
csoler
04dc764339
merged upstream/master 2018-03-15 09:19:56 +01:00
Gioacchino Mazzurco
9fbf56e592
Remove outdated misleading comment 2018-03-03 01:55:49 +01:00
Gioacchino Mazzurco
234daffec7
Merge branch 'IPv6-v3' into extra_locators 2018-03-03 01:43:00 +01:00
Gioacchino Mazzurco
52ef72d761
Fix p3PeerMgrIMPL::UpdateOwnAddress local address
Due to a regression introduced in
dedfcb2b60 the local address was not
updated correctly causing part of RS networking being stuck and printing
lot of invalid sockaddr_storage messages, this commit fix the regression
2018-03-03 01:39:50 +01:00
Gioacchino Mazzurco
bed856425f
Share additional addresses via RsCertificate 2018-03-03 00:08:56 +01:00
Gioacchino Mazzurco
8542abd4f0
Few fixes in RsUrl 2018-03-02 20:08:50 +01:00
Gioacchino Mazzurco
518df99243
Merge branch 'master' into extra_locators 2018-03-02 19:31:37 +01:00
Gioacchino Mazzurco
923c383a13
Add naif URL manipulation class RsUrl
Use RsUrl to convert sockaddre_storage from/to string
2018-03-02 19:20:56 +01:00
csoler
026951ff2c
added consistency check in getGroupMeta so that ADMIN/PUBLISH flags always correspond to what the key set reflects 2018-03-01 11:45:54 +01:00
Gioacchino Mazzurco
dedfcb2b60
More ipv6 to ipv4 conversion around
More safe sockaddr_storage copy
2018-03-01 10:12:15 +01:00
csoler
5d5894352d
forced notification of type RECEIVE when creating a new group so that the GxsIFaceHelper updates the group list 2018-02-28 23:18:50 +01:00
csoler
29ab0e9913
fixed bug that would erase private publish key when a group update is received 2018-02-28 22:40:04 +01:00
csoler
165b241341
made add of publish key a meta group change, to force reload the list of groups 2018-02-27 23:19:27 +01:00
csoler
3bc5b456a5
added a FeedItem to warn when publish permissions are received for a channel 2018-02-27 22:42:48 +01:00
csoler
aad9397ef8
fixed memory leak in p3GxsTunnel 2018-02-26 23:38:13 +01:00
Gioacchino Mazzurco
7d765ec04e
pqissl::Initiate_Connection remove duplicated code 2018-02-26 16:30:27 +01:00
Gioacchino Mazzurco
f4a6090150
More ipv6_to_ipv4 conversions 2018-02-26 16:28:36 +01:00
Gioacchino Mazzurco
ac8b56951c
Enforce main IPv4 usage for better retrocompatibility 2018-02-26 08:49:06 +01:00
csoler
dd9f67a28b
fixed version number problem 2018-02-25 17:53:42 +01:00
Gioacchino Mazzurco
f5160338ed
sockaddr_storage_familytostring be quite if not debugging 2018-02-25 13:18:34 +01:00
Gioacchino Mazzurco
9281a5966b
p3Peers::getPeerDetails retrocompatible IPv4 format 2018-02-25 12:48:55 +01:00
Gioacchino Mazzurco
9a446fc1ff
Fix compilation for Android 2018-02-25 11:28:26 +01:00
csoler
681f543184
Merge pull request #1183 from csoler/v0.6.4
switched version to 0.6.4
2018-02-24 22:04:26 +01:00
csoler
39e70ed8bf
ignore unknown ptags in certificates instead of causing an error, for future backward compatibility 2018-02-24 21:51:18 +01:00
Gioacchino Mazzurco
4a138e07b9
Implement IPv6 listening
With this commit IPv6-v3 surpass v0.6-IPv6-2 in term of features
  obsoleting it.
p3BitDht handle gracefully unwanted non IPv4 addresses
rsUdpStack handle gracefully unwanted non IPv4 addresses
pqissludp handle gracefully unwanted non IPv4 addresses
Move single address limitation workaround from
  p3discovery2::sendOwnContactInfo to better
  place p3PeerMgrIMPL::UpdateOwnAddress this way local address list is
  queried less often and only id there is some suggestion that it may
  have changed (probably ir will not be called all the times there is a
  changes in local network interfaces but is good enough)
Implement crossplatform rs_setsockopt to avoid too much ifdef around
Implement sockaddr_storage_copy to safely copy sockaddr_storage objects
2018-02-24 17:14:49 +01:00
Gioacchino Mazzurco
b3c7d195c8
Port pqissl to dual stack IPv6+IPv4
Changed unix_connect signature to be more comfortable for dual stack
  usage
Remove dead code in pqissl::pqissl(...)
Adapt p3I2pBob::connectI2P() to new unix_connect
Adapt extaddrfinder to new unix_connect
Add sockaddr_storage_ipv4_to_ipv6 to convert from flat IPv4 to IPv4
  mapped as IPv6
2018-02-24 14:29:56 +01:00
Gioacchino Mazzurco
2170313e42
Improve discovery
Workaround RS single local address flawed assumption by spreading
  all viables local addrresses via discovery
Spread addresses also through hidden node as they are the only hope
  to help direct connection happening for common trusted nodes
  behind nasty firewalls
2018-02-24 14:29:56 +01:00
csoler
13441ff483
removed debug info in rsgenexchange.cc 2018-02-23 15:13:13 +01:00
csoler
d8e950c5e0
removed debug output from rsdataservice 2018-02-23 14:28:22 +01:00
csoler
ff7633fefe
Merge pull request #1184 from G10h4ck/linkLocalFallback
[0.6.4] Use link local address only if necessary fix #292
2018-02-23 14:00:39 +01:00
Gioacchino Mazzurco
8d5cd8afef
Increase size of list of ip shared via discovery2 2018-02-23 02:10:58 +01:00
Gioacchino Mazzurco
9dd1aef2b7
Discovery do not distribute addresses to hidden nodes
As there is no consensus in takde advantage of hidden nodes for
  discovery do not spread ip address to them
2018-02-23 02:10:58 +01:00
Gioacchino Mazzurco
e7facc122b
Prevent discovery to share local addresses if hidden
Do not query/share local addresses if hidden node as it would leak
  information about the location of the node
2018-02-23 02:10:58 +01:00
Gioacchino Mazzurco
4fa6bdc789
Improve discovery
Workaround RS single local address flawed assumption by spreading
  all viables local addrresses via discovery
Spread addresses also through hidden node as they are the only hope
  to help direct connection happening for common trusted nodes
  behind nasty firewalls
2018-02-23 02:10:58 +01:00
Gioacchino Mazzurco
2044a2c848
Use retrocompatible iterators
Explain why shuffling the local addresses list before looking for
 a viable local is a bad idea.
2018-02-21 12:35:27 +01:00
Phenom
73d11e1857
Fix Gcc Warning in nxsmsgsync_test.cc
/trunk/tests/unittests/libretroshare/gxs/nxs_test/nxsmsgsync_test.cc:28:
warning: deleting object of abstract class type ‘RsGixsReputation’ which
has non-virtual destructor will cause undefined behavior [-Wdelete-non-
virtual-dtor]
  delete mRep ;
/trunk/tests/unittests/libretroshare/gxs/nxs_test/nxsmsgsync_test.cc:29:
warning: deleting object of abstract class type ‘RsGcxs’ which has non-
virtual destructor will cause undefined behavior [-Wdelete-non-virtual-
dtor]
  delete mCircles;
/trunk/tests/unittests/libretroshare/gxs/nxs_test/nxsmsgsync_test.cc:30:
warning: deleting object of abstract class type ‘PgpAuxUtils’ which has
non-virtual destructor will cause undefined behavior [-Wdelete-non-
virtual-dtor]
  delete mPgpUtils;
2018-02-20 23:28:48 +01:00
Gioacchino Mazzurco
0c99975800
Use link local address only if necessary
This should solve APIPA address being always selected as preferred local
address on Windows which was causing problems connecting to machines on
the same local network.
Now the link local address is used as fallback only if there is non link
local private address available.
2018-02-19 23:23:15 +01:00
csoler
566776366f
switched version to 0.6.4 2018-02-19 21:49:06 +01:00
csoler
2511934fb0
Merge pull request #1177 from csoler/v0.6-FT
added limiter in number of responses forwarded back by turtle search,…
2018-02-18 17:58:06 +01:00
csoler
7a844921ad
Merge pull request #1176 from csoler/v0.6-SecurityFixes
added load/save of known forums to avoid re-displaying it in the News…
2018-02-18 17:57:42 +01:00
csoler
6fe14136ae
added limiter in number of responses forwarded back by turtle search, which should avoid bursts of bandwidth for popular requests 2018-02-17 23:37:25 +01:00
csoler
8708dd9b94
fixed bug due to wrong service ID in serializer 2018-02-17 12:04:13 +01:00
csoler
d57f933109
added load/save of known channels to avoid re-displaying it in the NewsFeed after then have been deleted. 2018-02-16 23:51:43 +01:00
csoler
252626f5ec
added load/save of known forums to avoid re-displaying it in the NewsFeed after then have been deleted. 2018-02-16 23:24:01 +01:00
Phenom
83b6205af3 Fix New Chat Invite 2018-02-16 10:22:59 +01:00
csoler
0491e43118
Merge pull request #1169 from csoler/v0.6-FT
V0.6 ft
2018-02-11 21:28:43 +01:00
csoler
7a2d874863
Merge pull request #1153 from csoler/v0.6-TorOnly
V0.6 tor only
2018-02-11 20:49:45 +01:00
csoler
74a6076f18 added sources in new QModel. Unfinished yet. 2018-02-07 00:25:41 +01:00
csoler
3f8ff6489b first attempt at creating a display model for transfers. Not finished yet. 2018-02-04 22:56:13 +01:00
Gioacchino Mazzurco
00125864ff Add support for SQLCipher on Android
Plus some cleanup
2018-01-30 18:24:03 +01:00
Gioacchino Mazzurco
ebfe50f814 Make .pro files compiler agnostic on Android 2018-01-30 18:11:31 +01:00
Gioacchino Mazzurco
fa71ed25ba Install bdboot.txt in Android
DHT now works on android as bdboot.txt is bundled as android asset
Update Android documentation as DHT works on Android after this commit
2018-01-29 16:14:14 +01:00
csoler
8f7582588a fixed windows compilation 2018-01-27 20:59:11 +01:00
csoler
d0039241d3 replaced usleep() by rstime::rs_usleep() which accepts times >= 1 sec. Should fix problems on windows 2018-01-27 20:22:31 +01:00
Gioacchino Mazzurco
86ce177228 time_t may be signed in JSON 2018-01-27 19:57:15 +01:00
Gioacchino Mazzurco
ef6681b6f9 Remove outdated documentation 2018-01-27 19:40:39 +01:00
Gioacchino Mazzurco
8b774595d7 Better usage of type traits
Don't need register types for serializationanymore
Don't need casting helpers for serialization
2018-01-27 17:57:33 +01:00
Gioacchino Mazzurco
ba6f2d7e81 Remove default template for to/from_JSON
This way the compiler will complain if a type is added directly to
RsTypeSerializer without specify all needed serial operations
2018-01-26 17:18:05 +01:00
Gioacchino Mazzurco
13d4a2c916 Safer and elgant serial helper macros 2018-01-26 13:43:09 +01:00
csoler
725abad777 fixed a bug in filterItems that caused searched files to generate an error in the console 2018-01-23 22:18:02 +01:00
Gioacchino Mazzurco
7409de5170 Fix compilation on systems with atipic time_t 2018-01-22 21:53:12 +01:00
Gioacchino Mazzurco
443ffb9f85 Fix some warnings 2018-01-22 15:02:33 +01:00
Gioacchino Mazzurco
9c68bcbca4 Fix some warnings 2018-01-22 14:50:07 +01:00
Gioacchino Mazzurco
04d32d2f44 Remove duplicated include 2018-01-22 12:55:22 +01:00
Gioacchino Mazzurco
b95e3380c0 Fix Android compilation 2018-01-22 11:09:00 +01:00
Gioacchino Mazzurco
9d40d416f6 Better naming for serialization helper macro 2018-01-21 20:27:49 +01:00
csoler
95e8fc4404 merged upstream/master 2018-01-16 23:03:26 +01:00
Gioacchino Mazzurco
5cdc5aa58d Add automatic JSON serialization/deserialization
Abstract serialization concept to pure virtaul class RsSerializable
  from which every other serializable class must inherit from
Use RapidJSON for JSON manipulation
Add TO_JSON and FROM_JSON SerializeJob
Deprecate unused SerializationFormat
Remove some unused old piece of code
Adjust many lines to max 80 columns for better readability on little
  screens
Clean up documentation and code, remove old cruft
Add copyright notice on edited files that miss it
2018-01-16 03:31:03 +01:00
csoler
4c626e04a1
Merge pull request #1152 from csoler/v0.6-SecurityFixes
fixed possible crash due to accessing deleted memory in database cach…
2018-01-15 23:17:09 +01:00
csoler
841fee6799 fixed possible crash due to accessing deleted memory in database cache access 2018-01-15 23:13:42 +01:00
csoler
7cac367820 removed warnign about bad service string when the service string is actually empty 2018-01-14 22:39:50 +01:00
csoler
4eea5a8eca removed consts in GrpMetaCache pointers, and made it possible to always re=use cache entries, possibly updating them 2018-01-10 00:10:08 +01:00
csoler
506190a64b fixed bug causing failure of flag actions on groups 2018-01-09 22:11:11 +01:00
csoler
ed81b4cac6 removed delete causing read of deleted memory 2018-01-09 21:49:15 +01:00
csoler
89c538deb1 fixed double deletion problem causing crashes 2018-01-07 22:36:38 +01:00
csoler
b42b8e3a51 moved memory ownership of RsGxsGrpMetaData down into RsGxsDataAccess. Avoids many copy-constructors of RsTlvSecurityKey. Will probably spare a lot of CPU on windows 2018-01-07 21:41:41 +01:00
csoler
e28886fe79 updated to upstream/master 2018-01-05 21:59:22 +01:00
csoler
ab60f49820 prevent sending/receiving of IP addresses to/at hidden nodes 2018-01-03 18:37:43 +01:00
csoler
0f6006d140 prevent subscribing to a signed chat room without a signed identity 2018-01-03 15:01:04 +01:00
csoler
fcc3995d87 removed BanList service from Retro-Tor version 2018-01-01 15:49:49 +01:00
csoler
da5253059a fixed retrotor compilation when removing dht and udp 2017-12-31 17:27:21 +01:00
csoler
122f6af30a fixed compilation on ubuntu precise 2017-12-24 11:06:03 +01:00
csoler
f5ce711ad6 only load hidden nodes in retro-only mode 2017-12-21 21:34:51 +01:00
csoler
76ec079b40 added missing change in .pro 2017-12-20 22:14:58 +01:00
csoler
a173f325a9 added .h for RsGxsNetTunnel service 2017-12-20 00:09:34 +01:00
csoler
99e35b131c rename file in partials into real name before moving it; check for destination directory before moving file 2017-12-16 15:04:16 +01:00
csoler
b12f9323dc added some text to describe the protocol for GXS distant sync 2017-12-10 15:57:01 +01:00
csoler
63b3acb95a
Merge pull request #1113 from csoler/v0.6-SSL110Fix
added sha256 calculation functions, and non backward compatible SSL I…
2017-11-23 21:27:03 +01:00
csoler
1faa274e07 simplified memory management in certificate signature verification code 2017-11-22 23:46:57 +01:00
csoler
669f2ba7ba fixed a few bugs in signature verification code accross versions 2017-11-22 22:56:40 +01:00
csoler
f6d69e09d5 ensured maximum backward compatibility for crypto changes that will occur in future v0.7 2017-11-22 00:02:11 +01:00
Gioacchino Mazzurco
6d4c9422d9 Removed unnecessary executable flag on some files 2017-11-21 13:28:24 +01:00
csoler
e2c1661c49 fixed compilation with v0.7 defines 2017-11-20 22:44:34 +01:00
csoler
cd51afbc70 fixed small bug in signature and compilation 2017-11-20 22:26:14 +01:00
csoler
9367aa0d84 changed #ifs into #ifdefs because it us more robust, and moved the definition of variables to retroshare.pri 2017-11-19 20:15:36 +01:00
csoler
ef1a61374c added proper debug output for signature verification 2017-11-19 19:57:38 +01:00
csoler
863e6256c3 centralized the defines into a single file 2017-11-19 19:34:54 +01:00
csoler
e72bd9ff4f fixed bug causing certificate rejection 2017-11-19 18:38:46 +01:00
csoler
b4fdd4e0d0 added two additional non packward compatible changes for future version 0.7, and improvements of verifications of certificate signatures 2017-11-19 18:21:56 +01:00
csoler
7472f78223 added sha256 calculation functions, and non backward compatible SSL Id computation code to active later (0.7) 2017-11-15 23:24:43 +01:00
csoler
ba7cf4995b
Merge pull request #1037 from RetroPooh/searchspy
Searchspy
2017-11-14 20:53:24 +01:00
RetroPooh
919d6503d7 in search strings change comma to space for better look 2017-11-14 16:09:05 +03:00
Pooh
9aa6dd3f64
Update rsturtleitem.h 2017-11-14 14:34:22 +03:00
csoler
5fab053fb8 added toStdString() method to search strings so as to display what is searched 2017-11-13 23:37:53 +01:00
Phenom
72b917de37 Fix CppCheck in UPnPBase.h
/libretroshare/src/upnp/UPnPBase.cpp:62: warning:
Cppcheck(funcArgOrderDifferent): Function 'CUPnPPortMapping' argument
order different: declaration 'in_port, ex_port, protocol, enabled,
description' definition 'ex_port, in_port, protocol, enabled,
description'
/libretroshare/src/upnp/UPnPBase.h:109: warning:
Cppcheck(noExplicitConstructor): Class 'CUPnPLib' has a constructor with
1 argument that is not explicit.
/libretroshare/src/upnp/UPnPBase.h:577: warning:
Cppcheck(noExplicitConstructor): Class 'CUPnPControlPoint' has a
constructor with 1 argument that is not explicit.
2017-11-07 22:04:46 +01:00
Phenom
2933861691 Fix CppCheck in p3turtle.cc
/libretroshare/src/turtle/p3turtle.cc:1450: warning:
Cppcheck(unusedVariable): Unused variable: info
/libretroshare/src/turtle/p3turtle.cc:1875: warning:
Cppcheck(redundantIfRemove): Redundant checking of STL container element
existence before removing it.
2017-11-07 22:04:10 +01:00
Phenom
2728880621 Fix CppCheck in p3postbase.cc
/libretroshare/src/services/p3postbase.cc:628: warning:
Cppcheck(invalidScanfArgType_int): %d in format string (no. 1) requires
'int *' but the argument type is 'unsigned int *'.
/libretroshare/src/services/p3postbase.cc:628: warning:
Cppcheck(invalidScanfArgType_int): %d in format string (no. 2) requires
'int *' but the argument type is 'unsigned int *'.
/libretroshare/src/services/p3postbase.cc:628: warning:
Cppcheck(invalidScanfArgType_int): %d in format string (no. 3) requires
'int *' but the argument type is 'unsigned int *'.
2017-11-07 21:59:58 +01:00
Phenom
d0eb40b08c Fix CppCheck in p3discovery2.cc
/libretroshare/src/services/p3discovery2.cc:916: warning:
Cppcheck(unreadVariable): Variable 'sit' is assigned a value that is
never used.
2017-11-07 21:59:34 +01:00
Phenom
7278f67073 Fix CppCheck in p3bwctrl.h
/libretroshare/src/services/p3bwctrl.h:77: warning:
Cppcheck(noExplicitConstructor): Class 'p3BandwidthControl' has a
constructor with 1 argument that is not explicit.
2017-11-07 21:59:04 +01:00