Commit Graph

5747 Commits

Author SHA1 Message Date
sehraf
897c8e0a8a
jsonapi: more rsMsg functions 2018-10-04 22:43:13 +02:00
sehraf
70678ad508
jsonapi: fix std::map<T,U> 2018-10-04 22:43:13 +02:00
sehraf
150af40e09
jsonapi: convert and add getMessageCount 2018-10-04 22:43:12 +02:00
sehraf
285158db5f
jsonapi: access messages (mail) 2018-10-04 22:43:12 +02:00
csoler
c6d0203557
added debug output to see which config files are loaded/saved 2018-10-04 19:22:49 +02:00
csoler
fb21e427be
removed saving of GxsTrans configuration in class destructor, causing lock up when quitting RS 2018-10-04 19:14:21 +02:00
Gioacchino Mazzurco
7c986b926d
Remove overloaded GetRetroshareInvite method
now the original method has default paramether that return invite for
  own node, this way JSON API is more friendly
2018-10-04 19:14:16 +02:00
Gioacchino Mazzurco
7cc15c703c
Fix forward declarations class struct missmatch 2018-10-03 19:07:46 +02:00
Gioacchino Mazzurco
e6e5700ed6
Fix warning caused by clang defining _GNUC_ 2018-10-03 19:07:46 +02:00
Gioacchino Mazzurco
8f3f2cd7cb
retroshare-service improve building process 2018-10-03 15:53:18 +02:00
csoler
81fc3b7921
select GxsIds as default list to chose msg destination from 2018-10-03 15:25:53 +02:00
Phenom
6ef72f551d Fix Gcc Warning in authssl.cc
/libretroshare/src/pqi/authssl.cc:160: warning: ‘void
dyn_destroy_function(CRYPTO_dynlock_value*, const char*, int)’ defined
but not used [-Wunused-function]
 static void dyn_destroy_function(struct CRYPTO_dynlock_value *l, const
char */*file*/, int /*line*/)
/libretroshare/src/pqi/authssl.cc:143: warning: ‘void
dyn_lock_function(int, CRYPTO_dynlock_value*, const char*, int)’ defined
but not used [-Wunused-function]
 static void dyn_lock_function(int mode, struct CRYPTO_dynlock_value *l,
const char */*file*/, int /*line*/)
/libretroshare/src/pqi/authssl.cc:121: warning: ‘CRYPTO_dynlock_value*
dyn_create_function(const char*, int)’ defined but not used [-Wunused-
function]
 static struct CRYPTO_dynlock_value *dyn_create_function(const char */
*file*/, int /*line*/)
/libretroshare/src/pqi/authssl.cc:106: warning: ‘long unsigned int
id_function()’ defined but not used [-Wunused-function]
 static unsigned long id_function(void)
/libretroshare/src/pqi/authssl.cc:92: warning: ‘void
locking_function(int, int, const char*, int)’ defined but not used [-
Wunused-function]
 static void locking_function(int mode, int n, const char */*file*/, int
/*line*/)
2018-09-30 15:10:40 +02:00
Phenom
1839d23df1 Fix Gcc Warning hashstream.h
/libretroshare/src/crypto/hashstream.cc:38: warning: friend declaration
‘template<class T> librs::crypto::HashStream&
librs::crypto::operator<<(librs::crypto::HashStream&, const T&)’ is not
visible to explicit specialization
  HashStream& operator<<(HashStream& u,const std::string& s)
/libretroshare/src/crypto/hashstream.cc:44: warning: friend declaration
‘template<class T> librs::crypto::HashStream&
librs::crypto::operator<<(librs::crypto::HashStream&, const T&)’ is not
visible to explicit specialization
  HashStream& operator<<(HashStream& u,const uint64_t& n)
/libretroshare/src/crypto/hashstream.cc:58: warning: friend declaration
‘template<class T> librs::crypto::HashStream&
librs::crypto::operator<<(librs::crypto::HashStream&, const T&)’ is not
visible to explicit specialization
  HashStream& operator<<(HashStream& u,const uint32_t& n)
/libretroshare/src/crypto/hashstream.cc:72: warning: friend declaration
‘template<class T> librs::crypto::HashStream&
librs::crypto::operator<<(librs::crypto::HashStream&, const T&)’ is not
visible to explicit specialization
  HashStream& operator<<(HashStream& u,const uint8_t& n)
2018-09-30 15:10:40 +02:00
csoler
79a8b2183f
Merge pull request #1353 from csoler/v0.6-FileLists
V0.6 file lists
2018-09-30 13:31:26 +02:00
csoler
443dbdfbef
fixed small bug breaking display of flat mode in files 2018-09-29 19:04:23 +02:00
Gioacchino Mazzurco
0078501dba
Initial work on a RetroShare cross-platform service
This doesn't need any interacion of the user at startup, unlike
retroshare-nogui which requires the user to login on the shell this doesn't
even need a TTY.
At startup this just parse command line, read the PGP keyring, look for
available locations, and start listening for JSON API requests.
Another difference with retroshare-nogui is that this is capable to
generate/import PGP identities, generate locations, and in general anything
possible through the RetroShare API.
retroshare-service is suitable also to run it as a system service, even
in very constrained systems such as Android ot a Docker container.
retroshare-service drop support for libresapi so only the new JSON API
is exposed, it will completely obsolete retroshare-android-service once
retroshare-qml-app is ported to the new JSON API.
2018-09-29 00:15:10 +02:00
csoler
752275f813
fixed various display bugs in extra file list 2018-09-27 22:14:00 +02:00
csoler
54ec49dc03
make extra shared file list appear only when non empty 2018-09-27 21:56:41 +02:00
csoler
e1698429de
fixed display of size 2018-09-27 21:46:00 +02:00
csoler
2610f62e41
fixed display of temporary shared file text 2018-09-27 21:42:21 +02:00
csoler
c77a28c17a
added proper notification when removing an extra file 2018-09-27 21:20:06 +02:00
csoler
7ab7c7db93
added possibility to remove extra shared file 2018-09-27 16:53:08 +02:00
csoler
1383846364
added extra list view in own files. 2018-09-27 13:42:49 +02:00
Phenom
aec68c2269 Fix qmake double using retroshare.pri
From 544b4af4c2
2018-09-26 17:55:58 +02:00
Phenom
f420bb4644 Fix qmake warnings:
Makefile.libretroshare:3811: warning: overriding recipe for target
'temp/linux-g++/obj/hashstream.o'
Makefile.libretroshare:3772: warning: ignoring old recipe for target
'temp/linux-g++/obj/hashstream.o'
2018-09-26 17:36:33 +02:00
G10h4ck
f09bef2ac8
Merge pull request #1349 from G10h4ck/jsonapi
Implement JSON API HTTP Basic authentication
2018-09-25 18:10:16 +02:00
Gioacchino Mazzurco
95e0fd338f
JsonApiServer::isAuthTokenValid avoid timing attack
Thanks Cyril for review :)
2018-09-25 17:27:54 +02:00
Gioacchino Mazzurco
1c7f02655e
Fix crash at startup if jsonapi not enabled 2018-09-21 01:40:26 +02:00
Gioacchino Mazzurco
bf98166197
RsServer fix crash on stop if shutdown callback not set 2018-09-21 01:39:48 +02:00
zapek
dc926d30c8 links with wsock32 only if the jsonapi is built 2018-09-20 23:29:36 +02:00
zapek
458a8b0878 fixed JSONAPI build for Windows 2018-09-20 22:24:05 +02:00
Gioacchino Mazzurco
add97dede0
p3face include jsonapi.h only if enabled 2018-09-19 22:02:07 +02:00
Gioacchino Mazzurco
eb77f921ec
Implement JSON API HTTP Basic authentication
jsonapi-generator is now capable of generating API for headers outside
  retroshare/ directory
jsonapi-generator do a bit of methods parameter sanity check
JsonApiServer is now integrated in the rsinit hell like other services
Add *::exportGPGKeyPairToString to a bunch of classes in cascade
RsControl is now capable of calling back a function when retroshare is almost
  completely stopped, this is useful when running retroshare toghether with
  externally managed runloop such as QCoreApplication
Expose a bunch of methods through JSON API
retroshare-nogui remove some dead code and fix stopping from the RetroShare API
2018-09-19 21:28:26 +02:00
Gioacchino Mazzurco
43bc80de8e
JSON API export version extra too 2018-09-15 21:53:46 +02:00
Gioacchino Mazzurco
cd03953b1a
Provide meaningful devault value in rsversion.h 2018-09-15 21:07:03 +02:00
hunbernd
05537d89cb Added warning instead of running the version_detail script 2018-09-15 18:27:15 +02:00
G10h4ck
eece958aa0
Merge pull request #1340 from sehraf/pr_remove-obsolete-version-scripts
remove obsolete version scripts
2018-09-15 17:59:09 +02:00
sehraf
0b6644cd55
get rid of unused variables 2018-09-15 14:38:57 +02:00
sehraf
1e85b05f09
get rid of cipher_version variable. use plain output from openssl 2018-09-15 14:37:40 +02:00
sehraf
1faaf91ebe
G10h4ck said that there are obsolete since #1336 and should not be used anymore. 2018-09-14 17:01:52 +02:00
sehraf
7ce2bef37b
add support for displaying TLSv1.3 2018-09-14 16:27:50 +02:00
Gioacchino Mazzurco
148e46346d
JSON API accessible via HTTP GET method
This is useful in cases where the client cannot use POST method.
/jsonApiServer/shutdown now reply before shutting down the core.
2018-09-12 23:40:34 +02:00
Gioacchino Mazzurco
1694e37c58
More fixes to JSON API
Remove unnecessary dangerous method from RsLoginHelper
Fix documentation for RsServiceControl::getServiceName that was breaking
  JSON API and causing compilation warning
2018-09-12 10:49:37 +02:00
Gioacchino Mazzurco
5245765964
JSON API expose retroshare version
Added a couple of macro to reduce boilerplate in manually written API
wrappers, use them in auto-generated wrappers too
2018-09-12 10:49:37 +02:00
Gioacchino Mazzurco
92f90178c4
RS version is now parametrizable at compile time
Avoid the need of dirty patching to set the version at build time
In case RS version is not passed as argument attempt to determine it
  using git describe, if unavailable use hardcoded default
2018-09-12 10:49:36 +02:00
Gioacchino Mazzurco
5495f43c51
Fix RsServiceControl::getServiceItemNames doc
Was breaking JSON API and causing some compilation warnings
2018-09-12 00:31:16 +02:00
csoler
b138263878
Merge pull request #1323 from csoler/v0.6-ForumAdmin
V0.6 forum admin
2018-09-11 15:17:33 +02:00
csoler
c17b821ea6
Merge pull request #1334 from csoler/v0.6-GxsFix
auto send of own signed GXS ids to friends in discovery
2018-09-10 20:39:29 +02:00
csoler
2b80c23f6a
fixed according to comments on PR 1334 2018-09-10 20:03:47 +02:00
G10h4ck
cb83abf932
Merge pull request #1335 from sehraf/pr_jsonfy
Make more APIs jsonapi compatible
2018-09-10 00:29:07 +02:00
sehraf
247c368279
incorporated requested changes 2018-09-09 22:22:55 +02:00
csoler
59a76a9418
fixed checking of signature for own ids when loading in cache 2018-09-09 21:22:08 +02:00
sehraf
ae6a5c74d2
add rsPeer groups to jsonapi 2018-09-08 17:04:29 +02:00
sehraf
5a961179f3
unify parameter names 2018-09-08 09:48:27 +02:00
sehraf
31b0f67e94
jsonfy RsServiceControl 2018-09-08 09:47:45 +02:00
sehraf
9306d8ccc8
drop deprecated function 2018-09-08 08:58:42 +02:00
sehraf
ae14a01d58
add json support to getWaitingDiscCount 2018-09-07 14:19:06 +02:00
sehraf
be50400114
jsonfy rsDisc 2018-09-07 14:17:44 +02:00
sehraf
fb8e49ee66
jsonjy rsConfig 2018-09-07 12:58:30 +02:00
csoler
3402f7d9b5
auto send of own signed GXS ids to friends in discovery 2018-09-06 21:15:25 +02:00
sehraf
39c07f4ef0
make p3GxsTrans a class 2018-09-06 13:17:33 +02:00
csoler
b17d2a3aca
Merge pull request #1331 from G10h4ck/jsonapi
JSON API improvements
2018-09-06 08:39:30 +02:00
Gioacchino Mazzurco
2c8aa5a1fe
RsAccounts::getCurrentAccountId is now static 2018-09-06 02:04:48 +02:00
csoler
4a309b827a
fixed compilation with libressl2.7 (patch from sss, modified) 2018-09-05 21:00:34 +02:00
Gioacchino Mazzurco
7787f9d62f
Merge branch 'master' into jsonapi 2018-09-05 00:17:21 +02:00
Gioacchino Mazzurco
a194e4cf56
Make JSON API server bind address configurable
Enforce it being 127.0.0.1 by default, I assumed 127.0.0.1 was restbed
default, but as reported by sehraf is not alwayd the case

JSON API bind address now is also configurable via commandline on
retroshare-android-service and retroshare-nogui, while it obey the
configuration of webui (execept for that port is incremented by 2)
in retroshare-gui
2018-09-05 00:08:56 +02:00
csoler
59535eac8a
added a flag for moderating messages to help removign them when the author is not a moderator anymore 2018-09-02 17:07:40 +02:00
Gioacchino Mazzurco
7f74313552
JSON API close restbed session before shutting down 2018-09-01 15:54:11 +02:00
Gioacchino Mazzurco
7a37c11e47
Prevent crash calling uninitialized service via JSON API 2018-09-01 15:29:09 +02:00
Gioacchino Mazzurco
cc6f0b1f05
Expose RsPeers JSON API
Added also new method for better usability via the API that allow to add
  friend directly for RetroShare invitation (supports also URL) without
  having to call to mulptiple metods to set IP etc.
  RsPeers::acceptInvite
  /rsPeers/acceptInvite
2018-08-30 21:45:51 +02:00
Gioacchino Mazzurco
a8ddec03fc
Expose more login related JSON API
/rsLoginHelper/isLoggedIn to check if already logged in
/rsAccounts/getCurrentAccountId to get the id of current selected
  account, beware that an account may be selected without actually logging in
2018-08-30 19:09:50 +02:00
csoler
5c2f714ada
merged with upstream/master 2018-08-30 14:50:16 +02:00
csoler
65304a301a
added last relay (a.k.a which direct friend) of search results in sources column 2018-08-28 23:57:16 +02:00
csoler
c9b30f5a72
fixed merged with upstream/master 2018-08-28 23:42:24 +02:00
csoler
c294971633
Merge pull request #1289 from G10h4ck/jsonapi
Implement automatic JSON API generation
2018-08-28 19:11:08 +02:00
Gioacchino Mazzurco
dd55ddea95
Add more consistency checks to serialization code
As suggested by Cyril
2018-08-28 15:20:41 +02:00
Gioacchino Mazzurco
3094146c13
RsLoginHelper::attemptLogin clear cached passphrase after usage
Thanks Cyril for suggestion
2018-08-28 14:35:29 +02:00
Gioacchino Mazzurco
75e882bb9f
Make NotifyClient class again 2018-08-28 14:12:09 +02:00
csoler
5f18d26738
removed unused member depth from search results to avoid confusion while ensureing backward compatibility is kept 2018-08-27 23:36:21 +02:00
csoler
fd25f8336e
Merge pull request #1329 from sehraf/pr_small-fixes
small fixes
2018-08-27 10:56:29 +02:00
Gioacchino Mazzurco
1dfe64443f
Improve documentation 2018-08-26 11:39:26 +02:00
csoler
2fab33d37f
fixed a few bugs in ban file list management 2018-08-25 20:52:06 +02:00
csoler
b5eabf7af7
improved banned files UI and fixed deadlock 2018-08-25 20:18:54 +02:00
csoler
c14d898901
added some debug info to file control system and fixes a problem with sending TS 2018-08-25 18:44:29 +02:00
G10h4ck
41f7235ed0
Merge pull request #2 from sehraf/pr_improve_json
Multiple fixes on json handling by sehraf
2018-08-25 18:05:56 +02:00
Gioacchino Mazzurco
c50405c070
Expose /rsFiles/turtleSearchRequest via JSON API
Expose new async C++ API RsFiles::turtleSearchRequest with callback
Modernize TurtleFileInfo serialization code keeping retrocompatibility
2018-08-25 17:58:04 +02:00
sehraf
9557a5246e
remove unnecessary locking, print log entries also to stdout 2018-08-25 17:54:34 +02:00
sehraf
c754435944
fix deserialisation and improve PRINT job 2018-08-25 17:10:01 +02:00
Gioacchino Mazzurco
a8b2532d3b
Fix warning #pragma once used in main file
Probably a copy paste error made during license cleanup
2018-08-25 17:04:42 +02:00
sehraf
588295e1e5
make RsGroupInfo serializable 2018-08-25 16:52:46 +02:00
sehraf
4d03b906b8
convert values properly to string 2018-08-25 16:51:49 +02:00
Gioacchino Mazzurco
31f0a42b86
Merge branch 'csoler/v0.6-FT' into jsonapi
Needed to exopse JSON API for file search
2018-08-25 16:14:42 +02:00
Gioacchino Mazzurco
b98246ee21
Fix location creation via JSON API
To complete location creation login is needed
2018-08-25 00:19:26 +02:00
csoler
8eebe53d75
moved UI notification for turtle FT search results into ftServer, in order to allow easier libresAPI calls 2018-08-24 16:12:05 +02:00
Gioacchino Mazzurco
afb92999d8
Enable JSON conversion for RsGxsImage via MemBlockProxy 2018-08-24 00:31:25 +02:00
Gioacchino Mazzurco
afeb408f7a
Expose more RsFiles via JSON API
FileInfo remove dead static members
2018-08-23 22:38:21 +02:00
Gioacchino Mazzurco
4d30d4f32b
Avoid cloning huge unused restbed openssl dependency 2018-08-23 15:47:01 +02:00
Gioacchino Mazzurco
18feb23c77
Suggest shallow submodules for jsonapi dependencies 2018-08-23 14:20:24 +02:00
Gioacchino Mazzurco
3b72f912e4
Improve API
Manually expose /rsFiles/getFileData to stream/preview files
Automatically expose a bunch of methods via JSON API
Implement serial_process for std::pair
2018-08-23 01:39:26 +02:00
csoler
3055897425
added filter in p3turtle against banned hashes in tunnel requests and search results 2018-08-22 21:57:56 +02:00
Gioacchino Mazzurco
ab6a5c07cc
RsLoginHelper::createLocation expose capability of creating hidden locations 2018-08-22 17:22:27 +02:00
Gioacchino Mazzurco
8f7bacbb35
Remove #pragma once in .cc file
It was probably introduced by copy paste error on license cleanup
2018-08-22 17:00:22 +02:00
Gioacchino Mazzurco
396fe49312
Merge branch 'master' into jsonapi 2018-08-22 16:59:42 +02:00
csoler
365464623a
added load/save of banned files and handling of banned files information from friends 2018-08-21 11:20:02 +02:00
csoler
0b176a0fe5
added sending of banned file info 2018-08-20 23:30:05 +02:00
csoler
e5e566051b
added logic to compute ban list from friend nodes and own opinions 2018-08-19 21:11:17 +02:00
csoler
af7556610a
added option whether to trust friend nodes for banned files 2018-08-19 15:52:35 +02:00
Gioacchino Mazzurco
fe8c2c4683
Merge branch 'jsonapi' of github.com:G10h4ck/RetroShare into jsonapi 2018-08-16 23:51:35 +02:00
Gioacchino Mazzurco
4b6f751b09
Implement JSON API generation for async API calls
Move JSON helpers to util/rsjson.* for better usability
Implement JSON ostream manipulator to print compact and pretty JSON
Use lambdas for API wrappers, integrate better and avoid namespace
  pollution
Removed experimental JSON API for notify client wrapper, notifications
  can be implemented automatically with moderns async API calls
Implement and automatically expose to JSON API
  RsGxsChannels::turtleSearchRequest(
        const std::string& matchString,
        const std::function<void (const RsGxsGroupSummary&)>& multiCallback,
        std::time_t maxWait )
2018-08-16 23:48:21 +02:00
csoler
e17c4d0e40
added a dialog to edit banned files 2018-08-16 22:22:47 +02:00
csoler
50e03a539c
basic infrastructure for banning unwanted file content 2018-08-16 18:49:36 +02:00
Gioacchino Mazzurco
b7f5d4286f
RsGxsNetService::receiveTurtleSearchResults fix deadlock
Avoid notifing observer while the mutex is locked by storing results in
a temporary set
2018-08-16 14:26:41 +02:00
csoler
5b1c150acb
added background for post pinning and logic to edit others posts 2018-08-12 15:30:07 +02:00
csoler
ded9c21617
added selection boxes to add forum moderators 2018-08-09 21:18:37 +02:00
sehraf
a556965813
further conversion to new wrapper function 2018-08-03 20:19:10 +02:00
csoler
cc51298de6
fixed warning about badly overloaded function in rsexpr.h 2018-08-02 14:13:14 +02:00
csoler
985be3504e
fixed compilation with RS_AUTO_LOGIN 2018-08-01 23:05:36 +02:00
sehraf
97194fd092
Add wrapper function to convert uint16_t service IDs to internal unsigned int.
Use it when looking up service names.
2018-08-01 20:47:02 +02:00
csoler
c948517c3d
Merge pull request #1306 from csoler/v0.6-TorOnly
V0.6 tor only
2018-07-31 14:18:24 +02:00
csoler
ecd45215c7
disallow empty file when loading shared file list in order to avoid malloc of size 0 2018-07-31 14:13:01 +02:00
csoler
1297d2e106
fixed double calls to pthread_exit() (one being implicit after return from main thread method) -- patch from sss 2018-07-30 10:50:32 +02:00
csoler
d7c7e35d71
fixed compilation on MacOS 2018-07-27 15:15:04 +02:00
csoler
cc1a05ddc9
fixed certificate creation in TorAuto mode 2018-07-27 12:33:06 +02:00
csoler
62b9a74324
fixed running with TorControl in new mode 2018-07-25 15:31:18 +02:00
csoler
d1a375cbd0
removed RETROTOR #ifdef and started using RsAccounts::isTorAuto() instead. Unfinished yet. 2018-07-25 11:37:40 +02:00
Gioacchino Mazzurco
d2a62b03ee
Fix deep search returning 0 results 2018-07-25 00:29:36 +02:00
Gioacchino Mazzurco
b4dd89dd87
Fix deep search returning 0 results 2018-07-25 00:27:39 +02:00
csoler
0f758902cd
started cleaning the mess with rsAccounts: only exposed useful functionality of rsAccount beyond a static class and removed all references to rsAccounts in the code 2018-07-24 23:47:32 +02:00
sehraf
7af5075891
fix jsonapi.h 2018-07-24 20:59:20 +02:00
sehraf
e6acb52d17
add simple chat support 2018-07-24 20:09:45 +02:00
thunder2
7128a04525 Added Xapian to Windows build environment 2018-07-24 16:03:32 +02:00
Gioacchino Mazzurco
1bc518041c
Experiment of notification via NotifyClient + JSON API 2018-07-23 14:52:17 +02:00
Gioacchino Mazzurco
130007b578
Merge branch 'master' into jsonapi 2018-07-23 13:44:01 +02:00
G10h4ck
fbc4e4205d
Merge pull request #1292 from G10h4ck/deep_search
Content search for channels trough xapian
2018-07-23 11:48:55 +02:00
Gioacchino Mazzurco
e8c9ba52b2
Improve code quality after Cyril review 2018-07-23 11:18:32 +02:00
Gioacchino Mazzurco
6f8c2f6f41
Fix compilation if deep_search is disabled 2018-07-22 23:39:06 +02:00
Gioacchino Mazzurco
51c25219bb
Fix compiling with old GCC 2018-07-22 22:47:30 +02:00
Gioacchino Mazzurco
d9aa37219c
Revert "DROP before merge. Reduce INTEGRITY_CHECK_PERIOD"
This reverts commit ce61174d79.
2018-07-22 21:45:43 +02:00
Gioacchino Mazzurco
f97dc8a125
Properly plug deep search in GXS search
Some modifications breaks retrocompatibility of GXS search:
  remove horrible templated RsTypeSerializer::serial_process for
    RsGxsGroupSummary with hardcoded member names
  RsGxsGroupSummary doesn't use old TLV serialization format anymore
  RsGxsGroupSummary remove unused description member
  RsGxsGroupSummary derive from RsSerializable and use serialization
    helper macro
Add autor id and signature flags to the index so there is no need to
  retrive them from GXS, thus improving performances
RsGroupNetworkStats initialize members properly
RsGxsGroupSummary rename members to follow usual mMemberName convention
2018-07-22 21:33:40 +02:00
csoler
82c9084ca4
Merge pull request #1303 from csoler/v0.6-GXS-DistSync3-TurtleSearch
fixed deadlock due to turtle calling addVirtualPeer for client servic…
2018-07-22 00:22:51 +02:00
csoler
2ab12a2ef5
fixed deadlock due to turtle calling addVirtualPeer for client services inside a mutex protected zone (breaks mutex order service > turtle) 2018-07-22 00:21:45 +02:00
Gioacchino Mazzurco
6982ae6cd5
Improve retrocompatibility with older xapian 2018-07-21 13:35:05 +02:00
Gioacchino Mazzurco
ff166b2295
Merge branch 'master' into deep_search 2018-07-21 12:57:05 +02:00
csoler
e72ef242c9
Merge pull request #1298 from csoler/v0.6-DebianPackaging
V0.6 debian packaging
2018-07-20 19:16:58 +02:00
Gioacchino Mazzurco
3fc9ff3fef
WIP Plug deep search into GXS search 2018-07-20 15:29:37 +02:00
Gioacchino Mazzurco
a31b06ab60
Merge branch 'master' into deep_search
Needed to make deep search and GXS search cooperate
2018-07-20 13:15:11 +02:00
csoler
d4fce07e4c
changed lrand48 to RSRandom for cross-plateform compatibility, in rsgxsnettunnel.cc 2018-07-19 23:46:31 +02:00
csoler
2bab688dec
fixed merge with upstream/master 2018-07-19 23:22:24 +02:00
csoler
b8062f2e21
Merge pull request #1294 from csoler/v0.6-GXS-DistSync3-TurtleSearch
V0.6 gxs dist sync3 turtle search
2018-07-19 22:59:43 +02:00
csoler
dac885e24d
made randomBias initilized with true random bytes at start 2018-07-18 21:22:38 +02:00
csoler
9b0a4b966e
removed extra call to loadConfiguration() 2018-07-18 21:20:51 +02:00
sehraf
55e99ef0d1
add auto detection of installed rapidjson 2018-07-16 23:22:04 +02:00
csoler
1de31493a9
fixed up display of GXS net tunnel info 2018-07-15 19:09:12 +02:00
csoler
fd45d44826
added interface to get statistics about GxsNetTunnel 2018-07-15 11:14:58 +02:00
csoler
b20bd0a454
added admin list to forum group data 2018-07-15 10:13:04 +02:00
csoler
6848a586f3
merged upstream/master 2018-07-08 21:17:48 +02:00
chelovechishko
b3dddeafdf add missing namespaces 2018-07-06 23:55:12 +09:00
csoler
0c45217fc0
merged upstream/master 2018-07-05 17:41:30 +02:00
csoler
98f8e4da0a
added per-item type limit for turtle search results 2018-07-05 17:40:06 +02:00
csoler
4a64ea5f1f
added optional use of dist sync in GroupFrameDialog 2018-07-05 14:00:04 +02:00
csoler
0cc87c9880
fixed bug causing search data result to not be forwarded correctly (missing request id) 2018-07-05 12:20:22 +02:00
csoler
0e37de3e11
made retrieval of group data manual instead of automatic 2018-07-05 11:43:55 +02:00
csoler
59c51a250b
removed debug switch to allow display of existing distant group search results 2018-07-05 10:16:48 +02:00
csoler
47e760a2c5
added a few missing mutexes in prevent searches to be shown when already known 2018-07-05 10:11:12 +02:00
csoler
2067b106e4
fixed missing code in passing turtle group data result to client service 2018-07-04 23:54:26 +02:00
csoler
8ad454723a
added group data request when search items are selected 2018-07-04 21:42:09 +02:00
Gioacchino Mazzurco
d3e5b760a2
DeepSearch index channels posts too
Improve indexing using RsUrl, store some relevant fields in stored url
2018-07-04 12:08:50 +02:00
Gioacchino Mazzurco
32014eaac1
Use proper path for DeepSearch xapian DB 2018-07-02 17:31:47 +02:00
Gioacchino Mazzurco
5a41b3cb37
Index only public channels 2018-07-02 17:31:47 +02:00
Gioacchino Mazzurco
0f63283f96
Add search capability to DeepSearch 2018-07-02 17:31:47 +02:00
Gioacchino Mazzurco
c15ae864b5
deep_search: use service serializer not serial_process
Avoid tricky pointers arithmetic, thanks Cyril for suggestion
2018-07-02 17:31:47 +02:00
Gioacchino Mazzurco
c0e92ddc6b
WIP Index GXS channels with xapian
Use temporary DB ATM
2018-07-02 17:29:54 +02:00
Gioacchino Mazzurco
ce61174d79
DROP before merge. Reduce INTEGRITY_CHECK_PERIOD
So it run each two 2 minutes and it's easy to debug deep search
2018-07-02 17:29:52 +02:00
Gioacchino Mazzurco
418c42bd11
Extra locators in cert invite made optional 2018-07-02 13:50:02 +02:00
Gioacchino Mazzurco
1dd707710b
Merge branch 'master' into extra_locators_merge 2018-07-02 12:22:23 +02:00
csoler
80a43fe3d5
added secure retrieval of distant groups 2018-06-30 21:52:25 +02:00
Gioacchino Mazzurco
1c63cec735
Expose some RsFiles method trought JSON API 2018-06-29 16:02:07 +02:00
Gioacchino Mazzurco
102558afdf
Merge fixes to serialization from master branch 2018-06-29 00:13:07 +02:00
sehraf
f7625e3526
fix json uint64 2018-06-28 20:25:10 +02:00
Gioacchino Mazzurco
d511b6648e
Extend JSON API to shutdown retroshare gracefully 2018-06-28 15:04:06 +02:00
Gioacchino Mazzurco
0ff80baed3
Extend JSON API with reasonable way to create location 2018-06-28 12:06:43 +02:00
csoler
db06c32e80
turned turtle encryption routine into a generic authenticated encryption method in librs::crypto 2018-06-28 10:01:57 +02:00
Gioacchino Mazzurco
4637fbaff5
Add login JSON API
Implement a "normal" way to login RsLoginHelper::attemptLogin
Implement a way to get locations list RsLoginHelper::getLocations
Enable JSON API into retroshare-android-service
2018-06-27 08:52:03 +02:00
csoler
00dfa0f3c2
added fallback for GXS GroupMessage UI to look into cached distant group data 2018-06-26 22:20:02 +02:00
Gioacchino Mazzurco
d14a455cf1
jsonapi-generator fix support for void methods
Thanks sehraf for reporting
retroshare://forum?name=fucking%20genius&id=8fd22bd8f99754461e7ba1ca8a727995&msgid=503d75bf7ed7fa7568eeae4db5c8d31a7e124c98
2018-06-26 22:01:17 +02:00
Gioacchino Mazzurco
cb11ad92ea
Merge branch 'master' into jsonapi 2018-06-26 15:19:25 +02:00
Gioacchino Mazzurco
502459a25a
Cleanup rapidjson inclusion
Fix compilation error of android service
2018-06-26 15:12:16 +02:00
Gioacchino Mazzurco
15f39129f1
Complete GxsChannels JSON API with blocking methods
RsGxsIfaceHelper::requestStatus expose it to JSON API
Implemented RsGxsIfaceHelper::waitToken to wait for GXS operations
RsItem::serial_process fix doxygen warning as it's a comment not documentation
RsTypeSerializer add JSON conversion methods for double [de]serialization not
	implemented yet
RsTypeSerializer_PRIVATE_{FROM,TO}_JSON_ARRAY fix doxygen warning as it's a
	comment not documentation
make GxsChannels::ExtraFileHash a bit more reasonable
jsonapi-generator fix unused variable warning if there is no input or output
	paramethers
jsonapi-generator fix generation for inerithed jsonapi methods
Convert to RsSerializable some Gxs structs for the JSON API
2018-06-26 13:20:24 +02:00
Gioacchino Mazzurco
d731b665db
Expose tokenservice methods trough GxsIfaceHelper 2018-06-25 10:44:39 +02:00
Gioacchino Mazzurco
2f4b9b3e20
Convert to RsTokenService::GxsRequestStatus
Indicate GxsRequest status with an enum instead of uint_* that make the
  code less readable and more prone to errors
2018-06-24 23:24:52 +02:00
Gioacchino Mazzurco
b4d2ce82c1
RsTokenService use enum for request status 2018-06-24 18:56:48 +02:00
Gioacchino Mazzurco
ec95b6d054
Remove unused misleading GXS request status
Something must be really strange to be finished and incomplete at same
  time..
2018-06-24 18:03:26 +02:00
csoler
e351d7257e
added retrieval of search results in UI 2018-06-24 16:55:38 +02:00
Gioacchino Mazzurco
7ad337c8d2
Implement automatic JSON API generation
qmake file add jsonapi-generator target to compile JSON API generator
qmake files add rs_jsonapi CONFIG option to enable/disable JSON API at compile
  time
RsTypeSerializer pass down same serialization flags when creating new context
  for nested objects serial job
RsGxsChannels expose a few methods through JSON API as example
Derive a few GXS types (RsGxsChannelGroup, RsGxsChannelPost, RsGxsFile,
  RsMsgMetaData) from RsSerializables so they can be used for the JSON API
Create RsGenericSerializer::SERIALIZATION_FLAG_YIELDING so JSON objects that
  miss some fields can be still deserialized, this improve API usability
SerializeContext offer friendly constructor with default paramethers
Add restbed 4.6 library as git submodule as most systems doesn't have it yet
Add a bit of documentation about JSON API into jsonapi-generator/README.adoc
Add JsonApiServer class to expose the JSON API via HTTP protocol
2018-06-24 16:28:33 +02:00
csoler
6ccc7654d6
added code to notify GxsBroadcast system with new distant search results 2018-06-23 22:25:36 +02:00
csoler
5b9666855d
fixed merge with upstream 2018-06-22 23:38:31 +02:00
csoler
2f159efb10
Merge pull request #1288 from csoler/v0.6-GxsFix
changed std::vector into std::set in notification system, hence remov…
2018-06-22 22:06:59 +02:00
csoler
84699db744
changed std::vector into std::set in notification system, hence removing lots of std::find(std::vector::begin(),std::vector::end(),T), causing quadratic costs in multiple places. 2018-06-21 15:46:59 +02:00
csoler
3981bc8e3b
extended notification system to add distant search result notification 2018-06-21 13:48:57 +02:00
csoler
5cb48c27de
renamed a few constants of GXS notify system into more consistent values 2018-06-21 09:26:03 +02:00
G10h4ck
9090205747
Merge pull request #1284 from G10h4ck/improve_build
Improve build and Windows Continuos Integration
2018-06-19 11:53:07 +02:00
csoler
79e676edbe
fixed re-load of GXS groups (forums/channels) when the read flag is changed 2018-06-18 22:27:05 +02:00
csoler
c67084b7de
fixed mutex problem in turtle-GXS search 2018-06-17 21:23:16 +02:00
csoler
84194b6234
sereral fixes to GXS distant search 2018-06-16 22:39:35 +02:00
csoler
7a135c5c43
added quick and dirty turtle search for channels in Files search tab 2018-06-13 22:46:27 +02:00
csoler
be1e127a93
added test search functions in rsgxsnetservice 2018-06-11 22:00:03 +02:00
Gioacchino Mazzurco
1f76108a9e
Remove some cruft from build files 2018-06-11 14:21:28 +02:00
csoler
6fb459ce64
added logic for GXS search in RsGxsNetTunnel and Gxs client net service 2018-06-10 22:34:17 +02:00
Gioacchino Mazzurco
6010104127
Merge commit '9886840b79d617a32764ad52ef4747f5fd999250' 2018-06-09 18:10:22 +02:00
Gioacchino Mazzurco
9886840b79
Provide proper constructor for SerializeContext
Deprecate constructor that depends on deprecated declarations.
2018-06-09 17:59:11 +02:00
Gioacchino Mazzurco
1825b263f0
ChunkMap::reAskPendingChunk fix unused parameter warning 2018-06-09 17:21:59 +02:00
cyril soler
8edb1f7535 fixed problem causing infinite loop of net reset in p3NetMgr 2018-06-08 14:32:56 +02:00
G10h4ck
f3b0f7af1f
Merge pull request #1280 from G10h4ck/channels_apiv2_improvements
Channels apiv2 improvements
2018-06-07 17:53:42 +02:00
G10h4ck
e5c72481ad
Merge pull request #1281 from G10h4ck/filesharing_apiv2_improvements
Extend a bit filesharing JSON API v2
2018-06-07 17:53:26 +02:00
Gioacchino Mazzurco
3eff851cdb
Improve deprecation of RS_TOKREQ_ANSTYPE_* 2018-06-07 14:57:31 +02:00
csoler
7caf06b57d
added structures for generic turtle search and access functions in Gxs objects 2018-06-06 23:15:29 +02:00
csoler
b5c1b8210b
added classes for both group data and group summary results in turtle search 2018-06-02 18:12:27 +02:00
csoler
90d7f55c40
finished implementing GXS search items 2018-05-31 15:41:54 +02:00
csoler
b0f391d66f
fixed compilation and re-licensed zeroconf/ 2018-05-30 21:45:18 +02:00
csoler
bc63726c4c
fixed compilation 2018-05-30 21:35:29 +02:00
csoler
8641da189c
relicensed util/ and moved rsaes to crypto/ 2018-05-30 21:34:38 +02:00
csoler
858dcfc14c
removed unused tempering in random number generator, added comments and license text 2018-05-30 21:19:53 +02:00
csoler
6cf2090149
relicensed tcponudp, turtle, unused, upnp, and part of util/ 2018-05-30 21:19:13 +02:00
csoler
b3853156ce
re-licensed services/ 2018-05-29 21:54:27 +02:00
csoler
70f09b654c
re-licensed serialiser/ 2018-05-29 21:27:12 +02:00
csoler
05e2f684a9
re-licensed rsitems and rsserver 2018-05-29 21:08:17 +02:00
csoler
ff8c37f169
fixed license in retroshare/ 2018-05-28 22:28:51 +02:00
csoler
b3277824eb
license fix in pqi 2018-05-28 22:03:39 +02:00
csoler
1fee544db7
re-licensed gxstrans, gxstunnel, pgp, plugins and half pqi 2018-05-26 14:45:43 +02:00
csoler
33fe823127
Merge pull request #1271 from sehraf/pr_compile-fix-unused-services
make wiki and photo services compile again
2018-05-26 11:22:47 +02:00
csoler
8a07f2c8c4
fixed wrong commit with copy-pasted code 2018-05-24 19:50:07 +02:00
csoler
d5627d4b22
fixed license in ft, grouter, and gxs 2018-05-22 22:03:11 +02:00
Gioacchino Mazzurco
1ad1fdc7be
p3NetMgrIMPL::checkNetAddress() notify if port change
Plus cleanups and proper sockaddr_storage copy
2018-05-22 19:17:37 +02:00
Gioacchino Mazzurco
0bf02e2bc3
pqissludp::Initiate_Connection() check remote_addr to be IPv4 before use 2018-05-22 19:14:25 +02:00
csoler
544b4af4c2
fixed license in chat, crypto, dht, file_sharing 2018-05-21 20:50:38 +02:00
csoler
50b360bf9d
added missing license to some libresapi files 2018-05-21 20:17:54 +02:00
sehraf
0c19a5640e
compile fix gxsphoto 2018-05-21 14:55:10 +02:00
sehraf
92b21d7332
compile fix wikipoos 2018-05-21 14:26:46 +02:00
Gioacchino Mazzurco
5a301734a9
Extend a bit filesharing JSON API v2 2018-05-17 16:46:34 +02:00
csoler
28981b6c86
Merge pull request #1251 from PhenomRetroShare/Fix_Cppcheck(duplInheritedMember)InRsItem
Fix CppCheck duplInheritedMember warning in RsItem
2018-05-16 13:37:02 +02:00
csoler
2145911ac4
Merge pull request #1262 from PhenomRetroShare/Fix_PartialDirCheck
Fix Partial Dir Check
2018-05-16 13:30:56 +02:00
csoler
3f88e3e901
added check to avoid hashing files that are currently being modified 2018-05-16 13:24:52 +02:00
csoler
8451550561
added missing licence to file_tree.h 2018-05-16 11:40:39 +02:00
csoler
291c86e2d0
Merge pull request #1265 from csoler/v0.6-GxsFix
fixed bug causing new forums and identities to not show up immediately
2018-05-16 11:17:22 +02:00
csoler
4661329bee
fixed bug causing new forums and identities to not show up immediately 2018-05-16 11:15:18 +02:00
G10h4ck
9f37b63e4d
Merge pull request #1264 from G10h4ck/channel_json_api_v2
Channel json api v2
2018-05-16 10:49:28 +02:00
Phenom
f12cd5774d Fix Partial Dir Check
Add WrongValue StyleSheet property, when bad directory selected.
Update QLineEdit with current setting so it's possible to see if
something is modified. No need to restart.
2018-05-12 14:31:28 +02:00
csoler
4d287d68bc
fixed weird mistake in grouter which causes an issue only in gcc > 8 2018-05-09 13:27:16 +02:00
Phenom
f39fd069b5 Fix CppCheck duplInheritedMember warning in RsItem
/libretroshare/src/rsitems/rsitem.h:92: warning:
Cppcheck(duplInheritedMember): The class 'RsPeerNetItem' defines member
variable with name 'peerId' also defined in its parent struct 'RsItem'.
/libretroshare/src/rsitems/rsitem.h:92: warning:
Cppcheck(duplInheritedMember): The class 'RsHistoryMsgItem' defines
member variable with name 'peerId' also defined in its parent struct
'RsItem'.
/libretroshare/src/rsitems/rsitem.h:91: warning:
Cppcheck(duplInheritedMember): The class 'RsBanListConfigItem' defines
member variable with name 'type' also defined in its parent struct
'RsItem'.
/libretroshare/src/rsitems/rsitem.h:92: warning:
Cppcheck(duplInheritedMember): The class 'RsBanListConfigItem' defines
member variable with name 'peerId' also defined in its parent struct
'RsItem'.
2018-05-07 17:29:11 +02:00
csoler
a6821f4ded
Merge pull request #1249 from sehraf/pr_libsecret
Add support for libsecret (including KDE keyring) and fix retroshare-nogui autologin
2018-05-06 23:02:18 +02:00
Phenom
dca33daae8 Fix CppCheck in ftcontroller.cc
/libretroshare/src/ft/ftcontroller.cc:91: warning:
Cppcheck(passedByValue): Function parameter 'fname' should be passed by
reference.
/libretroshare/src/ft/ftcontroller.cc:92: warning:
Cppcheck(passedByValue): Function parameter 'tmppath' should be passed
by reference.
/libretroshare/src/ft/ftcontroller.cc:92: warning:
Cppcheck(passedByValue): Function parameter 'dest' should be passed by
reference.
/libretroshare/src/ft/ftcontroller.cc:1482: warning:
Cppcheck(stlIfStrFind): Inefficient usage of string::find() in
condition; string::compare() would be faster.
/libretroshare/src/ft/ftcontroller.cc:1491: warning:
Cppcheck(stlIfStrFind): Inefficient usage of string::find() in
condition; string::compare() would be faster.
2018-05-06 18:54:25 +02:00
csoler
e7182013bf
added items for generic search result items for GXS 2018-05-05 18:41:41 +02:00
csoler
0ada4d4895
improved GxsNetTunnel comment section 2018-05-05 18:08:27 +02:00
sehraf
1129bcb0c0
Add support for libsecret 2018-05-04 20:47:41 +02:00
csoler
8d5c013a17
added proper synchronization of GxsIds through tunnels of another service 2018-05-03 23:21:59 +02:00
csoler
8e111c2ee2
added rapidjson-1.1.0 code hard-coded in the source directory to allow everyone to compile without the need to tweak too much. When v1.1.0 is mainstream (espcially on ubuntu) we can revert back to an external dependency 2018-05-02 22:46:27 +02:00
csoler
4d6fed643a
reverted to single GxsTunnelService shared for all services 2018-05-01 20:10:56 +02:00
csoler
ba0819f8d0
added additional debug info to test proper distant request of GXS ids 2018-05-01 15:17:41 +02:00
csoler
c5ba0e975f
fixed TS in tunnel management 2018-04-29 19:20:14 +02:00
csoler
9973978350
improved management of tunnels and virtual peers 2018-04-29 16:19:45 +02:00
Gioacchino Mazzurco
be75e89ad2
Fix compialtion after merge 2018-04-27 20:55:38 +02:00
Gioacchino Mazzurco
f3ae61b462
Merge branch 'json_experiments' 2018-04-27 18:17:09 +02:00
csoler
5be57046f1
added load/save of random bias in GxsNetTunnel service 2018-04-27 00:00:29 +02:00
Gioacchino Mazzurco
f4e110ed0e
p3Banlist fail gracefully if IPv6 address get into
Translate IPv4 mapped to plain IPv4 before processing
Fail gracefully if the address is IPv6
2018-04-26 11:04:05 +02:00
csoler
57bb31ece6
added new checks in canSend and canRecv Msg/Grp to work with distant peers 2018-04-25 18:52:07 +02:00
csoler
da4b382ede
removed dependency on service in RsGxsNetTunnel 2018-04-25 18:29:49 +02:00
csoler
1a9a7622a2
made GxsNetTunnelService a parent class of GxsNetService and renamed public methods appropriately. 2018-04-25 17:58:37 +02:00
csoler
38b39caf13
added compilation flag for GXS dist sync 2018-04-25 14:58:53 +02:00
G10h4ck
82eb42ad8a
Merge pull request #1235 from G10h4ck/build_improvements
Build improvements
2018-04-23 12:04:35 +02:00
csoler
63359e0801
using additional const ref in rsexpr.h 2018-04-22 17:14:08 +02:00
csoler
c599b5a627
removed debug output in pqissl and pqissllistenner 2018-04-22 17:13:25 +02:00
Gioacchino Mazzurco
4876a0ea3b
Multiple improvements to build process
Restructure and document retroshare.pri variables and helper functions
Link sqlite statically like other libraries on Android
qmake has multiple win32-* specs match them correctly
Move a buch of generic thing to retroshare.pri instead of having them replocated
  accross project specific .pro
Fix retroshare-gui too many symbols exported on windows liking error by adding
  QMAKE_LFLAGS+=-Wl,--exclude-libs,ALL
Rename retroshare-gui/src/util/win32.h because the name is too prone to
  confusion and build conflicts
libreasapi avoid usage of cretar_prl link_prl that seems unreliable on some
  platforms
libreasapi rename LIBRESAPI_QT to more understendable LIBRESAPI_SETTINGS
Use use_*.pri instead of copy pasting error prone qmake snippets around
Expose bitdht option to retroshare.pri
Add RS_THREAD_LIB qmake variable for better crossplatform support
Move debug and profiling generic options to retroshare.pri (avoid copy/pasting)
Remove Qt script module in qmake as it is not available anymore
2018-04-18 07:56:43 +02:00
Gioacchino Mazzurco
f20705b36d
Workaround for systems that miss IPV6_V6ONLY
This should improve compatibility with old systems that miss
IPV6_V6ONLY and in particular for Windows XP
2018-04-15 12:32:39 +02:00
csoler
3c9af3d2e7
fixed bug in tunnel monitoring code 2018-04-14 11:48:55 +02:00
csoler
66df281f25
added asymmetry in GXS tunnel management to reduce the number of tunnels 2018-04-11 23:14:10 +02:00
Pooh
732e87a8bb
Merge branch 'master' into logshutup1 2018-04-09 11:15:43 +03:00
Gioacchino Mazzurco
c19919962d
pqissl silence extra debug message 2018-04-08 12:37:41 +02:00
csoler
27824943ff
removed debug info 2018-04-07 14:29:23 +02:00
csoler
e2b0e27205
fixed costly polling in RsGenExchange 2018-04-07 14:12:44 +02:00
Gioacchino Mazzurco
cc091cc2c8
Fixed hidden nodes listening failure
In case of hidden node the listen address was not properly converted to
  ipv4 mapped format causing bind to fail
Use sockaddr_storage_copy instead of = as sockaddr_storage is not
  guaranted to be copyable
2018-04-07 12:48:01 +02:00
csoler
393ff75c90
fixed polling strategy in RsGxsNetService causing some delay in distant post syncing 2018-04-07 00:56:44 +02:00
csoler
c0570ffef6
fixed costly polling in RsGenExchange 2018-04-07 00:56:07 +02:00
csoler
2b9139bf85
improved GXS dist sync item handling 2018-04-06 15:26:54 +02:00
csoler
7d561bcceb
added distant data access in GxsNetService 2018-04-04 21:41:21 +02:00
csoler
8fe3eb711d
fixed a few bugs in GXS dist sync tunneling 2018-04-02 17:07:32 +02:00
csoler
aa59694d88
added automatic detection for need to dist-sync groups 2018-04-01 22:04:16 +02:00
Pooh
c0834cf232
Merge branch 'master' into logshutup1 2018-04-01 17:40:44 +03:00
RetroPooh
0a943ea9ee log shut up 2018-04-01 17:30:36 +03:00
csoler
f0f69b8dd9
shared virtual peers across services 2018-03-29 16:26:36 +02:00
csoler
73b04f3109
finished implementation of GxsNetTunnel service 2018-03-29 10:54:58 +02:00
Gioacchino Mazzurco
8d1f1da242
Extend libresapi with minimal support for channels
The code is not elegant as this version of the API will be soon obsolete
  but it offer a bunch of channels functionalities, comments and votes
  are not implemented yet

/channels/list_channels get all visibile channels
/channels/get_channel get content of a subscribed channel
/channels/toggle_subscribe subscribe/unsubscribe to a channel
/channels/toggle_auto_download set/unset auto-download for files attached
  to posts in a channel
/channels/toggle_read mark a post as read
/channels/create_channel create a new channel
/channels/create_post create a new post in given channel, group_id
  paramenter renamed to channel_id for consistence

mChannels use reference instead of pointer as it must be valid
  for the whole lifetime of the object
RsGxsCommentService and derivatives use proper types for parameter, avoid
  reference when unneeded
2018-03-28 16:41:05 +02:00
csoler
73c6deebf4
Merge pull request #1191 from G10h4ck/IPv6-v3
IPv6 support
2018-03-27 20:54:31 +02:00
csoler
b488760d7d
fixed data incoming/outgoing in GxsNetTunnel 2018-03-26 23:19:29 +02:00
csoler
5566d90f32
finished tunnel handling and data send/recv in GxsNetTunnel 2018-03-24 16:42:16 +01:00
csoler
2255bda007
improved documentation of TurtleClientService class with doxygen type 2018-03-24 16:41:51 +01:00
csoler
58aa2413b3
finished moving tunnel encryption into turtle 2018-03-23 22:46:04 +01:00
csoler
00a6bd5b73
started to move FT encryption into p3turtle 2018-03-22 14:41:50 +01:00
csoler
3407604a54
added code to add/remove virtual peers in RsGxsNetTunnel 2018-03-21 22:09:40 +01:00
csoler
076309133b
basic structure of GxsNetTunnelService 2018-03-15 17:46:21 +01:00
csoler
e1ad21c357
fixed wrong file count in RsCollectionDialog when downloading files 2018-03-15 13:11:19 +01:00
csoler
b3653d1283
enabled aggressive re-request of pending slices at end of transfer, thus fixing the long delay to finish files with mixed fast/slow sources 2018-03-15 11:32:55 +01:00
csoler
04dc764339
merged upstream/master 2018-03-15 09:19:56 +01:00
Gioacchino Mazzurco
9fbf56e592
Remove outdated misleading comment 2018-03-03 01:55:49 +01:00
Gioacchino Mazzurco
234daffec7
Merge branch 'IPv6-v3' into extra_locators 2018-03-03 01:43:00 +01:00
Gioacchino Mazzurco
52ef72d761
Fix p3PeerMgrIMPL::UpdateOwnAddress local address
Due to a regression introduced in
dedfcb2b60 the local address was not
updated correctly causing part of RS networking being stuck and printing
lot of invalid sockaddr_storage messages, this commit fix the regression
2018-03-03 01:39:50 +01:00
Gioacchino Mazzurco
bed856425f
Share additional addresses via RsCertificate 2018-03-03 00:08:56 +01:00
Gioacchino Mazzurco
8542abd4f0
Few fixes in RsUrl 2018-03-02 20:08:50 +01:00
Gioacchino Mazzurco
518df99243
Merge branch 'master' into extra_locators 2018-03-02 19:31:37 +01:00
Gioacchino Mazzurco
923c383a13
Add naif URL manipulation class RsUrl
Use RsUrl to convert sockaddre_storage from/to string
2018-03-02 19:20:56 +01:00
csoler
026951ff2c
added consistency check in getGroupMeta so that ADMIN/PUBLISH flags always correspond to what the key set reflects 2018-03-01 11:45:54 +01:00
Gioacchino Mazzurco
dedfcb2b60
More ipv6 to ipv4 conversion around
More safe sockaddr_storage copy
2018-03-01 10:12:15 +01:00
csoler
5d5894352d
forced notification of type RECEIVE when creating a new group so that the GxsIFaceHelper updates the group list 2018-02-28 23:18:50 +01:00
csoler
29ab0e9913
fixed bug that would erase private publish key when a group update is received 2018-02-28 22:40:04 +01:00
csoler
165b241341
made add of publish key a meta group change, to force reload the list of groups 2018-02-27 23:19:27 +01:00
csoler
3bc5b456a5
added a FeedItem to warn when publish permissions are received for a channel 2018-02-27 22:42:48 +01:00
csoler
aad9397ef8
fixed memory leak in p3GxsTunnel 2018-02-26 23:38:13 +01:00
Gioacchino Mazzurco
7d765ec04e
pqissl::Initiate_Connection remove duplicated code 2018-02-26 16:30:27 +01:00
Gioacchino Mazzurco
f4a6090150
More ipv6_to_ipv4 conversions 2018-02-26 16:28:36 +01:00
Gioacchino Mazzurco
ac8b56951c
Enforce main IPv4 usage for better retrocompatibility 2018-02-26 08:49:06 +01:00
csoler
dd9f67a28b
fixed version number problem 2018-02-25 17:53:42 +01:00
Gioacchino Mazzurco
f5160338ed
sockaddr_storage_familytostring be quite if not debugging 2018-02-25 13:18:34 +01:00
Gioacchino Mazzurco
9281a5966b
p3Peers::getPeerDetails retrocompatible IPv4 format 2018-02-25 12:48:55 +01:00
Gioacchino Mazzurco
9a446fc1ff
Fix compilation for Android 2018-02-25 11:28:26 +01:00
csoler
681f543184
Merge pull request #1183 from csoler/v0.6.4
switched version to 0.6.4
2018-02-24 22:04:26 +01:00
csoler
39e70ed8bf
ignore unknown ptags in certificates instead of causing an error, for future backward compatibility 2018-02-24 21:51:18 +01:00
Gioacchino Mazzurco
4a138e07b9
Implement IPv6 listening
With this commit IPv6-v3 surpass v0.6-IPv6-2 in term of features
  obsoleting it.
p3BitDht handle gracefully unwanted non IPv4 addresses
rsUdpStack handle gracefully unwanted non IPv4 addresses
pqissludp handle gracefully unwanted non IPv4 addresses
Move single address limitation workaround from
  p3discovery2::sendOwnContactInfo to better
  place p3PeerMgrIMPL::UpdateOwnAddress this way local address list is
  queried less often and only id there is some suggestion that it may
  have changed (probably ir will not be called all the times there is a
  changes in local network interfaces but is good enough)
Implement crossplatform rs_setsockopt to avoid too much ifdef around
Implement sockaddr_storage_copy to safely copy sockaddr_storage objects
2018-02-24 17:14:49 +01:00
Gioacchino Mazzurco
b3c7d195c8
Port pqissl to dual stack IPv6+IPv4
Changed unix_connect signature to be more comfortable for dual stack
  usage
Remove dead code in pqissl::pqissl(...)
Adapt p3I2pBob::connectI2P() to new unix_connect
Adapt extaddrfinder to new unix_connect
Add sockaddr_storage_ipv4_to_ipv6 to convert from flat IPv4 to IPv4
  mapped as IPv6
2018-02-24 14:29:56 +01:00
Gioacchino Mazzurco
2170313e42
Improve discovery
Workaround RS single local address flawed assumption by spreading
  all viables local addrresses via discovery
Spread addresses also through hidden node as they are the only hope
  to help direct connection happening for common trusted nodes
  behind nasty firewalls
2018-02-24 14:29:56 +01:00
csoler
13441ff483
removed debug info in rsgenexchange.cc 2018-02-23 15:13:13 +01:00
csoler
d8e950c5e0
removed debug output from rsdataservice 2018-02-23 14:28:22 +01:00
csoler
ff7633fefe
Merge pull request #1184 from G10h4ck/linkLocalFallback
[0.6.4] Use link local address only if necessary fix #292
2018-02-23 14:00:39 +01:00
Gioacchino Mazzurco
8d5cd8afef
Increase size of list of ip shared via discovery2 2018-02-23 02:10:58 +01:00
Gioacchino Mazzurco
9dd1aef2b7
Discovery do not distribute addresses to hidden nodes
As there is no consensus in takde advantage of hidden nodes for
  discovery do not spread ip address to them
2018-02-23 02:10:58 +01:00
Gioacchino Mazzurco
e7facc122b
Prevent discovery to share local addresses if hidden
Do not query/share local addresses if hidden node as it would leak
  information about the location of the node
2018-02-23 02:10:58 +01:00
Gioacchino Mazzurco
4fa6bdc789
Improve discovery
Workaround RS single local address flawed assumption by spreading
  all viables local addrresses via discovery
Spread addresses also through hidden node as they are the only hope
  to help direct connection happening for common trusted nodes
  behind nasty firewalls
2018-02-23 02:10:58 +01:00
Gioacchino Mazzurco
2044a2c848
Use retrocompatible iterators
Explain why shuffling the local addresses list before looking for
 a viable local is a bad idea.
2018-02-21 12:35:27 +01:00
Phenom
73d11e1857
Fix Gcc Warning in nxsmsgsync_test.cc
/trunk/tests/unittests/libretroshare/gxs/nxs_test/nxsmsgsync_test.cc:28:
warning: deleting object of abstract class type ‘RsGixsReputation’ which
has non-virtual destructor will cause undefined behavior [-Wdelete-non-
virtual-dtor]
  delete mRep ;
/trunk/tests/unittests/libretroshare/gxs/nxs_test/nxsmsgsync_test.cc:29:
warning: deleting object of abstract class type ‘RsGcxs’ which has non-
virtual destructor will cause undefined behavior [-Wdelete-non-virtual-
dtor]
  delete mCircles;
/trunk/tests/unittests/libretroshare/gxs/nxs_test/nxsmsgsync_test.cc:30:
warning: deleting object of abstract class type ‘PgpAuxUtils’ which has
non-virtual destructor will cause undefined behavior [-Wdelete-non-
virtual-dtor]
  delete mPgpUtils;
2018-02-20 23:28:48 +01:00
Gioacchino Mazzurco
0c99975800
Use link local address only if necessary
This should solve APIPA address being always selected as preferred local
address on Windows which was causing problems connecting to machines on
the same local network.
Now the link local address is used as fallback only if there is non link
local private address available.
2018-02-19 23:23:15 +01:00
csoler
566776366f
switched version to 0.6.4 2018-02-19 21:49:06 +01:00
csoler
2511934fb0
Merge pull request #1177 from csoler/v0.6-FT
added limiter in number of responses forwarded back by turtle search,…
2018-02-18 17:58:06 +01:00
csoler
7a844921ad
Merge pull request #1176 from csoler/v0.6-SecurityFixes
added load/save of known forums to avoid re-displaying it in the News…
2018-02-18 17:57:42 +01:00
csoler
6fe14136ae
added limiter in number of responses forwarded back by turtle search, which should avoid bursts of bandwidth for popular requests 2018-02-17 23:37:25 +01:00
csoler
8708dd9b94
fixed bug due to wrong service ID in serializer 2018-02-17 12:04:13 +01:00
csoler
d57f933109
added load/save of known channels to avoid re-displaying it in the NewsFeed after then have been deleted. 2018-02-16 23:51:43 +01:00
csoler
252626f5ec
added load/save of known forums to avoid re-displaying it in the NewsFeed after then have been deleted. 2018-02-16 23:24:01 +01:00
Phenom
83b6205af3 Fix New Chat Invite 2018-02-16 10:22:59 +01:00
csoler
0491e43118
Merge pull request #1169 from csoler/v0.6-FT
V0.6 ft
2018-02-11 21:28:43 +01:00
csoler
7a2d874863
Merge pull request #1153 from csoler/v0.6-TorOnly
V0.6 tor only
2018-02-11 20:49:45 +01:00
csoler
74a6076f18 added sources in new QModel. Unfinished yet. 2018-02-07 00:25:41 +01:00
csoler
3f8ff6489b first attempt at creating a display model for transfers. Not finished yet. 2018-02-04 22:56:13 +01:00
Gioacchino Mazzurco
00125864ff Add support for SQLCipher on Android
Plus some cleanup
2018-01-30 18:24:03 +01:00
Gioacchino Mazzurco
ebfe50f814 Make .pro files compiler agnostic on Android 2018-01-30 18:11:31 +01:00
Gioacchino Mazzurco
fa71ed25ba Install bdboot.txt in Android
DHT now works on android as bdboot.txt is bundled as android asset
Update Android documentation as DHT works on Android after this commit
2018-01-29 16:14:14 +01:00
csoler
8f7582588a fixed windows compilation 2018-01-27 20:59:11 +01:00
csoler
d0039241d3 replaced usleep() by rstime::rs_usleep() which accepts times >= 1 sec. Should fix problems on windows 2018-01-27 20:22:31 +01:00
Gioacchino Mazzurco
86ce177228 time_t may be signed in JSON 2018-01-27 19:57:15 +01:00
Gioacchino Mazzurco
ef6681b6f9 Remove outdated documentation 2018-01-27 19:40:39 +01:00
Gioacchino Mazzurco
8b774595d7 Better usage of type traits
Don't need register types for serializationanymore
Don't need casting helpers for serialization
2018-01-27 17:57:33 +01:00
Gioacchino Mazzurco
ba6f2d7e81 Remove default template for to/from_JSON
This way the compiler will complain if a type is added directly to
RsTypeSerializer without specify all needed serial operations
2018-01-26 17:18:05 +01:00
Gioacchino Mazzurco
13d4a2c916 Safer and elgant serial helper macros 2018-01-26 13:43:09 +01:00
csoler
725abad777 fixed a bug in filterItems that caused searched files to generate an error in the console 2018-01-23 22:18:02 +01:00
Gioacchino Mazzurco
7409de5170 Fix compilation on systems with atipic time_t 2018-01-22 21:53:12 +01:00
Gioacchino Mazzurco
443ffb9f85 Fix some warnings 2018-01-22 15:02:33 +01:00
Gioacchino Mazzurco
9c68bcbca4 Fix some warnings 2018-01-22 14:50:07 +01:00
Gioacchino Mazzurco
04d32d2f44 Remove duplicated include 2018-01-22 12:55:22 +01:00
Gioacchino Mazzurco
b95e3380c0 Fix Android compilation 2018-01-22 11:09:00 +01:00
Gioacchino Mazzurco
9d40d416f6 Better naming for serialization helper macro 2018-01-21 20:27:49 +01:00
csoler
95e8fc4404 merged upstream/master 2018-01-16 23:03:26 +01:00
Gioacchino Mazzurco
5cdc5aa58d Add automatic JSON serialization/deserialization
Abstract serialization concept to pure virtaul class RsSerializable
  from which every other serializable class must inherit from
Use RapidJSON for JSON manipulation
Add TO_JSON and FROM_JSON SerializeJob
Deprecate unused SerializationFormat
Remove some unused old piece of code
Adjust many lines to max 80 columns for better readability on little
  screens
Clean up documentation and code, remove old cruft
Add copyright notice on edited files that miss it
2018-01-16 03:31:03 +01:00
csoler
4c626e04a1
Merge pull request #1152 from csoler/v0.6-SecurityFixes
fixed possible crash due to accessing deleted memory in database cach…
2018-01-15 23:17:09 +01:00
csoler
841fee6799 fixed possible crash due to accessing deleted memory in database cache access 2018-01-15 23:13:42 +01:00
csoler
7cac367820 removed warnign about bad service string when the service string is actually empty 2018-01-14 22:39:50 +01:00
csoler
4eea5a8eca removed consts in GrpMetaCache pointers, and made it possible to always re=use cache entries, possibly updating them 2018-01-10 00:10:08 +01:00
csoler
506190a64b fixed bug causing failure of flag actions on groups 2018-01-09 22:11:11 +01:00
csoler
ed81b4cac6 removed delete causing read of deleted memory 2018-01-09 21:49:15 +01:00
csoler
89c538deb1 fixed double deletion problem causing crashes 2018-01-07 22:36:38 +01:00
csoler
b42b8e3a51 moved memory ownership of RsGxsGrpMetaData down into RsGxsDataAccess. Avoids many copy-constructors of RsTlvSecurityKey. Will probably spare a lot of CPU on windows 2018-01-07 21:41:41 +01:00
csoler
e28886fe79 updated to upstream/master 2018-01-05 21:59:22 +01:00
csoler
ab60f49820 prevent sending/receiving of IP addresses to/at hidden nodes 2018-01-03 18:37:43 +01:00
csoler
0f6006d140 prevent subscribing to a signed chat room without a signed identity 2018-01-03 15:01:04 +01:00
csoler
fcc3995d87 removed BanList service from Retro-Tor version 2018-01-01 15:49:49 +01:00
csoler
da5253059a fixed retrotor compilation when removing dht and udp 2017-12-31 17:27:21 +01:00
csoler
122f6af30a fixed compilation on ubuntu precise 2017-12-24 11:06:03 +01:00
csoler
f5ce711ad6 only load hidden nodes in retro-only mode 2017-12-21 21:34:51 +01:00
csoler
76ec079b40 added missing change in .pro 2017-12-20 22:14:58 +01:00
csoler
a173f325a9 added .h for RsGxsNetTunnel service 2017-12-20 00:09:34 +01:00
csoler
99e35b131c rename file in partials into real name before moving it; check for destination directory before moving file 2017-12-16 15:04:16 +01:00
csoler
b12f9323dc added some text to describe the protocol for GXS distant sync 2017-12-10 15:57:01 +01:00
csoler
63b3acb95a
Merge pull request #1113 from csoler/v0.6-SSL110Fix
added sha256 calculation functions, and non backward compatible SSL I…
2017-11-23 21:27:03 +01:00
csoler
1faa274e07 simplified memory management in certificate signature verification code 2017-11-22 23:46:57 +01:00
csoler
669f2ba7ba fixed a few bugs in signature verification code accross versions 2017-11-22 22:56:40 +01:00
csoler
f6d69e09d5 ensured maximum backward compatibility for crypto changes that will occur in future v0.7 2017-11-22 00:02:11 +01:00
Gioacchino Mazzurco
6d4c9422d9 Removed unnecessary executable flag on some files 2017-11-21 13:28:24 +01:00
csoler
e2c1661c49 fixed compilation with v0.7 defines 2017-11-20 22:44:34 +01:00
csoler
cd51afbc70 fixed small bug in signature and compilation 2017-11-20 22:26:14 +01:00
csoler
9367aa0d84 changed #ifs into #ifdefs because it us more robust, and moved the definition of variables to retroshare.pri 2017-11-19 20:15:36 +01:00
csoler
ef1a61374c added proper debug output for signature verification 2017-11-19 19:57:38 +01:00
csoler
863e6256c3 centralized the defines into a single file 2017-11-19 19:34:54 +01:00
csoler
e72bd9ff4f fixed bug causing certificate rejection 2017-11-19 18:38:46 +01:00
csoler
b4fdd4e0d0 added two additional non packward compatible changes for future version 0.7, and improvements of verifications of certificate signatures 2017-11-19 18:21:56 +01:00
csoler
7472f78223 added sha256 calculation functions, and non backward compatible SSL Id computation code to active later (0.7) 2017-11-15 23:24:43 +01:00
csoler
ba7cf4995b
Merge pull request #1037 from RetroPooh/searchspy
Searchspy
2017-11-14 20:53:24 +01:00
RetroPooh
919d6503d7 in search strings change comma to space for better look 2017-11-14 16:09:05 +03:00
Pooh
9aa6dd3f64
Update rsturtleitem.h 2017-11-14 14:34:22 +03:00
csoler
5fab053fb8 added toStdString() method to search strings so as to display what is searched 2017-11-13 23:37:53 +01:00
Phenom
72b917de37 Fix CppCheck in UPnPBase.h
/libretroshare/src/upnp/UPnPBase.cpp:62: warning:
Cppcheck(funcArgOrderDifferent): Function 'CUPnPPortMapping' argument
order different: declaration 'in_port, ex_port, protocol, enabled,
description' definition 'ex_port, in_port, protocol, enabled,
description'
/libretroshare/src/upnp/UPnPBase.h:109: warning:
Cppcheck(noExplicitConstructor): Class 'CUPnPLib' has a constructor with
1 argument that is not explicit.
/libretroshare/src/upnp/UPnPBase.h:577: warning:
Cppcheck(noExplicitConstructor): Class 'CUPnPControlPoint' has a
constructor with 1 argument that is not explicit.
2017-11-07 22:04:46 +01:00
Phenom
2933861691 Fix CppCheck in p3turtle.cc
/libretroshare/src/turtle/p3turtle.cc:1450: warning:
Cppcheck(unusedVariable): Unused variable: info
/libretroshare/src/turtle/p3turtle.cc:1875: warning:
Cppcheck(redundantIfRemove): Redundant checking of STL container element
existence before removing it.
2017-11-07 22:04:10 +01:00
Phenom
2728880621 Fix CppCheck in p3postbase.cc
/libretroshare/src/services/p3postbase.cc:628: warning:
Cppcheck(invalidScanfArgType_int): %d in format string (no. 1) requires
'int *' but the argument type is 'unsigned int *'.
/libretroshare/src/services/p3postbase.cc:628: warning:
Cppcheck(invalidScanfArgType_int): %d in format string (no. 2) requires
'int *' but the argument type is 'unsigned int *'.
/libretroshare/src/services/p3postbase.cc:628: warning:
Cppcheck(invalidScanfArgType_int): %d in format string (no. 3) requires
'int *' but the argument type is 'unsigned int *'.
2017-11-07 21:59:58 +01:00
Phenom
d0eb40b08c Fix CppCheck in p3discovery2.cc
/libretroshare/src/services/p3discovery2.cc:916: warning:
Cppcheck(unreadVariable): Variable 'sit' is assigned a value that is
never used.
2017-11-07 21:59:34 +01:00
Phenom
7278f67073 Fix CppCheck in p3bwctrl.h
/libretroshare/src/services/p3bwctrl.h:77: warning:
Cppcheck(noExplicitConstructor): Class 'p3BandwidthControl' has a
constructor with 1 argument that is not explicit.
2017-11-07 21:59:04 +01:00
Phenom
9000f2e524 Fix CppCheck in p3i2pbob.h
/libretroshare/src/services/autoproxy/p3i2pbob.h:176: warning:
Cppcheck(noExplicitConstructor): Class 'p3I2pBob' has a constructor with
1 argument that is not explicit.
2017-11-07 21:58:30 +01:00
Phenom
fea9c0a851 Fix CppCheck in rstlvstring.h
/libretroshare/src/serialiser/rstlvstring.h:40: warning:
Cppcheck(noExplicitConstructor): Class 'RsTlvStringSet' has a
constructor with 1 argument that is not explicit.
2017-11-07 21:58:10 +01:00
Phenom
889f23f9d8 Fix CppCheck in rstlvidset.h
/libretroshare/src/serialiser/rstlvidset.h:93: warning:
Cppcheck(unreadVariable): Variable 'ok' is assigned a value that is
never used.
2017-11-07 21:57:39 +01:00
Phenom
371d8205d5 Fix CppCheck in rsinit.cc
/libretroshare/src/rsserver/rsinit.cc:1051: warning:
Cppcheck(unreadVariable): Variable 'mDhtStack' is assigned a value that
is never used.
2017-11-07 21:47:05 +01:00
Phenom
04125be8b1 Fix CppCheck in rsaccounts.cc
/libretroshare/src/rsserver/rsaccounts.cc:808: warning:
Cppcheck(ConfigurationNotChecked): Skipping configuration 'DATA_DIR'
since the value of 'DATA_DIR' is unknown. Use -D if you want to check
it. You can use -U to skip it explicitly.
/libretroshare/src/rsserver/rsaccounts.cc:1057: warning:
Cppcheck(redundantAssignment): Variable 'bio_out' is reassigned a value
before the old one has been used.
/libretroshare/src/rsserver/rsaccounts.cc:674: warning:
Cppcheck(unusedVariable): Unused variable: userName
/libretroshare/src/rsserver/rsaccounts.cc:1005: warning:
Cppcheck(unreadVariable): Variable 'pgp_name' is assigned a value that
is never used.
/libretroshare/src/rsserver/rsaccounts.cc:663: warning:
Cppcheck(passedByValue): Function parameter 'accountdir' should be
passed by reference.
2017-11-07 21:46:01 +01:00
Phenom
da190f544e Fix CppCheck in p3Status
/libretroshare/src/rsserver/p3status.h:42: warning:
Cppcheck(noExplicitConstructor): Class 'p3Status' has a constructor with
1 argument that is not explicit.
2017-11-07 21:44:48 +01:00
Phenom
628a23ae94 Fix CppCheck in rspluginitems.h
/libretroshare/src/rsitems/rspluginitems.h:39: warning:
Cppcheck(noExplicitConstructor): Class 'RsPluginItem' has a constructor
with 1 argument that is not explicit.
2017-11-07 21:44:17 +01:00
Phenom
7db813defc Fix CppCheck in rsnxsitems.h
/libretroshare/src/rsitems/rsnxsitems.h:117: warning:
Cppcheck(uninitMemberVar): Member variable
'RsNxsSyncGrpStatsItem::request_type' is not initialized in the
constructor.
/libretroshare/src/rsitems/rsnxsitems.h:117: warning:
Cppcheck(uninitMemberVar): Member variable
'RsNxsSyncGrpStatsItem::number_of_posts' is not initialized in the
constructor.
/libretroshare/src/rsitems/rsnxsitems.h:117: warning:
Cppcheck(uninitMemberVar): Member variable
'RsNxsSyncGrpStatsItem::last_post_TS' is not initialized in the
constructor.
/libretroshare/src/rsitems/rsnxsitems.h:371: warning:
Cppcheck(uninitMemberVar): Member variable 'RsNxsMsg::pos' is not
initialized in the constructor.
/libretroshare/src/rsitems/rsnxsitems.h:371: warning:
Cppcheck(uninitMemberVar): Member variable 'RsNxsMsg::count' is not
initialized in the constructor.
/libretroshare/src/rsitems/rsnxsitems.h:410: warning:
Cppcheck(uninitMemberVar): Member variable 'RsNxsSearchReqItem::nHops'
is not initialized in the constructor.
/libretroshare/src/rsitems/rsnxsitems.h:410: warning:
Cppcheck(uninitMemberVar): Member variable 'RsNxsSearchReqItem::token'
is not initialized in the constructor.
/libretroshare/src/rsitems/rsnxsitems.h:410: warning:
Cppcheck(uninitMemberVar): Member variable
'RsNxsSearchReqItem::expiration' is not initialized in the constructor.
/libretroshare/src/rsitems/rsnxsitems.h:431: warning:
Cppcheck(uninitMemberVar): Member variable
'RsNxsSearchResultMsgItem::token' is not initialized in the constructor.
/libretroshare/src/rsitems/rsnxsitems.h:431: warning:
Cppcheck(uninitMemberVar): Member variable
'RsNxsSearchResultMsgItem::expiration' is not initialized in the
constructor.
/libretroshare/src/rsitems/rsnxsitems.h:99: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSyncGrpReqItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:117: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSyncGrpStatsItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:140: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsGroupPublishKeyItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:183: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsTransacItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:211: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSyncGrpItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:257: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsEncryptedDataItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:283: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsGrp' has a constructor with
1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:327: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSyncMsgReqItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:351: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSyncMsgItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:371: warning:
Cppcheck(noExplicitConstructor): Struct 'RsNxsMsg' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:410: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSearchReqItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:500: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSerialiser' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:237: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSessionKeyItem' has a
constructor with 1 argument that is not explicit.
2017-11-07 21:43:51 +01:00
Phenom
f82ec64d29 Fix CppCheck in rsrttitems.h
/libretroshare/src/rsitems/rsrttitems.h:56: warning:
Cppcheck(uninitMemberVar): Member variable 'RsRttPingItem::mSeqNo' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsrttitems.h:56: warning:
Cppcheck(uninitMemberVar): Member variable 'RsRttPingItem::mPingTS' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsrttitems.h:70: warning:
Cppcheck(uninitMemberVar): Member variable 'RsRttPongItem::mSeqNo' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsrttitems.h:70: warning:
Cppcheck(uninitMemberVar): Member variable 'RsRttPongItem::mPingTS' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsrttitems.h:70: warning:
Cppcheck(uninitMemberVar): Member variable 'RsRttPongItem::mPongTS' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsrttitems.h:46: warning:
Cppcheck(noExplicitConstructor): Class 'RsRttItem' has a constructor
with 1 argument that is not explicit.
2017-11-06 22:20:44 +01:00
Phenom
7e47be56ea Fix CppCheck rsitem.h
/libretroshare/src/rsitems/rsitem.h:15: warning:
Cppcheck(noExplicitConstructor): Class 'RsItem' has a constructor with 1
argument that is not explicit.
2017-11-06 22:20:44 +01:00
Phenom
478071304b Fix CppCheck in rsgxsrecognitems.h
/libretroshare/src/rsitems/rsgxsrecognitems.h:56: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognReqItem::issued_at' is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:56: warning:
Cppcheck(uninitMemberVar): Member variable 'RsGxsRecognReqItem::period'
is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:56: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognReqItem::tag_class' is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:56: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognReqItem::tag_type' is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:82: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognTagItem::valid_from' is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:82: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognTagItem::valid_to' is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:82: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognTagItem::tag_class' is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:82: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognTagItem::tag_type' is not initialized in the constructor.
2017-11-06 22:20:44 +01:00
Phenom
732898a76f Fix CppCheck in rsgxsupdateitems.h
/libretroshare/src/rsitems/rsgxsupdateitems.h:88: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsGrpConfigItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsgxsupdateitems.h:109: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsGrpUpdateItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsgxsupdateitems.h:131: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsServerGrpUpdateItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsgxsupdateitems.h:157: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsMsgUpdateItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsgxsupdateitems.h:179: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsServerMsgUpdateItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsgxsupdateitems.h:194: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsUpdateSerialiser' has a
constructor with 1 argument that is not explicit.
2017-11-06 22:20:44 +01:00
Phenom
942eba3d71 Fix CppCheck in rsconfigitems.h
/libretroshare/src/rsitems/rsconfigitems.h:74: warning:
Cppcheck(uninitMemberVar): Member variable 'RsPeerNetItem::netMode' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsconfigitems.h:74: warning:
Cppcheck(uninitMemberVar): Member variable 'RsPeerNetItem::vs_disc' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsconfigitems.h:74: warning:
Cppcheck(uninitMemberVar): Member variable 'RsPeerNetItem::vs_dht' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsconfigitems.h:74: warning:
Cppcheck(uninitMemberVar): Member variable 'RsPeerNetItem::lastContact'
is not initialized in the constructor.
/libretroshare/src/rsitems/rsconfigitems.h:74: warning:
Cppcheck(uninitMemberVar): Member variable 'RsPeerNetItem::domain_port'
is not initialized in the constructor.
/libretroshare/src/rsitems/rsconfigitems.h:146: warning:
Cppcheck(uninitMemberVar): Member variable 'RsNodeGroupItem::flag' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsconfigitems.h:243: warning:
Cppcheck(uninitMemberVar): Member variable 'RsFileConfigItem::flags' is
not initialized in the constructor.
2017-11-06 22:20:44 +01:00
Phenom
a1fb8f70b9 Fix CppCheck in rswire.h
/libretroshare/src/retroshare/rswire.h:111: warning:
Cppcheck(noExplicitConstructor): Class 'RsWire' has a constructor with 1
argument that is not explicit.
2017-11-06 22:20:44 +01:00
Phenom
a248ee7d41 Fix CppCheck in rsservicecontrol.h
/libretroshare/src/retroshare/rsservicecontrol.h:46: warning:
Cppcheck(passedByValue): Function parameter 'service_name' should be
passed by reference.
2017-11-06 22:20:44 +01:00
Phenom
1c862def6a Fix CppCheck in rsposted.h
/libretroshare/src/retroshare/rsposted.h:81: warning:
Cppcheck(noExplicitConstructor): Class 'RsPosted' has a constructor with
1 argument that is not explicit.
2017-11-06 22:20:44 +01:00
Phenom
ba75294258 Fix CppChecker in rsidentity.h
/libretroshare/src/retroshare/rsidentity.h:269: warning:
Cppcheck(noExplicitConstructor): Class 'RsIdentity' has a constructor
with 1 argument that is not explicit.
2017-11-06 22:20:44 +01:00
Phenom
fee7d454d9 Fix CppCheck in rsgxsforums.h
/libretroshare/src/retroshare/rsgxsforums.h:66: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsForums' has a constructor
with 1 argument that is not explicit.
2017-11-06 22:20:44 +01:00
Phenom
10c46ee35c Fix CppChecker in rsphoto.h
/libretroshare/src/retroshare/rsphoto.h:162: warning:
Cppcheck(noExplicitConstructor): Class 'RsPhotoComment' has a
constructor with 1 argument that is not explicit.
2017-11-06 22:20:44 +01:00
Phenom
dd4ed2a7f1 Fix CppCheck in rsgxschannels.h
/libretroshare/src/retroshare/rsgxschannels.h:82: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsChannels' has a constructor
with 1 argument that is not explicit.
2017-11-06 22:20:44 +01:00
Phenom
6219b3199b Fix CppCheck in pqiqos.h
/libretroshare/src/pqi/pqiqos.h:62: warning: Cppcheck(uninitMemberVar):
Member variable 'ItemQueue::_threshold' is not initialized in the
constructor.
/libretroshare/src/pqi/pqiqos.h:62: warning: Cppcheck(uninitMemberVar):
Member variable 'ItemQueue::_counter' is not initialized in the
constructor.
/libretroshare/src/pqi/pqiqos.h:62: warning: Cppcheck(uninitMemberVar):
Member variable 'ItemQueue::_inc' is not initialized in the constructor.
2017-11-06 22:20:44 +01:00
Phenom
87947b1f21 Fix CppCheck in pqiindic.h
/libretroshare/src/pqi/pqiindic.h:39: warning:
Cppcheck(noExplicitConstructor): Class 'Indicator' has a constructor
with 1 argument that is not explicit.
2017-11-06 22:20:44 +01:00
Phenom
20462496e9 Fix CppCheck in pqihandler.cc
/libretroshare/src/pqi/pqihandler.cc:200: warning:
Cppcheck(unusedVariable): Unused variable: it
2017-11-05 18:32:54 +01:00
Phenom
b77d027454 Fix CppCheck in p3linkmgr.cc
/libretroshare/src/pqi/p3linkmgr.cc:329: warning:
Cppcheck(unusedVariable): Unused variable: it2
2017-11-05 18:32:16 +01:00
Phenom
73e1ddc557 Fix CppCheck in pqi_base.h
/libretroshare/src/pqi/pqi_base.h:195: warning:
Cppcheck(noExplicitConstructor): Class 'PQInterface' has a constructor
with 1 argument that is not explicit.
2017-11-05 18:31:39 +01:00
Phenom
50a9d8a1e3 Fix CppCheck in p3servicecontrol
/libretroshare/src/pqi/p3servicecontrol.cc:840: warning:
Cppcheck(unreadVariable): Variable 'changes' is assigned a value that is
never used.
/libretroshare/src/pqi/p3servicecontrol.cc:941: warning:
Cppcheck(unusedVariable): Unused variable: mit
/libretroshare/src/pqi/p3servicecontrol.cc:972: warning:
Cppcheck(unusedVariable): Unused variable: mit
/libretroshare/src/pqi/p3servicecontrol.cc:88: warning:
Cppcheck(uninitMemberVar): Member variable
'p3ServiceControl::mServiceServer' is not initialized in the
constructor.
/libretroshare/src/pqi/p3servicecontrol.h:69: warning:
Cppcheck(noExplicitConstructor): Class 'p3ServiceControl' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/pqi/p3servicecontrol.cc:45: warning:
Cppcheck(noExplicitConstructor): Class 'RsServiceControlItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/pqi/p3servicecontrol.cc:52: warning:
Cppcheck(noExplicitConstructor): Class 'RsServicePermissionItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/pqi/p3servicecontrol.cc:359: warning:
Cppcheck(passedByValue): Function parameter 'serviceName' should be
passed by reference.
2017-11-05 18:28:37 +01:00
Phenom
d21b41f871 Fix CppCheck in p3netmgr.cc
/libretroshare/src/pqi/p3netmgr.cc:926: warning:
Cppcheck(unreadVariable): Variable 'title' is assigned a value that is
never used.
/libretroshare/src/pqi/p3netmgr.cc:1808: warning:
Cppcheck(unreadVariable): Variable 'connectstr' is assigned a value that
is never used.
2017-11-05 18:25:36 +01:00
Phenom
6a0fd1179c Fix CppCheck in p3historymgr.cc
/libretroshare/src/pqi/p3historymgr.cc:353: warning:
Cppcheck(invalidScanfArgType_int): %d in format string (no. 1) requires
'int *' but the argument type is 'unsigned int *'.
2017-11-05 18:24:32 +01:00
Phenom
bd5603590a Fix CppCheck in p3cfgmgr.h
/libretroshare/src/pqi/p3cfgmgr.h:154: warning:
Cppcheck(noExplicitConstructor): Class 'p3ConfigMgr' has a constructor
with 1 argument that is not explicit.
2017-11-05 18:23:58 +01:00
Phenom
0a82ff0736 Fix CppCheck in authssl.cc
/libretroshare/src/pqi/authssl.cc:857: warning:
Cppcheck(redundantAssignment): Variable 'buf_in' is reassigned a value
before the old one has been used.
/libretroshare/src/pqi/authssl.cc:864: warning:
Cppcheck(redundantAssignment): Variable 'buf_hashout' is reassigned a
value before the old one has been used.
/libretroshare/src/pqi/authssl.cc:867: warning:
Cppcheck(redundantAssignment): Variable 'buf_sigout' is reassigned a
value before the old one has been used.
/libretroshare/src/pqi/authssl.cc:1006: warning:
Cppcheck(redundantAssignment): Variable 'buf_in' is reassigned a value
before the old one has been used.
/libretroshare/src/pqi/authssl.cc:1013: warning:
Cppcheck(redundantAssignment): Variable 'buf_hashout' is reassigned a
value before the old one has been used.
/libretroshare/src/pqi/authssl.cc:1016: warning:
Cppcheck(redundantAssignment): Variable 'buf_sigout' is reassigned a
value before the old one has been used.
/libretroshare/src/pqi/authssl.cc:1451: warning:
Cppcheck(redundantAssignment): Variable 'ek' is reassigned a value
before the old one has been used.
/libretroshare/src/pqi/authssl.cc:366: warning:
Cppcheck(unreadVariable): Variable 'dh_prime_2048_hex' is assigned a
value that is never used.
/libretroshare/src/pqi/authssl.cc:1508: warning:
Cppcheck(unreadVariable): Variable 'in_offset' is assigned a value that
is never used.
/libretroshare/src/pqi/authssl.cc:249: warning:
Cppcheck(useInitializationList): Variable 'name' is assigned in
constructor body. Consider performing initialization in initialization
list.
2017-11-05 18:22:46 +01:00
Phenom
4fc7787405 Fix CppCheck in authgpg
/libretroshare/src/pqi/authgpg.cc:124: warning:
Cppcheck(uninitMemberVar): Member variable 'AuthGPG::mStoreKeyTime' is
not initialized in the constructor.
/libretroshare/src/pqi/authgpg.h:58: warning:
Cppcheck(noExplicitConstructor): Class 'AuthGPGOperation' has a
constructor with 1 argument that is not explicit.
2017-11-05 18:20:25 +01:00
Phenom
cd040f6501 Fix CppCheck in pluginmanager.h
/libretroshare/src/plugins/pluginmanager.h:48: warning:
Cppcheck(noExplicitConstructor): Class 'RsPluginManager' has a
constructor with 1 argument that is not explicit.
2017-11-05 18:19:50 +01:00
Phenom
60d476211f Fix CppCheck in rscertificate.h
/libretroshare/src/pgp/rscertificate.cc:75: warning:
Cppcheck(unusedVariable): Unused variable: res
/libretroshare/src/pgp/rscertificate.h:55: warning:
Cppcheck(operatorEqVarError): Member variable
'RsCertificate::ipv4_external_ip_and_port' is not assigned a value in
'RsCertificate::operator='.
/libretroshare/src/pgp/rscertificate.h:55: warning:
Cppcheck(operatorEqVarError): Member variable
'RsCertificate::ipv4_internal_ip_and_port' is not assigned a value in
'RsCertificate::operator='.
/libretroshare/src/pgp/rscertificate.h:55: warning:
Cppcheck(operatorEqVarError): Member variable
'RsCertificate::binary_pgp_key' is not assigned a value in
'RsCertificate::operator='.
/libretroshare/src/pgp/rscertificate.h:55: warning:
Cppcheck(operatorEqVarError): Member variable
'RsCertificate::binary_pgp_key_size' is not assigned a value in
'RsCertificate::operator='.
/libretroshare/src/pgp/rscertificate.h:55: warning:
Cppcheck(operatorEqVarError): Member variable 'RsCertificate::only_pgp'
is not assigned a value in 'RsCertificate::operator='.
/libretroshare/src/pgp/rscertificate.h:55: warning:
Cppcheck(operatorEqVarError): Member variable
'RsCertificate::hidden_node' is not assigned a value in
'RsCertificate::operator='.
/libretroshare/src/pgp/rscertificate.h:16: warning:
Cppcheck(noExplicitConstructor): Class 'RsCertificate' has a constructor
with 1 argument that is not explicit.
2017-11-05 18:19:10 +01:00
Phenom
f91756a1bb Fix CppCheck in pgphandler.h
/libretroshare/src/pgp/pgphandler.cc:1277: warning:
Cppcheck(funcArgOrderDifferent): Function 'decryptDataBin' argument
order different: declaration 'key_id, data, len, decrypted_data,
decrypted_data_len' definition ', encrypted_data, encrypted_len, data,
data_len'
2017-11-05 18:17:48 +01:00
Phenom
722d98e43e Fix CppCheck in rsgxstunnelitems.h
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:75: warning:
Cppcheck(uninitMemberVar): Member variable 'RsGxsTunnelDataItem::flags'
is not initialized in the constructor.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:76: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsTunnelDataItem::unique_item_counter' is not initialized in the
constructor.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:76: warning:
Cppcheck(uninitMemberVar): Member variable 'RsGxsTunnelDataItem::flags'
is not initialized in the constructor.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:76: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsTunnelDataItem::service_id' is not initialized in the constructor.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:111: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsTunnelDataAckItem::unique_item_counter' is not initialized in the
constructor.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:128: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsTunnelDHPublicKeyItem::public_key' is not initialized in the
constructor.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:145: warning:
Cppcheck(operatorEqVarError): Member variable
'RsGxsTunnelDHPublicKeyItem::public_key' is not assigned a value in
'RsGxsTunnelDHPublicKeyItem::operator='.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:56: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsTunnelItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/gxstunnel/rsgxstunnelitems.h:76: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsTunnelDataItem' has a
constructor with 1 argument that is not explicit.
2017-11-05 16:55:48 +01:00
Phenom
4ed663a5c1 Fix CppCheck in p3gxstunnel.h
/libretroshare/src/gxstunnel/p3gxstunnel.h:127: warning:
Cppcheck(noExplicitConstructor): Class 'p3GxsTunnelService' has a
constructor with 1 argument that is not explicit.
2017-11-05 16:53:37 +01:00
Phenom
242cc9d199 Fix CppCheck in p3gxstransitems.h
/libretroshare/src/gxstrans/p3gxstransitems.h:42: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsTransBaseMsgItem' has a
constructor with 1 argument that is not explicit.
2017-11-05 16:53:15 +01:00
Phenom
3702cf259a Fix CppCheck in p3gxstrans.h
/libretroshare/src/gxstrans/p3gxstrans.h:296: warning:
Cppcheck(noExplicitConstructor): Class 'GxsTransIntegrityCleanupThread'
has a constructor with 1 argument that is not explicit.
2017-11-05 16:52:05 +01:00
Phenom
77c1ab4dd7 Fix CppCheck in rsgxsdataaccess.h
/libretroshare/src/gxs/rsgxsdataaccess.h:40: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsDataAccess' has a
constructor with 1 argument that is not explicit.
2017-11-05 16:47:49 +01:00
Phenom
718c09e6d7 Fix CppCheck in rsgixs.h
/libretroshare/src/gxs/rsgixs.h:179: warning: Cppcheck(uninitMemberVar):
Member variable 'GixsReputation::reputation_level' is not initialized in
the constructor.
2017-11-05 16:47:24 +01:00
Phenom
eb7655c14f Fix CppCheck in rsgenexchange.cc
/libretroshare/src/gxs/rsgenexchange.cc:2165: warning:
Cppcheck(redundantAssignment): Variable 'serialOk' is reassigned a value
before the old one has been used.
/libretroshare/src/gxs/rsgenexchange.cc:1227: warning:
Cppcheck(unusedVariable): Unused variable: metaL
/libretroshare/src/gxs/rsgenexchange.cc:2254: warning:
Cppcheck(unreadVariable): Variable 's' is assigned a value that is never
used.
/libretroshare/src/gxs/rsgenexchange.cc:71: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGenExchange::mCheckStarted' is not initialized in the constructor.
2017-11-05 16:46:57 +01:00
Phenom
344bc27ff7 Fix CppCheck in gxstokenqueue.h
/libretroshare/src/gxs/gxstokenqueue.h:51: warning:
Cppcheck(noExplicitConstructor): Class 'GxsTokenQueue' has a constructor
with 1 argument that is not explicit.
2017-11-05 16:41:40 +01:00
Phenom
f81c6aea03 Fix CppCheck in p3grouter
/libretroshare/src/grouter/p3grouter.cc:2295: warning:
Cppcheck(cstyleCast): C-style pointer casting
/libretroshare/src/grouter/p3grouter.h:82: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterDataInfo::last_activity_TS' is not initialized in the
constructor.
/libretroshare/src/grouter/p3grouter.cc:206: warning:
Cppcheck(uninitMemberVar): Member variable 'p3GRouter::mTurtle' is not
initialized in the constructor.
/libretroshare/src/grouter/p3grouter.cc:206: warning:
Cppcheck(uninitMemberVar): Member variable 'p3GRouter::mLinkMgr' is not
initialized in the constructor.
2017-11-05 16:41:11 +01:00
Phenom
10721945a3 Fix CppCheck in grouteritems.h
/libretroshare/src/grouter/grouteritems.h:93: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterAbstractMsgItem::flags' is not initialized in the constructor.
/libretroshare/src/grouter/grouteritems.h:106: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterGenericDataItem::data_size' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:106: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterGenericDataItem::data_bytes' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:106: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterGenericDataItem::duplication_factor' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:159: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterTransactionChunkItem::chunk_start' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:159: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterTransactionChunkItem::chunk_size' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:159: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterTransactionChunkItem::total_size' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:159: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterTransactionChunkItem::chunk_data' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:220: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGRouterMatrixTrackItem::time_stamp' is not initialized in the
constructor.
/libretroshare/src/grouter/grouteritems.h:62: warning:
Cppcheck(noExplicitConstructor): Class 'RsGRouterItem' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/grouter/grouteritems.h:93: warning:
Cppcheck(noExplicitConstructor): Class 'RsGRouterAbstractMsgItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/grouter/grouteritems.h:147: warning:
Cppcheck(noExplicitConstructor): Class 'RsGRouterTransactionItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/grouter/grouteritems.h:274: warning:
Cppcheck(noExplicitConstructor): Class 'RsGRouterSerialiser' has a
constructor with 1 argument that is not explicit.
2017-11-05 16:39:44 +01:00
Phenom
10233ef1cc Fix CppCheck in groutertypes.h
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::data_status' is not initialized in the constructor.
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::tunnel_status' is not initialized in the
constructor.
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::received_time_TS' is not initialized in the
constructor.
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::last_sent_TS' is not initialized in the
constructor.
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::last_tunnel_request_TS' is not initialized in the
constructor.
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::sending_attempts' is not initialized in the
constructor.
/libretroshare/src/grouter/groutertypes.h:99: warning:
Cppcheck(uninitMemberVar): Member variable
'GRouterRoutingInfo::routing_flags' is not initialized in the
constructor.
2017-11-05 16:38:50 +01:00
Phenom
a622194c2d Fix CppCheck in ftturtlefiletransferitem.h
/libretroshare/src/ft/ftturtlefiletransferitem.h:36: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleFileRequestItem::chunk_offset' is not initialized in the
constructor.
/libretroshare/src/ft/ftturtlefiletransferitem.h:36: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleFileRequestItem::chunk_size' is not initialized in the
constructor.
/libretroshare/src/ft/ftturtlefiletransferitem.h:52: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleFileDataItem::chunk_offset' is not initialized in the
constructor.
/libretroshare/src/ft/ftturtlefiletransferitem.h:52: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleFileDataItem::chunk_size' is not initialized in the
constructor.
/libretroshare/src/ft/ftturtlefiletransferitem.h:52: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleFileDataItem::chunk_data' is not initialized in the
constructor.
/libretroshare/src/ft/ftturtlefiletransferitem.h:102: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleChunkCrcRequestItem::chunk_number' is not initialized in the
constructor.
/libretroshare/src/ft/ftturtlefiletransferitem.h:116: warning:
Cppcheck(uninitMemberVar): Member variable
'RsTurtleChunkCrcItem::chunk_number' is not initialized in the
constructor.
2017-11-05 16:36:01 +01:00
Phenom
edfd2ad232 Fix CppCheck in fttransfermodule
/libretroshare/src/ft/fttransfermodule.cc:158: warning:
Cppcheck(unreadVariable): Variable 'mit' is assigned a value that is
never used.
/libretroshare/src/ft/fttransfermodule.h:59: warning:
Cppcheck(noExplicitConstructor): Class 'peerInfo' has a constructor with
1 argument that is not explicit.
/libretroshare/src/ft/fttransfermodule.h:114: warning:
Cppcheck(noExplicitConstructor): Class 'ftFileStatus' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/ft/fttransfermodule.cc:548: warning:
Cppcheck(noExplicitConstructor): Class 'HashThread' has a constructor
with 1 argument that is not explicit.
2017-11-05 16:34:45 +01:00
Phenom
c8548b2a2d Fix CppCheck in ftserver.cc
/libretroshare/src/ft/ftserver.cc:134: warning:
Cppcheck(unreadVariable): Variable 'localcachedir' is assigned a value
that is never used.
/libretroshare/src/ft/ftserver.cc:135: warning:
Cppcheck(unreadVariable): Variable 'remotecachedir' is assigned a value
that is never used.
2017-11-05 16:33:56 +01:00
Phenom
51ed0324f6 Fix CppCheck ftfilecreator.cc
/libretroshare/src/ft/ftfilecreator.cc:86: warning:
Cppcheck(unusedVariable): Unused variable: it
/libretroshare/src/ft/ftfilecreator.cc:545: warning:
Cppcheck(unreadVariable): Variable 'chunks_for_this_peer' is modified
but its new value is never used.
2017-11-05 16:33:16 +01:00
Phenom
68934499d4 Fix CppCheck in ftchunkmap.h
/libretroshare/src/ft/ftchunkmap.h:37: warning:
Cppcheck(uninitMemberVar): Member variable 'ftChunk::id' is not
initialized in the constructor.
2017-11-05 16:28:37 +01:00
Phenom
f8d4d6cb21 Fix CppCheck in p3filelists.h
/libretroshare/src/file_sharing/p3filelists.h:86: warning:
Cppcheck(noExplicitConstructor): Class 'p3FileDatabase' has a
constructor with 1 argument that is not explicit.
2017-11-05 16:28:06 +01:00
Phenom
0d5b1ed40b Fix CppCheck in rsfilelistitems.h
/libretroshare/src/file_sharing/rsfilelistitems.h:78: warning:
Cppcheck(uninitMemberVar): Member variable
'RsFileListsSyncRequestItem::flags' is not initialized in the
constructor.
/libretroshare/src/file_sharing/rsfilelistitems.h:78: warning:
Cppcheck(uninitMemberVar): Member variable
'RsFileListsSyncRequestItem::last_known_recurs_modf_TS' is not
initialized in the constructor.
/libretroshare/src/file_sharing/rsfilelistitems.h:78: warning:
Cppcheck(uninitMemberVar): Member variable
'RsFileListsSyncRequestItem::request_id' is not initialized in the
constructor.
/libretroshare/src/file_sharing/rsfilelistitems.h:94: warning:
Cppcheck(uninitMemberVar): Member variable
'RsFileListsSyncResponseItem::flags' is not initialized in the
constructor.
/libretroshare/src/file_sharing/rsfilelistitems.h:94: warning:
Cppcheck(uninitMemberVar): Member variable
'RsFileListsSyncResponseItem::last_known_recurs_modf_TS' is not
initialized in the constructor.
/libretroshare/src/file_sharing/rsfilelistitems.h:94: warning:
Cppcheck(uninitMemberVar): Member variable
'RsFileListsSyncResponseItem::request_id' is not initialized in the
constructor.
/libretroshare/src/file_sharing/rsfilelistitems.h:52: warning:
Cppcheck(noExplicitConstructor): Class 'RsFileListsItem' has a
constructor with 1 argument that is not explicit.
2017-11-05 16:27:45 +01:00
Phenom
0e014d6632 Fix CppCheck in p3filelists.cc
/libretroshare/src/file_sharing/hash_cache.h:57: warning:
Cppcheck(noExplicitConstructor): Class 'HashStorage' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/file_sharing/p3filelists.cc:375: warning:
Cppcheck(unusedVariable): Unused variable: mit
/libretroshare/src/file_sharing/p3filelists.cc:1530: warning:
Cppcheck(unreadVariable): Variable 'indent' is assigned a value that is
never used.
2017-11-05 16:26:56 +01:00
Phenom
d9965acf1d Fix CppCheck in hash_cache.h
/libretroshare/src/file_sharing/hash_cache.h:57: warning:
Cppcheck(noExplicitConstructor): Class 'HashStorage' has a constructor
with 1 argument that is not explicit.
2017-11-05 16:26:02 +01:00
Phenom
f18a842d9d Fix CppCheck in directory_storage.h and directory_storage.cc
/libretroshare/src/file_sharing/directory_storage.h💯 warning:
Cppcheck(noExplicitConstructor): Class 'FileIterator' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/file_sharing/directory_storage.cc:579: warning:
Cppcheck(unusedVariable): Unused variable: peers
2017-11-05 16:23:47 +01:00
Phenom
1456bdd641 Fix CppCheck in dir_hierarchy.h and dir_hierarchy.cc
/libretroshare/src/file_sharing/dir_hierarchy.cc:883: warning:
Cppcheck(unreadVariable): Variable 'nunknown' is modified but its new
value is never used.
/libretroshare/src/file_sharing/dir_hierarchy.h:71: warning:
Cppcheck(noExplicitConstructor): Class 'DirEntry' has a constructor with
1 argument that is not explicit.
/libretroshare/src/file_sharing/dir_hierarchy.cc:1056: warning:
Cppcheck(noExplicitConstructor): Class 'read_error' has a constructor
with 1 argument that is not explicit.
2017-11-05 16:22:51 +01:00
csoler
37f6e7e13b
Merge pull request #1064 from PhenomRetroShare/Fix_OpModeRestore
Fix OpMode Restore
2017-11-03 23:49:30 +01:00
csoler
aa4c2090cf fixed formula to compute score based on up/dn votes in comments 2017-11-02 22:20:49 +01:00
csoler
3bb694f439 added display of hashing speed. Changed hashing buffer size to 10MB to improve performance 2017-10-29 21:24:34 +01:00
Arthur Cruchon
39759993fb Add missing close after blacklisted connection attempt. 2017-10-25 17:42:09 +02:00
csoler
06f489ec61 Merge pull request #1065 from csoler/v0.6-Links2
V0.6 links2
2017-10-23 22:14:06 +02:00
csoler
edffbc3670 fixed bug in removing top dirs when creating file hierarhies 2017-10-21 18:09:26 +02:00
csoler
32be00614d various improvements to collection links 2017-10-19 10:19:56 +02:00
csoler
9206daca37 fixed up collection link display 2017-10-18 23:20:19 +02:00
csoler
e1d5014288 added copy links from file hierarchy 2017-10-18 22:32:15 +02:00
csoler
f98edd400e added FileTree class to implement a compact representation of file hierarchies 2017-10-18 00:04:04 +02:00
Phenom
e63217e7de Fix OpMode Restore 2017-10-17 15:39:38 +02:00
Gioacchino Mazzurco
034d88c4e2 Fix android compilation with newer Qt
In lastest Qt versions linux-* mkspec doesn't match android anymore,
this was triggering a compilation error as DATA_DIR was not defined the
RsAccountsDetail::PathDataDirectory(bool check) code has been rearranged
so it works reasonably also on Android and do not depend on DATA_DIR
define anymore

Updated Android compiling documentation
2017-10-16 20:07:52 +02:00
csoler
d61a5cd5ab attempt at fixing the re-hash bug. Now only using canonicalized filenames in hash cache 2017-10-02 22:23:26 +02:00
csoler
22942dc70b fixed bug causing suffix/prefix lists to contain an empty string 2017-10-01 20:20:26 +02:00
Phenom
7f851f66be Fix Gcc Warning in p3banlist 2017-09-28 19:24:26 +02:00
csoler
a00d2c912c changed lobby to char room in chat system msgs 2017-09-26 21:12:17 +02:00
csoler
cbeefda151 Merge pull request #744 from RetroPooh/tunnel-names
transfers - add peer names for turtle routed sources
2017-09-25 21:35:59 +02:00
csoler
5970ff239b Merge pull request #1052 from csoler/v0.6-FT
removed delay when calling forceUpdate() on directories
2017-09-25 21:14:30 +02:00
csoler
40cda111d2 removed delay when calling forceUpdate() on directories 2017-09-25 21:05:42 +02:00
csoler
b969f313b0 Merge pull request #1050 from csoler/v0.6-FT
V0.6 ft
2017-09-25 20:59:32 +02:00
csoler
d8cb3fe35a fixed not rehashing files that already exist in a different directory pointed by a symlink 2017-09-25 20:56:35 +02:00
Pooh
c47e6f620d Merge branch 'master' into tunnel-names 2017-09-25 21:43:41 +03:00
csoler
4766a8927a added an additional hard limit to directory depth, just in case 2017-09-24 23:51:47 +02:00
csoler
f497905497 fixed limitation of directory depth when indexing files 2017-09-24 23:43:52 +02:00
csoler
abd7e25a2e added checks for mMaxShareDepth and mIgnoreDuplicates 2017-09-24 18:14:45 +02:00
csoler
2a99df4d48 added UI and parameters for two new options in shared files: max share depth and ignore duplicates 2017-09-24 17:53:06 +02:00
csoler
73cbf6ca38 Merge pull request #1047 from csoler/v0.6-FT
removed the 4M files limit on 64bits systems
2017-09-21 23:47:11 +02:00
csoler
a2ccf97b82 removed the 4M files limit on 64bits systems 2017-09-20 22:57:32 +02:00
csoler
58ccf0bef4 Merge pull request #1045 from csoler/v0.6-FT
adding pending transfers 100 at a time instead of 1 at a time when lo…
2017-09-18 22:50:35 +02:00
csoler
bc2c9d576e adding pending transfers 100 at a time instead of 1 at a time when loading 2017-09-18 22:49:51 +02:00
csoler
bf7d346e8d Merge pull request #1043 from csoler/v0.6-FT
make forceDirectoryCheck() to desactivate the pause, in case it was l…
2017-09-17 20:27:44 +02:00
csoler
d8f621e9ec make forceDirectoryCheck() to desactivate the pause, in case it was left activated 2017-09-17 20:14:45 +02:00
Gioacchino Mazzurco
2b71a049eb Use proper initializers in p3BanList 2017-09-17 15:36:06 +02:00
Gioacchino Mazzurco
d89c151a4d Fix typo 2017-09-17 14:41:18 +02:00
csoler
8189d660c4 fixed bug causing anon FT to not resume when restarting RS when the server enforces encryption 2017-09-16 22:13:15 +02:00
RetroPooh
b9be37b245 search spy more files 2017-09-15 15:16:36 +03:00
RetroPooh
41251fdd9e search spy 2017-09-15 15:03:06 +03:00
Phenom
a0ebddb4eb Fic Gcc warnings:
/libretroshare/src/file_sharing/p3filelists.cc👎 In static member
function ‘static bool p3FileDatabase::convertPointerToEntryIndex(const
void*, p3FileDatabase::EntryIndex&, uint32_t&)’:
/libretroshare/src/file_sharing/p3filelists.cc:624: warning:
dereferencing type-punned pointer will break strict-aliasing rules [-
Wstrict-aliasing]
     e   = EntryIndex(  *reinterpret_cast<uint32_t*>(&p) &
ENTRY_INDEX_BIT_MASK ) ;
/home/phenom/GIT/RetroShare/trunk/libretroshare/src/file_sharing/
p3filelists.cc:625: warning: dereferencing type-punned pointer will
break strict-aliasing rules [-Wstrict-aliasing]
     friend_index = (*reinterpret_cast<uint32_t*>(&p)) >>
NB_ENTRY_INDEX_BITS ;

/libretroshare/src/gxstrans/p3gxstransitems.h:29: In file included from
../../../trunk/libretroshare/src/gxstrans/p3gxstransitems.h:29:0,
/libretroshare/src/gxstrans/p3gxstransitems.cc:19: from ../../../trunk/
libretroshare/src/gxstrans/p3gxstransitems.cc:19:
/libretroshare/src/gxstrans/p3gxstransitems.cc👎 In member function
‘virtual void
OutgoingRecord_deprecated::serial_process(RsGenericSerializer::SerializeJob,
RsGenericSerializer::SerializeContext&)’:
/libretroshare/src/serialiser/rstypeserializer.h:61: warning:
dereferencing type-punned pointer will break strict-aliasing rules [-
Wstrict-aliasing]
  RsTypeSerializer::serial_process<T>(j, ctx, reinterpret_cast<T&>(I),
#I);\

/libretroshare/src/gxstrans/p3gxstransitems.cc:51: in expansion of macro
‘RS_REGISTER_SERIAL_MEMBER_TYPED’
  RS_REGISTER_SERIAL_MEMBER_TYPED(clientService, uint16_t);
/libretroshare/src/gxstrans/p3gxstransitems.cc👎 In member function
‘virtual void
OutgoingRecord::serial_process(RsGenericSerializer::SerializeJob,
RsGenericSerializer::SerializeContext&)’:
/libretroshare/src/serialiser/rstypeserializer.h:61: warning:
dereferencing type-punned pointer will break strict-aliasing rules [-
Wstrict-aliasing]
  RsTypeSerializer::serial_process<T>(j, ctx, reinterpret_cast<T&>(I),
#I);\

/libretroshare/src/gxstrans/p3gxstransitems.cc:65: in expansion of macro
‘RS_REGISTER_SERIAL_MEMBER_TYPED’
  RS_REGISTER_SERIAL_MEMBER_TYPED(clientService, uint16_t);
/retroshare-gui/src/gui/common/RsBanListToolButton.cpp👎 In member
function ‘void RsBanListToolButton::applyIp()’:
/retroshare-gui/src/gui/common/RsBanListToolButton.cpp:163: warning:
‘list_type’ may be used uninitialized in this function [-Wmaybe-
uninitialized]
   changed = rsBanList->removeIpRange(addr, masked_bytes, list_type);
2017-09-13 18:37:32 +02:00
Phenom
8884a324bb Fix Uninitilized Peer Max Rates.
When called by /libretroshare/src/pqi/pqihandler.cc:140
2017-09-12 17:18:41 +02:00
Phenom
cf908674ce Fix unitialized value in LocalDirectoryUpdater. 2017-09-11 21:51:14 +02:00
csoler
551ef63c6e added default ignore list on linux 2017-09-11 19:36:06 +02:00
csoler
0ca0b72a5a moved file ignore test to a more appropriate place 2017-09-11 19:02:07 +02:00
csoler
eff5c5d6ee added pause to file hashing 2017-09-10 22:07:36 +02:00
csoler
ea25d4b5a4 improved update of ignore list 2017-09-10 20:22:17 +02:00
csoler
884b3a6220 added infrastructure to add a ignore list in shared files 2017-09-10 19:58:57 +02:00
csoler
160ab7b4f3 added missing code for remote search by hash, fixing the bug of direct sources not added 2017-09-03 23:32:48 +02:00
csoler
8d146038c2 fixed bug preventing search by hash to be called on own files 2017-09-03 22:52:31 +02:00
Gioacchino Mazzurco
32f43b999e Merge branch 'GSoC2017-evaluation-final' 2017-08-18 01:39:31 +02:00
Phenom
5a1c316fc6 Fix Travis MacOs Compilation 2017-08-12 11:49:33 +02:00
thunder2
3ae85dbc6f Fixed version number in rsversion.in 2017-08-06 14:10:23 +02:00
thunder2
52dbd91f3b Removed Windows specific hack to get commandline arguments. 2017-08-05 14:23:35 +02:00
csoler
3e25d96daa fixed unix -> linux-* target in .pri, as qt4 doesnt seem to recognise unix 2017-08-04 21:38:44 +02:00
csoler
11832e34f8 updated version number 2017-08-03 22:51:40 +02:00
csoler
4e02c5f262 Merge pull request #979 from PhenomRetroShare/Fix_LobbyAutoSubscribe
Fix Lobby auto-subscribe.
2017-08-03 21:29:52 +02:00
csoler
4b820a055c Merge pull request #981 from csoler/v0.6.3
removed newline that comes with debug info
2017-08-03 21:08:54 +02:00
csoler
84b32f060e removed newline that comes with debug info 2017-08-03 20:09:48 +02:00
Phenom
27bedf8414 Fix Lobby auto-subscribe.
Don't remove auto-subscribe if we cannot get gxsId detail.
But what happens if the id is removed?
2017-08-01 10:16:42 +02:00
csoler
7d5f60185b Merge pull request #978 from G10h4ck/cxx11_comp
Introduce C++11 compatibility macro for gcc < 4.6
2017-07-31 19:22:15 +02:00
Gioacchino Mazzurco
541b1ea498 Introduce C++11 compatibility macro for gcc < 4.6 2017-07-31 18:26:51 +02:00
csoler
2588068775 Merge pull request #953 from PhenomRetroShare/Fix_NewWindowForPassword
Fix Ask Password in new window if wrong in StartDialog.
2017-07-30 21:29:14 +02:00
csoler
a2f8b5e6e9 Merge pull request #972 from csoler/v0.6.3
V0.6.3
2017-07-30 14:42:28 +02:00
csoler
e82b6fc1fe improved GenCertDialog with small indicator text, and hide location by default 2017-07-30 14:31:52 +02:00
Phenom
5dc25e37f7 Fix Ask Password in new window if wrong in StartDialog.
And Fix LineEditClear to show placeholder test even if it has focus
(Like Qt5).
2017-07-30 14:11:34 +02:00
csoler
09faa60005 Merge pull request #967 from csoler/v0.6.3
V0.6.3
2017-07-29 23:16:47 +02:00
csoler
e8415c4f03 made RS not to ask for plugin confirmation on first load 2017-07-29 23:12:56 +02:00
csoler
a16220e53e switched to RC2 2017-07-29 20:24:31 +02:00
csoler
e861f87364 removed unused msg item class that caused aliasing warnings (serialisation of time_t as uint32_t) 2017-07-26 21:44:24 +02:00
csoler
286e7e0b1a Merge pull request #961 from csoler/v0.6.3
V0.6.3
2017-07-26 14:01:28 +02:00
csoler
34ddf71703 Merge pull request #957 from PhenomRetroShare/Fix_CppCheckerError
Fix cpp checker error
2017-07-26 13:54:44 +02:00
csoler
1792273cff Merge pull request #946 from PhenomRetroShare/Fix_GuiAutoLogin
Fix GUI AutoLogin
2017-07-26 13:50:21 +02:00
csoler
b0483a0c38 fixed bug in removeDeleteExistingMsgs() 2017-07-26 10:23:18 +02:00
csoler
9881b616ac cleanup code in RsGenExchange 2017-07-25 22:06:18 +02:00
csoler
a382a0f5ce fixed memory leak in p3peermgr config load 2017-07-25 21:52:09 +02:00
csoler
041f989f1c rewrote processRecvdMessages() and processRecvdGroups() in RsGenExchange. Removed mReceivedGrps and mReceivedMsgs, cleaned-up terrible branching and memory management 2017-07-25 21:21:24 +02:00
csoler
461ccf3b84 removed aliasing in storeMessages/storeGroups, removed several memory leaks in unittests, improved auto-delete structures in rsgxsutil, added deletion for members of RsGenExchange, removed shared pointers from unittests (they cause a memory leak and are only used in unittests) 2017-07-25 00:07:53 +02:00
csoler
79779b8056 fixed memory leaks in GxsSecurity 2017-07-24 18:45:24 +02:00
csoler
70f72db0aa fixed memory leak in GxsSecurity 2017-07-24 18:20:21 +02:00
csoler
bcaafc241d improved template class naming for temporary Gxs grp data structures 2017-07-24 14:29:30 +02:00
Gioacchino Mazzurco
3b1606ceb9 Remove misguiding if 2017-07-24 11:52:23 +02:00
Gioacchino Mazzurco
03cc2e629d Remove miguiding if before delete 2017-07-24 10:16:24 +02:00
csoler
02424240a0 reverting last commit that causes crashes 2017-07-22 12:08:28 +02:00
csoler
9e2241a940 attempt to fix memory leak in RsGenExchange. To be tested. 2017-07-21 23:15:50 +02:00
Phenom
8ce10ea6a8 Fix past commit for p3idservice.cc 2017-07-21 15:31:53 +02:00
Phenom
2afc1bf423 Fix CppCheck Error in contentvalue.cc
/libretroshare/src/util/contentvalue.cc:189: error: Cppcheck(memleak):
Memory leak: dest
2017-07-21 15:04:34 +02:00
Phenom
e5767431e6 Fix CppCheck Error in p3idservice.cc
/libretroshare/src/services/p3idservice.cc:1216: error:
Cppcheck(eraseDereference): Iterator 'it' used after element has been
erased.
/libretroshare/src/services/p3idservice.cc:1346: error:
Cppcheck(eraseDereference): Iterator 'it' used after element has been
erased.
/libretroshare/src/services/p3idservice.cc:448: error:
Cppcheck(uninitvar): Uninitialized variable: max_keep_time
2017-07-21 14:57:43 +02:00
csoler
aa471e5b2f fixed uninitialized memory read in GxsTrans 2017-07-21 10:25:20 +02:00
csoler
baac33d95a updated revision number 2017-07-20 21:18:57 +02:00
Phenom
cbbc3920fa Fix Lobby auto-subscribe.
Save GxsId for each.
Disallow to auto-subscribe to signed lobby with unsigned id.
2017-07-19 18:33:55 +02:00
csoler
71810e8daa Merge pull request #950 from PhenomRetroShare/Add_ChatServerFlag
Add flag for ChatServer
2017-07-19 18:18:32 +02:00
Phenom
5bbb99aef7 Fix Bad Service Monitor registering.
This induce to remove peers in statistics->bandwidth when disc service
is off.
2017-07-18 19:24:32 +02:00
Phenom
3a6bcf5ef8 Add flag for ChatServer
append the following assignation to qmake command line "CONFIG
+=rs_chatserver"
2017-07-18 16:34:56 +02:00
csoler
e56340e0a1 Merge pull request #386 from PhenomRetroShare/Add_AbilityToChangeOpModeInCmdLine
Add the ability to change OpMode in command line.
2017-07-17 23:12:06 +02:00
csoler
f4aec11b0a suppressed warning in p3dhtmgr.cc 2017-07-17 22:48:12 +02:00
Phenom
437426429e Fix clang warning: unused variable 'pqiservicezone'
/libretroshare/src/pqi/pqiservice.cc:30: warning: unused variable
'pqiservicezone' [-Wunused-const-variable]
const int pqiservicezone = 60478;
2017-07-17 22:35:01 +02:00
Phenom
300359863e Fix clang warning: 'p3ChatService' defined as a struct here but
previously declared as a class

/libretroshare/src/chat/p3chatservice.h:56: warning: 'p3ChatService'
defined as a struct here but previously declared as a class [-
Wmismatched-tags]
struct p3ChatService :
/libretroshare/src/rsserver/p3msgs.h:33: did you mean struct here?
class p3ChatService;
2017-07-17 22:32:23 +02:00
Phenom
91c526f2b5 Fix clang warning: 'p3MsgService' defined as a struct here but
previously declared as a class

/libretroshare/src/services/p3msgservice.h:58: warning: 'p3MsgService'
defined as a struct here but previously declared as a class [-
Wmismatched-tags]
struct p3MsgService :
/libretroshare/src/rsserver/p3msgs.h:32: did you mean struct here?
class p3MsgService;
2017-07-17 22:32:07 +02:00
Phenom
896ed3e992 Fix clang warning: class 'p3Config' was previously declared as a struct
/libretroshare/src/retroshare/rsplugin.h:77: warning: class 'p3Config'
was previously declared as a struct [-Wmismatched-tags]
class p3Config;
2017-07-17 22:31:30 +02:00
Phenom
8dbb0d61af Fix warning: this statement may fall through
/libretroshare/src/dht/connectstatebox.cc:394: warning: this statement
may fall through [-Wimplicit-fallthrough=]
    if (mNextAttemptTS > now)
/libretroshare/src/dht/connectstatebox.cc:401: here
   default:

/libretroshare/src/dht/connectstatebox.cc:406: warning: this statement
may fall through [-Wimplicit-fallthrough=]
    if (mState != CSB_FAILED_WAIT)
/libretroshare/src/dht/connectstatebox.cc:414: here
   case CSB_START:

/libretroshare/src/dht/connectstatebox.cc:530: warning: this statement
may fall through [-Wimplicit-fallthrough=]
    if (mNextAttemptTS > now)
/libretroshare/src/dht/connectstatebox.cc:540: here
   default:

/libretroshare/src/dht/connectstatebox.cc:543: warning: this statement
may fall through [-Wimplicit-fallthrough=]
    if (mState != CSB_FAILED_WAIT)
/libretroshare/src/dht/connectstatebox.cc:551: here
   case CSB_START:
2017-07-17 22:29:11 +02:00
Phenom
f888913800 Set Operating Mode in RsInit::InitRetroShare so noGUI could use it. 2017-07-17 15:40:14 +02:00
cyril soler
1491a051dc fixed deadlock situation in FT causing multiple bugs: lock when DLing from a file list a file that is already being downloaded, and lock when a FT module find a direct source among friends 2017-07-17 11:16:48 +02:00
Phenom
e2fa57dcd7 Fix clang warning: unused variable 'INTERVAL_BETWEEN_DEBUG_DUMP'
/libretroshare/src/gxstunnel/p3gxstunnel.cc:62: warning: unused variable
'INTERVAL_BETWEEN_DEBUG_DUMP' [-Wunused-const-variable]
static const uint32_t INTERVAL_BETWEEN_DEBUG_DUMP        = 10 ;
2017-07-16 21:43:05 +02:00
Phenom
26397d7e4d Fix clang warning: unused variables 'LOWER_LIMIT', ...
/libretroshare/src/services/p3gxsreputation.cc:130: warning: unused
variable 'LOWER_LIMIT' [-Wunused-const-variable]
static const uint32_t LOWER_LIMIT                         = 0;        //
used to filter valid Opinion values from serialized data
/libretroshare/src/services/p3gxsreputation.cc:132: warning: unused
variable 'kMaximumPeerAge' [-Wunused-const-variable]
static const int      kMaximumPeerAge                     = 180;      //
half a year.
/libretroshare/src/services/p3gxsreputation.cc:135: warning: unused
variable 'ACTIVE_FRIENDS_ONLINE_DELAY' [-Wunused-const-variable]
static const int      ACTIVE_FRIENDS_ONLINE_DELAY         = 86400*7 ; //
1 week.
/libretroshare/src/services/p3gxsreputation.cc:138: warning: unused
variable 'REPUTATION_ASSESSMENT_THRESHOLD_X1' [-Wunused-const-variable]
static const float    REPUTATION_ASSESSMENT_THRESHOLD_X1  = 0.5f ;    //
reputation under which the peer gets killed. Warning there's a 1 shift
with what's shown in GUI. Be careful.
/libretroshare/src/services/p3gxsreputation.cc:139: warning: unused
variable 'PGP_AUTO_BAN_THRESHOLD_DEFAULT' [-Wunused-const-variable]
static const uint32_t PGP_AUTO_BAN_THRESHOLD_DEFAULT      = 2 ;       //
above this, auto ban any GXS id signed by this node
/libretroshare/src/gxstunnel/p3gxstunnel.cc:62: warning: unused variable
'INTERVAL_BETWEEN_DEBUG_DUMP' [-Wunused-const-variable]
static const uint32_t INTERVAL_BETWEEN_DEBUG_DUMP        = 10 ;
2017-07-16 21:37:22 +02:00
Phenom
903f875d1d Fix clang warning: unused variable 'MAX_SERIALIZED_ARRAY_SIZE'
/libretroshare/src/serialiser/rstypeserializer.cc:39: warning: unused
variable 'MAX_SERIALIZED_ARRAY_SIZE' [-Wunused-const-variable]
static const uint32_t MAX_SERIALIZED_ARRAY_SIZE = 500 ;
2017-07-16 21:36:35 +02:00
Phenom
d83a9625cc Fix clang warning: unused variables 'GIXS_CUT_OFF', ...
/libretroshare/src/gxs/rsgxsnetservice.cc:247: warning: unused variable
'GIXS_CUT_OFF' [-Wunused-const-variable]
static const uint32_t GIXS_CUT_OFF                            =
0;
/libretroshare/src/gxs/rsgxsnetservice.cc:251: warning: unused variable
'SECURITY_DELAY_TO_FORCE_CLIENT_REUPDATE' [-Wunused-const-variable]
static const uint32_t SECURITY_DELAY_TO_FORCE_CLIENT_REUPDATE =
3600; // force re-update if there happens to be a large delay between
our server side TS and the client side TS of friends
2017-07-16 21:36:14 +02:00
Phenom
51fa7a5dda Fix clang warning: unused variable 'p3facestartupzone'
/libretroshare/src/rsserver/rsinit.cc:145: warning: unused variable
'p3facestartupzone' [-Wunused-const-variable]
const int p3facestartupzone = 47238;
2017-07-16 21:35:35 +02:00
Phenom
13220ec414 Fix clang warning: unused variable
'MAX_TIME_KEEP_LOCATION_WITHOUT_CONTACT'

/libretroshare/src/rsserver/p3peers.cc:52: warning: unused variable
'MAX_TIME_KEEP_LOCATION_WITHOUT_CONTACT' [-Wunused-const-variable]
static const int MAX_TIME_KEEP_LOCATION_WITHOUT_CONTACT = 30*24*3600 ;
// 30 days.
2017-07-16 21:34:38 +02:00
Phenom
fea1b83b34 Fix clang warning: unused variable 'p3facemsgzone'
/libretroshare/src/rsserver/p3face-config.cc:36: warning: unused
variable 'p3facemsgzone' [-Wunused-const-variable]
const int p3facemsgzone = 11453;

/libretroshare/src/rsserver/p3msgs.cc:33: warning: unused variable
'p3facemsgzone' [-Wunused-const-variable]
const int p3facemsgzone = 11453;
2017-07-16 21:34:09 +02:00
Phenom
5a64996304 Fix clang warning: unused variables 'RS_NET_NEEDS_RESET', ...
/libretroshare/src/pqi/p3peermgr.cc:53: warning: unused variable
'RS_NET_NEEDS_RESET' [-Wunused-const-variable]
const uint32_t RS_NET_NEEDS_RESET =     0x0000;
/libretroshare/src/pqi/p3peermgr.cc:54: warning: unused variable
'RS_NET_UNKNOWN' [-Wunused-const-variable]
const uint32_t RS_NET_UNKNOWN =         0x0001;
/libretroshare/src/pqi/p3peermgr.cc:55: warning: unused variable
'RS_NET_UPNP_INIT' [-Wunused-const-variable]
const uint32_t RS_NET_UPNP_INIT =       0x0002;
/libretroshare/src/pqi/p3peermgr.cc:56: warning: unused variable
'RS_NET_UPNP_SETUP' [-Wunused-const-variable]
const uint32_t RS_NET_UPNP_SETUP =      0x0003;
/libretroshare/src/pqi/p3peermgr.cc:57: warning: unused variable
'RS_NET_EXT_SETUP' [-Wunused-const-variable]
const uint32_t RS_NET_EXT_SETUP =       0x0004;
/libretroshare/src/pqi/p3peermgr.cc:58: warning: unused variable
'RS_NET_DONE' [-Wunused-const-variable]
const uint32_t RS_NET_DONE =            0x0005;
/libretroshare/src/pqi/p3peermgr.cc:59: warning: unused variable
'RS_NET_LOOPBACK' [-Wunused-const-variable]
const uint32_t RS_NET_LOOPBACK =        0x0006;
/libretroshare/src/pqi/p3peermgr.cc:60: warning: unused variable
'RS_NET_DOWN' [-Wunused-const-variable]
const uint32_t RS_NET_DOWN =            0x0007;
/libretroshare/src/pqi/p3peermgr.cc:62: warning: unused variable
'MIN_TIME_BETWEEN_NET_RESET' [-Wunused-const-variable]
const uint32_t MIN_TIME_BETWEEN_NET_RESET =             5;
/libretroshare/src/pqi/p3peermgr.cc:64: warning: unused variable
'PEER_IP_CONNECT_STATE_MAX_LIST_SIZE' [-Wunused-const-variable]
const uint32_t PEER_IP_CONNECT_STATE_MAX_LIST_SIZE =            4;
2017-07-16 21:31:41 +02:00
Phenom
4152a46ad8 Fix clang warning: unused variable 'P3CONNMGR_UDP_DEFAULT_DELAY'
/libretroshare/src/pqi/p3linkmgr.cc:78: warning: unused variable
'P3CONNMGR_UDP_DEFAULT_DELAY' [-Wunused-const-variable]
const uint32_t P3CONNMGR_UDP_DEFAULT_DELAY = 3; /* 2 Seconds? is it be
enough! */
2017-07-16 21:31:11 +02:00
Phenom
5b1323e31f Fix clang warning: unused variables 'PQI_HANDLER_NB_PRIORITY_LEVELS',
...

/libretroshare/src/pqi/pqihandler.cc:71: warning: unused variable
'PQI_HANDLER_NB_PRIORITY_LEVELS' [-Wunused-const-variable]
static const int PQI_HANDLER_NB_PRIORITY_LEVELS = 10 ;
/libretroshare/src/pqi/pqihandler.cc:72: warning: unused variable
'PQI_HANDLER_NB_PRIORITY_RATIO' [-Wunused-const-variable]
static const float PQI_HANDLER_NB_PRIORITY_RATIO = 2 ;
2017-07-16 21:30:31 +02:00
Phenom
9148fa6645 Fix clang warning: unused variables 'RS_NET_DOWN', ...
/libretroshare/src/pqi/p3netmgr.cc:60: warning: unused variable
'RS_NET_DOWN' [-Wunused-const-variable]
const uint32_t RS_NET_DOWN =            0x0007;
/libretroshare/src/pqi/p3netmgr.cc:63: warning: unused variable
'RS_STUN_DHT' [-Wunused-const-variable]
const uint32_t RS_STUN_DHT =            0x0001;
/libretroshare/src/pqi/p3netmgr.cc:64: warning: unused variable
'RS_STUN_DONE' [-Wunused-const-variable]
const uint32_t RS_STUN_DONE =           0x0002;
/libretroshare/src/pqi/p3netmgr.cc:65: warning: unused variable
'RS_STUN_LIST_MIN' [-Wunused-const-variable]
const uint32_t RS_STUN_LIST_MIN =       100;
/libretroshare/src/pqi/p3netmgr.cc:66: warning: unused variable
'RS_STUN_FOUND_MIN' [-Wunused-const-variable]
const uint32_t RS_STUN_FOUND_MIN =      10;
/libretroshare/src/pqi/p3netmgr.cc:70: warning: unused variable
'MAX_NETWORK_INIT' [-Wunused-const-variable]
const uint32_t MAX_NETWORK_INIT =       70; /* timeout before network
reset */
/libretroshare/src/pqi/p3netmgr.cc:72: warning: unused variable
'MIN_TIME_BETWEEN_NET_RESET' [-Wunused-const-variable]
const uint32_t MIN_TIME_BETWEEN_NET_RESET =             5;
2017-07-16 21:18:22 +02:00
Phenom
e4616c09bc Fix clang warning: unused variable 'STORE_KEY_TIMEOUT'
/libretroshare/src/pqi/authgpg.cc:51: warning: unused variable
'STORE_KEY_TIMEOUT' [-Wunused-const-variable]
const time_t STORE_KEY_TIMEOUT = 1 * 60 * 60; //store key is call around
every hour
2017-07-16 21:17:52 +02:00
Phenom
0479ec07ab Fix clang warning: unused variable 'MAX_MESSAGES_PER_SECONDS_NUMBER'
/libretroshare/src/chat/distributedchat.cc:57: warning: unused variable
'MAX_MESSAGES_PER_SECONDS_NUMBER' [-Wunused-const-variable]
static const uint32_t MAX_MESSAGES_PER_SECONDS_NUMBER     =  5 ; // max
number of messages from a given peer in a window for duration below
2017-07-16 21:17:06 +02:00
Phenom
80ea4de7be Fix clang warning: unused variable 'ftserverzone'
/libretroshare/src/ft/ftserver.cc:34: warning: unused variable
'ftserverzone' [-Wunused-const-variable]
const int ftserverzone = 29539;
2017-07-16 21:16:30 +02:00
Phenom
8a270af519 fixed merging problem 2017-07-16 21:15:26 +02:00
Phenom
35186c4054 Fix clang warning: unused variable 'res'
/libretroshare/src/crypto/chacha20.cpp:978: warning: unused variable
'res' [-Wunused-variable]
        uint256_32 res(q1) ;
2017-07-16 21:12:09 +02:00
Phenom
7f1e23085d Fix clang warning: unused variable 'FT_TM_CRC_MAP_MAX_WAIT_PER_GIG', ...
/libretroshare/src/ft/fttransfermodule.cc:56: warning: unused variable
'FT_TM_CRC_MAP_MAX_WAIT_PER_GIG' [-Wunused-const-variable]
const uint32_t FT_TM_CRC_MAP_MAX_WAIT_PER_GIG = 20; /* 20 seconds per
gigabyte */
/libretroshare/src/ft/fttransfermodule.cc:65: warning: unused variable
'FT_TM_FAST_RTT' [-Wunused-const-variable]
const int32_t FT_TM_FAST_RTT    = 1.0;
/libretroshare/src/ft/fttransfermodule.cc:66: warning: unused variable
'FT_TM_STD_RTT' [-Wunused-const-variable]
const int32_t FT_TM_STD_RTT     = 5.0;
/libretroshare/src/ft/fttransfermodule.cc:67: warning: unused variable
'FT_TM_SLOW_RTT' [-Wunused-const-variable]
const int32_t FT_TM_SLOW_RTT    = 20.0;
/libretroshare/src/ft/fttransfermodule.cc:69: warning: unused variable
'FT_TM_CRC_MAP_STATE_NOCHECK' [-Wunused-const-variable]
const uint32_t FT_TM_CRC_MAP_STATE_NOCHECK      = 0 ;
/libretroshare/src/ft/fttransfermodule.cc:70: warning: unused variable
'FT_TM_CRC_MAP_STATE_DONT_HAVE' [-Wunused-const-variable]
const uint32_t FT_TM_CRC_MAP_STATE_DONT_HAVE = 1 ;
/libretroshare/src/ft/fttransfermodule.cc:71: warning: unused variable
'FT_TM_CRC_MAP_STATE_HAVE' [-Wunused-const-variable]
const uint32_t FT_TM_CRC_MAP_STATE_HAVE                 = 2 ;
2017-07-16 21:11:47 +02:00
Phenom
8b99c80e07 Fix clang warning: 'p3GxsTrans' defined as a class here but previously
declared as a struct

/libretroshare/src/gxstrans/p3gxstrans.h:88: warning: 'p3GxsTrans'
defined as a class here but previously declared as a struct [-
Wmismatched-tags]
class p3GxsTrans : public RsGenExchange, public GxsTokenQueue, public
p3Config, public RsGxsTrans
/libretroshare/src/gxstrans/p3gxstrans.h:31: did you mean class here?
struct p3GxsTrans;
2017-07-16 21:11:10 +02:00
Phenom
c97269bed6 Fix warning: this statement may fall through
/libretroshare/src/gxstrans/p3gxstrans.cc:870: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   pr.sent_ts = time(NULL) ; //pr.mailItem.meta.mPublishTs = time(NULL);
/libretroshare/src/gxstrans/p3gxstrans.cc:872: here
  case GxsTransSendStatus::PENDING_PREFERRED_GROUP:

/libretroshare/src/gxstrans/p3gxstrans.cc:883: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   pr.group_id = mPreferredGroupId ; //pr.mailItem.meta.mGroupId =
mPreferredGroupId;
/libretroshare/src/gxstrans/p3gxstrans.cc:885: here
  case GxsTransSendStatus::PENDING_RECEIPT_CREATE:

/libretroshare/src/gxstrans/p3gxstrans.cc:906: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   pr.presignedReceipt.msg.setBinData(&grsrz[0], grsz);
/libretroshare/src/gxstrans/p3gxstrans.cc:908: here
  case GxsTransSendStatus::PENDING_RECEIPT_SIGNATURE:     // (cyril)
This step is never actually used.

/libretroshare/src/gxstrans/p3gxstrans.cc:924: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   pr.presignedReceipt.meta.setBinData(&srx[0], metaSize);
/libretroshare/src/gxstrans/p3gxstrans.cc:926: here
  case GxsTransSendStatus::PENDING_PAYLOAD_CREATE:

/libretroshare/src/gxstrans/p3gxstrans.cc:938: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   memcpy(&pr.mailItem.payload[offset], &pr.mailData[0], datasize);
/libretroshare/src/gxstrans/p3gxstrans.cc:940: here
  case GxsTransSendStatus::PENDING_PAYLOAD_ENCRYPT:

/libretroshare/src/gxstrans/p3gxstrans.cc:982: warning: this statement
may fall through [-Wimplicit-fallthrough=]
   }
/libretroshare/src/gxstrans/p3gxstrans.cc:984: here
  case GxsTransSendStatus::PENDING_PUBLISH:
2017-07-16 20:47:45 +02:00
Phenom
18139489cf Fix warning: unused parameter ‘grpItem’ and unused debug variables
/libretroshare/src/gxstrans/p3gxstrans.cc:635: warning: unused parameter
‘grpItem’ [-Wunused-parameter]
         RsGxsGrpItem* grpItem, RsTlvSecurityKeySet& /*keySet*/ )

/libretroshare/src/gxstrans/p3gxstrans.cc:681: warning: unused variable
‘msgId’ [-Wunused-variable]
      const RsGxsMessageId& msgId = *vit;

/libretroshare/src/gxstrans/p3gxstrans.cc:676: warning: unused variable
‘grpId’ [-Wunused-variable]
     const RsGxsGroupId& grpId = it->first;
2017-07-16 20:46:55 +02:00
Phenom
e1ea92d733 Fix warning: unused parameter ‘n’
/libretroshare/src/serialiser/rstypeserializer.cc:358: warning: unused
parameter ‘n’ [-Wunused-parameter]
 template<> void RsTypeSerializer::print_data( const std::string& n,
2017-07-16 20:41:24 +02:00
Phenom
f193af2865 Fix warning: unused parameter ‘size’
/libretroshare/src/gxs/rsgenexchange.cc:3079: warning: unused parameter
‘size’ [-Wunused-parameter]
 bool RsGenExchange::acceptNewMessage(const RsGxsMsgMetaData* /
*grpMeta*/,uint32_t size ) { return true; }
2017-07-16 20:41:01 +02:00
Phenom
d8b0b5222b Fix warning: variable ‘it’ set but not used
/libretroshare/src/gxs/rsgxsnetservice.cc:867: warning: variable ‘it’
set but not used [-Wunused-but-set-variable]
     std::map<RsGxsGroupId,RsGxsServerMsgUpdate>::iterator it =
mServerMsgUpdateMap.find(grpId) ;

/libretroshare/src/gxs/rsgxsnetservice.cc:2434: warning: variable ‘it’
set but not used [-Wunused-but-set-variable]
             ClientGrpMap::iterator it =
mClientGrpUpdateMap.find(peerFrom);
2017-07-16 20:40:31 +02:00
Phenom
b11022a239 Fix warning: this statement may fall through
/libretroshare/src/util/dnsresolver.cc:49: warning: this statement may
fall through [-Wimplicit-fallthrough=]
       case DNSResolver::DNS_LOOKUP_ERROR:  if(it-
>second.last_lookup_time + MAX_TIME_BEFORE_RETRY > now)
/libretroshare/src/util/dnsresolver.cc:52: here
       case DNSResolver::DNS_DONT_HAVE:   next_call = it->first ;
2017-07-16 20:38:43 +02:00
Phenom
0e302e254e Fix warning: this statement may fall through
/libretroshare/src/util/rsnet_ss.cc:1031: warning: this statement may
fall through [-Wimplicit-fallthrough=]
   success = inet_ntop( addr.ss_family, (const void *) &(addrv4p-
>sin_addr), ipStr, INET_ADDRSTRLEN );
/libretroshare/src/util/rsnet_ss.cc:1033: here
  case AF_INET6:
2017-07-16 20:36:16 +02:00
Phenom
7b4d3c5a24 Fix warning: this statement may fall through
/libretroshare/src/util/rscompress.cc:165: warning: this statement may
fall through [-Wimplicit-fallthrough=]
      ret = Z_DATA_ERROR;     /* and fall through */
/home/phenom/GIT/RetroShare/trunk/libretroshare/src/util/rscompress.cc:
166: here
     case Z_DATA_ERROR:
2017-07-16 20:34:38 +02:00
Phenom
476b581506 Fix warning: this statement may fall through
/libretroshare/src/rsserver/p3serverconfig.cc:292: warning: this
statement may fall through [-Wimplicit-fallthrough=]
    if (mPeerMgr->getFriendCount(true, false) > MIN_BASIC_FRIENDS)
/libretroshare/src/rsserver/p3serverconfig.cc:297: here
   case RSCONFIG_USER_LEVEL_BASIC:

/libretroshare/src/rsserver/p3serverconfig.cc:300: warning: this
statement may fall through [-Wimplicit-fallthrough=]
    if (mPeerMgr->haveOnceConnected())
/libretroshare/src/rsserver/p3serverconfig.cc:306: here
   case RSCONFIG_USER_LEVEL_CASUAL:
2017-07-16 20:33:55 +02:00
Phenom
7bd7c57ff9 Fix warning: variable ‘pgpNameFound’ set but not used
/libretroshare/src/rsserver/rsaccounts.cc:130: warning: variable
‘pgpNameFound’ set but not used [-Wunused-but-set-variable]
  bool pgpNameFound = false;
2017-07-16 20:32:32 +02:00
Phenom
a0506c1a0f Fix warning: this statement may fall through
/libretroshare/src/pqi/pqissl.cc:449: warning: this statement may fall
through [-Wimplicit-fallthrough=]
    sslmode = PQISSL_ACTIVE; /* we're starting this one */
/libretroshare/src/pqi/pqissl.cc:456: here
   case WAITING_DELAY:
2017-07-16 20:31:49 +02:00
Phenom
b9d4651f07 Fix warning: this statement may fall through
/libretroshare/src/pqi/pqisslpersongrp.cc:125: warning: this statement
may fall through [-Wimplicit-fallthrough=]
     std::cerr << " --> falling back to Tor" << std::endl;
/libretroshare/src/pqi/pqisslpersongrp.cc:126: here
    case RS_HIDDEN_TYPE_TOR:
2017-07-16 20:30:41 +02:00
Phenom
e12f51b1be Fix warning: variable ‘peerIt1’ set but not used
/libretroshare/src/pqi/p3peermgr.cc:2619: warning: variable ‘peerIt1’
set but not used [-Wunused-but-set-variable]
                     std::set<RsPgpId>::iterator peerIt1 =
groupItem.peerIds.find(*peerIt);
2017-07-16 20:28:24 +02:00
Phenom
78cfde9b4f Fix warning: this statement may fall through
/libretroshare/src/pgp/pgphandler.cc:62: warning: this statement may
fall through [-Wimplicit-fallthrough=]
   case OPS_PARSER_CMD_GET_SK_PASSPHRASE_PREV_WAS_BAD: prev_was_bad =
true ;

/libretroshare/src/pgp/pgphandler.cc:63: here
   case OPS_PARSER_CMD_GET_SK_PASSPHRASE:
2017-07-16 20:27:46 +02:00
Phenom
3a6ad822da Fix warning: this statement may fall through
/libretroshare/src/ft/ftchunkmap.cc:190: warning: this statement may
fall through [-Wimplicit-fallthrough=]
    case FileChunksInfo::CHUNK_CHECKING: _file_is_complete = false ;

/libretroshare/src/ft/ftchunkmap.cc:191: here
    case FileChunksInfo::CHUNK_DONE:   _total_downloaded +=
sizeOfChunk(i) ;
2017-07-16 20:27:09 +02:00
Phenom
635246c462 Fix warning: this statement may fall through
/libretroshare/src/tcponudp/bss_tou.c:246: warning: this statement may
fall through [-Wimplicit-fallthrough=]
   num=0;

/libretroshare/src/tcponudp/bss_tou.c:247: here
  case BIO_C_FILE_SEEK:
2017-07-16 20:25:11 +02:00
Phenom
59e018e02d Fix GUI AutoLogin 2017-07-16 16:03:56 +02:00
csoler
08faa3f5d5 fixed p3Gxstunnel so that it sends the data packets in the same order it received them. This fixes the bug in distant chat causing images to not transfer correctly in some cases 2017-07-15 22:16:45 +02:00
csoler
9c391cb015 added an additional param to BinToHex so as to limit the size of the output 2017-07-15 22:15:51 +02:00
csoler
98b0585ba4 Merge pull request #937 from csoler/v0.6-ImprovedNoGUI
V0.6 improved no gui
2017-07-13 21:23:13 +02:00
Gioacchino Mazzurco
69aa5b6a09 Clean some garbage from the code 2017-07-13 13:00:32 +02:00
csoler
fd452af088 removed some debut output that perturbated the passwd command line 2017-07-12 23:03:17 +02:00
csoler
00c1a9a7ff fixed autologin 2017-07-12 22:53:35 +02:00
csoler
66268c8267 fixed variable shadowing a parameter 2017-07-12 18:48:06 +02:00
csoler
4cfdef5ff9 do not display auto-login option when software is compiled without autologin 2017-07-11 23:39:04 +02:00
csoler
a5e0b1c336 fixed -U option in rs-nogui. Removed debug output that would ruin the terminal interface 2017-07-11 23:32:22 +02:00
csoler
3e3ee1a34b little improvement to command line help display 2017-07-09 22:12:01 +02:00
csoler
5dfbce7e3a fixed Terminal Api Client logic 2017-07-09 21:16:41 +02:00
csoler
7ee527ecbd removed comments 2017-07-08 17:35:34 +02:00
csoler
b5976e195e fixed message when passphrase is empty 2017-07-08 16:48:24 +02:00
Phenom
54047cd7a7 Fix multi download of same file. 2017-07-06 22:38:08 +02:00
Gioacchino Mazzurco
c630f1fa89 Fix unused warning in gxstokenqueue 2017-07-06 16:28:59 +02:00
Gioacchino Mazzurco
b935bacd99 Add missing break in p3IdService::handleResponse 2017-07-06 16:28:00 +02:00
csoler
141277b131 removed debug info 2017-07-05 22:16:14 +02:00
csoler
c1e18c7fe6 fixed bug causing an infinite subscribe/unsubscribe loop in GxsTrans 2017-07-05 22:12:56 +02:00
csoler
370d50b41a cleaned a bit the code in rsinit.cc 2017-07-05 21:36:00 +02:00
cyril soler
f413433480 removed zeroing of preferred group causing a bug in GxsTrans 2017-07-03 11:25:12 +02:00
csoler
1b4e8a46ed Merge pull request #909 from csoler/v0.6-GxsTransport
V0.6 gxs transport
2017-06-29 18:38:10 +02:00
csoler
64e3fc97e8 fixed bug preventing correct subscribe in GxsTrans 2017-06-29 18:37:39 +02:00
csoler
700d114cf4 fixed bug causing failure of group autosubscribe in GxsTrans 2017-06-29 18:27:00 +02:00
Phenom
b4071d158e Add General Direct Download setting.
Yes, No, Per User
2017-06-29 17:18:28 +02:00
csoler
37edcc1e37 fixed subscribe policy to GxsTrans groups as a function of last available post and group usage 2017-06-29 13:44:40 +02:00
csoler
dc605c02f1 added a last modif TS in GrpNetworkStats, that is inited from network Grp statistics, and used to provide a value for unsubscribed groups 2017-06-29 13:15:39 +02:00
csoler
533e2a8b45 added check to fix existing wrong storage time value in GxsTrans 2017-06-28 23:23:27 +02:00
csoler
f37ba83c07 moved msg keep period settings to netService and made the initialisation obei the default settings of the service 2017-06-28 23:12:33 +02:00
csoler
12b562893d added more debug info in GxsUtil 2017-06-27 22:21:35 +02:00
csoler
51c7e18a3a added last msg time in GxsTrans stats. Added mutex to protect non atomic mPreferredGroup 2017-06-27 19:56:21 +02:00
csoler
2bb49f6925 Merge pull request #898 from csoler/v0.6-GxsTransport
fixed memory leak in GxsTrans
2017-06-23 21:58:54 +02:00
csoler
0f99647a86 fixed memory leak in GxsTrans 2017-06-23 21:58:17 +02:00
csoler
0133be757a Merge pull request #887 from csoler/v0.6-GxsTransport
V0.6 gxs transport
2017-06-17 23:07:10 +02:00
csoler
12a45294a3 added ifdef for comments on GxsTrans 2017-06-17 23:02:28 +02:00
csoler
eb4bb5be65 fixed bug in gxs trans stats counting 2017-06-17 21:42:00 +02:00
csoler
43dcddce67 Merge pull request #880 from PhenomRetroShare/Add_GxsCircleNotify
Add Circle Feed Item.
2017-06-16 12:37:09 +02:00
csoler
a29bc4408e Merge pull request #874 from G10h4ck/silent_initiate_distant_chat_api
libresapi: silent /chat/initiate_distant_chat
2017-06-16 12:24:45 +02:00
csoler
25565a7ecd merged upstream/master 2017-06-15 23:58:29 +02:00
csoler
6633b04a44 changed constants for GxsTransport anti-spam 2017-06-15 23:57:02 +02:00
csoler
26bb865d29 added code to reject messages based on existing per-user statistics 2017-06-15 19:32:31 +02:00
sehraf
fe5ec8bda8 reduce BOB log level 2017-06-15 07:06:52 +02:00
csoler
09ff94c9ec added new virtual method to refuse incoming msgs (similar to groups) in RsGenExchange, and used it in p3GxsTrans to refuse msgs from peers who send too much 2017-06-14 23:19:52 +02:00
csoler
79825eb2e2 fixed thread issue in RsGxsCleanupThread that caused random crashes 2017-06-12 20:36:02 +02:00
Phenom
aa64c4d3c5 Add Circle Feed Item. 2017-06-11 16:16:41 +02:00
csoler
1766087f71 fixed update notification and display in GxsTransStatistics 2017-06-07 23:10:59 +02:00
csoler
9853b53f8b fixed debug output in GxsNetService 2017-06-07 23:10:24 +02:00
csoler
4cb7522feb added deleted gxs messages to the reject list of GxsNetService to avoid re-downloading them right away 2017-06-07 21:41:00 +02:00
csoler
23156ab4b1 fixed malloc problem when chat avatar is missing 2017-06-07 20:14:27 +02:00
cyril soler
e726bd1061 attempt to fix the crash in DataStore by not calling deleteMsgs directly 2017-06-07 13:37:55 +02:00