Syscall param write(buf) points to uninitialised byte(s)
in PGPHandler::locked_writePrivateTrustDatabase() in /libretroshare/
src/pgp/pgphandler.cc:1885
1: write in /usr/lib/libc-2.32.so
2: _IO_file_write@@GLIBC_2.2.5 in /usr/lib/libc-2.32.so
3: new_do_write in /usr/lib/libc-2.32.so
4: _IO_do_write@@GLIBC_2.2.5 in /usr/lib/libc-2.32.so
5: _IO_file_close_it@@GLIBC_2.2.5 in /usr/lib/libc-2.32.so
6: fclose@@GLIBC_2.2.5 in /usr/lib/libc-2.32.so
7: PGPHandler::locked_writePrivateTrustDatabase() in /libretroshare/
src/pgp/pgphandler.cc:1885
8: PGPHandler::locked_syncTrustDatabase() in /libretroshare/src/pgp/
pgphandler.cc:1987
9: PGPHandler::syncDatabase() in /libretroshare/src/pgp/pgphandler.cc:
1909
10: AuthGPG::threadTick() in /libretroshare/src/pqi/authgpg.cc:207
11: RsTickingThread::run() in /libretroshare/src/util/rsthreads.h:314
12: RsThread::wrapRun() in /libretroshare/src/util/rsthreads.cc:116
13: RsThread::rsthread_init(void*) in /libretroshare/src/util/
rsthreads.cc:84
14: start_thread in /usr/lib/libpthread-2.32.so
15: clone in /usr/lib/libc-2.32.so
Address 0xcb70379 is 9 bytes inside a block of size 4,096 alloc'd 1:
malloc in /build/valgrind/src/valgrind-3.16.1/coregrind/m_replacemalloc/
vg_replace_malloc.c:307
2: _IO_file_doallocate in /usr/lib/libc-2.32.so
3: _IO_doallocbuf in /usr/lib/libc-2.32.so
4: _IO_file_overflow@@GLIBC_2.2.5 in /usr/lib/libc-2.32.so
5: _IO_file_xsputn@@GLIBC_2.2.5 in /usr/lib/libc-2.32.so
6: fwrite in /usr/lib/libc-2.32.so
7: PGPHandler::locked_writePrivateTrustDatabase() in /libretroshare/
src/pgp/pgphandler.cc:1877
8: PGPHandler::locked_syncTrustDatabase() in /libretroshare/src/pgp/
pgphandler.cc:1987
9: PGPHandler::syncDatabase() in /libretroshare/src/pgp/pgphandler.cc:
1909
10: AuthGPG::threadTick() in /libretroshare/src/pqi/authgpg.cc:207
11: RsTickingThread::run() in /libretroshare/src/util/rsthreads.h:314
12: RsThread::wrapRun() in /libretroshare/src/util/rsthreads.cc:116
13: RsThread::rsthread_init(void*) in /libretroshare/src/util/
rsthreads.cc:84
14: start_thread in /usr/lib/libpthread-2.32.so
15: clone in /usr/lib/libc-2.32.so
Uninitialised value was created by a stack allocation 1:
PGPHandler::locked_writePrivateTrustDatabase() in /libretroshare/src/
pgp/pgphandler.cc:1855
Fix missing RsDiscPgpKeyItem initialization
Fix inconsistent new[]/delete[] usage in RsDiscPgpKeyItem and
PGPHandler::exportPublicKey which now consistently uses malloc/free
Remove deprecated RsGenericSerializer::FORMAT_*
Move from deprecated RsServiceSerializer::SERIALIZATION_FLAG_* to
RsSerializationFlags
Solve a bunch of compiler warnings
Stricter checks in SerializeContext costructor
Deprecate unsafe costructor, substituted by fromBufferUnsafe which explicitely
marked suggest the caller to pay attention.
Use enum class for id types instead of constants
Make size constants more private
Use internal Id_t alias to avoid huge template lines
Remove and deprecate oguly names in favor of consistent names
Avoid problems to serialization on different platforms, without breaking
nested STL containers serialization.
The conversion have been made with sed, and checked with grep, plus
kdiff3 visual ispection, plus rutime tests, so it should be fine.
jsonapi-generator is now capable of generating API for headers outside
retroshare/ directory
jsonapi-generator do a bit of methods parameter sanity check
JsonApiServer is now integrated in the rsinit hell like other services
Add *::exportGPGKeyPairToString to a bunch of classes in cascade
RsControl is now capable of calling back a function when retroshare is almost
completely stopped, this is useful when running retroshare toghether with
externally managed runloop such as QCoreApplication
Expose a bunch of methods through JSON API
retroshare-nogui remove some dead code and fix stopping from the RetroShare API
/libretroshare/src/pgp/pgphandler.cc:62: warning: this statement may
fall through [-Wimplicit-fallthrough=]
case OPS_PARSER_CMD_GET_SK_PASSPHRASE_PREV_WAS_BAD: prev_was_bad =
true ;
/libretroshare/src/pgp/pgphandler.cc:63: here
case OPS_PARSER_CMD_GET_SK_PASSPHRASE:
These split at 6672 -> 7075, so quite a bit merge.
libretroshare compiles - but untested.
retroshare-gui needs GenCertDialog.ui and IdEditDialog.ui to be properly merged. (compile errors).
some plugins will be broken.
retroshare-nogui is untested.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7078 b45a01b8-16f6-495d-af2f-9b41ad6348cc
The static arrays in RsDiscSpace were to small for RS_PGP_DIRECTORY (0x0003)
Added new constant RS_DIRECTORY_COUNT
- Added missing fclose to PGPHandler::encryptTextToFile
Used ops_teardown_file_write instead of ops_writer_close and ops_create_info_delete
Windows cannot move a file when it is still open
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@6542 b45a01b8-16f6-495d-af2f-9b41ad6348cc
- copy files to tmp before appending new keys, then rename back to original.
- always check for disk full before syncing keyrings
- use tmp file to sync keyring
- new RsDirUtil::fileExists() method
- check system for disk space in pgp directory
- added RsPGPDirectory() method to RsInit
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@6541 b45a01b8-16f6-495d-af2f-9b41ad6348cc
