Commit Graph

152 Commits

Author SHA1 Message Date
Gioacchino Mazzurco
9281a5966b
p3Peers::getPeerDetails retrocompatible IPv4 format 2018-02-25 12:48:55 +01:00
Phenom
73d11e1857
Fix Gcc Warning in nxsmsgsync_test.cc
/trunk/tests/unittests/libretroshare/gxs/nxs_test/nxsmsgsync_test.cc:28:
warning: deleting object of abstract class type ‘RsGixsReputation’ which
has non-virtual destructor will cause undefined behavior [-Wdelete-non-
virtual-dtor]
  delete mRep ;
/trunk/tests/unittests/libretroshare/gxs/nxs_test/nxsmsgsync_test.cc:29:
warning: deleting object of abstract class type ‘RsGcxs’ which has non-
virtual destructor will cause undefined behavior [-Wdelete-non-virtual-
dtor]
  delete mCircles;
/trunk/tests/unittests/libretroshare/gxs/nxs_test/nxsmsgsync_test.cc:30:
warning: deleting object of abstract class type ‘PgpAuxUtils’ which has
non-virtual destructor will cause undefined behavior [-Wdelete-non-
virtual-dtor]
  delete mPgpUtils;
2018-02-20 23:28:48 +01:00
csoler
9367aa0d84 changed #ifs into #ifdefs because it us more robust, and moved the definition of variables to retroshare.pri 2017-11-19 20:15:36 +01:00
csoler
863e6256c3 centralized the defines into a single file 2017-11-19 19:34:54 +01:00
csoler
b4fdd4e0d0 added two additional non packward compatible changes for future version 0.7, and improvements of verifications of certificate signatures 2017-11-19 18:21:56 +01:00
Phenom
60d476211f Fix CppCheck in rscertificate.h
/libretroshare/src/pgp/rscertificate.cc:75: warning:
Cppcheck(unusedVariable): Unused variable: res
/libretroshare/src/pgp/rscertificate.h:55: warning:
Cppcheck(operatorEqVarError): Member variable
'RsCertificate::ipv4_external_ip_and_port' is not assigned a value in
'RsCertificate::operator='.
/libretroshare/src/pgp/rscertificate.h:55: warning:
Cppcheck(operatorEqVarError): Member variable
'RsCertificate::ipv4_internal_ip_and_port' is not assigned a value in
'RsCertificate::operator='.
/libretroshare/src/pgp/rscertificate.h:55: warning:
Cppcheck(operatorEqVarError): Member variable
'RsCertificate::binary_pgp_key' is not assigned a value in
'RsCertificate::operator='.
/libretroshare/src/pgp/rscertificate.h:55: warning:
Cppcheck(operatorEqVarError): Member variable
'RsCertificate::binary_pgp_key_size' is not assigned a value in
'RsCertificate::operator='.
/libretroshare/src/pgp/rscertificate.h:55: warning:
Cppcheck(operatorEqVarError): Member variable 'RsCertificate::only_pgp'
is not assigned a value in 'RsCertificate::operator='.
/libretroshare/src/pgp/rscertificate.h:55: warning:
Cppcheck(operatorEqVarError): Member variable
'RsCertificate::hidden_node' is not assigned a value in
'RsCertificate::operator='.
/libretroshare/src/pgp/rscertificate.h:16: warning:
Cppcheck(noExplicitConstructor): Class 'RsCertificate' has a constructor
with 1 argument that is not explicit.
2017-11-05 18:19:10 +01:00
Phenom
f91756a1bb Fix CppCheck in pgphandler.h
/libretroshare/src/pgp/pgphandler.cc:1277: warning:
Cppcheck(funcArgOrderDifferent): Function 'decryptDataBin' argument
order different: declaration 'key_id, data, len, decrypted_data,
decrypted_data_len' definition ', encrypted_data, encrypted_len, data,
data_len'
2017-11-05 18:17:48 +01:00
Phenom
78cfde9b4f Fix warning: this statement may fall through
/libretroshare/src/pgp/pgphandler.cc:62: warning: this statement may
fall through [-Wimplicit-fallthrough=]
   case OPS_PARSER_CMD_GET_SK_PASSPHRASE_PREV_WAS_BAD: prev_was_bad =
true ;

/libretroshare/src/pgp/pgphandler.cc:63: here
   case OPS_PARSER_CMD_GET_SK_PASSPHRASE:
2017-07-16 20:27:46 +02:00
csoler
7da68ff72d improved certificate parsing in Home so that corrupted certs never get accepted 2017-01-22 21:44:26 +01:00
Phenom
674b6de381 Fix Some gcc warnings 383 to 208 lines
Left explicit #warning and deprecated.
Some lines are wrong indented and produce mal formed code.
2016-11-30 22:01:01 +01:00
csoler
368a429846 fixed read_125Size and write_125Size according to RFC4880 2016-08-17 09:40:16 +02:00
Phenom
38a9e10096 Fix RsCertificate::toStdString by fixing PGPKeyParser::read_125Size.
And added some comments, plus values in hexadecimal for better view.
2016-08-15 20:00:49 +02:00
csoler
ab82c4a73c added missing return in PGPKeyUtil, causing corruption of keys in some--possible rare--situations 2016-08-12 18:58:35 +02:00
Phenom
275c47eff9 Add Title when ask for password. 2016-08-09 01:22:14 +02:00
Phenom
005af47fe9 Fix Compilation when mkstemp is not defined. 2016-06-01 22:37:05 +02:00
Cyril Soler
dafb2e6bc2 Merge pull request #396 from csoler/v0.6-Circles
V0.6 circles
2016-05-27 17:35:23 -04:00
anon tahoe
abe0e02910 replaced mktemp by mkstemp (cherry-picked from anontahoe repository) 2016-05-18 21:29:55 -04:00
csoler
2591e3ff25 changed prototype of Radix encoding to take unsigned char* instead of char* 2016-05-10 22:17:48 -04:00
csoler
fa8a585e20 removed some debug info 2016-04-15 18:25:53 -04:00
csoler
9d9b790a3e exposed un-verified PGP signatures on GXS ids in GUI. Added auto-ban of GXS ids signed by a PGP ids that has already signed a large enough set of GXS ids. Still needs some GUI to change the threshold. 2016-04-02 16:14:18 -04:00
csoler
d55993d1e4 removed two instances of malloc(0) captured by new rs_malloc funtion 2016-01-12 21:43:04 -05:00
csoler
d13526facd added a new method rs_malloc that checks its arguments and prints a stacktrace on error/weird call. Changed the code everywhere to use this instead of malloc. Removed some mallocs and replaced with RsTemporaryMemory 2016-01-12 21:10:11 -05:00
csoler
9c6e7dfc13 added checks after mallocs in several files 2016-01-11 23:49:00 -05:00
csoler
22d4893721 removed a few compilation warning that might cause compilation errors on some systems 2015-09-24 18:03:19 -04:00
thunder2
c76141ed65 Added missing initialization in
- pqissl
- pqissludp
- PeerConnectStateBox
- RsTlvBanListEntry
- RsServer
- TcpStream
- PGPCertificateInfo
- peerConnectAddress
- AudioInputConfig
- SpeexInputProcessor
- xProgressBar
- TBoard

Removed unused member:
- xProgressBar


git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8611 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-07-13 11:03:18 +00:00
electron128
13355a7efe changed Radix64::decode to return result as std::vector
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8520 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-06-18 13:45:08 +00:00
electron128
15bb95a398 fixed potential memory leak in pgphandler
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8509 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-06-17 09:25:55 +00:00
electron128
8fc3917c4b webui:
- added profile import/creation
- fixed leaking file descriptors
- added upload handler for small files
- fixed terminal thread
- removed some unused parameter warnings

git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8485 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-06-16 12:35:07 +00:00
csoler
f360e9d0ba fixed password handling in deferred signature algorithm (in case of cancel, enter wrong passphrase, etc)
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8423 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-06-12 21:04:11 +00:00
csoler
74c01423f0 improved login system: do not re-ask for passphrase when user clicks cancel. Removed warning stating that maybe passphrase is wrong
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8415 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-06-11 20:31:52 +00:00
csoler
258c4e4afd improved/removed debug info
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8413 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-06-11 18:47:52 +00:00
csoler
c9d5c7b3cb turned some std::list<PeerId> into std::set, as it automatically prevents duplicates
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8138 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-04-17 21:36:22 +00:00
csoler
90427eb08b fixed self-signature checking for imported keys, previously causing imported certificates with signatures to be rejected
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@8053 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-03-19 21:02:14 +00:00
csoler
8cb3ae6d2e added code to generate 3072 and 4096 bit PGP keys at startup (Patch from Serhaf)
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7841 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2015-01-12 22:02:43 +00:00
csoler
d547cb6fdb changed post fixed operator++ into prefixed. More efficient on some systems. Patch from Phenom.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7630 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-10-24 22:07:26 +00:00
drbob
23480be883 Added PgpAuxUtils to allow Mocking of Pgp functions for simulations.
Cleaned up some of the debug messages.



git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7306 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-04-27 13:14:07 +00:00
chrisparker126
0f29d28b1b merge of branch v0.6-idclean 7180
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7187 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-03-17 20:56:06 +00:00
drbob
c0738eec7f Merging branches/v0.6-initdev into trunk.
These split at 6672 -> 7075, so quite a bit merge.
libretroshare compiles - but untested.
retroshare-gui needs GenCertDialog.ui and IdEditDialog.ui to be properly merged. (compile errors).
some plugins will be broken.
retroshare-nogui is untested.



git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7078 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-02-01 14:16:15 +00:00
csoler
efd1447a84 removed code for old certificate format.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/branches/v0.6-initdev@7041 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-01-19 14:42:16 +00:00
csoler
affdd49001 made cert of versions 0.5 and 0.6 incompatible. Removed old cert format parse/display
git-svn-id: http://svn.code.sf.net/p/retroshare/code/branches/v0.6-initdev@7033 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-01-18 16:53:19 +00:00
drbob
8c8baae044 fixed bad parse of addresses in certificate.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/branches/v0.6-initdev@7032 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-01-18 05:42:44 +00:00
drbob
b741503803 Added port to hidden address.
git-svn-id: http://svn.code.sf.net/p/retroshare/code/branches/v0.6-initdev@7031 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-01-18 05:27:54 +00:00
csoler
ba927adf1c fixed small error in pgphandler, potentially adding empty certs in database
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7015 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-01-15 20:15:48 +00:00
csoler
99b9b53c62 fixed missing error handling, causing unhandled exception
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@7003 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-01-09 20:20:46 +00:00
csoler
4ce8ea73d2 moved PGP id types into rsid.h, and renamed them with a more appropriate name
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@6985 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2014-01-03 22:42:17 +00:00
csoler
98847c60b1 moved SSLIdType to rsid.h which has less dependencies
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@6968 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2013-12-27 20:01:47 +00:00
csoler
d26d6fa355 added check to only import version 4 keys in the keyring
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@6945 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2013-12-13 20:58:06 +00:00
csoler
5800069acf error handling in pgphandler.cc
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@6938 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2013-12-10 10:08:41 +00:00
csoler
3e88b54ae3 removed asserts and put proper error handling in compress.c
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@6937 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2013-12-10 09:49:13 +00:00
csoler
b2bea751aa restriction to only accept self-signed certificates for friend keys
git-svn-id: http://svn.code.sf.net/p/retroshare/code/trunk@6928 b45a01b8-16f6-495d-af2f-9b41ad6348cc
2013-12-07 14:29:46 +00:00