Commit Graph

11635 Commits

Author SHA1 Message Date
csoler
8368a764fc
Merge pull request #1110 from csoler/v0.6-FT
added toStdString() method to search strings so as to display what is…
2017-11-13 23:38:25 +01:00
csoler
5fab053fb8 added toStdString() method to search strings so as to display what is searched 2017-11-13 23:37:53 +01:00
csoler
7304c48a4a
Merge pull request #1109 from csoler/v0.6-Links2
use "download..." menu with RsCollectionDialog with multiple files an…
2017-11-13 22:32:30 +01:00
csoler
1669cd48c8 use "download..." menu with RsCollectionDialog with multiple files and directories 2017-11-13 22:08:05 +01:00
csoler
45c8e9ea96
Merge pull request #1107 from csoler/v0.6-Links2
fixed bug causing RsCollection to fail on remote files. Now using RsC…
2017-11-13 11:01:48 +01:00
csoler
5997c10495 fixed bug causing RsCollection to fail on remote files. Now using RsCollectionDialog when downloading directories from friend shared files 2017-11-12 22:46:29 +01:00
csoler
c0951b301e
Merge pull request #1040 from RetroPooh/searchmultinames2
allow multiple filenames display for a single hash in search
2017-11-12 21:33:21 +01:00
csoler
240d3a6f35
Merge pull request #1104 from RetroPooh/linkaddrtooltips
add tooltips with address to urls
2017-11-11 16:33:30 +01:00
csoler
cb7724312e
Merge pull request #1105 from RetroPooh/smallfixes1
Smallfixes1
2017-11-11 16:31:33 +01:00
RetroPooh
9b66e7e83d fix non-latin peer name display in bw stats 2017-11-10 18:32:18 +03:00
RetroPooh
792f7ff7eb fix status led icons for distant chat 2017-11-10 18:31:41 +03:00
RetroPooh
df244fd44d add tooltips with address to urls 2017-11-10 16:01:11 +03:00
csoler
7feb630c92
Merge pull request #1102 from csoler/v0.6-Links2
use of RsCollectionDialog for processing single file links. Only "ext…
2017-11-08 20:11:26 +01:00
csoler
6a8bc8baf8 use of RsCollectionDialog for processing single file links. Only "extra" links still require the older processing system because RsCollections cannot have sources for each entry 2017-11-08 18:11:46 +01:00
Phenom
ee7e950f5f Fix CppCheck in RsButtonOnText
/retroshare-gui/src/gui/common/RsButtonOnText.cpp:13: warning:
Cppcheck(uninitMemberVar): Member variable 'RSButtonOnText::_textEdit'
is not initialized in the constructor.
/retroshare-gui/src/gui/common/RsButtonOnText.cpp:13: warning:
Cppcheck(uninitMemberVar): Member variable
'RSButtonOnText::_textEditViewPort' is not initialized in the
constructor.
/retroshare-gui/src/gui/common/RsButtonOnText.cpp:13: warning:
Cppcheck(uninitMemberVar): Member variable 'RSButtonOnText::_textCursor'
is not initialized in the constructor.
/retroshare-gui/src/gui/common/RsButtonOnText.cpp:21: warning:
Cppcheck(uninitMemberVar): Member variable 'RSButtonOnText::_textEdit'
is not initialized in the constructor.
/retroshare-gui/src/gui/common/RsButtonOnText.cpp:21: warning:
Cppcheck(uninitMemberVar): Member variable
'RSButtonOnText::_textEditViewPort' is not initialized in the
constructor.
/retroshare-gui/src/gui/common/RsButtonOnText.cpp:21: warning:
Cppcheck(uninitMemberVar): Member variable 'RSButtonOnText::_textCursor'
is not initialized in the constructor.
/retroshare-gui/src/gui/common/RsButtonOnText.cpp:32: warning:
Cppcheck(uninitMemberVar): Member variable 'RSButtonOnText::_textEdit'
is not initialized in the constructor.
/retroshare-gui/src/gui/common/RsButtonOnText.cpp:32: warning:
Cppcheck(uninitMemberVar): Member variable
'RSButtonOnText::_textEditViewPort' is not initialized in the
constructor.
/retroshare-gui/src/gui/common/RsButtonOnText.cpp:32: warning:
Cppcheck(uninitMemberVar): Member variable 'RSButtonOnText::_textCursor'
is not initialized in the constructor.
2017-11-07 22:15:34 +01:00
Phenom
214e382a0a Fix CppCheck in ChatWidget.cpp
/retroshare-gui/src/gui/chat/ChatWidget.cpp:482: warning:
Cppcheck(clarifyCondition): Boolean result is used in bitwise operation.
Clarify expression with parentheses.
2017-11-07 22:14:28 +01:00
Phenom
88d84e0249 Fix CppCheck in FlowLayout.h
/retroshare-gui/src/gui/common/FlowLayout.h:77: warning:
Cppcheck(uninitMemberVar): Member variable
'FlowLayoutItem::m_isSelected' is not initialized in the constructor.
/retroshare-gui/src/gui/common/FlowLayout.h:77: warning:
Cppcheck(uninitMemberVar): Member variable 'FlowLayoutItem::m_isCurrent'
is not initialized in the constructor.
2017-11-07 22:13:44 +01:00
Phenom
25f1a919e0 Fix CppCheck in ToasterItem.h
/retroshare-gui/src/gui/toaster/ToasterItem.h:35: warning:
Cppcheck(noExplicitConstructor): Class 'ToasterItem' has a constructor
with 1 argument that is not explicit.
2017-11-07 22:13:07 +01:00
Phenom
d234b8be5e Fix CppCheck in XPathWrapper.h
/plugins/FeedReader/util/XPathWrapper.h:46: warning:
Cppcheck(noExplicitConstructor): Class 'XPathWrapper' has a constructor
with 1 argument that is not explicit.
2017-11-07 22:11:29 +01:00
Phenom
9f5d08110c Fix CppCheck in RSTextBrowser.h
/home/phenom/GIT/RetroShare/trunk/retroshare-gui/src/gui/common/
RSTextBrowser.h:11: warning: Cppcheck(noConstructor): The class
'RSTextBrowser' does not have a constructor.
2017-11-07 22:11:04 +01:00
Phenom
72b917de37 Fix CppCheck in UPnPBase.h
/libretroshare/src/upnp/UPnPBase.cpp:62: warning:
Cppcheck(funcArgOrderDifferent): Function 'CUPnPPortMapping' argument
order different: declaration 'in_port, ex_port, protocol, enabled,
description' definition 'ex_port, in_port, protocol, enabled,
description'
/libretroshare/src/upnp/UPnPBase.h:109: warning:
Cppcheck(noExplicitConstructor): Class 'CUPnPLib' has a constructor with
1 argument that is not explicit.
/libretroshare/src/upnp/UPnPBase.h:577: warning:
Cppcheck(noExplicitConstructor): Class 'CUPnPControlPoint' has a
constructor with 1 argument that is not explicit.
2017-11-07 22:04:46 +01:00
Phenom
2933861691 Fix CppCheck in p3turtle.cc
/libretroshare/src/turtle/p3turtle.cc:1450: warning:
Cppcheck(unusedVariable): Unused variable: info
/libretroshare/src/turtle/p3turtle.cc:1875: warning:
Cppcheck(redundantIfRemove): Redundant checking of STL container element
existence before removing it.
2017-11-07 22:04:10 +01:00
Phenom
2728880621 Fix CppCheck in p3postbase.cc
/libretroshare/src/services/p3postbase.cc:628: warning:
Cppcheck(invalidScanfArgType_int): %d in format string (no. 1) requires
'int *' but the argument type is 'unsigned int *'.
/libretroshare/src/services/p3postbase.cc:628: warning:
Cppcheck(invalidScanfArgType_int): %d in format string (no. 2) requires
'int *' but the argument type is 'unsigned int *'.
/libretroshare/src/services/p3postbase.cc:628: warning:
Cppcheck(invalidScanfArgType_int): %d in format string (no. 3) requires
'int *' but the argument type is 'unsigned int *'.
2017-11-07 21:59:58 +01:00
Phenom
d0eb40b08c Fix CppCheck in p3discovery2.cc
/libretroshare/src/services/p3discovery2.cc:916: warning:
Cppcheck(unreadVariable): Variable 'sit' is assigned a value that is
never used.
2017-11-07 21:59:34 +01:00
Phenom
7278f67073 Fix CppCheck in p3bwctrl.h
/libretroshare/src/services/p3bwctrl.h:77: warning:
Cppcheck(noExplicitConstructor): Class 'p3BandwidthControl' has a
constructor with 1 argument that is not explicit.
2017-11-07 21:59:04 +01:00
Phenom
9000f2e524 Fix CppCheck in p3i2pbob.h
/libretroshare/src/services/autoproxy/p3i2pbob.h:176: warning:
Cppcheck(noExplicitConstructor): Class 'p3I2pBob' has a constructor with
1 argument that is not explicit.
2017-11-07 21:58:30 +01:00
Phenom
fea9c0a851 Fix CppCheck in rstlvstring.h
/libretroshare/src/serialiser/rstlvstring.h:40: warning:
Cppcheck(noExplicitConstructor): Class 'RsTlvStringSet' has a
constructor with 1 argument that is not explicit.
2017-11-07 21:58:10 +01:00
Phenom
889f23f9d8 Fix CppCheck in rstlvidset.h
/libretroshare/src/serialiser/rstlvidset.h:93: warning:
Cppcheck(unreadVariable): Variable 'ok' is assigned a value that is
never used.
2017-11-07 21:57:39 +01:00
Phenom
371d8205d5 Fix CppCheck in rsinit.cc
/libretroshare/src/rsserver/rsinit.cc:1051: warning:
Cppcheck(unreadVariable): Variable 'mDhtStack' is assigned a value that
is never used.
2017-11-07 21:47:05 +01:00
Phenom
04125be8b1 Fix CppCheck in rsaccounts.cc
/libretroshare/src/rsserver/rsaccounts.cc:808: warning:
Cppcheck(ConfigurationNotChecked): Skipping configuration 'DATA_DIR'
since the value of 'DATA_DIR' is unknown. Use -D if you want to check
it. You can use -U to skip it explicitly.
/libretroshare/src/rsserver/rsaccounts.cc:1057: warning:
Cppcheck(redundantAssignment): Variable 'bio_out' is reassigned a value
before the old one has been used.
/libretroshare/src/rsserver/rsaccounts.cc:674: warning:
Cppcheck(unusedVariable): Unused variable: userName
/libretroshare/src/rsserver/rsaccounts.cc:1005: warning:
Cppcheck(unreadVariable): Variable 'pgp_name' is assigned a value that
is never used.
/libretroshare/src/rsserver/rsaccounts.cc:663: warning:
Cppcheck(passedByValue): Function parameter 'accountdir' should be
passed by reference.
2017-11-07 21:46:01 +01:00
Phenom
da190f544e Fix CppCheck in p3Status
/libretroshare/src/rsserver/p3status.h:42: warning:
Cppcheck(noExplicitConstructor): Class 'p3Status' has a constructor with
1 argument that is not explicit.
2017-11-07 21:44:48 +01:00
Phenom
628a23ae94 Fix CppCheck in rspluginitems.h
/libretroshare/src/rsitems/rspluginitems.h:39: warning:
Cppcheck(noExplicitConstructor): Class 'RsPluginItem' has a constructor
with 1 argument that is not explicit.
2017-11-07 21:44:17 +01:00
Phenom
7db813defc Fix CppCheck in rsnxsitems.h
/libretroshare/src/rsitems/rsnxsitems.h:117: warning:
Cppcheck(uninitMemberVar): Member variable
'RsNxsSyncGrpStatsItem::request_type' is not initialized in the
constructor.
/libretroshare/src/rsitems/rsnxsitems.h:117: warning:
Cppcheck(uninitMemberVar): Member variable
'RsNxsSyncGrpStatsItem::number_of_posts' is not initialized in the
constructor.
/libretroshare/src/rsitems/rsnxsitems.h:117: warning:
Cppcheck(uninitMemberVar): Member variable
'RsNxsSyncGrpStatsItem::last_post_TS' is not initialized in the
constructor.
/libretroshare/src/rsitems/rsnxsitems.h:371: warning:
Cppcheck(uninitMemberVar): Member variable 'RsNxsMsg::pos' is not
initialized in the constructor.
/libretroshare/src/rsitems/rsnxsitems.h:371: warning:
Cppcheck(uninitMemberVar): Member variable 'RsNxsMsg::count' is not
initialized in the constructor.
/libretroshare/src/rsitems/rsnxsitems.h:410: warning:
Cppcheck(uninitMemberVar): Member variable 'RsNxsSearchReqItem::nHops'
is not initialized in the constructor.
/libretroshare/src/rsitems/rsnxsitems.h:410: warning:
Cppcheck(uninitMemberVar): Member variable 'RsNxsSearchReqItem::token'
is not initialized in the constructor.
/libretroshare/src/rsitems/rsnxsitems.h:410: warning:
Cppcheck(uninitMemberVar): Member variable
'RsNxsSearchReqItem::expiration' is not initialized in the constructor.
/libretroshare/src/rsitems/rsnxsitems.h:431: warning:
Cppcheck(uninitMemberVar): Member variable
'RsNxsSearchResultMsgItem::token' is not initialized in the constructor.
/libretroshare/src/rsitems/rsnxsitems.h:431: warning:
Cppcheck(uninitMemberVar): Member variable
'RsNxsSearchResultMsgItem::expiration' is not initialized in the
constructor.
/libretroshare/src/rsitems/rsnxsitems.h:99: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSyncGrpReqItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:117: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSyncGrpStatsItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:140: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsGroupPublishKeyItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:183: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsTransacItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:211: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSyncGrpItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:257: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsEncryptedDataItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:283: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsGrp' has a constructor with
1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:327: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSyncMsgReqItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:351: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSyncMsgItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:371: warning:
Cppcheck(noExplicitConstructor): Struct 'RsNxsMsg' has a constructor
with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:410: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSearchReqItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:500: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSerialiser' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsnxsitems.h:237: warning:
Cppcheck(noExplicitConstructor): Class 'RsNxsSessionKeyItem' has a
constructor with 1 argument that is not explicit.
2017-11-07 21:43:51 +01:00
csoler
c67143d435 updated changelog 2017-11-07 20:58:22 +01:00
Phenom
68b35f3b9a Fix CppCheck in notifytxt.cc
/retroshare-nogui/src/notifytxt.cc:155: warning:
Cppcheck(postfixOperator): Prefer prefix ++/-- operators for non-
primitive types.
/retroshare-nogui/src/notifytxt.cc:175: warning:
Cppcheck(postfixOperator): Prefer prefix ++/-- operators for non-
primitive types.
/retroshare-nogui/src/notifytxt.cc:248: warning:
Cppcheck(postfixOperator): Prefer prefix ++/-- operators for non-
primitive types.
/retroshare-nogui/src/notifytxt.cc:262: warning:
Cppcheck(postfixOperator): Prefer prefix ++/-- operators for non-
primitive types.
2017-11-06 22:20:44 +01:00
Phenom
0b8d684195 Fix CppCheck in framecatcher.cpp
/retroshare-gui/src/util/framecatcher.cpp:28: warning:
Cppcheck(uninitMemberVar): Member variable 'framecatcher::length' is not
initialized in the constructor.
2017-11-06 22:20:44 +01:00
Phenom
deb6693248 Fix CppCheck in idle.cpp
/retroshare-gui/src/idle/idle.cpp:118: warning:
Cppcheck(knownConditionTrueFalse): Condition 't>0' is always true
2017-11-06 22:20:44 +01:00
Phenom
589e61ff67 Fix CppCheck in rsettings.cpp
/retroshare-gui/src/gui/settings/rsettings.cpp:43: warning:
Cppcheck(passedByValue): Function parameter 'fileName' should be passed
by reference.
2017-11-06 22:20:44 +01:00
Phenom
5554f4a739 Fix CppCheck in MimeTextEdit.h
/retroshare-gui/src/gui/common/MimeTextEdit.h:29: warning:
Cppcheck(noConstructor): The class 'MimeTextEdit' does not have a
constructor.
2017-11-06 22:20:44 +01:00
Phenom
8438d7052b Fix CppCheck in GroupTreeWidget.h
/retroshare-gui/src/gui/common/GroupTreeWidget.h:47: warning:
Cppcheck(uninitMemberVar): Member variable 'GroupItemInfo::adminKey' is
not initialized in the constructor.
/retroshare-gui/src/gui/common/GroupTreeWidget.h:68: warning:
Cppcheck(noConstructor): The class 'GroupTreeWidget' does not have a
constructor.
2017-11-06 22:20:44 +01:00
Phenom
f82ec64d29 Fix CppCheck in rsrttitems.h
/libretroshare/src/rsitems/rsrttitems.h:56: warning:
Cppcheck(uninitMemberVar): Member variable 'RsRttPingItem::mSeqNo' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsrttitems.h:56: warning:
Cppcheck(uninitMemberVar): Member variable 'RsRttPingItem::mPingTS' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsrttitems.h:70: warning:
Cppcheck(uninitMemberVar): Member variable 'RsRttPongItem::mSeqNo' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsrttitems.h:70: warning:
Cppcheck(uninitMemberVar): Member variable 'RsRttPongItem::mPingTS' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsrttitems.h:70: warning:
Cppcheck(uninitMemberVar): Member variable 'RsRttPongItem::mPongTS' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsrttitems.h:46: warning:
Cppcheck(noExplicitConstructor): Class 'RsRttItem' has a constructor
with 1 argument that is not explicit.
2017-11-06 22:20:44 +01:00
Phenom
7e47be56ea Fix CppCheck rsitem.h
/libretroshare/src/rsitems/rsitem.h:15: warning:
Cppcheck(noExplicitConstructor): Class 'RsItem' has a constructor with 1
argument that is not explicit.
2017-11-06 22:20:44 +01:00
Phenom
478071304b Fix CppCheck in rsgxsrecognitems.h
/libretroshare/src/rsitems/rsgxsrecognitems.h:56: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognReqItem::issued_at' is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:56: warning:
Cppcheck(uninitMemberVar): Member variable 'RsGxsRecognReqItem::period'
is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:56: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognReqItem::tag_class' is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:56: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognReqItem::tag_type' is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:82: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognTagItem::valid_from' is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:82: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognTagItem::valid_to' is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:82: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognTagItem::tag_class' is not initialized in the constructor.
/libretroshare/src/rsitems/rsgxsrecognitems.h:82: warning:
Cppcheck(uninitMemberVar): Member variable
'RsGxsRecognTagItem::tag_type' is not initialized in the constructor.
2017-11-06 22:20:44 +01:00
Phenom
732898a76f Fix CppCheck in rsgxsupdateitems.h
/libretroshare/src/rsitems/rsgxsupdateitems.h:88: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsGrpConfigItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsgxsupdateitems.h:109: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsGrpUpdateItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsgxsupdateitems.h:131: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsServerGrpUpdateItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsgxsupdateitems.h:157: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsMsgUpdateItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsgxsupdateitems.h:179: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsServerMsgUpdateItem' has a
constructor with 1 argument that is not explicit.
/libretroshare/src/rsitems/rsgxsupdateitems.h:194: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsUpdateSerialiser' has a
constructor with 1 argument that is not explicit.
2017-11-06 22:20:44 +01:00
Phenom
942eba3d71 Fix CppCheck in rsconfigitems.h
/libretroshare/src/rsitems/rsconfigitems.h:74: warning:
Cppcheck(uninitMemberVar): Member variable 'RsPeerNetItem::netMode' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsconfigitems.h:74: warning:
Cppcheck(uninitMemberVar): Member variable 'RsPeerNetItem::vs_disc' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsconfigitems.h:74: warning:
Cppcheck(uninitMemberVar): Member variable 'RsPeerNetItem::vs_dht' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsconfigitems.h:74: warning:
Cppcheck(uninitMemberVar): Member variable 'RsPeerNetItem::lastContact'
is not initialized in the constructor.
/libretroshare/src/rsitems/rsconfigitems.h:74: warning:
Cppcheck(uninitMemberVar): Member variable 'RsPeerNetItem::domain_port'
is not initialized in the constructor.
/libretroshare/src/rsitems/rsconfigitems.h:146: warning:
Cppcheck(uninitMemberVar): Member variable 'RsNodeGroupItem::flag' is
not initialized in the constructor.
/libretroshare/src/rsitems/rsconfigitems.h:243: warning:
Cppcheck(uninitMemberVar): Member variable 'RsFileConfigItem::flags' is
not initialized in the constructor.
2017-11-06 22:20:44 +01:00
Phenom
a1fb8f70b9 Fix CppCheck in rswire.h
/libretroshare/src/retroshare/rswire.h:111: warning:
Cppcheck(noExplicitConstructor): Class 'RsWire' has a constructor with 1
argument that is not explicit.
2017-11-06 22:20:44 +01:00
Phenom
a248ee7d41 Fix CppCheck in rsservicecontrol.h
/libretroshare/src/retroshare/rsservicecontrol.h:46: warning:
Cppcheck(passedByValue): Function parameter 'service_name' should be
passed by reference.
2017-11-06 22:20:44 +01:00
Phenom
1c862def6a Fix CppCheck in rsposted.h
/libretroshare/src/retroshare/rsposted.h:81: warning:
Cppcheck(noExplicitConstructor): Class 'RsPosted' has a constructor with
1 argument that is not explicit.
2017-11-06 22:20:44 +01:00
Phenom
ba75294258 Fix CppChecker in rsidentity.h
/libretroshare/src/retroshare/rsidentity.h:269: warning:
Cppcheck(noExplicitConstructor): Class 'RsIdentity' has a constructor
with 1 argument that is not explicit.
2017-11-06 22:20:44 +01:00
Phenom
fee7d454d9 Fix CppCheck in rsgxsforums.h
/libretroshare/src/retroshare/rsgxsforums.h:66: warning:
Cppcheck(noExplicitConstructor): Class 'RsGxsForums' has a constructor
with 1 argument that is not explicit.
2017-11-06 22:20:44 +01:00