Commit Graph

11017 Commits

Author SHA1 Message Date
Phenom
733f81269c Fix CppCheck Error in utility_functions.c
/supportlibs/pegmarkdown/utility_functions.c:28: error:
Cppcheck(memleak): Memory leak: new
2017-07-21 15:20:04 +02:00
Phenom
36e3772d59 Fix CppCheck Error in advancedsearchdialog.cpp
/retroshare-gui/src/gui/advsearch/advancedsearchdialog.cpp:131: error:
Cppcheck(memleak): Memory leak: wholeExpression
2017-07-21 15:19:17 +02:00
Phenom
145ce6b8b5 Fix CppCheck Error in ChatPage.cpp
/retroshare-gui/src/gui/settings/ChatPage.cpp:398: error:
Cppcheck(syntaxError): syntax error
2017-07-21 15:11:55 +02:00
Phenom
2afc1bf423 Fix CppCheck Error in contentvalue.cc
/libretroshare/src/util/contentvalue.cc:189: error: Cppcheck(memleak):
Memory leak: dest
2017-07-21 15:04:34 +02:00
Phenom
e5767431e6 Fix CppCheck Error in p3idservice.cc
/libretroshare/src/services/p3idservice.cc:1216: error:
Cppcheck(eraseDereference): Iterator 'it' used after element has been
erased.
/libretroshare/src/services/p3idservice.cc:1346: error:
Cppcheck(eraseDereference): Iterator 'it' used after element has been
erased.
/libretroshare/src/services/p3idservice.cc:448: error:
Cppcheck(uninitvar): Uninitialized variable: max_keep_time
2017-07-21 14:57:43 +02:00
csoler
aa471e5b2f fixed uninitialized memory read in GxsTrans 2017-07-21 10:25:20 +02:00
csoler
f370f59c42 fixed typo in ppa upload script 2017-07-20 22:12:57 +02:00
csoler
581c11dd8a fixed various problems with 06 suppression in package control files 2017-07-20 22:11:35 +02:00
csoler
baac33d95a updated revision number 2017-07-20 21:18:57 +02:00
csoler
f9d6a78627 Merge pull request #954 from PhenomRetroShare/Fix_ShowAuthorInPeopleTabAtStartUp
Fix Show Author In People Tab at startup
2017-07-20 18:19:10 +02:00
Phenom
5b86f44ef0 Fix Show Author In People Tab at startup
In same, save selected Id when list updated.
2017-07-20 14:29:31 +02:00
csoler
d60bb781b8 Merge pull request #952 from PhenomRetroShare/Fix_LobbyAutoSubscribe
Fix Lobby auto-subscribe.
2017-07-19 18:37:23 +02:00
Phenom
cbbc3920fa Fix Lobby auto-subscribe.
Save GxsId for each.
Disallow to auto-subscribe to signed lobby with unsigned id.
2017-07-19 18:33:55 +02:00
csoler
0d681b149f Merge pull request #924 from PhenomRetroShare/Fix_retroshare06_case
Change RetroShare06 to lower case
2017-07-19 18:26:32 +02:00
csoler
71810e8daa Merge pull request #950 from PhenomRetroShare/Add_ChatServerFlag
Add flag for ChatServer
2017-07-19 18:18:32 +02:00
csoler
833787e728 Merge pull request #949 from PhenomRetroShare/Add_AnonIconBeforeName
Add :/icons/anonymous_blue_128.png before name for unsigned GxsId
2017-07-18 23:02:54 +02:00
csoler
bb8f93eacc Merge pull request #951 from PhenomRetroShare/Fix_BadServMntorRegister
Fix Bad Service Monitor registering.
2017-07-18 21:19:38 +02:00
Phenom
5bbb99aef7 Fix Bad Service Monitor registering.
This induce to remove peers in statistics->bandwidth when disc service
is off.
2017-07-18 19:24:32 +02:00
Phenom
3a6bcf5ef8 Add flag for ChatServer
append the following assignation to qmake command line "CONFIG
+=rs_chatserver"
2017-07-18 16:34:56 +02:00
Phenom
b8f742d80c Add :/icons/anonymous_blue_128.png before name for unsigned GxsId
Unsigned is added to tooltip.
Double click on name is fixed.
2017-07-18 14:30:31 +02:00
csoler
e56340e0a1 Merge pull request #386 from PhenomRetroShare/Add_AbilityToChangeOpModeInCmdLine
Add the ability to change OpMode in command line.
2017-07-17 23:12:06 +02:00
csoler
d39b05ccec Merge pull request #948 from PhenomRetroShare/Add_FilterIdInFriendList
Add new Filter by ID in FriendList.
2017-07-17 22:49:44 +02:00
csoler
f4aec11b0a suppressed warning in p3dhtmgr.cc 2017-07-17 22:48:12 +02:00
Phenom
437426429e Fix clang warning: unused variable 'pqiservicezone'
/libretroshare/src/pqi/pqiservice.cc:30: warning: unused variable
'pqiservicezone' [-Wunused-const-variable]
const int pqiservicezone = 60478;
2017-07-17 22:35:01 +02:00
Phenom
1f39789f2e Fix clang warning: 'RSGraphWidget::sizeHint' hides overloaded virtual
function

/retroshare-gui/src/gui/common/RSGraphWidget.h:173: warning:
'RSGraphWidget::sizeHint' hides overloaded virtual function [-
Woverloaded-virtual]
        virtual QSizeF sizeHint( Qt::SizeHint which, const QSizeF &
constraint = QSizeF() ) const;
/usr/include/qt4/QtGui/qframe.h:76: hidden overloaded virtual function
'QFrame::sizeHint' declared here: different number of parameters (0 vs
2)
    QSize sizeHint() const;
2017-07-17 22:34:32 +02:00
Phenom
300359863e Fix clang warning: 'p3ChatService' defined as a struct here but
previously declared as a class

/libretroshare/src/chat/p3chatservice.h:56: warning: 'p3ChatService'
defined as a struct here but previously declared as a class [-
Wmismatched-tags]
struct p3ChatService :
/libretroshare/src/rsserver/p3msgs.h:33: did you mean struct here?
class p3ChatService;
2017-07-17 22:32:23 +02:00
Phenom
91c526f2b5 Fix clang warning: 'p3MsgService' defined as a struct here but
previously declared as a class

/libretroshare/src/services/p3msgservice.h:58: warning: 'p3MsgService'
defined as a struct here but previously declared as a class [-
Wmismatched-tags]
struct p3MsgService :
/libretroshare/src/rsserver/p3msgs.h:32: did you mean struct here?
class p3MsgService;
2017-07-17 22:32:07 +02:00
Phenom
896ed3e992 Fix clang warning: class 'p3Config' was previously declared as a struct
/libretroshare/src/retroshare/rsplugin.h:77: warning: class 'p3Config'
was previously declared as a struct [-Wmismatched-tags]
class p3Config;
2017-07-17 22:31:30 +02:00
Phenom
8dbb0d61af Fix warning: this statement may fall through
/libretroshare/src/dht/connectstatebox.cc:394: warning: this statement
may fall through [-Wimplicit-fallthrough=]
    if (mNextAttemptTS > now)
/libretroshare/src/dht/connectstatebox.cc:401: here
   default:

/libretroshare/src/dht/connectstatebox.cc:406: warning: this statement
may fall through [-Wimplicit-fallthrough=]
    if (mState != CSB_FAILED_WAIT)
/libretroshare/src/dht/connectstatebox.cc:414: here
   case CSB_START:

/libretroshare/src/dht/connectstatebox.cc:530: warning: this statement
may fall through [-Wimplicit-fallthrough=]
    if (mNextAttemptTS > now)
/libretroshare/src/dht/connectstatebox.cc:540: here
   default:

/libretroshare/src/dht/connectstatebox.cc:543: warning: this statement
may fall through [-Wimplicit-fallthrough=]
    if (mState != CSB_FAILED_WAIT)
/libretroshare/src/dht/connectstatebox.cc:551: here
   case CSB_START:
2017-07-17 22:29:11 +02:00
csoler
7d8b3796d1 Merge pull request #941 from PhenomRetroShare/Add_UnsignedInChatName
Add [Unsigned] before name in chat for unsigned (anonymous) GxsID.
2017-07-17 22:18:53 +02:00
Gioacchino Mazzurco
b6731ed0f5 Better naming and doc for warning suppression CONFIG 2017-07-17 16:04:52 +02:00
Phenom
f888913800 Set Operating Mode in RsInit::InitRetroShare so noGUI could use it. 2017-07-17 15:40:14 +02:00
Phenom
8563957591 Add the ability to change OpMode in command line.
So you can change OpMode while running via ssh to get more bandwidth.
Usage: RetroShare06 --opmode [full|noturtle|gaming|minimal]
2017-07-17 14:36:51 +02:00
Phenom
c74c865058 Add new Filter by ID in FriendList. 2017-07-17 14:10:26 +02:00
cyril soler
1491a051dc fixed deadlock situation in FT causing multiple bugs: lock when DLing from a file list a file that is already being downloaded, and lock when a FT module find a direct source among friends 2017-07-17 11:16:48 +02:00
Phenom
5bf056c7a4 Rename retroshare06 to retroshare 2017-07-17 10:45:18 +02:00
Phenom
b12fd11496 Change RetroShare06 to lower case
This is important to comply with linux standards.
2017-07-17 10:45:17 +02:00
csoler
65326d9438 removed DEPRECATED warnings by default 2017-07-16 22:08:07 +02:00
Phenom
e2fa57dcd7 Fix clang warning: unused variable 'INTERVAL_BETWEEN_DEBUG_DUMP'
/libretroshare/src/gxstunnel/p3gxstunnel.cc:62: warning: unused variable
'INTERVAL_BETWEEN_DEBUG_DUMP' [-Wunused-const-variable]
static const uint32_t INTERVAL_BETWEEN_DEBUG_DUMP        = 10 ;
2017-07-16 21:43:05 +02:00
Phenom
a50c4ca8d2 Fix clang warning: unused variable 'kRecognTagClass_DEVELOPMENT'
/retroshare-gui/src/gui/gxs/GxsIdDetails.cpp:62: warning: unused
variable 'kRecognTagClass_DEVELOPMENT' [-Wunused-const-variable]
const int kRecognTagClass_DEVELOPMENT = 1;
/retroshare-gui/src/gui/gxs/GxsIdDetails.cpp:64: warning: unused
variable 'kRecognTagType_Dev_Ambassador' [-Wunused-const-variable]
const int kRecognTagType_Dev_Ambassador         = 1;
/retroshare-gui/src/gui/gxs/GxsIdDetails.cpp:65: warning: unused
variable 'kRecognTagType_Dev_Contributor' [-Wunused-const-variable]
const int kRecognTagType_Dev_Contributor        = 2;
/retroshare-gui/src/gui/gxs/GxsIdDetails.cpp:66: warning: unused
variable 'kRecognTagType_Dev_Translator' [-Wunused-const-variable]
const int kRecognTagType_Dev_Translator         = 3;
/retroshare-gui/src/gui/gxs/GxsIdDetails.cpp:67: warning: unused
variable 'kRecognTagType_Dev_Patcher' [-Wunused-const-variable]
const int kRecognTagType_Dev_Patcher            = 4;
/retroshare-gui/src/gui/gxs/GxsIdDetails.cpp:68: warning: unused
variable 'kRecognTagType_Dev_Developer' [-Wunused-const-variable]
const int kRecognTagType_Dev_Developer          = 5;
2017-07-16 21:42:41 +02:00
Phenom
f2fb05db58 Fix clang warning: unused variables 'PARTIAL_VIEW_SIZE', ...
/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:67:
warning: unused variable 'PARTIAL_VIEW_SIZE' [-Wunused-const-variable]
static const int PARTIAL_VIEW_SIZE                           =  9 ;
/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:68:
warning: unused variable 'MAX_TUNNEL_REQUESTS_DISPLAY' [-Wunused-const-
variable]
static const int MAX_TUNNEL_REQUESTS_DISPLAY                 = 10 ;
/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:69:
warning: unused variable 'GXSTRANS_STATISTICS_DELAY_BETWEEN_GROUP_REQ'
[-Wunused-const-variable]
static const int GXSTRANS_STATISTICS_DELAY_BETWEEN_GROUP_REQ = 30 ;
// never request more than every 30 secs.
2017-07-16 21:42:23 +02:00
Phenom
6ee65bc98a Fix clang warning: using floating point absolute value function 'fabsf'
when argument is of integer type

/retroshare-gui/src/gui/statistics/BWGraph.cpp:83: warning: using
floating point absolute value function 'fabsf' when argument is of
integer type [-Wabsolute-value]
        if(!lst.empty() && fabsf(lst.back().first - ms) >
_update_period_msecs*1.2 )
2017-07-16 21:42:00 +02:00
Phenom
a0ac6b7ca0 Fix clang warning: unused variable 'MAX_TUNNEL_REQUESTS_DISPLAY'
/retroshare-gui/src/gui/statistics/TurtleRouterStatistics.cpp:36:
warning: unused variable 'MAX_TUNNEL_REQUESTS_DISPLAY' [-Wunused-const-
variable]
static const int MAX_TUNNEL_REQUESTS_DISPLAY = 10 ;
/retroshare-gui/src/gui/statistics/GlobalRouterStatistics.cpp:58:
warning: unused variable 'MAX_TUNNEL_REQUESTS_DISPLAY' [-Wunused-const-
variable]
static const int MAX_TUNNEL_REQUESTS_DISPLAY = 10 ;
2017-07-16 21:41:14 +02:00
Phenom
64899e40e8 Fix clang warning: unused variable 'SFI_DEFAULT_PERIOD'
/retroshare-gui/src/gui/feeds/SubFileItem.cpp:69: warning: unused
variable 'SFI_DEFAULT_PERIOD' [-Wunused-const-variable]
const uint32_t SFI_DEFAULT_PERIOD       = (30 * 3600 * 24); /* 30 Days
*/
2017-07-16 21:40:29 +02:00
Phenom
b31c812d8d Fix clang warning: unused variable 'NEWSFEED_CHANNELMSGLIST'
/retroshare-gui/src/gui/NewsFeed.cpp:70: warning: unused variable
'NEWSFEED_CHANNELMSGLIST' [-Wunused-const-variable]
const uint32_t NEWSFEED_CHANNELMSGLIST = 0x0005;
2017-07-16 21:40:07 +02:00
Phenom
69060f8119 Modify #warning to get author and date. 2017-07-16 21:37:53 +02:00
Phenom
26397d7e4d Fix clang warning: unused variables 'LOWER_LIMIT', ...
/libretroshare/src/services/p3gxsreputation.cc:130: warning: unused
variable 'LOWER_LIMIT' [-Wunused-const-variable]
static const uint32_t LOWER_LIMIT                         = 0;        //
used to filter valid Opinion values from serialized data
/libretroshare/src/services/p3gxsreputation.cc:132: warning: unused
variable 'kMaximumPeerAge' [-Wunused-const-variable]
static const int      kMaximumPeerAge                     = 180;      //
half a year.
/libretroshare/src/services/p3gxsreputation.cc:135: warning: unused
variable 'ACTIVE_FRIENDS_ONLINE_DELAY' [-Wunused-const-variable]
static const int      ACTIVE_FRIENDS_ONLINE_DELAY         = 86400*7 ; //
1 week.
/libretroshare/src/services/p3gxsreputation.cc:138: warning: unused
variable 'REPUTATION_ASSESSMENT_THRESHOLD_X1' [-Wunused-const-variable]
static const float    REPUTATION_ASSESSMENT_THRESHOLD_X1  = 0.5f ;    //
reputation under which the peer gets killed. Warning there's a 1 shift
with what's shown in GUI. Be careful.
/libretroshare/src/services/p3gxsreputation.cc:139: warning: unused
variable 'PGP_AUTO_BAN_THRESHOLD_DEFAULT' [-Wunused-const-variable]
static const uint32_t PGP_AUTO_BAN_THRESHOLD_DEFAULT      = 2 ;       //
above this, auto ban any GXS id signed by this node
/libretroshare/src/gxstunnel/p3gxstunnel.cc:62: warning: unused variable
'INTERVAL_BETWEEN_DEBUG_DUMP' [-Wunused-const-variable]
static const uint32_t INTERVAL_BETWEEN_DEBUG_DUMP        = 10 ;
2017-07-16 21:37:22 +02:00
Phenom
903f875d1d Fix clang warning: unused variable 'MAX_SERIALIZED_ARRAY_SIZE'
/libretroshare/src/serialiser/rstypeserializer.cc:39: warning: unused
variable 'MAX_SERIALIZED_ARRAY_SIZE' [-Wunused-const-variable]
static const uint32_t MAX_SERIALIZED_ARRAY_SIZE = 500 ;
2017-07-16 21:36:35 +02:00
Phenom
d83a9625cc Fix clang warning: unused variables 'GIXS_CUT_OFF', ...
/libretroshare/src/gxs/rsgxsnetservice.cc:247: warning: unused variable
'GIXS_CUT_OFF' [-Wunused-const-variable]
static const uint32_t GIXS_CUT_OFF                            =
0;
/libretroshare/src/gxs/rsgxsnetservice.cc:251: warning: unused variable
'SECURITY_DELAY_TO_FORCE_CLIENT_REUPDATE' [-Wunused-const-variable]
static const uint32_t SECURITY_DELAY_TO_FORCE_CLIENT_REUPDATE =
3600; // force re-update if there happens to be a large delay between
our server side TS and the client side TS of friends
2017-07-16 21:36:14 +02:00
Phenom
51fa7a5dda Fix clang warning: unused variable 'p3facestartupzone'
/libretroshare/src/rsserver/rsinit.cc:145: warning: unused variable
'p3facestartupzone' [-Wunused-const-variable]
const int p3facestartupzone = 47238;
2017-07-16 21:35:35 +02:00