when argument is of integer type
/retroshare-gui/src/gui/statistics/BWGraph.cpp:83: warning: using
floating point absolute value function 'fabsf' when argument is of
integer type [-Wabsolute-value]
if(!lst.empty() && fabsf(lst.back().first - ms) >
_update_period_msecs*1.2 )
/libretroshare/src/gxs/rsgxsnetservice.cc:247: warning: unused variable
'GIXS_CUT_OFF' [-Wunused-const-variable]
static const uint32_t GIXS_CUT_OFF =
0;
/libretroshare/src/gxs/rsgxsnetservice.cc:251: warning: unused variable
'SECURITY_DELAY_TO_FORCE_CLIENT_REUPDATE' [-Wunused-const-variable]
static const uint32_t SECURITY_DELAY_TO_FORCE_CLIENT_REUPDATE =
3600; // force re-update if there happens to be a large delay between
our server side TS and the client side TS of friends
/libretroshare/src/chat/distributedchat.cc:57: warning: unused variable
'MAX_MESSAGES_PER_SECONDS_NUMBER' [-Wunused-const-variable]
static const uint32_t MAX_MESSAGES_PER_SECONDS_NUMBER = 5 ; // max
number of messages from a given peer in a window for duration below
declared as a struct
/libretroshare/src/gxstrans/p3gxstrans.h:88: warning: 'p3GxsTrans'
defined as a class here but previously declared as a struct [-
Wmismatched-tags]
class p3GxsTrans : public RsGenExchange, public GxsTokenQueue, public
p3Config, public RsGxsTrans
/libretroshare/src/gxstrans/p3gxstrans.h:31: did you mean class here?
struct p3GxsTrans;
and misleading-indentation
/retroshare-gui/src/gui/gxs/GxsFeedItem.cpp:161: warning: comparison
between signed and unsigned integer expressions [-Wsign-compare]
for(uint32_t i=0;i<mMessageVersions.size();++i)
/retroshare-gui/src/gui/gxs/GxsFeedItem.cpp:161: warning: this ‘for’
clause does not guard... [-Wmisleading-indentation]
for(uint32_t i=0;i<mMessageVersions.size();++i)
/retroshare-gui/src/gui/gxs/GxsGroupDialog.cpp:654: warning: this
statement may fall through [-Wimplicit-fallthrough=]
case 2: signFlags |=
GXS_SERV::FLAG_AUTHOR_AUTHENTICATION_GPG_KNOWN; // no break below, since
we want *both* flags in this case.
/retroshare-gui/src/gui/gxschannels/CreateGxsChannelMsg.cpp:360:
warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
if(assume_file_ready)
/retroshare-gui/src/gui/gxsforums/GxsForumsFillThread.cpp:286: warning:
comparison between signed and unsigned integer expressions [-Wsign-
compare]
for(uint32_t i=1;i<(*it).size();++i)
/retroshare-gui/src/gui/statistics/BWGraph.cpp:245: warning: this
statement may fall through [-Wimplicit-fallthrough=]
case GRAPH_TYPE_ALL: std::cerr << "(WW) Impossible situation. Cannot
draw graph in mode All/All. Reverting to sum." << std::endl;
, misleading-indentation and unused-variable
/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:242:
warning: comparison between signed and unsigned integer expressions [-
Wsign-compare]
for(uint32_t i=0;i<groupTreeWidget->topLevelItemCount();++i)
/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:242:
warning: this ‘for’ clause does not guard... [-Wmisleading-indentation]
for(uint32_t i=0;i<groupTreeWidget->topLevelItemCount();++i)
/retroshare-gui/src/gui/statistics/GxsTransportStatistics.cpp:203:
warning: unused variable ‘now’ [-Wunused-variable]
time_t now = time(NULL) ;
/retroshare-gui/src/gui/GetStartedDialog.cpp:122: warning: this
statement may fall through [-Wimplicit-fallthrough=]
ui.firewallCheckBox->setChecked(true);
/retroshare-gui/src/gui/GetStartedDialog.cpp:124: here
case RSCONFIG_USER_LEVEL_CASUAL:
/retroshare-gui/src/gui/GetStartedDialog.cpp:125: warning: this
statement may fall through [-Wimplicit-fallthrough=]
ui.connectCheckBox->setChecked(true);
/retroshare-gui/src/gui/GetStartedDialog.cpp:127: here
case RSCONFIG_USER_LEVEL_BASIC:
/retroshare-gui/src/gui/RetroShareLink.cpp:585: warning: this statement
may fall through [-Wimplicit-fallthrough=]
if(!checkSSLId(_SSLid))
/retroshare-gui/src/gui/RetroShareLink.cpp:587: here
case TYPE_FILE:
/libretroshare/src/gxstrans/p3gxstrans.cc:870: warning: this statement
may fall through [-Wimplicit-fallthrough=]
pr.sent_ts = time(NULL) ; //pr.mailItem.meta.mPublishTs = time(NULL);
/libretroshare/src/gxstrans/p3gxstrans.cc:872: here
case GxsTransSendStatus::PENDING_PREFERRED_GROUP:
/libretroshare/src/gxstrans/p3gxstrans.cc:883: warning: this statement
may fall through [-Wimplicit-fallthrough=]
pr.group_id = mPreferredGroupId ; //pr.mailItem.meta.mGroupId =
mPreferredGroupId;
/libretroshare/src/gxstrans/p3gxstrans.cc:885: here
case GxsTransSendStatus::PENDING_RECEIPT_CREATE:
/libretroshare/src/gxstrans/p3gxstrans.cc:906: warning: this statement
may fall through [-Wimplicit-fallthrough=]
pr.presignedReceipt.msg.setBinData(&grsrz[0], grsz);
/libretroshare/src/gxstrans/p3gxstrans.cc:908: here
case GxsTransSendStatus::PENDING_RECEIPT_SIGNATURE: // (cyril)
This step is never actually used.
/libretroshare/src/gxstrans/p3gxstrans.cc:924: warning: this statement
may fall through [-Wimplicit-fallthrough=]
pr.presignedReceipt.meta.setBinData(&srx[0], metaSize);
/libretroshare/src/gxstrans/p3gxstrans.cc:926: here
case GxsTransSendStatus::PENDING_PAYLOAD_CREATE:
/libretroshare/src/gxstrans/p3gxstrans.cc:938: warning: this statement
may fall through [-Wimplicit-fallthrough=]
memcpy(&pr.mailItem.payload[offset], &pr.mailData[0], datasize);
/libretroshare/src/gxstrans/p3gxstrans.cc:940: here
case GxsTransSendStatus::PENDING_PAYLOAD_ENCRYPT:
/libretroshare/src/gxstrans/p3gxstrans.cc:982: warning: this statement
may fall through [-Wimplicit-fallthrough=]
}
/libretroshare/src/gxstrans/p3gxstrans.cc:984: here
case GxsTransSendStatus::PENDING_PUBLISH:
/libretroshare/src/gxs/rsgxsnetservice.cc:867: warning: variable ‘it’
set but not used [-Wunused-but-set-variable]
std::map<RsGxsGroupId,RsGxsServerMsgUpdate>::iterator it =
mServerMsgUpdateMap.find(grpId) ;
/libretroshare/src/gxs/rsgxsnetservice.cc:2434: warning: variable ‘it’
set but not used [-Wunused-but-set-variable]
ClientGrpMap::iterator it =
mClientGrpUpdateMap.find(peerFrom);
/libretroshare/src/util/dnsresolver.cc:49: warning: this statement may
fall through [-Wimplicit-fallthrough=]
case DNSResolver::DNS_LOOKUP_ERROR: if(it-
>second.last_lookup_time + MAX_TIME_BEFORE_RETRY > now)
/libretroshare/src/util/dnsresolver.cc:52: here
case DNSResolver::DNS_DONT_HAVE: next_call = it->first ;
/libretroshare/src/util/rsnet_ss.cc:1031: warning: this statement may
fall through [-Wimplicit-fallthrough=]
success = inet_ntop( addr.ss_family, (const void *) &(addrv4p-
>sin_addr), ipStr, INET_ADDRSTRLEN );
/libretroshare/src/util/rsnet_ss.cc:1033: here
case AF_INET6:
