Git-Mirrors/RetroShare
1
0
Fork 0
mirror of https://github.com/RetroShare/RetroShare.git synced 2025-08-13 08:35:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Fix CppCheck in rsservicecontrol.h

Browse source 
/libretroshare/src/retroshare/rsservicecontrol.h:46: warning:
Cppcheck(passedByValue): Function parameter 'service_name' should be
passed by reference.
This commit is contained in:
Phenom 2017-07-27 16:54:56 +02:00 • committed by csoler
parent 1c862def6a
commit a248ee7d41
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
libretroshare/src/pqi/p3servicecontrol.cc
View file

@ -1367,7 +1367,7 @@ void RsServicePermissions::resetPermission(const RsPeerId& peerId)
RsServiceInfo::RsServiceInfo( RsServiceInfo::RsServiceInfo(
const uint16_t service_type, const uint16_t service_type,
const std::string service_name, const std::string& service_name,
const uint16_t version_major, const uint16_t version_major,
const uint16_t version_minor, const uint16_t version_minor,
const uint16_t min_version_major, const uint16_t min_version_major,

2
libretroshare/src/retroshare/rsservicecontrol.h
View file

@ -43,7 +43,7 @@ class RsServiceInfo
RsServiceInfo(); RsServiceInfo();
RsServiceInfo( RsServiceInfo(
const uint16_t service_type, const uint16_t service_type,
const std::string service_name, const std::string& service_name,
const uint16_t version_major, const uint16_t version_major,
const uint16_t version_minor, const uint16_t version_minor,
const uint16_t min_version_major, const uint16_t min_version_major,