From a248ee7d4145c85854f1e82c160bf52e9add5798 Mon Sep 17 00:00:00 2001 From: Phenom Date: Thu, 27 Jul 2017 16:54:56 +0200 Subject: [PATCH] Fix CppCheck in rsservicecontrol.h /libretroshare/src/retroshare/rsservicecontrol.h:46: warning: Cppcheck(passedByValue): Function parameter 'service_name' should be passed by reference. --- libretroshare/src/pqi/p3servicecontrol.cc | 2 +- libretroshare/src/retroshare/rsservicecontrol.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libretroshare/src/pqi/p3servicecontrol.cc b/libretroshare/src/pqi/p3servicecontrol.cc index 0105690c3..251777e70 100644 --- a/libretroshare/src/pqi/p3servicecontrol.cc +++ b/libretroshare/src/pqi/p3servicecontrol.cc @@ -1367,7 +1367,7 @@ void RsServicePermissions::resetPermission(const RsPeerId& peerId) RsServiceInfo::RsServiceInfo( const uint16_t service_type, - const std::string service_name, + const std::string& service_name, const uint16_t version_major, const uint16_t version_minor, const uint16_t min_version_major, diff --git a/libretroshare/src/retroshare/rsservicecontrol.h b/libretroshare/src/retroshare/rsservicecontrol.h index 7558764e7..12d9dc5d2 100644 --- a/libretroshare/src/retroshare/rsservicecontrol.h +++ b/libretroshare/src/retroshare/rsservicecontrol.h @@ -43,7 +43,7 @@ class RsServiceInfo RsServiceInfo(); RsServiceInfo( const uint16_t service_type, - const std::string service_name, + const std::string& service_name, const uint16_t version_major, const uint16_t version_minor, const uint16_t min_version_major,