iv-org/invidious
1
0
Fork 0
mirror of https://github.com/iv-org/invidious.git synced 2024-10-01 01:35:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

js: add support to detect alt, meta and control key in keydown handler (#704)

Browse Source 
This fixes a quite severe user experience issue where pressing the
'alt', 'meta' and/or 'ctrl' key along with one of the supported keys
(e.g. 'f' to enter video fullscreen mode) would overwrite the default
browser behavior. In the case of 'f+meta' we would enter fullscreen
mode, and not open the browser search panel as one might expect.

This change is required to stay consistent with the way YouTube
handles keydown events.
This commit is contained in:
leonklingele 2019-08-19 06:22:39 +02:00 committed by Omar Roth
parent 2b94975345
commit acaf7b969a
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
assets/js/player.js
View File

@ -327,8 +327,13 @@ window.addEventListener('keydown', e => {
let action = null; let action = null;
const code = e.keyCode; const code = e.keyCode;
const key = e.key; const decoratedKey =
switch (key) { e.key
+ (e.altKey ? '+alt' : '')
+ (e.ctrlKey ? '+ctrl' : '')
+ (e.metaKey ? '+meta' : '')
;
switch (decoratedKey) {
case ' ': case ' ':
case 'k': case 'k':
action = toggle_play; action = toggle_play;
@ -405,7 +410,7 @@ window.addEventListener('keydown', e => {
break; break;
default: default:
console.info('Unhandled key down event: %s:', key, e); console.info('Unhandled key down event: %s:', decoratedKey, e);
break; break;
} }