mirror of
https://git.anonymousland.org/anonymousland/synapse-product.git
synced 2024-12-11 18:04:19 -05:00
e746f80b4f
Internally the push rules module uses a `pattern_type` property for `event_match` conditions (and `related_event_match`) to mark the condition as matching the current user's Matrix ID or localpart. This is leaky to the Client-Server API where a user can successfully set a condition which provides `pattern_type` instead of `pattern` (note that there's no benefit to doing this -- the user can just use their own Matrix ID or localpart instead). When serializing back to the client the `pattern_type` property is converted into a proper `pattern`. The following changes are made to avoid this: * Separate the `KnownCondition::EventMatch` enum value into `EventMatch` and `EventMatchType`, each with their own expected properties. (Note that a similar change is made for `RelatedEventMatch`.) * Make it such that the `pattern_type` variants serialize to the same condition kind, but cannot be deserialized (since they're only provided by base rules). * As a final tweak, convert `user_id` vs. `user_localpart` values into an enum. |
||
---|---|---|
.. | ||
__init__.py | ||
test_bulk_push_rule_evaluator.py | ||
test_email.py | ||
test_http.py | ||
test_presentable_names.py | ||
test_push_rule_evaluator.py |