synapse-product/changelog.d
Patrick Cloke e746f80b4f
Do not accept pattern_type from user input in push rules. (#15088)
Internally the push rules module uses a `pattern_type` property for `event_match`
conditions (and `related_event_match`) to mark the condition as matching the
current user's Matrix ID or localpart.

This is leaky to the Client-Server API where a user can successfully set a condition
which provides `pattern_type` instead of `pattern` (note that there's no benefit to
doing this -- the user can just use their own Matrix ID or localpart instead). When
serializing back to the client the `pattern_type` property is converted into a proper
`pattern`.

The following changes are made to avoid this:

* Separate the `KnownCondition::EventMatch` enum value into `EventMatch`
  and `EventMatchType`, each with their own expected properties. (Note that a
  similar change is made for `RelatedEventMatch`.)
* Make it such that the `pattern_type` variants serialize to the same condition kind,
  but cannot be deserialized (since they're only provided by base rules).
* As a final tweak, convert `user_id` vs. `user_localpart` values into an enum.
2023-02-28 10:11:20 -05:00
..
.gitignore Correct attrs package name in requirements (#3492) 2018-07-07 10:46:59 +10:00
14026.doc Add documentation for caching in a module (#14026) 2023-02-28 14:16:33 +00:00
14918.misc Batch up storing state groups when creating new room (#14918) 2023-02-24 13:15:29 -08:00
15044.feature Add module API callbacks for adding and deleting local 3PID associations (#15044 2023-02-27 14:19:19 +00:00
15071.doc Clarify the workers that the ThirdPartyRules' on_new_event callback will run on (#15071) 2023-02-22 16:05:34 +00:00
15088.bugfix Do not accept pattern_type from user input in push rules. (#15088) 2023-02-28 10:11:20 -05:00
15092.bugfix Do not fail completely if oEmbed autodiscovery fails. (#15092) 2023-02-23 16:08:53 -05:00
15093.bugfix Remove unused room_alias field from /createRoom response (#15093) 2023-02-22 11:07:28 +00:00
15095.misc Use json.dump in FileExfiltrationWriter (#15095) 2023-02-22 14:29:39 -05:00
15103.misc Bump black from 22.12.0 to 23.1.0 (#15103) 2023-02-22 15:29:09 -05:00
15107.feature Add information on uploaded media to user export command. (#15107) 2023-02-23 13:14:17 -05:00
15112.doc Documentation using Shibboleth with OIDC Plugin for SSO. (#15112) 2023-02-23 12:54:03 -05:00
15116.feature Admin API endpoint to delete a reported event (#15116) 2023-02-28 12:09:10 +00:00
15135.misc Tighten the default rate limit of creating new devices. (#15135) 2023-02-22 14:37:18 -05:00
15137.removal Stop parsing the unspecced type parameter on thumbnail requests. (#15137) 2023-02-23 16:07:46 -05:00
15138.misc Fix a typo in MSC3873 config option. (#15138) 2023-02-23 16:06:42 -05:00
15139.doc Fix typo in federation_verify_certificates in config documentation. (#15139) 2023-02-23 13:25:56 -05:00
15143.misc Improve handling of non-ASCII characters in user directory search (#15143) 2023-02-24 13:39:45 +00:00
15146.misc Refactor media modules. (#15146) 2023-02-27 08:26:05 -05:00
15148.doc Small fixes to MatrixFederationHttpClient docstrings (#15148) 2023-02-27 13:03:22 +00:00
15152.misc Bump dawidd6/action-download-artifact from 2.25.0 to 2.26.0 (#15152) 2023-02-27 11:28:57 +00:00
15154.misc Bump docker/login-action from 1 to 2 (#15154) 2023-02-27 11:29:51 +00:00
15155.misc Bump actions/checkout from 2 to 3 (#15155) 2023-02-27 11:32:52 +00:00
15156.misc Bump matrix-org/backend-meta from 1 to 2 (#15156) 2023-02-27 11:33:27 +00:00
15157.misc Bump typing-extensions from 4.4.0 to 4.5.0 (#15157) 2023-02-27 11:34:57 +00:00
15158.misc Bump types-opentracing from 2.4.10.1 to 2.4.10.3 (#15158) 2023-02-27 11:37:33 +00:00
15159.misc Bump ruff from 0.0.237 to 0.0.252 (#15159) 2023-02-27 11:39:26 +00:00
15160.misc Bump types-setuptools from 67.3.0.1 to 67.4.0.3 (#15160) 2023-02-27 11:38:10 +00:00
15167.misc Remove dangling reference to being a reference implementation (#15167) 2023-02-27 20:08:18 +00:00
15168.doc Correct documentation about registration_shared_secret_path (#15168) 2023-02-28 11:09:31 +00:00