synapse-product/13855.bugfix at 9f218b73e9d52eebd10f359c70c61de40d73e4d6 - synapse-product - Gitea: Git with a cup of tea

Matrix-Mirrors/synapse-product

mirror of https://git.anonymousland.org/anonymousland/synapse-product.git synced 2024-12-18 01:04:22 -05:00

Eric Eastwood db868db594

Fix access token leak to logs from proxyagent (#13855 )

This can happen specifically with an application service `/transactions/10722?access_token=leaked` request

Fix https://github.com/matrix-org/synapse/issues/13010

---

Saw an example leak in https://github.com/matrix-org/synapse/issues/13423#issuecomment-1205348482

```
2022-08-04 14:47:57,925 - synapse.http.client - 401 - DEBUG - as-sender-signal-1 - Sending request PUT http://localhost:29328/transactions/10722?access_token=<redacted>
2022-08-04 14:47:57,926 - synapse.http.proxyagent - 223 - DEBUG - as-sender-signal-1 - Requesting b'http://localhost:29328/transactions/10722?access_token=leaked' via <HostnameEndpoint localhost:29328>
```

2022-09-23 11:49:39 -05:00

2 lines

48 B

Plaintext

Raw Blame History

Fix access token leak to logs from proxy agent.