David Robertson 796a4b7482 Prefer type(x) is int to isinstance(x, int) (#14945) ... * Perfer `type(x) is int` to `isinstance(x, int)` This covered all additional instances I could see where `x` was user-controlled. The remaining cases are ``` $ rg -s 'isinstance.*[^_]int' tests/replication/_base.py 576: if isinstance(obj, int): synapse/util/caches/stream_change_cache.py 136: assert isinstance(stream_pos, int) 214: assert isinstance(stream_pos, int) 246: assert isinstance(stream_pos, int) 267: assert isinstance(stream_pos, int) synapse/replication/tcp/external_cache.py 133: if isinstance(result, int): synapse/metrics/__init__.py 100: if isinstance(calls, (int, float)): synapse/handlers/appservice.py 262: assert isinstance(new_token, int) synapse/config/_util.py 62: if isinstance(p, int): ``` which cover metrics, logic related to `jsonschema`, and replication and data streams. AFAICS these are all internal to Synapse * Changelog		2023-01-31 10:33:07 +00:00
..
ui_auth	Fix twisted trunk mypy errors (#14012)	2022-10-03 13:26:49 +00:00
__init__.py	Remove redundant "coding: utf-8" lines (#9786)	2021-04-14 15:34:27 +01:00
account_data.py	Use StrCollection in place of Collection[str] in (most) handlers code. (#14922)	2023-01-26 12:31:58 -05:00
account_validity.py	Implement cancellation support/protection for module callbacks (#12568)	2022-05-09 12:31:14 +01:00
account.py	Optionally include account validity in MSC3720 account status responses (#12266)	2022-03-24 11:19:41 +01:00
admin.py	Use an enum for direction. (#14927)	2023-01-27 07:27:55 -05:00
appservice.py	Improve logging and opentracing for to-device message handling (#14598)	2022-12-06 09:52:55 +00:00
auth.py	Add missing type hints to tests.handlers. (#14680)	2022-12-16 11:53:01 +00:00
cas.py	Fix twisted trunk mypy errors (#14012)	2022-10-03 13:26:49 +00:00
deactivate_account.py	Add a type hint for get_device_handler() and fix incorrect types. (#14055)	2022-11-22 14:08:04 -05:00
device.py	Use StrCollection in place of Collection[str] in (most) handlers code. (#14922)	2023-01-26 12:31:58 -05:00
devicemessage.py	Batch up replication requests to request the resyncing of remote users's devices. (#14716)	2023-01-10 11:17:59 +00:00
directory.py	Allow PUT/GET of aliases during faster join (#14292)	2022-11-01 15:02:39 +00:00
e2e_keys.py	Batch up replication requests to request the resyncing of remote users's devices. (#14716)	2023-01-10 11:17:59 +00:00
e2e_room_keys.py	Remove redundant types from comments. (#14412)	2022-11-16 15:25:24 +00:00
event_auth.py	Use StrCollection in place of Collection[str] in (most) handlers code. (#14922)	2023-01-26 12:31:58 -05:00
events.py	Directly lookup local membership instead of getting all members in a room first (get_users_in_room mis-use) (#13608)	2022-08-24 14:13:12 -05:00
federation_event.py	Use StrCollection in place of Collection[str] in (most) handlers code. (#14922)	2023-01-26 12:31:58 -05:00
federation.py	Use StrCollection in place of Collection[str] in (most) handlers code. (#14922)	2023-01-26 12:31:58 -05:00
identity.py	Remove redundant types from comments. (#14412)	2022-11-16 15:25:24 +00:00
initial_sync.py	Use an enum for direction. (#14927)	2023-01-27 07:27:55 -05:00
message.py	Prefer type(x) is int to isinstance(x, int) (#14945)	2023-01-31 10:33:07 +00:00
oidc.py	Support RFC7636 PKCE in the OAuth 2.0 flow. (#14750)	2023-01-04 14:58:08 -05:00
pagination.py	Use an enum for direction. (#14927)	2023-01-27 07:27:55 -05:00
password_policy.py	Use direct references for some configuration variables (part 3) (#10885)	2021-09-23 07:13:34 -04:00
presence.py	Fix a bug in the send_local_online_presence_to module API (#14880)	2023-01-25 21:34:37 +00:00
profile.py	fix broken avatar checks when server_name contains a port (#13927)	2022-10-26 15:51:23 +01:00
push_rules.py	Port the push rule classes to Rust. (#13768)	2022-09-20 12:10:31 +01:00
read_marker.py	Refactor and convert Linearizer to async (#12357)	2022-04-05 15:43:52 +01:00
receipts.py	Include thread information when sending receipts over federation. (#14466)	2022-11-28 14:40:17 +00:00
register.py	Move StateFilter to synapse.types (#14668)	2022-12-12 16:19:30 +00:00
relations.py	Use an enum for direction. (#14927)	2023-01-27 07:27:55 -05:00
room_batch.py	Make handle_new_client_event throws PartialStateConflictError (#14665)	2022-12-15 16:04:23 +00:00
room_list.py	Use stable prefixes for MSC3827: filtering of /publicRooms by room type (#13370)	2022-07-27 19:46:57 +01:00
room_member_worker.py	Implement knock feature (#6739)	2021-06-09 19:39:51 +01:00
room_member.py	Make handle_new_client_event throws PartialStateConflictError (#14665)	2022-12-15 16:04:23 +00:00
room_summary.py	Use StrCollection in place of Collection[str] in (most) handlers code. (#14922)	2023-01-26 12:31:58 -05:00
room.py	Use StrCollection in place of Collection[str] in (most) handlers code. (#14922)	2023-01-26 12:31:58 -05:00
saml.py	Remove redundant types from comments. (#14412)	2022-11-16 15:25:24 +00:00
search.py	Use StrCollection in place of Collection[str] in (most) handlers code. (#14922)	2023-01-26 12:31:58 -05:00
send_email.py	Discourage automatic replies to Synapse's emails (#13957)	2022-09-30 13:23:37 +00:00
set_password.py	Add a type hint for get_device_handler() and fix incorrect types. (#14055)	2022-11-22 14:08:04 -05:00
sso.py	Use StrCollection in place of Collection[str] in (most) handlers code. (#14922)	2023-01-26 12:31:58 -05:00
state_deltas.py	Remove HomeServer.get_datastore() (#12031)	2022-02-23 11:04:02 +00:00
stats.py	Implement MSC3827: Filtering of /publicRooms by room type (#13031)	2022-06-29 17:12:45 +00:00
sync.py	Merge branch 'release-v1.76' into develop	2023-01-27 13:01:18 +00:00
typing.py	Better return type for get_all_entities_changed (#14604)	2022-12-05 15:19:14 -05:00
user_directory.py	Clarifications in user directory for users who share rooms tracking (#13966)	2022-09-30 14:40:18 -05:00