synapse-product/synapse
Brendan Abolivier 504c8f3483
Fix handling of "off" in encryption_enabled_by_default_for_room_type (#7822)
Fixes https://github.com/matrix-org/synapse/issues/7821, introduced in https://github.com/matrix-org/synapse/pull/7639

Turns out PyYAML translates `off` into a `False` boolean if it's
unquoted (see https://stackoverflow.com/questions/36463531/pyyaml-automatically-converting-certain-keys-to-boolean-values),
which seems to be a liberal interpretation of this bit of the YAML spec: https://yaml.org/spec/1.1/current.html#id864510

An alternative fix would be to implement the solution mentioned in the
SO post linked above, but I'm aware it might break existing setups
(which might use these values in the configuration file) so it's
probably better just to add an extra check for this one. We should be
aware that this is a thing for the next times we do that though.

I didn't find any other occurrence of this bug elsewhere in the
codebase.
2020-07-13 17:14:42 +01:00
..
_scripts Replace all remaining six usage with native Python 3 equivalents (#7704) 2020-06-16 08:51:47 -04:00
api Do not use canonicaljson to magically handle decoding bytes from JSON. (#7802) 2020-07-10 14:30:08 -04:00
app Add ability to shard the federation sender (#7798) 2020-07-10 18:26:36 +01:00
appservice Include room states on invite events sent to ASes (#6455) 2020-07-10 18:44:56 +01:00
config Fix handling of "off" in encryption_enabled_by_default_for_room_type (#7822) 2020-07-13 17:14:42 +01:00
crypto Replace all remaining six usage with native Python 3 equivalents (#7704) 2020-06-16 08:51:47 -04:00
events Add HomeServer.signing_key property (#7805) 2020-07-08 17:51:56 +01:00
federation Do not use canonicaljson to magically handle decoding bytes from JSON. (#7802) 2020-07-10 14:30:08 -04:00
groups Add HomeServer.signing_key property (#7805) 2020-07-08 17:51:56 +01:00
handlers Do not use canonicaljson to magically handle decoding bytes from JSON. (#7802) 2020-07-10 14:30:08 -04:00
http Do not use canonicaljson to magically handle decoding bytes from JSON. (#7802) 2020-07-10 14:30:08 -04:00
logging isort 5 compatibility (#7786) 2020-07-05 16:32:02 +01:00
metrics Improve stacktraces from exceptions in background processes (#7808) 2020-07-09 13:01:33 +01:00
module_api Wrap register_device coroutine in an ensureDeferred (#7684) 2020-06-16 10:13:59 +01:00
push Don't ignore set_tweak actions with no explicit value. (#7766) 2020-07-06 11:43:41 +01:00
replication Add ability to shard the federation sender (#7798) 2020-07-10 18:26:36 +01:00
res/templates
rest update_membership declaration: now always returns an event id. (#7809) 2020-07-09 13:01:42 +01:00
server_notices Replace all remaining six usage with native Python 3 equivalents (#7704) 2020-06-16 08:51:47 -04:00
spam_checker_api
state Add another yield point to state res v2 (#7746) 2020-06-26 10:44:52 +01:00
static Clean-up the fallback login code. (#7657) 2020-06-10 09:50:39 -04:00
storage Merge branch 'release-v1.17.0' into develop 2020-07-10 18:38:50 +01:00
streams Fix some spelling mistakes / typos. (#7811) 2020-07-09 09:52:58 -04:00
util Fix some spelling mistakes / typos. (#7811) 2020-07-09 09:52:58 -04:00
__init__.py 1.17.0 2020-07-13 10:20:36 +01:00
event_auth.py Fix recursion error when fetching auth chain over federation (#7817) 2020-07-10 18:15:35 +01:00
notifier.py Fix some spelling mistakes / typos. (#7811) 2020-07-09 09:52:58 -04:00
python_dependencies.py Allow to use higher versions of prometheus_client (#7780) 2020-07-06 10:21:41 +01:00
secrets.py isort 5 compatibility (#7786) 2020-07-05 16:32:02 +01:00
server.py Add HomeServer.signing_key property (#7805) 2020-07-08 17:51:56 +01:00
server.pyi Add ability to wait for replication streams (#7542) 2020-05-22 14:21:54 +01:00
types.py isort 5 compatibility (#7786) 2020-07-05 16:32:02 +01:00
visibility.py Fix some spelling mistakes / typos. (#7811) 2020-07-09 09:52:58 -04:00