Eric Eastwood 35d6b914eb Resolve and share state_groups for all historical events in batch (MSC2716) (#10975) ... Resolve and share `state_groups` for all historical events in batch. This also helps for showing the appropriate avatar/displayname in Element and will work whenever `/messages` has one of the historical messages as the first message in the batch. This does have the flaw where if you just insert a single historical event somewhere, it probably won't resolve the state correctly from `/messages` or `/context` since it will grab a non historical event above or below with resolved state which never included the historical state back then. For the same reasions, this also does not work in Element between the transition from actual messages to historical messages. In the Gitter case, this isn't really a problem since all of the historical messages are in one big lump at the beginning of the room. For a future iteration, might be good to look at `/messages` and `/context` to additionally add the `state` for any historical messages in that batch. --- How are the `state_groups` shared? To illustrate the `state_group` sharing, see this example: **Before** (new `state_group` for every event 😬, very inefficient): ``` # Tests from https://github.com/matrix-org/complement/pull/206 $ COMPLEMENT_ALWAYS_PRINT_SERVER_LOGS=1 COMPLEMENT_DIR=../complement ./scripts-dev/complement.sh TestBackfillingHistory/parallel/should_resolve_member_state_events_for_historical_events create_new_client_event m.room.member event=$_JXfwUDIWS6xKGG4SmZXjSFrizhARM7QblhATVWWUcA state_group=None create_new_client_event org.matrix.msc2716.insertion event=$1ZBfmBKEjg94d-vGYymKrVYeghwBOuGJ3wubU1-I9y0 state_group=9 create_new_client_event org.matrix.msc2716.insertion event=$Mq2JvRetTyclPuozRI682SAjYp3GqRuPc8_cH5-ezPY state_group=10 create_new_client_event m.room.message event=$MfmY4rBQkxrIp8jVwVMTJ4PKnxSigpG9E2cn7S0AtTo state_group=11 create_new_client_event m.room.message event=$uYOv6V8wiF7xHwOMt-60d1AoOIbqLgrDLz6ZIQDdWUI state_group=12 create_new_client_event m.room.message event=$PAbkJRMxb0bX4A6av463faiAhxkE3FEObM1xB4D0UG4 state_group=13 create_new_client_event org.matrix.msc2716.batch event=$Oy_S7AWN7rJQe_MYwGPEy6RtbYklrI-tAhmfiLrCaKI state_group=14 ``` **After** (all events in batch sharing `state_group=10`) (the base insertion event has `state_group=8` which matches the `prev_event` we're inserting next to): ``` # Tests from https://github.com/matrix-org/complement/pull/206 $ COMPLEMENT_ALWAYS_PRINT_SERVER_LOGS=1 COMPLEMENT_DIR=../complement ./scripts-dev/complement.sh TestBackfillingHistory/parallel/should_resolve_member_state_events_for_historical_events create_new_client_event m.room.member event=$PWomJ8PwENYEYuVNoG30gqtybuQQSZ55eldBUSs0i0U state_group=None create_new_client_event org.matrix.msc2716.insertion event=$e_mCU7Eah9ABF6nQU7lu4E1RxIWccNF05AKaTT5m3lw state_group=9 create_new_client_event org.matrix.msc2716.insertion event=$ui7A3_GdXIcJq0C8GpyrF8X7B3DTjMd_WGCjogax7xU state_group=10 create_new_client_event m.room.message event=$EnTIM5rEGVezQJiYl62uFBl6kJ7B-sMxWqe2D_4FX1I state_group=10 create_new_client_event m.room.message event=$LGx5jGONnBPuNhAuZqHeEoXChd9ryVkuTZatGisOPjk state_group=10 create_new_client_event m.room.message event=$wW0zwoN50lbLu1KoKbybVMxLbKUj7GV_olozIc5i3M0 state_group=10 create_new_client_event org.matrix.msc2716.batch event=$5ZB6dtzqFBCEuMRgpkU201Qhx3WtXZGTz_YgldL6JrQ state_group=10 ```		2021-10-13 17:44:00 -05:00
..
__init__.py	Verify ?chunk_id actually corresponds to an insertion event that exists (MSC2716) (#10776)	2021-09-15 09:34:30 +01:00
account_data.py	Remove unnecessary parentheses around tuples returned from methods (#10889)	2021-09-23 11:59:07 +01:00
appservice.py	Use direct references for some configuration variables (part 3) (#10885)	2021-09-23 07:13:34 -04:00
cache.py	add a cache to have_seen_event (#9953)	2021-06-01 12:04:47 +01:00
censor_events.py	Use direct references for configuration variables (part 6). (#10916)	2021-09-29 06:44:15 -04:00
client_ips.py	Stop user directory from failing if it encounters users not in the users table. (#11053)	2021-10-13 09:38:22 +00:00
deviceinbox.py	Remove unnecessary parentheses around tuples returned from methods (#10889)	2021-09-23 11:59:07 +01:00
devices.py	Use direct references for some configuration variables (#10798)	2021-09-13 13:07:12 -04:00
directory.py	Allow room_alias_name parameter to be handled by /createRoom calls on workers (#10757)	2021-09-06 14:37:15 +01:00
e2e_room_keys.py	Remove redundant "coding: utf-8" lines (#9786)	2021-04-14 15:34:27 +01:00
end_to_end_keys.py	Fix invalidating OTK count cache after claim (#10875)	2021-09-22 15:31:05 +01:00
event_federation.py	Rename MSC2716 things from chunk to batch to match /batch_send endpoint (#10838)	2021-09-21 15:06:28 -05:00
event_push_actions.py	Use direct references for some configuration variables (#10798)	2021-09-13 13:07:12 -04:00
events_bg_updates.py	Fix remove_stale_pushers job on SQLite. (#10843)	2021-09-20 10:26:13 +01:00
events_forward_extremities.py	Remove redundant "coding: utf-8" lines (#9786)	2021-04-14 15:34:27 +01:00
events_worker.py	Remove unnecessary parentheses around tuples returned from methods (#10889)	2021-09-23 11:59:07 +01:00
events.py	Resolve and share state_groups for all historical events in batch (MSC2716) (#10975)	2021-10-13 17:44:00 -05:00
filtering.py	Add type hints to filtering classes. (#10958)	2021-10-01 07:02:32 -04:00
group_server.py	[pyupgrade] synapse/ (#10348)	2021-07-19 15:28:05 +01:00
keys.py	Add missing type hints to synapse.util (#9982)	2021-05-24 15:32:01 -04:00
lock.py	Fix dropping locks on shut down (#10433)	2021-07-20 14:24:25 +01:00
media_repository.py	Add an admin API for unprotecting local media from quarantine (#10040)	2021-05-26 11:19:47 +01:00
metrics.py	Use direct references for some configuration variables (#10798)	2021-09-13 13:07:12 -04:00
monthly_active_users.py	Add functionality to remove deactivated users from the monthly_active_users table (#10947)	2021-10-04 08:34:42 -07:00
openid.py	Convert additional databases to async/await part 2 (#8200)	2020-09-01 08:39:04 -04:00
presence.py	Add a partial index to presence_stream to speed up startups (#10748)	2021-09-03 17:16:56 +01:00
profile.py	Fix deactivate a user if he does not have a profile (#10252)	2021-07-06 13:08:53 +01:00
purge_events.py	In _purge_history_txn, ensure that txn.fetchall has elements before accessing rows (#10690)	2021-09-24 09:19:51 +00:00
push_rule.py	disallow-untyped-defs for synapse.push (#11023)	2021-10-11 17:42:10 +01:00
pusher.py	Annotate synapse.storage.util (#10892)	2021-10-08 14:25:16 +00:00
receipts.py	Add type hints for event streams. (#10856)	2021-09-21 13:34:26 -04:00
registration.py	Annotate synapse.storage.util (#10892)	2021-10-08 14:25:16 +00:00
rejections.py	Remove redundant "coding: utf-8" lines (#9786)	2021-04-14 15:34:27 +01:00
relations.py	Remove redundant "coding: utf-8" lines (#9786)	2021-04-14 15:34:27 +01:00
room_batch.py	Resolve and share state_groups for all historical events in batch (MSC2716) (#10975)	2021-10-13 17:44:00 -05:00
room.py	Use direct references for configuration variables (part 6). (#10916)	2021-09-29 06:44:15 -04:00
roommember.py	Use direct references for configuration variables (part 4). (#10893)	2021-09-23 12:03:01 -04:00
search.py	Use direct references for configuration variables (part 6). (#10916)	2021-09-29 06:44:15 -04:00
session.py	Use direct references for some configuration variables (#10798)	2021-09-13 13:07:12 -04:00
signatures.py	Remove redundant "coding: utf-8" lines (#9786)	2021-04-14 15:34:27 +01:00
state_deltas.py	Remove unnecessary parentheses around tuples returned from methods (#10889)	2021-09-23 11:59:07 +01:00
state.py	Fix remove_stale_pushers job on SQLite. (#10843)	2021-09-20 10:26:13 +01:00
stats.py	Use direct references for configuration variables (part 5). (#10897)	2021-09-24 07:25:21 -04:00
stream.py	Remove unnecessary parentheses around tuples returned from methods (#10889)	2021-09-23 11:59:07 +01:00
tags.py	Use inline type hints in http/federation/, storage/ and util/ (#10381)	2021-07-15 12:46:54 -04:00
transactions.py	Use direct references for some configuration variables (#10798)	2021-09-13 13:07:12 -04:00
ui_auth.py	Fix remove_stale_pushers job on SQLite. (#10843)	2021-09-20 10:26:13 +01:00
user_directory.py	Stop user directory from failing if it encounters users not in the users table. (#11053)	2021-10-13 09:38:22 +00:00
user_erasure_store.py	Minor @cachedList enhancements (#9975)	2021-05-14 11:12:36 +01:00