synapse-product/tests/handlers
Richard van der Hoff 2ec8ca5e60
Remove SynapseRequest.get_user_agent (#9069)
SynapseRequest is in danger of becoming a bit of a dumping-ground for "useful stuff relating to Requests",
which isn't really its intention (its purpose is to override render, finished and connectionLost to set up the 
LoggingContext and write the right entries to the request log).

Putting utility functions inside SynapseRequest means that lots of our code ends up requiring a
SynapseRequest when there is nothing synapse-specific about the Request at all, and any old
twisted.web.iweb.IRequest will do. This increases code coupling and makes testing more difficult.

In short: move get_user_agent out to a utility function.
2021-01-12 12:34:16 +00:00
..
__init__.py Reference Matrix Home Server 2014-08-12 15:10:52 +01:00
test_admin.py Remove the deprecated Handlers object (#8494) 2020-10-09 07:24:34 -04:00
test_appservice.py Start fewer opentracing spans (#8640) 2020-10-26 09:30:19 +00:00
test_auth.py Simplify the way the HomeServer object caches its internal attributes. (#8565) 2020-11-30 13:28:44 -05:00
test_cas.py Remove SynapseRequest.get_user_agent (#9069) 2021-01-12 12:34:16 +00:00
test_device.py Apply an IP range blacklist to push and key revocation requests. (#8821) 2020-12-02 11:09:24 -05:00
test_directory.py Remove spurious "SynapseRequest" result from `make_request" 2020-12-15 22:35:40 +00:00
test_e2e_keys.py Remove the deprecated Handlers object (#8494) 2020-10-09 07:24:34 -04:00
test_e2e_room_keys.py Remove the deprecated Handlers object (#8494) 2020-10-09 07:24:34 -04:00
test_federation.py Various clean-ups to the logging context code (#8935) 2020-12-14 14:19:47 -05:00
test_message.py Remove spurious "SynapseRequest" result from `make_request" 2020-12-15 22:35:40 +00:00
test_oidc.py Remove SynapseRequest.get_user_agent (#9069) 2021-01-12 12:34:16 +00:00
test_password_providers.py Remove spurious "SynapseRequest" result from `make_request" 2020-12-15 22:35:40 +00:00
test_presence.py Apply an IP range blacklist to push and key revocation requests. (#8821) 2020-12-02 11:09:24 -05:00
test_profile.py Remove redundant mocking 2020-12-02 17:53:38 +00:00
test_register.py Remove the deprecated Handlers object (#8494) 2020-10-09 07:24:34 -04:00
test_saml.py Remove SynapseRequest.get_user_agent (#9069) 2021-01-12 12:34:16 +00:00
test_stats.py Rename 'populate_stats_process_rooms_2' background job back to 'populate_stats_process_rooms' again (#8243) 2020-09-08 11:05:59 +01:00
test_sync.py Add admin API for logging in as a user (#8617) 2020-11-17 10:51:25 +00:00
test_typing.py Remove spurious "SynapseRequest" result from `make_request" 2020-12-15 22:35:40 +00:00
test_user_directory.py Fix a bug that deactivated users appear in the directory (#8933) 2020-12-17 12:05:39 +00:00