mirror of
https://git.anonymousland.org/anonymousland/synapse-product.git
synced 2024-09-07 16:21:54 +00:00
![]() * Perfer `type(x) is int` to `isinstance(x, int)` This covered all additional instances I could see where `x` was user-controlled. The remaining cases are ``` $ rg -s 'isinstance.*[^_]int' tests/replication/_base.py 576: if isinstance(obj, int): synapse/util/caches/stream_change_cache.py 136: assert isinstance(stream_pos, int) 214: assert isinstance(stream_pos, int) 246: assert isinstance(stream_pos, int) 267: assert isinstance(stream_pos, int) synapse/replication/tcp/external_cache.py 133: if isinstance(result, int): synapse/metrics/__init__.py 100: if isinstance(calls, (int, float)): synapse/handlers/appservice.py 262: assert isinstance(new_token, int) synapse/config/_util.py 62: if isinstance(p, int): ``` which cover metrics, logic related to `jsonschema`, and replication and data streams. AFAICS these are all internal to Synapse * Changelog |
||
---|---|---|
.. | ||
__init__.py | ||
__main__.py | ||
_base.py | ||
_base.pyi | ||
_util.py | ||
account_validity.py | ||
api.py | ||
appservice.py | ||
auth.py | ||
background_updates.py | ||
cache.py | ||
captcha.py | ||
cas.py | ||
consent.py | ||
database.py | ||
emailconfig.py | ||
experimental.py | ||
federation.py | ||
homeserver.py | ||
jwt.py | ||
key.py | ||
logger.py | ||
metrics.py | ||
modules.py | ||
oembed.py | ||
oidc.py | ||
password_auth_providers.py | ||
push.py | ||
ratelimiting.py | ||
redis.py | ||
registration.py | ||
repository.py | ||
retention.py | ||
room_directory.py | ||
room.py | ||
saml2.py | ||
server_notices.py | ||
server.py | ||
spam_checker.py | ||
sso.py | ||
stats.py | ||
third_party_event_rules.py | ||
tls.py | ||
tracer.py | ||
user_directory.py | ||
voip.py | ||
workers.py |