synapse-product/synapse/http
Richard van der Hoff 2ec8ca5e60
Remove SynapseRequest.get_user_agent (#9069)
SynapseRequest is in danger of becoming a bit of a dumping-ground for "useful stuff relating to Requests",
which isn't really its intention (its purpose is to override render, finished and connectionLost to set up the 
LoggingContext and write the right entries to the request log).

Putting utility functions inside SynapseRequest means that lots of our code ends up requiring a
SynapseRequest when there is nothing synapse-specific about the Request at all, and any old
twisted.web.iweb.IRequest will do. This increases code coupling and makes testing more difficult.

In short: move get_user_agent out to a utility function.
2021-01-12 12:34:16 +00:00
..
federation Add a maximum size for well-known lookups. (#8950) 2020-12-16 17:25:24 -05:00
__init__.py Remove SynapseRequest.get_user_agent (#9069) 2021-01-12 12:34:16 +00:00
additional_resource.py Merge different Resource implementation classes (#7732) 2020-07-03 19:02:19 +01:00
client.py Add a maximum size for well-known lookups. (#8950) 2020-12-16 17:25:24 -05:00
connectproxyclient.py Stop sub-classing object (#8249) 2020-09-04 06:54:56 -04:00
endpoint.py Run Black. (#5482) 2019-06-20 19:32:02 +10:00
matrixfederationclient.py Add a maximum size for well-known lookups. (#8950) 2020-12-16 17:25:24 -05:00
proxyagent.py Fix handling of connection timeouts in outgoing http requests (#8400) 2020-09-29 10:29:21 +01:00
request_metrics.py Fix typos and spelling errors. (#8639) 2020-10-23 12:38:40 -04:00
server.py Fix buglet in DirectRenderJsonResource (#8897) 2020-12-10 12:42:55 +00:00
servlet.py Remove unused OPTIONS handlers. (#8621) 2020-10-22 08:35:55 -04:00
site.py Remove SynapseRequest.get_user_agent (#9069) 2021-01-12 12:34:16 +00:00