Matrix-Mirrors/synapse-product
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse-product.git synced 2024-12-17 23:04:24 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix b'GET' in prometheus metrics (#7503)

Browse Source
This commit is contained in:
Richard van der Hoff 2020-05-14 17:01:34 +01:00 committed by GitHub
parent 225c165087
commit eafd103fc7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/7503.bugfix Normal file
View File

@ -0,0 +1 @@
Fix incorrect `method` label on `synapse_http_matrixfederationclient_{requests,responses}` prometheus metrics.

6
synapse/http/matrixfederationclient.py
View File

@ -408,7 +408,7 @@ class MatrixFederationHttpClient(object):
_sec_timeout, _sec_timeout,
) )
outgoing_requests_counter.labels(method_bytes).inc() outgoing_requests_counter.labels(request.method).inc()
try: try:
with Measure(self.clock, "outbound_request"): with Measure(self.clock, "outbound_request"):
@ -434,7 +434,9 @@ class MatrixFederationHttpClient(object):
logger.info("Failed to send request: %s", e) logger.info("Failed to send request: %s", e)
raise_from(RequestSendFailed(e, can_retry=True), e) raise_from(RequestSendFailed(e, can_retry=True), e)
incoming_responses_counter.labels(method_bytes, response.code).inc() incoming_responses_counter.labels(
request.method, response.code
).inc()
set_tag(tags.HTTP_STATUS_CODE, response.code) set_tag(tags.HTTP_STATUS_CODE, response.code)