Merge pull request #1183 from matrix-org/erikj/fix_email_update

Fix user_threepids schema delta
This commit is contained in:
Erik Johnston 2016-10-27 14:48:30 +01:00 committed by GitHub
commit e438699c59

View File

@ -17,7 +17,36 @@
* Update any email addresses that were stored with mixed case into all * Update any email addresses that were stored with mixed case into all
* lowercase * lowercase
*/ */
UPDATE user_threepids SET address = LOWER(address) where medium = 'email';
-- There may be "duplicate" emails (with different case) already in the table,
-- so we find them and move all but the most recently used account.
UPDATE user_threepids
SET medium = 'email_old'
WHERE medium = 'email'
AND address IN (
-- We select all the addresses that are linked to the user_id that is NOT
-- the most recently created.
SELECT u.address
FROM
user_threepids AS u,
-- `duplicate_addresses` is a table of all the email addresses that
-- appear multiple times and when the binding was created
(
SELECT lower(u1.address) AS address, max(u1.added_at) AS max_ts
FROM user_threepids AS u1
INNER JOIN user_threepids AS u2 ON u1.medium = u2.medium AND lower(u1.address) = lower(u2.address) AND u1.address != u2.address
WHERE u1.medium = 'email' AND u2.medium = 'email'
GROUP BY lower(u1.address)
) AS duplicate_addresses
WHERE
lower(u.address) = duplicate_addresses.address
AND u.added_at != max_ts -- NOT the most recently created
);
-- This update is now safe since we've removed the duplicate addresses.
UPDATE user_threepids SET address = LOWER(address) WHERE medium = 'email';
/* Add an index for the select we do on passwored reset */ /* Add an index for the select we do on passwored reset */
CREATE INDEX user_threepids_medium_address on user_threepids (medium, address); CREATE INDEX user_threepids_medium_address on user_threepids (medium, address);