Merge pull request #5793 from matrix-org/erikj/fix_bg_update

Don't recreate current_state_events.membership column
This commit is contained in:
Brendan Abolivier 2019-07-30 21:19:39 +02:00 committed by GitHub
commit d4f91e7e9f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 23 additions and 1 deletions

1
changelog.d/5793.misc Normal file
View File

@ -0,0 +1 @@
Reduce database IO usage by optimising queries for current membership.

View File

@ -0,0 +1,22 @@
/* Copyright 2019 The Matrix.org Foundation C.I.C.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-- We add membership to current state so that we don't need to join against
-- room_memberships, which can be surprisingly costly (we do such queries
-- very frequently).
-- This will be null for non-membership events and the content.membership key
-- for membership events. (Will also be null for membership events until the
-- background update job has finished).
ALTER TABLE current_state_events ADD membership TEXT;

View File

@ -19,7 +19,6 @@
-- This will be null for non-membership events and the content.membership key -- This will be null for non-membership events and the content.membership key
-- for membership events. (Will also be null for membership events until the -- for membership events. (Will also be null for membership events until the
-- background update job has finished). -- background update job has finished).
ALTER TABLE current_state_events ADD membership TEXT;
INSERT INTO background_updates (update_name, progress_json) VALUES INSERT INTO background_updates (update_name, progress_json) VALUES
('current_state_events_membership', '{}'); ('current_state_events_membership', '{}');