From cb12a377082f2241ee8a8280810e9e38fb69778d Mon Sep 17 00:00:00 2001
From: Erik Johnston <erik@matrix.org>
Date: Thu, 14 Feb 2019 18:16:32 +0000
Subject: [PATCH] Clarify and fix behaviour when there are multiple aliases

---
 synapse/config/room_directory.py    | 22 +++++++++++++++++-----
 tests/config/test_room_directory.py |  6 ++++++
 2 files changed, 23 insertions(+), 5 deletions(-)

diff --git a/synapse/config/room_directory.py b/synapse/config/room_directory.py
index 719892be7..af84adf5f 100644
--- a/synapse/config/room_directory.py
+++ b/synapse/config/room_directory.py
@@ -58,7 +58,11 @@ class RoomDirectoryConfig(Config):
         # which rooms can be published in the public room list.
         #
         # The format of this option is the same as that for
-        # `alias_creation_rules`
+        # `alias_creation_rules`.
+        #
+        # If the room has one or more aliases associated with it, the rules are
+        # run against each alias. If there are no aliases then only rules with
+        # `alias: *` match.
         room_list_publication_rules:
             - user_id: "*"    # Matches against the user publishing the room
               alias: "*"      # Matches against any current local or canonical
@@ -156,11 +160,19 @@ class _RoomDirectoryRule(object):
 
         # If we are not given any aliases then this rule only matches if the
         # alias glob matches all aliases
-        if not aliases and not self._alias_matches_all:
-            return False
+        matched = False
+        if not aliases:
+            if not self._alias_matches_all:
+                return False
+        else:
+            # Otherwise, we just need one alias to match
+            matched = False
+            for alias in aliases:
+                if self._alias_regex.match(alias):
+                    matched = True
+                    break
 
-        for alias in aliases:
-            if not self._alias_regex.match(alias):
+            if not matched:
                 return False
 
         if not self._room_id_regex.match(room_id):
diff --git a/tests/config/test_room_directory.py b/tests/config/test_room_directory.py
index 1d4ca0055..3dc263152 100644
--- a/tests/config/test_room_directory.py
+++ b/tests/config/test_room_directory.py
@@ -138,3 +138,9 @@ class RoomDirectoryConfigTestCase(unittest.TestCase):
             room_id="!test-deny",
             aliases=[],
         ))
+
+        self.assertTrue(rd_config.is_publishing_room_allowed(
+            user_id="@test:example.com",
+            room_id="!test",
+            aliases=["#unofficial_st:example.com", "#blah:example.com"],
+        ))