Matrix-Mirrors/synapse-product
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse-product.git synced 2025-07-11 23:19:20 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix stacktraces when using ObservableDeferred and async/await (#6836)

Browse source
This commit is contained in:
Erik Johnston 2020-02-03 17:10:54 +00:00 • committed by GitHub
parent 370080531e
commit ae5b3104f0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/6836.misc Normal file
View file

@ -0,0 +1 @@
Fix stacktraces when using `ObservableDeferred` and async/await.

4
synapse/util/async_helpers.py
View file

@ -73,6 +73,10 @@ class ObservableDeferred(object):
def errback(f): def errback(f):
object.__setattr__(self, "_result", (False, f)) object.__setattr__(self, "_result", (False, f))
while self._observers: while self._observers:
# This is a little bit of magic to correctly propagate stack
# traces when we `await` on one of the observer deferreds.
f.value.__failure__ = f
try: try:
# TODO: Handle errors here. # TODO: Handle errors here.
self._observers.pop().errback(f) self._observers.pop().errback(f)