Review comments

This commit is contained in:
Erik Johnston 2019-06-27 16:06:23 +01:00
parent 82028d723b
commit 729f5a4fb6
2 changed files with 5 additions and 7 deletions

View File

@ -1089,9 +1089,9 @@ class SyncHandler(object):
# for anymore. # for anymore.
# #
# For the first step we check: # For the first step we check:
# 1. if any users we share a room with have updated their devices, # a. if any users we share a room with have updated their devices,
# and # and
# 2. we also check if we've joined any new rooms, or if a user has # b. we also check if we've joined any new rooms, or if a user has
# joined a room we're in. # joined a room we're in.
# #
# For the second step we just find any users we no longer share a # For the second step we just find any users we no longer share a
@ -1102,12 +1102,12 @@ class SyncHandler(object):
user_id user_id
) )
# Step 1, check for changes in devices of users we share a room with # Step 1a, check for changes in devices of users we share a room with
users_that_have_changed = yield self.store.get_users_whose_devices_changed( users_that_have_changed = yield self.store.get_users_whose_devices_changed(
since_token.device_list_key, users_who_share_room since_token.device_list_key, users_who_share_room
) )
# Step 2, check for newly joined rooms # Step 1b, check for newly joined rooms
for room_id in newly_joined_rooms: for room_id in newly_joined_rooms:
joined_users = yield self.state.get_current_users_in_room(room_id) joined_users = yield self.state.get_current_users_in_room(room_id)
newly_joined_or_invited_users.update(joined_users) newly_joined_or_invited_users.update(joined_users)

View File

@ -425,9 +425,7 @@ class DeviceWorkerStore(SQLBaseStore):
""" """
for chunk in batch_iter(to_check, 100): for chunk in batch_iter(to_check, 100):
txn.execute( txn.execute(sql % (",".join("?" for _ in chunk),), (from_key,) + chunk)
sql % (",".join("?" for _ in chunk),), [from_key] + list(chunk)
)
changes.update(user_id for user_id, in txn) changes.update(user_id for user_id, in txn)
return changes return changes